Received: (at 70271) by debbugs.gnu.org; 8 Apr 2024 11:25:22 +0000 From debbugs-submit-bounces <at> debbugs.gnu.org Mon Apr 08 07:25:22 2024 Received: from localhost ([127.0.0.1]:45395 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from <debbugs-submit-bounces <at> debbugs.gnu.org>) id 1rtn7p-0002gT-00 for submit <at> debbugs.gnu.org; Mon, 08 Apr 2024 07:25:21 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]:55332) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from <eliz@HIDDEN>) id 1rtn7m-0002fq-Al for 70271 <at> debbugs.gnu.org; Mon, 08 Apr 2024 07:25:18 -0400 Received: from fencepost.gnu.org ([2001:470:142:3::e]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from <eliz@HIDDEN>) id 1rtn7Z-0005bO-5p; Mon, 08 Apr 2024 07:25:05 -0400 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=gnu.org; s=fencepost-gnu-org; h=References:Subject:In-Reply-To:To:From:Date: mime-version; bh=LF3U6BG9qnooZrf0IJ2XLwQZwfV0yE0/qxQhXnhW1fA=; b=QucsjbTAHbfF fd2dlW7L3HlPEujK6ged5nmMH+yGV6RprNVp61krGVrSqnu2tq0SGwlXd3CJMU61/+TwKigMV0Vy/ x8uGW9+Mnt70ZOTxASKLMsSmeuT0y37WapmUvQo+JXFkRhPq9XjocfE1qLPLYV1n+VGoixuTeCq/a 1biNUYhyM2jov0YaWDs5rpJ4xJALAzhAclrzyoC5GlNRu05ShndgtuVXx0Nlub267E+cxmc3jfIcG 155LOIbrUkQAHxSwKpz4VZCiMcAs7n2YFzq4rAJinqejB5Sq7z6bglMks+JTMwI1Cc/nAyUqqdoc/ CUn5fVJsPo08EIvg+IAovQ==; Date: Mon, 08 Apr 2024 14:25:02 +0300 Message-Id: <86bk6kyu41.fsf@HIDDEN> From: Eli Zaretskii <eliz@HIDDEN> To: Lin Sun <sunlin7.mail@HIDDEN> In-Reply-To: <CABCREdrp7ArT1y7k_=ATrdH5F2qKpS86KK5b4K53P8v5VxYzhA@HIDDEN> (message from Lin Sun on Mon, 8 Apr 2024 05:10:22 +0000) Subject: Re: bug#70271: 30.0.50; [PATCH] * lisp/ls-lisp.el (ls-lisp--sanitize-switches): support more References: <CABCREdrp7ArT1y7k_=ATrdH5F2qKpS86KK5b4K53P8v5VxYzhA@HIDDEN> X-Spam-Score: -2.3 (--) X-Debbugs-Envelope-To: 70271 Cc: 70271 <at> debbugs.gnu.org X-BeenThere: debbugs-submit <at> debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: <debbugs-submit.debbugs.gnu.org> List-Unsubscribe: <https://debbugs.gnu.org/cgi-bin/mailman/options/debbugs-submit>, <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=unsubscribe> List-Archive: <https://debbugs.gnu.org/cgi-bin/mailman/private/debbugs-submit/> List-Post: <mailto:debbugs-submit <at> debbugs.gnu.org> List-Help: <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=help> List-Subscribe: <https://debbugs.gnu.org/cgi-bin/mailman/listinfo/debbugs-submit>, <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=subscribe> Errors-To: debbugs-submit-bounces <at> debbugs.gnu.org Sender: "Debbugs-submit" <debbugs-submit-bounces <at> debbugs.gnu.org> X-Spam-Score: -3.3 (---) > From: Lin Sun <sunlin7.mail@HIDDEN> > Date: Mon, 8 Apr 2024 05:10:22 +0000 > > The dired ignored the options like "--time=ctime" in the variable > `dired-listing-switches' on Windows OS. > > I traced the code and found dired will use the functions in the > `ls-lisp.el' instead of calling the real command "/usr/bin/ls", and > the "ls-lisp.el" didn't process the "--time=ctime" option. > > The attached PATCH will convert the "--time=ctime" to "-c"... in the > "ls-lisp.el", and then the dired will display the desired time in its > time column. > > Here is the verification code (on Windows OS), try it one line and > close the dired buffer then try next line. > > (dired "/tmp/aa" "-al --sort=time") ; as "-al -t" > > (dired "/tmp/aa" "-al --time=ctime") ; as "al -c" > > (dired "/tmp/aa" "-al --time=atime") ; as "al -u" > > Please help review the changes and approve them. Thanks Thanks, but how about adding some tests for this?
bug-gnu-emacs@HIDDEN:bug#70271; Package emacs.
Full text available.Received: (at submit) by debbugs.gnu.org; 8 Apr 2024 05:10:53 +0000 From debbugs-submit-bounces <at> debbugs.gnu.org Mon Apr 08 01:10:53 2024 Received: from localhost ([127.0.0.1]:45095 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from <debbugs-submit-bounces <at> debbugs.gnu.org>) id 1rthHR-0005ki-Bq for submit <at> debbugs.gnu.org; Mon, 08 Apr 2024 01:10:53 -0400 Received: from lists.gnu.org ([2001:470:142::17]:44366) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from <sunlin7.mail@HIDDEN>) id 1rthHP-0005jy-2h for submit <at> debbugs.gnu.org; Mon, 08 Apr 2024 01:10:51 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from <sunlin7.mail@HIDDEN>) id 1rthHC-0004Tc-G6 for bug-gnu-emacs@HIDDEN; Mon, 08 Apr 2024 01:10:38 -0400 Received: from mail-ej1-x62a.google.com ([2a00:1450:4864:20::62a]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from <sunlin7.mail@HIDDEN>) id 1rthHA-0005aC-NB for bug-gnu-emacs@HIDDEN; Mon, 08 Apr 2024 01:10:38 -0400 Received: by mail-ej1-x62a.google.com with SMTP id a640c23a62f3a-a465ddc2c09so291592766b.2 for <bug-gnu-emacs@HIDDEN>; Sun, 07 Apr 2024 22:10:36 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1712553034; x=1713157834; darn=gnu.org; h=to:subject:message-id:date:from:mime-version:from:to:cc:subject :date:message-id:reply-to; bh=Ud4SLej7ntHard8KkXxAun9LpmpKCr+c0EssnSBNalk=; b=UzaRQyGOHOuZ2B/ZH3+08LicUzljVtCaxxb7Ie4AkLdrg1ot9qbrYoCwygLMnZ7afd AXxyYUSAGR07H2pvUjgcfoI3nLGsS1V/jBj0k13ecjEWfALR2kkHMoGO8jdJpTrE8uOf 2pZ8FBIF6yZ3+THYtHB1U2Yo628HCIAARJ7dR/5l22zAO1R2KSxNFNaCCZ4ISdr3744S 8c1s9p8uTBMeTHgrO63H9LS+SVRiLSdG3Z9OvknYW1H4DHO48Mi0Rc27jb5SCz2c8MN2 lKQOkZy3hRMWEB6ruboKgiAT8H1m+SqF+cVXEQ3zvwyXe1+lQwXNaRLbX2zbPvdjzFF5 0Ctw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1712553034; x=1713157834; h=to:subject:message-id:date:from:mime-version:x-gm-message-state :from:to:cc:subject:date:message-id:reply-to; bh=Ud4SLej7ntHard8KkXxAun9LpmpKCr+c0EssnSBNalk=; b=L9DxxeZ7P7Y2uq3IegzyRjzBQbnrc7NlVcdC7nFzmgb50pEPVAC16kEq683vI4VODi qDcZwFUbN9UJZ8E9VrFV1HQEBrjTUG1K+ciWfWgJYRAR3ANNMek+MbvCgJizndiLu3LL Mv8XxsS9Ywgtr1H9El3O/84DWbRMgZUWlYhJ19aHdFmNTOPhuqfpx5wkb8jrzHJCmAPk aEjD+S/UDvWwKU8OCkNZFjfXmoUpY1FZ2T15PTwxQSckxV5cFVXR8dFJQA+h5t3FRD31 ItWcOoA6s5DvN92E8Id1+9ipunHuY+UIhen2a3C5HQOpXe9CjRfWM9iX7iz4efT4x/e+ zYyw== X-Gm-Message-State: AOJu0YzxoX1FrZLX92eXFSddZMu6joRuwm8wT+GvgXPoTH8TqkstCypj 67nIrs08ujvJOgI2ar1803+x1RDveorkEFuV+0KUhsISvrMqN+7VNI9TkfUA49H6SV4qQ7/Vu2O Xair4V1T8sp8/WWCDYnch9unEuZQLsHstvS4= X-Google-Smtp-Source: AGHT+IGD8mHTlCUMo+BjjOjjIP8Kwfv8Mcgf6Og4RfCv4tK7Dw8qf68YZykpxC0l/CSQKhAzX/nB7RBTS5+F8FcQRXY= X-Received: by 2002:a50:aad0:0:b0:56e:57f9:8c83 with SMTP id r16-20020a50aad0000000b0056e57f98c83mr2236632edc.19.1712553034103; Sun, 07 Apr 2024 22:10:34 -0700 (PDT) MIME-Version: 1.0 From: Lin Sun <sunlin7.mail@HIDDEN> Date: Mon, 8 Apr 2024 05:10:22 +0000 Message-ID: <CABCREdrp7ArT1y7k_=ATrdH5F2qKpS86KK5b4K53P8v5VxYzhA@HIDDEN> Subject: 30.0.50; [PATCH] * lisp/ls-lisp.el (ls-lisp--sanitize-switches): support more To: bug-gnu-emacs@HIDDEN Content-Type: multipart/mixed; boundary="00000000000041d7cb06158ed36a" Received-SPF: pass client-ip=2a00:1450:4864:20::62a; envelope-from=sunlin7.mail@HIDDEN; helo=mail-ej1-x62a.google.com X-Spam_score_int: -20 X-Spam_score: -2.1 X-Spam_bar: -- X-Spam_report: (-2.1 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, FREEMAIL_FROM=0.001, RCVD_IN_DNSWL_NONE=-0.0001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-Spam-Score: 1.0 (+) X-Debbugs-Envelope-To: submit X-BeenThere: debbugs-submit <at> debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: <debbugs-submit.debbugs.gnu.org> List-Unsubscribe: <https://debbugs.gnu.org/cgi-bin/mailman/options/debbugs-submit>, <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=unsubscribe> List-Archive: <https://debbugs.gnu.org/cgi-bin/mailman/private/debbugs-submit/> List-Post: <mailto:debbugs-submit <at> debbugs.gnu.org> List-Help: <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=help> List-Subscribe: <https://debbugs.gnu.org/cgi-bin/mailman/listinfo/debbugs-submit>, <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=subscribe> Errors-To: debbugs-submit-bounces <at> debbugs.gnu.org Sender: "Debbugs-submit" <debbugs-submit-bounces <at> debbugs.gnu.org> X-Spam-Score: -0.0 (/) --00000000000041d7cb06158ed36a Content-Type: text/plain; charset="UTF-8" Hi, The dired ignored the options like "--time=ctime" in the variable `dired-listing-switches' on Windows OS. I traced the code and found dired will use the functions in the `ls-lisp.el' instead of calling the real command "/usr/bin/ls", and the "ls-lisp.el" didn't process the "--time=ctime" option. The attached PATCH will convert the "--time=ctime" to "-c"... in the "ls-lisp.el", and then the dired will display the desired time in its time column. Here is the verification code (on Windows OS), try it one line and close the dired buffer then try next line. (dired "/tmp/aa" "-al --sort=time") ; as "-al -t" (dired "/tmp/aa" "-al --time=ctime") ; as "al -c" (dired "/tmp/aa" "-al --time=atime") ; as "al -u" Please help review the changes and approve them. Thanks --00000000000041d7cb06158ed36a Content-Type: text/x-patch; charset="US-ASCII"; name="0001-lisp-ls-lisp.el-ls-lisp-sanitize-switches-support-mo.patch" Content-Disposition: attachment; filename="0001-lisp-ls-lisp.el-ls-lisp-sanitize-switches-support-mo.patch" Content-Transfer-Encoding: base64 Content-ID: <f_luqhuhe30> X-Attachment-Id: f_luqhuhe30 RnJvbSAyMDQ0YmUwOTM1N2M0NmFmMTNlZDM0MWJhZmJjYzU3MzdiZDQwYzQyIE1vbiBTZXAgMTcg MDA6MDA6MDAgMjAwMQpGcm9tOiBMaW4gU3VuIDxzdW5saW43QGhvdG1haWwuY29tPgpEYXRlOiBN b24sIDggQXByIDIwMjQgMDY6NTk6MjEgKzAwMDAKU3ViamVjdDogW1BBVENIXSAqIGxpc3AvbHMt bGlzcC5lbCAobHMtbGlzcC0tc2FuaXRpemUtc3dpdGNoZXMpOiBzdXBwb3J0IG1vcmUKIHRpbWUg b3B0aW9ucwoKLS0tCiBsaXNwL2xzLWxpc3AuZWwgfCAzICsrKwogMSBmaWxlIGNoYW5nZWQsIDMg aW5zZXJ0aW9ucygrKQoKZGlmZiAtLWdpdCBhL2xpc3AvbHMtbGlzcC5lbCBiL2xpc3AvbHMtbGlz cC5lbAppbmRleCBkMDliNTNiMWNjLi5hZTRhNDM3OTdmIDEwMDY0NAotLS0gYS9saXNwL2xzLWxp c3AuZWwKKysrIGIvbGlzcC9scy1saXNwLmVsCkBAIC04NzMsNiArODczLDcgQEAgbHMtbGlzcC0t c2FuaXRpemUtc3dpdGNoZXMKICAgKGxldCAoKGxzZmxhZ3MgJygoIi1hIiAuICItLWFsbCIpCiAg ICAgICAgICAgICAgICAgICAgKCItQSIgLiAiLS1hbG1vc3QtYWxsIikKICAgICAgICAgICAgICAg ICAgICAoIi1CIiAuICItLWlnbm9yZS1iYWNrdXBzIikKKyAgICAgICAgICAgICAgICAgICAoIi1j IiAuICItLXRpbWU9Y3RpbWUiKQogICAgICAgICAgICAgICAgICAgICgiLUMiIC4gIi0tY29sb3Ii KQogICAgICAgICAgICAgICAgICAgICgiLUYiIC4gIi0tY2xhc3NpZnkiKQogICAgICAgICAgICAg ICAgICAgICgiLUciIC4gIi0tbm8tZ3JvdXAiKQpAQCAtODgzLDcgKzg4NCw5IEBAIGxzLWxpc3At LXNhbml0aXplLXN3aXRjaGVzCiAgICAgICAgICAgICAgICAgICAgKCItciIgLiAiLS1yZXZlcnNl IikKICAgICAgICAgICAgICAgICAgICAoIi1SIiAuICItLXJlY3Vyc2l2ZSIpCiAgICAgICAgICAg ICAgICAgICAgKCItcyIgLiAiLS1zaXplIikKKyAgICAgICAgICAgICAgICAgICAoIi10IiAuICIt LXNvcnQ9dGltZSIpCiAgICAgICAgICAgICAgICAgICAgKCItUyIgLiAiLS1zb3J0LipbIFxcXHRd IikKKyAgICAgICAgICAgICAgICAgICAoIi11IiAuICItLXRpbWU9YXRpbWUiKQogICAgICAgICAg ICAgICAgICAgICgiIiAgIC4gIi0tZ3JvdXAtZGlyZWN0b3JpZXMtZmlyc3QiKQogICAgICAgICAg ICAgICAgICAgICgiIiAgIC4gIi0tYXV0aG9yIikKICAgICAgICAgICAgICAgICAgICAoIiIgICAu ICItLWVzY2FwZSIpCi0tIAoyLjIwLjUKCg== --00000000000041d7cb06158ed36a--
Lin Sun <sunlin7.mail@HIDDEN>:bug-gnu-emacs@HIDDEN.
Full text available.bug-gnu-emacs@HIDDEN:bug#70271; Package emacs.
Full text available.
GNU bug tracking system
Copyright (C) 1999 Darren O. Benham,
1997 nCipher Corporation Ltd,
1994-97 Ian Jackson.