Received: (at 70361) by debbugs.gnu.org; 13 Apr 2024 09:33:38 +0000 From debbugs-submit-bounces <at> debbugs.gnu.org Sat Apr 13 05:33:38 2024 Received: from localhost ([127.0.0.1]:60146 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from <debbugs-submit-bounces <at> debbugs.gnu.org>) id 1rvZlQ-0006x7-M5 for submit <at> debbugs.gnu.org; Sat, 13 Apr 2024 05:33:38 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]:54694) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from <eliz@HIDDEN>) id 1rvZlO-0006vl-N2 for 70361 <at> debbugs.gnu.org; Sat, 13 Apr 2024 05:33:36 -0400 Received: from fencepost.gnu.org ([2001:470:142:3::e]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from <eliz@HIDDEN>) id 1rvZl8-0008FQ-S1; Sat, 13 Apr 2024 05:33:18 -0400 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=gnu.org; s=fencepost-gnu-org; h=References:Subject:In-Reply-To:To:From:Date: mime-version; bh=S0FgjfWgdZd1T6MVXNQYYokwv3E9lBhPZxwL9H8tt/U=; b=GvDT1HwwY+lC zf0v9wCDJhrfm4qyIdP0v+ZhHRT8oOHjQOQ9V0lWByE2Ny/eJH3d2mF0mzapJLHJs40I9dIv1+Rhk ruuXjkrl74IyCyr5JnEi7XCM5B+fOFVezEUkHPivmpLtnNchgdpX5l3aADvllCd05Us8GMOE4+djL dS45/ohpcU86kMtjB6+hs3P+a3KxNmrG2NcNU2wLY1NOE4cx6GEctDvTvZtY1pv0r498kJyOpPcOl NKFTNtSAxUQTZLszChcSbK4CNxBCOxUrswEAhZrB9cgFa18Gj0Fk8aqbrRPFdw6/NR56iJCRi/axu Xc/+eojq0unuYlmNw+JDrQ==; Date: Sat, 13 Apr 2024 12:33:15 +0300 Message-Id: <86sezpppyc.fsf@HIDDEN> From: Eli Zaretskii <eliz@HIDDEN> To: Noah Peart <noah.v.peart@HIDDEN> In-Reply-To: <CAPVBTSccb5e=pU1c9YSgoh828Wy5ey7zpzR80MSMxpL+GSRGrQ@HIDDEN> (message from Noah Peart on Sat, 13 Apr 2024 00:53:45 -0700) Subject: Re: bug#70361: [PATCH] Add font-locking for operators in go-ts-mode. References: <CAPVBTScmTQ_jXt483miDqyRsivrLWtXU9g7gztFP=aZO5XHrBQ@HIDDEN> <86r0f9ranr.fsf@HIDDEN> <CAPVBTSd-xydnydn+DvqqTQpPJ5Dg=9K0TZaeH5gJ7Nd03SK+Dg@HIDDEN> <CAPVBTSejO+khsA6+RKbJ8FD5aOMnP5PxxViLgrCtMdQhguismw@HIDDEN> <86mspxr9ra.fsf@HIDDEN> <CAPVBTSccb5e=pU1c9YSgoh828Wy5ey7zpzR80MSMxpL+GSRGrQ@HIDDEN> X-Spam-Score: -2.3 (--) X-Debbugs-Envelope-To: 70361 Cc: 70361 <at> debbugs.gnu.org, casouri@HIDDEN X-BeenThere: debbugs-submit <at> debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: <debbugs-submit.debbugs.gnu.org> List-Unsubscribe: <https://debbugs.gnu.org/cgi-bin/mailman/options/debbugs-submit>, <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=unsubscribe> List-Archive: <https://debbugs.gnu.org/cgi-bin/mailman/private/debbugs-submit/> List-Post: <mailto:debbugs-submit <at> debbugs.gnu.org> List-Help: <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=help> List-Subscribe: <https://debbugs.gnu.org/cgi-bin/mailman/listinfo/debbugs-submit>, <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=subscribe> Errors-To: debbugs-submit-bounces <at> debbugs.gnu.org Sender: "Debbugs-submit" <debbugs-submit-bounces <at> debbugs.gnu.org> X-Spam-Score: -3.3 (---) > From: Noah Peart <noah.v.peart@HIDDEN> > Date: Sat, 13 Apr 2024 00:53:45 -0700 > Cc: Yuan Fu <casouri@HIDDEN>, 70361 <at> debbugs.gnu.org > > > What problems do you see with the current approach that would require > more fine-grained user control? > > The main issue for me is removing the `error` feature from any mode > that adds it with `:override t`. I find the override font-locking is jarring - in some > Languages half the buffer can switch in and out of parse errors when you > do something as simple as removing a closing paren. Maybe we should have a user option to turn error feature on and off. Yuan, WDYT? > Also, allowing users to rearrange features at different levels seems like a bonus. Not sure about this one. We didn't have that in the traditional font-lock, did we?
bug-gnu-emacs@HIDDEN:bug#70361; Package emacs.
Full text available.Received: (at 70361) by debbugs.gnu.org; 13 Apr 2024 07:54:18 +0000 From debbugs-submit-bounces <at> debbugs.gnu.org Sat Apr 13 03:54:17 2024 Received: from localhost ([127.0.0.1]:60023 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from <debbugs-submit-bounces <at> debbugs.gnu.org>) id 1rvYDH-00065q-N7 for submit <at> debbugs.gnu.org; Sat, 13 Apr 2024 03:54:17 -0400 Received: from mail-oa1-x34.google.com ([2001:4860:4864:20::34]:54720) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from <noah.v.peart@HIDDEN>) id 1rvYDF-00064T-0i for 70361 <at> debbugs.gnu.org; Sat, 13 Apr 2024 03:54:14 -0400 Received: by mail-oa1-x34.google.com with SMTP id 586e51a60fabf-23333dddd8aso973397fac.1 for <70361 <at> debbugs.gnu.org>; Sat, 13 Apr 2024 00:54:02 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1712994837; x=1713599637; darn=debbugs.gnu.org; h=cc:to:subject:message-id:date:from:in-reply-to:references :mime-version:from:to:cc:subject:date:message-id:reply-to; bh=Gjo9EnM8t0pAUFOPmuT/DntwbAB4UjW15SmyLeAAJ28=; b=AM3XXUTUIRUgBcvAqD5b5yLOeKEVOvi0dYA788DBvTZTjXKsq+vJeMqMph5nZSYnvg VgQYawe43e95Yuqryc2DUVg8sRIx9ILlJtSsd7Y8XCpU7fQcA6/4zsp3nwb8noBX1TZF mVNN99sIbhfJtLVpR7xZZD4GfLJUwEotNkoBpH+vR19opUnEvKxWJHHE8iCSSL4ZsGx3 9kWwVFXPR9jPTiy+kf8Sbari9WIJCH8HRDUJE6ehwJLtZFjXHQg8wLBMrXhD4I6OUNwf 9T+1Kr0z5JK6KwSdFWJ9AhUPOUjMi1xABmBUG7qeo2exyztkWPncrmt7lWS4lqLmAwv4 NIFA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1712994837; x=1713599637; h=cc:to:subject:message-id:date:from:in-reply-to:references :mime-version:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=Gjo9EnM8t0pAUFOPmuT/DntwbAB4UjW15SmyLeAAJ28=; b=Jh8XO7DgrTc3KK6epnZBVNhCJkrEWZO61tIEz48FdGJzMJK2ZopUskk3X2ZQRn3FV7 BXJGVvr5mMNSqkgWZWipar71szXRoegbK0sYgTyJ2jQCT8551tyRJuyiYqrB1qZ3HUFv jRfyWvTpbY7QncZKK9dMRhrjEhij5GaEXgQc5Zid8ANbfCAiK/ge/DnSgOROhipHAHg9 uDW9WqKuvX/OnRzXYc46eZ+rmhEVUiVOZqPbEcXRuFApEXlWYzOEgwrRAuPGXcIn715h Q6WyktGc+x3ClOvFG4aLUewEG+aO1H76kOI4OEr3+p0bo6swv2/bE14JCi62BPJpWViQ vpxg== X-Forwarded-Encrypted: i=1; AJvYcCXIdEzgEbsNe2Nb62ENnulpEr+sDgWW1zos2El6Rhbtid2vqHMelpLIYmKQWihDMPqUB4I6EQlaBPe0ifKSvLoIouyJAao= X-Gm-Message-State: AOJu0YyuOuHZAVuaUz9umh5gTP1UxiMO+2FBR8OFrhVwcY9h0UxAXCyG XhiXp5JXG1AOvApUHHkl3JmFMk/ZhttqlD/NMjzimPBRdF+ePDvv2mdUnRIQhHjLo0Jo+j4ycsQ FXJqTh41D1+QSJqvCCKnrw/vFWGZILHj9kDMzIQ== X-Google-Smtp-Source: AGHT+IFxp4ZdDo/fvqJ7Ju+0kT+JjNZjFXMLLIKLn/2iatEWI9KNFmswM/mgbFa5yGiRVk8Ou4Alm73UsUyN5/wy8RQ= X-Received: by 2002:a05:6870:b68d:b0:22e:bc50:3492 with SMTP id cy13-20020a056870b68d00b0022ebc503492mr5037006oab.47.1712994836769; Sat, 13 Apr 2024 00:53:56 -0700 (PDT) MIME-Version: 1.0 References: <CAPVBTScmTQ_jXt483miDqyRsivrLWtXU9g7gztFP=aZO5XHrBQ@HIDDEN> <86r0f9ranr.fsf@HIDDEN> <CAPVBTSd-xydnydn+DvqqTQpPJ5Dg=9K0TZaeH5gJ7Nd03SK+Dg@HIDDEN> <CAPVBTSejO+khsA6+RKbJ8FD5aOMnP5PxxViLgrCtMdQhguismw@HIDDEN> <86mspxr9ra.fsf@HIDDEN> In-Reply-To: <86mspxr9ra.fsf@HIDDEN> From: Noah Peart <noah.v.peart@HIDDEN> Date: Sat, 13 Apr 2024 00:53:45 -0700 Message-ID: <CAPVBTSccb5e=pU1c9YSgoh828Wy5ey7zpzR80MSMxpL+GSRGrQ@HIDDEN> Subject: Re: bug#70361: [PATCH] Add font-locking for operators in go-ts-mode. To: Eli Zaretskii <eliz@HIDDEN> Content-Type: multipart/alternative; boundary="000000000000bf73490615f5b03d" X-Spam-Score: 0.0 (/) X-Debbugs-Envelope-To: 70361 Cc: 70361 <at> debbugs.gnu.org, Yuan Fu <casouri@HIDDEN> X-BeenThere: debbugs-submit <at> debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: <debbugs-submit.debbugs.gnu.org> List-Unsubscribe: <https://debbugs.gnu.org/cgi-bin/mailman/options/debbugs-submit>, <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=unsubscribe> List-Archive: <https://debbugs.gnu.org/cgi-bin/mailman/private/debbugs-submit/> List-Post: <mailto:debbugs-submit <at> debbugs.gnu.org> List-Help: <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=help> List-Subscribe: <https://debbugs.gnu.org/cgi-bin/mailman/listinfo/debbugs-submit>, <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=subscribe> Errors-To: debbugs-submit-bounces <at> debbugs.gnu.org Sender: "Debbugs-submit" <debbugs-submit-bounces <at> debbugs.gnu.org> X-Spam-Score: -1.0 (-) --000000000000bf73490615f5b03d Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable > What problems do you see with the current approach that would require more fine-grained user control? The main issue for me is removing the `error` feature from any mode that adds it with `:override t`. I find the override font-locking is jarring - in some Languages half the buffer can switch in and out of parse errors when you do something as simple as removing a closing paren. Also, allowing users to rearrange features at different levels seems like a bonus. > And why do you think a defvar is the proper way of providing such control= ? You're right, I don't think it's the best way - it's just what I've been doing in treesit modes I've written till now. On Sat, Apr 13, 2024 at 12:40=E2=80=AFAM Eli Zaretskii <eliz@HIDDEN> wrote= : > > From: Noah Peart <noah.v.peart@HIDDEN> > > Date: Sat, 13 Apr 2024 00:32:59 -0700 > > Cc: 70361 <at> debbugs.gnu.org > > > > On a somewhat related note, I was wondering why the treesit modes in > emacs > > define their `treesit-font-lock-feature-list`s in the mode definitions. > > > > Wouldn't it be more user-friendly to `defvar` the feature list? > > AFAIR, we do that in the mode's settings because the translation of > general categories into mode-specific settings is not easy, and > because we want users to control that via the fontification level, not > below that. > > What problems do you see with the current approach that would require > more fine-grained user control? And why do you think a defvar is the > proper way of providing such control? > --000000000000bf73490615f5b03d Content-Type: text/html; charset="UTF-8" Content-Transfer-Encoding: quoted-printable <div dir=3D"ltr">> What problems do you see with the current approach th= at would require<br>more fine-grained user control?<div><br></div><div>The = main issue for me is removing the `error` feature from any mode</div><div>t= hat adds it with `:override t`. I find the override font-locking is jarring= - in some</div><div>Languages half the buffer can switch in and out of par= se errors when you</div><div>do something as simple as removing a closing p= aren.</div><div><br></div><div>Also, allowing users to rearrange features a= t different levels seems like a bonus.</div><div><br></div><div>> And wh= y do you think a defvar is the proper way of providing such control?</div><= div><br></div><div>You're right, I don't think it's the best wa= y - it's just what I've been doing in</div><div>treesit=C2=A0modes = I've written till now.</div></div><br><div class=3D"gmail_quote"><div d= ir=3D"ltr" class=3D"gmail_attr">On Sat, Apr 13, 2024 at 12:40=E2=80=AFAM El= i Zaretskii <<a href=3D"mailto:eliz@HIDDEN">eliz@HIDDEN</a>> wrote:= <br></div><blockquote class=3D"gmail_quote" style=3D"margin:0px 0px 0px 0.8= ex;border-left:1px solid rgb(204,204,204);padding-left:1ex">> From: Noah= Peart <<a href=3D"mailto:noah.v.peart@HIDDEN" target=3D"_blank">noah= .v.peart@HIDDEN</a>><br> > Date: Sat, 13 Apr 2024 00:32:59 -0700<br> > Cc: <a href=3D"mailto:70361 <at> debbugs.gnu.org" target=3D"_blank">70361@d= ebbugs.gnu.org</a><br> > <br> > On a somewhat related note, I was wondering why the treesit modes in e= macs<br> > define their `treesit-font-lock-feature-list`s in the mode definitions= .<br> > <br> > Wouldn't it be more user-friendly to `defvar` the feature list?<br= > <br> AFAIR, we do that in the mode's settings because the translation of<br> general categories into mode-specific settings is not easy, and<br> because we want users to control that via the fontification level, not<br> below that.<br> <br> What problems do you see with the current approach that would require<br> more fine-grained user control?=C2=A0 And why do you think a defvar is the<= br> proper way of providing such control?<br> </blockquote></div> --000000000000bf73490615f5b03d--
bug-gnu-emacs@HIDDEN:bug#70361; Package emacs.
Full text available.Received: (at 70361) by debbugs.gnu.org; 13 Apr 2024 07:40:38 +0000 From debbugs-submit-bounces <at> debbugs.gnu.org Sat Apr 13 03:40:38 2024 Received: from localhost ([127.0.0.1]:59988 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from <debbugs-submit-bounces <at> debbugs.gnu.org>) id 1rvY05-00041i-Kl for submit <at> debbugs.gnu.org; Sat, 13 Apr 2024 03:40:37 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]:52388) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from <eliz@HIDDEN>) id 1rvY02-00040N-Re for 70361 <at> debbugs.gnu.org; Sat, 13 Apr 2024 03:40:35 -0400 Received: from fencepost.gnu.org ([2001:470:142:3::e]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from <eliz@HIDDEN>) id 1rvXzn-0002t8-4o; Sat, 13 Apr 2024 03:40:19 -0400 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=gnu.org; s=fencepost-gnu-org; h=References:Subject:In-Reply-To:To:From:Date: mime-version; bh=KRvwhjkrNlA0aT6vrNpksgDsyXSrSHc99qR8PZriLnc=; b=fSNM7QUgW1hs gU8F2gZRmBEjDtic4WJPp9xIR3sq3DHkcUKXsrnU7/weJs7Rf9k6qmsvinISWHQpzcRb4A3lMk6au EaQdAAgKIFSuqIp5IJYoR60B/sH7s84K9frKAFiQxCsa5SnR5QKwhWJhASkE1JgQ3neOGIYZjWIEF ais6fa5eemwJ4TTOHuZmcEaIINFh+IQCHbUYfgNFPC0UGo8r20ltHlz67wll4laPtDEAW1s1ZDDeA OSM+x1iZPK4N8a/WbdgjVCkyrfE7ZVW3tTC5Rb2zhWrj2XU6QFnTTtQ2o5D90Q8huCKOySYus7w8R eRlzoNgP1/GDBj72YCkYtQ==; Date: Sat, 13 Apr 2024 10:40:09 +0300 Message-Id: <86mspxr9ra.fsf@HIDDEN> From: Eli Zaretskii <eliz@HIDDEN> To: Noah Peart <noah.v.peart@HIDDEN>, Yuan Fu <casouri@HIDDEN> In-Reply-To: <CAPVBTSejO+khsA6+RKbJ8FD5aOMnP5PxxViLgrCtMdQhguismw@HIDDEN> (message from Noah Peart on Sat, 13 Apr 2024 00:32:59 -0700) Subject: Re: bug#70361: [PATCH] Add font-locking for operators in go-ts-mode. References: <CAPVBTScmTQ_jXt483miDqyRsivrLWtXU9g7gztFP=aZO5XHrBQ@HIDDEN> <86r0f9ranr.fsf@HIDDEN> <CAPVBTSd-xydnydn+DvqqTQpPJ5Dg=9K0TZaeH5gJ7Nd03SK+Dg@HIDDEN> <CAPVBTSejO+khsA6+RKbJ8FD5aOMnP5PxxViLgrCtMdQhguismw@HIDDEN> X-Spam-Score: -2.3 (--) X-Debbugs-Envelope-To: 70361 Cc: 70361 <at> debbugs.gnu.org X-BeenThere: debbugs-submit <at> debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: <debbugs-submit.debbugs.gnu.org> List-Unsubscribe: <https://debbugs.gnu.org/cgi-bin/mailman/options/debbugs-submit>, <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=unsubscribe> List-Archive: <https://debbugs.gnu.org/cgi-bin/mailman/private/debbugs-submit/> List-Post: <mailto:debbugs-submit <at> debbugs.gnu.org> List-Help: <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=help> List-Subscribe: <https://debbugs.gnu.org/cgi-bin/mailman/listinfo/debbugs-submit>, <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=subscribe> Errors-To: debbugs-submit-bounces <at> debbugs.gnu.org Sender: "Debbugs-submit" <debbugs-submit-bounces <at> debbugs.gnu.org> X-Spam-Score: -3.3 (---) > From: Noah Peart <noah.v.peart@HIDDEN> > Date: Sat, 13 Apr 2024 00:32:59 -0700 > Cc: 70361 <at> debbugs.gnu.org > > On a somewhat related note, I was wondering why the treesit modes in emacs > define their `treesit-font-lock-feature-list`s in the mode definitions. > > Wouldn't it be more user-friendly to `defvar` the feature list? AFAIR, we do that in the mode's settings because the translation of general categories into mode-specific settings is not easy, and because we want users to control that via the fontification level, not below that. What problems do you see with the current approach that would require more fine-grained user control? And why do you think a defvar is the proper way of providing such control?
bug-gnu-emacs@HIDDEN:bug#70361; Package emacs.
Full text available.Received: (at 70361) by debbugs.gnu.org; 13 Apr 2024 07:33:31 +0000 From debbugs-submit-bounces <at> debbugs.gnu.org Sat Apr 13 03:33:31 2024 Received: from localhost ([127.0.0.1]:59979 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from <debbugs-submit-bounces <at> debbugs.gnu.org>) id 1rvXtB-0002ze-Hy for submit <at> debbugs.gnu.org; Sat, 13 Apr 2024 03:33:31 -0400 Received: from mail-oo1-xc29.google.com ([2607:f8b0:4864:20::c29]:46456) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from <noah.v.peart@HIDDEN>) id 1rvXt9-0002yH-47 for 70361 <at> debbugs.gnu.org; Sat, 13 Apr 2024 03:33:28 -0400 Received: by mail-oo1-xc29.google.com with SMTP id 006d021491bc7-5aa26990d5aso1125499eaf.1 for <70361 <at> debbugs.gnu.org>; Sat, 13 Apr 2024 00:33:16 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1712993591; x=1713598391; darn=debbugs.gnu.org; h=cc:to:subject:message-id:date:from:in-reply-to:references :mime-version:from:to:cc:subject:date:message-id:reply-to; bh=M1wLszlEjjpnogH1qOUuhsEDCGWqLOFhGUEjNK4cap8=; b=lhoUizwfE0cNo9gxGDy6Iu1U6+TGkcGsgkkgH6LWU6MLnY4MHnYwurscvIUiN3Visd D00aGMuAh+R6Eo9fBdP7Mo5AUSr1vpkpkKrcmZ0lIXQT0HI9fHbOw4AzSpjY77Qd6yTj woQ0vEd54SaMI9NEH3CvPnJNmZ2KoZbIpxHgcwKpd5Ntfkjwh/d4qTNUvSvH284ry/eq Gz2YA46cfAO9Gc/5PNDfikyPqlBe6b6llYyTY7rtwzrbuP4Uf74WxJfYzMxkJf5TfIsq WmOLyaHD4h/asB/p44iSosJ/FAzvGt4PiacJvUvVGRBG9x/3tmPhe0db36Fmfw/mIqWf oUqw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1712993591; x=1713598391; h=cc:to:subject:message-id:date:from:in-reply-to:references :mime-version:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=M1wLszlEjjpnogH1qOUuhsEDCGWqLOFhGUEjNK4cap8=; b=GXTAdP3Fq518W6oROlCpkR2e+tnUafqy9uvDaR6xILleQlsG5dszZXJme4In7r3QBs Zv4MZxJU/UEkLefl259WDygUEWlAwtLV8H3WR/ehJ7YrMy4CH7MAz7+BpKULj0OZUC6M Z8Ho0TFczcMNQwET+wnP6UgmCtqKlRDHDpSx8+2u8U7IZEpsnnYP+Z1xMgGBuuizwwlF JEPPwA8jjrPxa7Y9ibGmhz1k5ujIlxdPgwaSgw8JHu9NQcofhSCKL54+Ugto/4eAdQ68 nbsgFHCJF3pD8QatFvvdXm6KUAKreNne7k7DS5hicFrthGY5HZf61O2wYc31iGdaOaf+ QLPg== X-Gm-Message-State: AOJu0YyW66T2FwW2Ve3z2OJBw7tJc05/oV1+8iHuTCR7lEpZJRts1jkU 3fwmd3RLt0+/wtfW18sisRnWt7NtnblQfB5n9j45/vxDUvW1rybhVyqnX8/YHcm6SseCk1K7QJg ssIAlD/9UumxNmtyy66kir30bZIepYzJra1U= X-Google-Smtp-Source: AGHT+IFtoHo3oD3SuM5oexIB6QF6blW0sXtf7tI5PIrvAqI8vAllwCCUZqmcuIe/rcHLdbSxalYGHPqVN0BsFAIuJrU= X-Received: by 2002:a05:6870:e09:b0:22e:d13b:c13d with SMTP id mp9-20020a0568700e0900b0022ed13bc13dmr5525010oab.18.1712993591000; Sat, 13 Apr 2024 00:33:11 -0700 (PDT) MIME-Version: 1.0 References: <CAPVBTScmTQ_jXt483miDqyRsivrLWtXU9g7gztFP=aZO5XHrBQ@HIDDEN> <86r0f9ranr.fsf@HIDDEN> <CAPVBTSd-xydnydn+DvqqTQpPJ5Dg=9K0TZaeH5gJ7Nd03SK+Dg@HIDDEN> In-Reply-To: <CAPVBTSd-xydnydn+DvqqTQpPJ5Dg=9K0TZaeH5gJ7Nd03SK+Dg@HIDDEN> From: Noah Peart <noah.v.peart@HIDDEN> Date: Sat, 13 Apr 2024 00:32:59 -0700 Message-ID: <CAPVBTSejO+khsA6+RKbJ8FD5aOMnP5PxxViLgrCtMdQhguismw@HIDDEN> Subject: Re: bug#70361: [PATCH] Add font-locking for operators in go-ts-mode. To: Eli Zaretskii <eliz@HIDDEN> Content-Type: multipart/alternative; boundary="0000000000007e86b80615f5668f" X-Spam-Score: 0.0 (/) X-Debbugs-Envelope-To: 70361 Cc: 70361 <at> debbugs.gnu.org X-BeenThere: debbugs-submit <at> debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: <debbugs-submit.debbugs.gnu.org> List-Unsubscribe: <https://debbugs.gnu.org/cgi-bin/mailman/options/debbugs-submit>, <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=unsubscribe> List-Archive: <https://debbugs.gnu.org/cgi-bin/mailman/private/debbugs-submit/> List-Post: <mailto:debbugs-submit <at> debbugs.gnu.org> List-Help: <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=help> List-Subscribe: <https://debbugs.gnu.org/cgi-bin/mailman/listinfo/debbugs-submit>, <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=subscribe> Errors-To: debbugs-submit-bounces <at> debbugs.gnu.org Sender: "Debbugs-submit" <debbugs-submit-bounces <at> debbugs.gnu.org> X-Spam-Score: -1.0 (-) --0000000000007e86b80615f5668f Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable On a somewhat related note, I was wondering why the treesit modes in emacs define their `treesit-font-lock-feature-list`s in the mode definitions. Wouldn't it be more user-friendly to `defvar` the feature list? On Sat, Apr 13, 2024 at 12:27=E2=80=AFAM Noah Peart <noah.v.peart@HIDDEN= > wrote: > > The operators will be fontified only if treesit-font-lock-level is 4, > right? > > Yea, operator is at level 4 - I didn't change the > treesit-font-lock-feature-list. > > > > On Sat, Apr 13, 2024 at 12:20=E2=80=AFAM Eli Zaretskii <eliz@HIDDEN> wro= te: > >> > From: Noah Peart <noah.v.peart@HIDDEN> >> > Date: Fri, 12 Apr 2024 22:23:05 -0700 >> > >> > Adds font-locking for Go operators in `go-ts-mode'. The operator featu= re >> > is already added to `treesit-font-lock-feature-list' in `go-ts-mode` - >> this >> > just adds the missing rule to `go-ts-mode--font-lock-settings'. >> >> Thanks. >> >> The operators will be fontified only if treesit-font-lock-level is 4, >> right? That's the level at which we decided to fontify operators. >> > --0000000000007e86b80615f5668f Content-Type: text/html; charset="UTF-8" Content-Transfer-Encoding: quoted-printable <div dir=3D"ltr">On a somewhat related note, I was wondering why the treesi= t=C2=A0modes in emacs<div>define their `treesit-font-lock-feature-list`s in= the mode definitions.</div><div><br></div><div>Wouldn't it be more use= r-friendly to `defvar` the feature list?</div></div><br><div class=3D"gmail= _quote"><div dir=3D"ltr" class=3D"gmail_attr">On Sat, Apr 13, 2024 at 12:27= =E2=80=AFAM Noah Peart <<a href=3D"mailto:noah.v.peart@HIDDEN">noah.v= .peart@HIDDEN</a>> wrote:<br></div><blockquote class=3D"gmail_quote" = style=3D"margin:0px 0px 0px 0.8ex;border-left:1px solid rgb(204,204,204);pa= dding-left:1ex"><div dir=3D"ltr">> The operators will be fontified only = if treesit-font-lock-level is 4,<br>right?<div><br></div><div>Yea, operator= is at level 4 - I didn't change the treesit-font-lock-feature-list.</d= iv><div><br></div><div><br></div></div><br><div class=3D"gmail_quote"><div = dir=3D"ltr" class=3D"gmail_attr">On Sat, Apr 13, 2024 at 12:20=E2=80=AFAM E= li Zaretskii <<a href=3D"mailto:eliz@HIDDEN" target=3D"_blank">eliz@gnu= .org</a>> wrote:<br></div><blockquote class=3D"gmail_quote" style=3D"mar= gin:0px 0px 0px 0.8ex;border-left:1px solid rgb(204,204,204);padding-left:1= ex">> From: Noah Peart <<a href=3D"mailto:noah.v.peart@HIDDEN" tar= get=3D"_blank">noah.v.peart@HIDDEN</a>><br> > Date: Fri, 12 Apr 2024 22:23:05 -0700<br> > <br> > Adds font-locking for Go operators in `go-ts-mode'. The operator f= eature<br> > is already added to `treesit-font-lock-feature-list' in `go-ts-mod= e` - this<br> > just adds the missing rule to `go-ts-mode--font-lock-settings'.<br= > <br> Thanks.<br> <br> The operators will be fontified only if treesit-font-lock-level is 4,<br> right?=C2=A0 That's the level at which we decided to fontify operators.= <br> </blockquote></div> </blockquote></div> --0000000000007e86b80615f5668f--
bug-gnu-emacs@HIDDEN:bug#70361; Package emacs.
Full text available.Received: (at 70361) by debbugs.gnu.org; 13 Apr 2024 07:27:59 +0000 From debbugs-submit-bounces <at> debbugs.gnu.org Sat Apr 13 03:27:58 2024 Received: from localhost ([127.0.0.1]:59969 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from <debbugs-submit-bounces <at> debbugs.gnu.org>) id 1rvXnp-0002Ay-7k for submit <at> debbugs.gnu.org; Sat, 13 Apr 2024 03:27:58 -0400 Received: from mail-oa1-x2f.google.com ([2001:4860:4864:20::2f]:47158) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from <noah.v.peart@HIDDEN>) id 1rvXnl-00029a-Q5 for 70361 <at> debbugs.gnu.org; Sat, 13 Apr 2024 03:27:55 -0400 Received: by mail-oa1-x2f.google.com with SMTP id 586e51a60fabf-22f32226947so959408fac.2 for <70361 <at> debbugs.gnu.org>; Sat, 13 Apr 2024 00:27:43 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1712993258; x=1713598058; darn=debbugs.gnu.org; h=cc:to:subject:message-id:date:from:in-reply-to:references :mime-version:from:to:cc:subject:date:message-id:reply-to; bh=yc8N19Esjv2DIT9rKBv5xYuG5rbN26BjBW/F0JFei/o=; b=NZQWAUbEHdZgE14Hlb3pC+QlFzc7XNnTDHJEt9YTVTGoSAeXttAUPfKpgbQf18cyEg 4KwixPWzdVH/wgiGuNTpcK/WaRAeufSKIKdVs+2kcv8xvLzGTfDj3SuMm1GGUVoH+wc2 g3AUz66qk/6fu8ssXr664pFDh6S8SOy5flE7UDZwPvMGSsWQianW7T2aX9rPUevTS/En Qhfpu3NHNH5uvSL2bh5lzeFUxhm0S9CPD0KLaXWWxi4BudM34Ss/690CRzIyDcsi2OFT i+uNqNRINFvNmq2AoJEG5FhxgjWZjMAIuSqr2wwJ0h+mRbRbF0Vwjrvb5Q/ypdMybYRk Wcfg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1712993258; x=1713598058; h=cc:to:subject:message-id:date:from:in-reply-to:references :mime-version:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=yc8N19Esjv2DIT9rKBv5xYuG5rbN26BjBW/F0JFei/o=; b=fXwytvSR93gUiK4gQb6L3Ppp4ecZ/60/jUNeSYVnjWB9JooxzpOGJ6ylI3KzC8Q1QH hD9BxFTcOcmSpajqGvJZIG0o6EIc6XGR6CyUFHnLL+BBi4eGK2kTswWz0feE2xxFbNdG hxd2ENvPsOcLPVmcNiEywIaAIqThQlwc4gOWTbujdg+1e+TSsoCIjN4EHBol6pKWdfvw KUGhKUrame4h4nEaO3ZvC6g/tnkCHGnsxRGvJUzphdo0MnuarFqZQ3+zOT0huTED7tdU CtVrKEcwDsf/G7kRTwZZ1vBTdvl4c+bxtPIqITjSxQn/CGv2CHhI6aqHrJRwuWDxZ+K5 CyDA== X-Gm-Message-State: AOJu0YzYg+7bC+vzuk8bJgc5Jf+1FCiyLzOa0WoPX0DMTDTrOtQBa+P5 VEqECevZiu/FQM1j286AiXAl8AjeyUGQ+pm6oEm+a4MM89SRCvsdUsMHs6Lwsu+CLzAjE/uDgBB ZWl2hLDrSh1YWK08gjO1pEHHn3Ks= X-Google-Smtp-Source: AGHT+IGQ+iyBGQvEbUlAO5fgDhCqZoMvQ7BzKS1N8rbatWE1TlACf+UDhOYAksB8/i3KKmMS+Sq7zY1UovoJ99iZdWs= X-Received: by 2002:a05:6870:e09:b0:22e:d13b:c13d with SMTP id mp9-20020a0568700e0900b0022ed13bc13dmr5512501oab.18.1712993257575; Sat, 13 Apr 2024 00:27:37 -0700 (PDT) MIME-Version: 1.0 References: <CAPVBTScmTQ_jXt483miDqyRsivrLWtXU9g7gztFP=aZO5XHrBQ@HIDDEN> <86r0f9ranr.fsf@HIDDEN> In-Reply-To: <86r0f9ranr.fsf@HIDDEN> From: Noah Peart <noah.v.peart@HIDDEN> Date: Sat, 13 Apr 2024 00:27:26 -0700 Message-ID: <CAPVBTSd-xydnydn+DvqqTQpPJ5Dg=9K0TZaeH5gJ7Nd03SK+Dg@HIDDEN> Subject: Re: bug#70361: [PATCH] Add font-locking for operators in go-ts-mode. To: Eli Zaretskii <eliz@HIDDEN> Content-Type: multipart/alternative; boundary="0000000000009edd470615f5526e" X-Spam-Score: 0.0 (/) X-Debbugs-Envelope-To: 70361 Cc: 70361 <at> debbugs.gnu.org X-BeenThere: debbugs-submit <at> debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: <debbugs-submit.debbugs.gnu.org> List-Unsubscribe: <https://debbugs.gnu.org/cgi-bin/mailman/options/debbugs-submit>, <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=unsubscribe> List-Archive: <https://debbugs.gnu.org/cgi-bin/mailman/private/debbugs-submit/> List-Post: <mailto:debbugs-submit <at> debbugs.gnu.org> List-Help: <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=help> List-Subscribe: <https://debbugs.gnu.org/cgi-bin/mailman/listinfo/debbugs-submit>, <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=subscribe> Errors-To: debbugs-submit-bounces <at> debbugs.gnu.org Sender: "Debbugs-submit" <debbugs-submit-bounces <at> debbugs.gnu.org> X-Spam-Score: -1.0 (-) --0000000000009edd470615f5526e Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable > The operators will be fontified only if treesit-font-lock-level is 4, right? Yea, operator is at level 4 - I didn't change the treesit-font-lock-feature-list. On Sat, Apr 13, 2024 at 12:20=E2=80=AFAM Eli Zaretskii <eliz@HIDDEN> wrote= : > > From: Noah Peart <noah.v.peart@HIDDEN> > > Date: Fri, 12 Apr 2024 22:23:05 -0700 > > > > Adds font-locking for Go operators in `go-ts-mode'. The operator featur= e > > is already added to `treesit-font-lock-feature-list' in `go-ts-mode` - > this > > just adds the missing rule to `go-ts-mode--font-lock-settings'. > > Thanks. > > The operators will be fontified only if treesit-font-lock-level is 4, > right? That's the level at which we decided to fontify operators. > --0000000000009edd470615f5526e Content-Type: text/html; charset="UTF-8" Content-Transfer-Encoding: quoted-printable <div dir=3D"ltr">> The operators will be fontified only if treesit-font-= lock-level is 4,<br>right?<div><br></div><div>Yea, operator is at level 4 -= I didn't change the treesit-font-lock-feature-list.</div><div><br></di= v><div><br></div></div><br><div class=3D"gmail_quote"><div dir=3D"ltr" clas= s=3D"gmail_attr">On Sat, Apr 13, 2024 at 12:20=E2=80=AFAM Eli Zaretskii <= ;<a href=3D"mailto:eliz@HIDDEN">eliz@HIDDEN</a>> wrote:<br></div><bloc= kquote class=3D"gmail_quote" style=3D"margin:0px 0px 0px 0.8ex;border-left:= 1px solid rgb(204,204,204);padding-left:1ex">> From: Noah Peart <<a h= ref=3D"mailto:noah.v.peart@HIDDEN" target=3D"_blank">noah.v.peart@gmail.= com</a>><br> > Date: Fri, 12 Apr 2024 22:23:05 -0700<br> > <br> > Adds font-locking for Go operators in `go-ts-mode'. The operator f= eature<br> > is already added to `treesit-font-lock-feature-list' in `go-ts-mod= e` - this<br> > just adds the missing rule to `go-ts-mode--font-lock-settings'.<br= > <br> Thanks.<br> <br> The operators will be fontified only if treesit-font-lock-level is 4,<br> right?=C2=A0 That's the level at which we decided to fontify operators.= <br> </blockquote></div> --0000000000009edd470615f5526e--
bug-gnu-emacs@HIDDEN:bug#70361; Package emacs.
Full text available.Received: (at 70361) by debbugs.gnu.org; 13 Apr 2024 07:21:01 +0000 From debbugs-submit-bounces <at> debbugs.gnu.org Sat Apr 13 03:21:01 2024 Received: from localhost ([127.0.0.1]:59929 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from <debbugs-submit-bounces <at> debbugs.gnu.org>) id 1rvXh6-00018y-1A for submit <at> debbugs.gnu.org; Sat, 13 Apr 2024 03:21:01 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]:57176) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from <eliz@HIDDEN>) id 1rvXh4-00017p-Gm for 70361 <at> debbugs.gnu.org; Sat, 13 Apr 2024 03:20:58 -0400 Received: from fencepost.gnu.org ([2001:470:142:3::e]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from <eliz@HIDDEN>) id 1rvXgo-0007PD-Si; Sat, 13 Apr 2024 03:20:42 -0400 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=gnu.org; s=fencepost-gnu-org; h=References:Subject:In-Reply-To:To:From:Date: mime-version; bh=2hqKefUaGXIh2hOt7XHAuaDa3rfuz7KkIanfj/m1gac=; b=ITGUKz4ew4xW s/CEQfoMFbTEdttiVz8nJ9+tSoJ77p2eB3zz9Venv0wHYXhHZDZzHCDic+Fwnl+lCQQzQM7LD8UCF Jw1+VcWMINqaNrq0eaRPA+ciE065dN5GZk9f9JisP2xP/lRDrJ4Uk/BN5QsYZEvCs1Cc9Hnq+mePL 0unz9Qid6rvlvj2jamfagHKMl99FpBTY8dImYOGG2CWFdbhk8tuXnCoMcyDgyGfiAz1C6VOX0yCiV fvpsiFD5+aBWTRfbYSsVakiKvjz+Pv1MeTOrUzsQMKk3GF2lNEuvOaP8XkPWxtbV08lWTEGMyz49a 9BT39cgChpjZO2tv51WBXw==; Date: Sat, 13 Apr 2024 10:20:40 +0300 Message-Id: <86r0f9ranr.fsf@HIDDEN> From: Eli Zaretskii <eliz@HIDDEN> To: Noah Peart <noah.v.peart@HIDDEN> In-Reply-To: <CAPVBTScmTQ_jXt483miDqyRsivrLWtXU9g7gztFP=aZO5XHrBQ@HIDDEN> (message from Noah Peart on Fri, 12 Apr 2024 22:23:05 -0700) Subject: Re: bug#70361: [PATCH] Add font-locking for operators in go-ts-mode. References: <CAPVBTScmTQ_jXt483miDqyRsivrLWtXU9g7gztFP=aZO5XHrBQ@HIDDEN> X-Spam-Score: -2.3 (--) X-Debbugs-Envelope-To: 70361 Cc: 70361 <at> debbugs.gnu.org X-BeenThere: debbugs-submit <at> debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: <debbugs-submit.debbugs.gnu.org> List-Unsubscribe: <https://debbugs.gnu.org/cgi-bin/mailman/options/debbugs-submit>, <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=unsubscribe> List-Archive: <https://debbugs.gnu.org/cgi-bin/mailman/private/debbugs-submit/> List-Post: <mailto:debbugs-submit <at> debbugs.gnu.org> List-Help: <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=help> List-Subscribe: <https://debbugs.gnu.org/cgi-bin/mailman/listinfo/debbugs-submit>, <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=subscribe> Errors-To: debbugs-submit-bounces <at> debbugs.gnu.org Sender: "Debbugs-submit" <debbugs-submit-bounces <at> debbugs.gnu.org> X-Spam-Score: -3.3 (---) > From: Noah Peart <noah.v.peart@HIDDEN> > Date: Fri, 12 Apr 2024 22:23:05 -0700 > > Adds font-locking for Go operators in `go-ts-mode'. The operator feature > is already added to `treesit-font-lock-feature-list' in `go-ts-mode` - this > just adds the missing rule to `go-ts-mode--font-lock-settings'. Thanks. The operators will be fontified only if treesit-font-lock-level is 4, right? That's the level at which we decided to fontify operators.
bug-gnu-emacs@HIDDEN:bug#70361; Package emacs.
Full text available.Received: (at submit) by debbugs.gnu.org; 13 Apr 2024 05:23:50 +0000 From debbugs-submit-bounces <at> debbugs.gnu.org Sat Apr 13 01:23:49 2024 Received: from localhost ([127.0.0.1]:59827 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from <debbugs-submit-bounces <at> debbugs.gnu.org>) id 1rvVrh-0000Ec-A5 for submit <at> debbugs.gnu.org; Sat, 13 Apr 2024 01:23:49 -0400 Received: from lists.gnu.org ([2001:470:142::17]:55900) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from <noah.v.peart@HIDDEN>) id 1rvVrd-0000Cp-C1 for submit <at> debbugs.gnu.org; Sat, 13 Apr 2024 01:23:47 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from <noah.v.peart@HIDDEN>) id 1rvVrF-0001ok-Is for bug-gnu-emacs@HIDDEN; Sat, 13 Apr 2024 01:23:21 -0400 Received: from mail-oa1-x2d.google.com ([2001:4860:4864:20::2d]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from <noah.v.peart@HIDDEN>) id 1rvVrC-0001b2-I5 for bug-gnu-emacs@HIDDEN; Sat, 13 Apr 2024 01:23:21 -0400 Received: by mail-oa1-x2d.google.com with SMTP id 586e51a60fabf-22edbb5dd40so837853fac.1 for <bug-gnu-emacs@HIDDEN>; Fri, 12 Apr 2024 22:23:17 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1712985796; x=1713590596; darn=gnu.org; h=to:subject:message-id:date:from:mime-version:from:to:cc:subject :date:message-id:reply-to; bh=kD+BILPwFRqE7IqqR03karRCiRUQ9I1EnrhJo3HEY3Y=; b=MqOKiScbiVhBKNwMofbbj35b95rHi7dwD8Ajc+JNTSfHGH8YtV6s5RL3xbJ+lQo3Yw Gwug3l1IYNmyNBUtcK72aHl6+1fKjkaT7O/murC5QHEnwdBvt6Ezq/JUuNrnHVYAVN5F 7l+6h9Pr6CEcSQ3dl+9bBITlkLoRi+Tw7p/PtLEdv10K6RG2aXZNKopgi0pMJB0yN0HC YTMge2m6et6uWKGhyOhM/heAgCmwxxfY05PnnceiINbYp6sFFtSpU2vcN3XGWChXjzDB t/6uBRQ+hk6CxecxBSyv4oiuAD+ss0TfSYl1Ffsfc+NhCkd4EOQ0tgoCsoCxJuhJ+qTC 4ffg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1712985796; x=1713590596; h=to:subject:message-id:date:from:mime-version:x-gm-message-state :from:to:cc:subject:date:message-id:reply-to; bh=kD+BILPwFRqE7IqqR03karRCiRUQ9I1EnrhJo3HEY3Y=; b=n38LXhLzNwqo/lnd9D7GvMOT0g8MN7y/vCAYaj3WjINmhJ3+z+D0MrBq7rH0lrMAeH VUqFM/RHV8348hb35BXkw1KMZQOSgHX+SReYyAdPTkxKcGwkTPDsKX5G/AqaccuAF/PQ XH+0tqzg3rPd3+PcZn8hhY2aEc/dNP2ZEWoRtv3SDLS4R85rJsyk6XmPwms1scmUAwJC PontqftvCohnRL9Xa3pkKs+kR2Lm1lnXwORbQANPgkigvvwY3Ysy6AdKJQ1SgoZSIrxw cw/r5nIz4fNJG9R7SubJA2UNZqWkPqJVlOdPcRUeN7CrF6XeaYavWx0FOi1s9zqjY6HU NpOg== X-Gm-Message-State: AOJu0YykKGolnbeVPoXSstDnM7xreAkAPeJLudwVpv9zjCXZHUO4WDR2 ypxapUyyVj0PsMGnCjkrPRzcmmexY/fsKnBkySbSw3tKCDXv4WOA7cH14YEnwh1v9e8sZsey+ls RHCVr2CYGvNB2t+7tNsajuMBliKjnH9f0OScDdw== X-Google-Smtp-Source: AGHT+IHEBoTGCoB2+ozeHTmvSezIMgSM5yB5sVSWAMMgr6t/QgK0Gx9+eYV4yitAP6xW4a/DiVfbZPRQV4VGzkKH/AU= X-Received: by 2002:a05:6870:a10a:b0:22e:83e8:2f13 with SMTP id m10-20020a056870a10a00b0022e83e82f13mr3099263oae.24.1712985796001; Fri, 12 Apr 2024 22:23:16 -0700 (PDT) MIME-Version: 1.0 From: Noah Peart <noah.v.peart@HIDDEN> Date: Fri, 12 Apr 2024 22:23:05 -0700 Message-ID: <CAPVBTScmTQ_jXt483miDqyRsivrLWtXU9g7gztFP=aZO5XHrBQ@HIDDEN> Subject: [PATCH] Add font-locking for operators in go-ts-mode. To: bug-gnu-emacs@HIDDEN Content-Type: multipart/mixed; boundary="000000000000e05bcb0615f395e7" Received-SPF: pass client-ip=2001:4860:4864:20::2d; envelope-from=noah.v.peart@HIDDEN; helo=mail-oa1-x2d.google.com X-Spam_score_int: -20 X-Spam_score: -2.1 X-Spam_bar: -- X-Spam_report: (-2.1 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, FREEMAIL_FROM=0.001, HTML_MESSAGE=0.001, RCVD_IN_DNSWL_NONE=-0.0001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-Spam-Score: 1.0 (+) X-Debbugs-Envelope-To: submit X-BeenThere: debbugs-submit <at> debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: <debbugs-submit.debbugs.gnu.org> List-Unsubscribe: <https://debbugs.gnu.org/cgi-bin/mailman/options/debbugs-submit>, <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=unsubscribe> List-Archive: <https://debbugs.gnu.org/cgi-bin/mailman/private/debbugs-submit/> List-Post: <mailto:debbugs-submit <at> debbugs.gnu.org> List-Help: <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=help> List-Subscribe: <https://debbugs.gnu.org/cgi-bin/mailman/listinfo/debbugs-submit>, <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=subscribe> Errors-To: debbugs-submit-bounces <at> debbugs.gnu.org Sender: "Debbugs-submit" <debbugs-submit-bounces <at> debbugs.gnu.org> X-Spam-Score: -0.0 (/) --000000000000e05bcb0615f395e7 Content-Type: multipart/alternative; boundary="000000000000e05bc90615f395e5" --000000000000e05bc90615f395e5 Content-Type: text/plain; charset="UTF-8" Tags: patch Adds font-locking for Go operators in `go-ts-mode'. The operator feature is already added to `treesit-font-lock-feature-list' in `go-ts-mode` - this just adds the missing rule to `go-ts-mode--font-lock-settings'. In GNU Emacs 30.0.50 (build 1, x86_64-pc-linux-gnu, GTK+ Version 3.24.33, cairo version 1.16.0) of 2024-04-07 built on noah-X580VD Repository revision: ee377aaddf9d73116b93c3d54b1ffef9a3a8b925 Repository branch: master Windowing system distributor 'The X.Org Foundation', version 11.0.12101004 System Description: Ubuntu 22.04.4 LTS Configured using: 'configure --prefix=/usr/local --with-modules --with-tree-sitter --with-threads --with-x-toolkit=gtk3 --with-xwidgets --with-gnutls --with-json --with-mailutils --with-jpeg --with-png --with-rsvg --with-tiff --with-xml2 --with-xpm --with-imagemagick CC=gcc-12 CXX=gcc-12' --000000000000e05bc90615f395e5 Content-Type: text/html; charset="UTF-8" Content-Transfer-Encoding: quoted-printable <div dir=3D"ltr">Tags: patch<br><br><br>Adds font-locking for Go operators = in `go-ts-mode'. The operator feature<br>is already added to `treesit-f= ont-lock-feature-list' in `go-ts-mode` - this<br>just adds the missing = rule to `go-ts-mode--font-lock-settings'.<br><br><br>In GNU Emacs 30.0.= 50 (build 1, x86_64-pc-linux-gnu, GTK+ Version<br>3.24.33, cairo version 1.= 16.0) of 2024-04-07 built on noah-X580VD<br>Repository revision: ee377aaddf= 9d73116b93c3d54b1ffef9a3a8b925<br>Repository branch: master<br>Windowing sy= stem distributor 'The X.Org Foundation', version 11.0.12101004<br>S= ystem Description: Ubuntu 22.04.4 LTS<br><br>Configured using:<br>=C2=A0= 9;configure --prefix=3D/usr/local --with-modules --with-tree-sitter<br>--wi= th-threads --with-x-toolkit=3Dgtk3 --with-xwidgets --with-gnutls<br>--with-= json --with-mailutils --with-jpeg --with-png --with-rsvg<br>--with-tiff --w= ith-xml2 --with-xpm --with-imagemagick CC=3Dgcc-12<br>CXX=3Dgcc-12'<br>= </div> --000000000000e05bc90615f395e5-- --000000000000e05bcb0615f395e7 Content-Type: text/x-patch; charset="US-ASCII"; name="0001-Add-font-locking-for-operators-in-go-ts-mode.patch" Content-Disposition: attachment; filename="0001-Add-font-locking-for-operators-in-go-ts-mode.patch" Content-Transfer-Encoding: base64 Content-ID: <f_luxnhexb0> X-Attachment-Id: f_luxnhexb0 RnJvbSBmZDM5M2E2MjU5ZTVmMzQ3OWE5ZjI0NDc2NGVmMjZhNzk2NTA1ZTI4IE1vbiBTZXAgMTcg MDA6MDA6MDAgMjAwMQpGcm9tOiBOb2FoIFBlYXJ0IDxub2FoLnYucGVhcnRAZ21haWwuY29tPgpE YXRlOiBGcmksIDEyIEFwciAyMDI0IDIyOjA5OjE3IC0wNzAwClN1YmplY3Q6IFtQQVRDSF0gQWRk IGZvbnQtbG9ja2luZyBmb3Igb3BlcmF0b3JzIGluIGdvLXRzLW1vZGUuCgoqIGxpc3AvcHJvZ21v ZGVzL2dvLXRzLW1vZGUuZWwgKGdvLXRzLW1vZGUtLWZvbnQtbG9jay1zZXR0aW5ncyk6IEFkZApm b250LWxvY2tpbmcgZm9yIEdvIG9wZXJhdG9ycy4KLS0tCiBsaXNwL3Byb2dtb2Rlcy9nby10cy1t b2RlLmVsIHwgNCArKysrCiAxIGZpbGUgY2hhbmdlZCwgNCBpbnNlcnRpb25zKCspCgpkaWZmIC0t Z2l0IGEvbGlzcC9wcm9nbW9kZXMvZ28tdHMtbW9kZS5lbCBiL2xpc3AvcHJvZ21vZGVzL2dvLXRz LW1vZGUuZWwKaW5kZXggY2MzMzA2ODhkYzMuLjdjYTNiZmE1ZTY1IDEwMDY0NAotLS0gYS9saXNw L3Byb2dtb2Rlcy9nby10cy1tb2RlLmVsCisrKyBiL2xpc3AvcHJvZ21vZGVzL2dvLXRzLW1vZGUu ZWwKQEAgLTEzNSw2ICsxMzUsMTAgQEAgZ28tdHMtbW9kZS0tZm9udC1sb2NrLXNldHRpbmdzCiAg ICA6ZmVhdHVyZSAnZGVsaW1pdGVyCiAgICAnKChbIiwiICIuIiAiOyIgIjoiXSkgQGZvbnQtbG9j ay1kZWxpbWl0ZXItZmFjZSkKIAorICAgOmxhbmd1YWdlICdnbworICAgOmZlYXR1cmUgJ29wZXJh dG9yCisgICBgKFssQGdvLXRzLW1vZGUtLW9wZXJhdG9yc10gQGZvbnQtbG9jay1vcGVyYXRvci1m YWNlKQorCiAgICA6bGFuZ3VhZ2UgJ2dvCiAgICA6ZmVhdHVyZSAnZGVmaW5pdGlvbgogICAgJygo ZnVuY3Rpb25fZGVjbGFyYXRpb24KLS0gCjIuMzQuMQoK --000000000000e05bcb0615f395e7--
Noah Peart <noah.v.peart@HIDDEN>:bug-gnu-emacs@HIDDEN.
Full text available.bug-gnu-emacs@HIDDEN:bug#70361; Package emacs.
Full text available.
GNU bug tracking system
Copyright (C) 1999 Darren O. Benham,
1997 nCipher Corporation Ltd,
1994-97 Ian Jackson.