GNU bug report logs - #70362
[PATCH] Add font-locking for Go built-in functions in go-ts-mode

Please note: This is a static page, with minimal formatting, updated once a day.
Click here to see this page with the latest information and nicer formatting.

Package: emacs; Reported by: Noah Peart <noah.v.peart@HIDDEN>; Keywords: patch; Done: Eli Zaretskii <eliz@HIDDEN>; Maintainer for emacs is bug-gnu-emacs@HIDDEN.

Message received at 70362 <at> debbugs.gnu.org:


Received: (at 70362) by debbugs.gnu.org; 18 Apr 2024 14:16:20 +0000
From debbugs-submit-bounces <at> debbugs.gnu.org Thu Apr 18 10:16:20 2024
Received: from localhost ([127.0.0.1]:52659 helo=debbugs.gnu.org)
	by debbugs.gnu.org with esmtp (Exim 4.84_2)
	(envelope-from <debbugs-submit-bounces <at> debbugs.gnu.org>)
	id 1rxSYl-00053Q-Ko
	for submit <at> debbugs.gnu.org; Thu, 18 Apr 2024 10:16:20 -0400
Received: from eggs.gnu.org ([2001:470:142:3::10]:57416)
 by debbugs.gnu.org with esmtp (Exim 4.84_2)
 (envelope-from <eliz@HIDDEN>) id 1rxSYi-00052V-D4
 for 70362 <at> debbugs.gnu.org; Thu, 18 Apr 2024 10:16:17 -0400
Received: from fencepost.gnu.org ([2001:470:142:3::e])
 by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256)
 (Exim 4.90_1) (envelope-from <eliz@HIDDEN>)
 id 1rxSYO-0000A5-7V; Thu, 18 Apr 2024 10:15:56 -0400
DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=gnu.org;
 s=fencepost-gnu-org; h=References:Subject:In-Reply-To:To:From:Date:
 mime-version; bh=ZyFUtdI97j4tLyE3Jaq2qorUdIOAV2WN12oHzHUjI6w=; b=UBpo1G/Ym86M
 j2V6eq5R9MgG/LrymSiLJtuNdUQMqiEekMYtMNm1P3riYpJtIQ2EjiRAt1lOEMO5SbaoaKt6i4ynp
 9DXtOk5IkilUeRwxhd1CfMhws92l91k0QkWbX44/CLx0+bGwRvEelAVYvr4BZNfD/j1wBkRJPZN2L
 cOdcRyauWqrUJcI+YS/WjCXI9F7r3Jy4gVBNDW6Z54YTJZ1BZ98RfJiCaC4UHFqjjBNRiY7QAR3wF
 NbR0Gsmr9znXYUmS3+08uQvgSYA7eYIpseYh5lnIvCGbcUxHAcIcrv3y3B8yxSP8PJChdvc8SbdXm
 /Vpm8E+wN9ZgvIw/ODlUmA==;
Date: Thu, 18 Apr 2024 17:15:22 +0300
Message-Id: <86a5lqeozp.fsf@HIDDEN>
From: Eli Zaretskii <eliz@HIDDEN>
To: Randy Taylor <dev@HIDDEN>
In-Reply-To: <N32PMs79gKrndJdQYBCnV1oOjg_h1Pw56m1vKaVfY5GM-SvuY-8ldoRMuLgP3JvdqjPS6uDX3HzGM2078vxkBeOxQ_dC_yA0bfHOV_WXdSM=@rjt.dev>
 (message from Randy Taylor on Thu, 18 Apr 2024 13:44:56 +0000)
Subject: Re: bug#70362: [PATCH] Add font-locking for Go built-in functions in
 go-ts-mode
References: <CAPVBTSdAEhJoNVzb-Wof++SnwQAhXEFbMc3+D5wD69gKeapjVQ@HIDDEN>
 <25B8E895-4E4B-4D60-BCDC-97A02AD2A1CE@HIDDEN>
 <q2Je4sVKgp_Cyuv71lkaRyVFjnLsNjOEI-WbJLFhWroZgtUph66UYXPVWz-E6r9-mTKnJVE5y1Z9Vz1akNZyz3dIFptd4Qm4vARqfgEvMko=@rjt.dev>
 <86v84fdkrf.fsf@HIDDEN>
 <N32PMs79gKrndJdQYBCnV1oOjg_h1Pw56m1vKaVfY5GM-SvuY-8ldoRMuLgP3JvdqjPS6uDX3HzGM2078vxkBeOxQ_dC_yA0bfHOV_WXdSM=@rjt.dev>
X-Spam-Score: -1.6 (-)
X-Debbugs-Envelope-To: 70362
Cc: noah.v.peart@HIDDEN, casouri@HIDDEN, 70362 <at> debbugs.gnu.org,
 dmitry@HIDDEN
X-BeenThere: debbugs-submit <at> debbugs.gnu.org
X-Mailman-Version: 2.1.18
Precedence: list
List-Id: <debbugs-submit.debbugs.gnu.org>
List-Unsubscribe: <https://debbugs.gnu.org/cgi-bin/mailman/options/debbugs-submit>, 
 <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=unsubscribe>
List-Archive: <https://debbugs.gnu.org/cgi-bin/mailman/private/debbugs-submit/>
List-Post: <mailto:debbugs-submit <at> debbugs.gnu.org>
List-Help: <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=help>
List-Subscribe: <https://debbugs.gnu.org/cgi-bin/mailman/listinfo/debbugs-submit>, 
 <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=subscribe>
Errors-To: debbugs-submit-bounces <at> debbugs.gnu.org
Sender: "Debbugs-submit" <debbugs-submit-bounces <at> debbugs.gnu.org>
X-Spam-Score: -2.6 (--)

> Date: Thu, 18 Apr 2024 13:44:56 +0000
> From: Randy Taylor <dev@HIDDEN>
> Cc: noah.v.peart@HIDDEN, casouri@HIDDEN, dmitry@HIDDEN, 70362 <at> debbugs.gnu.org
> 
> On Thursday, April 18th, 2024 at 06:32, Eli Zaretskii <eliz@HIDDEN> wrote:
> > 
> > > Date: Tue, 16 Apr 2024 00:44:16 +0000
> > 
> > > From: Randy Taylor dev@HIDDEN
> > > Cc: Yuan Fu casouri@HIDDEN, Dmitry Gutov dmitry@HIDDEN, Eli Zaretskii eliz@HIDDEN, 70362 <at> debbugs.gnu.org
> > > 
> > > Thanks for working on this Noah, it looks good to me as well.
> > > 
> > > Perhaps builtin could come before constant in treesit-font-lock-feature-list to keep things alphabetical?
> > 
> > 
> > I've rearranged them, thanks for noticing this.
> 
> Thanks, but I was referring to the treesit-font-lock-feature-list variable (see attached patch), not go-ts-mode--font-lock-settings which is not alphabetized.

Thanks, installed.




Information forwarded to bug-gnu-emacs@HIDDEN:
bug#70362; Package emacs. Full text available.

Message received at 70362 <at> debbugs.gnu.org:


Received: (at 70362) by debbugs.gnu.org; 18 Apr 2024 13:45:31 +0000
From debbugs-submit-bounces <at> debbugs.gnu.org Thu Apr 18 09:45:30 2024
Received: from localhost ([127.0.0.1]:52525 helo=debbugs.gnu.org)
	by debbugs.gnu.org with esmtp (Exim 4.84_2)
	(envelope-from <debbugs-submit-bounces <at> debbugs.gnu.org>)
	id 1rxS4t-0001LI-3W
	for submit <at> debbugs.gnu.org; Thu, 18 Apr 2024 09:45:30 -0400
Received: from mail-4323.proton.ch ([185.70.43.23]:40651)
 by debbugs.gnu.org with esmtp (Exim 4.84_2)
 (envelope-from <dev@HIDDEN>) id 1rxS4n-0001Jc-OO
 for 70362 <at> debbugs.gnu.org; Thu, 18 Apr 2024 09:45:24 -0400
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=rjt.dev;
 s=protonmail2; t=1713447901; x=1713707101;
 bh=VZrxeez4aZnyJkWxX3uvi3aPPXNSNVXn7S0DVgvKpyc=;
 h=Date:To:From:Cc:Subject:Message-ID:In-Reply-To:References:
 Feedback-ID:From:To:Cc:Date:Subject:Reply-To:Feedback-ID:
 Message-ID:BIMI-Selector;
 b=lBVD0GbaycsfrTLbhGqSOgHLNMH0Esv/lbN2VpM/z7w0BRkOFmQY+CidBhQvgcJ+a
 5PStsxeaYMqEojQ1cGJolT+fQXjg3DbHKgGiZjdVnSH6aIuSyQFjl1eGtg59xXwObD
 bdzftgBovnkO7VpnO7UvgQHFyxAVcUB5pkFVDJHDgy3PNXWxUb6Ljkq5EogFvP9Dlh
 YgTrPZjJyKLCSXnTT8Pp9l6Awt8dGZ4JJp1y/Xjqr9+e1tcHplvPSQP1bCrPyEaV7f
 a8qoon3/kch2YXzTXFrOFZNOxcSnTBe1y085EkeyBQ8LLZ3tnOOWjgvB4sdGZELV4+
 NCKhkJxzgoQzQ==
Date: Thu, 18 Apr 2024 13:44:56 +0000
To: Eli Zaretskii <eliz@HIDDEN>
From: Randy Taylor <dev@HIDDEN>
Subject: Re: bug#70362: [PATCH] Add font-locking for Go built-in functions in
 go-ts-mode
Message-ID: <N32PMs79gKrndJdQYBCnV1oOjg_h1Pw56m1vKaVfY5GM-SvuY-8ldoRMuLgP3JvdqjPS6uDX3HzGM2078vxkBeOxQ_dC_yA0bfHOV_WXdSM=@rjt.dev>
In-Reply-To: <86v84fdkrf.fsf@HIDDEN>
References: <CAPVBTSdAEhJoNVzb-Wof++SnwQAhXEFbMc3+D5wD69gKeapjVQ@HIDDEN>
 <25B8E895-4E4B-4D60-BCDC-97A02AD2A1CE@HIDDEN>
 <q2Je4sVKgp_Cyuv71lkaRyVFjnLsNjOEI-WbJLFhWroZgtUph66UYXPVWz-E6r9-mTKnJVE5y1Z9Vz1akNZyz3dIFptd4Qm4vARqfgEvMko=@rjt.dev>
 <86v84fdkrf.fsf@HIDDEN>
Feedback-ID: 44397038:user:proton
X-Pm-Message-ID: 94008b8d7553bc4f1c16f5d07dba4c7b14effe0d
MIME-Version: 1.0
Content-Type: multipart/mixed;
 boundary="b1_dfUVldJZLydHj4iSXwFDeDT0euwYKSvwgyeZEwY8acs"
X-Spam-Score: 0.7 (/)
X-Debbugs-Envelope-To: 70362
Cc: noah.v.peart@HIDDEN, casouri@HIDDEN, 70362 <at> debbugs.gnu.org,
 dmitry@HIDDEN
X-BeenThere: debbugs-submit <at> debbugs.gnu.org
X-Mailman-Version: 2.1.18
Precedence: list
List-Id: <debbugs-submit.debbugs.gnu.org>
List-Unsubscribe: <https://debbugs.gnu.org/cgi-bin/mailman/options/debbugs-submit>, 
 <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=unsubscribe>
List-Archive: <https://debbugs.gnu.org/cgi-bin/mailman/private/debbugs-submit/>
List-Post: <mailto:debbugs-submit <at> debbugs.gnu.org>
List-Help: <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=help>
List-Subscribe: <https://debbugs.gnu.org/cgi-bin/mailman/listinfo/debbugs-submit>, 
 <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=subscribe>
Errors-To: debbugs-submit-bounces <at> debbugs.gnu.org
Sender: "Debbugs-submit" <debbugs-submit-bounces <at> debbugs.gnu.org>
X-Spam-Score: -0.3 (/)

This is a multi-part message in MIME format.

--b1_dfUVldJZLydHj4iSXwFDeDT0euwYKSvwgyeZEwY8acs
Content-Type: text/plain; charset=utf-8
Content-Transfer-Encoding: quoted-printable

On Thursday, April 18th, 2024 at 06:32, Eli Zaretskii <eliz@HIDDEN> wrote:
>=20
> > Date: Tue, 16 Apr 2024 00:44:16 +0000
>=20
> > From: Randy Taylor dev@HIDDEN
> > Cc: Yuan Fu casouri@HIDDEN, Dmitry Gutov dmitry@HIDDEN, Eli Zaret=
skii eliz@HIDDEN, 70362 <at> debbugs.gnu.org
> >=20
> > Thanks for working on this Noah, it looks good to me as well.
> >=20
> > Perhaps builtin could come before constant in treesit-font-lock-feature=
-list to keep things alphabetical?
>=20
>=20
> I've rearranged them, thanks for noticing this.

Thanks, but I was referring to the treesit-font-lock-feature-list variable =
(see attached patch), not go-ts-mode--font-lock-settings which is not alpha=
betized.
--b1_dfUVldJZLydHj4iSXwFDeDT0euwYKSvwgyeZEwY8acs
Content-Type: text/x-patch; name=0001-Alphabetize-go-ts-mode-s-treesit-font-lock-feature-l.patch
Content-Transfer-Encoding: base64
Content-Disposition: attachment; filename=0001-Alphabetize-go-ts-mode-s-treesit-font-lock-feature-l.patch

RnJvbSBlNzdjMTMyZDkzNGFkNjExMTdkNTVhNTU2MmM5Y2YwZGMxZmFlNDdjIE1vbiBTZXAgMTcg
MDA6MDA6MDAgMjAwMQpGcm9tOiBSYW5keSBUYXlsb3IgPGRldkByanQuZGV2PgpEYXRlOiBUaHUs
IDE4IEFwciAyMDI0IDA5OjM4OjI4IC0wNDAwClN1YmplY3Q6IFtQQVRDSF0gOyBBbHBoYWJldGl6
ZSBnby10cy1tb2RlJ3MgdHJlZXNpdC1mb250LWxvY2stZmVhdHVyZS1saXN0CgoqIGxpc3AvcHJv
Z21vZGVzL2dvLXRzLW1vZGUuZWwgKGdvLXRzLW1vZGUpOgpSZWFycmFuZ2UgZmVhdHVyZXMgdG8g
a2VlcCBhbHBoYWJldGljYWwgb3JkZXIuICAoQnVnIzcwMzYyKQotLS0KIGxpc3AvcHJvZ21vZGVz
L2dvLXRzLW1vZGUuZWwgfCAyICstCiAxIGZpbGUgY2hhbmdlZCwgMSBpbnNlcnRpb24oKyksIDEg
ZGVsZXRpb24oLSkKCmRpZmYgLS1naXQgYS9saXNwL3Byb2dtb2Rlcy9nby10cy1tb2RlLmVsIGIv
bGlzcC9wcm9nbW9kZXMvZ28tdHMtbW9kZS5lbAppbmRleCBmMmI1ODZkZmI0My4uYWVmMjI0YWIz
ZmEgMTAwNjQ0Ci0tLSBhL2xpc3AvcHJvZ21vZGVzL2dvLXRzLW1vZGUuZWwKKysrIGIvbGlzcC9w
cm9nbW9kZXMvZ28tdHMtbW9kZS5lbApAQCAtMjg0LDcgKzI4NCw3IEBAIGdvLXRzLW1vZGUKICAg
ICAoc2V0cS1sb2NhbCB0cmVlc2l0LWZvbnQtbG9jay1mZWF0dXJlLWxpc3QKICAgICAgICAgICAg
ICAgICAnKCggY29tbWVudCBkZWZpbml0aW9uKQogICAgICAgICAgICAgICAgICAgKCBrZXl3b3Jk
IHN0cmluZyB0eXBlKQotICAgICAgICAgICAgICAgICAgKCBjb25zdGFudCBlc2NhcGUtc2VxdWVu
Y2UgbGFiZWwgbnVtYmVyIGJ1aWx0aW4pCisgICAgICAgICAgICAgICAgICAoIGJ1aWx0aW4gY29u
c3RhbnQgZXNjYXBlLXNlcXVlbmNlIGxhYmVsIG51bWJlcikKICAgICAgICAgICAgICAgICAgICgg
YnJhY2tldCBkZWxpbWl0ZXIgZXJyb3IgZnVuY3Rpb24gb3BlcmF0b3IgcHJvcGVydHkgdmFyaWFi
bGUpKSkKIAogICAgICh0cmVlc2l0LW1ham9yLW1vZGUtc2V0dXApKSkKLS0gCjIuNDQuMAoK

--b1_dfUVldJZLydHj4iSXwFDeDT0euwYKSvwgyeZEwY8acs--





Information forwarded to bug-gnu-emacs@HIDDEN:
bug#70362; Package emacs. Full text available.

Message received at 70362 <at> debbugs.gnu.org:


Received: (at 70362) by debbugs.gnu.org; 18 Apr 2024 10:33:26 +0000
From debbugs-submit-bounces <at> debbugs.gnu.org Thu Apr 18 06:33:24 2024
Received: from localhost ([127.0.0.1]:51604 helo=debbugs.gnu.org)
	by debbugs.gnu.org with esmtp (Exim 4.84_2)
	(envelope-from <debbugs-submit-bounces <at> debbugs.gnu.org>)
	id 1rxP4x-0000aF-PX
	for submit <at> debbugs.gnu.org; Thu, 18 Apr 2024 06:33:24 -0400
Received: from eggs.gnu.org ([2001:470:142:3::10]:33272)
 by debbugs.gnu.org with esmtp (Exim 4.84_2)
 (envelope-from <eliz@HIDDEN>) id 1rxP4G-0000VQ-H1
 for 70362 <at> debbugs.gnu.org; Thu, 18 Apr 2024 06:32:42 -0400
Received: from fencepost.gnu.org ([2001:470:142:3::e])
 by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256)
 (Exim 4.90_1) (envelope-from <eliz@HIDDEN>)
 id 1rxP3x-0000QG-MD; Thu, 18 Apr 2024 06:32:17 -0400
DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=gnu.org;
 s=fencepost-gnu-org; h=References:Subject:In-Reply-To:To:From:Date:
 mime-version; bh=oLTlrFusPRHwSLSZRe7dLBqiDDJARgRSdSpMvdD/Z+Q=; b=GzBaPgzTjsWr
 ZJ/U+RBONrlXkY33DGXT4tUBqCltG9si3Nr1n13RocEa8EemfwC/MUR7dq0r4+fo+7qJ6YyT+a6zM
 mt51LDy0kAKGFD+VzyVZB225KItyNhfKPdUlMpGeA1ELwvyxE/xFVBP2H0Sfk5pOE46iUWUVZiZwI
 dLxiHDF0OJNP36BAIjoWIIwnAkuBsY3E3P9BuArbz6hqaEsGcwVZ4ycdeTl7DxguGlVqIB0Eqqt4Y
 X1ykgLnlOstMAdNZ3JfmHwjdIu5Dj2gLpDGgVMtWlmswo0SIUiXEC7X9qPkKo7DZJyyXwbFyy1u/E
 V4JLn+ulKCbFAtuV/t3+XQ==;
Date: Thu, 18 Apr 2024 13:32:04 +0300
Message-Id: <86v84fdkrf.fsf@HIDDEN>
From: Eli Zaretskii <eliz@HIDDEN>
To: Randy Taylor <dev@HIDDEN>
In-Reply-To: <q2Je4sVKgp_Cyuv71lkaRyVFjnLsNjOEI-WbJLFhWroZgtUph66UYXPVWz-E6r9-mTKnJVE5y1Z9Vz1akNZyz3dIFptd4Qm4vARqfgEvMko=@rjt.dev>
 (message from Randy Taylor on Tue, 16 Apr 2024 00:44:16 +0000)
Subject: Re: bug#70362: [PATCH] Add font-locking for Go built-in functions in
 go-ts-mode
References: <CAPVBTSdAEhJoNVzb-Wof++SnwQAhXEFbMc3+D5wD69gKeapjVQ@HIDDEN>
 <25B8E895-4E4B-4D60-BCDC-97A02AD2A1CE@HIDDEN>
 <q2Je4sVKgp_Cyuv71lkaRyVFjnLsNjOEI-WbJLFhWroZgtUph66UYXPVWz-E6r9-mTKnJVE5y1Z9Vz1akNZyz3dIFptd4Qm4vARqfgEvMko=@rjt.dev>
X-Spam-Score: -1.6 (-)
X-Debbugs-Envelope-To: 70362
Cc: noah.v.peart@HIDDEN, casouri@HIDDEN, 70362 <at> debbugs.gnu.org,
 dmitry@HIDDEN
X-BeenThere: debbugs-submit <at> debbugs.gnu.org
X-Mailman-Version: 2.1.18
Precedence: list
List-Id: <debbugs-submit.debbugs.gnu.org>
List-Unsubscribe: <https://debbugs.gnu.org/cgi-bin/mailman/options/debbugs-submit>, 
 <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=unsubscribe>
List-Archive: <https://debbugs.gnu.org/cgi-bin/mailman/private/debbugs-submit/>
List-Post: <mailto:debbugs-submit <at> debbugs.gnu.org>
List-Help: <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=help>
List-Subscribe: <https://debbugs.gnu.org/cgi-bin/mailman/listinfo/debbugs-submit>, 
 <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=subscribe>
Errors-To: debbugs-submit-bounces <at> debbugs.gnu.org
Sender: "Debbugs-submit" <debbugs-submit-bounces <at> debbugs.gnu.org>
X-Spam-Score: -2.6 (--)

> Date: Tue, 16 Apr 2024 00:44:16 +0000
> From: Randy Taylor <dev@HIDDEN>
> Cc: Yuan Fu <casouri@HIDDEN>, Dmitry Gutov <dmitry@HIDDEN>, Eli Zaretskii <eliz@HIDDEN>, 70362 <at> debbugs.gnu.org
> 
> Thanks for working on this Noah, it looks good to me as well.
> 
> Perhaps builtin could come before constant in treesit-font-lock-feature-list to keep things alphabetical?

I've rearranged them, thanks for noticing this.




Information forwarded to bug-gnu-emacs@HIDDEN:
bug#70362; Package emacs. Full text available.

Message received at 70362-done <at> debbugs.gnu.org:


Received: (at 70362-done) by debbugs.gnu.org; 18 Apr 2024 10:32:14 +0000
From debbugs-submit-bounces <at> debbugs.gnu.org Thu Apr 18 06:32:12 2024
Received: from localhost ([127.0.0.1]:51591 helo=debbugs.gnu.org)
	by debbugs.gnu.org with esmtp (Exim 4.84_2)
	(envelope-from <debbugs-submit-bounces <at> debbugs.gnu.org>)
	id 1rxP3m-0000TQ-R5
	for submit <at> debbugs.gnu.org; Thu, 18 Apr 2024 06:32:12 -0400
Received: from eggs.gnu.org ([2001:470:142:3::10]:55494)
 by debbugs.gnu.org with esmtp (Exim 4.84_2)
 (envelope-from <eliz@HIDDEN>) id 1rxP3U-0000RD-TR
 for 70362-done <at> debbugs.gnu.org; Thu, 18 Apr 2024 06:32:00 -0400
Received: from fencepost.gnu.org ([2001:470:142:3::e])
 by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256)
 (Exim 4.90_1) (envelope-from <eliz@HIDDEN>)
 id 1rxP3A-0000Av-Vt; Thu, 18 Apr 2024 06:31:29 -0400
DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=gnu.org;
 s=fencepost-gnu-org; h=References:Subject:In-Reply-To:To:From:Date:
 mime-version; bh=PuF87eAGV3tnupi+WY6hqIcQIXHOT2DHh/BVrZN/7Qs=; b=dtehh7ITZLL8
 zzrUX5AKZ0gNiGsRkzrNCmoZkk9jXtJ9b6aArQCgXafYKK4nz7ptA6IZldkGauPpHlPexydsSaBoP
 ldws7rneW3p8gCgzto+wXYD/Dtv8zR0aYDXrW+Ns0KGzMMHQFZOjN2YMCDMWOg+axYl1a6nlxqojN
 Ip3TNBUYkquwOSW0iX/vJ+uK9V4V+SXLbFilqV/vskW3hUmh9KsjGwOgVt9nvT6PUAqMGHN1KKyAN
 jU/yAs4Yj0S1kF/kkedVVNfzIv5RNyEXK7Ooy7TOG7TWp2e28flKUQ/WM7N9aV7FByehKPtyTw6FO
 P4RD6tGd0Lu8HTjZ1QLnOQ==;
Date: Thu, 18 Apr 2024 13:31:25 +0300
Message-Id: <86wmovdksi.fsf@HIDDEN>
From: Eli Zaretskii <eliz@HIDDEN>
To: Yuan Fu <casouri@HIDDEN>
In-Reply-To: <25B8E895-4E4B-4D60-BCDC-97A02AD2A1CE@HIDDEN> (message from
 Yuan Fu on Sun, 14 Apr 2024 16:32:43 -0700)
Subject: Re: bug#70362: [PATCH] Add font-locking for Go built-in functions in
 go-ts-mode
References: <25B8E895-4E4B-4D60-BCDC-97A02AD2A1CE@HIDDEN>
X-Spam-Score: -1.6 (-)
X-Debbugs-Envelope-To: 70362-done
Cc: dmitry@HIDDEN, 70362-done <at> debbugs.gnu.org, noah.v.peart@HIDDEN
X-BeenThere: debbugs-submit <at> debbugs.gnu.org
X-Mailman-Version: 2.1.18
Precedence: list
List-Id: <debbugs-submit.debbugs.gnu.org>
List-Unsubscribe: <https://debbugs.gnu.org/cgi-bin/mailman/options/debbugs-submit>, 
 <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=unsubscribe>
List-Archive: <https://debbugs.gnu.org/cgi-bin/mailman/private/debbugs-submit/>
List-Post: <mailto:debbugs-submit <at> debbugs.gnu.org>
List-Help: <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=help>
List-Subscribe: <https://debbugs.gnu.org/cgi-bin/mailman/listinfo/debbugs-submit>, 
 <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=subscribe>
Errors-To: debbugs-submit-bounces <at> debbugs.gnu.org
Sender: "Debbugs-submit" <debbugs-submit-bounces <at> debbugs.gnu.org>
X-Spam-Score: -2.6 (--)

> From: Yuan Fu <casouri@HIDDEN>
> Date: Sun, 14 Apr 2024 16:32:43 -0700
> Cc: Noah Peart <noah.v.peart@HIDDEN>,
>  Eli Zaretskii <eliz@HIDDEN>,
>  70362 <at> debbugs.gnu.org
> 
> 
> Dmitry Gutov <dmitry@HIDDEN> writes:
> 
> > On 13/04/2024 10:40, Noah Peart wrote:
> >> I put it at level 3 following the conventions in other treesit modes
> >> I checked: python-ts-mode, ruby-ts-mode, rust-ts-mode all put
> >> builtins at level 3.
> >> But, I haven't done a full census of the ts modes so there might be
> >> variability.
> >
> > SGTM. If classic major modes highlight a thing (and they do that for
> > built-ins), we usually put it in the default highlighting for ts modes
> > as well (meaning level 3 or lower).
> 
> Right. And the patch looks good to me.

Thanks, installed on master, and closing the bug.




Notification sent to Noah Peart <noah.v.peart@HIDDEN>:
bug acknowledged by developer. Full text available.
Reply sent to Eli Zaretskii <eliz@HIDDEN>:
You have taken responsibility. Full text available.

Message received at 70362 <at> debbugs.gnu.org:


Received: (at 70362) by debbugs.gnu.org; 16 Apr 2024 00:44:45 +0000
From debbugs-submit-bounces <at> debbugs.gnu.org Mon Apr 15 20:44:44 2024
Received: from localhost ([127.0.0.1]:40580 helo=debbugs.gnu.org)
	by debbugs.gnu.org with esmtp (Exim 4.84_2)
	(envelope-from <debbugs-submit-bounces <at> debbugs.gnu.org>)
	id 1rwWwF-0007MN-4o
	for submit <at> debbugs.gnu.org; Mon, 15 Apr 2024 20:44:44 -0400
Received: from mail-4323.proton.ch ([185.70.43.23]:28805)
 by debbugs.gnu.org with esmtp (Exim 4.84_2)
 (envelope-from <dev@HIDDEN>) id 1rwWwA-0007Ko-KR
 for 70362 <at> debbugs.gnu.org; Mon, 15 Apr 2024 20:44:41 -0400
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=rjt.dev;
 s=protonmail2; t=1713228260; x=1713487460;
 bh=FSRhpFib/Z0Banc75KADDzhqONyKwHTBuVbOuOv3ERA=;
 h=Date:To:From:Cc:Subject:Message-ID:In-Reply-To:References:
 Feedback-ID:From:To:Cc:Date:Subject:Reply-To:Feedback-ID:
 Message-ID:BIMI-Selector;
 b=YodErldPAUQF0Xsm+eK4nJKuGpk7jlmCWuPqHVWct+arrLpCzrxTsPoTl8xvLSyaF
 fewMtoMI37ptks+Wnwj6MjZjThRWCDR/P4Azxm5wF7FqsgZdiRMkgjBRqy4y/gVQpJ
 3Dr76RbqEpu7CHOxozuJDOC+lkh6qzOrUVoMtvm73+7ACaxaIjiri+wi6Ljk8335up
 oW+FIyUC2MvkYlPOCdEHexoZ5S0Hrkfm1vfPJ00yLuOM9+DlnOFrS/vaTTa6cqFoHa
 hS9t9c8zSthhrrAw62k1+WUG+C4PoFEAs/L4jCVO/shR/HNEnS1X++0ztj/fX4yUSJ
 CY6F8ke6VW3kA==
Date: Tue, 16 Apr 2024 00:44:16 +0000
To: Noah Peart <noah.v.peart@HIDDEN>
From: Randy Taylor <dev@HIDDEN>
Subject: Re: bug#70362: [PATCH] Add font-locking for Go built-in functions in
 go-ts-mode
Message-ID: <q2Je4sVKgp_Cyuv71lkaRyVFjnLsNjOEI-WbJLFhWroZgtUph66UYXPVWz-E6r9-mTKnJVE5y1Z9Vz1akNZyz3dIFptd4Qm4vARqfgEvMko=@rjt.dev>
In-Reply-To: <25B8E895-4E4B-4D60-BCDC-97A02AD2A1CE@HIDDEN>
References: <CAPVBTSdAEhJoNVzb-Wof++SnwQAhXEFbMc3+D5wD69gKeapjVQ@HIDDEN>
 <25B8E895-4E4B-4D60-BCDC-97A02AD2A1CE@HIDDEN>
Feedback-ID: 44397038:user:proton
MIME-Version: 1.0
Content-Type: text/plain; charset=utf-8
Content-Transfer-Encoding: quoted-printable
X-Spam-Score: 0.7 (/)
X-Debbugs-Envelope-To: 70362
Cc: Dmitry Gutov <dmitry@HIDDEN>, Yuan Fu <casouri@HIDDEN>,
 70362 <at> debbugs.gnu.org, Eli Zaretskii <eliz@HIDDEN>
X-BeenThere: debbugs-submit <at> debbugs.gnu.org
X-Mailman-Version: 2.1.18
Precedence: list
List-Id: <debbugs-submit.debbugs.gnu.org>
List-Unsubscribe: <https://debbugs.gnu.org/cgi-bin/mailman/options/debbugs-submit>, 
 <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=unsubscribe>
List-Archive: <https://debbugs.gnu.org/cgi-bin/mailman/private/debbugs-submit/>
List-Post: <mailto:debbugs-submit <at> debbugs.gnu.org>
List-Help: <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=help>
List-Subscribe: <https://debbugs.gnu.org/cgi-bin/mailman/listinfo/debbugs-submit>, 
 <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=subscribe>
Errors-To: debbugs-submit-bounces <at> debbugs.gnu.org
Sender: "Debbugs-submit" <debbugs-submit-bounces <at> debbugs.gnu.org>
X-Spam-Score: -0.3 (/)

On Sunday, April 14th, 2024 at 19:32, Yuan Fu <casouri@HIDDEN> wrote:
>=20
> Dmitry Gutov dmitry@HIDDEN writes:
>=20
> > On 13/04/2024 10:40, Noah Peart wrote:
> >=20
> > > I put it at level 3 following the conventions in other treesit modes
> > > I checked: python-ts-mode, ruby-ts-mode, rust-ts-mode all put
> > > builtins at level 3.
> > > But, I haven't done a full census of the ts modes so there might be
> > > variability.
> >=20
> > SGTM. If classic major modes highlight a thing (and they do that for
> > built-ins), we usually put it in the default highlighting for ts modes
> > as well (meaning level 3 or lower).
>=20
>=20
> Right. And the patch looks good to me.
>=20
> Yuan
>=20

Thanks for working on this Noah, it looks good to me as well.

Perhaps builtin could come before constant in treesit-font-lock-feature-lis=
t to keep things alphabetical?





Information forwarded to bug-gnu-emacs@HIDDEN:
bug#70362; Package emacs. Full text available.

Message received at 70362 <at> debbugs.gnu.org:


Received: (at 70362) by debbugs.gnu.org; 14 Apr 2024 23:33:14 +0000
From debbugs-submit-bounces <at> debbugs.gnu.org Sun Apr 14 19:33:14 2024
Received: from localhost ([127.0.0.1]:36379 helo=debbugs.gnu.org)
	by debbugs.gnu.org with esmtp (Exim 4.84_2)
	(envelope-from <debbugs-submit-bounces <at> debbugs.gnu.org>)
	id 1rw9LW-0005yi-JH
	for submit <at> debbugs.gnu.org; Sun, 14 Apr 2024 19:33:14 -0400
Received: from mail-pl1-x62d.google.com ([2607:f8b0:4864:20::62d]:57365)
 by debbugs.gnu.org with esmtp (Exim 4.84_2)
 (envelope-from <casouri@HIDDEN>) id 1rw9LU-0005xy-Dw
 for 70362 <at> debbugs.gnu.org; Sun, 14 Apr 2024 19:33:13 -0400
Received: by mail-pl1-x62d.google.com with SMTP id
 d9443c01a7336-1e3f17c6491so21498695ad.2
 for <70362 <at> debbugs.gnu.org>; Sun, 14 Apr 2024 16:33:00 -0700 (PDT)
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed;
 d=gmail.com; s=20230601; t=1713137575; x=1713742375; darn=debbugs.gnu.org;
 h=to:cc:date:message-id:subject:mime-version
 :content-transfer-encoding:from:from:to:cc:subject:date:message-id
 :reply-to; bh=OIdqWkrUzOO57Pt0V2WRkzS1ZmPWYaRg8u1KrtjyyUI=;
 b=Yc38XQd16eLVDS5h7yinKHmqJx64rqkZV/Yx+tEk3jZR/WtvkH1Dh/+ypAi1mRqw3h
 wDE/Mlyp8T40bg+7/MtRHwzUCq0WvJkpAJmG37nqA6JVbK50pJ5Q2CBBnOlohOEc4Da5
 xeX8tRPH87OM/ebKP4fYE1Pj/BVnJ4RAmOxz1FCwAxVmoaJ9svSL5PmfdduX2WYE5uXz
 5INIdEkxfSzLUeFGvpWfNtbt0sBu3595bPM9PYGhNwMdKWI9z/ZwR1wVNWyqEVjezbm8
 5FxvOMyCyS2hSfOcVqxnOc/EGd+Jkl8aD4j50ZwrOWNj8xp22+Oj6RyFxbp7DmNCdfLB
 RuzQ==
X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed;
 d=1e100.net; s=20230601; t=1713137575; x=1713742375;
 h=to:cc:date:message-id:subject:mime-version
 :content-transfer-encoding:from:x-gm-message-state:from:to:cc
 :subject:date:message-id:reply-to;
 bh=OIdqWkrUzOO57Pt0V2WRkzS1ZmPWYaRg8u1KrtjyyUI=;
 b=cOmTaqcLUJFMJ5brfdw22wzGwMcqiQr79YZTAYi8kc6l5ww8d3DBgsVRfHgw3zQTFF
 PqZWIb51M4rz+/1iSBNjau434Mm2qnLP/IH4FEuFdhzNnq2FFInY1W41AFYoLy8mLmCY
 tpM1ou5Zxpmcx4gjGPCTp1eN8Ay7/16TQPjJrfcGoEQhWuMCWxiC/DTSKmtMNwu9SNKT
 FLOf+Z2s5oMoVd1mV1iSs/9u8fVdaF3r3t0twlfi86jbPIoLXBTR0PR/IY+cOAGS+pE7
 RJLeDUTVnwlAByWCFY7tU1TrLSjtEIRwVA0beYduZmiZc8MbAa1AWfEMBOqrga3aELNi
 fj4Q==
X-Forwarded-Encrypted: i=1;
 AJvYcCWnddDJ+t8jCANf4LpWT1X0GCttwCHQtVh0TLlWi2U+wklsiBikDnZVfq4dDpc10wjDua7pfpQP2Al2oF/E0tUH+Vb4JLQ=
X-Gm-Message-State: AOJu0Yw8wPQKWZntRJOUq79q/EIkXAtrOt8pzpG1IGPsPF3WQQ/CC0bk
 a6l2mWWr4XD11mQXT8oxX7CfA6PE+1kyunR7cuOCL50+u1u6cDXFsHSj6Q==
X-Google-Smtp-Source: AGHT+IG1kjwNuY08YtDIG9CX1WxS6kynRkD9ADRSf/+0qyYVL0Bdv9JEnwBNsxEVGYABfSQgqIHNvg==
X-Received: by 2002:a17:902:f68e:b0:1e4:a120:14f3 with SMTP id
 l14-20020a170902f68e00b001e4a12014f3mr7774620plg.51.1713137575213; 
 Sun, 14 Apr 2024 16:32:55 -0700 (PDT)
Received: from smtpclient.apple ([2601:641:300:4910:ddd5:ebc3:f048:bab8])
 by smtp.gmail.com with ESMTPSA id
 x5-20020a170902a38500b001e55671bd35sm6623261pla.29.2024.04.14.16.32.54
 (version=TLS1_2 cipher=ECDHE-ECDSA-AES128-GCM-SHA256 bits=128/128);
 Sun, 14 Apr 2024 16:32:54 -0700 (PDT)
From: Yuan Fu <casouri@HIDDEN>
Content-Type: text/plain;
	charset=us-ascii
Content-Transfer-Encoding: 7bit
Mime-Version: 1.0 (Mac OS X Mail 16.0 \(3731.700.6\))
Subject: Re: bug#70362: [PATCH] Add font-locking for Go built-in functions in
 go-ts-mode
Message-Id: <25B8E895-4E4B-4D60-BCDC-97A02AD2A1CE@HIDDEN>
Date: Sun, 14 Apr 2024 16:32:43 -0700
To: Dmitry Gutov <dmitry@HIDDEN>
X-Mailer: Apple Mail (2.3731.700.6)
X-Spam-Score: 0.7 (/)
X-Debbugs-Envelope-To: 70362
Cc: Noah Peart <noah.v.peart@HIDDEN>, Eli Zaretskii <eliz@HIDDEN>,
 70362 <at> debbugs.gnu.org
X-BeenThere: debbugs-submit <at> debbugs.gnu.org
X-Mailman-Version: 2.1.18
Precedence: list
List-Id: <debbugs-submit.debbugs.gnu.org>
List-Unsubscribe: <https://debbugs.gnu.org/cgi-bin/mailman/options/debbugs-submit>, 
 <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=unsubscribe>
List-Archive: <https://debbugs.gnu.org/cgi-bin/mailman/private/debbugs-submit/>
List-Post: <mailto:debbugs-submit <at> debbugs.gnu.org>
List-Help: <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=help>
List-Subscribe: <https://debbugs.gnu.org/cgi-bin/mailman/listinfo/debbugs-submit>, 
 <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=subscribe>
Errors-To: debbugs-submit-bounces <at> debbugs.gnu.org
Sender: "Debbugs-submit" <debbugs-submit-bounces <at> debbugs.gnu.org>
X-Spam-Score: -0.3 (/)


Dmitry Gutov <dmitry@HIDDEN> writes:

> On 13/04/2024 10:40, Noah Peart wrote:
>> I put it at level 3 following the conventions in other treesit modes
>> I checked: python-ts-mode, ruby-ts-mode, rust-ts-mode all put
>> builtins at level 3.
>> But, I haven't done a full census of the ts modes so there might be
>> variability.
>
> SGTM. If classic major modes highlight a thing (and they do that for
> built-ins), we usually put it in the default highlighting for ts modes
> as well (meaning level 3 or lower).

Right. And the patch looks good to me.

Yuan




Information forwarded to bug-gnu-emacs@HIDDEN:
bug#70362; Package emacs. Full text available.

Message received at 70362 <at> debbugs.gnu.org:


Received: (at 70362) by debbugs.gnu.org; 13 Apr 2024 12:17:16 +0000
From debbugs-submit-bounces <at> debbugs.gnu.org Sat Apr 13 08:17:16 2024
Received: from localhost ([127.0.0.1]:60287 helo=debbugs.gnu.org)
	by debbugs.gnu.org with esmtp (Exim 4.84_2)
	(envelope-from <debbugs-submit-bounces <at> debbugs.gnu.org>)
	id 1rvcJk-0003Gb-GH
	for submit <at> debbugs.gnu.org; Sat, 13 Apr 2024 08:17:16 -0400
Received: from wfout6-smtp.messagingengine.com ([64.147.123.149]:47579)
 by debbugs.gnu.org with esmtp (Exim 4.84_2)
 (envelope-from <dmitry@HIDDEN>) id 1rvcJe-0003EG-Vz
 for 70362 <at> debbugs.gnu.org; Sat, 13 Apr 2024 08:17:10 -0400
Received: from compute1.internal (compute1.nyi.internal [10.202.2.41])
 by mailfout.west.internal (Postfix) with ESMTP id 43C321C0013B;
 Sat, 13 Apr 2024 08:16:50 -0400 (EDT)
Received: from mailfrontend1 ([10.202.2.162])
 by compute1.internal (MEProxy); Sat, 13 Apr 2024 08:16:50 -0400
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gutov.dev; h=cc
 :cc:content-transfer-encoding:content-type:content-type:date
 :date:from:from:in-reply-to:in-reply-to:message-id:mime-version
 :references:reply-to:subject:subject:to:to; s=fm1; t=1713010609;
 x=1713097009; bh=1Sn3AENJo3x/ID82ezW+xoN7GvCfTwTGxkcpdSOTmUk=; b=
 OYonMryeO7KRPH6K+mO8PA2b6Wp/q6HEbgGBHTfuP2XH2UpCDQKhEb5zqQnn5xgg
 b/5Tvi5AQ0UmnCj7XsfzX633yR8RPLr8FKh2YuC6wZRi5PCLH01zXBxRS/FsbEqc
 1h2PED01B7KR3bnPVU0A7L50+RamwmWdgq4SGbqVDq2G1sEtkCIdoqWzpfRoSiGN
 t3VSpoEpceSPaq/0X5OpzbFr1wsaMyVIbVtm2LH04/WCrGVd7dN5Ga+wWFeL37Sj
 1T63dh1z/gRZQbaYtd/FoUXqdxgATze2w0bEVnRZbwqaxy8Zb7ZNoyuO5ApI7eky
 FgSxCfrQ6RGUWqtRXEgDqw==
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=
 messagingengine.com; h=cc:cc:content-transfer-encoding
 :content-type:content-type:date:date:feedback-id:feedback-id
 :from:from:in-reply-to:in-reply-to:message-id:mime-version
 :references:reply-to:subject:subject:to:to:x-me-proxy:x-me-proxy
 :x-me-sender:x-me-sender:x-sasl-enc; s=fm2; t=1713010609; x=
 1713097009; bh=1Sn3AENJo3x/ID82ezW+xoN7GvCfTwTGxkcpdSOTmUk=; b=n
 XVftUg2dNGIKjb/A/D2OpBLoPwHH5PAEcowe2zf5j2hxusGnBHpBfKLoslqWBFgD
 KVMoKT5d2Lfj3lcUxR7g5jnITZLPkLtJia0bseIHopEt8wqzdiWHQFxR4zFWeb2n
 Qufzc/SukwA55IIx4P39egeX9wOt/kbk/3fduoU2jC3sZjRDOwMfdgAe6w35/3RT
 54nzfml36fmoqCRGDtFCHC7nXEPV/9X0DDakkXu/cgYori/Rsj4KHmLqHFZoDQL4
 xqSYv1y+7vdsUUK+b47GGqZ/O5gA1t43owRzK6m9XDRTjo3dSFwk+qcRpX4h8oaf
 TI7g7bZb5kR18+lNP0qFg==
X-ME-Sender: <xms:sXcaZtlB-K73hAUFnu3RK_vDgMOE3_NaniRQ5Zzmy85O5SQamhy15w>
 <xme:sXcaZo0b37QLnNwQGEpGYueOmhqSFrIDIKe6zuLwPGkBkhq28Db28bz48Z7NQ1jXe
 w5aUPW8rMHsRQcNqVg>
X-ME-Received: <xmr:sXcaZjrBGxkzL-9GpRSbXq33WPpw0YfQWJX-8IDGFncasa09fuBQIT9TyyzKGgVGxxJB>
X-ME-Proxy-Cause: gggruggvucftvghtrhhoucdtuddrgedvledrudeiiedghedtucetufdoteggodetrfdotf
 fvucfrrhhofhhilhgvmecuhfgrshhtofgrihhlpdfqfgfvpdfurfetoffkrfgpnffqhgen
 uceurghilhhouhhtmecufedttdenucesvcftvggtihhpihgvnhhtshculddquddttddmne
 cujfgurhepkfffgggfuffvvehfhfgjtgfgsehtjeertddtvdejnecuhfhrohhmpeffmhhi
 thhrhicuifhuthhovhcuoegumhhithhrhiesghhuthhovhdruggvvheqnecuggftrfgrth
 htvghrnhepteduleejgeehtefgheegjeekueehvdevieekueeftddvtdevfefhvdevgedu
 jeehnecuvehluhhsthgvrhfuihiivgeptdenucfrrghrrghmpehmrghilhhfrhhomhepug
 hmihhtrhihsehguhhtohhvrdguvghv
X-ME-Proxy: <xmx:sXcaZtnNxlKnejoW3KQ-f1GsJO78uKOzBd-ZS12EYExAbUKtIYr5bw>
 <xmx:sXcaZr1f5gmT9Ocaa-2wTwmD8Ux5ulgtYh8_WqWhvJD5kE3e4Nviiw>
 <xmx:sXcaZsstPdrL09-fcgfFTR4Ia2Yu_22uLlhEKvgzFmn2wK5EY-ClLg>
 <xmx:sXcaZvVy8pY7iE06w5GatoAFy4_WL1tFBLqanPMQEUhQQ5JhhJMfFg>
 <xmx:sXcaZsxhU7qi0h7-HA66TMeB8M91Hbp2QDr3F_3HaXjcRT-syfoBU9Fo>
Feedback-ID: i0e71465a:Fastmail
Received: by mail.messagingengine.com (Postfix) with ESMTPA; Sat,
 13 Apr 2024 08:16:48 -0400 (EDT)
Message-ID: <4ca70f75-4834-4299-ab6d-4621dde31cfe@HIDDEN>
Date: Sat, 13 Apr 2024 15:16:45 +0300
MIME-Version: 1.0
User-Agent: Mozilla Thunderbird
Subject: Re: bug#70362: [PATCH] Add font-locking for Go built-in functions in
 go-ts-mode
Content-Language: en-US
To: Noah Peart <noah.v.peart@HIDDEN>, Eli Zaretskii <eliz@HIDDEN>
References: <CAPVBTSdAEhJoNVzb-Wof++SnwQAhXEFbMc3+D5wD69gKeapjVQ@HIDDEN>
 <86plutraj0.fsf@HIDDEN>
 <CAPVBTSfCE3Cx0jWjAzczh7FJLcT2E2tyZoKmaPW=aV_GLgLrcQ@HIDDEN>
From: Dmitry Gutov <dmitry@HIDDEN>
In-Reply-To: <CAPVBTSfCE3Cx0jWjAzczh7FJLcT2E2tyZoKmaPW=aV_GLgLrcQ@HIDDEN>
Content-Type: text/plain; charset=UTF-8; format=flowed
Content-Transfer-Encoding: 7bit
X-Spam-Score: 0.7 (/)
X-Debbugs-Envelope-To: 70362
Cc: 70362 <at> debbugs.gnu.org
X-BeenThere: debbugs-submit <at> debbugs.gnu.org
X-Mailman-Version: 2.1.18
Precedence: list
List-Id: <debbugs-submit.debbugs.gnu.org>
List-Unsubscribe: <https://debbugs.gnu.org/cgi-bin/mailman/options/debbugs-submit>, 
 <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=unsubscribe>
List-Archive: <https://debbugs.gnu.org/cgi-bin/mailman/private/debbugs-submit/>
List-Post: <mailto:debbugs-submit <at> debbugs.gnu.org>
List-Help: <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=help>
List-Subscribe: <https://debbugs.gnu.org/cgi-bin/mailman/listinfo/debbugs-submit>, 
 <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=subscribe>
Errors-To: debbugs-submit-bounces <at> debbugs.gnu.org
Sender: "Debbugs-submit" <debbugs-submit-bounces <at> debbugs.gnu.org>
X-Spam-Score: -0.3 (/)

On 13/04/2024 10:40, Noah Peart wrote:
> I put it at level 3 following the conventions in other treesit modes
> I checked: python-ts-mode, ruby-ts-mode, rust-ts-mode all put builtins 
> at level 3.
> But, I haven't done a full census of the ts modes so there might be 
> variability.

SGTM. If classic major modes highlight a thing (and they do that for 
built-ins), we usually put it in the default highlighting for ts modes 
as well (meaning level 3 or lower).




Information forwarded to bug-gnu-emacs@HIDDEN:
bug#70362; Package emacs. Full text available.

Message received at 70362 <at> debbugs.gnu.org:


Received: (at 70362) by debbugs.gnu.org; 13 Apr 2024 07:41:08 +0000
From debbugs-submit-bounces <at> debbugs.gnu.org Sat Apr 13 03:41:08 2024
Received: from localhost ([127.0.0.1]:59992 helo=debbugs.gnu.org)
	by debbugs.gnu.org with esmtp (Exim 4.84_2)
	(envelope-from <debbugs-submit-bounces <at> debbugs.gnu.org>)
	id 1rvY0a-00046H-2L
	for submit <at> debbugs.gnu.org; Sat, 13 Apr 2024 03:41:08 -0400
Received: from mail-oa1-x35.google.com ([2001:4860:4864:20::35]:48277)
 by debbugs.gnu.org with esmtp (Exim 4.84_2)
 (envelope-from <noah.v.peart@HIDDEN>) id 1rvY0X-00044I-HM
 for 70362 <at> debbugs.gnu.org; Sat, 13 Apr 2024 03:41:06 -0400
Received: by mail-oa1-x35.google.com with SMTP id
 586e51a60fabf-22fa18566adso724499fac.0
 for <70362 <at> debbugs.gnu.org>; Sat, 13 Apr 2024 00:40:55 -0700 (PDT)
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed;
 d=gmail.com; s=20230601; t=1712994049; x=1713598849; darn=debbugs.gnu.org;
 h=cc:to:subject:message-id:date:from:in-reply-to:references
 :mime-version:from:to:cc:subject:date:message-id:reply-to;
 bh=5jJ0Rk8g3hrLmyRqEtVJpcDYQ4mQxoM5Ge7wSVhgvxw=;
 b=DCtQ5GyoR1zqQOdKNWZnr2kJjcjziyDu2FKvVxl2J1ZTpnIUjF7YLeMAgEttx5J6qS
 kLV4sU4NCb8pm5xAx7qJ5JPvFcu5YR3H8AR6p3A2K2rlPBFDBjaQx0OlQNpIXcn3ynka
 98xtRe8EkbaE4lmfO9Q7uw0AyoJQlbe3v5hfRYBm6GxoYZqgCZZjUKqZ4Rdv8Y9462af
 xI24XYkEgeAcGzdywlRIhaiOrus5r8b16aqF+y+vILRD/EuBjUu4HmBnP8/dlgU+Dav0
 OodDeiCRAfwZablI1X3vGUKIzo5dDq4AL9j/L1yU/uc9Htv35Ybx8xbgN2cLWGXVOowr
 1QiQ==
X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed;
 d=1e100.net; s=20230601; t=1712994049; x=1713598849;
 h=cc:to:subject:message-id:date:from:in-reply-to:references
 :mime-version:x-gm-message-state:from:to:cc:subject:date:message-id
 :reply-to;
 bh=5jJ0Rk8g3hrLmyRqEtVJpcDYQ4mQxoM5Ge7wSVhgvxw=;
 b=hqCrQJmpcFDOrmw7Buz51tyz++wW+82kpaCRQ/+jPRVswLDcXEpukU4sHuae2rDS6L
 1ByJsyltPiNMpwUdKWkSM2PRT/0V9x/ttUUtIn1yVcUvX1il7iLamGV12EjmrqB1gdg6
 8k+8B2uB7GdE95S9fMtOx+uc91kkItACyJHHHriSRW5rUq6RyvFkwfVYX2wLhBQGMF/5
 D65z3XwiNGToPUvycGYsEyx8VPp+fn8frAf9IbYt77daEgac6xq7oaHsroAeoTwL2s2S
 stCohntHik9jbR17CoFy6Nhlm6sRMUjwoGU6k9lUQ7JORmcCyEU2deFysh8IbyFeKPMF
 QYXw==
X-Gm-Message-State: AOJu0YzB0OV8mHb2y61eH4NckKgfsc41ehZxj0m4cuvIC5BzeNM4EKnV
 YHV6eSCUHL6MJ4YB2XKDBxcS0p4UKrLyhHzeBoBdlJh2R4VSdXtZdBkPaXOSa7fv0MxuZS23Bc8
 DbejfGaPHSFqwFtLqpI/WtCePccdxIXB8xhM=
X-Google-Smtp-Source: AGHT+IHkPhtpn9bHVLVz/oc2hStFDIktA2b5cah7J3wS4DmozJOpPFbuRgWOFIrjU70VT8mdr7Peu4CQSJJovuIidCQ=
X-Received: by 2002:a05:6870:f613:b0:22e:caed:bc2 with SMTP id
 ek19-20020a056870f61300b0022ecaed0bc2mr5501865oab.8.1712994049403; Sat, 13
 Apr 2024 00:40:49 -0700 (PDT)
MIME-Version: 1.0
References: <CAPVBTSdAEhJoNVzb-Wof++SnwQAhXEFbMc3+D5wD69gKeapjVQ@HIDDEN>
 <86plutraj0.fsf@HIDDEN>
In-Reply-To: <86plutraj0.fsf@HIDDEN>
From: Noah Peart <noah.v.peart@HIDDEN>
Date: Sat, 13 Apr 2024 00:40:38 -0700
Message-ID: <CAPVBTSfCE3Cx0jWjAzczh7FJLcT2E2tyZoKmaPW=aV_GLgLrcQ@HIDDEN>
Subject: Re: bug#70362: [PATCH] Add font-locking for Go built-in functions in
 go-ts-mode
To: Eli Zaretskii <eliz@HIDDEN>
Content-Type: multipart/alternative; boundary="000000000000d1342a0615f5817c"
X-Spam-Score: 0.0 (/)
X-Debbugs-Envelope-To: 70362
Cc: 70362 <at> debbugs.gnu.org
X-BeenThere: debbugs-submit <at> debbugs.gnu.org
X-Mailman-Version: 2.1.18
Precedence: list
List-Id: <debbugs-submit.debbugs.gnu.org>
List-Unsubscribe: <https://debbugs.gnu.org/cgi-bin/mailman/options/debbugs-submit>, 
 <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=unsubscribe>
List-Archive: <https://debbugs.gnu.org/cgi-bin/mailman/private/debbugs-submit/>
List-Post: <mailto:debbugs-submit <at> debbugs.gnu.org>
List-Help: <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=help>
List-Subscribe: <https://debbugs.gnu.org/cgi-bin/mailman/listinfo/debbugs-submit>, 
 <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=subscribe>
Errors-To: debbugs-submit-bounces <at> debbugs.gnu.org
Sender: "Debbugs-submit" <debbugs-submit-bounces <at> debbugs.gnu.org>
X-Spam-Score: -1.0 (-)

--000000000000d1342a0615f5817c
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: quoted-printable

I put it at level 3 following the conventions in other treesit modes
I checked: python-ts-mode, ruby-ts-mode, rust-ts-mode all put builtins at
level 3.
But, I haven't done a full census of the ts modes so there might be
variability.

On Sat, Apr 13, 2024 at 12:23=E2=80=AFAM Eli Zaretskii <eliz@HIDDEN> wrote=
:

> > From: Noah Peart <noah.v.peart@HIDDEN>
> > Date: Fri, 12 Apr 2024 22:47:37 -0700
> >
> > This patch adds a new `builtin` feature to
> > `treesit-font-lock-feature-list` in `go-ts-mode` and a corresponding
> > rule to `go-ts-mode--font-lock-settings` to highlight Go's built-in
> functions.
>
> Thanks.
>
> I will ask here as well: at what level of font-lock will this be
> fontified?  I think it should be fontified only on level 4.
>

--000000000000d1342a0615f5817c
Content-Type: text/html; charset="UTF-8"
Content-Transfer-Encoding: quoted-printable

<div dir=3D"ltr">I put it at level 3 following the conventions in other tre=
esit modes<div>I checked: python-ts-mode, ruby-ts-mode, rust-ts-mode all pu=
t builtins at level 3.</div><div>But, I haven&#39;t done a full census of t=
he ts modes so there might be variability.</div></div><br><div class=3D"gma=
il_quote"><div dir=3D"ltr" class=3D"gmail_attr">On Sat, Apr 13, 2024 at 12:=
23=E2=80=AFAM Eli Zaretskii &lt;<a href=3D"mailto:eliz@HIDDEN">eliz@HIDDEN=
g</a>&gt; wrote:<br></div><blockquote class=3D"gmail_quote" style=3D"margin=
:0px 0px 0px 0.8ex;border-left:1px solid rgb(204,204,204);padding-left:1ex"=
>&gt; From: Noah Peart &lt;<a href=3D"mailto:noah.v.peart@HIDDEN" target=
=3D"_blank">noah.v.peart@HIDDEN</a>&gt;<br>
&gt; Date: Fri, 12 Apr 2024 22:47:37 -0700<br>
&gt; <br>
&gt; This patch adds a new `builtin` feature to<br>
&gt; `treesit-font-lock-feature-list` in `go-ts-mode` and a corresponding<b=
r>
&gt; rule to `go-ts-mode--font-lock-settings` to highlight Go&#39;s built-i=
n functions.<br>
<br>
Thanks.<br>
<br>
I will ask here as well: at what level of font-lock will this be<br>
fontified?=C2=A0 I think it should be fontified only on level 4.<br>
</blockquote></div>

--000000000000d1342a0615f5817c--




Information forwarded to bug-gnu-emacs@HIDDEN:
bug#70362; Package emacs. Full text available.

Message received at 70362 <at> debbugs.gnu.org:


Received: (at 70362) by debbugs.gnu.org; 13 Apr 2024 07:23:53 +0000
From debbugs-submit-bounces <at> debbugs.gnu.org Sat Apr 13 03:23:53 2024
Received: from localhost ([127.0.0.1]:59940 helo=debbugs.gnu.org)
	by debbugs.gnu.org with esmtp (Exim 4.84_2)
	(envelope-from <debbugs-submit-bounces <at> debbugs.gnu.org>)
	id 1rvXjs-0001Ym-TQ
	for submit <at> debbugs.gnu.org; Sat, 13 Apr 2024 03:23:53 -0400
Received: from eggs.gnu.org ([2001:470:142:3::10]:51804)
 by debbugs.gnu.org with esmtp (Exim 4.84_2)
 (envelope-from <eliz@HIDDEN>) id 1rvXjo-0001Xs-SD
 for 70362 <at> debbugs.gnu.org; Sat, 13 Apr 2024 03:23:51 -0400
Received: from fencepost.gnu.org ([2001:470:142:3::e])
 by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256)
 (Exim 4.90_1) (envelope-from <eliz@HIDDEN>)
 id 1rvXjZ-0007kn-7X; Sat, 13 Apr 2024 03:23:33 -0400
DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=gnu.org;
 s=fencepost-gnu-org; h=References:Subject:In-Reply-To:To:From:Date:
 mime-version; bh=Ta5Vfw8svf2BwyioDlUQD1gjvntdCfW90J45Ly4DVfg=; b=VNMnUMqE3bql
 Esu3mAC+BPRWaH8Mb3fzy6JwFYGnbRlJFra+DZ/uLovl162q+2r8YS8TS6BzurH2PXvgT6kwwgo0o
 tT1waCY2lsUycei0xoTmfXfFvFUjlgOlYy8udMNno7jm39QuxTxmbfuXz/TREdVGmedWu3s3MgvcH
 onNDwKeiERQwxbdpNQPXFEYeSi+ALS4l/id1Dl1ANaggThDMaPO0j6Nn2HSjKDIb8wzFtbu3mXh3h
 HvrC6Ob44wwfdWO5zfFq8kHOVYoK8cAfFnaSGaB73Zg2YHRNBMQDh6R4PFXeHo8JasY76DoekLDD7
 fpLyWwmmt17bVxveJkWIag==;
Date: Sat, 13 Apr 2024 10:23:31 +0300
Message-Id: <86plutraj0.fsf@HIDDEN>
From: Eli Zaretskii <eliz@HIDDEN>
To: Noah Peart <noah.v.peart@HIDDEN>
In-Reply-To: <CAPVBTSdAEhJoNVzb-Wof++SnwQAhXEFbMc3+D5wD69gKeapjVQ@HIDDEN>
 (message from Noah Peart on Fri, 12 Apr 2024 22:47:37 -0700)
Subject: Re: bug#70362: [PATCH] Add font-locking for Go built-in functions in
 go-ts-mode
References: <CAPVBTSdAEhJoNVzb-Wof++SnwQAhXEFbMc3+D5wD69gKeapjVQ@HIDDEN>
X-Spam-Score: -2.3 (--)
X-Debbugs-Envelope-To: 70362
Cc: 70362 <at> debbugs.gnu.org
X-BeenThere: debbugs-submit <at> debbugs.gnu.org
X-Mailman-Version: 2.1.18
Precedence: list
List-Id: <debbugs-submit.debbugs.gnu.org>
List-Unsubscribe: <https://debbugs.gnu.org/cgi-bin/mailman/options/debbugs-submit>, 
 <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=unsubscribe>
List-Archive: <https://debbugs.gnu.org/cgi-bin/mailman/private/debbugs-submit/>
List-Post: <mailto:debbugs-submit <at> debbugs.gnu.org>
List-Help: <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=help>
List-Subscribe: <https://debbugs.gnu.org/cgi-bin/mailman/listinfo/debbugs-submit>, 
 <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=subscribe>
Errors-To: debbugs-submit-bounces <at> debbugs.gnu.org
Sender: "Debbugs-submit" <debbugs-submit-bounces <at> debbugs.gnu.org>
X-Spam-Score: -3.3 (---)

> From: Noah Peart <noah.v.peart@HIDDEN>
> Date: Fri, 12 Apr 2024 22:47:37 -0700
> 
> This patch adds a new `builtin` feature to
> `treesit-font-lock-feature-list` in `go-ts-mode` and a corresponding
> rule to `go-ts-mode--font-lock-settings` to highlight Go's built-in functions.

Thanks.

I will ask here as well: at what level of font-lock will this be
fontified?  I think it should be fontified only on level 4.




Information forwarded to bug-gnu-emacs@HIDDEN:
bug#70362; Package emacs. Full text available.

Message received at submit <at> debbugs.gnu.org:


Received: (at submit) by debbugs.gnu.org; 13 Apr 2024 05:48:13 +0000
From debbugs-submit-bounces <at> debbugs.gnu.org Sat Apr 13 01:48:12 2024
Received: from localhost ([127.0.0.1]:59834 helo=debbugs.gnu.org)
	by debbugs.gnu.org with esmtp (Exim 4.84_2)
	(envelope-from <debbugs-submit-bounces <at> debbugs.gnu.org>)
	id 1rvWFG-0003s4-R5
	for submit <at> debbugs.gnu.org; Sat, 13 Apr 2024 01:48:12 -0400
Received: from lists.gnu.org ([2001:470:142::17]:43230)
 by debbugs.gnu.org with esmtp (Exim 4.84_2)
 (envelope-from <noah.v.peart@HIDDEN>) id 1rvWFD-0003q1-3f
 for submit <at> debbugs.gnu.org; Sat, 13 Apr 2024 01:48:08 -0400
Received: from eggs.gnu.org ([2001:470:142:3::10])
 by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256)
 (Exim 4.90_1) (envelope-from <noah.v.peart@HIDDEN>)
 id 1rvWEx-000872-3s
 for bug-gnu-emacs@HIDDEN; Sat, 13 Apr 2024 01:47:51 -0400
Received: from mail-oa1-x2d.google.com ([2001:4860:4864:20::2d])
 by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128)
 (Exim 4.90_1) (envelope-from <noah.v.peart@HIDDEN>)
 id 1rvWEv-00069s-Ht
 for bug-gnu-emacs@HIDDEN; Sat, 13 Apr 2024 01:47:50 -0400
Received: by mail-oa1-x2d.google.com with SMTP id
 586e51a60fabf-22ed075a629so915366fac.3
 for <bug-gnu-emacs@HIDDEN>; Fri, 12 Apr 2024 22:47:49 -0700 (PDT)
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed;
 d=gmail.com; s=20230601; t=1712987268; x=1713592068; darn=gnu.org;
 h=to:subject:message-id:date:from:mime-version:from:to:cc:subject
 :date:message-id:reply-to;
 bh=Vc+9gGkD+oX+RMmSrdYHcccoKe9yTcYrCGXZqHyG4Y0=;
 b=NsxeyZHpnuYNhqDi+IdIgwZPsb8SJo3TKeVRM2g1i5Yhb/3keID9unlgMAGoDGm8V+
 l+POohllXhpf0BW0EJq1Re1ac5ZFpeZv2p9mC3KjWcWrezcj4bHSxePIwkLVuLARLYLh
 VhHuVNCCvm7UP1f/526sji1a8ZzgNTpdl1Vo6ruCCEFFQnB8gi6bRsfH0qUImXNaArHE
 8pBpKyQ//pyB6YNzhn5B4cTz65iEfOtZ1WkqQjdpfKVSKxY6N6VJ2mFJ5VNN0MIECgDy
 Cw/BYWMzS+PUO3YGkeMuRh+4MtZB8Wo+ySnuaAW7QVJgBpr9ZwiOsCAoAW0tGl2TkNfH
 k9kA==
X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed;
 d=1e100.net; s=20230601; t=1712987268; x=1713592068;
 h=to:subject:message-id:date:from:mime-version:x-gm-message-state
 :from:to:cc:subject:date:message-id:reply-to;
 bh=Vc+9gGkD+oX+RMmSrdYHcccoKe9yTcYrCGXZqHyG4Y0=;
 b=RQsr78mIhgo+psmp4I22m/m0y2EXg/678qWANk3QNpYsenOnXyjZ8EQrlPCExcH0Gz
 3V8EiO2rR7eXEG3a6eSQ8mRkOZLKe8Op6blHzDF5bCG510EVZiin7NnZKiDDHck6T0rn
 9AV0aZfa61oDfethUedpCCpFJwGv/gEN9tS1XgfGr/Izha3KaxjURDQ7zIRlXQ4H/CMU
 fYfHDQJByvqyOI9kfHJte+OzLsMzmemZE/20PWxu1C8OnZNivOW+CjoUSHgfjj+DEO65
 XwsT67FTjUYSsiGL0BQiMoJGiNqBTRLYDg+Uk20rpi8xuGJVeAcbXXmcCuvI9Uwt+9Hu
 Ut+A==
X-Gm-Message-State: AOJu0Yw6WgsnneCu0FpIQ3SKeNdKqxkpi95WwYhiPoyJIRW7xdg2aq8E
 IrboVismybLOKZ0r0Dv28UGHns46bMkqS+0MKGETlSJCuKvhIgqwQOYztwnkIvvOU7hKAW9UeKa
 cZ4F0l6I3AJM6sc49PM0LcwBMmnCqPkVaqM5Rxg==
X-Google-Smtp-Source: AGHT+IEFfBcaIdG8sxbeAuOvQEhR4Gnt4W1ILtXwkqT6kebhTOH22QA1N4N5ZQsjPkZ2uy+CDhIRzfbRG53YLtmffWE=
X-Received: by 2002:a05:6871:729:b0:22e:d7be:54cf with SMTP id
 f41-20020a056871072900b0022ed7be54cfmr5321728oap.37.1712987267950; Fri, 12
 Apr 2024 22:47:47 -0700 (PDT)
MIME-Version: 1.0
From: Noah Peart <noah.v.peart@HIDDEN>
Date: Fri, 12 Apr 2024 22:47:37 -0700
Message-ID: <CAPVBTSdAEhJoNVzb-Wof++SnwQAhXEFbMc3+D5wD69gKeapjVQ@HIDDEN>
Subject: [PATCH] Add font-locking for Go built-in functions in go-ts-mode
To: bug-gnu-emacs@HIDDEN
Content-Type: multipart/mixed; boundary="0000000000009c87100615f3edfe"
Received-SPF: pass client-ip=2001:4860:4864:20::2d;
 envelope-from=noah.v.peart@HIDDEN; helo=mail-oa1-x2d.google.com
X-Spam_score_int: -20
X-Spam_score: -2.1
X-Spam_bar: --
X-Spam_report: (-2.1 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1,
 DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, FREEMAIL_FROM=0.001,
 HTML_MESSAGE=0.001, RCVD_IN_DNSWL_NONE=-0.0001, SPF_HELO_NONE=0.001,
 SPF_PASS=-0.001 autolearn=ham autolearn_force=no
X-Spam_action: no action
X-Spam-Score: 1.0 (+)
X-Debbugs-Envelope-To: submit
X-BeenThere: debbugs-submit <at> debbugs.gnu.org
X-Mailman-Version: 2.1.18
Precedence: list
List-Id: <debbugs-submit.debbugs.gnu.org>
List-Unsubscribe: <https://debbugs.gnu.org/cgi-bin/mailman/options/debbugs-submit>, 
 <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=unsubscribe>
List-Archive: <https://debbugs.gnu.org/cgi-bin/mailman/private/debbugs-submit/>
List-Post: <mailto:debbugs-submit <at> debbugs.gnu.org>
List-Help: <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=help>
List-Subscribe: <https://debbugs.gnu.org/cgi-bin/mailman/listinfo/debbugs-submit>, 
 <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=subscribe>
Errors-To: debbugs-submit-bounces <at> debbugs.gnu.org
Sender: "Debbugs-submit" <debbugs-submit-bounces <at> debbugs.gnu.org>
X-Spam-Score: -0.0 (/)

--0000000000009c87100615f3edfe
Content-Type: multipart/alternative; boundary="0000000000009c870f0615f3edfc"

--0000000000009c870f0615f3edfc
Content-Type: text/plain; charset="UTF-8"

Tags: patch

This patch adds a new `builtin` feature to
`treesit-font-lock-feature-list` in `go-ts-mode` and a corresponding
rule to `go-ts-mode--font-lock-settings` to highlight Go's built-in
functions.

--0000000000009c870f0615f3edfc
Content-Type: text/html; charset="UTF-8"

<div dir="ltr">Tags: patch<br><br>This patch adds a new `builtin` feature to<br>`treesit-font-lock-feature-list` in `go-ts-mode` and a corresponding<br>rule to `go-ts-mode--font-lock-settings` to highlight Go&#39;s built-in functions.<br></div>

--0000000000009c870f0615f3edfc--

--0000000000009c87100615f3edfe
Content-Type: text/x-patch; charset="US-ASCII"; 
	name="0001-Add-font-locking-for-Go-built-in-functions-in-go-ts-.patch"
Content-Disposition: attachment; 
	filename="0001-Add-font-locking-for-Go-built-in-functions-in-go-ts-.patch"
Content-Transfer-Encoding: base64
Content-ID: <f_luxoc8y20>
X-Attachment-Id: f_luxoc8y20

RnJvbSBmZWFmNTU5OGE1YTYzODY3ZjdkYzViZjhmMmMxMWMwNDdiMTE0ODNmIE1vbiBTZXAgMTcg
MDA6MDA6MDAgMjAwMQpGcm9tOiBOb2FoIFBlYXJ0IDxub2FoLnYucGVhcnRAZ21haWwuY29tPgpE
YXRlOiBGcmksIDEyIEFwciAyMDI0IDIyOjM4OjI4IC0wNzAwClN1YmplY3Q6IFtQQVRDSF0gQWRk
IGZvbnQtbG9ja2luZyBmb3IgR28gYnVpbHQtaW4gZnVuY3Rpb25zIGluIGdvLXRzLW1vZGUKCiog
bGlzcC9wcm9nbW9kZXMvZ28tdHMtbW9kZS5lbCAoZ28tdHMtbW9kZS0tZm9udC1sb2NrLXNldHRp
bmdzKToKQWRkIGZvbnQtbG9ja2luZyBmb3IgR28gYnVpbHQtaW4gZnVuY3Rpb25zIHRvIGdvLXRz
LW1vZGUuCi0tLQogbGlzcC9wcm9nbW9kZXMvZ28tdHMtbW9kZS5lbCB8IDE3ICsrKysrKysrKysr
KysrKystCiAxIGZpbGUgY2hhbmdlZCwgMTYgaW5zZXJ0aW9ucygrKSwgMSBkZWxldGlvbigtKQoK
ZGlmZiAtLWdpdCBhL2xpc3AvcHJvZ21vZGVzL2dvLXRzLW1vZGUuZWwgYi9saXNwL3Byb2dtb2Rl
cy9nby10cy1tb2RlLmVsCmluZGV4IGNjMzMwNjg4ZGMzLi5hMTczNjcwM2I2MiAxMDA2NDQKLS0t
IGEvbGlzcC9wcm9nbW9kZXMvZ28tdHMtbW9kZS5lbAorKysgYi9saXNwL3Byb2dtb2Rlcy9nby10
cy1tb2RlLmVsCkBAIC0xMDgsNiArMTA4LDExIEBAIGdvLXRzLW1vZGUtLW9wZXJhdG9ycwogICAg
ICI+PiIgIiU9IiAiPj49IiAiLS0iICIhIiAgIi4uLiIgICImXiIgIiZePSIgIn4iKQogICAiR28g
b3BlcmF0b3JzIGZvciB0cmVlLXNpdHRlciBmb250LWxvY2tpbmcuIikKIAorKGRlZnZhciBnby10
cy1tb2RlLS1idWlsdGluLWZ1bmN0aW9ucworICAnKCJhcHBlbmQiICJjYXAiICJjbGVhciIgImNs
b3NlIiAiY29tcGxleCIgImNvcHkiICJkZWxldGUiICJpbWFnIiAibGVuIiAibWFrZSIKKyAgICAi
bWF4IiAibWluIiAibmV3IiAicGFuaWMiICJwcmludCIgInByaW50bG4iICJyZWFsIiAicmVjb3Zl
ciIpCisgICJHbyBidWlsdC1pbiBmdW5jdGlvbnMgZm9yIHRyZWUtc2l0dGVyIGZvbnQtbG9ja2lu
Zy4iKQorCiAoZGVmdW4gZ28tdHMtbW9kZS0taW90YS1xdWVyeS1zdXBwb3J0ZWQtcCAoKQogICAi
UmV0dXJuIHQgaWYgdGhlIGlvdGEgcXVlcnkgaXMgc3VwcG9ydGVkIGJ5IHRoZSB0cmVlLXNpdHRl
ci1nbyBncmFtbWFyLiIKICAgKGlnbm9yZS1lcnJvcnMKQEAgLTE1NCw2ICsxNTksMTYgQEAgZ28t
dHMtbW9kZS0tZm9udC1sb2NrLXNldHRpbmdzCiAgICAgICh2YXJfc3BlYyBuYW1lOiAoaWRlbnRp
ZmllcikgQGZvbnQtbG9jay12YXJpYWJsZS1uYW1lLWZhY2UKICAgICAgICAgICAgICAgICgiLCIg
bmFtZTogKGlkZW50aWZpZXIpIEBmb250LWxvY2stdmFyaWFibGUtbmFtZS1mYWNlKSopKQogCisg
ICA6bGFuZ3VhZ2UgJ2dvCisgICA6ZmVhdHVyZSAnYnVpbHRpbgorICAgYCgoY2FsbF9leHByZXNz
aW9uCisgICAgICBmdW5jdGlvbjogKChpZGVudGlmaWVyKSBAZm9udC1sb2NrLWJ1aWx0aW4tZmFj
ZQorICAgICAgICAgICAgICAgICAoOm1hdGNoICwocngtdG8tc3RyaW5nCisgICAgICAgICAgICAg
ICAgICAgICAgICAgICBgKHNlcSBib2wKKyAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAg
IChvciAsQGdvLXRzLW1vZGUtLWJ1aWx0aW4tZnVuY3Rpb25zKQorICAgICAgICAgICAgICAgICAg
ICAgICAgICAgICAgICAgZW9sKSkKKyAgICAgICAgICAgICAgICAgICAgICAgICBAZm9udC1sb2Nr
LWJ1aWx0aW4tZmFjZSkpKSkKKwogICAgOmxhbmd1YWdlICdnbwogICAgOmZlYXR1cmUgJ2Z1bmN0
aW9uCiAgICAnKChjYWxsX2V4cHJlc3Npb24KQEAgLTI1Niw3ICsyNzEsNyBAQCBnby10cy1tb2Rl
CiAgICAgKHNldHEtbG9jYWwgdHJlZXNpdC1mb250LWxvY2stZmVhdHVyZS1saXN0CiAgICAgICAg
ICAgICAgICAgJygoIGNvbW1lbnQgZGVmaW5pdGlvbikKICAgICAgICAgICAgICAgICAgICgga2V5
d29yZCBzdHJpbmcgdHlwZSkKLSAgICAgICAgICAgICAgICAgICggY29uc3RhbnQgZXNjYXBlLXNl
cXVlbmNlIGxhYmVsIG51bWJlcikKKyAgICAgICAgICAgICAgICAgICggY29uc3RhbnQgZXNjYXBl
LXNlcXVlbmNlIGxhYmVsIG51bWJlciBidWlsdGluKQogICAgICAgICAgICAgICAgICAgKCBicmFj
a2V0IGRlbGltaXRlciBlcnJvciBmdW5jdGlvbiBvcGVyYXRvciBwcm9wZXJ0eSB2YXJpYWJsZSkp
KQogCiAgICAgKHRyZWVzaXQtbWFqb3ItbW9kZS1zZXR1cCkpKQotLSAKMi4zNC4xCgo=
--0000000000009c87100615f3edfe--




Acknowledgement sent to Noah Peart <noah.v.peart@HIDDEN>:
New bug report received and forwarded. Copy sent to bug-gnu-emacs@HIDDEN. Full text available.
Report forwarded to bug-gnu-emacs@HIDDEN:
bug#70362; Package emacs. Full text available.
Please note: This is a static page, with minimal formatting, updated once a day.
Click here to see this page with the latest information and nicer formatting.
Last modified: Thu, 18 Apr 2024 14:30:04 UTC

GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997 nCipher Corporation Ltd, 1994-97 Ian Jackson.