Received: (at 70383-done) by debbugs.gnu.org; 18 Apr 2024 18:29:38 +0000 From debbugs-submit-bounces <at> debbugs.gnu.org Thu Apr 18 14:29:37 2024 Received: from localhost ([127.0.0.1]:53897 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from <debbugs-submit-bounces <at> debbugs.gnu.org>) id 1rxWVs-00045r-MF for submit <at> debbugs.gnu.org; Thu, 18 Apr 2024 14:29:37 -0400 Received: from mailscanner.iro.umontreal.ca ([132.204.25.50]:33586) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from <monnier@HIDDEN>) id 1rxWVr-000453-6w for 70383-done <at> debbugs.gnu.org; Thu, 18 Apr 2024 14:29:35 -0400 Received: from pmg3.iro.umontreal.ca (localhost [127.0.0.1]) by pmg3.iro.umontreal.ca (Proxmox) with ESMTP id 7F47E441AB7; Thu, 18 Apr 2024 14:29:15 -0400 (EDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=iro.umontreal.ca; s=mail; t=1713464954; bh=s51R30NVoWa3eKOd3wtJ9gPSWPXXzJ9Zb6r0Ek40UDs=; h=From:To:Cc:Subject:In-Reply-To:References:Date:From; b=gI0zt9TBFbG2UUUAF/Ynt88R29x9e3WoYmhKdgMgWDCIqb/7RXzEViUnwvbB7nE6T 00fOtHXs9U3Nv00n8vh/PFIYflVUiThUYt6qqrHhVIZJi3vVr8sh6p64Qlm6VqzWho dnpfuWAWPnaMmP3QdoYwid1gDtjBcB0M1ob2TBE6qFeywYTH39DEIEDXyd7hc1hef5 oD24LUgDvYixbvL6/fdtpAEXIVCdW8JEqH3zO/+/CMJK7Z3C8AauUNqFLdFwKFyEQL 0qCQr2RjRNqZ01wUps3qkIhhCyxn3Wz75D6WP7XjOSfiYpqXXviq+z8ZEHQ8ZqrQuu QHZpraeb4YXgw== Received: from mail01.iro.umontreal.ca (unknown [172.31.2.1]) by pmg3.iro.umontreal.ca (Proxmox) with ESMTP id 60563441A5D; Thu, 18 Apr 2024 14:29:14 -0400 (EDT) Received: from pastel (unknown [45.72.201.215]) by mail01.iro.umontreal.ca (Postfix) with ESMTPSA id 323AA12039E; Thu, 18 Apr 2024 14:29:14 -0400 (EDT) From: Stefan Monnier <monnier@HIDDEN> To: Alastair Irving <alastair.j.irving@HIDDEN> Subject: Re: bug#70383: Conf-mode[toml] badly set face property In-Reply-To: <a65984f4-94a3-4b07-9b8b-7c06592e3da3@HIDDEN> (Alastair Irving's message of "Thu, 18 Apr 2024 18:26:13 +0100") Message-ID: <jwvle5atti0.fsf-monnier+emacs@HIDDEN> References: <45347c16-6e54-4598-8ac9-33f56f65e106@HIDDEN> <868r1fnb8k.fsf@HIDDEN> <b380858c-de65-41d2-91d2-51f65d5e5091@HIDDEN> <867cgylmoq.fsf@HIDDEN> <jwv34rj500v.fsf-monnier+emacs@HIDDEN> <jwvle5b3kqr.fsf-monnier+emacs@HIDDEN> <a65984f4-94a3-4b07-9b8b-7c06592e3da3@HIDDEN> Date: Thu, 18 Apr 2024 14:29:13 -0400 User-Agent: Gnus/5.13 (Gnus v5.13) MIME-Version: 1.0 Content-Type: text/plain X-SPAM-INFO: Spam detection results: 0 ALL_TRUSTED -1 Passed through trusted hosts only via SMTP AWL 0.012 Adjusted score from AWL reputation of From: address BAYES_00 -1.9 Bayes spam probability is 0 to 1% DKIM_SIGNED 0.1 Message has a DKIM or DK signature, not necessarily valid DKIM_VALID -0.1 Message has at least one valid DKIM or DK signature DKIM_VALID_AU -0.1 Message has a valid DKIM or DK signature from author's domain DKIM_VALID_EF -0.1 Message has a valid DKIM or DK signature from envelope-from domain X-SPAM-LEVEL: X-Spam-Score: -2.3 (--) X-Debbugs-Envelope-To: 70383-done Cc: 70383-done <at> debbugs.gnu.org, Eli Zaretskii <eliz@HIDDEN>, jostein@HIDDEN, casouri@HIDDEN X-BeenThere: debbugs-submit <at> debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: <debbugs-submit.debbugs.gnu.org> List-Unsubscribe: <https://debbugs.gnu.org/cgi-bin/mailman/options/debbugs-submit>, <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=unsubscribe> List-Archive: <https://debbugs.gnu.org/cgi-bin/mailman/private/debbugs-submit/> List-Post: <mailto:debbugs-submit <at> debbugs.gnu.org> List-Help: <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=help> List-Subscribe: <https://debbugs.gnu.org/cgi-bin/mailman/listinfo/debbugs-submit>, <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=subscribe> Errors-To: debbugs-submit-bounces <at> debbugs.gnu.org Sender: "Debbugs-submit" <debbugs-submit-bounces <at> debbugs.gnu.org> X-Spam-Score: -3.3 (---) > Thank you Stefan, that's fixed it. Thanks for confirming, closing, Stefan
Alastair Irving <alastair.j.irving@HIDDEN>
:Stefan Monnier <monnier@HIDDEN>
:Received: (at 70383) by debbugs.gnu.org; 17 Apr 2024 18:34:48 +0000 From debbugs-submit-bounces <at> debbugs.gnu.org Wed Apr 17 14:34:48 2024 Received: from localhost ([127.0.0.1]:47431 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from <debbugs-submit-bounces <at> debbugs.gnu.org>) id 1rxA7K-0004bX-QE for submit <at> debbugs.gnu.org; Wed, 17 Apr 2024 14:34:47 -0400 Received: from mailscanner.iro.umontreal.ca ([132.204.25.50]:11256) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from <monnier@HIDDEN>) id 1rxA7G-0004a5-1q for 70383 <at> debbugs.gnu.org; Wed, 17 Apr 2024 14:34:45 -0400 Received: from pmg2.iro.umontreal.ca (localhost.localdomain [127.0.0.1]) by pmg2.iro.umontreal.ca (Proxmox) with ESMTP id A56C28098A; Wed, 17 Apr 2024 14:34:23 -0400 (EDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=iro.umontreal.ca; s=mail; t=1713378862; bh=nK6NGdKvABV9mMQumYXjHnXp2nwfOjGhZpBrWxAZzLM=; h=From:To:Cc:Subject:In-Reply-To:References:Date:From; b=FOEM4TrvhSA5+R4N3325a84ujpBLl9GMcQ90G/8r2zmp2MbU1FuwESdFdDUjAs6L3 ZGvz4oojwrnH6CTl6ebXVAx+QtXVUswMty5+H6oYxQ2kLULgaVR6017zMMHFvaJNCo yMOQY9C19rYC8QghCkI6zS7/h3LQyhlyEowgB9paFmdTzFPm2oFoE2JAUnPQ2XvzUf wHP6YJptSjX+4lOpYOdJEOcsV94qLAXl0sfVtt7Fud0HRxZtvSXKaMz2fV4Hq7YWTE JlbBkqjb2Rflv1+9eMvRZF9cljWBLA0U7kl65Dbxp+NTD+yVh5gjJ2y3PiZgywEnif JNlIHcrz5JgOQ== Received: from mail01.iro.umontreal.ca (unknown [172.31.2.1]) by pmg2.iro.umontreal.ca (Proxmox) with ESMTP id 9D3768074F; Wed, 17 Apr 2024 14:34:22 -0400 (EDT) Received: from lechazo (lechon.iro.umontreal.ca [132.204.27.242]) by mail01.iro.umontreal.ca (Postfix) with ESMTPSA id 89FC6120454; Wed, 17 Apr 2024 14:34:22 -0400 (EDT) From: Stefan Monnier <monnier@HIDDEN> To: Eli Zaretskii <eliz@HIDDEN> Subject: Re: bug#70383: Conf-mode[toml] badly set face property In-Reply-To: <jwv34rj500v.fsf-monnier+emacs@HIDDEN> (Stefan Monnier's message of "Wed, 17 Apr 2024 14:17:43 -0400") Message-ID: <jwvle5b3kqr.fsf-monnier+emacs@HIDDEN> References: <45347c16-6e54-4598-8ac9-33f56f65e106@HIDDEN> <868r1fnb8k.fsf@HIDDEN> <b380858c-de65-41d2-91d2-51f65d5e5091@HIDDEN> <867cgylmoq.fsf@HIDDEN> <jwv34rj500v.fsf-monnier+emacs@HIDDEN> Date: Wed, 17 Apr 2024 14:31:36 -0400 User-Agent: Gnus/5.13 (Gnus v5.13) MIME-Version: 1.0 Content-Type: text/plain X-SPAM-INFO: Spam detection results: 0 ALL_TRUSTED -1 Passed through trusted hosts only via SMTP AWL 0.171 Adjusted score from AWL reputation of From: address BAYES_00 -1.9 Bayes spam probability is 0 to 1% DKIM_SIGNED 0.1 Message has a DKIM or DK signature, not necessarily valid DKIM_VALID -0.1 Message has at least one valid DKIM or DK signature DKIM_VALID_AU -0.1 Message has a valid DKIM or DK signature from author's domain DKIM_VALID_EF -0.1 Message has a valid DKIM or DK signature from envelope-from domain X-SPAM-LEVEL: X-Spam-Score: -2.3 (--) X-Debbugs-Envelope-To: 70383 Cc: Alastair Irving <alastair.j.irving@HIDDEN>, 70383 <at> debbugs.gnu.org, casouri@HIDDEN, jostein@HIDDEN X-BeenThere: debbugs-submit <at> debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: <debbugs-submit.debbugs.gnu.org> List-Unsubscribe: <https://debbugs.gnu.org/cgi-bin/mailman/options/debbugs-submit>, <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=unsubscribe> List-Archive: <https://debbugs.gnu.org/cgi-bin/mailman/private/debbugs-submit/> List-Post: <mailto:debbugs-submit <at> debbugs.gnu.org> List-Help: <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=help> List-Subscribe: <https://debbugs.gnu.org/cgi-bin/mailman/listinfo/debbugs-submit>, <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=subscribe> Errors-To: debbugs-submit-bounces <at> debbugs.gnu.org Sender: "Debbugs-submit" <debbugs-submit-bounces <at> debbugs.gnu.org> X-Spam-Score: -3.3 (---) > The patch below seems to DTRT for me. > [ I'd even argue that it should (goto-char end). ] Oh, it already does, sorry. OK I pushed it to `master`. I think this is it. Can the OP confirm it fixes the problem for them? Stefan
bug-gnu-emacs@HIDDEN
:bug#70383
; Package emacs
.
Full text available.Received: (at 70383) by debbugs.gnu.org; 17 Apr 2024 18:20:55 +0000 From debbugs-submit-bounces <at> debbugs.gnu.org Wed Apr 17 14:20:54 2024 Received: from localhost ([127.0.0.1]:47354 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from <debbugs-submit-bounces <at> debbugs.gnu.org>) id 1rx9tt-00030G-1q for submit <at> debbugs.gnu.org; Wed, 17 Apr 2024 14:20:54 -0400 Received: from mailscanner.iro.umontreal.ca ([132.204.25.50]:43706) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from <monnier@HIDDEN>) id 1rx9tp-0002yq-FW for 70383 <at> debbugs.gnu.org; Wed, 17 Apr 2024 14:20:50 -0400 Received: from pmg1.iro.umontreal.ca (localhost.localdomain [127.0.0.1]) by pmg1.iro.umontreal.ca (Proxmox) with ESMTP id 701A610007D; Wed, 17 Apr 2024 14:20:30 -0400 (EDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=iro.umontreal.ca; s=mail; t=1713378029; bh=TLwy0XZRrjHMJKEaFHYJOJ5Jim8NTMIVVJmje8OQ19w=; h=From:To:Cc:Subject:In-Reply-To:References:Date:From; b=B2KapMESM+x+ZknM6Q188islEGPpD1BHRtycI4FV6jytFr6d8TcxzT9/APsJUCS4l beNH2fn9at0j3WAI3jBN2gFoNgEo1q9QGqj5PlM7Bkv+qzMOPC1DJ2xNGCGkg5DqMa aNtbAJO80c9dXPYNzSX0ywEe2qQbUfHHWn5tlRxK1pzTDkGCICBaRCx+h5PBfU6KBy iEeHFnkLB2NQwOk9cgTVOwip15RALQEXdBhDCzcMVSNljiibS01zjRbU0nvgTLSem+ OmKO9ug9foU5M0jFJ9RvJfeHyL6LwAkzDHOe9ST+yYh9DLjdvHRkhdhp6aizASsoyO ZlIbMeyR/XZBw== Received: from mail01.iro.umontreal.ca (unknown [172.31.2.1]) by pmg1.iro.umontreal.ca (Proxmox) with ESMTP id 766C0100048; Wed, 17 Apr 2024 14:20:29 -0400 (EDT) Received: from lechazo (lechon.iro.umontreal.ca [132.204.27.242]) by mail01.iro.umontreal.ca (Postfix) with ESMTPSA id 5A05A12059E; Wed, 17 Apr 2024 14:20:29 -0400 (EDT) From: Stefan Monnier <monnier@HIDDEN> To: Eli Zaretskii <eliz@HIDDEN> Subject: Re: bug#70383: Conf-mode[toml] badly set face property In-Reply-To: <867cgylmoq.fsf@HIDDEN> (Eli Zaretskii's message of "Mon, 15 Apr 2024 17:34:13 +0300") Message-ID: <jwv34rj500v.fsf-monnier+emacs@HIDDEN> References: <45347c16-6e54-4598-8ac9-33f56f65e106@HIDDEN> <868r1fnb8k.fsf@HIDDEN> <b380858c-de65-41d2-91d2-51f65d5e5091@HIDDEN> <867cgylmoq.fsf@HIDDEN> Date: Wed, 17 Apr 2024 14:17:43 -0400 User-Agent: Gnus/5.13 (Gnus v5.13) MIME-Version: 1.0 Content-Type: text/plain X-SPAM-INFO: Spam detection results: 0 ALL_TRUSTED -1 Passed through trusted hosts only via SMTP AWL 0.111 Adjusted score from AWL reputation of From: address BAYES_00 -1.9 Bayes spam probability is 0 to 1% DKIM_SIGNED 0.1 Message has a DKIM or DK signature, not necessarily valid DKIM_VALID -0.1 Message has at least one valid DKIM or DK signature DKIM_VALID_AU -0.1 Message has a valid DKIM or DK signature from author's domain DKIM_VALID_EF -0.1 Message has a valid DKIM or DK signature from envelope-from domain X-SPAM-LEVEL: X-Spam-Score: -2.3 (--) X-Debbugs-Envelope-To: 70383 Cc: Alastair Irving <alastair.j.irving@HIDDEN>, 70383 <at> debbugs.gnu.org, casouri@HIDDEN, jostein@HIDDEN X-BeenThere: debbugs-submit <at> debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: <debbugs-submit.debbugs.gnu.org> List-Unsubscribe: <https://debbugs.gnu.org/cgi-bin/mailman/options/debbugs-submit>, <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=unsubscribe> List-Archive: <https://debbugs.gnu.org/cgi-bin/mailman/private/debbugs-submit/> List-Post: <mailto:debbugs-submit <at> debbugs.gnu.org> List-Help: <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=help> List-Subscribe: <https://debbugs.gnu.org/cgi-bin/mailman/listinfo/debbugs-submit>, <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=subscribe> Errors-To: debbugs-submit-bounces <at> debbugs.gnu.org Sender: "Debbugs-submit" <debbugs-submit-bounces <at> debbugs.gnu.org> X-Spam-Score: -3.3 (---) > diff --git a/lisp/textmodes/conf-mode.el b/lisp/textmodes/conf-mode.el > index 5e16360..8a201bd 100644 > --- a/lisp/textmodes/conf-mode.el > +++ b/lisp/textmodes/conf-mode.el > @@ -180,7 +180,7 @@ conf-font-lock-keywords > (1 'font-lock-variable-name-face) > (2 'font-lock-constant-face nil t)) > ;; section { ... } (do this last because some assign ...{...) > - ("^[ \t]*\\([^#=:\n]+?\\)[ \t\n]*{[^{}]*?$" 1 'font-lock-type-face prepend)) > + ("^[ \t]*\\([^[#=:\n]+?\\)[ \t\n]*{[^{}]*?$" 1 'font-lock-type-face prepend)) > "Keywords to highlight in Conf mode.") AFAICT this rule is not even activated in for TOML files. The patch below seems to DTRT for me. [ I'd even argue that it should (goto-char end). ] [ I found the culprit after noticing that the number of `font-lock-type-face` elements in the list in the `face` property was the same as the number of characters between the two "sections". ] Stefan diff --git a/lisp/textmodes/conf-mode.el b/lisp/textmodes/conf-mode.el index 5e1636033f6..e74409128df 100644 --- a/lisp/textmodes/conf-mode.el +++ b/lisp/textmodes/conf-mode.el @@ -613,7 +613,6 @@ "Font-lock helper function for `conf-toml-mode'. Handles recognizing TOML section names, like [section], \[[section]], or [something.\"else\".section]." - (save-excursion ;; Skip any number of "[" to handle things like [[section]]. (when (re-search-forward "^\\s-*\\[+" limit t) (let ((start (point))) @@ -633,7 +632,7 @@ (goto-char start) (unless (search-forward "," end t) (set-match-data (list start end)) - t))))))) + t)))))) ;;;###autoload (define-derived-mode conf-toml-mode conf-mode "Conf[TOML]"
bug-gnu-emacs@HIDDEN
:bug#70383
; Package emacs
.
Full text available.Received: (at 70383) by debbugs.gnu.org; 15 Apr 2024 14:34:41 +0000 From debbugs-submit-bounces <at> debbugs.gnu.org Mon Apr 15 10:34:41 2024 Received: from localhost ([127.0.0.1]:37604 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from <debbugs-submit-bounces <at> debbugs.gnu.org>) id 1rwNPs-0008HV-9a for submit <at> debbugs.gnu.org; Mon, 15 Apr 2024 10:34:40 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]:43488) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from <eliz@HIDDEN>) id 1rwNPp-0008GF-Mm for 70383 <at> debbugs.gnu.org; Mon, 15 Apr 2024 10:34:38 -0400 Received: from fencepost.gnu.org ([2001:470:142:3::e]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from <eliz@HIDDEN>) id 1rwNPX-0006lL-FM; Mon, 15 Apr 2024 10:34:19 -0400 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=gnu.org; s=fencepost-gnu-org; h=MIME-version:References:Subject:In-Reply-To:To:From: Date; bh=IYjoIfbEtdzF1gCd2oqHGmoAGra/ilySHbuC97gPv4A=; b=BREdVitKnYBaAITP9v3k K8JNK+OMvmbm3HvqHmDW1RGbtfcnTvZCIM+c4NlE91QgaRPsZm1HvgNi1NutnxSl9Ml3f2sx2xlkA 1NDIE5WGOMVNxTSEGfb3JZXqoNVfaDHKUB7kAHShtDB4Tcj6yybEujC5LsxW4vrzOmSTLK+EzbWwT 8Eqg5gmhmVhkCpanLsjkWX2qjv5/kkSr7WEeEVzNQ6Omxp+WA+1ZOB+/m5e4cxO2SxI4pD5ULLjVl kfK0Kx26rcMfzcF6WtngEsKR7yHJU5luiV/9X//uXHekVEqmefOBVTk4zFAm15utzBerwx4MHjMFD +nDLGhzUS7/4Hg==; Date: Mon, 15 Apr 2024 17:34:13 +0300 Message-Id: <867cgylmoq.fsf@HIDDEN> From: Eli Zaretskii <eliz@HIDDEN> To: Alastair Irving <alastair.j.irving@HIDDEN>, Stefan Monnier <monnier@HIDDEN> In-Reply-To: <b380858c-de65-41d2-91d2-51f65d5e5091@HIDDEN> (message from Alastair Irving on Sun, 14 Apr 2024 20:59:02 +0100) Subject: Re: bug#70383: Conf-mode[toml] badly set face property References: <45347c16-6e54-4598-8ac9-33f56f65e106@HIDDEN> <868r1fnb8k.fsf@HIDDEN> <b380858c-de65-41d2-91d2-51f65d5e5091@HIDDEN> MIME-version: 1.0 Content-type: text/plain; charset=utf-8 Content-Transfer-Encoding: 8bit X-Spam-Score: -2.3 (--) X-Debbugs-Envelope-To: 70383 Cc: 70383 <at> debbugs.gnu.org, casouri@HIDDEN, jostein@HIDDEN X-BeenThere: debbugs-submit <at> debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: <debbugs-submit.debbugs.gnu.org> List-Unsubscribe: <https://debbugs.gnu.org/cgi-bin/mailman/options/debbugs-submit>, <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=unsubscribe> List-Archive: <https://debbugs.gnu.org/cgi-bin/mailman/private/debbugs-submit/> List-Post: <mailto:debbugs-submit <at> debbugs.gnu.org> List-Help: <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=help> List-Subscribe: <https://debbugs.gnu.org/cgi-bin/mailman/listinfo/debbugs-submit>, <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=subscribe> Errors-To: debbugs-submit-bounces <at> debbugs.gnu.org Sender: "Debbugs-submit" <debbugs-submit-bounces <at> debbugs.gnu.org> X-Spam-Score: -3.3 (---) > Date: Sun, 14 Apr 2024 20:59:02 +0100 > Cc: 70383 <at> debbugs.gnu.org > From: Alastair Irving <alastair.j.irving@HIDDEN> > > > I cannot reproduce this here, neither in Emacs 29 nor in Emacs 30. > > What version of the TOML grammar library are you using? > I don't think it's using a TOML grammar library, just conf-mode bundled > with EMACS "The major mode is Conf[TOML] mode defined in conf-mode.el". > I think an extra newline was inserted in the TOML I pasted (in the > comment before the URL), it should be 4 lines total. I've attached the > exact file. Thanks. Does the patch below give good results (I don't have too many conf files around to test it). Stefan, does the fix look good to you? diff --git a/lisp/textmodes/conf-mode.el b/lisp/textmodes/conf-mode.el index 5e16360..8a201bd 100644 --- a/lisp/textmodes/conf-mode.el +++ b/lisp/textmodes/conf-mode.el @@ -180,7 +180,7 @@ conf-font-lock-keywords (1 'font-lock-variable-name-face) (2 'font-lock-constant-face nil t)) ;; section { ... } (do this last because some assign ...{...) - ("^[ \t]*\\([^#=:\n]+?\\)[ \t\n]*{[^{}]*?$" 1 'font-lock-type-face prepend)) + ("^[ \t]*\\([^[#=:\n]+?\\)[ \t\n]*{[^{}]*?$" 1 'font-lock-type-face prepend)) "Keywords to highlight in Conf mode.") (defvar conf-javaprop-font-lock-keywords
bug-gnu-emacs@HIDDEN
:bug#70383
; Package emacs
.
Full text available.Received: (at 70383) by debbugs.gnu.org; 15 Apr 2024 11:35:48 +0000 From debbugs-submit-bounces <at> debbugs.gnu.org Mon Apr 15 07:35:48 2024 Received: from localhost ([127.0.0.1]:37005 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from <debbugs-submit-bounces <at> debbugs.gnu.org>) id 1rwKcm-0005yc-DJ for submit <at> debbugs.gnu.org; Mon, 15 Apr 2024 07:35:48 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]:59716) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from <eliz@HIDDEN>) id 1rwKcj-0005xS-Mn for 70383 <at> debbugs.gnu.org; Mon, 15 Apr 2024 07:35:46 -0400 Received: from fencepost.gnu.org ([2001:470:142:3::e]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from <eliz@HIDDEN>) id 1rwKcR-0004TR-Vl; Mon, 15 Apr 2024 07:35:27 -0400 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=gnu.org; s=fencepost-gnu-org; h=MIME-version:References:Subject:In-Reply-To:To:From: Date; bh=q5N4PbnqveG6DBrg4JNRhBJo8nmNOYdfNVNaxz018jI=; b=VQ8AMPNfUYVz5soIrubz jNT1n+icdG1j3uXXVUIANSHmNQGa/f9e/CTTCCX7gFehBRmdGn53uhueh5D5Lcofx9chu0phl++tK +ru53c2QaG6Si22D4pid6wJyViH62k35V2tV5eXBl1kHRRXHacIjPOqVHTKY9umwD7SrYxQUFp77M 2gRyV3jcduAKmlkhs4HkLIdttvDb3Huq/x94MuQyJeThcL3dzeBsEvbOBu5GO8wDMi2mZCnZRECjj Ds8zLQEH/L3TeqDejeFoRcfOkw5Q7gzspUSdHmRNJq6FxxaZTc4hGIupMS0K8tzv5oITmRl3wttRr ncT/YhBN4LcG8w==; Date: Mon, 15 Apr 2024 14:35:17 +0300 Message-Id: <86o7aaluyy.fsf@HIDDEN> From: Eli Zaretskii <eliz@HIDDEN> To: Jostein =?utf-8?Q?Kj=C3=B8nigsen?= <jostein@HIDDEN> In-Reply-To: <16B0031C-DFCA-42E3-9D76-26AC3D7BDA77@HIDDEN> (message from Jostein =?utf-8?Q?Kj=C3=B8nigsen?= on Mon, 15 Apr 2024 08:43:59 +0200) Subject: Re: bug#70383: Conf-mode[toml] badly set face property References: <45347c16-6e54-4598-8ac9-33f56f65e106@HIDDEN> <868r1fnb8k.fsf@HIDDEN> <b380858c-de65-41d2-91d2-51f65d5e5091@HIDDEN> <16B0031C-DFCA-42E3-9D76-26AC3D7BDA77@HIDDEN> MIME-version: 1.0 Content-type: text/plain; charset=utf-8 Content-Transfer-Encoding: 8bit X-Spam-Score: -2.3 (--) X-Debbugs-Envelope-To: 70383 Cc: alastair.j.irving@HIDDEN, 70383 <at> debbugs.gnu.org, casouri@HIDDEN, jostein@HIDDEN X-BeenThere: debbugs-submit <at> debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: <debbugs-submit.debbugs.gnu.org> List-Unsubscribe: <https://debbugs.gnu.org/cgi-bin/mailman/options/debbugs-submit>, <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=unsubscribe> List-Archive: <https://debbugs.gnu.org/cgi-bin/mailman/private/debbugs-submit/> List-Post: <mailto:debbugs-submit <at> debbugs.gnu.org> List-Help: <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=help> List-Subscribe: <https://debbugs.gnu.org/cgi-bin/mailman/listinfo/debbugs-submit>, <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=subscribe> Errors-To: debbugs-submit-bounces <at> debbugs.gnu.org Sender: "Debbugs-submit" <debbugs-submit-bounces <at> debbugs.gnu.org> X-Spam-Score: -3.3 (---) > From: Jostein Kjønigsen <jostein@HIDDEN> > Date: Mon, 15 Apr 2024 08:43:59 +0200 > Cc: Eli Zaretskii <eliz@HIDDEN>, > "Mr. Jostein Kjønigsen" <jostein@HIDDEN>, > Yuan Fu <casouri@HIDDEN>, > 70383 <at> debbugs.gnu.org > > From what I can tell Alastair is using conf-mode, not toml-ts-mode. Right, sorry.
bug-gnu-emacs@HIDDEN
:bug#70383
; Package emacs
.
Full text available.Received: (at 70383) by debbugs.gnu.org; 15 Apr 2024 06:44:53 +0000 From debbugs-submit-bounces <at> debbugs.gnu.org Mon Apr 15 02:44:53 2024 Received: from localhost ([127.0.0.1]:36497 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from <debbugs-submit-bounces <at> debbugs.gnu.org>) id 1rwG58-0006Rj-Pn for submit <at> debbugs.gnu.org; Mon, 15 Apr 2024 02:44:53 -0400 Received: from wfout8-smtp.messagingengine.com ([64.147.123.151]:33807) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from <jostein@HIDDEN>) id 1rwG4t-0006OR-Jq for 70383 <at> debbugs.gnu.org; Mon, 15 Apr 2024 02:44:43 -0400 Received: from compute5.internal (compute5.nyi.internal [10.202.2.45]) by mailfout.west.internal (Postfix) with ESMTP id E8A511C00103; Mon, 15 Apr 2024 02:44:13 -0400 (EDT) Received: from mailfrontend2 ([10.202.2.163]) by compute5.internal (MEProxy); Mon, 15 Apr 2024 02:44:14 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d= secure.kjonigsen.net; h=cc:cc:content-type:content-type:date :date:from:from:in-reply-to:in-reply-to:message-id:mime-version :references:reply-to:subject:subject:to:to; s=fm1; t=1713163453; x=1713249853; bh=b/b31cusY75b2T+7CNbCeHo0gXj7yYdwUf+anV/gLLE=; b= hHPsVZVBV9YS9MqApSvIcCw7b/xb3gnVUYbMlTIVozB0G9Lx2DwX9uOYsx/jMWUr A0NS6rtcavPgL+zAF6FOl5cy9j5SCQeILNZLOGOgmDxMk47/SiTbw670Nms2NNey I4FoqzZpeSIJdb3o6PJfVisGAlU8STAx7qMmFXYOWnKNK5KQFnrYvfr4I2fFwz9Z ME4pCYkrUoEpYRHeCec7V2z+F8qhSvcRK/Mf3WusR2DYuGWndqgf+8fvD38guTan lJw9IC/aT90i81xJJN05xKMqpzs9QXS9AhVHPPLkptzucy4lIIJEKjRgl84CG2z1 usFUzGeSnfI5C9p3CLJOmA== DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d= messagingengine.com; h=cc:cc:content-type:content-type:date:date :feedback-id:feedback-id:from:from:in-reply-to:in-reply-to :message-id:mime-version:references:reply-to:subject:subject:to :to:x-me-proxy:x-me-proxy:x-me-sender:x-me-sender:x-sasl-enc; s= fm2; t=1713163453; x=1713249853; bh=b/b31cusY75b2T+7CNbCeHo0gXj7 yYdwUf+anV/gLLE=; b=YZFpdvm5C5NNnDbLmAL+LW/56jS66mwO18i/1GTx+sbU +T794xmCKKaNYdoTN8nIf3SQlyfvtklMSsNA7KYfI+FEt7GIhllL4IWEbQuNva0Q zFgd0nfxV0UtRrD/MKUh95xefDqHk/N9veT30wkjnz4vGKDx0rZDDfZtPLlWxJwm uxCov5+VV3Wv9RYRZi7nihHGLBvTsaIH/ejpAPAATjkbVqjfDrXHjQECeaFMsO7A OAVpBQdHNQ8KZHzI40JGXMWYIOwlhmUTVnGpYLGja0Czv+Ri2s9GN5KKw0PWvfbI ZsemJid9GDm4pLr/W28FP49t5Yq0GU0w7ski55bHHQ== X-ME-Sender: <xms:vcwcZoCyIB1No6TPIECuf0QahaG4S0UtvrQ48HQMduiMvKARLWXlew> <xme:vcwcZqgcQZ2jFdTNxGY6FGnt1hHGsrxXEkZxnIhoSMln-xR1pMZzhzeL1rhU_LFYA oByPWDAiu_Teha0Uw> X-ME-Received: <xmr:vcwcZrl7uIYSqLHmCbz3_W25mtFdGPeKpJfMaNYIXzCaJZlMF5jNq7zAGrNMVaMLoNMoO-bIfBkTxxjS-ecDzwmk5zZAkIDs0uYf> X-ME-Proxy-Cause: gggruggvucftvghtrhhoucdtuddrgedvledrudejuddgiedtucetufdoteggodetrfdotf fvucfrrhhofhhilhgvmecuhfgrshhtofgrihhlpdfqfgfvpdfurfetoffkrfgpnffqhgen uceurghilhhouhhtmecufedttdenucesvcftvggtihhpihgvnhhtshculddquddttddmne cujfgurhephffktgggufffjgevvfhfofesrgdtmherhhdtjeenucfhrhhomheplfhoshht vghinhcumfhjpphnihhgshgvnhcuoehjohhsthgvihhnsehsvggtuhhrvgdrkhhjohhnih hgshgvnhdrnhgvtheqnecuggftrfgrthhtvghrnheptdfhfefgfeeijeffveeludevveev tedtteeiveeifffhhfetieeijeejvdekgfegnecuffhomhgrihhnpehruhhsthdqlhgrnh hgrdhorhhgnecuvehluhhsthgvrhfuihiivgeptdenucfrrghrrghmpehmrghilhhfrhho mhepjhhoshhtvghinhesshgvtghurhgvrdhkjhhonhhighhsvghnrdhnvght X-ME-Proxy: <xmx:vcwcZuxPJN1iKDPIak9B0iwnVcs7eX9w99dE3HrlEUVg1RljUFmx2w> <xmx:vcwcZtTTF1oZHK_N2DHW2CLMJMVuuTjwmPwKj16AgWKIBGLcN7pLhQ> <xmx:vcwcZpZFzGSezxY2ADWHrYkdNKuztobalnBGN4R_W7rsrKQY4iN4UQ> <xmx:vcwcZmT2Yx4AMaClBZeo_QqZl3beQ7o79eQJcJdoFY-wcrCfWCdiYQ> <xmx:vcwcZmJ9Gupp0M6eJo6EBZJK3dvYjRs6DYI7iCaZ8ANPHGOfJ9lJ77Qx> Feedback-ID: ib2f84088:Fastmail Received: by mail.messagingengine.com (Postfix) with ESMTPA; Mon, 15 Apr 2024 02:44:11 -0400 (EDT) From: =?utf-8?Q?Jostein_Kj=C3=B8nigsen?= <jostein@HIDDEN> Message-Id: <16B0031C-DFCA-42E3-9D76-26AC3D7BDA77@HIDDEN> Content-Type: multipart/alternative; boundary="Apple-Mail=_5F1A0708-79BD-4633-B17B-06F0B0626B1C" Mime-Version: 1.0 (Mac OS X Mail 16.0 \(3774.300.61.1.2\)) Subject: Re: bug#70383: Conf-mode[toml] badly set face property Date: Mon, 15 Apr 2024 08:43:59 +0200 In-Reply-To: <b380858c-de65-41d2-91d2-51f65d5e5091@HIDDEN> To: Alastair Irving <alastair.j.irving@HIDDEN> References: <45347c16-6e54-4598-8ac9-33f56f65e106@HIDDEN> <868r1fnb8k.fsf@HIDDEN> <b380858c-de65-41d2-91d2-51f65d5e5091@HIDDEN> X-Mailer: Apple Mail (2.3774.300.61.1.2) X-Spam-Score: -0.7 (/) X-Debbugs-Envelope-To: 70383 Cc: 70383 <at> debbugs.gnu.org, Eli Zaretskii <eliz@HIDDEN>, =?utf-8?B?Ik1yLiBKb3N0ZWluIEtqw7huaWdzZW4i?= <jostein@HIDDEN>, Yuan Fu <casouri@HIDDEN> X-BeenThere: debbugs-submit <at> debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: <debbugs-submit.debbugs.gnu.org> List-Unsubscribe: <https://debbugs.gnu.org/cgi-bin/mailman/options/debbugs-submit>, <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=unsubscribe> List-Archive: <https://debbugs.gnu.org/cgi-bin/mailman/private/debbugs-submit/> List-Post: <mailto:debbugs-submit <at> debbugs.gnu.org> List-Help: <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=help> List-Subscribe: <https://debbugs.gnu.org/cgi-bin/mailman/listinfo/debbugs-submit>, <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=subscribe> Errors-To: debbugs-submit-bounces <at> debbugs.gnu.org Sender: "Debbugs-submit" <debbugs-submit-bounces <at> debbugs.gnu.org> X-Spam-Score: -1.7 (-) --Apple-Mail=_5F1A0708-79BD-4633-B17B-06F0B0626B1C Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset=utf-8 =46rom what I can tell Alastair is using conf-mode, not toml-ts-mode. Alastait: toml-ts-mode is a new builtin tree-sitter based major-mode for = working with TOML files. If you have issues with conf-mode and certain TOML files, you could try = that instead. I just tried it with your test-files and I don't see any = incorrect fontification, so it seems to work fairly well. Eli: If there's a bug to fix in conf-mode, I'm going to assume it would = be better to CC the conf-mode maintainer than the toml-ts-mode = maintainer. It might gain more traction. =E2=80=94 Kind Regards Jostein Kj=C3=B8nigsen > On 14 Apr 2024, at 21:59, Alastair Irving = <alastair.j.irving@HIDDEN> wrote: >=20 >=20 > On 14/04/2024 17:46, Eli Zaretskii wrote: >>> Date: Sun, 14 Apr 2024 11:25:08 +0100 >>> From: Alastair Irving <alastair.j.irving@HIDDEN> >>>=20 >>> When editting TOML files with conf-mode[toml] the face property is = being >>> set badly on certain characters. This occurs in Emacs 29.3 (running >>> with -q) but has been present in older versions. Steps to = reproduce: >>>=20 >>> 1. Create a file test.toml containing the following: >>>=20 >>>=20 >>> [package] >>> name =3D "test" >>> # See more keys and their definitions at >>> https://doc.rust-lang.org/cargo/reference/manifest.html >>> [dependencies] >>>=20 >>> 2. Navigate to the d in dependencies and evaluate >>>=20 >>> (text-properties-at (point)) >>>=20 >>> The output for me looks like >>>=20 >>> (face (font-lock-type-face font-lock-type-face font-lock-type-face >>> font-lock-type-face font-lock-type-face font-lock-ty\ >>> pe-face font-lock-type-face font-lock-type-face font-lock-type-face >>> font-lock-type-face >>>=20 >>>=20 >>> It looks like something is wrong in the font-lock setup and the same >>> face is being applied very many times. >> I cannot reproduce this here, neither in Emacs 29 nor in Emacs 30. >> What version of the TOML grammar library are you using? > I don't think it's using a TOML grammar library, just conf-mode = bundled with EMACS "The major mode is Conf[TOML] mode defined in = conf-mode.el". I think an extra newline was inserted in the TOML I = pasted (in the comment before the URL), it should be 4 lines total. I've = attached the exact file. >>=20 >> Jostein and Yuan, can you please look into this? > <test.toml> --Apple-Mail=_5F1A0708-79BD-4633-B17B-06F0B0626B1C Content-Transfer-Encoding: quoted-printable Content-Type: text/html; charset=utf-8 <html><head><meta http-equiv=3D"content-type" content=3D"text/html; = charset=3Dutf-8"></head><body style=3D"overflow-wrap: break-word; = -webkit-nbsp-mode: space; line-break: after-white-space;">=46rom what I = can tell Alastair is using conf-mode, not = toml-ts-mode.<div><br></div><div>Alastait: toml-ts-mode is a new builtin = tree-sitter based major-mode for working with TOML = files.</div><div><br></div><div>If you have issues with conf-mode and = certain TOML files, you could try that instead. I just tried it with = your test-files and I don't see any incorrect fontification, so it seems = to work fairly well.</div><div><br></div><div>Eli: If there's a bug to = fix in conf-mode, I'm going to assume it would be better to CC the = conf-mode maintainer than the toml-ts-mode maintainer. It might gain = more traction.</div><div><br id=3D"lineBreakAtBeginningOfMessage"><div> <meta charset=3D"UTF-8"><div>=E2=80=94<br>Kind Regards<br>Jostein = Kj=C3=B8nigsen</div> </div> <div><br><blockquote type=3D"cite"><div>On 14 Apr 2024, at 21:59, = Alastair Irving <alastair.j.irving@HIDDEN> wrote:</div><br = class=3D"Apple-interchange-newline"><div><meta charset=3D"UTF-8"><br = style=3D"caret-color: rgb(0, 0, 0); font-family: Helvetica; font-size: = 12px; font-style: normal; font-variant-caps: normal; font-weight: 400; = letter-spacing: normal; text-align: start; text-indent: 0px; = text-transform: none; white-space: normal; word-spacing: 0px; = -webkit-text-stroke-width: 0px; text-decoration: none;"><span = style=3D"caret-color: rgb(0, 0, 0); font-family: Helvetica; font-size: = 12px; font-style: normal; font-variant-caps: normal; font-weight: 400; = letter-spacing: normal; text-align: start; text-indent: 0px; = text-transform: none; white-space: normal; word-spacing: 0px; = -webkit-text-stroke-width: 0px; text-decoration: none; float: none; = display: inline !important;">On 14/04/2024 17:46, Eli Zaretskii = wrote:</span><br style=3D"caret-color: rgb(0, 0, 0); font-family: = Helvetica; font-size: 12px; font-style: normal; font-variant-caps: = normal; font-weight: 400; letter-spacing: normal; text-align: start; = text-indent: 0px; text-transform: none; white-space: normal; = word-spacing: 0px; -webkit-text-stroke-width: 0px; text-decoration: = none;"><blockquote type=3D"cite" style=3D"font-family: Helvetica; = font-size: 12px; font-style: normal; font-variant-caps: normal; = font-weight: 400; letter-spacing: normal; orphans: auto; text-align: = start; text-indent: 0px; text-transform: none; white-space: normal; = widows: auto; word-spacing: 0px; -webkit-text-stroke-width: 0px; = text-decoration: none;"><blockquote type=3D"cite">Date: Sun, 14 Apr 2024 = 11:25:08 +0100<br>From: Alastair Irving = <alastair.j.irving@HIDDEN><br><br>When editting TOML files with = conf-mode[toml] the face property is being<br>set badly on certain = characters. This occurs in Emacs 29.3 (running<br>with -q) but has = been present in older versions. Steps to reproduce:<br><br>1. = Create a file test.toml containing the = following:<br><br><br>[package]<br>name =3D "test"<br># See more keys = and their definitions = at<br>https://doc.rust-lang.org/cargo/reference/manifest.html<br>[dependen= cies]<br><br>2. Navigate to the d in dependencies and = evaluate<br><br>(text-properties-at (point))<br><br>The output for me = looks like<br><br>(face (font-lock-type-face font-lock-type-face = font-lock-type-face<br>font-lock-type-face font-lock-type-face = font-lock-ty\<br>pe-face font-lock-type-face font-lock-type-face = font-lock-type-face<br>font-lock-type-face<br><br><br>It looks like = something is wrong in the font-lock setup and the same<br>face is being = applied very many times.<br></blockquote>I cannot reproduce this here, = neither in Emacs 29 nor in Emacs 30.<br>What version of the TOML grammar = library are you using?<br></blockquote><span style=3D"caret-color: = rgb(0, 0, 0); font-family: Helvetica; font-size: 12px; font-style: = normal; font-variant-caps: normal; font-weight: 400; letter-spacing: = normal; text-align: start; text-indent: 0px; text-transform: none; = white-space: normal; word-spacing: 0px; -webkit-text-stroke-width: 0px; = text-decoration: none; float: none; display: inline !important;">I don't = think it's using a TOML grammar library, just conf-mode bundled with = EMACS "The major mode is Conf[TOML] mode defined in conf-mode.el". = I think an extra newline was inserted in the TOML I pasted (in the = comment before the URL), it should be 4 lines total. I've attached the = exact file.</span><br style=3D"caret-color: rgb(0, 0, 0); font-family: = Helvetica; font-size: 12px; font-style: normal; font-variant-caps: = normal; font-weight: 400; letter-spacing: normal; text-align: start; = text-indent: 0px; text-transform: none; white-space: normal; = word-spacing: 0px; -webkit-text-stroke-width: 0px; text-decoration: = none;"><blockquote type=3D"cite" style=3D"font-family: Helvetica; = font-size: 12px; font-style: normal; font-variant-caps: normal; = font-weight: 400; letter-spacing: normal; orphans: auto; text-align: = start; text-indent: 0px; text-transform: none; white-space: normal; = widows: auto; word-spacing: 0px; -webkit-text-stroke-width: 0px; = text-decoration: none;"><br>Jostein and Yuan, can you please look into = this?</blockquote><span = id=3D"cid:EF286F69-F217-4672-BE5A-3101DE9C34ED"><test.toml></span></= div></blockquote></div><br></div></body></html>= --Apple-Mail=_5F1A0708-79BD-4633-B17B-06F0B0626B1C--
bug-gnu-emacs@HIDDEN
:bug#70383
; Package emacs
.
Full text available.Received: (at 70383) by debbugs.gnu.org; 14 Apr 2024 20:51:53 +0000 From debbugs-submit-bounces <at> debbugs.gnu.org Sun Apr 14 16:51:52 2024 Received: from localhost ([127.0.0.1]:36339 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from <debbugs-submit-bounces <at> debbugs.gnu.org>) id 1rw6pH-0006ke-0n for submit <at> debbugs.gnu.org; Sun, 14 Apr 2024 16:51:52 -0400 Received: from mail-wr1-x432.google.com ([2a00:1450:4864:20::432]:48564) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from <alastair.j.irving@HIDDEN>) id 1rw60X-0004VX-4X for 70383 <at> debbugs.gnu.org; Sun, 14 Apr 2024 15:59:23 -0400 Received: by mail-wr1-x432.google.com with SMTP id ffacd0b85a97d-343c7fae6e4so2142655f8f.1 for <70383 <at> debbugs.gnu.org>; Sun, 14 Apr 2024 12:59:09 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1713124744; x=1713729544; darn=debbugs.gnu.org; h=in-reply-to:from:references:cc:to:content-language:subject :user-agent:mime-version:date:message-id:from:to:cc:subject:date :message-id:reply-to; bh=bVRJQIoVmNiMyYZG10L5FVvauFlqFWtMP17YSRZUWnw=; b=A0SjQEXAJq7iZcyZHsAfHdxm+WJMfAzn1/Rn6waPxZxzgewlhyEGpsf4xZtvFDF1sa LNdlhuJQGQNctb4aAgUdipOABP8PR6P3Zn2ipi/NXihR6oI9KaaXm0k/DBXYS6n7ajdt e8G0tn7OoNZ/FO60bg7Wgz1/T2bxu+PaLQCTE61dMEYG00ZzfnfSj15Rl4sv1bFc7cfh 5Deg5xwVVgmOmoWl5oNDQCfJ6PHmjvJSbM1SB9ADTPN1CnfWpRxgkuyp4dcH0070AGcv H8BL6NF96N9nQceEtgrL1Qnc3wNuzBPEfw9yLeDRdrau7oyMxQSo8pWRkEXHmSnC/5kG dCFQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1713124744; x=1713729544; h=in-reply-to:from:references:cc:to:content-language:subject :user-agent:mime-version:date:message-id:x-gm-message-state:from:to :cc:subject:date:message-id:reply-to; bh=bVRJQIoVmNiMyYZG10L5FVvauFlqFWtMP17YSRZUWnw=; b=ZIBlkGvnhcTd6aOdbZ9QZVr9tpTLB0srLZk8dl8bUccJyyy0oSAHGxiexpoaF2A3zA 73kQhXm+duWfemAm7kkuLcLWBTEyQee7XKLVrUUd4itPUEPgsA4O5zlcVymNM2bmFn/u iUVzFxw5JzRTByHPiJaprhqdmhN5MnDaETcjZRhLb/5wP9XAbtd4BN84CBUDeYl0wa6e 4CFALqjET6440z/BiIDqcYdI4lnK5sHmL8vrUa4lYCRjqb+sXCfjf6S/sR7h1C4LRNSG 7jVeMlQfO1vhIrROV12BuzXh0M4kxAojF14EWBofLBDMNYQzkv8O27S1K0EpFVwKYASa ZREg== X-Gm-Message-State: AOJu0YyK5+RRBpjNwPAl8K0K3xfg3sekf1QCtBlKGQbkychECzZB0qsF 15TTkDL1LRuvL+18CL5+ReER9BGG5WfXNOQVp+hgJcI9gC0zamz/ X-Google-Smtp-Source: AGHT+IElwoaMFhqL9i0whwZ4Zg7ZXT+i/z+rfB6a6nfUdTEsPlhm1R27RPZ5VNKXlb+taDINPm49ag== X-Received: by 2002:a5d:47ab:0:b0:343:65a8:406d with SMTP id 11-20020a5d47ab000000b0034365a8406dmr6858613wrb.64.1713124743850; Sun, 14 Apr 2024 12:59:03 -0700 (PDT) Received: from ?IPV6:2a02:c7c:8239:f200:9123:6aed:6f92:203a? ([2a02:c7c:8239:f200:9123:6aed:6f92:203a]) by smtp.googlemail.com with ESMTPSA id n7-20020a05600c4f8700b004181ed7c033sm6904902wmq.24.2024.04.14.12.59.02 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Sun, 14 Apr 2024 12:59:03 -0700 (PDT) Content-Type: multipart/mixed; boundary="------------03JnVhWXBU4DoOzVDEeXG9Nk" Message-ID: <b380858c-de65-41d2-91d2-51f65d5e5091@HIDDEN> Date: Sun, 14 Apr 2024 20:59:02 +0100 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: bug#70383: Conf-mode[toml] badly set face property Content-Language: en-GB To: Eli Zaretskii <eliz@HIDDEN>, =?UTF-8?Q?Jostein_Kj=C3=B8nigsen?= <jostein@HIDDEN>, Yuan Fu <casouri@HIDDEN> References: <45347c16-6e54-4598-8ac9-33f56f65e106@HIDDEN> <868r1fnb8k.fsf@HIDDEN> From: Alastair Irving <alastair.j.irving@HIDDEN> In-Reply-To: <868r1fnb8k.fsf@HIDDEN> X-Spam-Score: 0.0 (/) X-Debbugs-Envelope-To: 70383 X-Mailman-Approved-At: Sun, 14 Apr 2024 16:51:41 -0400 Cc: 70383 <at> debbugs.gnu.org X-BeenThere: debbugs-submit <at> debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: <debbugs-submit.debbugs.gnu.org> List-Unsubscribe: <https://debbugs.gnu.org/cgi-bin/mailman/options/debbugs-submit>, <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=unsubscribe> List-Archive: <https://debbugs.gnu.org/cgi-bin/mailman/private/debbugs-submit/> List-Post: <mailto:debbugs-submit <at> debbugs.gnu.org> List-Help: <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=help> List-Subscribe: <https://debbugs.gnu.org/cgi-bin/mailman/listinfo/debbugs-submit>, <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=subscribe> Errors-To: debbugs-submit-bounces <at> debbugs.gnu.org Sender: "Debbugs-submit" <debbugs-submit-bounces <at> debbugs.gnu.org> X-Spam-Score: -1.0 (-) This is a multi-part message in MIME format. --------------03JnVhWXBU4DoOzVDEeXG9Nk Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 8bit On 14/04/2024 17:46, Eli Zaretskii wrote: >> Date: Sun, 14 Apr 2024 11:25:08 +0100 >> From: Alastair Irving <alastair.j.irving@HIDDEN> >> >> When editting TOML files with conf-mode[toml] the face property is being >> set badly on certain characters. This occurs in Emacs 29.3 (running >> with -q) but has been present in older versions. Steps to reproduce: >> >> 1. Create a file test.toml containing the following: >> >> >> [package] >> name = "test" >> # See more keys and their definitions at >> https://doc.rust-lang.org/cargo/reference/manifest.html >> [dependencies] >> >> 2. Navigate to the d in dependencies and evaluate >> >> (text-properties-at (point)) >> >> The output for me looks like >> >> (face (font-lock-type-face font-lock-type-face font-lock-type-face >> font-lock-type-face font-lock-type-face font-lock-ty\ >> pe-face font-lock-type-face font-lock-type-face font-lock-type-face >> font-lock-type-face >> >> >> It looks like something is wrong in the font-lock setup and the same >> face is being applied very many times. > I cannot reproduce this here, neither in Emacs 29 nor in Emacs 30. > What version of the TOML grammar library are you using? I don't think it's using a TOML grammar library, just conf-mode bundled with EMACS "The major mode is Conf[TOML] mode defined in conf-mode.el". I think an extra newline was inserted in the TOML I pasted (in the comment before the URL), it should be 4 lines total. I've attached the exact file. > > Jostein and Yuan, can you please look into this? --------------03JnVhWXBU4DoOzVDEeXG9Nk Content-Type: text/plain; charset=UTF-8; name="test.toml" Content-Disposition: attachment; filename="test.toml" Content-Transfer-Encoding: base64 W3BhY2thZ2VdCm5hbWUgPSAidGVzdCIKIyBTZWUgbW9yZSBrZXlzIGFuZCB0aGVpciBkZWZp bml0aW9ucyBhdCBodHRwczovL2RvYy5ydXN0LWxhbmcub3JnL2NhcmdvL3JlZmVyZW5jZS9t YW5pZmVzdC5odG1sCltkZXBlbmRlbmNpZXNdCg== --------------03JnVhWXBU4DoOzVDEeXG9Nk--
bug-gnu-emacs@HIDDEN
:bug#70383
; Package emacs
.
Full text available.Received: (at 70383) by debbugs.gnu.org; 14 Apr 2024 16:46:41 +0000 From debbugs-submit-bounces <at> debbugs.gnu.org Sun Apr 14 12:46:41 2024 Received: from localhost ([127.0.0.1]:36088 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from <debbugs-submit-bounces <at> debbugs.gnu.org>) id 1rw304-0006C0-UI for submit <at> debbugs.gnu.org; Sun, 14 Apr 2024 12:46:41 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]:46022) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from <eliz@HIDDEN>) id 1rw302-0006AW-7I for 70383 <at> debbugs.gnu.org; Sun, 14 Apr 2024 12:46:38 -0400 Received: from fencepost.gnu.org ([2001:470:142:3::e]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from <eliz@HIDDEN>) id 1rw2zl-0001hK-LG; Sun, 14 Apr 2024 12:46:21 -0400 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=gnu.org; s=fencepost-gnu-org; h=MIME-version:References:Subject:In-Reply-To:To:From: Date; bh=MwLJNCL3vGPQM+HeZYGZ8cjc4RqZqh1yMdCe4EXBxkE=; b=l9sVY3sn5uWDsEspB3D1 sbeyKyPsLY1f5GvkLBV2wUXVd1uCVCJPEBjWH9AUHIJwpnEqhxRoc8z0MW2ZkswEy2r3Vjpv2OSNX Dq2oMkwwAsy4QnvNV3sOp2y3moWJD8VZkudkkZ1OsuVHzof/ROOtvYS3hAodYNEIVdRfvf9tKFXAw qtd9FN8wiF7xAlSoILoo7WMVoTFgWhi/fJxK15q14epuZlXlKyYp0zl0ttzlGnDCU6C0tw087aEje T33O13VetFS/KXuzd540MqbXu3FurPkpkGtYTgGMRn41uGi3o//pIb18282XhaxhkYTT9MPrBjsLM HPFTL+ceO/id8Q==; Date: Sun, 14 Apr 2024 19:46:19 +0300 Message-Id: <868r1fnb8k.fsf@HIDDEN> From: Eli Zaretskii <eliz@HIDDEN> To: Alastair Irving <alastair.j.irving@HIDDEN>, Jostein =?utf-8?Q?Kj=C3=B8nigsen?= <jostein@HIDDEN>, Yuan Fu <casouri@HIDDEN> In-Reply-To: <45347c16-6e54-4598-8ac9-33f56f65e106@HIDDEN> (message from Alastair Irving on Sun, 14 Apr 2024 11:25:08 +0100) Subject: Re: bug#70383: Conf-mode[toml] badly set face property References: <45347c16-6e54-4598-8ac9-33f56f65e106@HIDDEN> MIME-version: 1.0 Content-type: text/plain; charset=utf-8 Content-Transfer-Encoding: 8bit X-Spam-Score: -2.3 (--) X-Debbugs-Envelope-To: 70383 Cc: 70383 <at> debbugs.gnu.org X-BeenThere: debbugs-submit <at> debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: <debbugs-submit.debbugs.gnu.org> List-Unsubscribe: <https://debbugs.gnu.org/cgi-bin/mailman/options/debbugs-submit>, <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=unsubscribe> List-Archive: <https://debbugs.gnu.org/cgi-bin/mailman/private/debbugs-submit/> List-Post: <mailto:debbugs-submit <at> debbugs.gnu.org> List-Help: <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=help> List-Subscribe: <https://debbugs.gnu.org/cgi-bin/mailman/listinfo/debbugs-submit>, <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=subscribe> Errors-To: debbugs-submit-bounces <at> debbugs.gnu.org Sender: "Debbugs-submit" <debbugs-submit-bounces <at> debbugs.gnu.org> X-Spam-Score: -3.3 (---) > Date: Sun, 14 Apr 2024 11:25:08 +0100 > From: Alastair Irving <alastair.j.irving@HIDDEN> > > When editting TOML files with conf-mode[toml] the face property is being > set badly on certain characters. This occurs in Emacs 29.3 (running > with -q) but has been present in older versions. Steps to reproduce: > > 1. Create a file test.toml containing the following: > > > [package] > name = "test" > # See more keys and their definitions at > https://doc.rust-lang.org/cargo/reference/manifest.html > [dependencies] > > 2. Navigate to the d in dependencies and evaluate > > (text-properties-at (point)) > > The output for me looks like > > (face (font-lock-type-face font-lock-type-face font-lock-type-face > font-lock-type-face font-lock-type-face font-lock-ty\ > pe-face font-lock-type-face font-lock-type-face font-lock-type-face > font-lock-type-face > > > It looks like something is wrong in the font-lock setup and the same > face is being applied very many times. I cannot reproduce this here, neither in Emacs 29 nor in Emacs 30. What version of the TOML grammar library are you using? Jostein and Yuan, can you please look into this?
bug-gnu-emacs@HIDDEN
:bug#70383
; Package emacs
.
Full text available.Received: (at submit) by debbugs.gnu.org; 14 Apr 2024 15:20:23 +0000 From debbugs-submit-bounces <at> debbugs.gnu.org Sun Apr 14 11:20:23 2024 Received: from localhost ([127.0.0.1]:35972 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from <debbugs-submit-bounces <at> debbugs.gnu.org>) id 1rw1eY-0006v5-Sn for submit <at> debbugs.gnu.org; Sun, 14 Apr 2024 11:20:23 -0400 Received: from lists.gnu.org ([2001:470:142::17]:54802) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from <alastair.j.irving@HIDDEN>) id 1rvx3O-0006uu-7p for submit <at> debbugs.gnu.org; Sun, 14 Apr 2024 06:25:45 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from <alastair.j.irving@HIDDEN>) id 1rvx36-0004J5-EO for bug-gnu-emacs@HIDDEN; Sun, 14 Apr 2024 06:25:24 -0400 Received: from mail-wr1-x42d.google.com ([2a00:1450:4864:20::42d]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from <alastair.j.irving@HIDDEN>) id 1rvx32-0000jv-Fz for bug-gnu-emacs@HIDDEN; Sun, 14 Apr 2024 06:25:21 -0400 Received: by mail-wr1-x42d.google.com with SMTP id ffacd0b85a97d-347aa00e3c8so78846f8f.1 for <bug-gnu-emacs@HIDDEN>; Sun, 14 Apr 2024 03:25:12 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1713090309; x=1713695109; darn=gnu.org; h=content-transfer-encoding:subject:from:to:content-language :user-agent:mime-version:date:message-id:from:to:cc:subject:date :message-id:reply-to; bh=eDxZDgIYJuf8nleVV72a8ZVA/ddIPJECgnVLMM2KAYc=; b=UTlm+Yfwu2TLvu7p4g4iA4cFayOAPtfUvbUQ+Bk0zsT40LYWN9iIgSDp+31nLf5O8G nSzXGxtpn7tEO07OJYdCRgR6hg39QZBlT5tEMKYynfuuNMpBCLtZ0GLWnV2QuwRpTwKx HsB2kXBJ0D7QbUcbXwCkNJvMVVeEZ30gaCCNgEirwwMG4aYWYn9X0jDi/v59HcRAqdML 6a4POVha2jWKfhlXjpuabtRu1fI2jviVy1oXb/d5Qts60Bi17ycZdH3MbEkvUJor/omq DwcmqT1GhHjNX+4MzvqMEKqNWmHD/Anp6HYSHSx434IQE23J1rO4wWjygVGqT9hlH+jk FDpg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1713090309; x=1713695109; h=content-transfer-encoding:subject:from:to:content-language :user-agent:mime-version:date:message-id:x-gm-message-state:from:to :cc:subject:date:message-id:reply-to; bh=eDxZDgIYJuf8nleVV72a8ZVA/ddIPJECgnVLMM2KAYc=; b=V3mCyuYkqZ+xptaUUBBUnRXFZRfHYsVAPO8kiW4DUWkzPeBgHdaquxp4zRUCF4rfO8 F4hLjFFX9e1PhyAAII9m59qqSkETPiZDQ+gzuZ/l4ZaJ1vGCtz8qEDG0GJN7GR0hWgvY LjlQuI4EdxkceTXy8+jBZcw/KXAvOwWZFgSumdLNfp/IXQANDw4DD4HtiiapplhSkL3E 9xmEEtGOZ77fgtLaP/X1QNIYvSOI5SF8H3h70K5EwWdT4VsbO4JlfXWtvU0BKaxMBTAb BFnbr1xTrNhLCpAgcdPi0q/+edq//Cm5byxZ3nuomKbrNvRk/OPukiw47hUR24Js4nWc T+qw== X-Gm-Message-State: AOJu0YzT8Y+MaKmczyn+DolhmSbUZPR5mxdsNHUCSNsaKClJnkN0dFcM b+BoiaHBv9oGPjpWe3MCV1gVjYFcBxBTwvOBaANrX+QG6qe165X3JvRbDg== X-Google-Smtp-Source: AGHT+IGHUYBrECghkPPyiRjk8RplXk+fdB8e28GWqqvcJ+4u4c/ifeMBQPSkA/tS1gw4BvqHyHENuQ== X-Received: by 2002:a5d:4e0e:0:b0:342:d5ac:c712 with SMTP id p14-20020a5d4e0e000000b00342d5acc712mr6065653wrt.7.1713090309399; Sun, 14 Apr 2024 03:25:09 -0700 (PDT) Received: from ?IPV6:2a02:c7c:8239:f200:9123:6aed:6f92:203a? ([2a02:c7c:8239:f200:9123:6aed:6f92:203a]) by smtp.googlemail.com with ESMTPSA id r26-20020adfb1da000000b0033e745b8bcfsm8845868wra.88.2024.04.14.03.25.08 for <bug-gnu-emacs@HIDDEN> (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Sun, 14 Apr 2024 03:25:09 -0700 (PDT) Message-ID: <45347c16-6e54-4598-8ac9-33f56f65e106@HIDDEN> Date: Sun, 14 Apr 2024 11:25:08 +0100 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Content-Language: en-GB To: bug-gnu-emacs@HIDDEN From: Alastair Irving <alastair.j.irving@HIDDEN> Subject: Conf-mode[toml] badly set face property Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 8bit Received-SPF: pass client-ip=2a00:1450:4864:20::42d; envelope-from=alastair.j.irving@HIDDEN; helo=mail-wr1-x42d.google.com X-Spam_score_int: -20 X-Spam_score: -2.1 X-Spam_bar: -- X-Spam_report: (-2.1 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, FREEMAIL_FROM=0.001, RCVD_IN_DNSWL_NONE=-0.0001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-Spam-Score: 1.0 (+) X-Debbugs-Envelope-To: submit X-Mailman-Approved-At: Sun, 14 Apr 2024 11:20:21 -0400 X-BeenThere: debbugs-submit <at> debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: <debbugs-submit.debbugs.gnu.org> List-Unsubscribe: <https://debbugs.gnu.org/cgi-bin/mailman/options/debbugs-submit>, <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=unsubscribe> List-Archive: <https://debbugs.gnu.org/cgi-bin/mailman/private/debbugs-submit/> List-Post: <mailto:debbugs-submit <at> debbugs.gnu.org> List-Help: <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=help> List-Subscribe: <https://debbugs.gnu.org/cgi-bin/mailman/listinfo/debbugs-submit>, <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=subscribe> Errors-To: debbugs-submit-bounces <at> debbugs.gnu.org Sender: "Debbugs-submit" <debbugs-submit-bounces <at> debbugs.gnu.org> X-Spam-Score: -0.0 (/) When editting TOML files with conf-mode[toml] the face property is being set badly on certain characters. This occurs in Emacs 29.3 (running with -q) but has been present in older versions. Steps to reproduce: 1. Create a file test.toml containing the following: [package] name = "test" # See more keys and their definitions at https://doc.rust-lang.org/cargo/reference/manifest.html [dependencies] 2. Navigate to the d in dependencies and evaluate (text-properties-at (point)) The output for me looks like (face (font-lock-type-face font-lock-type-face font-lock-type-face font-lock-type-face font-lock-type-face font-lock-ty\ pe-face font-lock-type-face font-lock-type-face font-lock-type-face font-lock-type-face It looks like something is wrong in the font-lock setup and the same face is being applied very many times.
Alastair Irving <alastair.j.irving@HIDDEN>
:bug-gnu-emacs@HIDDEN
.
Full text available.bug-gnu-emacs@HIDDEN
:bug#70383
; Package emacs
.
Full text available.
GNU bug tracking system
Copyright (C) 1999 Darren O. Benham,
1997 nCipher Corporation Ltd,
1994-97 Ian Jackson.