Yuan Fu <casouri@HIDDEN>
to control <at> debbugs.gnu.org.
Full text available.Received: (at 70478) by debbugs.gnu.org; 21 Apr 2024 23:40:17 +0000 From debbugs-submit-bounces <at> debbugs.gnu.org Sun Apr 21 19:40:17 2024 Received: from localhost ([127.0.0.1]:45250 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from <debbugs-submit-bounces <at> debbugs.gnu.org>) id 1rygnB-0004G4-EB for submit <at> debbugs.gnu.org; Sun, 21 Apr 2024 19:40:17 -0400 Received: from mail-ot1-x32f.google.com ([2607:f8b0:4864:20::32f]:52733) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from <casouri@HIDDEN>) id 1rygn8-0004F4-Ak for 70478 <at> debbugs.gnu.org; Sun, 21 Apr 2024 19:40:16 -0400 Received: by mail-ot1-x32f.google.com with SMTP id 46e09a7af769-6eb797e10ceso2375236a34.1 for <70478 <at> debbugs.gnu.org>; Sun, 21 Apr 2024 16:39:58 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1713742793; x=1714347593; darn=debbugs.gnu.org; h=to:references:message-id:content-transfer-encoding:cc:date :in-reply-to:from:subject:mime-version:from:to:cc:subject:date :message-id:reply-to; bh=8ihJF7129D/5VCU6PqDAqasebIa5REw+k5nHc/CU1to=; b=RpVxy1VjgNClDP3nrrSsS3VfRFhLzdq+znzXaJpjur342QJdaLYcL7q0mAlksz/sKf p5DK4y2w8RfWSfbvnnBd4YyxqJ0oC4vCSKh8w3291ARgn6fsVP4+Jdf/1CDQyCKR0U// 2JWR4UmbfwxN5NXlVOXOnlRXpoDwFfcARg0+0MsLkuMrD0AEKFDhK/amMtOrVznNm22S 1MAyw5f/kTumqew+7w5zCGE/6Rhm5/tydnRKuV3pZKiVbf1CqnXJpC4EhNTkhtnHZvcR vkuFKXzv3VS98q6MBreSUwk82tC5BdtMm2gA8B+KiGmyZ+DgObW1SkD3DdDUhVZVv7O1 s/CQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1713742793; x=1714347593; h=to:references:message-id:content-transfer-encoding:cc:date :in-reply-to:from:subject:mime-version:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=8ihJF7129D/5VCU6PqDAqasebIa5REw+k5nHc/CU1to=; b=Ou/3dzwR/9CR0t85WvyuWAx4PjclLS6tyUBdH8PSvXRH3XoHFG6CpdHDULufezONtA RP70lrBW5Bs76P8TAuC78+CTWQEbrEk/CU3rx65JSCKzCPjgWrDxV/RA6PcH5NUAMDgD bGp8agMLE+Bvy8uxrEMUUFUfaOlaDOd8k7tKHdz6GUsTLJmnKXeHdFWW0Upj5YHaqG/j FYJlvaFIULphM5wKJO7w7o2PS8iJfximSeS6n0I+JltFIiU2rRTU/yBW/0EtoAiIxHKV EWLaeljeqitHDF492fTMX/Was+QObDLClBFrwv2TCYvcSnyeoAD2uH/AAF4hdj0C+pql frgw== X-Forwarded-Encrypted: i=1; AJvYcCVmjWshOtxmuY9hADOyM9k5R3wlm2kPkaTIFvBssU2UDmr5Mey+PqzuLrqEh0fnRsWXozomGCV3pWewf6iEOEUyoiz5CDE= X-Gm-Message-State: AOJu0YwYLtMQ6oxZw5wmJrnaFJcRxF4DJVNwYvCB/8EPRYZJT6Gf1pHX UQ/IPK6pJ7zjvTmY48J3PQn8JY63lat1aVa8u0kJUlKuw7xATIH5 X-Google-Smtp-Source: AGHT+IGO8p3anqwp3wy5W/Gf4w/B9+ZTsMVtrZCYrg7xX7in6K5CC0I1ZxaaPzj3SApH4EM6j9e8xw== X-Received: by 2002:a05:6830:e89:b0:6eb:e1ba:6648 with SMTP id dp9-20020a0568300e8900b006ebe1ba6648mr5762353otb.1.1713742792877; Sun, 21 Apr 2024 16:39:52 -0700 (PDT) Received: from smtpclient.apple ([2601:641:300:4910:e4f6:f0b8:c91d:e40b]) by smtp.gmail.com with ESMTPSA id z23-20020a656657000000b005f8072699e1sm3299639pgv.45.2024.04.21.16.39.51 (version=TLS1_2 cipher=ECDHE-ECDSA-AES128-GCM-SHA256 bits=128/128); Sun, 21 Apr 2024 16:39:52 -0700 (PDT) Content-Type: text/plain; charset=utf-8 Mime-Version: 1.0 (Mac OS X Mail 16.0 \(3731.700.6.1.1\)) Subject: Re: bug#70478: 30.0.50; [PATCH] Fix treesitter-font-lock-settings for built-in functions and attributes. From: Yuan Fu <casouri@HIDDEN> In-Reply-To: <86a5ln8ev5.fsf@HIDDEN> Date: Sun, 21 Apr 2024 16:39:40 -0700 Content-Transfer-Encoding: quoted-printable Message-Id: <BD3D25F0-9677-471A-920C-9F5C1C44D9CF@HIDDEN> References: <CALFrjHzHr=T3S7UsCBzrLoQ34y5hqGBYkqaXTx04ooAo9qz1LQ@HIDDEN> <86le58a7dv.fsf@HIDDEN> <CALFrjHyFMzoe8N+dnHDE8s59ghKktAFAS=8gg02wQC-zA9zi-Q@HIDDEN> <CALFrjHx+UoQZrQMRy9DD5wvAS8D6FemdH=gKgUfk54796V+Qjg@HIDDEN> <86edb0a3bq.fsf@HIDDEN> <CALFrjHyiuPO017_uQxSxq+oS2Hn6pFrP=EUOJTvvFGaw+gU5YA@HIDDEN> <7587CCB2-559E-46D7-B497-668477F41CF4@HIDDEN> <86a5ln8ev5.fsf@HIDDEN> To: Eli Zaretskii <eliz@HIDDEN> X-Mailer: Apple Mail (2.3731.700.6.1.1) X-Spam-Score: 0.0 (/) X-Debbugs-Envelope-To: 70478 Cc: Prateek Sharma <ps.prateek.sharma143@HIDDEN>, 70478 <at> debbugs.gnu.org X-BeenThere: debbugs-submit <at> debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: <debbugs-submit.debbugs.gnu.org> List-Unsubscribe: <https://debbugs.gnu.org/cgi-bin/mailman/options/debbugs-submit>, <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=unsubscribe> List-Archive: <https://debbugs.gnu.org/cgi-bin/mailman/private/debbugs-submit/> List-Post: <mailto:debbugs-submit <at> debbugs.gnu.org> List-Help: <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=help> List-Subscribe: <https://debbugs.gnu.org/cgi-bin/mailman/listinfo/debbugs-submit>, <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=subscribe> Errors-To: debbugs-submit-bounces <at> debbugs.gnu.org Sender: "Debbugs-submit" <debbugs-submit-bounces <at> debbugs.gnu.org> X-Spam-Score: -1.0 (-) > On Apr 20, 2024, at 10:27 PM, Eli Zaretskii <eliz@HIDDEN> wrote: >=20 >> From: Yuan Fu <casouri@HIDDEN> >> Date: Sat, 20 Apr 2024 20:47:29 -0700 >> Cc: Eli Zaretskii <eliz@HIDDEN>, >> 70478 <at> debbugs.gnu.org >>=20 >>> On Sat, Apr 20, 2024 at 1:11=E2=80=AFPM Eli Zaretskii <eliz@HIDDEN> = wrote: >>>> From: Prateek Sharma <ps.prateek.sharma143@HIDDEN> >>>> Date: Sat, 20 Apr 2024 12:25:24 +0530 >>>> Cc: Yuan Fu <casouri@HIDDEN>, 70478 <at> debbugs.gnu.org >>>>=20 >>>> Also should I squash the changes of both the above commits into one = and then create a patch file? >>>=20 >>> You should squash, yes. Other than that, attaching the patches as = you >>> did is fine. >>>=20 >>> Thanks. >>> <0001-Fix-treesitter-font-lock-settings-for-built-in-funct.patch> >>=20 >> Thanks! Should I apply this to master or emacs-29? It=E2=80=99s a fix = so I think emacs-29? >=20 > Yes, emacs-29 is fine. Merged. BTW, Prateek, make sure to wrap the title and body of the commit = message, and not end the title with a period. =F0=9F=98=8A Yuan=
bug-gnu-emacs@HIDDEN:bug#70478; Package emacs.
Full text available.Received: (at 70478) by debbugs.gnu.org; 21 Apr 2024 05:28:13 +0000 From debbugs-submit-bounces <at> debbugs.gnu.org Sun Apr 21 01:28:12 2024 Received: from localhost ([127.0.0.1]:40693 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from <debbugs-submit-bounces <at> debbugs.gnu.org>) id 1ryPkK-0006bp-6O for submit <at> debbugs.gnu.org; Sun, 21 Apr 2024 01:28:12 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]:47700) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from <eliz@HIDDEN>) id 1ryPkI-0006aw-BW for 70478 <at> debbugs.gnu.org; Sun, 21 Apr 2024 01:28:10 -0400 Received: from fencepost.gnu.org ([2001:470:142:3::e]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from <eliz@HIDDEN>) id 1ryPjs-0000WP-MU; Sun, 21 Apr 2024 01:27:48 -0400 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=gnu.org; s=fencepost-gnu-org; h=MIME-version:References:Subject:In-Reply-To:To:From: Date; bh=Ube1dYJwfUI1yWhE8M+PUhzqbOYOiGialNq9fePzs50=; b=o9WquZ9pdTeQytyd+Kg/ j6ZsQv1Ygh2N6RG5ngWdjfLJL+uX+YoZArcsYkwbMMoh3km7AgfVN+dLASLK3FCkxSu+3XU43ZxiL 3H0p1s+skmbFIl2X4SMc0rkw7dQnqHSM/fujoOm+6ayUPv4LgzUzPGXzF8CI5J36wWqwGmCivyCV3 BRPrMIxB8g0Kzx+7gudQS4PrlprfKpDpFlepRVom2blJ8Jz6CpajQn7yFQlV3XxqdHomy1o+XYyZr liIF4NQY9Cvt38AstdFd1e67JLKs/HNNffCrhXU+Rfb5Bfq/AHIK4I+wbXV8iSOQq3NKDnZYBjlj+ zw2GEJqwkwqR7A==; Date: Sun, 21 Apr 2024 08:27:26 +0300 Message-Id: <86a5ln8ev5.fsf@HIDDEN> From: Eli Zaretskii <eliz@HIDDEN> To: Yuan Fu <casouri@HIDDEN> In-Reply-To: <7587CCB2-559E-46D7-B497-668477F41CF4@HIDDEN> (message from Yuan Fu on Sat, 20 Apr 2024 20:47:29 -0700) Subject: Re: bug#70478: 30.0.50; [PATCH] Fix treesitter-font-lock-settings for built-in functions and attributes. References: <CALFrjHzHr=T3S7UsCBzrLoQ34y5hqGBYkqaXTx04ooAo9qz1LQ@HIDDEN> <86le58a7dv.fsf@HIDDEN> <CALFrjHyFMzoe8N+dnHDE8s59ghKktAFAS=8gg02wQC-zA9zi-Q@HIDDEN> <CALFrjHx+UoQZrQMRy9DD5wvAS8D6FemdH=gKgUfk54796V+Qjg@HIDDEN> <86edb0a3bq.fsf@HIDDEN> <CALFrjHyiuPO017_uQxSxq+oS2Hn6pFrP=EUOJTvvFGaw+gU5YA@HIDDEN> <7587CCB2-559E-46D7-B497-668477F41CF4@HIDDEN> MIME-version: 1.0 Content-type: text/plain; charset=utf-8 Content-Transfer-Encoding: 8bit X-Spam-Score: -2.3 (--) X-Debbugs-Envelope-To: 70478 Cc: ps.prateek.sharma143@HIDDEN, 70478 <at> debbugs.gnu.org X-BeenThere: debbugs-submit <at> debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: <debbugs-submit.debbugs.gnu.org> List-Unsubscribe: <https://debbugs.gnu.org/cgi-bin/mailman/options/debbugs-submit>, <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=unsubscribe> List-Archive: <https://debbugs.gnu.org/cgi-bin/mailman/private/debbugs-submit/> List-Post: <mailto:debbugs-submit <at> debbugs.gnu.org> List-Help: <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=help> List-Subscribe: <https://debbugs.gnu.org/cgi-bin/mailman/listinfo/debbugs-submit>, <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=subscribe> Errors-To: debbugs-submit-bounces <at> debbugs.gnu.org Sender: "Debbugs-submit" <debbugs-submit-bounces <at> debbugs.gnu.org> X-Spam-Score: -3.3 (---) > From: Yuan Fu <casouri@HIDDEN> > Date: Sat, 20 Apr 2024 20:47:29 -0700 > Cc: Eli Zaretskii <eliz@HIDDEN>, > 70478 <at> debbugs.gnu.org > > > On Sat, Apr 20, 2024 at 1:11 PM Eli Zaretskii <eliz@HIDDEN> wrote: > > > From: Prateek Sharma <ps.prateek.sharma143@HIDDEN> > > > Date: Sat, 20 Apr 2024 12:25:24 +0530 > > > Cc: Yuan Fu <casouri@HIDDEN>, 70478 <at> debbugs.gnu.org > > > > > > Also should I squash the changes of both the above commits into one and then create a patch file? > > > > You should squash, yes. Other than that, attaching the patches as you > > did is fine. > > > > Thanks. > > <0001-Fix-treesitter-font-lock-settings-for-built-in-funct.patch> > > Thanks! Should I apply this to master or emacs-29? It’s a fix so I think emacs-29? Yes, emacs-29 is fine.
bug-gnu-emacs@HIDDEN:bug#70478; Package emacs.
Full text available.Received: (at 70478) by debbugs.gnu.org; 21 Apr 2024 05:17:18 +0000 From debbugs-submit-bounces <at> debbugs.gnu.org Sun Apr 21 01:17:18 2024 Received: from localhost ([127.0.0.1]:40649 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from <debbugs-submit-bounces <at> debbugs.gnu.org>) id 1ryPZl-0005Lu-Pl for submit <at> debbugs.gnu.org; Sun, 21 Apr 2024 01:17:18 -0400 Received: from mail-vs1-xe29.google.com ([2607:f8b0:4864:20::e29]:56351) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from <ps.prateek.sharma143@HIDDEN>) id 1ryPZk-0005Li-RL for 70478 <at> debbugs.gnu.org; Sun, 21 Apr 2024 01:17:17 -0400 Received: by mail-vs1-xe29.google.com with SMTP id ada2fe7eead31-479e857876fso1173408137.0 for <70478 <at> debbugs.gnu.org>; Sat, 20 Apr 2024 22:17:01 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1713676616; x=1714281416; darn=debbugs.gnu.org; h=cc:to:subject:message-id:date:from:in-reply-to:references :mime-version:from:to:cc:subject:date:message-id:reply-to; bh=rfudxBnkpkSJtUHBS99x+ydjMV4nMhfb8cGlOrF7gpk=; b=EV+uQOOa/N/eGOu1Q6KjpSFSfhWnVm7b+ZbRbl09P8tzqO+LdJsTWpFrfqm8OvL6bW Cp3fcUCbvJyLiO6jbWIbZsglsafm0ygpSH+OEOSP8YhFtvssEN08z8AWHfw+HcfndOwH WwhwVhdYfquB0AmERUhFgeJzXij6KQTdlNJnvgfiZ4tYQpA+GKAj5gZLrQbfbQCdilNu I8GDvaD+LoPH8X9LmD9n2pfRGzXPS4ikjnlPGskj00QDOn4BZnBJY3nImqMu82q61aak 6gNmKkLl6kkfjPTjPYOos3Imn7ejgkn1FesRy2g6549DptpoXZIdr1/afJ94mnjhf1jb KXYA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1713676616; x=1714281416; h=cc:to:subject:message-id:date:from:in-reply-to:references :mime-version:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=rfudxBnkpkSJtUHBS99x+ydjMV4nMhfb8cGlOrF7gpk=; b=q2eQufHSqusmQ2v9XnxLffGb6jUrG5xrGpwUMQfSx60P72B2y0OAajaRCYqzqncMhw i3kDvcBSAVH91uh2DM5pjxduE5B9Hixt46IAvXgKXHRWRvfT8qBuBFuVWtZW3SkeQtB+ hQtgcK/ytc7XysDHGeVlNUtYUHFI1OO/woNpc8RwDI/qWauRBaI1GOIrVeu8KIx38ZZz TW3Sms250ROWqYlvKMexqIEf4GDTgCTViXpdWxw+9FEh4xVCqLNE3rR3aNSSJ7q8KrVV LcTWseiy5qgYRTFeXNizZBJgSLPfF9oH4hhSA3I84NErIX/rCYl13Zcx7GBy6Q7qhDLe n1jw== X-Forwarded-Encrypted: i=1; AJvYcCUs2/kgyO30yqjyjLOTFoVeWgv0XFENT0L9k1eqc071pbvaFIniC6VSGWID6jDn6WorWweXSf3Yb7pphKHE98UGfMEg2FY= X-Gm-Message-State: AOJu0YyBI7PojbRsu+8vofukEVw8cNEG4WhqbI4iqycdK41/ZS9/wbpL CBbHQs1vjiseF9ZBkOpjWo7ZGZAVEPEyfTL1JZmt/INyXxSWKFcatlAMcCfcKiE30vVLbYY9uEp k+VsPactWvbKn29AFEh5ZpApUO7Y= X-Google-Smtp-Source: AGHT+IHkfM+Pl8Uq5FiojunD7KCPRIncnLMdhzVoCZzBzVruTNRO3x6Da2vR/5TexmpBaNJx5RHm6GnrDnTglRABzAk= X-Received: by 2002:a67:bb08:0:b0:47a:31f9:163b with SMTP id m8-20020a67bb08000000b0047a31f9163bmr7494018vsn.13.1713676616138; Sat, 20 Apr 2024 22:16:56 -0700 (PDT) MIME-Version: 1.0 References: <CALFrjHzHr=T3S7UsCBzrLoQ34y5hqGBYkqaXTx04ooAo9qz1LQ@HIDDEN> <86le58a7dv.fsf@HIDDEN> <CALFrjHyFMzoe8N+dnHDE8s59ghKktAFAS=8gg02wQC-zA9zi-Q@HIDDEN> <CALFrjHx+UoQZrQMRy9DD5wvAS8D6FemdH=gKgUfk54796V+Qjg@HIDDEN> <86edb0a3bq.fsf@HIDDEN> <CALFrjHyiuPO017_uQxSxq+oS2Hn6pFrP=EUOJTvvFGaw+gU5YA@HIDDEN> <7587CCB2-559E-46D7-B497-668477F41CF4@HIDDEN> In-Reply-To: <7587CCB2-559E-46D7-B497-668477F41CF4@HIDDEN> From: Prateek Sharma <ps.prateek.sharma143@HIDDEN> Date: Sun, 21 Apr 2024 10:46:44 +0530 Message-ID: <CALFrjHyGLqtzBLaVUU6U_NPGkV-XbFt6iyakmoH-pDtuxFicqQ@HIDDEN> Subject: Re: bug#70478: 30.0.50; [PATCH] Fix treesitter-font-lock-settings for built-in functions and attributes. To: Yuan Fu <casouri@HIDDEN> Content-Type: multipart/alternative; boundary="000000000000f708750616946d3f" X-Spam-Score: 0.3 (/) X-Debbugs-Envelope-To: 70478 Cc: Eli Zaretskii <eliz@HIDDEN>, 70478 <at> debbugs.gnu.org X-BeenThere: debbugs-submit <at> debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: <debbugs-submit.debbugs.gnu.org> List-Unsubscribe: <https://debbugs.gnu.org/cgi-bin/mailman/options/debbugs-submit>, <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=unsubscribe> List-Archive: <https://debbugs.gnu.org/cgi-bin/mailman/private/debbugs-submit/> List-Post: <mailto:debbugs-submit <at> debbugs.gnu.org> List-Help: <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=help> List-Subscribe: <https://debbugs.gnu.org/cgi-bin/mailman/listinfo/debbugs-submit>, <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=subscribe> Errors-To: debbugs-submit-bounces <at> debbugs.gnu.org Sender: "Debbugs-submit" <debbugs-submit-bounces <at> debbugs.gnu.org> X-Spam-Score: -0.7 (/) --000000000000f708750616946d3f Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable Well, I think emacs-29 also needs this fix. There is one other fix with indentation in python-ts-mode that is needed in emacs-29. But it's already fixed in emacs-30 as I've tested. On Sun, Apr 21, 2024 at 9:17=E2=80=AFAM Yuan Fu <casouri@HIDDEN> wrote: > > > > On Apr 20, 2024, at 12:53 AM, Prateek Sharma < > ps.prateek.sharma143@HIDDEN> wrote: > > > > Here is the patch for the squashed commit and updated code. Thanks for > helping me out! > > > > > > On Sat, Apr 20, 2024 at 1:11=E2=80=AFPM Eli Zaretskii <eliz@HIDDEN> wr= ote: > > > From: Prateek Sharma <ps.prateek.sharma143@HIDDEN> > > > Date: Sat, 20 Apr 2024 12:25:24 +0530 > > > Cc: Yuan Fu <casouri@HIDDEN>, 70478 <at> debbugs.gnu.org > > > > > > Also should I squash the changes of both the above commits into one > and then create a patch file? > > > > You should squash, yes. Other than that, attaching the patches as you > > did is fine. > > > > Thanks. > > <0001-Fix-treesitter-font-lock-settings-for-built-in-funct.patch> > > Thanks! Should I apply this to master or emacs-29? It=E2=80=99s a fix so = I think > emacs-29? > > Yuan --000000000000f708750616946d3f Content-Type: text/html; charset="UTF-8" Content-Transfer-Encoding: quoted-printable <div dir=3D"ltr">Well, I think emacs-29 also needs this fix.<div><br></div>= <div>There is one other fix with indentation in python-ts-mode that is need= ed in emacs-29. But it's already fixed in emacs-30 as I've tested.<= /div></div><br><div class=3D"gmail_quote"><div dir=3D"ltr" class=3D"gmail_a= ttr">On Sun, Apr 21, 2024 at 9:17=E2=80=AFAM Yuan Fu <<a href=3D"mailto:= casouri@HIDDEN">casouri@HIDDEN</a>> wrote:<br></div><blockquote cl= ass=3D"gmail_quote" style=3D"margin:0px 0px 0px 0.8ex;border-left:1px solid= rgb(204,204,204);padding-left:1ex"><br> <br> > On Apr 20, 2024, at 12:53 AM, Prateek Sharma <<a href=3D"mailto:ps.= prateek.sharma143@HIDDEN" target=3D"_blank">ps.prateek.sharma143@HIDDEN= om</a>> wrote:<br> > <br> > Here is the patch for the squashed commit and updated code. Thanks for= helping me out!<br> > <br> > <br> > On Sat, Apr 20, 2024 at 1:11=E2=80=AFPM Eli Zaretskii <<a href=3D"m= ailto:eliz@HIDDEN" target=3D"_blank">eliz@HIDDEN</a>> wrote:<br> > > From: Prateek Sharma <<a href=3D"mailto:ps.prateek.sharma143@g= mail.com" target=3D"_blank">ps.prateek.sharma143@HIDDEN</a>><br> > > Date: Sat, 20 Apr 2024 12:25:24 +0530<br> > > Cc: Yuan Fu <<a href=3D"mailto:casouri@HIDDEN" target=3D"_b= lank">casouri@HIDDEN</a>>, <a href=3D"mailto:70478 <at> debbugs.gnu.org" t= arget=3D"_blank">70478 <at> debbugs.gnu.org</a><br> > > <br> > > Also should I squash the changes of both the above commits into o= ne and then create a patch file?<br> > <br> > You should squash, yes.=C2=A0 Other than that, attaching the patches a= s you<br> > did is fine.<br> > <br> > Thanks.<br> > <0001-Fix-treesitter-font-lock-settings-for-built-in-funct.patch>= ;<br> <br> Thanks! Should I apply this to master or emacs-29? It=E2=80=99s a fix so I = think emacs-29?<br> <br> Yuan</blockquote></div> --000000000000f708750616946d3f--
bug-gnu-emacs@HIDDEN:bug#70478; Package emacs.
Full text available.Received: (at 70478) by debbugs.gnu.org; 21 Apr 2024 03:48:05 +0000 From debbugs-submit-bounces <at> debbugs.gnu.org Sat Apr 20 23:48:04 2024 Received: from localhost ([127.0.0.1]:40307 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from <debbugs-submit-bounces <at> debbugs.gnu.org>) id 1ryOBQ-0003C7-BU for submit <at> debbugs.gnu.org; Sat, 20 Apr 2024 23:48:04 -0400 Received: from mail-qk1-x72b.google.com ([2607:f8b0:4864:20::72b]:44438) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from <casouri@HIDDEN>) id 1ryOBN-0003B8-Q6 for 70478 <at> debbugs.gnu.org; Sat, 20 Apr 2024 23:48:02 -0400 Received: by mail-qk1-x72b.google.com with SMTP id af79cd13be357-78f02c96c52so221715485a.1 for <70478 <at> debbugs.gnu.org>; Sat, 20 Apr 2024 20:47:46 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1713671261; x=1714276061; darn=debbugs.gnu.org; h=to:references:message-id:content-transfer-encoding:cc:date :in-reply-to:from:subject:mime-version:from:to:cc:subject:date :message-id:reply-to; bh=qwLVa9SaLeINOz7iqh4K2HxirKkGSDzPrfr/9Ao+Gvc=; b=HUufhqVt2lhQ7H6zSUc8mMuA7aCxrV5GZdVYgayB2KTTI1MvtPB6PQ0abPfMwo2pHe n6Fh54zlicpLbEml01YM3hDJtiCyUGdHTMu/WojN/Iqrd3Bry4WZktLICPUvVioTwleW 6j7pvHUwGIC48vp270sWfGy6mkiju3rqfRcs6rOX7n6Q/Lck+9Fczo559x58r4qKamN9 Exhm08PCk+eIPo/KWp3F+YYl62dU49fshfBOdVpgpa8iloIpCnl3bgmIG1PqEh9kPvXd IUjJJl+CE1Qj91XGPgqe8V+AlLGXkhkeDpwVL15PABT+CjiGVqr7qBQK895KG9w6qZLP nVSg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1713671261; x=1714276061; h=to:references:message-id:content-transfer-encoding:cc:date :in-reply-to:from:subject:mime-version:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=qwLVa9SaLeINOz7iqh4K2HxirKkGSDzPrfr/9Ao+Gvc=; b=J/6QcNUAs+W8BWigX1XNHe/nPsxzr1z5DcGV40WVO4+lPXSd0mG3rnp3yxdVqXAqZv ISnDmejWl6IqxuYse2GjEvNC8jo+gWSQc2e/2m0+0RQxNQ/AmGP4G2/vSo+Ybg0rlV+I eBfq0Ak3V73fPS1G5fUped+Ntb3SxA6u3IFw3oRlERpyP4MNmCqH53s5ABiAV1n5sM8v NBTgPJrmvmxuZhab26PJx3nK21zNStaGIdtECeUXh24q8+HjSXd6F3tx4o+6mD3zwtGa bnzZJ76xfZKVQLfg1p1XkhJrkmVGpo2lTG3/DZiyK3MP4YKOAQo+xUGpqww8M3WVmiZD 97YQ== X-Forwarded-Encrypted: i=1; AJvYcCXr6kKwjKkH4AXEhXr6tLR+bUcGGkDq2cdBzLdaXzPUIPqdU8nCPooxhSndieYHFn24YRRgI0RL9jMAljt60/TJnAS1Jsc= X-Gm-Message-State: AOJu0YyrEFak/CQzm4JdH5tmX/vf/2CUPwxM7H6+oRu/oiPj65FwR5y/ a+NYN3GUXgHn6ws8EfnDP/m7dgBTbxC1DRm441DXxMEnn95NwXei X-Google-Smtp-Source: AGHT+IGFwioHpKnRXugS3rI8HeDkDP4zaJcJ+yrX29Bm312LbJKwCFPGKfwPuh8H/P3bwvgXzYoHSw== X-Received: by 2002:a05:620a:56c1:b0:78f:179e:9fd1 with SMTP id wh1-20020a05620a56c100b0078f179e9fd1mr6961832qkn.37.1713671260995; Sat, 20 Apr 2024 20:47:40 -0700 (PDT) Received: from smtpclient.apple ([208.95.235.149]) by smtp.gmail.com with ESMTPSA id q24-20020a637518000000b005dc4b562f6csm5365647pgc.3.2024.04.20.20.47.39 (version=TLS1_2 cipher=ECDHE-ECDSA-AES128-GCM-SHA256 bits=128/128); Sat, 20 Apr 2024 20:47:40 -0700 (PDT) Content-Type: text/plain; charset=utf-8 Mime-Version: 1.0 (Mac OS X Mail 16.0 \(3731.700.6.1.1\)) Subject: Re: bug#70478: 30.0.50; [PATCH] Fix treesitter-font-lock-settings for built-in functions and attributes. From: Yuan Fu <casouri@HIDDEN> In-Reply-To: <CALFrjHyiuPO017_uQxSxq+oS2Hn6pFrP=EUOJTvvFGaw+gU5YA@HIDDEN> Date: Sat, 20 Apr 2024 20:47:29 -0700 Content-Transfer-Encoding: quoted-printable Message-Id: <7587CCB2-559E-46D7-B497-668477F41CF4@HIDDEN> References: <CALFrjHzHr=T3S7UsCBzrLoQ34y5hqGBYkqaXTx04ooAo9qz1LQ@HIDDEN> <86le58a7dv.fsf@HIDDEN> <CALFrjHyFMzoe8N+dnHDE8s59ghKktAFAS=8gg02wQC-zA9zi-Q@HIDDEN> <CALFrjHx+UoQZrQMRy9DD5wvAS8D6FemdH=gKgUfk54796V+Qjg@HIDDEN> <86edb0a3bq.fsf@HIDDEN> <CALFrjHyiuPO017_uQxSxq+oS2Hn6pFrP=EUOJTvvFGaw+gU5YA@HIDDEN> To: Prateek Sharma <ps.prateek.sharma143@HIDDEN> X-Mailer: Apple Mail (2.3731.700.6.1.1) X-Spam-Score: 0.0 (/) X-Debbugs-Envelope-To: 70478 Cc: Eli Zaretskii <eliz@HIDDEN>, 70478 <at> debbugs.gnu.org X-BeenThere: debbugs-submit <at> debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: <debbugs-submit.debbugs.gnu.org> List-Unsubscribe: <https://debbugs.gnu.org/cgi-bin/mailman/options/debbugs-submit>, <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=unsubscribe> List-Archive: <https://debbugs.gnu.org/cgi-bin/mailman/private/debbugs-submit/> List-Post: <mailto:debbugs-submit <at> debbugs.gnu.org> List-Help: <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=help> List-Subscribe: <https://debbugs.gnu.org/cgi-bin/mailman/listinfo/debbugs-submit>, <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=subscribe> Errors-To: debbugs-submit-bounces <at> debbugs.gnu.org Sender: "Debbugs-submit" <debbugs-submit-bounces <at> debbugs.gnu.org> X-Spam-Score: -1.0 (-) > On Apr 20, 2024, at 12:53 AM, Prateek Sharma = <ps.prateek.sharma143@HIDDEN> wrote: >=20 > Here is the patch for the squashed commit and updated code. Thanks for = helping me out! >=20 >=20 > On Sat, Apr 20, 2024 at 1:11=E2=80=AFPM Eli Zaretskii <eliz@HIDDEN> = wrote: > > From: Prateek Sharma <ps.prateek.sharma143@HIDDEN> > > Date: Sat, 20 Apr 2024 12:25:24 +0530 > > Cc: Yuan Fu <casouri@HIDDEN>, 70478 <at> debbugs.gnu.org > >=20 > > Also should I squash the changes of both the above commits into one = and then create a patch file? >=20 > You should squash, yes. Other than that, attaching the patches as you > did is fine. >=20 > Thanks. > <0001-Fix-treesitter-font-lock-settings-for-built-in-funct.patch> Thanks! Should I apply this to master or emacs-29? It=E2=80=99s a fix so = I think emacs-29? Yuan=
bug-gnu-emacs@HIDDEN:bug#70478; Package emacs.
Full text available.Received: (at 70478) by debbugs.gnu.org; 20 Apr 2024 07:54:09 +0000 From debbugs-submit-bounces <at> debbugs.gnu.org Sat Apr 20 03:54:09 2024 Received: from localhost ([127.0.0.1]:34912 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from <debbugs-submit-bounces <at> debbugs.gnu.org>) id 1ry5Y0-000752-IO for submit <at> debbugs.gnu.org; Sat, 20 Apr 2024 03:54:08 -0400 Received: from mail-oo1-xc30.google.com ([2607:f8b0:4864:20::c30]:58554) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from <ps.prateek.sharma143@HIDDEN>) id 1ry5Xy-00073h-CN for 70478 <at> debbugs.gnu.org; Sat, 20 Apr 2024 03:54:07 -0400 Received: by mail-oo1-xc30.google.com with SMTP id 006d021491bc7-5aa400b917dso1944344eaf.0 for <70478 <at> debbugs.gnu.org>; Sat, 20 Apr 2024 00:53:51 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1713599626; x=1714204426; darn=debbugs.gnu.org; h=cc:to:subject:message-id:date:from:in-reply-to:references :mime-version:from:to:cc:subject:date:message-id:reply-to; bh=pOPVtGfrE93/tZIZ+l5Ujn4ZY9x9f04rTU/one2hHZ8=; b=Knq9RMiJ//Fz2zbNCs4bAVYnNWC2mHWyqo3lJ2uGU6arbQbTVkeq7V6Lh+u3x3D/hC /OJ3zYDQ2/sbSLS+RUdYtpCjefpz8u73cP3oYRhmpVJhlD16P1aIAzoUM5Z7aaaW3gew mBwnuw6ipOv/2Bqa+EAWQ9M4mfpM0mQFaFYxWcY88u1lCBpGPPg5VuX9SOpsjJWvNSxo W0zVql6Sys2pNOfrCJUhp1/JwssnN5MDShSAm08tzbMZHHQNYVo+oFrmmOWrfH14WkDI DSolzUaEvEiznJ18NpONa9c6DZX5w5FGeGnLu5RvMUViPxHKA7nbtdHDyGb8d5jtF/Y7 zZJw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1713599626; x=1714204426; h=cc:to:subject:message-id:date:from:in-reply-to:references :mime-version:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=pOPVtGfrE93/tZIZ+l5Ujn4ZY9x9f04rTU/one2hHZ8=; b=dhqvSJ3lg4ZqZ3VF183CcG/iCjV2sWSk7ce3IE7iN2D1PgDuHbA/MicSlA6Q0QYlEj nJNNjqZo9htTxKxaTniLx0vnt+dSIeRWOyiJpVslvshLVTGJi52pa9gFpinb0E8e0XRf +noRkY0d8D8ECa5TsBayJTHCOismoR2EOQ7U/gGwash5fXCirdq3gsG6QVqm1EulMdkZ F+LgfPp+9qnIgTjc3gHAkx2tpbtdOMG7JFe6lCrS0QwN3tWZWP7T40JcHuIWE7aVX0/e I70k4R35B5PHRZB0ONvYyMXSxBBFRl4hcCxHNvjwiP7WonipK3UDBvI3rvJ9U59j5yVv qCVA== X-Forwarded-Encrypted: i=1; AJvYcCUTOFocWbMSQFq7hnW6VxFf4WAdaIvzAAn2smj2hapMLVd8NeBqi8BLELa8PiQzuio7Qzr9aIBjdbnPo8yGvlSapeDTXP4= X-Gm-Message-State: AOJu0Yx+UUmgbZOcjrdW2In89VQk2uZEjZG2KuztktDraVuOl2IljAqU DnvUe99c/aA6hGEshSISP8mXSDAB0wET65vvKSvIj4QDCwOCkIM4PENW/2/53W5eRajgn0AaKQA PIlPyjgeHRMOZa/73ok00HE0c7AA= X-Google-Smtp-Source: AGHT+IG9ANJVtg4O+90DqOP3meWgaNMY5kHJicY3SRcgYkbzz1ft74eMTYNsLoXh+rkg/vzAukU+9UWuvl8Y0hPy6n4= X-Received: by 2002:a05:6358:795:b0:181:6575:1b23 with SMTP id n21-20020a056358079500b0018165751b23mr6996143rwj.5.1713599625947; Sat, 20 Apr 2024 00:53:45 -0700 (PDT) MIME-Version: 1.0 References: <CALFrjHzHr=T3S7UsCBzrLoQ34y5hqGBYkqaXTx04ooAo9qz1LQ@HIDDEN> <86le58a7dv.fsf@HIDDEN> <CALFrjHyFMzoe8N+dnHDE8s59ghKktAFAS=8gg02wQC-zA9zi-Q@HIDDEN> <CALFrjHx+UoQZrQMRy9DD5wvAS8D6FemdH=gKgUfk54796V+Qjg@HIDDEN> <86edb0a3bq.fsf@HIDDEN> In-Reply-To: <86edb0a3bq.fsf@HIDDEN> From: Prateek Sharma <ps.prateek.sharma143@HIDDEN> Date: Sat, 20 Apr 2024 13:23:34 +0530 Message-ID: <CALFrjHyiuPO017_uQxSxq+oS2Hn6pFrP=EUOJTvvFGaw+gU5YA@HIDDEN> Subject: Re: bug#70478: 30.0.50; [PATCH] Fix treesitter-font-lock-settings for built-in functions and attributes. To: Eli Zaretskii <eliz@HIDDEN> Content-Type: multipart/mixed; boundary="000000000000feb82e0616828096" X-Spam-Score: 0.3 (/) X-Debbugs-Envelope-To: 70478 Cc: casouri@HIDDEN, 70478 <at> debbugs.gnu.org X-BeenThere: debbugs-submit <at> debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: <debbugs-submit.debbugs.gnu.org> List-Unsubscribe: <https://debbugs.gnu.org/cgi-bin/mailman/options/debbugs-submit>, <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=unsubscribe> List-Archive: <https://debbugs.gnu.org/cgi-bin/mailman/private/debbugs-submit/> List-Post: <mailto:debbugs-submit <at> debbugs.gnu.org> List-Help: <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=help> List-Subscribe: <https://debbugs.gnu.org/cgi-bin/mailman/listinfo/debbugs-submit>, <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=subscribe> Errors-To: debbugs-submit-bounces <at> debbugs.gnu.org Sender: "Debbugs-submit" <debbugs-submit-bounces <at> debbugs.gnu.org> X-Spam-Score: -0.7 (/) --000000000000feb82e0616828096 Content-Type: multipart/alternative; boundary="000000000000feb82d0616828094" --000000000000feb82d0616828094 Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable Here is the patch for the squashed commit and updated code. Thanks for helping me out! On Sat, Apr 20, 2024 at 1:11=E2=80=AFPM Eli Zaretskii <eliz@HIDDEN> wrote: > > From: Prateek Sharma <ps.prateek.sharma143@HIDDEN> > > Date: Sat, 20 Apr 2024 12:25:24 +0530 > > Cc: Yuan Fu <casouri@HIDDEN>, 70478 <at> debbugs.gnu.org > > > > Also should I squash the changes of both the above commits into one and > then create a patch file? > > You should squash, yes. Other than that, attaching the patches as you > did is fine. > > Thanks. > --000000000000feb82d0616828094 Content-Type: text/html; charset="UTF-8" Content-Transfer-Encoding: quoted-printable <div dir=3D"ltr">Here is the patch for the squashed commit and updated code= . Thanks for helping me out!<div><br></div></div><br><div class=3D"gmail_qu= ote"><div dir=3D"ltr" class=3D"gmail_attr">On Sat, Apr 20, 2024 at 1:11=E2= =80=AFPM Eli Zaretskii <<a href=3D"mailto:eliz@HIDDEN">eliz@HIDDEN</a>= > wrote:<br></div><blockquote class=3D"gmail_quote" style=3D"margin:0px = 0px 0px 0.8ex;border-left:1px solid rgb(204,204,204);padding-left:1ex">>= From: Prateek Sharma <<a href=3D"mailto:ps.prateek.sharma143@HIDDEN"= target=3D"_blank">ps.prateek.sharma143@HIDDEN</a>><br> > Date: Sat, 20 Apr 2024 12:25:24 +0530<br> > Cc: Yuan Fu <<a href=3D"mailto:casouri@HIDDEN" target=3D"_blank"= >casouri@HIDDEN</a>>, <a href=3D"mailto:70478 <at> debbugs.gnu.org" target= =3D"_blank">70478 <at> debbugs.gnu.org</a><br> > <br> > Also should I squash the changes of both the above commits into one an= d then create a patch file?<br> <br> You should squash, yes.=C2=A0 Other than that, attaching the patches as you= <br> did is fine.<br> <br> Thanks.<br> </blockquote></div> --000000000000feb82d0616828094-- --000000000000feb82e0616828096 Content-Type: application/octet-stream; name="0001-Fix-treesitter-font-lock-settings-for-built-in-funct.patch" Content-Disposition: attachment; filename="0001-Fix-treesitter-font-lock-settings-for-built-in-funct.patch" Content-Transfer-Encoding: base64 Content-ID: <f_lv7symwy0> X-Attachment-Id: f_lv7symwy0 RnJvbSA2YjhlMTU1YTZmYzkxN2ViNjQ0YTMyYzA2ZmE3MzgzYThjYmY0N2I5IE1vbiBTZXAgMTcg MDA6MDA6MDAgMjAwMQpGcm9tOiBQcmF0ZWVrIFNoYXJtYSA8cHMucHJhdGVlay5zaGFybWExNDNA Z21haWwuY29tPgpEYXRlOiBTYXQsIDIwIEFwciAyMDI0IDAyOjA2OjE3ICswNTMwClN1YmplY3Q6 IFtQQVRDSF0gRml4IHRyZWVzaXR0ZXItZm9udC1sb2NrLXNldHRpbmdzIGZvciBidWlsdC1pbiBm dW5jdGlvbnMgYW5kCiBhdHRyaWJ1dGVzLgoKKiBsaXNwL3Byb2dtb2Rlcy9weXRob24uZWwgKHB5 dGhvbi0tdHJlZXNpdC1zZXR0aW5ncyk6IENoYW5nZSB0aGUgdHJlZXNpdHRlciBxdWVyeSB0byBm ZXRjaCB0aGUgY29ycmVjdCB0eXBlIG9mIG5vZGUgZm9yIGJ1aWx0LWluIGZ1bmN0aW9ucyBhbmQg YXR0cmlidXRlcyBhbmQgaGlnaGxpZ2h0IHRoZW0gd2l0aCBjb3JyZXNwb25kaW5nIGZvbnQtbG9j ayBmYWNlLgotLS0KIGxpc3AvcHJvZ21vZGVzL3B5dGhvbi5lbCB8IDE2ICsrKysrKysrKy0tLS0t LS0KIDEgZmlsZSBjaGFuZ2VkLCA5IGluc2VydGlvbnMoKyksIDcgZGVsZXRpb25zKC0pCgpkaWZm IC0tZ2l0IGEvbGlzcC9wcm9nbW9kZXMvcHl0aG9uLmVsIGIvbGlzcC9wcm9nbW9kZXMvcHl0aG9u LmVsCmluZGV4IDg1Mjc5ZDNlODRiLi5kNmMyOWU1ZmZjNiAxMDA2NDQKLS0tIGEvbGlzcC9wcm9n bW9kZXMvcHl0aG9uLmVsCisrKyBiL2xpc3AvcHJvZ21vZGVzL3B5dGhvbi5lbApAQCAtMTIwNiwx MyArMTIwNiwxNSBAQCBmb250aWZpZWQuIgogCiAgICA6ZmVhdHVyZSAnYnVpbHRpbgogICAgOmxh bmd1YWdlICdweXRob24KLSAgIGAoKChpZGVudGlmaWVyKSBAZm9udC1sb2NrLWJ1aWx0aW4tZmFj ZQotICAgICAgKDptYXRjaCAsKHJ4LXRvLXN0cmluZwotICAgICAgICAgICAgICAgIGAoc2VxIGJv bAotICAgICAgICAgICAgICAgICAgICAgIChvciAsQHB5dGhvbi0tdHJlZXNpdC1idWlsdGlucwot ICAgICAgICAgICAgICAgICAgICAgICAgICAsQHB5dGhvbi0tdHJlZXNpdC1zcGVjaWFsLWF0dHJp YnV0ZXMpCi0gICAgICAgICAgICAgICAgICAgICAgZW9sKSkKLSAgICAgICAgICAgICAgQGZvbnQt bG9jay1idWlsdGluLWZhY2UpKSkKKyAgIGAoKGNhbGwgZnVuY3Rpb246IChpZGVudGlmaWVyKSBA Zm9udC1sb2NrLWJ1aWx0aW4tZmFjZQorICAgICAgICAgICAoOm1hdGNoICwocngtdG8tc3RyaW5n CisgICAgICAgICAgICAgICAgICAgICBgKHNlcSBib2wgKG9yICxAcHl0aG9uLS10cmVlc2l0LWJ1 aWx0aW5zKSBlb2wpKQorICAgICAgICAgICAgICAgICAgIEBmb250LWxvY2stYnVpbHRpbi1mYWNl KSkKKyAgICAgKGF0dHJpYnV0ZSBhdHRyaWJ1dGU6IChpZGVudGlmaWVyKSBAZm9udC1sb2NrLWJ1 aWx0aW4tZmFjZQorICAgICAgICAgICAgICAgICg6bWF0Y2ggLChyeC10by1zdHJpbmcKKyAgICAg ICAgICAgICAgICAgICAgICAgICAgYChzZXEgYm9sCisgICAgICAgICAgICAgICAgICAgICAgICAg ICAgICAgIChvciAsQHB5dGhvbi0tdHJlZXNpdC1zcGVjaWFsLWF0dHJpYnV0ZXMpIGVvbCkpCisg ICAgICAgICAgICAgICAgICAgICAgICBAZm9udC1sb2NrLWJ1aWx0aW4tZmFjZSkpKQogCiAgICA6 ZmVhdHVyZSAnZGVjb3JhdG9yCiAgICA6bGFuZ3VhZ2UgJ3B5dGhvbgotLSAKMi4zOS4zIChBcHBs ZSBHaXQtMTQ2KQoK --000000000000feb82e0616828096--
bug-gnu-emacs@HIDDEN:bug#70478; Package emacs.
Full text available.Received: (at 70478) by debbugs.gnu.org; 20 Apr 2024 07:41:55 +0000 From debbugs-submit-bounces <at> debbugs.gnu.org Sat Apr 20 03:41:55 2024 Received: from localhost ([127.0.0.1]:34847 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from <debbugs-submit-bounces <at> debbugs.gnu.org>) id 1ry5MB-0005Hq-9q for submit <at> debbugs.gnu.org; Sat, 20 Apr 2024 03:41:55 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]:57984) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from <eliz@HIDDEN>) id 1ry5M8-0005Gj-Eu for 70478 <at> debbugs.gnu.org; Sat, 20 Apr 2024 03:41:54 -0400 Received: from fencepost.gnu.org ([2001:470:142:3::e]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from <eliz@HIDDEN>) id 1ry5Lo-0006yi-FO; Sat, 20 Apr 2024 03:41:32 -0400 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=gnu.org; s=fencepost-gnu-org; h=References:Subject:In-Reply-To:To:From:Date: mime-version; bh=NPuYRr9MLADq5Je9eTTClGCPLC/sm0u80PY7AYzHDn0=; b=O8njGLX6B1fm CnLY+7P/jqZxbrm3EOIhkk49/jP2BJ2ZAWA4yuVMRfsPs9yH21m+3ayRAFC+9YzC8CLe7MsdiUv3Y T7Fxn222KMs82AvmORDyDCgrmcLoNdAHdHMTbcC9pkJZJWCcrKI+vV0UN4pcN1ejUXvhqke263mVj IMSChNwpkoTYORoXwyRnacIx3NKT2I1VqL3TrliKwz+QyzJeLSEfE4U5AWR1eyVbt9IZGOO+2//z3 0UQ1lCAqhlEcp97PzOfNvm7T2itR35MVJG7orqEGxDRxyqNomLei2o+BIialsbVUzGCv64XnSGU5w 3C+tc7JdBSxYxxZZf6s+JA==; Date: Sat, 20 Apr 2024 10:41:29 +0300 Message-Id: <86edb0a3bq.fsf@HIDDEN> From: Eli Zaretskii <eliz@HIDDEN> To: Prateek Sharma <ps.prateek.sharma143@HIDDEN> In-Reply-To: <CALFrjHx+UoQZrQMRy9DD5wvAS8D6FemdH=gKgUfk54796V+Qjg@HIDDEN> (message from Prateek Sharma on Sat, 20 Apr 2024 12:25:24 +0530) Subject: Re: bug#70478: 30.0.50; [PATCH] Fix treesitter-font-lock-settings for built-in functions and attributes. References: <CALFrjHzHr=T3S7UsCBzrLoQ34y5hqGBYkqaXTx04ooAo9qz1LQ@HIDDEN> <86le58a7dv.fsf@HIDDEN> <CALFrjHyFMzoe8N+dnHDE8s59ghKktAFAS=8gg02wQC-zA9zi-Q@HIDDEN> <CALFrjHx+UoQZrQMRy9DD5wvAS8D6FemdH=gKgUfk54796V+Qjg@HIDDEN> X-Spam-Score: -2.3 (--) X-Debbugs-Envelope-To: 70478 Cc: casouri@HIDDEN, 70478 <at> debbugs.gnu.org X-BeenThere: debbugs-submit <at> debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: <debbugs-submit.debbugs.gnu.org> List-Unsubscribe: <https://debbugs.gnu.org/cgi-bin/mailman/options/debbugs-submit>, <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=unsubscribe> List-Archive: <https://debbugs.gnu.org/cgi-bin/mailman/private/debbugs-submit/> List-Post: <mailto:debbugs-submit <at> debbugs.gnu.org> List-Help: <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=help> List-Subscribe: <https://debbugs.gnu.org/cgi-bin/mailman/listinfo/debbugs-submit>, <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=subscribe> Errors-To: debbugs-submit-bounces <at> debbugs.gnu.org Sender: "Debbugs-submit" <debbugs-submit-bounces <at> debbugs.gnu.org> X-Spam-Score: -3.3 (---) > From: Prateek Sharma <ps.prateek.sharma143@HIDDEN> > Date: Sat, 20 Apr 2024 12:25:24 +0530 > Cc: Yuan Fu <casouri@HIDDEN>, 70478 <at> debbugs.gnu.org > > Also should I squash the changes of both the above commits into one and then create a patch file? You should squash, yes. Other than that, attaching the patches as you did is fine. Thanks.
bug-gnu-emacs@HIDDEN:bug#70478; Package emacs.
Full text available.Received: (at 70478) by debbugs.gnu.org; 20 Apr 2024 06:56:01 +0000 From debbugs-submit-bounces <at> debbugs.gnu.org Sat Apr 20 02:56:01 2024 Received: from localhost ([127.0.0.1]:34668 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from <debbugs-submit-bounces <at> debbugs.gnu.org>) id 1ry4di-00082b-30 for submit <at> debbugs.gnu.org; Sat, 20 Apr 2024 02:56:01 -0400 Received: from mail-vk1-xa29.google.com ([2607:f8b0:4864:20::a29]:56431) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from <ps.prateek.sharma143@HIDDEN>) id 1ry4df-000813-3U for 70478 <at> debbugs.gnu.org; Sat, 20 Apr 2024 02:55:56 -0400 Received: by mail-vk1-xa29.google.com with SMTP id 71dfb90a1353d-4dae8b2d29bso698100e0c.0 for <70478 <at> debbugs.gnu.org>; Fri, 19 Apr 2024 23:55:40 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1713596135; x=1714200935; darn=debbugs.gnu.org; h=cc:to:subject:message-id:date:from:in-reply-to:references :mime-version:from:to:cc:subject:date:message-id:reply-to; bh=4cQ6nTDSKI02SzkFAO/Jep7zIA4MHEn/lihlPqfynf4=; b=lrk4oAyRNYXktTfUp6sVty0QOzpwauTfQKwTE66UHu/kN2OkRHSWY8OQlnDZaw6zsf pn+hGeeKqfie+5cgRBFeLf5s1B5SlhUMkQM0wrq5vssXgpm4AxS74X5H/Di7QV6SS3kt 3hEE3yKd+owzJ3u1geIBPHYMZebppG1rtg74xvdvQMQXBD/8O2E/nhBqevSwAV/Ed7Ah vE4Dq1j2PNuQFaRC4+SSGk+kowqRyF5c0pB/imnC06I5S8rDar3Qi1dkuWsJonZZaWos IH1QgN0YTN8ioeLqz180dqryEAXNxxIRnonIlbC55bo4rHzwZwwFid2+lZuBJ2j0+sRt cNDw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1713596135; x=1714200935; h=cc:to:subject:message-id:date:from:in-reply-to:references :mime-version:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=4cQ6nTDSKI02SzkFAO/Jep7zIA4MHEn/lihlPqfynf4=; b=WUup9F8s2gScuhwFegKRn9lskjFMiuowK98FpL0Ht3fYJ6N7Mk3oSUTAxVcYJ5q1mR 16zz8W6RGtt8202sMGVoDKXfCp4rG7LT6mNK6K/AZqA1Lqw5Dt7rFF5xvSD9Jf9r1hJo YeE143w/DEntBe8Upcb4kZVXZbHsJnA7v5/5dCYnZDlKeGH5cLzh7IbjwgU+X/4kvKgC QMFzAl8BPLOulkrj4P/iTGvsBEdlGWEhKcwUYnZ7RiqmY4fajcOvJqZwgYfOL6ZtnqYA 4eOO/ZIbh84kWFKoe052nCD3QieUoECh9JGyrjPg9GfzjyHb6udLslpsSYZ4qNTyW+RG jleQ== X-Forwarded-Encrypted: i=1; AJvYcCVt1k7dAwP0UbGJEWAw2pqrZVE97TzglacJxYELMR8QX5OBvJjwCo9/McPQpEfI4bo0PFUJ/Nm/BvO8nWUkxaCAVLinjpI= X-Gm-Message-State: AOJu0YxMaZImNc9sUWBnIU17KlrAiCqz5iB2k0xhZKe49hXEDjJ060XS CcxLLqWpsXamvRE7iSJTvIrzs9qt33udj9RZ2QgYKK8CMpaBuf1RvZ5jlnX2gD/aSn1+3ghNHnp 6vTybY0C+p1k/tUuYd48PooCyVxc= X-Google-Smtp-Source: AGHT+IH4g0NfIdpmKSCeLDjiPAnLuIictsuuQiQk17wjFOpPoJsp6aR/IR0f26tUeqCDhzxKjpZfnQqMt3ziaNC0fuQ= X-Received: by 2002:a05:6122:32d4:b0:4c0:24e6:f49d with SMTP id ck20-20020a05612232d400b004c024e6f49dmr5037711vkb.1.1713596134897; Fri, 19 Apr 2024 23:55:34 -0700 (PDT) MIME-Version: 1.0 References: <CALFrjHzHr=T3S7UsCBzrLoQ34y5hqGBYkqaXTx04ooAo9qz1LQ@HIDDEN> <86le58a7dv.fsf@HIDDEN> <CALFrjHyFMzoe8N+dnHDE8s59ghKktAFAS=8gg02wQC-zA9zi-Q@HIDDEN> In-Reply-To: <CALFrjHyFMzoe8N+dnHDE8s59ghKktAFAS=8gg02wQC-zA9zi-Q@HIDDEN> From: Prateek Sharma <ps.prateek.sharma143@HIDDEN> Date: Sat, 20 Apr 2024 12:25:24 +0530 Message-ID: <CALFrjHx+UoQZrQMRy9DD5wvAS8D6FemdH=gKgUfk54796V+Qjg@HIDDEN> Subject: Re: bug#70478: 30.0.50; [PATCH] Fix treesitter-font-lock-settings for built-in functions and attributes. To: Eli Zaretskii <eliz@HIDDEN> Content-Type: multipart/alternative; boundary="000000000000e8bd5d061681b0a7" X-Spam-Score: 0.3 (/) X-Debbugs-Envelope-To: 70478 Cc: Yuan Fu <casouri@HIDDEN>, 70478 <at> debbugs.gnu.org X-BeenThere: debbugs-submit <at> debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: <debbugs-submit.debbugs.gnu.org> List-Unsubscribe: <https://debbugs.gnu.org/cgi-bin/mailman/options/debbugs-submit>, <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=unsubscribe> List-Archive: <https://debbugs.gnu.org/cgi-bin/mailman/private/debbugs-submit/> List-Post: <mailto:debbugs-submit <at> debbugs.gnu.org> List-Help: <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=help> List-Subscribe: <https://debbugs.gnu.org/cgi-bin/mailman/listinfo/debbugs-submit>, <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=subscribe> Errors-To: debbugs-submit-bounces <at> debbugs.gnu.org Sender: "Debbugs-submit" <debbugs-submit-bounces <at> debbugs.gnu.org> X-Spam-Score: -0.7 (/) --000000000000e8bd5d061681b0a7 Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable Also should I squash the changes of both the above commits into one and then create a patch file? On Sat, Apr 20, 2024 at 12:24=E2=80=AFPM Prateek Sharma < ps.prateek.sharma143@HIDDEN> wrote: > Hey, Thanks for reviewing my changes. > > Here is the patch for reformatted version of the above fix. I've also > removed the announcement in the NEWS file. > > On Sat, Apr 20, 2024 at 11:43=E2=80=AFAM Eli Zaretskii <eliz@HIDDEN> wro= te: > >> > From: Prateek Sharma <ps.prateek.sharma143@HIDDEN> >> > Date: Sat, 20 Apr 2024 02:30:17 +0530 >> > >> > I do a lot of programming in python and have noticed that if there is = a >> > method of a class defined with the same name as a builtin function. It >> > gets highlighted with the face for builtin functions and it looks >> > different for all the other functions and confuses me sometimes and ju= st >> > looks inconsistent. >> > >> > I have made a simple fix to the treesitter query and it seems to have >> > fixed the problem. >> > >> > Please share you thoughts on this fix. This is my first time >> > contributing to an open-source project and to emacs. Very excited to >> > hear from you guys!!! >> >> Thanks. Yuan, any comments? >> >> I have a few minor comments below. >> >> > diff --git a/etc/NEWS b/etc/NEWS >> > index 8ad1e78ca60..e5cd70b6106 100644 >> > --- a/etc/NEWS >> > +++ b/etc/NEWS >> > @@ -1319,6 +1319,15 @@ instead of: >> > This allows the user to specify command line arguments to the non >> > interactive Python interpreter specified by 'python-interpreter'. >> > >> > +*** Treesitter syntax highlighting for built-in functions fixed >> > +The fix highlights only the correct built-in function calls and >> > +attributes with font-lock-builtin-face. When some class defines >> > +a function with the same name as a built-in function, earlier it was >> > +being highlighted with the same font-lock-builtin-face, which was >> > +incorrect. Now, normal user defined functions will be highlighted >> > +with font-lock-function-call-face face and built-in functions and >> > +attributes will be highlighted with font-lock-builtin-face. >> >> This part is not needed, I think: we don't document bugfixes in NEWS. >> >> > + `((call function: (identifier) @font-lock-builtin-face >> > + (:match ,(rx-to-string `(seq bol (or >> ,@python--treesit-builtins) eol)) >> > + @font-lock-builtin-face)) >> > + (attribute attribute: (identifier) @font-lock-builtin-face >> > + (:match ,(rx-to-string `(seq bol (or >> ,@python--treesit-special-attributes) eol)) >> > + @font-lock-builtin-face))) >> >> Please reformat the whitespace here to avoid exceeding 80 columns in >> each individual line. >> > --000000000000e8bd5d061681b0a7 Content-Type: text/html; charset="UTF-8" Content-Transfer-Encoding: quoted-printable <div dir=3D"ltr">Also should I squash the changes of both the above commits= into one and then create a patch file?</div><br><div class=3D"gmail_quote"= ><div dir=3D"ltr" class=3D"gmail_attr">On Sat, Apr 20, 2024 at 12:24=E2=80= =AFPM Prateek Sharma <<a href=3D"mailto:ps.prateek.sharma143@HIDDEN">= ps.prateek.sharma143@HIDDEN</a>> wrote:<br></div><blockquote class=3D= "gmail_quote" style=3D"margin:0px 0px 0px 0.8ex;border-left:1px solid rgb(2= 04,204,204);padding-left:1ex"><div dir=3D"ltr">Hey, Thanks for reviewing my= changes.<div><br></div><div>Here is the patch for reformatted=C2=A0version= of the above fix. I've also removed the announcement in the NEWS file.= </div></div><br><div class=3D"gmail_quote"><div dir=3D"ltr" class=3D"gmail_= attr">On Sat, Apr 20, 2024 at 11:43=E2=80=AFAM Eli Zaretskii <<a href=3D= "mailto:eliz@HIDDEN" target=3D"_blank">eliz@HIDDEN</a>> wrote:<br></di= v><blockquote class=3D"gmail_quote" style=3D"margin:0px 0px 0px 0.8ex;borde= r-left:1px solid rgb(204,204,204);padding-left:1ex">> From: Prateek Shar= ma <<a href=3D"mailto:ps.prateek.sharma143@HIDDEN" target=3D"_blank">= ps.prateek.sharma143@HIDDEN</a>><br> > Date: Sat, 20 Apr 2024 02:30:17 +0530<br> > <br> > I do a lot of programming in python and have noticed that if there is = a<br> > method of a class defined with the same name as a builtin function. It= <br> > gets highlighted with the face for builtin functions and it looks<br> > different for all the other functions and confuses me sometimes and ju= st<br> > looks inconsistent.<br> > <br> > I have made a simple fix to the treesitter query and it seems to have<= br> > fixed the problem.<br> > <br> > Please share you thoughts on this fix. This is my first time<br> > contributing to an open-source project and to emacs. Very excited to<b= r> > hear from you guys!!!<br> <br> Thanks.=C2=A0 Yuan, any comments?<br> <br> I have a few minor comments below.<br> <br> > diff --git a/etc/NEWS b/etc/NEWS<br> > index 8ad1e78ca60..e5cd70b6106 100644<br> > --- a/etc/NEWS<br> > +++ b/etc/NEWS<br> > @@ -1319,6 +1319,15 @@ instead of:<br> >=C2=A0 This allows the user to specify command line arguments to the no= n<br> >=C2=A0 interactive Python interpreter specified by 'python-interpre= ter'.<br> >=C2=A0 <br> > +*** Treesitter syntax highlighting for built-in functions fixed<br> > +The fix highlights only the correct built-in function calls and<br> > +attributes with font-lock-builtin-face. When some class defines<br> > +a function with the same name as a built-in function, earlier it was<= br> > +being highlighted with the same font-lock-builtin-face, which was<br> > +incorrect. Now, normal user defined functions will be highlighted<br> > +with font-lock-function-call-face face and built-in functions and<br> > +attributes will be highlighted with font-lock-builtin-face.<br> <br> This part is not needed, I think: we don't document bugfixes in NEWS.<b= r> <br> > +=C2=A0 =C2=A0`((call function: (identifier) @font-lock-builtin-face<b= r> > +=C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0(:match ,(rx-to-string `(seq= bol (or ,@python--treesit-builtins) eol))<br> > +=C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0= @font-lock-builtin-face))<br> > +=C2=A0 =C2=A0 =C2=A0(attribute attribute: (identifier) @font-lock-bui= ltin-face<br> > +=C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 (:match ,(rx-= to-string `(seq bol (or ,@python--treesit-special-attributes) eol))<br> > +=C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0= =C2=A0 =C2=A0 @font-lock-builtin-face)))<br> <br> Please reformat the whitespace here to avoid exceeding 80 columns in<br> each individual line.<br> </blockquote></div> </blockquote></div> --000000000000e8bd5d061681b0a7--
bug-gnu-emacs@HIDDEN:bug#70478; Package emacs.
Full text available.Received: (at 70478) by debbugs.gnu.org; 20 Apr 2024 06:54:48 +0000 From debbugs-submit-bounces <at> debbugs.gnu.org Sat Apr 20 02:54:47 2024 Received: from localhost ([127.0.0.1]:34659 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from <debbugs-submit-bounces <at> debbugs.gnu.org>) id 1ry4cZ-0007qv-4n for submit <at> debbugs.gnu.org; Sat, 20 Apr 2024 02:54:47 -0400 Received: from mail-vk1-xa30.google.com ([2607:f8b0:4864:20::a30]:44403) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from <ps.prateek.sharma143@HIDDEN>) id 1ry4cX-0007qK-5M for 70478 <at> debbugs.gnu.org; Sat, 20 Apr 2024 02:54:45 -0400 Received: by mail-vk1-xa30.google.com with SMTP id 71dfb90a1353d-4dabbd69c71so769773e0c.1 for <70478 <at> debbugs.gnu.org>; Fri, 19 Apr 2024 23:54:30 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1713596065; x=1714200865; darn=debbugs.gnu.org; h=cc:to:subject:message-id:date:from:in-reply-to:references :mime-version:from:to:cc:subject:date:message-id:reply-to; bh=ldlGDWLqlYG4eJvSl55RwetYaxw3pR8inMWLOiHF7OE=; b=k8SBL3qUOsSy8TMKAhpVyv58aocnNqMq6pbdXTP1g7ey88H9IVYLz7/AwYGxAd+/ti XUEkXu1/hdUnd69Qnu0+lJyoAvMc+RVhhKt6SehZaSOl9z7OJ4KxF0y3vNeP4N1sE0n1 N3IUwUbNmc1qzhqB3CmFYHdYSMrzSeat/RdfY3ZBi6G4PzG/KyM7w3Ueob7gXMWchZYI sU93/8rFCLAMEEKWUnt+iRnwr0l2+tijoeG7HjZab32zvWgcrO5I4BB/Npr1KssEvQBP diwKYMJa684q8hjblp6niVFEVWheGvzm5/PW1Hl0Lv23tJHVN2RyBF8IRYegHS+h67bd KdtA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1713596065; x=1714200865; h=cc:to:subject:message-id:date:from:in-reply-to:references :mime-version:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=ldlGDWLqlYG4eJvSl55RwetYaxw3pR8inMWLOiHF7OE=; b=N5ysMHBivBimAI1YJcsQKqR17RoADhfW9d0ur9bcJqrtrHhog1Wl5wyed5RP21UFTt GkIFLzoWy0cjD4nCN1tfGw3IPEPYtJFFc1URrm5GtaaxmYQ83Tx12MelMSS1YGrUv/hb JKFHP2n8tCUD4oyyUy1JkCB3mCiDSQ7aBstBIxOdmoXb5WlEg504w4z9taSskBmldOWA k1L3iLO4ClfAb0YxJZRN03IeNppatBr0BLe3a3fEfyf28EQ5C90YbRK7tD0fD9ogpXib zxGCJ1dEZe9+QARq3DTE5lkY0ctgmNrJZLvFSEoypSmvt3i2hkyw2WWuzIqNq018a6Pj woDQ== X-Forwarded-Encrypted: i=1; AJvYcCWgl6bjrxvCXMv9xmFd23OmRHYnpnZBek/l0oa6DNNxvlKcBhMKHJ/HiXCa8XmiEm/GxsxAr0WoJFdFiYc19hjsi6jIXYA= X-Gm-Message-State: AOJu0Yz9DKW8GJmqGcnoQ2VSvRZ/hdxeargcSmJrXVKGGIWWHgo4qfzv 9JGqGNV4Kuua408VsKxK/BlzHaQW4lEWe032EW4lJh3/9LJ4J4vBJ4yQnEjcKFeHi6vchnehYQz vsc/iDnNiSto+r4dECG4H5uvpoBc= X-Google-Smtp-Source: AGHT+IFN3r3k4IyjPNWJ8PXk2O4ny0vAOk8yF/o2xj9BRX288nC7jiKnbO86TAOntP5ILWbsgFkGdnz2l0aiz1Ilevs= X-Received: by 2002:ac5:c856:0:b0:4db:11aa:7ab1 with SMTP id g22-20020ac5c856000000b004db11aa7ab1mr4420774vkm.10.1713596064905; Fri, 19 Apr 2024 23:54:24 -0700 (PDT) MIME-Version: 1.0 References: <CALFrjHzHr=T3S7UsCBzrLoQ34y5hqGBYkqaXTx04ooAo9qz1LQ@HIDDEN> <86le58a7dv.fsf@HIDDEN> In-Reply-To: <86le58a7dv.fsf@HIDDEN> From: Prateek Sharma <ps.prateek.sharma143@HIDDEN> Date: Sat, 20 Apr 2024 12:24:13 +0530 Message-ID: <CALFrjHyFMzoe8N+dnHDE8s59ghKktAFAS=8gg02wQC-zA9zi-Q@HIDDEN> Subject: Re: bug#70478: 30.0.50; [PATCH] Fix treesitter-font-lock-settings for built-in functions and attributes. To: Eli Zaretskii <eliz@HIDDEN> Content-Type: multipart/mixed; boundary="000000000000bcd314061681ac7e" X-Spam-Score: 0.3 (/) X-Debbugs-Envelope-To: 70478 Cc: Yuan Fu <casouri@HIDDEN>, 70478 <at> debbugs.gnu.org X-BeenThere: debbugs-submit <at> debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: <debbugs-submit.debbugs.gnu.org> List-Unsubscribe: <https://debbugs.gnu.org/cgi-bin/mailman/options/debbugs-submit>, <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=unsubscribe> List-Archive: <https://debbugs.gnu.org/cgi-bin/mailman/private/debbugs-submit/> List-Post: <mailto:debbugs-submit <at> debbugs.gnu.org> List-Help: <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=help> List-Subscribe: <https://debbugs.gnu.org/cgi-bin/mailman/listinfo/debbugs-submit>, <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=subscribe> Errors-To: debbugs-submit-bounces <at> debbugs.gnu.org Sender: "Debbugs-submit" <debbugs-submit-bounces <at> debbugs.gnu.org> X-Spam-Score: -0.7 (/) --000000000000bcd314061681ac7e Content-Type: multipart/alternative; boundary="000000000000bcd312061681ac7c" --000000000000bcd312061681ac7c Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable Hey, Thanks for reviewing my changes. Here is the patch for reformatted version of the above fix. I've also removed the announcement in the NEWS file. On Sat, Apr 20, 2024 at 11:43=E2=80=AFAM Eli Zaretskii <eliz@HIDDEN> wrote= : > > From: Prateek Sharma <ps.prateek.sharma143@HIDDEN> > > Date: Sat, 20 Apr 2024 02:30:17 +0530 > > > > I do a lot of programming in python and have noticed that if there is a > > method of a class defined with the same name as a builtin function. It > > gets highlighted with the face for builtin functions and it looks > > different for all the other functions and confuses me sometimes and jus= t > > looks inconsistent. > > > > I have made a simple fix to the treesitter query and it seems to have > > fixed the problem. > > > > Please share you thoughts on this fix. This is my first time > > contributing to an open-source project and to emacs. Very excited to > > hear from you guys!!! > > Thanks. Yuan, any comments? > > I have a few minor comments below. > > > diff --git a/etc/NEWS b/etc/NEWS > > index 8ad1e78ca60..e5cd70b6106 100644 > > --- a/etc/NEWS > > +++ b/etc/NEWS > > @@ -1319,6 +1319,15 @@ instead of: > > This allows the user to specify command line arguments to the non > > interactive Python interpreter specified by 'python-interpreter'. > > > > +*** Treesitter syntax highlighting for built-in functions fixed > > +The fix highlights only the correct built-in function calls and > > +attributes with font-lock-builtin-face. When some class defines > > +a function with the same name as a built-in function, earlier it was > > +being highlighted with the same font-lock-builtin-face, which was > > +incorrect. Now, normal user defined functions will be highlighted > > +with font-lock-function-call-face face and built-in functions and > > +attributes will be highlighted with font-lock-builtin-face. > > This part is not needed, I think: we don't document bugfixes in NEWS. > > > + `((call function: (identifier) @font-lock-builtin-face > > + (:match ,(rx-to-string `(seq bol (or > ,@python--treesit-builtins) eol)) > > + @font-lock-builtin-face)) > > + (attribute attribute: (identifier) @font-lock-builtin-face > > + (:match ,(rx-to-string `(seq bol (or > ,@python--treesit-special-attributes) eol)) > > + @font-lock-builtin-face))) > > Please reformat the whitespace here to avoid exceeding 80 columns in > each individual line. > --000000000000bcd312061681ac7c Content-Type: text/html; charset="UTF-8" Content-Transfer-Encoding: quoted-printable <div dir=3D"ltr">Hey, Thanks for reviewing my changes.<div><br></div><div>H= ere is the patch for reformatted=C2=A0version of the above fix. I've al= so removed the announcement in the NEWS file.</div></div><br><div class=3D"= gmail_quote"><div dir=3D"ltr" class=3D"gmail_attr">On Sat, Apr 20, 2024 at = 11:43=E2=80=AFAM Eli Zaretskii <<a href=3D"mailto:eliz@HIDDEN">eliz@gnu= .org</a>> wrote:<br></div><blockquote class=3D"gmail_quote" style=3D"mar= gin:0px 0px 0px 0.8ex;border-left:1px solid rgb(204,204,204);padding-left:1= ex">> From: Prateek Sharma <<a href=3D"mailto:ps.prateek.sharma143@gm= ail.com" target=3D"_blank">ps.prateek.sharma143@HIDDEN</a>><br> > Date: Sat, 20 Apr 2024 02:30:17 +0530<br> > <br> > I do a lot of programming in python and have noticed that if there is = a<br> > method of a class defined with the same name as a builtin function. It= <br> > gets highlighted with the face for builtin functions and it looks<br> > different for all the other functions and confuses me sometimes and ju= st<br> > looks inconsistent.<br> > <br> > I have made a simple fix to the treesitter query and it seems to have<= br> > fixed the problem.<br> > <br> > Please share you thoughts on this fix. This is my first time<br> > contributing to an open-source project and to emacs. Very excited to<b= r> > hear from you guys!!!<br> <br> Thanks.=C2=A0 Yuan, any comments?<br> <br> I have a few minor comments below.<br> <br> > diff --git a/etc/NEWS b/etc/NEWS<br> > index 8ad1e78ca60..e5cd70b6106 100644<br> > --- a/etc/NEWS<br> > +++ b/etc/NEWS<br> > @@ -1319,6 +1319,15 @@ instead of:<br> >=C2=A0 This allows the user to specify command line arguments to the no= n<br> >=C2=A0 interactive Python interpreter specified by 'python-interpre= ter'.<br> >=C2=A0 <br> > +*** Treesitter syntax highlighting for built-in functions fixed<br> > +The fix highlights only the correct built-in function calls and<br> > +attributes with font-lock-builtin-face. When some class defines<br> > +a function with the same name as a built-in function, earlier it was<= br> > +being highlighted with the same font-lock-builtin-face, which was<br> > +incorrect. Now, normal user defined functions will be highlighted<br> > +with font-lock-function-call-face face and built-in functions and<br> > +attributes will be highlighted with font-lock-builtin-face.<br> <br> This part is not needed, I think: we don't document bugfixes in NEWS.<b= r> <br> > +=C2=A0 =C2=A0`((call function: (identifier) @font-lock-builtin-face<b= r> > +=C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0(:match ,(rx-to-string `(seq= bol (or ,@python--treesit-builtins) eol))<br> > +=C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0= @font-lock-builtin-face))<br> > +=C2=A0 =C2=A0 =C2=A0(attribute attribute: (identifier) @font-lock-bui= ltin-face<br> > +=C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 (:match ,(rx-= to-string `(seq bol (or ,@python--treesit-special-attributes) eol))<br> > +=C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0= =C2=A0 =C2=A0 @font-lock-builtin-face)))<br> <br> Please reformat the whitespace here to avoid exceeding 80 columns in<br> each individual line.<br> </blockquote></div> --000000000000bcd312061681ac7c-- --000000000000bcd314061681ac7e Content-Type: application/octet-stream; name="0002-Reformat-treesitter-query-for-builtins-to-not-exceed.patch" Content-Disposition: attachment; filename="0002-Reformat-treesitter-query-for-builtins-to-not-exceed.patch" Content-Transfer-Encoding: base64 Content-ID: <f_lv7qsoa60> X-Attachment-Id: f_lv7qsoa60 RnJvbSA4NjdjNjc2NzBiMzFkMGFkZjRhMTY3MTE3OTJlMmQ4MzllYjhlYmQ3IE1vbiBTZXAgMTcg MDA6MDA6MDAgMjAwMQpGcm9tOiBQcmF0ZWVrIFNoYXJtYSA8cHMucHJhdGVlay5zaGFybWExNDNA Z21haWwuY29tPgpEYXRlOiBTYXQsIDIwIEFwciAyMDI0IDEyOjEzOjQ4ICswNTMwClN1YmplY3Q6 IFtQQVRDSCAyLzJdIFJlZm9ybWF0IHRyZWVzaXR0ZXIgcXVlcnkgZm9yIGJ1aWx0aW5zIHRvIG5v dCBleGNlZWQgODAKIGNvbHVtbnMKCiogZXRjL05FV1M6IFJlbW92ZSBidWdmaXggbmV3cyBhcyBp dCdzIG5vdCBuZWVkZWQKKiBsaXNwL3Byb2dtb2Rlcy9weXRob24uZWwgKHB5dGhvbi0tdHJlZXNp dC1zZXR0aW5ncyk6IFJlZm9ybWF0IHRoZSB0cmVlc2l0dGVyIHF1ZXJ5IGZvciBmb250LWxvY2sg dG8gbm90IGV4Y2VlZCA4MCBjb2x1bW5zCi0tLQogZXRjL05FV1MgICAgICAgICAgICAgICAgIHwg OSAtLS0tLS0tLS0KIGxpc3AvcHJvZ21vZGVzL3B5dGhvbi5lbCB8IDcgKysrKystLQogMiBmaWxl cyBjaGFuZ2VkLCA1IGluc2VydGlvbnMoKyksIDExIGRlbGV0aW9ucygtKQoKZGlmZiAtLWdpdCBh L2V0Yy9ORVdTIGIvZXRjL05FV1MKaW5kZXggZTVjZDcwYjYxMDYuLjhhZDFlNzhjYTYwIDEwMDY0 NAotLS0gYS9ldGMvTkVXUworKysgYi9ldGMvTkVXUwpAQCAtMTMxOSwxNSArMTMxOSw2IEBAIGlu c3RlYWQgb2Y6CiBUaGlzIGFsbG93cyB0aGUgdXNlciB0byBzcGVjaWZ5IGNvbW1hbmQgbGluZSBh cmd1bWVudHMgdG8gdGhlIG5vbgogaW50ZXJhY3RpdmUgUHl0aG9uIGludGVycHJldGVyIHNwZWNp ZmllZCBieSAncHl0aG9uLWludGVycHJldGVyJy4KIAotKioqIFRyZWVzaXR0ZXIgc3ludGF4IGhp Z2hsaWdodGluZyBmb3IgYnVpbHQtaW4gZnVuY3Rpb25zIGZpeGVkCi1UaGUgZml4IGhpZ2hsaWdo dHMgb25seSB0aGUgY29ycmVjdCBidWlsdC1pbiBmdW5jdGlvbiBjYWxscyBhbmQKLWF0dHJpYnV0 ZXMgd2l0aCBmb250LWxvY2stYnVpbHRpbi1mYWNlLiBXaGVuIHNvbWUgY2xhc3MgZGVmaW5lcwot YSBmdW5jdGlvbiB3aXRoIHRoZSBzYW1lIG5hbWUgYXMgYSBidWlsdC1pbiBmdW5jdGlvbiwgZWFy bGllciBpdCB3YXMKLWJlaW5nIGhpZ2hsaWdodGVkIHdpdGggdGhlIHNhbWUgZm9udC1sb2NrLWJ1 aWx0aW4tZmFjZSwgd2hpY2ggd2FzCi1pbmNvcnJlY3QuIE5vdywgbm9ybWFsIHVzZXIgZGVmaW5l ZCBmdW5jdGlvbnMgd2lsbCBiZSBoaWdobGlnaHRlZAotd2l0aCBmb250LWxvY2stZnVuY3Rpb24t Y2FsbC1mYWNlIGZhY2UgYW5kIGJ1aWx0LWluIGZ1bmN0aW9ucyBhbmQKLWF0dHJpYnV0ZXMgd2ls bCBiZSBoaWdobGlnaHRlZCB3aXRoIGZvbnQtbG9jay1idWlsdGluLWZhY2UuCi0KICoqIFNjaGVt ZSBtb2RlCiBTY2hlbWUgbW9kZSBub3cgaGFuZGxlcyByZWd1bGFyIGV4cHJlc3Npb24gbGl0ZXJh bCAnIy9yZWdleHAvJyB0aGF0IGlzCiBhdmFpbGFibGUgaW4gc29tZSBTY2hlbWUgaW1wbGVtZW50 YXRpb25zLgpkaWZmIC0tZ2l0IGEvbGlzcC9wcm9nbW9kZXMvcHl0aG9uLmVsIGIvbGlzcC9wcm9n bW9kZXMvcHl0aG9uLmVsCmluZGV4IDVjNjdkMDc2NWViLi5kNmMyOWU1ZmZjNiAxMDA2NDQKLS0t IGEvbGlzcC9wcm9nbW9kZXMvcHl0aG9uLmVsCisrKyBiL2xpc3AvcHJvZ21vZGVzL3B5dGhvbi5l bApAQCAtMTIwNywxMCArMTIwNywxMyBAQCBmb250aWZpZWQuIgogICAgOmZlYXR1cmUgJ2J1aWx0 aW4KICAgIDpsYW5ndWFnZSAncHl0aG9uCiAgICBgKChjYWxsIGZ1bmN0aW9uOiAoaWRlbnRpZmll cikgQGZvbnQtbG9jay1idWlsdGluLWZhY2UKLSAgICAgICAgICAgKDptYXRjaCAsKHJ4LXRvLXN0 cmluZyBgKHNlcSBib2wgKG9yICxAcHl0aG9uLS10cmVlc2l0LWJ1aWx0aW5zKSBlb2wpKQorICAg ICAgICAgICAoOm1hdGNoICwocngtdG8tc3RyaW5nCisgICAgICAgICAgICAgICAgICAgICBgKHNl cSBib2wgKG9yICxAcHl0aG9uLS10cmVlc2l0LWJ1aWx0aW5zKSBlb2wpKQogICAgICAgICAgICAg ICAgICAgIEBmb250LWxvY2stYnVpbHRpbi1mYWNlKSkKICAgICAgKGF0dHJpYnV0ZSBhdHRyaWJ1 dGU6IChpZGVudGlmaWVyKSBAZm9udC1sb2NrLWJ1aWx0aW4tZmFjZQotICAgICAgICAgICAgICAg ICg6bWF0Y2ggLChyeC10by1zdHJpbmcgYChzZXEgYm9sIChvciAsQHB5dGhvbi0tdHJlZXNpdC1z cGVjaWFsLWF0dHJpYnV0ZXMpIGVvbCkpCisgICAgICAgICAgICAgICAgKDptYXRjaCAsKHJ4LXRv LXN0cmluZworICAgICAgICAgICAgICAgICAgICAgICAgICBgKHNlcSBib2wKKyAgICAgICAgICAg ICAgICAgICAgICAgICAgICAgICAgKG9yICxAcHl0aG9uLS10cmVlc2l0LXNwZWNpYWwtYXR0cmli dXRlcykgZW9sKSkKICAgICAgICAgICAgICAgICAgICAgICAgIEBmb250LWxvY2stYnVpbHRpbi1m YWNlKSkpCiAKICAgIDpmZWF0dXJlICdkZWNvcmF0b3IKLS0gCjIuMzkuMyAoQXBwbGUgR2l0LTE0 NikKCg== --000000000000bcd314061681ac7e--
bug-gnu-emacs@HIDDEN:bug#70478; Package emacs.
Full text available.Received: (at 70478) by debbugs.gnu.org; 20 Apr 2024 06:14:16 +0000 From debbugs-submit-bounces <at> debbugs.gnu.org Sat Apr 20 02:14:16 2024 Received: from localhost ([127.0.0.1]:34491 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from <debbugs-submit-bounces <at> debbugs.gnu.org>) id 1ry3zK-0003DS-IE for submit <at> debbugs.gnu.org; Sat, 20 Apr 2024 02:14:15 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]:56156) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from <eliz@HIDDEN>) id 1ry3zG-0003CP-Qe for 70478 <at> debbugs.gnu.org; Sat, 20 Apr 2024 02:14:12 -0400 Received: from fencepost.gnu.org ([2001:470:142:3::e]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from <eliz@HIDDEN>) id 1ry3yw-0003L8-TQ; Sat, 20 Apr 2024 02:13:50 -0400 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=gnu.org; s=fencepost-gnu-org; h=References:Subject:In-Reply-To:To:From:Date: mime-version; bh=uRrKcIB6W4P53aDrkuhEImkVF5wzrf2qT9VfNNPBqQc=; b=ltRhcu7e8Fe8 xDM+rh/QExuGS7mUvXFmgU/7ZlydHtMLk6uDS84tP/YSqeXQw9EsDnKVsXpbkfWhASgVUkExFe9T9 WJjQXDhCBu28c9W6qZhatoynYBVOAQaYyZZUgI/GpfrwzLGksKdWX5Qp07NPudRh0C6GfAcvCZI+2 uI42eg6h7PUMeEgMIxBzQA7w6N3oiq+wnCZyyeAYhv/p4r+1x1JHrQrnP7cXIZFVkxbUBOgqLHa5x wPQS6hsFHd56JAzc/YZQBYMBdMD/sUAIVKuEUEtXiK9n32PM4Zns2WRaY5F/Zkm70C4hseA/ISt67 IKYqlUY2BIFnWF3IqY0ozQ==; Date: Sat, 20 Apr 2024 09:13:48 +0300 Message-Id: <86le58a7dv.fsf@HIDDEN> From: Eli Zaretskii <eliz@HIDDEN> To: Prateek Sharma <ps.prateek.sharma143@HIDDEN>, Yuan Fu <casouri@HIDDEN> In-Reply-To: <CALFrjHzHr=T3S7UsCBzrLoQ34y5hqGBYkqaXTx04ooAo9qz1LQ@HIDDEN> (message from Prateek Sharma on Sat, 20 Apr 2024 02:30:17 +0530) Subject: Re: bug#70478: 30.0.50; [PATCH] Fix treesitter-font-lock-settings for built-in functions and attributes. References: <CALFrjHzHr=T3S7UsCBzrLoQ34y5hqGBYkqaXTx04ooAo9qz1LQ@HIDDEN> X-Spam-Score: -2.3 (--) X-Debbugs-Envelope-To: 70478 Cc: 70478 <at> debbugs.gnu.org X-BeenThere: debbugs-submit <at> debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: <debbugs-submit.debbugs.gnu.org> List-Unsubscribe: <https://debbugs.gnu.org/cgi-bin/mailman/options/debbugs-submit>, <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=unsubscribe> List-Archive: <https://debbugs.gnu.org/cgi-bin/mailman/private/debbugs-submit/> List-Post: <mailto:debbugs-submit <at> debbugs.gnu.org> List-Help: <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=help> List-Subscribe: <https://debbugs.gnu.org/cgi-bin/mailman/listinfo/debbugs-submit>, <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=subscribe> Errors-To: debbugs-submit-bounces <at> debbugs.gnu.org Sender: "Debbugs-submit" <debbugs-submit-bounces <at> debbugs.gnu.org> X-Spam-Score: -3.3 (---) > From: Prateek Sharma <ps.prateek.sharma143@HIDDEN> > Date: Sat, 20 Apr 2024 02:30:17 +0530 > > I do a lot of programming in python and have noticed that if there is a > method of a class defined with the same name as a builtin function. It > gets highlighted with the face for builtin functions and it looks > different for all the other functions and confuses me sometimes and just > looks inconsistent. > > I have made a simple fix to the treesitter query and it seems to have > fixed the problem. > > Please share you thoughts on this fix. This is my first time > contributing to an open-source project and to emacs. Very excited to > hear from you guys!!! Thanks. Yuan, any comments? I have a few minor comments below. > diff --git a/etc/NEWS b/etc/NEWS > index 8ad1e78ca60..e5cd70b6106 100644 > --- a/etc/NEWS > +++ b/etc/NEWS > @@ -1319,6 +1319,15 @@ instead of: > This allows the user to specify command line arguments to the non > interactive Python interpreter specified by 'python-interpreter'. > > +*** Treesitter syntax highlighting for built-in functions fixed > +The fix highlights only the correct built-in function calls and > +attributes with font-lock-builtin-face. When some class defines > +a function with the same name as a built-in function, earlier it was > +being highlighted with the same font-lock-builtin-face, which was > +incorrect. Now, normal user defined functions will be highlighted > +with font-lock-function-call-face face and built-in functions and > +attributes will be highlighted with font-lock-builtin-face. This part is not needed, I think: we don't document bugfixes in NEWS. > + `((call function: (identifier) @font-lock-builtin-face > + (:match ,(rx-to-string `(seq bol (or ,@python--treesit-builtins) eol)) > + @font-lock-builtin-face)) > + (attribute attribute: (identifier) @font-lock-builtin-face > + (:match ,(rx-to-string `(seq bol (or ,@python--treesit-special-attributes) eol)) > + @font-lock-builtin-face))) Please reformat the whitespace here to avoid exceeding 80 columns in each individual line.
bug-gnu-emacs@HIDDEN:bug#70478; Package emacs.
Full text available.Received: (at submit) by debbugs.gnu.org; 19 Apr 2024 23:05:38 +0000 From debbugs-submit-bounces <at> debbugs.gnu.org Fri Apr 19 19:05:38 2024 Received: from localhost ([127.0.0.1]:60867 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from <debbugs-submit-bounces <at> debbugs.gnu.org>) id 1rxxIX-0001pU-CG for submit <at> debbugs.gnu.org; Fri, 19 Apr 2024 19:05:38 -0400 Received: from lists.gnu.org ([2001:470:142::17]:58800) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from <ps.prateek.sharma143@HIDDEN>) id 1rxvME-00048C-0c for submit <at> debbugs.gnu.org; Fri, 19 Apr 2024 17:01:20 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from <ps.prateek.sharma143@HIDDEN>) id 1rxvLW-0001Hq-MI for bug-gnu-emacs@HIDDEN; Fri, 19 Apr 2024 17:00:35 -0400 Received: from mail-vk1-xa2e.google.com ([2607:f8b0:4864:20::a2e]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from <ps.prateek.sharma143@HIDDEN>) id 1rxvLU-0006qC-3o for bug-gnu-emacs@HIDDEN; Fri, 19 Apr 2024 17:00:34 -0400 Received: by mail-vk1-xa2e.google.com with SMTP id 71dfb90a1353d-4db24342894so720741e0c.0 for <bug-gnu-emacs@HIDDEN>; Fri, 19 Apr 2024 14:00:30 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1713560429; x=1714165229; darn=gnu.org; h=to:subject:message-id:date:from:mime-version:from:to:cc:subject :date:message-id:reply-to; bh=EWsWsFvWbI9DbG2xjapX7oz26DQ9c+Z0BGA+DXSLZ2w=; b=GBap2dmTegnTZERngqtW5oM6vXe1327JVcWGbVpWHjGXWKxeYyIMOwAT1liGOZLtmg n8W9b+zZ0e03XbpriRq7Vdve9HDsUAmxH03sL+BrT6hSBNsnZP2RNLceWW4jrmDpaasp 88U5RXoIRxYkGWF/cuuQzOPKAEdDmSJZY2wcf9svzSJnPD8IDjLh08DntZUBaf01jK0Z hiQS0kTQwshzmhi8yCulShHadX01l1SMCOgnCErz90Y3/G/6bxbkLUtf4eGFdlTp146u qU9mcwBGk4OEQ5jUSKD+9wEIIqEQm8lDEyl5+5I7TWAwlZaEkPt2CHBL4O9EQuYK0XxS IiFg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1713560429; x=1714165229; h=to:subject:message-id:date:from:mime-version:x-gm-message-state :from:to:cc:subject:date:message-id:reply-to; bh=EWsWsFvWbI9DbG2xjapX7oz26DQ9c+Z0BGA+DXSLZ2w=; b=BhKpKt/4X3vV8P25gpYxDuFTeW9+R9WcwA9eTV1ac5EiAEQib/q81lmW1ha9qIJRZa HNON/64nxeqshEu7GVnvHJHYCgiByQMKWi/IyOleys3NnYNOqiVaTYWH65gHjccXLx6P OK/SaH7cl3kNjm+2cPAhS8LIXJYSju+JjpRKlZfKV9fOoKOZVptd6BDl8Ok5nqvOMOjb fke8UfbiHjfQK+VwCG7bw9cqxagZitG53G7jACS/swM26NLHThJb42kGK//K91N4ZXLK uz6e43dSh2ladyKncQLRU5MPg8hl8AIoi1wsIFsa89Pjdd601VPipd3+eEJWFHsJtqkp pzJA== X-Gm-Message-State: AOJu0Yx3e1G3VKbeVMT/hvnYFTUxwlacK/cxHgGjzY1lFc2cagat9uua BY8yd7Jz+xJd0s7ssNhXOn8xsogySMktBuJq1KqenSxf6McRvO82mSOYri06ZXLZDKYggVIQVE6 BIGIrmDn5gT8iP7pD82IHhikI8k3OwFhZ X-Google-Smtp-Source: AGHT+IGnMuIVn/8sFKuqP+ANN23hIfhC38PI7fuQe8ERcFmFSbTAGLYIp3MxcjQio630b8MtkC4pne1wao399f75j8I= X-Received: by 2002:a05:6122:220c:b0:4d4:19e9:db0 with SMTP id bb12-20020a056122220c00b004d419e90db0mr3465109vkb.0.1713560428874; Fri, 19 Apr 2024 14:00:28 -0700 (PDT) MIME-Version: 1.0 From: Prateek Sharma <ps.prateek.sharma143@HIDDEN> Date: Sat, 20 Apr 2024 02:30:17 +0530 Message-ID: <CALFrjHzHr=T3S7UsCBzrLoQ34y5hqGBYkqaXTx04ooAo9qz1LQ@HIDDEN> Subject: 30.0.50; [PATCH] Fix treesitter-font-lock-settings for built-in functions and attributes. To: bug-gnu-emacs@HIDDEN Content-Type: multipart/mixed; boundary="000000000000aa270806167960c9" Received-SPF: pass client-ip=2607:f8b0:4864:20::a2e; envelope-from=ps.prateek.sharma143@HIDDEN; helo=mail-vk1-xa2e.google.com X-Spam_score_int: -17 X-Spam_score: -1.8 X-Spam_bar: - X-Spam_report: (-1.8 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, FREEMAIL_ENVFROM_END_DIGIT=0.25, FREEMAIL_FROM=0.001, HTML_MESSAGE=0.001, RCVD_IN_DNSWL_NONE=-0.0001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-Spam-Score: 1.2 (+) X-Spam-Report: Spam detection software, running on the system "debbugs.gnu.org", has NOT identified this incoming email as spam. The original message has been attached to this so you can view it or label similar future email. If you have any questions, see the administrator of that system for details. Content preview: Dear maintainers, I do a lot of programming in python and have noticed that if there is a method of a class defined with the same name as a builtin function. It gets highlighted with the face for builtin functions and [...] Content analysis details: (1.2 points, 10.0 required) pts rule name description ---- ---------------------- -------------------------------------------------- 0.0 FREEMAIL_FROM Sender email is commonly abused enduser mail provider (ps.prateek.sharma143[at]gmail.com) 0.2 FREEMAIL_ENVFROM_END_DIGIT Envelope-from freemail username ends in digit (ps.prateek.sharma143[at]gmail.com) 1.0 SPF_SOFTFAIL SPF: sender does not match SPF record (softfail) -0.0 SPF_HELO_PASS SPF: HELO matches SPF record 0.0 HTML_MESSAGE BODY: HTML included in message X-Debbugs-Envelope-To: submit X-Mailman-Approved-At: Fri, 19 Apr 2024 19:05:09 -0400 X-BeenThere: debbugs-submit <at> debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: <debbugs-submit.debbugs.gnu.org> List-Unsubscribe: <https://debbugs.gnu.org/cgi-bin/mailman/options/debbugs-submit>, <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=unsubscribe> List-Archive: <https://debbugs.gnu.org/cgi-bin/mailman/private/debbugs-submit/> List-Post: <mailto:debbugs-submit <at> debbugs.gnu.org> List-Help: <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=help> List-Subscribe: <https://debbugs.gnu.org/cgi-bin/mailman/listinfo/debbugs-submit>, <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=subscribe> Errors-To: debbugs-submit-bounces <at> debbugs.gnu.org Sender: "Debbugs-submit" <debbugs-submit-bounces <at> debbugs.gnu.org> X-Spam-Score: 0.2 (/) --000000000000aa270806167960c9 Content-Type: multipart/alternative; boundary="000000000000aa270806167960c7" --000000000000aa270806167960c7 Content-Type: text/plain; charset="UTF-8" Dear maintainers, I do a lot of programming in python and have noticed that if there is a method of a class defined with the same name as a builtin function. It gets highlighted with the face for builtin functions and it looks different for all the other functions and confuses me sometimes and just looks inconsistent. I have made a simple fix to the treesitter query and it seems to have fixed the problem. Please share you thoughts on this fix. This is my first time contributing to an open-source project and to emacs. Very excited to hear from you guys!!! Prateek Sharma --000000000000aa270806167960c7 Content-Type: text/html; charset="UTF-8" Content-Transfer-Encoding: quoted-printable <div dir=3D"ltr">Dear maintainers,<br><br>I do a lot of programming in pyth= on and have noticed that if there is a<br>method of a class defined with th= e same name as a builtin function. It<br>gets highlighted with the face for= builtin functions and it looks<br>different for all the other functions an= d confuses me sometimes and just<br>looks inconsistent.<br><br>I have made = a simple fix to the treesitter query and it seems to have<br>fixed the prob= lem.<br><br>Please share you thoughts on this fix. This is my first time<br= >contributing to an open-source project and to emacs. Very excited to<br>he= ar from you guys!!!<br><br>Prateek Sharma<br></div> --000000000000aa270806167960c7-- --000000000000aa270806167960c9 Content-Type: application/octet-stream; name="0001-Fix-treesitter-font-lock-settings-for-built-in-funct.patch" Content-Disposition: attachment; filename="0001-Fix-treesitter-font-lock-settings-for-built-in-funct.patch" Content-Transfer-Encoding: base64 Content-ID: <f_lv75meqq0> X-Attachment-Id: f_lv75meqq0 RnJvbSAzYmEyM2FlYTI4Nzk2YjgwMTgzMmJhZjFhYTVlMTA5MmNmZjg4ZTZlIE1vbiBTZXAgMTcg MDA6MDA6MDAgMjAwMQpGcm9tOiBQcmF0ZWVrIFNoYXJtYSA8cHMucHJhdGVlay5zaGFybWExNDNA Z21haWwuY29tPgpEYXRlOiBTYXQsIDIwIEFwciAyMDI0IDAyOjA2OjE3ICswNTMwClN1YmplY3Q6 IFtQQVRDSF0gRml4IHRyZWVzaXR0ZXItZm9udC1sb2NrLXNldHRpbmdzIGZvciBidWlsdC1pbiBm dW5jdGlvbnMgYW5kCiBhdHRyaWJ1dGVzLgoKKiBldGMvTkVXUzogQW5ub3VuY2UgdGhlIGVmZmVj dCBvZiB0aGUgY2hhbmdlcyBmb3IgdGhlIHRyZWVzaXR0ZXItZm9udC1sb2NrLXNldHRpbmdzIGZv ciBidWlsdC1pbiBmdW5jdGlvbnMgYW5kIGF0dHJpYnV0ZXMKKiBsaXNwL3Byb2dtb2Rlcy9weXRo b24uZWwgKHB5dGhvbi0tdHJlZXNpdC1zZXR0aW5ncyk6IENoYW5nZSB0aGUgdHJlZXNpdHRlciBx dWVyeSB0byBmZXRjaCB0aGUgY29ycmVjdCB0eXBlIG9mIG5vZGUgZm9yIGJ1aWx0LWluIGZ1bmN0 aW9ucyBhbmQgYXR0cmlidXRlcyBhbmQgaGlnaGxpZ2h0IHRoZW0gd2l0aCBjb3JyZXNwb25kaW5n IGZvbnQtbG9jayBmYWNlLgotLS0KIGV0Yy9ORVdTICAgICAgICAgICAgICAgICB8ICA5ICsrKysr KysrKwogbGlzcC9wcm9nbW9kZXMvcHl0aG9uLmVsIHwgMTMgKysrKysrLS0tLS0tLQogMiBmaWxl cyBjaGFuZ2VkLCAxNSBpbnNlcnRpb25zKCspLCA3IGRlbGV0aW9ucygtKQoKZGlmZiAtLWdpdCBh L2V0Yy9ORVdTIGIvZXRjL05FV1MKaW5kZXggOGFkMWU3OGNhNjAuLmU1Y2Q3MGI2MTA2IDEwMDY0 NAotLS0gYS9ldGMvTkVXUworKysgYi9ldGMvTkVXUwpAQCAtMTMxOSw2ICsxMzE5LDE1IEBAIGlu c3RlYWQgb2Y6CiBUaGlzIGFsbG93cyB0aGUgdXNlciB0byBzcGVjaWZ5IGNvbW1hbmQgbGluZSBh cmd1bWVudHMgdG8gdGhlIG5vbgogaW50ZXJhY3RpdmUgUHl0aG9uIGludGVycHJldGVyIHNwZWNp ZmllZCBieSAncHl0aG9uLWludGVycHJldGVyJy4KIAorKioqIFRyZWVzaXR0ZXIgc3ludGF4IGhp Z2hsaWdodGluZyBmb3IgYnVpbHQtaW4gZnVuY3Rpb25zIGZpeGVkCitUaGUgZml4IGhpZ2hsaWdo dHMgb25seSB0aGUgY29ycmVjdCBidWlsdC1pbiBmdW5jdGlvbiBjYWxscyBhbmQKK2F0dHJpYnV0 ZXMgd2l0aCBmb250LWxvY2stYnVpbHRpbi1mYWNlLiBXaGVuIHNvbWUgY2xhc3MgZGVmaW5lcwor YSBmdW5jdGlvbiB3aXRoIHRoZSBzYW1lIG5hbWUgYXMgYSBidWlsdC1pbiBmdW5jdGlvbiwgZWFy bGllciBpdCB3YXMKK2JlaW5nIGhpZ2hsaWdodGVkIHdpdGggdGhlIHNhbWUgZm9udC1sb2NrLWJ1 aWx0aW4tZmFjZSwgd2hpY2ggd2FzCitpbmNvcnJlY3QuIE5vdywgbm9ybWFsIHVzZXIgZGVmaW5l ZCBmdW5jdGlvbnMgd2lsbCBiZSBoaWdobGlnaHRlZAord2l0aCBmb250LWxvY2stZnVuY3Rpb24t Y2FsbC1mYWNlIGZhY2UgYW5kIGJ1aWx0LWluIGZ1bmN0aW9ucyBhbmQKK2F0dHJpYnV0ZXMgd2ls bCBiZSBoaWdobGlnaHRlZCB3aXRoIGZvbnQtbG9jay1idWlsdGluLWZhY2UuCisKICoqIFNjaGVt ZSBtb2RlCiBTY2hlbWUgbW9kZSBub3cgaGFuZGxlcyByZWd1bGFyIGV4cHJlc3Npb24gbGl0ZXJh bCAnIy9yZWdleHAvJyB0aGF0IGlzCiBhdmFpbGFibGUgaW4gc29tZSBTY2hlbWUgaW1wbGVtZW50 YXRpb25zLgpkaWZmIC0tZ2l0IGEvbGlzcC9wcm9nbW9kZXMvcHl0aG9uLmVsIGIvbGlzcC9wcm9n bW9kZXMvcHl0aG9uLmVsCmluZGV4IDg1Mjc5ZDNlODRiLi41YzY3ZDA3NjVlYiAxMDA2NDQKLS0t IGEvbGlzcC9wcm9nbW9kZXMvcHl0aG9uLmVsCisrKyBiL2xpc3AvcHJvZ21vZGVzL3B5dGhvbi5l bApAQCAtMTIwNiwxMyArMTIwNiwxMiBAQCBmb250aWZpZWQuIgogCiAgICA6ZmVhdHVyZSAnYnVp bHRpbgogICAgOmxhbmd1YWdlICdweXRob24KLSAgIGAoKChpZGVudGlmaWVyKSBAZm9udC1sb2Nr LWJ1aWx0aW4tZmFjZQotICAgICAgKDptYXRjaCAsKHJ4LXRvLXN0cmluZwotICAgICAgICAgICAg ICAgIGAoc2VxIGJvbAotICAgICAgICAgICAgICAgICAgICAgIChvciAsQHB5dGhvbi0tdHJlZXNp dC1idWlsdGlucwotICAgICAgICAgICAgICAgICAgICAgICAgICAsQHB5dGhvbi0tdHJlZXNpdC1z cGVjaWFsLWF0dHJpYnV0ZXMpCi0gICAgICAgICAgICAgICAgICAgICAgZW9sKSkKLSAgICAgICAg ICAgICAgQGZvbnQtbG9jay1idWlsdGluLWZhY2UpKSkKKyAgIGAoKGNhbGwgZnVuY3Rpb246IChp ZGVudGlmaWVyKSBAZm9udC1sb2NrLWJ1aWx0aW4tZmFjZQorICAgICAgICAgICAoOm1hdGNoICwo cngtdG8tc3RyaW5nIGAoc2VxIGJvbCAob3IgLEBweXRob24tLXRyZWVzaXQtYnVpbHRpbnMpIGVv bCkpCisgICAgICAgICAgICAgICAgICAgQGZvbnQtbG9jay1idWlsdGluLWZhY2UpKQorICAgICAo YXR0cmlidXRlIGF0dHJpYnV0ZTogKGlkZW50aWZpZXIpIEBmb250LWxvY2stYnVpbHRpbi1mYWNl CisgICAgICAgICAgICAgICAgKDptYXRjaCAsKHJ4LXRvLXN0cmluZyBgKHNlcSBib2wgKG9yICxA cHl0aG9uLS10cmVlc2l0LXNwZWNpYWwtYXR0cmlidXRlcykgZW9sKSkKKyAgICAgICAgICAgICAg ICAgICAgICAgIEBmb250LWxvY2stYnVpbHRpbi1mYWNlKSkpCiAKICAgIDpmZWF0dXJlICdkZWNv cmF0b3IKICAgIDpsYW5ndWFnZSAncHl0aG9uCi0tIAoyLjM5LjMgKEFwcGxlIEdpdC0xNDYpCgo= --000000000000aa270806167960c9--
Prateek Sharma <ps.prateek.sharma143@HIDDEN>:bug-gnu-emacs@HIDDEN.
Full text available.bug-gnu-emacs@HIDDEN:bug#70478; Package emacs.
Full text available.
GNU bug tracking system
Copyright (C) 1999 Darren O. Benham,
1997 nCipher Corporation Ltd,
1994-97 Ian Jackson.