GNU bug report logs - #70481
[PATCH 0/2] Update qmmp

Previous Next

To reply to this bug, email your comments to 70481 AT debbugs.gnu.org.
There is no need to reopen the bug first.

Toggle the display of automated, internal messages from the tracker.

Message #5 received at submit <at> debbugs.gnu.org (full text, mbox):

From: Timotej Lazar <timotej.lazar <at> araneo.si>
To: guix-patches <at> gnu.org
Cc: Timotej Lazar <timotej.lazar <at> araneo.si>
Subject: [PATCH 0/2] Update qmmp
Date: Sat, 20 Apr 2024 15:08:00 +0200

Timotej Lazar (2):
  gnu: qmmp: Update to 2.1.7.
  gnu: qmmp: Add missing inputs.

 gnu/packages/music.scm | 20 ++++++++++++++++----
 1 file changed, 16 insertions(+), 4 deletions(-)


base-commit: 0f68306268773f0eaa4327e1f6fdcb39442e4a34
-- 
2.41.0

Message #8 received at 70481 <at> debbugs.gnu.org (full text, mbox):

From: Timotej Lazar <timotej.lazar <at> araneo.si>
To: 70481 <at> debbugs.gnu.org
Cc: Timotej Lazar <timotej.lazar <at> araneo.si>
Subject: [PATCH 1/2] gnu: qmmp: Update to 2.1.7.
Date: Sat, 20 Apr 2024 15:12:30 +0200

* gnu/packages/music.scm (qmmp): Update to 2.1.7.
[properties]: Add release-monitoring-url.
---
 gnu/packages/music.scm | 8 +++++---
 1 file changed, 5 insertions(+), 3 deletions(-)

diff --git a/gnu/packages/music.scm b/gnu/packages/music.scm
index ceac94a592..86b46bfdfe 100644
--- a/gnu/packages/music.scm
+++ b/gnu/packages/music.scm
@@ -603,15 +603,15 @@ (define-public ctrlr
 (define-public qmmp
   (package
     (name "qmmp")
-    (version "2.1.6")
+    (version "2.1.7")
     (source
      (origin
        (method url-fetch)
-       (uri (string-append "https://qmmp.ylsoftware.com/files/"
+       (uri (string-append "https://qmmp.ylsoftware.com/files/qmmp/"
                            (version-major+minor version) "/"
                            "qmmp-" version ".tar.bz2"))
        (sha256
-        (base32 "1jpflf17198ascaqmxla6ajb69bnj8zzngk32vdyyw5443kshylj"))))
+        (base32 "0wqy4dh5cci67d822zn2535l0vsvd9c9sqsbscz4j530c6y6g9z6"))))
     (build-system qt-build-system)
     (arguments
      (list #:qtbase qtbase
@@ -650,6 +650,8 @@ (define-public qmmp
     (native-inputs
      (list pkg-config))
     (home-page "https://qmmp.ylsoftware.com")
+    (properties
+     `((release-monitoring-url . "https://qmmp.ylsoftware.com/downloads.php")))
     (synopsis "Qt-based music player")
     (description "Music player with support for most common audio formats, and
 plugins for various additional features such as visualization, effects and
-- 
2.41.0

Message #11 received at 70481 <at> debbugs.gnu.org (full text, mbox):

From: Timotej Lazar <timotej.lazar <at> araneo.si>
To: 70481 <at> debbugs.gnu.org
Cc: Timotej Lazar <timotej.lazar <at> araneo.si>
Subject: [PATCH 2/2] gnu: qmmp: Add missing inputs.
Date: Sat, 20 Apr 2024 15:12:31 +0200

* gnu/packages/music.scm (qmmp): Add inputs to support unpacking skins.
[inputs]: Add tar and unzip.
[arguments]: Add phase to set absolute paths to these programs.

Change-Id: I79a6530ad27b474ecc64e5b7de36e0370595bc69
---
 gnu/packages/music.scm | 12 +++++++++++-
 1 file changed, 11 insertions(+), 1 deletion(-)

diff --git a/gnu/packages/music.scm b/gnu/packages/music.scm
index 86b46bfdfe..df3ff38b4a 100644
--- a/gnu/packages/music.scm
+++ b/gnu/packages/music.scm
@@ -615,7 +615,15 @@ (define-public qmmp
     (build-system qt-build-system)
     (arguments
      (list #:qtbase qtbase
-           #:tests? #f)) ; there are no tests
+           #:tests? #f ; there are no tests
+           #:phases
+           #~(modify-phases %standard-phases
+               (add-after 'unpack 'set-paths
+                 (lambda* (#:key inputs #:allow-other-keys)
+                   (substitute* "src/plugins/Ui/skinned/skinreader.cpp"
+                     (("\"(tar|unzip)\"" _ name)
+                      (let ((file (string-append "/bin/" name)))
+                        (string-append "\"" (search-input-file inputs file) "\"")))))))))
     (inputs
      ;; Missing optional inputs:
      ;; libsidplay2 ; input plugin
@@ -645,6 +653,8 @@ (define-public qmmp
            qttools
            soxr
            taglib
+           tar ; for loading skins
+           unzip ; for loading skins
            wavpack
            wildmidi))
     (native-inputs
-- 
2.41.0

Message #16 received at 70481-done <at> debbugs.gnu.org (full text, mbox):

From: Zheng Junjie <zhengjunjie <at> iscas.ac.cn>
To: Timotej Lazar <timotej.lazar <at> araneo.si>
Cc: 70481-done <at> debbugs.gnu.org
Subject: Re: [bug#70481] [PATCH 0/2] Update qmmp
Date: Mon, 22 Apr 2024 12:46:06 +0800

[Message part 1 (text/plain, inline)]

Timotej Lazar <timotej.lazar <at> araneo.si> writes:

> Timotej Lazar (2):
>   gnu: qmmp: Update to 2.1.7.
>   gnu: qmmp: Add missing inputs.
>
>  gnu/packages/music.scm | 20 ++++++++++++++++----
>  1 file changed, 16 insertions(+), 4 deletions(-)
>
>
> base-commit: 0f68306268773f0eaa4327e1f6fdcb39442e4a34

LGTM, push. see
https://git.savannah.gnu.org/cgit/guix.git/commit/?id=fa67c2718a22348f49f279704e79925bc7488da5
and https://git.savannah.gnu.org/cgit/guix.git/commit/?id=53623ce862fb9cb02b1a6028d37c2e240eb05093

[signature.asc (application/pgp-signature, inline)]

Previous Next

GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson.