Received: (at 70508) by debbugs.gnu.org; 22 Apr 2024 12:41:35 +0000
From debbugs-submit-bounces <at> debbugs.gnu.org Mon Apr 22 08:41:35 2024
Received: from localhost ([127.0.0.1]:45914 helo=debbugs.gnu.org)
by debbugs.gnu.org with esmtp (Exim 4.84_2)
(envelope-from <debbugs-submit-bounces <at> debbugs.gnu.org>)
id 1ryszG-0001zJ-OY
for submit <at> debbugs.gnu.org; Mon, 22 Apr 2024 08:41:35 -0400
Received: from mail.envs.net ([5.199.136.28]:46884)
by debbugs.gnu.org with esmtp (Exim 4.84_2)
(envelope-from <iyzsong@HIDDEN>) id 1ryszD-0001z9-0v
for 70508 <at> debbugs.gnu.org; Mon, 22 Apr 2024 08:41:33 -0400
Received: from localhost (mail.envs.net [127.0.0.1])
by mail.envs.net (Postfix) with ESMTP id 7200638A1C23;
Mon, 22 Apr 2024 12:41:13 +0000 (UTC)
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=envs.net; s=modoboa;
t=1713789673; bh=hXVyaRe5dD9/ItD276ssZWMgh66GVE4nx4WXnf5zBzk=;
h=From:To:Cc:Subject:Date:From;
b=SIiibE76EDY7lPtkHy0R5Cqrasl9SGwkjI5C6zVIoSTk0Jkl7+30AkYcsFzZwykVC
18Y14mbYZKW4RUloTxskXx1y3mU+zkUbxO+8b4pJsF5iZfI5T70T8HZhyQniAzwMDA
wVtHct7gFqBmxKhA/mwCpNyR8sOBWZ2zmId1H2CpPwZb9f7bqnNUm384aq0GFwWBa6
kC9RidTQLmyQNIPfjU6QCzfSpFrlW1ebivOaGR0OJLXP7Hs574pt2yXvNfsE+C0D3O
xBNkFFbFA7YyMmzQZpw9MzqBxqjFAKsB3tIgf3ite1oZxC7PRMNyi5EaIEbe6GSkeA
Kum38I8I7gAhwSEsCAgZq94FxZPCbLuML1dWLfaAkdFImu9oqxNH5f1aWZNnwWmsVu
XSVLLk+SSxs1zCsPpuMw1Fa9fXFRMLYbaPUx1Je3knNnIXPLH5syuqheoKGBOejc6f
eXwxQwlUUw+96G7NNM8FaiyB46vWU6bOY1z0271MyX02M8UdtCBhuaObGyqFcNra4a
ATDvyai3jlqdJYh+mwRAMKcE7sfARwsMjnIIM/J3HyzqTSLeAsgeyvD/VYcnfjy1wg
Ui3CAE5fYRTBv6ql+h/bBbz5pAkbzK2jKwFH0ctxn51i6ZZ3xxyR8WEuHFkX6ICGhd
+GSJERluv8oQ+KO9RT4D0Q8c=
X-Virus-Scanned: Debian amavisd-new at mail.envs.net
Received: from mail.envs.net ([127.0.0.1])
by localhost (mail.envs.net [127.0.0.1]) (amavisd-new, port 10026)
with ESMTP id iobIq1uIvsTN; Mon, 22 Apr 2024 12:41:10 +0000 (UTC)
Received: from localhost (unknown [36.170.58.193])
(using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)
key-exchange ECDHE (P-256) server-signature RSA-PSS (2048 bits) server-digest
SHA256) (No client certificate requested)
by mail.envs.net (Postfix) with ESMTPSA;
Mon, 22 Apr 2024 12:41:09 +0000 (UTC)
Received: from localhost.localdomain (localhost [127.0.0.1])
by localhost (OpenSMTPD) with ESMTP id 48fc250b;
Mon, 22 Apr 2024 12:42:16 +0000 (UTC)
From: iyzsong@HIDDEN
To: 70508 <at> debbugs.gnu.org
Subject: [PATCH] services: Add gvfs-service-type.
Date: Mon, 22 Apr 2024 20:42:13 +0800
Message-ID: <d9f2d24c28021de758b35f3115d45c9ff70ffd09.1713789696.git.iyzsong@HIDDEN>
X-Mailer: git-send-email 2.41.0
MIME-Version: 1.0
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: 8bit
X-Spam-Score: 0.0 (/)
X-Debbugs-Envelope-To: 70508
Cc: =?UTF-8?q?=E5=AE=8B=E6=96=87=E6=AD=A6?= <iyzsong@HIDDEN>
X-BeenThere: debbugs-submit <at> debbugs.gnu.org
X-Mailman-Version: 2.1.18
Precedence: list
List-Id: <debbugs-submit.debbugs.gnu.org>
List-Unsubscribe: <https://debbugs.gnu.org/cgi-bin/mailman/options/debbugs-submit>,
<mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=unsubscribe>
List-Archive: <https://debbugs.gnu.org/cgi-bin/mailman/private/debbugs-submit/>
List-Post: <mailto:debbugs-submit <at> debbugs.gnu.org>
List-Help: <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=help>
List-Subscribe: <https://debbugs.gnu.org/cgi-bin/mailman/listinfo/debbugs-submit>,
<mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=subscribe>
Errors-To: debbugs-submit-bounces <at> debbugs.gnu.org
Sender: "Debbugs-submit" <debbugs-submit-bounces <at> debbugs.gnu.org>
X-Spam-Score: -1.0 (-)
From: 宋文武 <iyzsong@HIDDEN>
* gnu/services/desktop.scm (gvfs-service-type): New variable.
(gvfs-configuration, make-gvfs-configuration, gvfs-configuration?,
gvfs-package): New procedures.
(<gvfs-configuration>): New record.
* doc/guix.texi (Desktop Services): Document it.
Change-Id: I584819500e2ce7d2b14e57dac238a96e9888e75e
---
doc/guix.texi | 19 +++++++++++++++++++
gnu/services/desktop.scm | 28 ++++++++++++++++++++++++++++
2 files changed, 47 insertions(+)
diff --git a/doc/guix.texi b/doc/guix.texi
index 65af136e61..8a31bff121 100644
--- a/doc/guix.texi
+++ b/doc/guix.texi
@@ -24942,6 +24942,25 @@ Desktop Services
@end table
@end deftp
+@defvar gvfs-service-type
+Type for the service that provides virtual file systems for GIO
+applicaitons, which enables support for @code{trash:///}, @code{ftp://},
+@code{sftp://} and many other location schemas in file managers like
+Nautilus (GNOME Files) and Thunar.
+
+The value for this service is a @code{<gvfs-configuration>} object.
+@end defvar
+
+@deftp {Data Type} gvfs-configuration
+Data type representing the configuration for @code{gvfs-service-type}.
+
+@table @asis
+@item @code{gvfs} (default: @code{gvfs}) (type: file-like)
+Package object for GVfs.
+
+@end table
+@end deftp
+
@defvar colord-service-type
This is the type of the service that runs @command{colord}, a system
service with a D-Bus
diff --git a/gnu/services/desktop.scm b/gnu/services/desktop.scm
index 02a7802d58..d0b9728d4a 100644
--- a/gnu/services/desktop.scm
+++ b/gnu/services/desktop.scm
@@ -109,6 +109,10 @@ (define-module (gnu services desktop)
udisks-service ; deprecated
udisks-service-type
+ gvfs-configuration
+ gvfs-configuration?
+ gvfs-service-type
+
colord-service-type
geoclue-application
@@ -989,6 +993,30 @@ (define-deprecated (udisks-service #:key (udisks udisks))
(service udisks-service-type
(udisks-configuration (udisks udisks))))
+
+
+;;;
+;;; GVfs virtual file system.
+;;;
+
+(define-record-type* <gvfs-configuration>
+ gvfs-configuration make-gvfs-configuration
+ gvfs-configuration?
+ (gvfs gvfs-package (default gvfs)))
+
+(define gvfs-service-type
+ (service-type (name 'gvfs)
+ (extensions
+ (list
+ (service-extension profile-service-type
+ (compose list gvfs-package))
+ ;; Required for gvfs-udisks2-volume-monitor.
+ (service-extension udisks-service-type (const #t))))
+ (description
+ "Make GVfs virtual file systems (Trash, SFTP, SMB, HTTP,
+and many other) available for GIO applications.")
+ (default-value (gvfs-configuration))))
+
;;;
;;; Elogind login and seat management service.
base-commit: af4db17122d759705f3fd0ab03ef36c76ec90338
--
2.41.0
guix-patches@HIDDEN:bug#70508; Package guix-patches.
Full text available.Received: (at 70508) by debbugs.gnu.org; 22 Apr 2024 02:46:56 +0000 From debbugs-submit-bounces <at> debbugs.gnu.org Sun Apr 21 22:46:55 2024 Received: from localhost ([127.0.0.1]:45309 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from <debbugs-submit-bounces <at> debbugs.gnu.org>) id 1ryjhm-0003dv-Ki for submit <at> debbugs.gnu.org; Sun, 21 Apr 2024 22:46:55 -0400 Received: from mail.envs.net ([5.199.136.28]:39716) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from <iyzsong@HIDDEN>) id 1ryjhg-0003cs-HX for 70508 <at> debbugs.gnu.org; Sun, 21 Apr 2024 22:46:52 -0400 Received: from localhost (mail.envs.net [127.0.0.1]) by mail.envs.net (Postfix) with ESMTP id B2BA438A1BB8 for <70508 <at> debbugs.gnu.org>; Mon, 22 Apr 2024 02:46:29 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=envs.net; s=modoboa; t=1713753989; bh=mcjnTTqPuPbB80xk80i6y7XHbXzMkM3elkGPa/+FxeM=; h=From:To:Subject:In-Reply-To:References:Date:From; b=bsF3QxqOj9QrBfJK6rD2obDyW7aChz2lHUYdUkZofnEwJ8iCYsCMHfu83AoLSO8Tf q603PduootYwqeuq1mOlxqyngYdXh3eASFByAB6xHrgqAg0eBNPkUhfUrqfW0d8/gg eJ+jTIpZ6czF6kEYjIc6JISQv8A4V6AwRVXBBZCEljDJkKmODEbq5kHXuvKsso07JK g+WfnmhQlQ7AxBmeh6cjFKVpizYxcAcl2hg9yFe3Wupya90ZD+p3igYai5ihrvcNL/ ogX+ZJrqipJwGtONpWB5XvRll9yWjmbApnSXjnekE0shPh6i8V/EtRjP1WgDXN9y+I B8eGbjZqFvefpHJP7tRblKq3ewD3eY/K6+DjNMQrv1UIbpNxaFNQYxSjTPjxcT1c+F 1v5yBejJTy9UxMu0fc8b941iR2CM5pACdn5c0CfEW8SowXQNSTraIKd8OrhyHMN5uq XbyOJJYbqTTEV2IfeEUxpfkzWrGgJ4+6h9+RPY7OvjHtwdItbNY3kPUOC2qlSyWKFv a9spslonv15GkDLyv2+1mFpUWEk4dOm+qNF+M+qUFjvti+HwFr4ZZTzl9EFlQJK0fL NtCSUNFB80WzQfhcyR84OuTNpi5xWyX1NXBSYNl4xcy+oGEW9QwQ0cG9P/ScBzcfU9 CzEVzxvonGr1HvizmldOQ3CM= X-Virus-Scanned: Debian amavisd-new at mail.envs.net Received: from mail.envs.net ([127.0.0.1]) by localhost (mail.envs.net [127.0.0.1]) (amavisd-new, port 10026) with ESMTP id JUxckOCQKH0O for <70508 <at> debbugs.gnu.org>; Mon, 22 Apr 2024 02:46:27 +0000 (UTC) Received: from localhost (unknown [36.170.58.193]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange ECDHE (P-256) server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by mail.envs.net (Postfix) with ESMTPSA for <70508 <at> debbugs.gnu.org>; Mon, 22 Apr 2024 02:46:27 +0000 (UTC) Received: from localhost (localhost [local]) by localhost (OpenSMTPD) with ESMTPA id b25a1cd5 for <70508 <at> debbugs.gnu.org>; Mon, 22 Apr 2024 02:47:35 +0000 (UTC) From: =?utf-8?B?5a6L5paH5q2m?= <iyzsong@HIDDEN> To: 70508 <at> debbugs.gnu.org Subject: Re: [bug#70508] [PATCH] gnu: thunar: Use glib-or-gtk-build-system. In-Reply-To: <6e14dd7d2612569cef62640393bc4ebbb4196f70.1713750442.git.iyzsong@HIDDEN> (iyzsong@HIDDEN's message of "Mon, 22 Apr 2024 09:47:36 +0800") References: <6e14dd7d2612569cef62640393bc4ebbb4196f70.1713750442.git.iyzsong@HIDDEN> Date: Mon, 22 Apr 2024 10:47:35 +0800 Message-ID: <87o7a23ygo.fsf@HIDDEN> User-Agent: Gnus/5.13 (Gnus v5.13) MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable X-Spam-Score: 0.0 (/) X-Debbugs-Envelope-To: 70508 X-BeenThere: debbugs-submit <at> debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: <debbugs-submit.debbugs.gnu.org> List-Unsubscribe: <https://debbugs.gnu.org/cgi-bin/mailman/options/debbugs-submit>, <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=unsubscribe> List-Archive: <https://debbugs.gnu.org/cgi-bin/mailman/private/debbugs-submit/> List-Post: <mailto:debbugs-submit <at> debbugs.gnu.org> List-Help: <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=help> List-Subscribe: <https://debbugs.gnu.org/cgi-bin/mailman/listinfo/debbugs-submit>, <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=subscribe> Errors-To: debbugs-submit-bounces <at> debbugs.gnu.org Sender: "Debbugs-submit" <debbugs-submit-bounces <at> debbugs.gnu.org> X-Spam-Score: -1.0 (-) iyzsong@HIDDEN writes: > From: =E5=AE=8B=E6=96=87=E6=AD=A6 <iyzsong@HIDDEN> > > This wraps 'thunar' with GIO_EXTRA_MODULES to enable support for "Trash" = and > remote file systems via GVFS. > > Fixes <https://issues.guix.gnu.org/55781> and <https://issues.guix.gnu.or= g/40885>. > > * gnu/packages/xfce.scm (thunar)[build-system]: Switch to glib-or-gtk-bui= ld-system. Well, it turns out not enough. The system must also have 'udisks-service-t= ype' enalbed and gvfs have to be installed for activation via dbus user services.
guix-patches@HIDDEN:bug#70508; Package guix-patches.
Full text available.
Received: (at submit) by debbugs.gnu.org; 22 Apr 2024 01:47:09 +0000
From debbugs-submit-bounces <at> debbugs.gnu.org Sun Apr 21 21:47:09 2024
Received: from localhost ([127.0.0.1]:45296 helo=debbugs.gnu.org)
by debbugs.gnu.org with esmtp (Exim 4.84_2)
(envelope-from <debbugs-submit-bounces <at> debbugs.gnu.org>)
id 1ryilv-0005LV-J8
for submit <at> debbugs.gnu.org; Sun, 21 Apr 2024 21:47:08 -0400
Received: from lists.gnu.org ([2001:470:142::17]:47992)
by debbugs.gnu.org with esmtp (Exim 4.84_2)
(envelope-from <iyzsong@HIDDEN>) id 1ryilq-0005Jf-9E
for submit <at> debbugs.gnu.org; Sun, 21 Apr 2024 21:47:06 -0400
Received: from eggs.gnu.org ([2001:470:142:3::10])
by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256)
(Exim 4.90_1) (envelope-from <iyzsong@HIDDEN>) id 1ryilV-000642-0W
for guix-patches@HIDDEN; Sun, 21 Apr 2024 21:46:41 -0400
Received: from mail.envs.net ([5.199.136.28])
by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256)
(Exim 4.90_1) (envelope-from <iyzsong@HIDDEN>) id 1ryilS-0007so-No
for guix-patches@HIDDEN; Sun, 21 Apr 2024 21:46:40 -0400
Received: from localhost (mail.envs.net [127.0.0.1])
by mail.envs.net (Postfix) with ESMTP id 2642F38A1BB4;
Mon, 22 Apr 2024 01:46:36 +0000 (UTC)
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=envs.net; s=modoboa;
t=1713750396; bh=sBpV9cSNrndN986Lfkhf0yD3HoYoeNwjuk27oMDEc9E=;
h=From:To:Cc:Subject:Date:From;
b=N62rcaqsI/zXLiMzVLXYYfxhj1LDku5ngUMdLIAOO3jVIs+0emN1lvEdi4vudQQRd
I6MvrO81yawqD0PZ6qwRKLUj/Y+hnlKaFPDFZ/0rF+ETlpClFiUgkNJKNr9yqbsH1c
mlm3q+7L4lC86i85XEVYbkv6C5lYpFbGzlCyrpdxMZ/Sf8i8B+66sr+QoSbnQKOGtV
vfNHgB/x87Fz58ODcY5Eiu73jTA2xhj8sG1JyGjG4hGRpfBXvC4blPtID8obRJYYRq
SLZB3G6BcFCU6MLsVfZoDtNas6fD1Pp0m2BO+we2pmpVps/e5lTCMTxCnsCQXN5G0k
UCsCDEfKYoIXwX7fkvQur05piVK5ARq5BbAZW+89yv0IMC1e6LIjxCU8g/o9Pyi4YJ
kDUSv5t/iig962JeNbD2pjoIsw9ih6iwA6aj4mkkF7LzrAbu724K5Xu5O8TuclDyLr
vsSgQpnjF83zYPAA2mGZIZiE7RPNTns/dWIsQcRACzBba/I4HdEmJ1gdLYY3cnhg5H
yIiDlRnEj1gaeGC6z4xNgcM/QRWXeAy58O9FuClWOkSccZD6a1pL8b6Oz5RSRDUn1N
OYO+eHJveOI0QvdcTuysZV3jCVqglwwALrJnlxv0pOKOPJ5iWs1oYVhD1w6y8/bW1/
qkf7MjZmjC7vesRriOJ81KtA=
X-Virus-Scanned: Debian amavisd-new at mail.envs.net
Received: from mail.envs.net ([127.0.0.1])
by localhost (mail.envs.net [127.0.0.1]) (amavisd-new, port 10026)
with ESMTP id rOy8i27BGh5g; Mon, 22 Apr 2024 01:46:31 +0000 (UTC)
Received: from localhost (unknown [36.170.58.193])
(using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)
key-exchange ECDHE (P-256) server-signature RSA-PSS (2048 bits) server-digest
SHA256) (No client certificate requested)
by mail.envs.net (Postfix) with ESMTPSA;
Mon, 22 Apr 2024 01:46:31 +0000 (UTC)
Received: from localhost.localdomain (localhost [127.0.0.1])
by localhost (OpenSMTPD) with ESMTP id 1b7935a6;
Mon, 22 Apr 2024 01:47:40 +0000 (UTC)
From: iyzsong@HIDDEN
To: guix-patches@HIDDEN
Subject: [PATCH] gnu: thunar: Use glib-or-gtk-build-system.
Date: Mon, 22 Apr 2024 09:47:36 +0800
Message-ID: <6e14dd7d2612569cef62640393bc4ebbb4196f70.1713750442.git.iyzsong@HIDDEN>
X-Mailer: git-send-email 2.41.0
MIME-Version: 1.0
X-Debbugs-Cc: Zhu Zihao <all_but_last@HIDDEN>, 宋文武 <iyzsong@HIDDEN>
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: 8bit
Received-SPF: pass client-ip=5.199.136.28; envelope-from=iyzsong@HIDDEN;
helo=mail.envs.net
X-Spam_score_int: -20
X-Spam_score: -2.1
X-Spam_bar: --
X-Spam_report: (-2.1 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1,
DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, SPF_HELO_NONE=0.001,
SPF_PASS=-0.001 autolearn=ham autolearn_force=no
X-Spam_action: no action
X-Spam-Score: 0.9 (/)
X-Debbugs-Envelope-To: submit
Cc: =?UTF-8?q?=E5=AE=8B=E6=96=87=E6=AD=A6?= <iyzsong@HIDDEN>
X-BeenThere: debbugs-submit <at> debbugs.gnu.org
X-Mailman-Version: 2.1.18
Precedence: list
List-Id: <debbugs-submit.debbugs.gnu.org>
List-Unsubscribe: <https://debbugs.gnu.org/cgi-bin/mailman/options/debbugs-submit>,
<mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=unsubscribe>
List-Archive: <https://debbugs.gnu.org/cgi-bin/mailman/private/debbugs-submit/>
List-Post: <mailto:debbugs-submit <at> debbugs.gnu.org>
List-Help: <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=help>
List-Subscribe: <https://debbugs.gnu.org/cgi-bin/mailman/listinfo/debbugs-submit>,
<mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=subscribe>
Errors-To: debbugs-submit-bounces <at> debbugs.gnu.org
Sender: "Debbugs-submit" <debbugs-submit-bounces <at> debbugs.gnu.org>
X-Spam-Score: -0.1 (/)
From: 宋文武 <iyzsong@HIDDEN>
This wraps 'thunar' with GIO_EXTRA_MODULES to enable support for "Trash" and
remote file systems via GVFS.
Fixes <https://issues.guix.gnu.org/55781> and <https://issues.guix.gnu.org/40885>.
* gnu/packages/xfce.scm (thunar)[build-system]: Switch to glib-or-gtk-build-system.
Change-Id: Ifa4bc931272380e7c98dea40edb683da523bbaea
---
gnu/packages/xfce.scm | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/gnu/packages/xfce.scm b/gnu/packages/xfce.scm
index f9d9a81169..825b175140 100644
--- a/gnu/packages/xfce.scm
+++ b/gnu/packages/xfce.scm
@@ -736,7 +736,7 @@ (define-public thunar
(sha256
(base32
"020xrwzdnk5b7cli8vmv3yn7sfq6pg7bz57m4p0xh0ln2cgqlc78"))))
- (build-system gnu-build-system)
+ (build-system glib-or-gtk-build-system)
(arguments
'(#:configure-flags '("--with-custom-thunarx-dirs-enabled")))
(native-inputs
base-commit: 9fa34ad616b94ad881b5ca48ef88bd84f877a0e9
--
2.41.0
iyzsong@HIDDEN:all_but_last@HIDDEN, iyzsong@HIDDEN, guix-patches@HIDDEN.
Full text available.all_but_last@HIDDEN, iyzsong@HIDDEN, guix-patches@HIDDEN:bug#70508; Package guix-patches.
Full text available.
GNU bug tracking system
Copyright (C) 1999 Darren O. Benham,
1997 nCipher Corporation Ltd,
1994-97 Ian Jackson.