Chong Yidong <cyd <at> gnu.org>
to control <at> debbugs.gnu.org.
Full text available.
Received: (at 8706) by debbugs.gnu.org; 15 May 2012 08:55:30 +0000
From debbugs-submit-bounces <at> debbugs.gnu.org Tue May 15 04:55:30 2012
Received: from localhost ([127.0.0.1]:55223 helo=debbugs.gnu.org)
by debbugs.gnu.org with esmtp (Exim 4.72)
(envelope-from <debbugs-submit-bounces <at> debbugs.gnu.org>)
id 1SUDXV-0002oD-4L
for submit <at> debbugs.gnu.org; Tue, 15 May 2012 04:55:30 -0400
Received: from z.lifelogs.com ([173.255.230.239]:38194)
by debbugs.gnu.org with esmtp (Exim 4.72)
(envelope-from <tzz <at> lifelogs.com>) id 1SUDX5-0002nf-1H
for 8706 <at> debbugs.gnu.org; Tue, 15 May 2012 04:55:27 -0400
Received: from heechee (c-76-28-40-19.hsd1.vt.comcast.net [76.28.40.19])
(using TLSv1 with cipher DHE-RSA-AES128-SHA (128/128 bits))
(No client certificate requested) (Authenticated sender: tzz)
by z.lifelogs.com (Postfix) with ESMTPSA id 2CF8562C9A;
Tue, 15 May 2012 08:54:59 +0000 (UTC)
From: Ted Zlatanov <tzz <at> lifelogs.com>
To: Lars Magne Ingebrigtsen <larsi <at> gnus.org>
Subject: Re: bug#8706: 24.0.50; [PATCH] Function to build a URL query-string
Organization: =?utf-8?B?0KLQtdC+0LTQvtGAINCX0LvQsNGC0LDQvdC+0LI=?= @ Cienfuegos
References: <m2aaehrzeu.fsf <at> gmail.com> <87d3j932n7.fsf <at> lifelogs.com>
<87zkmaopfs.fsf <at> lifelogs.com>
<91C69C7A-1980-4AF4-9B4B-4AFDB16D2C0B <at> simplegeo.com>
<87y61uldyj.fsf <at> lifelogs.com>
<70084BE3-710F-47B6-8949-B420F5BF47B4 <at> simplegeo.com>
<87d3ip1nau.fsf <at> lifelogs.com> <87tybxjhh7.fsf <at> lifelogs.com>
<87k4cp5i2z.fsf <at> lifelogs.com> <m38vgvvpwi.fsf <at> stories.gnus.org>
X-Face: bd.DQ~'29fIs`T_%O%C\g%6jW)yi[zuz6;
d4V0`@y-~$#3P_Ng{@m+e4o<4P'#(_GJQ%TT=
D}[Ep*b!\e,fBZ'j_+#"Ps?s2!4H2-Y"sx"
Date: Tue, 15 May 2012 04:54:58 -0400
In-Reply-To: <m38vgvvpwi.fsf <at> stories.gnus.org> (Lars Magne Ingebrigtsen's
message of "Sun, 13 May 2012 21:31:41 +0200")
Message-ID: <871umlg6xp.fsf <at> lifelogs.com>
User-Agent: Gnus/5.130004 (Ma Gnus v0.4) Emacs/24.1.50 (gnu/linux)
MIME-Version: 1.0
Content-Type: text/plain
X-Spam-Score: -1.9 (-)
X-Debbugs-Envelope-To: 8706
Cc: 8706 <at> debbugs.gnu.org
X-BeenThere: debbugs-submit <at> debbugs.gnu.org
X-Mailman-Version: 2.1.13
Precedence: list
List-Id: <debbugs-submit.debbugs.gnu.org>
List-Unsubscribe: <http://debbugs.gnu.org/cgi-bin/mailman/options/debbugs-submit>,
<mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=unsubscribe>
List-Archive: <http://debbugs.gnu.org/cgi-bin/mailman/private/debbugs-submit>
List-Post: <mailto:debbugs-submit <at> debbugs.gnu.org>
List-Help: <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=help>
List-Subscribe: <http://debbugs.gnu.org/cgi-bin/mailman/listinfo/debbugs-submit>,
<mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=subscribe>
Sender: debbugs-submit-bounces <at> debbugs.gnu.org
Errors-To: debbugs-submit-bounces <at> debbugs.gnu.org
X-Spam-Score: -1.9 (-)
On Sun, 13 May 2012 21:31:41 +0200 Lars Magne Ingebrigtsen <larsi <at> gnus.org> wrote:
LMI> Ted Zlatanov <tzz <at> lifelogs.com> writes:
>> Ian, I'd like to commit this. I think it's pretty close to your
>> original code so you should be the author, which is why I'm asking for
>> your feedback (I can split the commits if you prefer). I see one commit
>> with your name in ChangeLog.14:
LMI> Ted, the paperwork is OK, so please go ahead and apply the patch. It's
LMI> a useful function.
OK; done. Ian is listed as the author of the change.
Ted
bug-gnu-emacs <at> gnu.org:bug#8706; Package emacs.
Full text available.Received: (at 8706) by debbugs.gnu.org; 13 May 2012 19:32:09 +0000 From debbugs-submit-bounces <at> debbugs.gnu.org Sun May 13 15:32:09 2012 Received: from localhost ([127.0.0.1]:51765 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.72) (envelope-from <debbugs-submit-bounces <at> debbugs.gnu.org>) id 1STeWW-000666-T0 for submit <at> debbugs.gnu.org; Sun, 13 May 2012 15:32:09 -0400 Received: from smtp.getmail.no ([84.208.15.66]:38949) by debbugs.gnu.org with esmtp (Exim 4.72) (envelope-from <larsi <at> gnus.org>) id 1STeWU-00065z-VX for 8706 <at> debbugs.gnu.org; Sun, 13 May 2012 15:32:08 -0400 MIME-version: 1.0 Content-transfer-encoding: 7BIT Content-type: text/plain Received: from get-mta-scan02.get.basefarm.net ([10.5.16.4]) by get-mta-out03.get.basefarm.net (Sun Java(tm) System Messaging Server 7.0-0.04 64bit (built Jun 20 2008)) with ESMTP id <0M3Z00NQI7L03EA0 <at> get-mta-out03.get.basefarm.net> for 8706 <at> debbugs.gnu.org; Sun, 13 May 2012 21:31:48 +0200 (MEST) Received: from get-mta-scan02.get.basefarm.net (localhost.localdomain [127.0.0.1]) by localhost (Email Security Appliance) with SMTP id 9DC911EA7ED1_FB00C24B for <8706 <at> debbugs.gnu.org>; Sun, 13 May 2012 19:31:48 +0000 (GMT) Received: from smtp.getmail.no (unknown [10.5.16.4]) by get-mta-scan02.get.basefarm.net (Sophos Email Appliance) with ESMTP id 85EE21EA7EEB_FB00C24F for <8706 <at> debbugs.gnu.org>; Sun, 13 May 2012 19:31:48 +0000 (GMT) Received: from stories.gnus.org ([84.215.51.58]) by get-mta-in03.get.basefarm.net (Sun Java(tm) System Messaging Server 7.0-0.04 64bit (built Jun 20 2008)) with ESMTP id <0M3Z002FX7KZWL00 <at> get-mta-in03.get.basefarm.net> for 8706 <at> debbugs.gnu.org; Sun, 13 May 2012 21:31:48 +0200 (MEST) From: Lars Magne Ingebrigtsen <larsi <at> gnus.org> To: Ian Eure <ian <at> simplegeo.com> Subject: Re: bug#8706: 24.0.50; [PATCH] Function to build a URL query-string References: <m2aaehrzeu.fsf <at> gmail.com> <87d3j932n7.fsf <at> lifelogs.com> <87zkmaopfs.fsf <at> lifelogs.com> <91C69C7A-1980-4AF4-9B4B-4AFDB16D2C0B <at> simplegeo.com> <87y61uldyj.fsf <at> lifelogs.com> <70084BE3-710F-47B6-8949-B420F5BF47B4 <at> simplegeo.com> <87d3ip1nau.fsf <at> lifelogs.com> <87tybxjhh7.fsf <at> lifelogs.com> <87k4cp5i2z.fsf <at> lifelogs.com> X-Now-Playing: Pet Shop Boys's _Format (1)_: "Confidential (demo for Tina Turner)" Date: Sun, 13 May 2012 21:31:41 +0200 In-reply-to: <87k4cp5i2z.fsf <at> lifelogs.com> Message-id: <m38vgvvpwi.fsf <at> stories.gnus.org> User-Agent: Gnus/5.130006 (Ma Gnus v0.6) Emacs/24.1.50 (gnu/linux) X-Spam-Score: -1.9 (-) X-Debbugs-Envelope-To: 8706 Cc: Ted Zlatanov <tzz <at> lifelogs.com>, 8706 <at> debbugs.gnu.org X-BeenThere: debbugs-submit <at> debbugs.gnu.org X-Mailman-Version: 2.1.13 Precedence: list List-Id: <debbugs-submit.debbugs.gnu.org> List-Unsubscribe: <http://debbugs.gnu.org/cgi-bin/mailman/options/debbugs-submit>, <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=unsubscribe> List-Archive: <http://debbugs.gnu.org/cgi-bin/mailman/private/debbugs-submit> List-Post: <mailto:debbugs-submit <at> debbugs.gnu.org> List-Help: <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=help> List-Subscribe: <http://debbugs.gnu.org/cgi-bin/mailman/listinfo/debbugs-submit>, <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=subscribe> Sender: debbugs-submit-bounces <at> debbugs.gnu.org Errors-To: debbugs-submit-bounces <at> debbugs.gnu.org X-Spam-Score: -1.9 (-) Ted Zlatanov <tzz <at> lifelogs.com> writes: > Ian, I'd like to commit this. I think it's pretty close to your > original code so you should be the author, which is why I'm asking for > your feedback (I can split the commits if you prefer). I see one commit > with your name in ChangeLog.14: Ted, the paperwork is OK, so please go ahead and apply the patch. It's a useful function. -- (domestic pets only, the antidote for overdose, milk.) bloggy blog http://lars.ingebrigtsen.no/
bug-gnu-emacs <at> gnu.org:bug#8706; Package emacs.
Full text available.
Received: (at 8706) by debbugs.gnu.org; 18 Apr 2012 22:37:25 +0000
From debbugs-submit-bounces <at> debbugs.gnu.org Wed Apr 18 18:37:25 2012
Received: from localhost ([127.0.0.1]:40512 helo=debbugs.gnu.org)
by debbugs.gnu.org with esmtp (Exim 4.72)
(envelope-from <debbugs-submit-bounces <at> debbugs.gnu.org>)
id 1SKdV6-00017a-Qv
for submit <at> debbugs.gnu.org; Wed, 18 Apr 2012 18:37:25 -0400
Received: from fencepost.gnu.org ([208.118.235.10]:60611 ident=Debian-exim)
by debbugs.gnu.org with esmtp (Exim 4.72)
(envelope-from <rgm <at> gnu.org>) id 1SKdV3-000172-TY
for 8706 <at> debbugs.gnu.org; Wed, 18 Apr 2012 18:37:22 -0400
Received: from rgm by fencepost.gnu.org with local (Exim 4.71)
(envelope-from <rgm <at> gnu.org>)
id 1SKdUj-0004VV-Ku; Wed, 18 Apr 2012 18:37:01 -0400
From: Glenn Morris <rgm <at> gnu.org>
To: Ted Zlatanov <tzz <at> lifelogs.com>
Subject: Re: bug#8706: 24.0.50; [PATCH] Function to build a URL query-string
References: <m2aaehrzeu.fsf <at> gmail.com> <87d3j932n7.fsf <at> lifelogs.com>
<87zkmaopfs.fsf <at> lifelogs.com>
<91C69C7A-1980-4AF4-9B4B-4AFDB16D2C0B <at> simplegeo.com>
<87y61uldyj.fsf <at> lifelogs.com>
<70084BE3-710F-47B6-8949-B420F5BF47B4 <at> simplegeo.com>
<87d3ip1nau.fsf <at> lifelogs.com> <87tybxjhh7.fsf <at> lifelogs.com>
<87k4cp5i2z.fsf <at> lifelogs.com>
<43BFB40C-4F1B-457E-BC78-F33A22C91CCE <at> simplegeo.com>
<a7vcw8o0em.fsf <at> fencepost.gnu.org> <8739jcuzbc.fsf <at> lifelogs.com>
<46027C83-0C05-4B9D-8183-04A7F8747F4B <at> simplegeo.com>
<m38vi0oigw.fsf <at> stories.gnus.org> <m3zkagn3qb.fsf <at> stories.gnus.org>
<87hawkblkl.fsf <at> lifelogs.com> <1qty0kv6en.fsf <at> fencepost.gnu.org>
X-Spook: Sears Tower FIPS140 FBI S Box counter intelligence DRM
X-Ran: -B#aDY4hfrMOKT{.ySW8p9A[V*d!\(}aeuL:!AUIK0-AcB^[;a`%O#B1~}Ptiv=k%?JEh}
X-Hue: white
X-Debbugs-No-Ack: yes
X-Attribution: GM
Date: Wed, 18 Apr 2012 18:37:01 -0400
In-Reply-To: <1qty0kv6en.fsf <at> fencepost.gnu.org> (Glenn Morris's message of
"Sun, 15 Apr 2012 20:58:56 -0400")
Message-ID: <434nsgfz02.fsf <at> fencepost.gnu.org>
User-Agent: Gnus (www.gnus.org), GNU Emacs (www.gnu.org/software/emacs/)
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
X-Spam-Score: -6.9 (------)
X-Debbugs-Envelope-To: 8706
Cc: Lars Magne Ingebrigtsen <larsi <at> gnus.org>, Ian Eure <ian <at> simplegeo.com>,
8706 <at> debbugs.gnu.org
X-BeenThere: debbugs-submit <at> debbugs.gnu.org
X-Mailman-Version: 2.1.13
Precedence: list
List-Id: <debbugs-submit.debbugs.gnu.org>
List-Unsubscribe: <http://debbugs.gnu.org/cgi-bin/mailman/options/debbugs-submit>,
<mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=unsubscribe>
List-Archive: <http://debbugs.gnu.org/cgi-bin/mailman/private/debbugs-submit>
List-Post: <mailto:debbugs-submit <at> debbugs.gnu.org>
List-Help: <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=help>
List-Subscribe: <http://debbugs.gnu.org/cgi-bin/mailman/listinfo/debbugs-submit>,
<mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=subscribe>
Sender: debbugs-submit-bounces <at> debbugs.gnu.org
Errors-To: debbugs-submit-bounces <at> debbugs.gnu.org
X-Spam-Score: -6.9 (------)
Glenn Morris wrote:
> I think the assignment may have been completed. Let me check with
> assign <at> gnu.
Yes, it's done. Fron that point of view, it is ok to install whatever it
is.
bug-gnu-emacs <at> gnu.org:bug#8706; Package emacs.
Full text available.
Received: (at 8706) by debbugs.gnu.org; 16 Apr 2012 01:00:44 +0000
From debbugs-submit-bounces <at> debbugs.gnu.org Sun Apr 15 21:00:44 2012
Received: from localhost ([127.0.0.1]:60106 helo=debbugs.gnu.org)
by debbugs.gnu.org with esmtp (Exim 4.72)
(envelope-from <debbugs-submit-bounces <at> debbugs.gnu.org>)
id 1SJaJ5-0000ii-Pn
for submit <at> debbugs.gnu.org; Sun, 15 Apr 2012 21:00:44 -0400
Received: from fencepost.gnu.org ([208.118.235.10]:36680)
by debbugs.gnu.org with esmtp (Exim 4.72)
(envelope-from <rgm <at> gnu.org>) id 1SJaIy-0000iV-Nx
for 8706 <at> debbugs.gnu.org; Sun, 15 Apr 2012 21:00:37 -0400
Received: from rgm by fencepost.gnu.org with local (Exim 4.71)
(envelope-from <rgm <at> gnu.org>)
id 1SJaHQ-0001jT-BI; Sun, 15 Apr 2012 20:58:56 -0400
From: Glenn Morris <rgm <at> gnu.org>
To: Ted Zlatanov <tzz <at> lifelogs.com>
Subject: Re: bug#8706: 24.0.50; [PATCH] Function to build a URL query-string
References: <m2aaehrzeu.fsf <at> gmail.com> <87d3j932n7.fsf <at> lifelogs.com>
<87zkmaopfs.fsf <at> lifelogs.com>
<91C69C7A-1980-4AF4-9B4B-4AFDB16D2C0B <at> simplegeo.com>
<87y61uldyj.fsf <at> lifelogs.com>
<70084BE3-710F-47B6-8949-B420F5BF47B4 <at> simplegeo.com>
<87d3ip1nau.fsf <at> lifelogs.com> <87tybxjhh7.fsf <at> lifelogs.com>
<87k4cp5i2z.fsf <at> lifelogs.com>
<43BFB40C-4F1B-457E-BC78-F33A22C91CCE <at> simplegeo.com>
<a7vcw8o0em.fsf <at> fencepost.gnu.org> <8739jcuzbc.fsf <at> lifelogs.com>
<46027C83-0C05-4B9D-8183-04A7F8747F4B <at> simplegeo.com>
<m38vi0oigw.fsf <at> stories.gnus.org> <m3zkagn3qb.fsf <at> stories.gnus.org>
<87hawkblkl.fsf <at> lifelogs.com>
X-Spook: Bruxelles Perl-RSA FBI argus industrial espionage
X-Ran: VbmNvW8k1MPRu;$(F%?sE#U<w$?Q~Wi]JE6~c9o!>1YqN\*I{>'l?%Zv)Ui<pQ3OgB+Y5X
X-Hue: magenta
X-Debbugs-No-Ack: yes
X-Attribution: GM
Date: Sun, 15 Apr 2012 20:58:56 -0400
In-Reply-To: <87hawkblkl.fsf <at> lifelogs.com> (Ted Zlatanov's message of "Sun, 15
Apr 2012 19:51:38 -0400")
Message-ID: <1qty0kv6en.fsf <at> fencepost.gnu.org>
User-Agent: Gnus (www.gnus.org), GNU Emacs (www.gnu.org/software/emacs/)
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
X-Spam-Score: -6.9 (------)
X-Debbugs-Envelope-To: 8706
Cc: Lars Magne Ingebrigtsen <larsi <at> gnus.org>, Ian Eure <ian <at> simplegeo.com>,
8706 <at> debbugs.gnu.org
X-BeenThere: debbugs-submit <at> debbugs.gnu.org
X-Mailman-Version: 2.1.13
Precedence: list
List-Id: <debbugs-submit.debbugs.gnu.org>
List-Unsubscribe: <http://debbugs.gnu.org/cgi-bin/mailman/options/debbugs-submit>,
<mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=unsubscribe>
List-Archive: <http://debbugs.gnu.org/cgi-bin/mailman/private/debbugs-submit>
List-Post: <mailto:debbugs-submit <at> debbugs.gnu.org>
List-Help: <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=help>
List-Subscribe: <http://debbugs.gnu.org/cgi-bin/mailman/listinfo/debbugs-submit>,
<mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=subscribe>
Sender: debbugs-submit-bounces <at> debbugs.gnu.org
Errors-To: debbugs-submit-bounces <at> debbugs.gnu.org
X-Spam-Score: -6.9 (------)
Ted Zlatanov wrote:
> LMI> Lars Magne Ingebrigtsen <larsi <at> gnus.org> writes:
>>> Was there any progress on the assignment paperwork status?
>
> LMI> Mail to Ian bounced...
I think the assignment may have been completed. Let me check with
assign <at> gnu.
bug-gnu-emacs <at> gnu.org:bug#8706; Package emacs.
Full text available.
Received: (at 8706) by debbugs.gnu.org; 15 Apr 2012 23:53:22 +0000
From debbugs-submit-bounces <at> debbugs.gnu.org Sun Apr 15 19:53:22 2012
Received: from localhost ([127.0.0.1]:60084 helo=debbugs.gnu.org)
by debbugs.gnu.org with esmtp (Exim 4.72)
(envelope-from <debbugs-submit-bounces <at> debbugs.gnu.org>)
id 1SJZFu-0007f5-NI
for submit <at> debbugs.gnu.org; Sun, 15 Apr 2012 19:53:22 -0400
Received: from z.lifelogs.com ([173.255.230.239]:49716)
by debbugs.gnu.org with esmtp (Exim 4.72)
(envelope-from <tzz <at> lifelogs.com>) id 1SJZFo-0007et-KN
for 8706 <at> debbugs.gnu.org; Sun, 15 Apr 2012 19:53:17 -0400
Received: from heechee (c-76-28-40-19.hsd1.vt.comcast.net [76.28.40.19])
(using TLSv1 with cipher DHE-RSA-AES128-SHA (128/128 bits))
(No client certificate requested) (Authenticated sender: tzz)
by z.lifelogs.com (Postfix) with ESMTPSA id 7446D621BE;
Sun, 15 Apr 2012 23:51:39 +0000 (UTC)
From: Ted Zlatanov <tzz <at> lifelogs.com>
To: Lars Magne Ingebrigtsen <larsi <at> gnus.org>
Subject: Re: bug#8706: 24.0.50; [PATCH] Function to build a URL query-string
Organization: =?utf-8?B?0KLQtdC+0LTQvtGAINCX0LvQsNGC0LDQvdC+0LI=?= @ Cienfuegos
References: <m2aaehrzeu.fsf <at> gmail.com> <87d3j932n7.fsf <at> lifelogs.com>
<87zkmaopfs.fsf <at> lifelogs.com>
<91C69C7A-1980-4AF4-9B4B-4AFDB16D2C0B <at> simplegeo.com>
<87y61uldyj.fsf <at> lifelogs.com>
<70084BE3-710F-47B6-8949-B420F5BF47B4 <at> simplegeo.com>
<87d3ip1nau.fsf <at> lifelogs.com> <87tybxjhh7.fsf <at> lifelogs.com>
<87k4cp5i2z.fsf <at> lifelogs.com>
<43BFB40C-4F1B-457E-BC78-F33A22C91CCE <at> simplegeo.com>
<a7vcw8o0em.fsf <at> fencepost.gnu.org> <8739jcuzbc.fsf <at> lifelogs.com>
<46027C83-0C05-4B9D-8183-04A7F8747F4B <at> simplegeo.com>
<m38vi0oigw.fsf <at> stories.gnus.org> <m3zkagn3qb.fsf <at> stories.gnus.org>
X-Face: bd.DQ~'29fIs`T_%O%C\g%6jW)yi[zuz6;
d4V0`@y-~$#3P_Ng{@m+e4o<4P'#(_GJQ%TT=
D}[Ep*b!\e,fBZ'j_+#"Ps?s2!4H2-Y"sx"
Date: Sun, 15 Apr 2012 19:51:38 -0400
In-Reply-To: <m3zkagn3qb.fsf <at> stories.gnus.org> (Lars Magne Ingebrigtsen's
message of "Thu, 12 Apr 2012 21:34:52 +0200")
Message-ID: <87hawkblkl.fsf <at> lifelogs.com>
User-Agent: Gnus/5.130004 (Ma Gnus v0.4) Emacs/24.1.50 (gnu/linux)
MIME-Version: 1.0
Content-Type: text/plain
X-Spam-Score: -1.9 (-)
X-Debbugs-Envelope-To: 8706
Cc: Glenn Morris <rgm <at> gnu.org>, Ian Eure <ian <at> simplegeo.com>,
8706 <at> debbugs.gnu.org
X-BeenThere: debbugs-submit <at> debbugs.gnu.org
X-Mailman-Version: 2.1.13
Precedence: list
List-Id: <debbugs-submit.debbugs.gnu.org>
List-Unsubscribe: <http://debbugs.gnu.org/cgi-bin/mailman/options/debbugs-submit>,
<mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=unsubscribe>
List-Archive: <http://debbugs.gnu.org/cgi-bin/mailman/private/debbugs-submit>
List-Post: <mailto:debbugs-submit <at> debbugs.gnu.org>
List-Help: <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=help>
List-Subscribe: <http://debbugs.gnu.org/cgi-bin/mailman/listinfo/debbugs-submit>,
<mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=subscribe>
Sender: debbugs-submit-bounces <at> debbugs.gnu.org
Errors-To: debbugs-submit-bounces <at> debbugs.gnu.org
X-Spam-Score: -1.9 (-)
On Thu, 12 Apr 2012 21:34:52 +0200 Lars Magne Ingebrigtsen <larsi <at> gnus.org> wrote:
LMI> Lars Magne Ingebrigtsen <larsi <at> gnus.org> writes:
>> Was there any progress on the assignment paperwork status?
LMI> Mail to Ian bounced...
LMI> ian <at> simplegeo.com
LMI> SMTP error from remote mail server after RCPT TO:<ian <at> simplegeo.com>:
LMI> host ASPMX.L.GOOGLE.com [209.85.173.26]: 550 5.2.1 The email account that you tried to reach is disabled. sq7si3330628lab.10
Considering the change is fairly small and simple I could just rewrite it.
Ted
bug-gnu-emacs <at> gnu.org:bug#8706; Package emacs.
Full text available.
Received: (at 8706) by debbugs.gnu.org; 12 Apr 2012 19:36:36 +0000
From debbugs-submit-bounces <at> debbugs.gnu.org Thu Apr 12 15:36:36 2012
Received: from localhost ([127.0.0.1]:54807 helo=debbugs.gnu.org)
by debbugs.gnu.org with esmtp (Exim 4.72)
(envelope-from <debbugs-submit-bounces <at> debbugs.gnu.org>)
id 1SIPob-0001n7-UV
for submit <at> debbugs.gnu.org; Thu, 12 Apr 2012 15:36:24 -0400
Received: from hermes.netfonds.no ([80.91.224.195]:34172)
by debbugs.gnu.org with esmtp (Exim 4.72)
(envelope-from <larsi <at> gnus.org>) id 1SIPoV-0001mu-4J
for 8706 <at> debbugs.gnu.org; Thu, 12 Apr 2012 15:36:20 -0400
Received: from cm-84.215.51.58.getinternet.no ([84.215.51.58]
helo=stories.gnus.org)
by hermes.netfonds.no with esmtpsa (TLS1.0:DHE_RSA_AES_128_CBC_SHA1:16)
(Exim 4.72) (envelope-from <larsi <at> gnus.org>)
id 1SIPnB-00089c-3H; Thu, 12 Apr 2012 21:34:53 +0200
From: Lars Magne Ingebrigtsen <larsi <at> gnus.org>
To: Ian Eure <ian <at> simplegeo.com>
Subject: Re: bug#8706: 24.0.50; [PATCH] Function to build a URL query-string
References: <m2aaehrzeu.fsf <at> gmail.com> <87d3j932n7.fsf <at> lifelogs.com>
<87zkmaopfs.fsf <at> lifelogs.com>
<91C69C7A-1980-4AF4-9B4B-4AFDB16D2C0B <at> simplegeo.com>
<87y61uldyj.fsf <at> lifelogs.com>
<70084BE3-710F-47B6-8949-B420F5BF47B4 <at> simplegeo.com>
<87d3ip1nau.fsf <at> lifelogs.com> <87tybxjhh7.fsf <at> lifelogs.com>
<87k4cp5i2z.fsf <at> lifelogs.com>
<43BFB40C-4F1B-457E-BC78-F33A22C91CCE <at> simplegeo.com>
<a7vcw8o0em.fsf <at> fencepost.gnu.org> <8739jcuzbc.fsf <at> lifelogs.com>
<46027C83-0C05-4B9D-8183-04A7F8747F4B <at> simplegeo.com>
<m38vi0oigw.fsf <at> stories.gnus.org>
X-Now-Playing: His Name Is Alive's _ECLIPX_: "The Pollinators"
Date: Thu, 12 Apr 2012 21:34:52 +0200
In-Reply-To: <m38vi0oigw.fsf <at> stories.gnus.org> (Lars Magne Ingebrigtsen's
message of "Thu, 12 Apr 2012 21:31:11 +0200")
Message-ID: <m3zkagn3qb.fsf <at> stories.gnus.org>
User-Agent: Gnus/5.130004 (Ma Gnus v0.4) Emacs/24.1.50 (gnu/linux)
MIME-Version: 1.0
Content-Type: text/plain
X-MailScanner-ID: 1SIPnB-00089c-3H
X-Netfonds-MailScanner: Found to be clean
X-Netfonds-MailScanner-From: larsi <at> gnus.org
MailScanner-NULL-Check: 1334864093.219 <at> Hb3eL8oX3zSzHrOmvanhkg
X-Spam-Status: No
X-Spam-Score: -1.9 (-)
X-Debbugs-Envelope-To: 8706
Cc: Glenn Morris <rgm <at> gnu.org>, Ted Zlatanov <tzz <at> lifelogs.com>,
8706 <at> debbugs.gnu.org
X-BeenThere: debbugs-submit <at> debbugs.gnu.org
X-Mailman-Version: 2.1.13
Precedence: list
List-Id: <debbugs-submit.debbugs.gnu.org>
List-Unsubscribe: <http://debbugs.gnu.org/cgi-bin/mailman/options/debbugs-submit>,
<mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=unsubscribe>
List-Archive: <http://debbugs.gnu.org/cgi-bin/mailman/private/debbugs-submit>
List-Post: <mailto:debbugs-submit <at> debbugs.gnu.org>
List-Help: <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=help>
List-Subscribe: <http://debbugs.gnu.org/cgi-bin/mailman/listinfo/debbugs-submit>,
<mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=subscribe>
Sender: debbugs-submit-bounces <at> debbugs.gnu.org
Errors-To: debbugs-submit-bounces <at> debbugs.gnu.org
X-Spam-Score: -1.9 (-)
Lars Magne Ingebrigtsen <larsi <at> gnus.org> writes:
> Was there any progress on the assignment paperwork status?
Mail to Ian bounced...
ian <at> simplegeo.com
SMTP error from remote mail server after RCPT TO:<ian <at> simplegeo.com>:
host ASPMX.L.GOOGLE.com [209.85.173.26]: 550 5.2.1 The email account that you tried to reach is disabled. sq7si3330628lab.10
--
(domestic pets only, the antidote for overdose, milk.)
bloggy blog http://lars.ingebrigtsen.no/
bug-gnu-emacs <at> gnu.org:bug#8706; Package emacs.
Full text available.Received: (at 8706) by debbugs.gnu.org; 12 Apr 2012 19:32:37 +0000 From debbugs-submit-bounces <at> debbugs.gnu.org Thu Apr 12 15:32:37 2012 Received: from localhost ([127.0.0.1]:54784 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.72) (envelope-from <debbugs-submit-bounces <at> debbugs.gnu.org>) id 1SIPky-0001h1-Q5 for submit <at> debbugs.gnu.org; Thu, 12 Apr 2012 15:32:37 -0400 Received: from hermes.netfonds.no ([80.91.224.195]:51158) by debbugs.gnu.org with esmtp (Exim 4.72) (envelope-from <larsi <at> gnus.org>) id 1SIPku-0001gq-JL for 8706 <at> debbugs.gnu.org; Thu, 12 Apr 2012 15:32:35 -0400 Received: from cm-84.215.51.58.getinternet.no ([84.215.51.58] helo=stories.gnus.org) by hermes.netfonds.no with esmtpsa (TLS1.0:DHE_RSA_AES_128_CBC_SHA1:16) (Exim 4.72) (envelope-from <larsi <at> gnus.org>) id 1SIPjc-00086U-3U; Thu, 12 Apr 2012 21:31:12 +0200 From: Lars Magne Ingebrigtsen <larsi <at> gnus.org> To: Ian Eure <ian <at> simplegeo.com> Subject: Re: bug#8706: 24.0.50; [PATCH] Function to build a URL query-string References: <m2aaehrzeu.fsf <at> gmail.com> <87d3j932n7.fsf <at> lifelogs.com> <87zkmaopfs.fsf <at> lifelogs.com> <91C69C7A-1980-4AF4-9B4B-4AFDB16D2C0B <at> simplegeo.com> <87y61uldyj.fsf <at> lifelogs.com> <70084BE3-710F-47B6-8949-B420F5BF47B4 <at> simplegeo.com> <87d3ip1nau.fsf <at> lifelogs.com> <87tybxjhh7.fsf <at> lifelogs.com> <87k4cp5i2z.fsf <at> lifelogs.com> <43BFB40C-4F1B-457E-BC78-F33A22C91CCE <at> simplegeo.com> <a7vcw8o0em.fsf <at> fencepost.gnu.org> <8739jcuzbc.fsf <at> lifelogs.com> <46027C83-0C05-4B9D-8183-04A7F8747F4B <at> simplegeo.com> X-Now-Playing: His Name Is Alive's _ECLIPX_: "Can't Seem To Make You Mine" Date: Thu, 12 Apr 2012 21:31:11 +0200 In-Reply-To: <46027C83-0C05-4B9D-8183-04A7F8747F4B <at> simplegeo.com> (Ian Eure's message of "Tue, 14 Jun 2011 09:57:00 -0700") Message-ID: <m38vi0oigw.fsf <at> stories.gnus.org> User-Agent: Gnus/5.130004 (Ma Gnus v0.4) Emacs/24.1.50 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain X-MailScanner-ID: 1SIPjc-00086U-3U X-Netfonds-MailScanner: Found to be clean X-Netfonds-MailScanner-From: larsi <at> gnus.org MailScanner-NULL-Check: 1334863872.31468 <at> NFaif6jyYXKFw+x2c9v0HA X-Spam-Status: No X-Spam-Score: -1.9 (-) X-Debbugs-Envelope-To: 8706 Cc: Glenn Morris <rgm <at> gnu.org>, Ted Zlatanov <tzz <at> lifelogs.com>, 8706 <at> debbugs.gnu.org X-BeenThere: debbugs-submit <at> debbugs.gnu.org X-Mailman-Version: 2.1.13 Precedence: list List-Id: <debbugs-submit.debbugs.gnu.org> List-Unsubscribe: <http://debbugs.gnu.org/cgi-bin/mailman/options/debbugs-submit>, <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=unsubscribe> List-Archive: <http://debbugs.gnu.org/cgi-bin/mailman/private/debbugs-submit> List-Post: <mailto:debbugs-submit <at> debbugs.gnu.org> List-Help: <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=help> List-Subscribe: <http://debbugs.gnu.org/cgi-bin/mailman/listinfo/debbugs-submit>, <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=subscribe> Sender: debbugs-submit-bounces <at> debbugs.gnu.org Errors-To: debbugs-submit-bounces <at> debbugs.gnu.org X-Spam-Score: -1.9 (-) Ian Eure <ian <at> simplegeo.com> writes: >> Ian, please let me know when this is done and I'll commit the patch. I >> hope we can get it done before the Emacs pretest. >> > I've emailed assign <at> gnu and hope to have it sorted out soon. Was there any progress on the assignment paperwork status? -- (domestic pets only, the antidote for overdose, milk.) bloggy blog http://lars.ingebrigtsen.no/
bug-gnu-emacs <at> gnu.org:bug#8706; Package emacs.
Full text available.Received: (at 8706) by debbugs.gnu.org; 14 Jun 2011 16:57:11 +0000 From debbugs-submit-bounces <at> debbugs.gnu.org Tue Jun 14 12:57:11 2011 Received: from localhost ([127.0.0.1] helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.69) (envelope-from <debbugs-submit-bounces <at> debbugs.gnu.org>) id 1QWWvO-00005m-SM for submit <at> debbugs.gnu.org; Tue, 14 Jun 2011 12:57:11 -0400 Received: from mail-pz0-f44.google.com ([209.85.210.44]) by debbugs.gnu.org with esmtp (Exim 4.69) (envelope-from <ian <at> simplegeo.com>) id 1QWWvN-00005V-NJ for 8706 <at> debbugs.gnu.org; Tue, 14 Jun 2011 12:57:10 -0400 Received: by pzk5 with SMTP id 5so2725728pzk.3 for <8706 <at> debbugs.gnu.org>; Tue, 14 Jun 2011 09:57:03 -0700 (PDT) Received: by 10.142.142.19 with SMTP id p19mr1207676wfd.374.1308070623100; Tue, 14 Jun 2011 09:57:03 -0700 (PDT) Received: from [10.128.0.81] (173-164-219-53-SFBA.hfc.comcastbusiness.net [173.164.219.53]) by mx.google.com with ESMTPS id y2sm5696650pbg.56.2011.06.14.09.57.01 (version=TLSv1/SSLv3 cipher=OTHER); Tue, 14 Jun 2011 09:57:02 -0700 (PDT) Subject: Re: bug#8706: 24.0.50; [PATCH] Function to build a URL query-string Mime-Version: 1.0 (Apple Message framework v1084) Content-Type: text/plain; charset=us-ascii From: Ian Eure <ian <at> simplegeo.com> In-Reply-To: <8739jcuzbc.fsf <at> lifelogs.com> Date: Tue, 14 Jun 2011 09:57:00 -0700 Content-Transfer-Encoding: quoted-printable Message-Id: <46027C83-0C05-4B9D-8183-04A7F8747F4B <at> simplegeo.com> References: <m2aaehrzeu.fsf <at> gmail.com> <87d3j932n7.fsf <at> lifelogs.com> <87zkmaopfs.fsf <at> lifelogs.com> <91C69C7A-1980-4AF4-9B4B-4AFDB16D2C0B <at> simplegeo.com> <87y61uldyj.fsf <at> lifelogs.com> <70084BE3-710F-47B6-8949-B420F5BF47B4 <at> simplegeo.com> <87d3ip1nau.fsf <at> lifelogs.com> <87tybxjhh7.fsf <at> lifelogs.com> <87k4cp5i2z.fsf <at> lifelogs.com> <43BFB40C-4F1B-457E-BC78-F33A22C91CCE <at> simplegeo.com> <a7vcw8o0em.fsf <at> fencepost.gnu.org> <8739jcuzbc.fsf <at> lifelogs.com> To: Ted Zlatanov <tzz <at> lifelogs.com> X-Mailer: Apple Mail (2.1084) X-Spam-Score: -3.6 (---) X-Debbugs-Envelope-To: 8706 Cc: Glenn Morris <rgm <at> gnu.org>, 8706 <at> debbugs.gnu.org X-BeenThere: debbugs-submit <at> debbugs.gnu.org X-Mailman-Version: 2.1.11 Precedence: list List-Id: <debbugs-submit.debbugs.gnu.org> List-Unsubscribe: <http://debbugs.gnu.org/cgi-bin/mailman/options/debbugs-submit>, <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=unsubscribe> List-Archive: <http://debbugs.gnu.org/pipermail/debbugs-submit> List-Post: <mailto:debbugs-submit <at> debbugs.gnu.org> List-Help: <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=help> List-Subscribe: <http://debbugs.gnu.org/cgi-bin/mailman/listinfo/debbugs-submit>, <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=subscribe> Sender: debbugs-submit-bounces <at> debbugs.gnu.org Errors-To: debbugs-submit-bounces <at> debbugs.gnu.org X-Spam-Score: -3.6 (---) On Jun 14, 2011, at 9:56 AM, Ted Zlatanov wrote: > On Tue, 14 Jun 2011 12:14:41 -0400 Glenn Morris <rgm <at> gnu.org> wrote:=20= >=20 > GM> Ian Eure wrote: >>> Yes, I filed them for that change. I've subsequently switched jobs, >>> but there's no chance there is an IP claim against it. >=20 > GM> I did not see an assignment in the file that records these things, = so I > GM> asked assign <at> gnu about it. They said that the assignment process = was not > GM> completed. Please contact assign <at> gnu directly to sort this out. >=20 > Ian, please let me know when this is done and I'll commit the patch. = I > hope we can get it done before the Emacs pretest. >=20 I've emailed assign <at> gnu and hope to have it sorted out soon.
owner <at> debbugs.gnu.org, bug-gnu-emacs <at> gnu.org:bug#8706; Package emacs.
Full text available.
Received: (at 8706) by debbugs.gnu.org; 14 Jun 2011 16:56:33 +0000
From debbugs-submit-bounces <at> debbugs.gnu.org Tue Jun 14 12:56:33 2011
Received: from localhost ([127.0.0.1] helo=debbugs.gnu.org)
by debbugs.gnu.org with esmtp (Exim 4.69)
(envelope-from <debbugs-submit-bounces <at> debbugs.gnu.org>)
id 1QWWum-0008W6-DJ
for submit <at> debbugs.gnu.org; Tue, 14 Jun 2011 12:56:32 -0400
Received: from chirelay1o.jumptrading.com ([38.98.147.153]
helo=chirelay1.jumptrading.com)
by debbugs.gnu.org with esmtp (Exim 4.69)
(envelope-from <tzz <at> lifelogs.com>) id 1QWWuk-0008Vr-Nh
for 8706 <at> debbugs.gnu.org; Tue, 14 Jun 2011 12:56:31 -0400
Received: from chirelay1.jumptrading.com (unknown [127.0.0.1])
by chirelay1.jumptrading.com (Symantec Mail Security) with ESMTP id
895AB32003C
for <8706 <at> debbugs.gnu.org>; Tue, 14 Jun 2011 11:56:25 -0500 (CDT)
X-AuditID: 26629395-9f3e2bb000002471-7f-4df792b99217
Received: from chiexchange02.w2k.jumptrading.com (unknown [38.98.147.140])
by chirelay1.jumptrading.com (Symantec Mail Security) with ESMTP id
5E9AC2DC003
for <8706 <at> debbugs.gnu.org>; Tue, 14 Jun 2011 11:56:25 -0500 (CDT)
Received: from internalsmtp.w2k.jumptrading.com (10.2.4.29) by
chiexchange02.w2k.jumptrading.com (10.2.4.71) with Microsoft SMTP
Server id 8.1.291.1; Tue, 14 Jun 2011 11:56:25 -0500
Received: from tzlatanov-ubuntu-desktop.jumptrading.com ([10.2.14.81]) by
internalsmtp.w2k.jumptrading.com with Microsoft SMTPSVC(6.0.3790.1830);
Tue, 14 Jun 2011 11:56:24 -0500
From: Ted Zlatanov <tzz <at> lifelogs.com>
To: Glenn Morris <rgm <at> gnu.org>
Subject: Re: bug#8706: 24.0.50; [PATCH] Function to build a URL query-string
Organization: =?utf-8?B?0KLQtdC+0LTQvtGAINCX0LvQsNGC0LDQvdC+0LI=?= @ Cienfuegos
References: <m2aaehrzeu.fsf <at> gmail.com> <87d3j932n7.fsf <at> lifelogs.com>
<87zkmaopfs.fsf <at> lifelogs.com>
<91C69C7A-1980-4AF4-9B4B-4AFDB16D2C0B <at> simplegeo.com>
<87y61uldyj.fsf <at> lifelogs.com>
<70084BE3-710F-47B6-8949-B420F5BF47B4 <at> simplegeo.com>
<87d3ip1nau.fsf <at> lifelogs.com> <87tybxjhh7.fsf <at> lifelogs.com>
<87k4cp5i2z.fsf <at> lifelogs.com>
<43BFB40C-4F1B-457E-BC78-F33A22C91CCE <at> simplegeo.com>
<a7vcw8o0em.fsf <at> fencepost.gnu.org>
X-Face: bd.DQ~'29fIs`T_%O%C\g%6jW)yi[zuz6;
d4V0`@y-~$#3P_Ng{@m+e4o<4P'#(_GJQ%TT=
D}[Ep*b!\e,fBZ'j_+#"Ps?s2!4H2-Y"sx"
Mail-Copies-To: never
Gmane-Reply-To-List: yes
Date: Tue, 14 Jun 2011 11:56:23 -0500
In-Reply-To: <a7vcw8o0em.fsf <at> fencepost.gnu.org> (Glenn Morris's message of
"Tue, 14 Jun 2011 12:14:41 -0400")
Message-ID: <8739jcuzbc.fsf <at> lifelogs.com>
User-Agent: Gnus/5.110018 (No Gnus v0.18) Emacs/24.0.50 (gnu/linux)
MIME-Version: 1.0
Content-Type: text/plain
X-OriginalArrivalTime: 14 Jun 2011 16:56:24.0850 (UTC)
FILETIME=[FEC15F20:01CC2AB3]
X-Brightmail-Tracker: AAAAAA==
X-Spam-Score: -2.7 (--)
X-Debbugs-Envelope-To: 8706
Cc: Ian Eure <ian <at> simplegeo.com>, 8706 <at> debbugs.gnu.org
X-BeenThere: debbugs-submit <at> debbugs.gnu.org
X-Mailman-Version: 2.1.11
Precedence: list
List-Id: <debbugs-submit.debbugs.gnu.org>
List-Unsubscribe: <http://debbugs.gnu.org/cgi-bin/mailman/options/debbugs-submit>,
<mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=unsubscribe>
List-Archive: <http://debbugs.gnu.org/pipermail/debbugs-submit>
List-Post: <mailto:debbugs-submit <at> debbugs.gnu.org>
List-Help: <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=help>
List-Subscribe: <http://debbugs.gnu.org/cgi-bin/mailman/listinfo/debbugs-submit>,
<mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=subscribe>
Sender: debbugs-submit-bounces <at> debbugs.gnu.org
Errors-To: debbugs-submit-bounces <at> debbugs.gnu.org
X-Spam-Score: -2.7 (--)
On Tue, 14 Jun 2011 12:14:41 -0400 Glenn Morris <rgm <at> gnu.org> wrote:
GM> Ian Eure wrote:
>> Yes, I filed them for that change. I've subsequently switched jobs,
>> but there's no chance there is an IP claim against it.
GM> I did not see an assignment in the file that records these things, so I
GM> asked assign <at> gnu about it. They said that the assignment process was not
GM> completed. Please contact assign <at> gnu directly to sort this out.
Ian, please let me know when this is done and I'll commit the patch. I
hope we can get it done before the Emacs pretest.
On Tue, 14 Jun 2011 12:27:42 -0400 Glenn Morris <rgm <at> gnu.org> wrote:
>> >> This is not a tiny change, though, even if we split the commits.
>>
>> Splitting commits is never relevant for this kind of thing. It's the
>> total that counts.
GM> Oh, I might have misunderstood what was meant by "splitting" in this
GM> context (eg between more than one author, that would be relevant).
Yeah, I meant Ian's original as one commit and my minor changes on top.
Sorry I wasn't clearer.
Thanks
Ted
owner <at> debbugs.gnu.org, bug-gnu-emacs <at> gnu.org:bug#8706; Package emacs.
Full text available.Received: (at 8706) by debbugs.gnu.org; 14 Jun 2011 16:27:52 +0000 From debbugs-submit-bounces <at> debbugs.gnu.org Tue Jun 14 12:27:52 2011 Received: from localhost ([127.0.0.1] helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.69) (envelope-from <debbugs-submit-bounces <at> debbugs.gnu.org>) id 1QWWT1-0007mn-Ta for submit <at> debbugs.gnu.org; Tue, 14 Jun 2011 12:27:52 -0400 Received: from fencepost.gnu.org ([140.186.70.10]) by debbugs.gnu.org with esmtp (Exim 4.69) (envelope-from <rgm <at> gnu.org>) id 1QWWSz-0007mZ-4O for 8706 <at> debbugs.gnu.org; Tue, 14 Jun 2011 12:27:49 -0400 Received: from localhost ([127.0.0.1]:53276) by fencepost.gnu.org with esmtp (Exim 4.71) (envelope-from <rgm <at> gnu.org>) id 1QWWSt-0002yL-Cq; Tue, 14 Jun 2011 12:27:43 -0400 MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Transfer-Encoding: 7bit Message-ID: <19959.35838.775232.163671 <at> fencepost.gnu.org> Date: Tue, 14 Jun 2011 12:27:42 -0400 From: Glenn Morris <rgm <at> gnu.org> To: Ian Eure <ian <at> simplegeo.com>, Ted Zlatanov <tzz <at> lifelogs.com>, 8706 <at> debbugs.gnu.org Subject: Re: bug#8706: 24.0.50; [PATCH] Function to build a URL query-string In-Reply-To: <a7vcw8o0em.fsf <at> fencepost.gnu.org> References: <m2aaehrzeu.fsf <at> gmail.com> <87d3j932n7.fsf <at> lifelogs.com> <87zkmaopfs.fsf <at> lifelogs.com> <91C69C7A-1980-4AF4-9B4B-4AFDB16D2C0B <at> simplegeo.com> <87y61uldyj.fsf <at> lifelogs.com> <70084BE3-710F-47B6-8949-B420F5BF47B4 <at> simplegeo.com> <87d3ip1nau.fsf <at> lifelogs.com> <87tybxjhh7.fsf <at> lifelogs.com> <87k4cp5i2z.fsf <at> lifelogs.com> <43BFB40C-4F1B-457E-BC78-F33A22C91CCE <at> simplegeo.com> <a7vcw8o0em.fsf <at> fencepost.gnu.org> X-Attribution: GM X-Mailer: VM (www.wonderworks.com/vm), GNU Emacs (www.gnu.org/software/emacs) X-Hue: black X-Ran: s>']yT<5J.-O2`[C|es=yTuTW`%.(bS4eU=HdNf|d#m~~Xg$e)M:NmjSI9g-z:Q1w;jV>O X-Spam-Score: -6.3 (------) X-Debbugs-Envelope-To: 8706 X-BeenThere: debbugs-submit <at> debbugs.gnu.org X-Mailman-Version: 2.1.11 Precedence: list List-Id: <debbugs-submit.debbugs.gnu.org> List-Unsubscribe: <http://debbugs.gnu.org/cgi-bin/mailman/options/debbugs-submit>, <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=unsubscribe> List-Archive: <http://debbugs.gnu.org/pipermail/debbugs-submit> List-Post: <mailto:debbugs-submit <at> debbugs.gnu.org> List-Help: <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=help> List-Subscribe: <http://debbugs.gnu.org/cgi-bin/mailman/listinfo/debbugs-submit>, <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=subscribe> Sender: debbugs-submit-bounces <at> debbugs.gnu.org Errors-To: debbugs-submit-bounces <at> debbugs.gnu.org X-Spam-Score: -6.3 (------) > >> This is not a tiny change, though, even if we split the commits. > > Splitting commits is never relevant for this kind of thing. It's the > total that counts. Oh, I might have misunderstood what was meant by "splitting" in this context (eg between more than one author, that would be relevant).
owner <at> debbugs.gnu.org, bug-gnu-emacs <at> gnu.org:bug#8706; Package emacs.
Full text available.
Received: (at 8706) by debbugs.gnu.org; 14 Jun 2011 16:14:51 +0000
From debbugs-submit-bounces <at> debbugs.gnu.org Tue Jun 14 12:14:51 2011
Received: from localhost ([127.0.0.1] helo=debbugs.gnu.org)
by debbugs.gnu.org with esmtp (Exim 4.69)
(envelope-from <debbugs-submit-bounces <at> debbugs.gnu.org>)
id 1QWWGQ-0007RM-Op
for submit <at> debbugs.gnu.org; Tue, 14 Jun 2011 12:14:50 -0400
Received: from fencepost.gnu.org ([140.186.70.10])
by debbugs.gnu.org with esmtp (Exim 4.69)
(envelope-from <rgm <at> gnu.org>) id 1QWWGP-0007RB-4o
for 8706 <at> debbugs.gnu.org; Tue, 14 Jun 2011 12:14:49 -0400
Received: from localhost ([127.0.0.1]:37488)
by fencepost.gnu.org with esmtp (Exim 4.71)
(envelope-from <rgm <at> gnu.org>)
id 1QWWGI-0002Cb-2C; Tue, 14 Jun 2011 12:14:42 -0400
From: Glenn Morris <rgm <at> gnu.org>
To: Ian Eure <ian <at> simplegeo.com>
Subject: Re: bug#8706: 24.0.50; [PATCH] Function to build a URL query-string
References: <m2aaehrzeu.fsf <at> gmail.com> <87d3j932n7.fsf <at> lifelogs.com>
<87zkmaopfs.fsf <at> lifelogs.com>
<91C69C7A-1980-4AF4-9B4B-4AFDB16D2C0B <at> simplegeo.com>
<87y61uldyj.fsf <at> lifelogs.com>
<70084BE3-710F-47B6-8949-B420F5BF47B4 <at> simplegeo.com>
<87d3ip1nau.fsf <at> lifelogs.com> <87tybxjhh7.fsf <at> lifelogs.com>
<87k4cp5i2z.fsf <at> lifelogs.com>
<43BFB40C-4F1B-457E-BC78-F33A22C91CCE <at> simplegeo.com>
X-Spook: 9/11 anthrax Rumsfeld bank LLNL Mole chameleon man Saudi
X-Ran: 1i?Eq1v}+=$@FXlQ<n9#}Ac#vd#Yp5$["y]F0Q'bsxM <at> e{;*#V!=c%Ci0/7z%gP[t4/'@^
X-Hue: red
X-Debbugs-No-Ack: yes
X-Attribution: GM
Date: Tue, 14 Jun 2011 12:14:41 -0400
In-Reply-To: <43BFB40C-4F1B-457E-BC78-F33A22C91CCE <at> simplegeo.com> (Ian Eure's
message of "Mon, 13 Jun 2011 18:29:44 -0700")
Message-ID: <a7vcw8o0em.fsf <at> fencepost.gnu.org>
User-Agent: Gnus (www.gnus.org), GNU Emacs (www.gnu.org/software/emacs/)
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
X-Spam-Score: -6.3 (------)
X-Debbugs-Envelope-To: 8706
Cc: Ted Zlatanov <tzz <at> lifelogs.com>, 8706 <at> debbugs.gnu.org
X-BeenThere: debbugs-submit <at> debbugs.gnu.org
X-Mailman-Version: 2.1.11
Precedence: list
List-Id: <debbugs-submit.debbugs.gnu.org>
List-Unsubscribe: <http://debbugs.gnu.org/cgi-bin/mailman/options/debbugs-submit>,
<mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=unsubscribe>
List-Archive: <http://debbugs.gnu.org/pipermail/debbugs-submit>
List-Post: <mailto:debbugs-submit <at> debbugs.gnu.org>
List-Help: <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=help>
List-Subscribe: <http://debbugs.gnu.org/cgi-bin/mailman/listinfo/debbugs-submit>,
<mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=subscribe>
Sender: debbugs-submit-bounces <at> debbugs.gnu.org
Errors-To: debbugs-submit-bounces <at> debbugs.gnu.org
X-Spam-Score: -6.3 (------)
Ian Eure wrote:
>> This is not a tiny change, though, even if we split the commits.
Splitting commits is never relevant for this kind of thing. It's the
total that counts.
>> Do you have Emacs assignment papers on file?
>>
> Yes, I filed them for that change. I've subsequently switched jobs,
> but there's no chance there is an IP claim against it.
I did not see an assignment in the file that records these things, so I
asked assign <at> gnu about it. They said that the assignment process was not
completed. Please contact assign <at> gnu directly to sort this out.
owner <at> debbugs.gnu.org, bug-gnu-emacs <at> gnu.org:bug#8706; Package emacs.
Full text available.Received: (at 8706) by debbugs.gnu.org; 14 Jun 2011 01:31:38 +0000 From debbugs-submit-bounces <at> debbugs.gnu.org Mon Jun 13 21:31:38 2011 Received: from localhost ([127.0.0.1] helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.69) (envelope-from <debbugs-submit-bounces <at> debbugs.gnu.org>) id 1QWITi-000351-4k for submit <at> debbugs.gnu.org; Mon, 13 Jun 2011 21:31:38 -0400 Received: from mail-pv0-f172.google.com ([74.125.83.172]) by debbugs.gnu.org with esmtp (Exim 4.69) (envelope-from <ian <at> simplegeo.com>) id 1QWITg-00034q-S2 for 8706 <at> debbugs.gnu.org; Mon, 13 Jun 2011 21:31:37 -0400 Received: by pvh18 with SMTP id 18so2376512pvh.3 for <8706 <at> debbugs.gnu.org>; Mon, 13 Jun 2011 18:31:30 -0700 (PDT) Received: by 10.68.14.226 with SMTP id s2mr2559733pbc.252.1308015090869; Mon, 13 Jun 2011 18:31:30 -0700 (PDT) Received: from [10.128.0.81] (50-0-96-104.dsl.static.sonic.net [50.0.96.104]) by mx.google.com with ESMTPS id m9sm5097939pbd.71.2011.06.13.18.31.29 (version=TLSv1/SSLv3 cipher=OTHER); Mon, 13 Jun 2011 18:31:30 -0700 (PDT) Subject: Re: bug#8706: 24.0.50; [PATCH] Function to build a URL query-string Mime-Version: 1.0 (Apple Message framework v1084) Content-Type: text/plain; charset=us-ascii From: Ian Eure <ian <at> simplegeo.com> In-Reply-To: <87k4cp5i2z.fsf <at> lifelogs.com> Date: Mon, 13 Jun 2011 18:29:44 -0700 Content-Transfer-Encoding: quoted-printable Message-Id: <43BFB40C-4F1B-457E-BC78-F33A22C91CCE <at> simplegeo.com> References: <m2aaehrzeu.fsf <at> gmail.com> <87d3j932n7.fsf <at> lifelogs.com> <87zkmaopfs.fsf <at> lifelogs.com> <91C69C7A-1980-4AF4-9B4B-4AFDB16D2C0B <at> simplegeo.com> <87y61uldyj.fsf <at> lifelogs.com> <70084BE3-710F-47B6-8949-B420F5BF47B4 <at> simplegeo.com> <87d3ip1nau.fsf <at> lifelogs.com> <87tybxjhh7.fsf <at> lifelogs.com> <87k4cp5i2z.fsf <at> lifelogs.com> To: Ted Zlatanov <tzz <at> lifelogs.com> X-Mailer: Apple Mail (2.1084) X-Spam-Score: -3.6 (---) X-Debbugs-Envelope-To: 8706 Cc: 8706 <at> debbugs.gnu.org X-BeenThere: debbugs-submit <at> debbugs.gnu.org X-Mailman-Version: 2.1.11 Precedence: list List-Id: <debbugs-submit.debbugs.gnu.org> List-Unsubscribe: <http://debbugs.gnu.org/cgi-bin/mailman/options/debbugs-submit>, <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=unsubscribe> List-Archive: <http://debbugs.gnu.org/pipermail/debbugs-submit> List-Post: <mailto:debbugs-submit <at> debbugs.gnu.org> List-Help: <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=help> List-Subscribe: <http://debbugs.gnu.org/cgi-bin/mailman/listinfo/debbugs-submit>, <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=subscribe> Sender: debbugs-submit-bounces <at> debbugs.gnu.org Errors-To: debbugs-submit-bounces <at> debbugs.gnu.org X-Spam-Score: -3.6 (---) On Jun 13, 2011, at 6:15 PM, Ted Zlatanov wrote: > On Fri, 10 Jun 2011 20:15:48 -0500 Ted Zlatanov <tzz <at> lifelogs.com> = wrote:=20 >=20 > TZ> (second try for this, the first one I posted through Gmane = disappeared) > TZ> Attached is a patch which: >=20 > TZ> - adds optional SEMICOLONS and KEEP-EMPTY to = `url-build-query-string' to > TZ> separate parameters with semicolons and to keep empty values >=20 > TZ> - fixes `url-parse-query-string' to understand the '=3D' is not = required > TZ> in a parameter >=20 > TZ> - adds ERT tests for `url-build-query-string' and > TZ> `url-parse-query-string' >=20 > TZ> Ian, if you could look it over, I'd appreciate it. In particular = if you > TZ> think KEEP-EMPTY should be the default or if you see any other = problems... >=20 Looks good to me. > Ian, I'd like to commit this. I think it's pretty close to your > original code so you should be the author, which is why I'm asking for > your feedback (I can split the commits if you prefer). I see one = commit > with your name in ChangeLog.14: >=20 > 2009-02-14 Ian Eure <ian <at> digg.com> (tiny change) >=20 > This is not a tiny change, though, even if we split the commits. Do = you > have Emacs assignment papers on file? >=20 Yes, I filed them for that change. I've subsequently switched jobs, but = there's no chance there is an IP claim against it.
owner <at> debbugs.gnu.org, bug-gnu-emacs <at> gnu.org:bug#8706; Package emacs.
Full text available.
Received: (at 8706) by debbugs.gnu.org; 14 Jun 2011 01:15:42 +0000
From debbugs-submit-bounces <at> debbugs.gnu.org Mon Jun 13 21:15:41 2011
Received: from localhost ([127.0.0.1] helo=debbugs.gnu.org)
by debbugs.gnu.org with esmtp (Exim 4.69)
(envelope-from <debbugs-submit-bounces <at> debbugs.gnu.org>)
id 1QWIEH-0002jQ-8k
for submit <at> debbugs.gnu.org; Mon, 13 Jun 2011 21:15:41 -0400
Received: from z.lifelogs.com ([173.255.230.239])
by debbugs.gnu.org with esmtp (Exim 4.69)
(envelope-from <tzz <at> lifelogs.com>) id 1QWIEF-0002jC-J4
for 8706 <at> debbugs.gnu.org; Mon, 13 Jun 2011 21:15:39 -0400
Received: from heechee (c-67-186-102-106.hsd1.il.comcast.net [67.186.102.106])
(using TLSv1 with cipher DHE-RSA-AES256-SHA (256/256 bits))
(No client certificate requested) (Authenticated sender: tzz)
by z.lifelogs.com (Postfix) with ESMTPSA id C104D6200E;
Tue, 14 Jun 2011 01:15:33 +0000 (UTC)
From: Ted Zlatanov <tzz <at> lifelogs.com>
To: Ian Eure <ian <at> simplegeo.com>
Subject: Re: bug#8706: 24.0.50; [PATCH] Function to build a URL query-string
Organization: =?utf-8?B?0KLQtdC+0LTQvtGAINCX0LvQsNGC0LDQvdC+0LI=?= @ Cienfuegos
References: <m2aaehrzeu.fsf <at> gmail.com> <87d3j932n7.fsf <at> lifelogs.com>
<87zkmaopfs.fsf <at> lifelogs.com>
<91C69C7A-1980-4AF4-9B4B-4AFDB16D2C0B <at> simplegeo.com>
<87y61uldyj.fsf <at> lifelogs.com>
<70084BE3-710F-47B6-8949-B420F5BF47B4 <at> simplegeo.com>
<87d3ip1nau.fsf <at> lifelogs.com> <87tybxjhh7.fsf <at> lifelogs.com>
X-Face: bd.DQ~'29fIs`T_%O%C\g%6jW)yi[zuz6;
d4V0`@y-~$#3P_Ng{@m+e4o<4P'#(_GJQ%TT=
D}[Ep*b!\e,fBZ'j_+#"Ps?s2!4H2-Y"sx"
Mail-Copies-To: never
Gmane-Reply-To-List: yes
Date: Mon, 13 Jun 2011 20:15:32 -0500
In-Reply-To: <87tybxjhh7.fsf <at> lifelogs.com> (Ted Zlatanov's message of "Fri, 10
Jun 2011 20:15:48 -0500")
Message-ID: <87k4cp5i2z.fsf <at> lifelogs.com>
User-Agent: Gnus/5.110018 (No Gnus v0.18) Emacs/24.0.50 (gnu/linux)
MIME-Version: 1.0
Content-Type: text/plain
X-Spam-Score: -3.4 (---)
X-Debbugs-Envelope-To: 8706
Cc: 8706 <at> debbugs.gnu.org
X-BeenThere: debbugs-submit <at> debbugs.gnu.org
X-Mailman-Version: 2.1.11
Precedence: list
List-Id: <debbugs-submit.debbugs.gnu.org>
List-Unsubscribe: <http://debbugs.gnu.org/cgi-bin/mailman/options/debbugs-submit>,
<mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=unsubscribe>
List-Archive: <http://debbugs.gnu.org/pipermail/debbugs-submit>
List-Post: <mailto:debbugs-submit <at> debbugs.gnu.org>
List-Help: <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=help>
List-Subscribe: <http://debbugs.gnu.org/cgi-bin/mailman/listinfo/debbugs-submit>,
<mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=subscribe>
Sender: debbugs-submit-bounces <at> debbugs.gnu.org
Errors-To: debbugs-submit-bounces <at> debbugs.gnu.org
X-Spam-Score: -3.3 (---)
On Fri, 10 Jun 2011 20:15:48 -0500 Ted Zlatanov <tzz <at> lifelogs.com> wrote:
TZ> (second try for this, the first one I posted through Gmane disappeared)
TZ> Attached is a patch which:
TZ> - adds optional SEMICOLONS and KEEP-EMPTY to `url-build-query-string' to
TZ> separate parameters with semicolons and to keep empty values
TZ> - fixes `url-parse-query-string' to understand the '=' is not required
TZ> in a parameter
TZ> - adds ERT tests for `url-build-query-string' and
TZ> `url-parse-query-string'
TZ> Ian, if you could look it over, I'd appreciate it. In particular if you
TZ> think KEEP-EMPTY should be the default or if you see any other problems...
Ian, I'd like to commit this. I think it's pretty close to your
original code so you should be the author, which is why I'm asking for
your feedback (I can split the commits if you prefer). I see one commit
with your name in ChangeLog.14:
2009-02-14 Ian Eure <ian <at> digg.com> (tiny change)
This is not a tiny change, though, even if we split the commits. Do you
have Emacs assignment papers on file?
Thanks
Ted
owner <at> debbugs.gnu.org, bug-gnu-emacs <at> gnu.org:bug#8706; Package emacs.
Full text available.
Received: (at 8706) by debbugs.gnu.org; 11 Jun 2011 10:29:45 +0000
From debbugs-submit-bounces <at> debbugs.gnu.org Sat Jun 11 06:29:45 2011
Received: from localhost ([127.0.0.1] helo=debbugs.gnu.org)
by debbugs.gnu.org with esmtp (Exim 4.69)
(envelope-from <debbugs-submit-bounces <at> debbugs.gnu.org>)
id 1QVLRp-0006hV-6W
for submit <at> debbugs.gnu.org; Sat, 11 Jun 2011 06:29:45 -0400
Received: from z.lifelogs.com ([173.255.230.239])
by debbugs.gnu.org with esmtp (Exim 4.69)
(envelope-from <tzz <at> lifelogs.com>) id 1QVLRi-0006hG-P4
for 8706 <at> debbugs.gnu.org; Sat, 11 Jun 2011 06:29:43 -0400
Received: from heechee (c-67-186-102-106.hsd1.il.comcast.net [67.186.102.106])
(using TLSv1 with cipher DHE-RSA-AES256-SHA (256/256 bits))
(No client certificate requested) (Authenticated sender: tzz)
by z.lifelogs.com (Postfix) with ESMTPSA id 25C726200E;
Sat, 11 Jun 2011 10:29:32 +0000 (UTC)
From: Ted Zlatanov <tzz <at> lifelogs.com>
To: Deniz Dogan <deniz <at> dogan.se>
Subject: Re: bug#8706: 24.0.50; [PATCH] Function to build a URL query-string
Organization: =?utf-8?B?0KLQtdC+0LTQvtGAINCX0LvQsNGC0LDQvdC+0LI=?= @ Cienfuegos
References: <m2aaehrzeu.fsf <at> gmail.com> <87d3j932n7.fsf <at> lifelogs.com>
<87zkmaopfs.fsf <at> lifelogs.com>
<91C69C7A-1980-4AF4-9B4B-4AFDB16D2C0B <at> simplegeo.com>
<87y61uldyj.fsf <at> lifelogs.com>
<70084BE3-710F-47B6-8949-B420F5BF47B4 <at> simplegeo.com>
<87d3ip1nau.fsf <at> lifelogs.com> <87tybxjhh7.fsf <at> lifelogs.com>
<4DF30BEE.2060801 <at> dogan.se>
X-Face: bd.DQ~'29fIs`T_%O%C\g%6jW)yi[zuz6;
d4V0`@y-~$#3P_Ng{@m+e4o<4P'#(_GJQ%TT=
D}[Ep*b!\e,fBZ'j_+#"Ps?s2!4H2-Y"sx"
Mail-Copies-To: never
Gmane-Reply-To-List: yes
Date: Sat, 11 Jun 2011 05:29:32 -0500
In-Reply-To: <4DF30BEE.2060801 <at> dogan.se> (Deniz Dogan's message of "Sat, 11
Jun 2011 08:32:14 +0200")
Message-ID: <87lix8k6er.fsf <at> lifelogs.com>
User-Agent: Gnus/5.110018 (No Gnus v0.18) Emacs/24.0.50 (gnu/linux)
MIME-Version: 1.0
Content-Type: text/plain
X-Spam-Score: -3.7 (---)
X-Debbugs-Envelope-To: 8706
Cc: 8706 <at> debbugs.gnu.org
X-BeenThere: debbugs-submit <at> debbugs.gnu.org
X-Mailman-Version: 2.1.11
Precedence: list
List-Id: <debbugs-submit.debbugs.gnu.org>
List-Unsubscribe: <http://debbugs.gnu.org/cgi-bin/mailman/options/debbugs-submit>,
<mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=unsubscribe>
List-Archive: <http://debbugs.gnu.org/pipermail/debbugs-submit>
List-Post: <mailto:debbugs-submit <at> debbugs.gnu.org>
List-Help: <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=help>
List-Subscribe: <http://debbugs.gnu.org/cgi-bin/mailman/listinfo/debbugs-submit>,
<mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=subscribe>
Sender: debbugs-submit-bounces <at> debbugs.gnu.org
Errors-To: debbugs-submit-bounces <at> debbugs.gnu.org
X-Spam-Score: -3.6 (---)
On Sat, 11 Jun 2011 08:32:14 +0200 Deniz Dogan <deniz <at> dogan.se> wrote:
DD> On 2011-06-11 03:15, Ted Zlatanov wrote:
>> (second try for this, the first one I posted through Gmane disappeared)
>>
>> Attached is a patch which:
>>
>> - adds optional SEMICOLONS and KEEP-EMPTY to `url-build-query-string' to
>> separate parameters with semicolons and to keep empty values
>>
DD> Why semicolons? Wouldn't it be more appropriate to have SEPARATOR as
DD> an optional argument instead?
URL query paramaters can only be separated by "&" and ";" and "&" is the
default :)
Ted
owner <at> debbugs.gnu.org, bug-gnu-emacs <at> gnu.org:bug#8706; Package emacs.
Full text available.Received: (at submit) by debbugs.gnu.org; 11 Jun 2011 06:34:00 +0000 From debbugs-submit-bounces <at> debbugs.gnu.org Sat Jun 11 02:34:00 2011 Received: from localhost ([127.0.0.1] helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.69) (envelope-from <debbugs-submit-bounces <at> debbugs.gnu.org>) id 1QVHlf-0001eA-Oh for submit <at> debbugs.gnu.org; Sat, 11 Jun 2011 02:33:59 -0400 Received: from eggs.gnu.org ([140.186.70.92]) by debbugs.gnu.org with esmtp (Exim 4.69) (envelope-from <deniz <at> dogan.se>) id 1QVHle-0001e1-Sy for submit <at> debbugs.gnu.org; Sat, 11 Jun 2011 02:33:59 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from <deniz <at> dogan.se>) id 1QVHlZ-0004jC-4S for submit <at> debbugs.gnu.org; Sat, 11 Jun 2011 02:33:53 -0400 X-Spam-Checker-Version: SpamAssassin 3.3.1 (2010-03-16) on eggs.gnu.org X-Spam-Level: X-Spam-Status: No, score=-2.6 required=5.0 tests=BAYES_00,RCVD_IN_DNSWL_LOW autolearn=unavailable version=3.3.1 Received: from lists.gnu.org ([140.186.70.17]:51495) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from <deniz <at> dogan.se>) id 1QVHlZ-0004j8-2U for submit <at> debbugs.gnu.org; Sat, 11 Jun 2011 02:33:53 -0400 Received: from eggs.gnu.org ([140.186.70.92]:36748) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from <deniz <at> dogan.se>) id 1QVHlX-0001no-Si for bug-gnu-emacs <at> gnu.org; Sat, 11 Jun 2011 02:33:52 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from <deniz <at> dogan.se>) id 1QVHlX-0004ii-2u for bug-gnu-emacs <at> gnu.org; Sat, 11 Jun 2011 02:33:51 -0400 Received: from ch-smtp05.sth.basefarm.net ([80.76.153.6]:39876) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from <deniz <at> dogan.se>) id 1QVHlW-0004ic-UY for bug-gnu-emacs <at> gnu.org; Sat, 11 Jun 2011 02:33:51 -0400 Received: from c80-216-105-155.bredband.comhem.se ([80.216.105.155]:53360 helo=[192.168.0.10]) by ch-smtp05.sth.basefarm.net with esmtp (Exim 4.76) (envelope-from <deniz <at> dogan.se>) id 1QVHkC-0008AM-Gf for bug-gnu-emacs <at> gnu.org; Sat, 11 Jun 2011 08:32:29 +0200 Message-ID: <4DF30BEE.2060801 <at> dogan.se> Date: Sat, 11 Jun 2011 08:32:14 +0200 From: Deniz Dogan <deniz <at> dogan.se> User-Agent: Mozilla/5.0 (Windows; U; Windows NT 6.1; en-US; rv:1.9.2.17) Gecko/20110414 Thunderbird/3.1.10 MIME-Version: 1.0 To: bug-gnu-emacs <at> gnu.org Subject: Re: bug#8706: 24.0.50; [PATCH] Function to build a URL query-string References: <m2aaehrzeu.fsf <at> gmail.com> <87d3j932n7.fsf <at> lifelogs.com> <87zkmaopfs.fsf <at> lifelogs.com> <91C69C7A-1980-4AF4-9B4B-4AFDB16D2C0B <at> simplegeo.com> <87y61uldyj.fsf <at> lifelogs.com> <70084BE3-710F-47B6-8949-B420F5BF47B4 <at> simplegeo.com> <87d3ip1nau.fsf <at> lifelogs.com> <87tybxjhh7.fsf <at> lifelogs.com> In-Reply-To: <87tybxjhh7.fsf <at> lifelogs.com> Content-Type: text/plain; charset=ISO-8859-1; format=flowed Content-Transfer-Encoding: 7bit X-Originating-IP: 80.216.105.155 X-Scan-Result: No virus found in message 1QVHkC-0008AM-Gf. X-Scan-Signature: ch-smtp05.sth.basefarm.net 1QVHkC-0008AM-Gf 01f5dda12cf549729b0c805009803fdb X-detected-operating-system: by eggs.gnu.org: Genre and OS details not recognized. X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.6 (newer, 3) X-Received-From: 140.186.70.17 X-Spam-Score: -5.1 (-----) X-Debbugs-Envelope-To: submit X-BeenThere: debbugs-submit <at> debbugs.gnu.org X-Mailman-Version: 2.1.11 Precedence: list List-Id: <debbugs-submit.debbugs.gnu.org> List-Unsubscribe: <http://debbugs.gnu.org/cgi-bin/mailman/options/debbugs-submit>, <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=unsubscribe> List-Archive: <http://debbugs.gnu.org/pipermail/debbugs-submit> List-Post: <mailto:debbugs-submit <at> debbugs.gnu.org> List-Help: <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=help> List-Subscribe: <http://debbugs.gnu.org/cgi-bin/mailman/listinfo/debbugs-submit>, <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=subscribe> Sender: debbugs-submit-bounces <at> debbugs.gnu.org Errors-To: debbugs-submit-bounces <at> debbugs.gnu.org X-Spam-Score: -5.4 (-----) On 2011-06-11 03:15, Ted Zlatanov wrote: > (second try for this, the first one I posted through Gmane disappeared) > > Attached is a patch which: > > - adds optional SEMICOLONS and KEEP-EMPTY to `url-build-query-string' to > separate parameters with semicolons and to keep empty values > Why semicolons? Wouldn't it be more appropriate to have SEPARATOR as an optional argument instead?
owner <at> debbugs.gnu.org, bug-gnu-emacs <at> gnu.org:bug#8706; Package emacs.
Full text available.
Received: (at 8706) by debbugs.gnu.org; 11 Jun 2011 01:15:58 +0000
From debbugs-submit-bounces <at> debbugs.gnu.org Fri Jun 10 21:15:58 2011
Received: from localhost ([127.0.0.1] helo=debbugs.gnu.org)
by debbugs.gnu.org with esmtp (Exim 4.69)
(envelope-from <debbugs-submit-bounces <at> debbugs.gnu.org>)
id 1QVCnt-00031S-N9
for submit <at> debbugs.gnu.org; Fri, 10 Jun 2011 21:15:58 -0400
Received: from z.lifelogs.com ([173.255.230.239])
by debbugs.gnu.org with esmtp (Exim 4.69)
(envelope-from <tzz <at> lifelogs.com>) id 1QVCnr-00031F-JY
for 8706 <at> debbugs.gnu.org; Fri, 10 Jun 2011 21:15:56 -0400
Received: from heechee (c-67-186-102-106.hsd1.il.comcast.net [67.186.102.106])
(using TLSv1 with cipher DHE-RSA-AES256-SHA (256/256 bits))
(No client certificate requested) (Authenticated sender: tzz)
by z.lifelogs.com (Postfix) with ESMTPSA id 8755A6200E;
Sat, 11 Jun 2011 01:15:49 +0000 (UTC)
From: Ted Zlatanov <tzz <at> lifelogs.com>
To: Ian Eure <ian <at> simplegeo.com>
Subject: Re: bug#8706: 24.0.50; [PATCH] Function to build a URL query-string
Organization: =?utf-8?B?0KLQtdC+0LTQvtGAINCX0LvQsNGC0LDQvdC+0LI=?= @ Cienfuegos
References: <m2aaehrzeu.fsf <at> gmail.com> <87d3j932n7.fsf <at> lifelogs.com>
<87zkmaopfs.fsf <at> lifelogs.com>
<91C69C7A-1980-4AF4-9B4B-4AFDB16D2C0B <at> simplegeo.com>
<87y61uldyj.fsf <at> lifelogs.com>
<70084BE3-710F-47B6-8949-B420F5BF47B4 <at> simplegeo.com>
<87d3ip1nau.fsf <at> lifelogs.com>
X-Face: bd.DQ~'29fIs`T_%O%C\g%6jW)yi[zuz6;
d4V0`@y-~$#3P_Ng{@m+e4o<4P'#(_GJQ%TT=
D}[Ep*b!\e,fBZ'j_+#"Ps?s2!4H2-Y"sx"
Mail-Copies-To: never
Gmane-Reply-To-List: yes
Date: Fri, 10 Jun 2011 20:15:48 -0500
In-Reply-To: <87d3ip1nau.fsf <at> lifelogs.com> (Ted Zlatanov's message of "Tue, 7
Jun 2011 13:58:17 -0500")
Message-ID: <87tybxjhh7.fsf <at> lifelogs.com>
User-Agent: Gnus/5.110018 (No Gnus v0.18) Emacs/24.0.50 (gnu/linux)
MIME-Version: 1.0
Content-Type: multipart/mixed; boundary="=-=-="
X-Spam-Score: -4.4 (----)
X-Debbugs-Envelope-To: 8706
Cc: 8706 <at> debbugs.gnu.org
X-BeenThere: debbugs-submit <at> debbugs.gnu.org
X-Mailman-Version: 2.1.11
Precedence: list
List-Id: <debbugs-submit.debbugs.gnu.org>
List-Unsubscribe: <http://debbugs.gnu.org/cgi-bin/mailman/options/debbugs-submit>,
<mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=unsubscribe>
List-Archive: <http://debbugs.gnu.org/pipermail/debbugs-submit>
List-Post: <mailto:debbugs-submit <at> debbugs.gnu.org>
List-Help: <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=help>
List-Subscribe: <http://debbugs.gnu.org/cgi-bin/mailman/listinfo/debbugs-submit>,
<mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=subscribe>
Sender: debbugs-submit-bounces <at> debbugs.gnu.org
Errors-To: debbugs-submit-bounces <at> debbugs.gnu.org
X-Spam-Score: -4.1 (----)
--=-=-=
Content-Type: text/plain
(second try for this, the first one I posted through Gmane disappeared)
Attached is a patch which:
- adds optional SEMICOLONS and KEEP-EMPTY to `url-build-query-string' to
separate parameters with semicolons and to keep empty values
- fixes `url-parse-query-string' to understand the '=' is not required
in a parameter
- adds ERT tests for `url-build-query-string' and
`url-parse-query-string'
Ian, if you could look it over, I'd appreciate it. In particular if you
think KEEP-EMPTY should be the default or if you see any other problems...
Thanks
Ted
--=-=-=
Content-Type: text/x-diff
Content-Disposition: inline; filename=url-build-and-parse.patch
=== modified file 'lisp/url/url-util.el'
--- lisp/url/url-util.el 2011-01-25 04:08:28 +0000
+++ lisp/url/url-util.el 2011-06-09 16:43:39 +0000
@@ -26,7 +26,8 @@
(require 'url-parse)
(require 'url-vars)
-(eval-when-compile (require 'cl))
+(eval-when-compile (require 'cl)
+ (require 'ert))
(autoload 'timezone-parse-date "timezone")
(autoload 'timezone-make-date-arpa-standard "timezone")
(autoload 'mail-header-extract "mailheader")
@@ -263,24 +264,65 @@
;;;###autoload
(defun url-parse-query-string (query &optional downcase allow-newlines)
(let (retval pairs cur key val)
- (setq pairs (split-string query "&"))
+ (setq pairs (split-string query "[;&]"))
(while pairs
(setq cur (car pairs)
pairs (cdr pairs))
- (if (not (string-match "=" cur))
- nil ; Grace
- (setq key (url-unhex-string (substring cur 0 (match-beginning 0))
- allow-newlines))
- (setq val (url-unhex-string (substring cur (match-end 0) nil)
- allow-newlines))
- (if downcase
- (setq key (downcase key)))
- (setq cur (assoc key retval))
- (if cur
- (setcdr cur (cons val (cdr cur)))
- (setq retval (cons (list key val) retval)))))
+ (unless (string-match "=" cur)
+ (setq cur (concat cur "=")))
+
+ (when (string-match "=" cur)
+ (setq key (url-unhex-string (substring cur 0 (match-beginning 0))
+ allow-newlines))
+ (setq val (url-unhex-string (substring cur (match-end 0) nil)
+ allow-newlines))
+ (if downcase
+ (setq key (downcase key)))
+ (setq cur (assoc key retval))
+ (if cur
+ (setcdr cur (cons val (cdr cur)))
+ (setq retval (cons (list key val) retval)))))
retval))
+;;;###autoload
+(defun url-build-query-string (query &optional semicolons keep-empty)
+ "Build a query-string.
+
+Given a QUERY in the form:
+'((key1 val1)
+ (key2 val2)
+ (key3 val1 val2)
+ (key4)
+ (key5 ""))
+
+\(This is the same format as produced by `url-parse-query-string')
+
+This will return a string
+\"key1=val1&key2=val2&key3=val1&key3=val2&key4&key5\". Keys may
+be strings or symbols; if they are symbols, the symbol name will
+be used.
+
+When SEMICOLONS is given, the separator will be \";\".
+
+When KEEP-EMPTY is given, empty values will show as \"key=\"
+instead of just \"key\" as in the example above."
+ (mapconcat
+ (lambda (key-vals)
+ (let ((escaped
+ (mapcar (lambda (sym)
+ (url-hexify-string (format "%s" sym))) key-vals)))
+ (mapconcat (lambda (val)
+ (let ((vprint (format "%s" val))
+ (eprint (format "%s" (car escaped))))
+ (concat eprint
+ (if (or keep-empty
+ (and val (not (zerop (length vprint)))))
+ "="
+ "")
+ vprint)))
+ (or (cdr escaped) '("")) (if semicolons ";" "&"))))
+ query (if semicolons ";" "&")))
+
(defun url-unhex (x)
(if (> x ?9)
(if (>= x ?a)
@@ -529,6 +571,27 @@
(error "Danger: `%s' is a symbolic link" file))
(set-file-modes file #o0600))))
+(ert-deftest url-build-and-parse-query-string ()
+ (let ((tests
+ '(("key1=val1&key2=val2&key3=val1&key3=val2&key4&key5"
+ ((key1 val1) (key2 "val2") (key3 val1 val2) (key4) (key5 "")))
+ ("key1=val1;key2=val2;key3=val1;key3=val2;key4;key5"
+ ((key1 "val1") (key2 val2) (key3 val1 val2) ("key4") (key5 "")) t)
+ ("key1=val1;key2=val2;key3=val1;key3=val2;key4=;key5="
+ ((key1 val1) (key2 val2) ("key3" val1 val2) (key4) (key5 "")) t t)))
+ test)
+ (while tests
+ (setq test (car tests)
+ tests (cdr tests))
+ (should (equal (apply 'url-build-query-string (cdr test)) (car test)))))
+ (should (equal (url-parse-query-string
+ "key1=val1&key2=val2&key3=val1&key3=val2&key4=&key5")
+ '(("key5" "")
+ ("key4" "")
+ ("key3" "val2" "val1")
+ ("key2" "val2")
+ ("key1" "val1")))))
+
(provide 'url-util)
;;; url-util.el ends here
--=-=-=--
owner <at> debbugs.gnu.org, bug-gnu-emacs <at> gnu.org:bug#8706; Package emacs.
Full text available.
Received: (at submit) by debbugs.gnu.org; 9 Jun 2011 16:48:06 +0000
From debbugs-submit-bounces <at> debbugs.gnu.org Thu Jun 09 12:48:06 2011
Received: from localhost ([127.0.0.1] helo=debbugs.gnu.org)
by debbugs.gnu.org with esmtp (Exim 4.69)
(envelope-from <debbugs-submit-bounces <at> debbugs.gnu.org>)
id 1QUiOr-0002un-AJ
for submit <at> debbugs.gnu.org; Thu, 09 Jun 2011 12:48:06 -0400
Received: from eggs.gnu.org ([140.186.70.92])
by debbugs.gnu.org with esmtp (Exim 4.69)
(envelope-from <geb-bug-gnu-emacs <at> m.gmane.org>) id 1QUiOo-0002uJ-Ok
for submit <at> debbugs.gnu.org; Thu, 09 Jun 2011 12:48:03 -0400
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
(envelope-from <geb-bug-gnu-emacs <at> m.gmane.org>) id 1QUiOe-0006ko-GV
for submit <at> debbugs.gnu.org; Thu, 09 Jun 2011 12:47:57 -0400
X-Spam-Checker-Version: SpamAssassin 3.3.1 (2010-03-16) on eggs.gnu.org
X-Spam-Level:
X-Spam-Status: No, score=-4.2 required=5.0 tests=BAYES_00,RCVD_IN_DNSWL_MED,
T_RP_MATCHES_RCVD autolearn=unavailable version=3.3.1
Received: from lists.gnu.org ([140.186.70.17]:56473)
by eggs.gnu.org with esmtp (Exim 4.71)
(envelope-from <geb-bug-gnu-emacs <at> m.gmane.org>) id 1QUiOe-0006kk-1X
for submit <at> debbugs.gnu.org; Thu, 09 Jun 2011 12:47:52 -0400
Received: from eggs.gnu.org ([140.186.70.92]:57173)
by lists.gnu.org with esmtp (Exim 4.71)
(envelope-from <geb-bug-gnu-emacs <at> m.gmane.org>) id 1QUiOc-00034q-90
for bug-gnu-emacs <at> gnu.org; Thu, 09 Jun 2011 12:47:51 -0400
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
(envelope-from <geb-bug-gnu-emacs <at> m.gmane.org>) id 1QUiOa-0006kS-8i
for bug-gnu-emacs <at> gnu.org; Thu, 09 Jun 2011 12:47:49 -0400
Received: from lo.gmane.org ([80.91.229.12]:60911)
by eggs.gnu.org with esmtp (Exim 4.71)
(envelope-from <geb-bug-gnu-emacs <at> m.gmane.org>) id 1QUiOZ-0006kN-QH
for bug-gnu-emacs <at> gnu.org; Thu, 09 Jun 2011 12:47:48 -0400
Received: from list by lo.gmane.org with local (Exim 4.69)
(envelope-from <geb-bug-gnu-emacs <at> m.gmane.org>) id 1QUiOY-00015y-Er
for bug-gnu-emacs <at> gnu.org; Thu, 09 Jun 2011 18:47:46 +0200
Received: from c-67-186-102-106.hsd1.il.comcast.net ([67.186.102.106])
by main.gmane.org with esmtp (Gmexim 0.1 (Debian))
id 1AlnuQ-0007hv-00
for <bug-gnu-emacs <at> gnu.org>; Thu, 09 Jun 2011 18:47:46 +0200
Received: from tzz by c-67-186-102-106.hsd1.il.comcast.net with local (Gmexim
0.1 (Debian)) id 1AlnuQ-0007hv-00
for <bug-gnu-emacs <at> gnu.org>; Thu, 09 Jun 2011 18:47:46 +0200
X-Injected-Via-Gmane: http://gmane.org/
Mail-Followup-To: bug-gnu-emacs <at> gnu.org
To: bug-gnu-emacs <at> gnu.org
From: Ted Zlatanov <tzz <at> lifelogs.com>
Subject: Re: bug#8706: 24.0.50; [PATCH] Function to build a URL query-string
Date: Thu, 09 Jun 2011 11:47:32 -0500
Organization: =?utf-8?B?0KLQtdC+0LTQvtGAINCX0LvQsNGC0LDQvdC+0LI=?= @ Cienfuegos
Lines: 148
Message-ID: <87boy7kl3v.fsf <at> lifelogs.com>
References: <m2aaehrzeu.fsf <at> gmail.com> <87d3j932n7.fsf <at> lifelogs.com>
<87zkmaopfs.fsf <at> lifelogs.com>
<91C69C7A-1980-4AF4-9B4B-4AFDB16D2C0B <at> simplegeo.com>
<87y61uldyj.fsf <at> lifelogs.com>
<70084BE3-710F-47B6-8949-B420F5BF47B4 <at> simplegeo.com>
<87d3ip1nau.fsf <at> lifelogs.com>
Mime-Version: 1.0
Content-Type: multipart/mixed; boundary="=-=-="
X-Complaints-To: usenet <at> dough.gmane.org
X-Gmane-NNTP-Posting-Host: c-67-186-102-106.hsd1.il.comcast.net
X-Face: bd.DQ~'29fIs`T_%O%C\g%6jW)yi[zuz6;
d4V0`@y-~$#3P_Ng{@m+e4o<4P'#(_GJQ%TT=
D}[Ep*b!\e,fBZ'j_+#"Ps?s2!4H2-Y"sx"
Mail-Copies-To: never
User-Agent: Gnus/5.110018 (No Gnus v0.18) Emacs/24.0.50 (gnu/linux)
Cancel-Lock: sha1:IJAjAIWrMvheLXZmBb6jQ1w2MmI=
X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.6 (newer, 3)
X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.6 (newer, 3)
X-Received-From: 140.186.70.17
X-Spam-Score: -6.1 (------)
X-Debbugs-Envelope-To: submit
X-BeenThere: debbugs-submit <at> debbugs.gnu.org
X-Mailman-Version: 2.1.11
Precedence: list
Reply-To: bug-gnu-emacs <at> gnu.org
List-Id: <debbugs-submit.debbugs.gnu.org>
List-Unsubscribe: <http://debbugs.gnu.org/cgi-bin/mailman/options/debbugs-submit>,
<mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=unsubscribe>
List-Archive: <http://debbugs.gnu.org/pipermail/debbugs-submit>
List-Post: <mailto:debbugs-submit <at> debbugs.gnu.org>
List-Help: <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=help>
List-Subscribe: <http://debbugs.gnu.org/cgi-bin/mailman/listinfo/debbugs-submit>,
<mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=subscribe>
Sender: debbugs-submit-bounces <at> debbugs.gnu.org
Errors-To: debbugs-submit-bounces <at> debbugs.gnu.org
X-Spam-Score: -6.0 (------)
--=-=-=
Content-Type: text/plain
Attached is a patch which:
- adds optional SEMICOLONS and KEEP-EMPTY to `url-build-query-string' to
separate parameters with semicolons and to keep empty values
- fixes `url-parse-query-string' to understand the '=' is not required
in a parameter
- adds ERT tests for `url-build-query-string' and
`url-parse-query-string'
Ian, if you could look it over, I'd appreciate it. In particular if you
think KEEP-EMPTY should be the default or if you see any other problems...
Thanks
Ted
--=-=-=
Content-Type: text/x-diff
Content-Disposition: inline; filename=url-build-and-parse.patch
=== modified file 'lisp/url/url-util.el'
--- lisp/url/url-util.el 2011-01-25 04:08:28 +0000
+++ lisp/url/url-util.el 2011-06-09 16:43:39 +0000
@@ -26,7 +26,8 @@
(require 'url-parse)
(require 'url-vars)
-(eval-when-compile (require 'cl))
+(eval-when-compile (require 'cl)
+ (require 'ert))
(autoload 'timezone-parse-date "timezone")
(autoload 'timezone-make-date-arpa-standard "timezone")
(autoload 'mail-header-extract "mailheader")
@@ -263,24 +264,65 @@
;;;###autoload
(defun url-parse-query-string (query &optional downcase allow-newlines)
(let (retval pairs cur key val)
- (setq pairs (split-string query "&"))
+ (setq pairs (split-string query "[;&]"))
(while pairs
(setq cur (car pairs)
pairs (cdr pairs))
- (if (not (string-match "=" cur))
- nil ; Grace
- (setq key (url-unhex-string (substring cur 0 (match-beginning 0))
- allow-newlines))
- (setq val (url-unhex-string (substring cur (match-end 0) nil)
- allow-newlines))
- (if downcase
- (setq key (downcase key)))
- (setq cur (assoc key retval))
- (if cur
- (setcdr cur (cons val (cdr cur)))
- (setq retval (cons (list key val) retval)))))
+ (unless (string-match "=" cur)
+ (setq cur (concat cur "=")))
+
+ (when (string-match "=" cur)
+ (setq key (url-unhex-string (substring cur 0 (match-beginning 0))
+ allow-newlines))
+ (setq val (url-unhex-string (substring cur (match-end 0) nil)
+ allow-newlines))
+ (if downcase
+ (setq key (downcase key)))
+ (setq cur (assoc key retval))
+ (if cur
+ (setcdr cur (cons val (cdr cur)))
+ (setq retval (cons (list key val) retval)))))
retval))
+;;;###autoload
+(defun url-build-query-string (query &optional semicolons keep-empty)
+ "Build a query-string.
+
+Given a QUERY in the form:
+'((key1 val1)
+ (key2 val2)
+ (key3 val1 val2)
+ (key4)
+ (key5 ""))
+
+\(This is the same format as produced by `url-parse-query-string')
+
+This will return a string
+\"key1=val1&key2=val2&key3=val1&key3=val2&key4&key5\". Keys may
+be strings or symbols; if they are symbols, the symbol name will
+be used.
+
+When SEMICOLONS is given, the separator will be \";\".
+
+When KEEP-EMPTY is given, empty values will show as \"key=\"
+instead of just \"key\" as in the example above."
+ (mapconcat
+ (lambda (key-vals)
+ (let ((escaped
+ (mapcar (lambda (sym)
+ (url-hexify-string (format "%s" sym))) key-vals)))
+ (mapconcat (lambda (val)
+ (let ((vprint (format "%s" val))
+ (eprint (format "%s" (car escaped))))
+ (concat eprint
+ (if (or keep-empty
+ (and val (not (zerop (length vprint)))))
+ "="
+ "")
+ vprint)))
+ (or (cdr escaped) '("")) (if semicolons ";" "&"))))
+ query (if semicolons ";" "&")))
+
(defun url-unhex (x)
(if (> x ?9)
(if (>= x ?a)
@@ -529,6 +571,27 @@
(error "Danger: `%s' is a symbolic link" file))
(set-file-modes file #o0600))))
+(ert-deftest url-build-and-parse-query-string ()
+ (let ((tests
+ '(("key1=val1&key2=val2&key3=val1&key3=val2&key4&key5"
+ ((key1 val1) (key2 "val2") (key3 val1 val2) (key4) (key5 "")))
+ ("key1=val1;key2=val2;key3=val1;key3=val2;key4;key5"
+ ((key1 "val1") (key2 val2) (key3 val1 val2) ("key4") (key5 "")) t)
+ ("key1=val1;key2=val2;key3=val1;key3=val2;key4=;key5="
+ ((key1 val1) (key2 val2) ("key3" val1 val2) (key4) (key5 "")) t t)))
+ test)
+ (while tests
+ (setq test (car tests)
+ tests (cdr tests))
+ (should (equal (apply 'url-build-query-string (cdr test)) (car test)))))
+ (should (equal (url-parse-query-string
+ "key1=val1&key2=val2&key3=val1&key3=val2&key4=&key5")
+ '(("key5" "")
+ ("key4" "")
+ ("key3" "val2" "val1")
+ ("key2" "val2")
+ ("key1" "val1")))))
+
(provide 'url-util)
;;; url-util.el ends here
--=-=-=--
owner <at> debbugs.gnu.org:bug#8706; Package emacs.
Full text available.
Received: (at 8706) by debbugs.gnu.org; 7 Jun 2011 18:58:27 +0000
From debbugs-submit-bounces <at> debbugs.gnu.org Tue Jun 07 14:58:27 2011
Received: from localhost ([127.0.0.1] helo=debbugs.gnu.org)
by debbugs.gnu.org with esmtp (Exim 4.69)
(envelope-from <debbugs-submit-bounces <at> debbugs.gnu.org>)
id 1QU1Tu-0006Vg-Lb
for submit <at> debbugs.gnu.org; Tue, 07 Jun 2011 14:58:26 -0400
Received: from chirelay1o.jumptrading.com ([38.98.147.153]
helo=chirelay1.jumptrading.com)
by debbugs.gnu.org with esmtp (Exim 4.69)
(envelope-from <tzz <at> lifelogs.com>) id 1QU1Tt-0006VU-82
for 8706 <at> debbugs.gnu.org; Tue, 07 Jun 2011 14:58:25 -0400
Received: from chirelay1.jumptrading.com (unknown [127.0.0.1])
by chirelay1.jumptrading.com (Symantec Mail Security) with ESMTP id
93E83320025
for <8706 <at> debbugs.gnu.org>; Tue, 7 Jun 2011 13:58:19 -0500 (CDT)
X-AuditID: 26629395-a42d8bb0000048db-aa-4dee74cb805d
Received: from chiexchange02.w2k.jumptrading.com (unknown [38.98.147.140])
by chirelay1.jumptrading.com (Symantec Mail Security) with ESMTP id
694F02DC005
for <8706 <at> debbugs.gnu.org>; Tue, 7 Jun 2011 13:58:19 -0500 (CDT)
Received: from internalsmtp.w2k.jumptrading.com (10.2.4.29) by
chiexchange02.w2k.jumptrading.com (10.2.4.71) with Microsoft SMTP
Server id 8.1.291.1; Tue, 7 Jun 2011 13:58:18 -0500
Received: from tzlatanov-ubuntu-desktop.jumptrading.com ([10.2.14.81]) by
internalsmtp.w2k.jumptrading.com with Microsoft SMTPSVC(6.0.3790.1830);
Tue, 7 Jun 2011 13:58:18 -0500
From: Ted Zlatanov <tzz <at> lifelogs.com>
Subject: Re: bug#8706: 24.0.50; [PATCH] Function to build a URL query-string
Organization: =?utf-8?B?0KLQtdC+0LTQvtGAINCX0LvQsNGC0LDQvdC+0LI=?= @ Cienfuegos
References: <m2aaehrzeu.fsf <at> gmail.com> <87d3j932n7.fsf <at> lifelogs.com>
<87zkmaopfs.fsf <at> lifelogs.com>
<91C69C7A-1980-4AF4-9B4B-4AFDB16D2C0B <at> simplegeo.com>
<87y61uldyj.fsf <at> lifelogs.com>
<70084BE3-710F-47B6-8949-B420F5BF47B4 <at> simplegeo.com>
X-Face: bd.DQ~'29fIs`T_%O%C\g%6jW)yi[zuz6;
d4V0`@y-~$#3P_Ng{@m+e4o<4P'#(_GJQ%TT=
D}[Ep*b!\e,fBZ'j_+#"Ps?s2!4H2-Y"sx"
Date: Tue, 7 Jun 2011 13:58:17 -0500
In-Reply-To: <70084BE3-710F-47B6-8949-B420F5BF47B4 <at> simplegeo.com> (Ian Eure's
message of "Tue, 7 Jun 2011 10:07:40 -0700")
Message-ID: <87d3ip1nau.fsf <at> lifelogs.com>
User-Agent: Gnus/5.110018 (No Gnus v0.18) Emacs/24.0.50 (gnu/linux)
MIME-Version: 1.0
Content-Type: text/plain
X-OriginalArrivalTime: 07 Jun 2011 18:58:18.0724 (UTC)
FILETIME=[DD45BA40:01CC2544]
X-Brightmail-Tracker: AAAAAA==
X-Spam-Score: -2.2 (--)
X-Debbugs-Envelope-To: 8706
Cc: Ian Eure <ian <at> simplegeo.com>, 8706 <at> debbugs.gnu.org
X-BeenThere: debbugs-submit <at> debbugs.gnu.org
X-Mailman-Version: 2.1.11
Precedence: list
List-Id: <debbugs-submit.debbugs.gnu.org>
List-Unsubscribe: <http://debbugs.gnu.org/cgi-bin/mailman/options/debbugs-submit>,
<mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=unsubscribe>
List-Archive: <http://debbugs.gnu.org/pipermail/debbugs-submit>
List-Post: <mailto:debbugs-submit <at> debbugs.gnu.org>
List-Help: <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=help>
List-Subscribe: <http://debbugs.gnu.org/cgi-bin/mailman/listinfo/debbugs-submit>,
<mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=subscribe>
Sender: debbugs-submit-bounces <at> debbugs.gnu.org
Errors-To: debbugs-submit-bounces <at> debbugs.gnu.org
X-Spam-Score: -2.2 (--)
On Tue, 7 Jun 2011 10:07:40 -0700 Ian Eure <ian <at> simplegeo.com> wrote:
IE> On May 25, 2011, at 1:31 PM, Ted Zlatanov wrote:
>> Single-element parameters, shown as just "key" instead of "key=val", are
>> a well-known URL query string convention. They are not opaque. I think
>> they should be explicitly supported.
>>
IE> As I said, they _are_ supported. You just have to explicitly pass an empty string in the pair:
(url-build-query-string '(("a" "b") ("c" "") (d)))
=> "a=b&c=&d="
IE> I believe this is the correct behavior.
You're right, it's not incorrect, but it's not optimal. The extra "="
can be safely omitted and it's preferrable to do so (for readability and
to save bytes). Maybe that could be optional behavior.
Also we could add an option to make ";" the separator (though the
default should still be "&").
IE> It's also precisely what url-parse-query-string returns:
IE> (url-parse-query-string "a=b&c=") -> (("c" "") ("a" "b"))
It's actually broken for valid URLs: (url-parse-query-string "a=b&c")
=> (("a" "b"))
Plus it doesn't support the ";" separator.
Ugh. Sorry to be a pain... but it's broken...
IE> Here's an updated patch which should correctly support everything
IE> url-parse-query-string produces. I also updated it to allow empty
IE> keys, as this was fairly easy with the code refactored to support
IE> (key val val val) syntax.
That all works great (I see it in the first example above).
Let me know how much of the above you want to do; I can implement all
the things I asked for if you're too busy. I appreciate your help.
Thanks
Ted
owner <at> debbugs.gnu.org, bug-gnu-emacs <at> gnu.org:bug#8706; Package emacs.
Full text available.
Received: (at 8706) by debbugs.gnu.org; 7 Jun 2011 18:12:25 +0000
From debbugs-submit-bounces <at> debbugs.gnu.org Tue Jun 07 14:12:25 2011
Received: from localhost ([127.0.0.1] helo=debbugs.gnu.org)
by debbugs.gnu.org with esmtp (Exim 4.69)
(envelope-from <debbugs-submit-bounces <at> debbugs.gnu.org>)
id 1QU0lM-0005UU-KM
for submit <at> debbugs.gnu.org; Tue, 07 Jun 2011 14:12:24 -0400
Received: from fencepost.gnu.org ([140.186.70.10])
by debbugs.gnu.org with esmtp (Exim 4.69)
(envelope-from <monnier <at> iro.umontreal.ca>) id 1QU0lK-0005UJ-Pc
for 8706 <at> debbugs.gnu.org; Tue, 07 Jun 2011 14:12:23 -0400
Received: from 121-249-126-200.fibertel.com.ar ([200.126.249.121]:62352
helo=ceviche.home)
by fencepost.gnu.org with esmtpsa (TLS1.0:DHE_RSA_AES_256_CBC_SHA1:32)
(Exim 4.71) (envelope-from <monnier <at> iro.umontreal.ca>)
id 1QU0lE-0001HV-TH; Tue, 07 Jun 2011 14:12:17 -0400
Received: by ceviche.home (Postfix, from userid 20848)
id 4900A660DD; Tue, 7 Jun 2011 15:12:14 -0300 (ART)
From: Stefan Monnier <monnier <at> iro.umontreal.ca>
To: Ian Eure <ian <at> simplegeo.com>
Subject: Re: bug#8706: 24.0.50; [PATCH] Function to build a URL query-string
Message-ID: <jwvsjrlzf86.fsf-monnier+emacs <at> gnu.org>
References: <m2aaehrzeu.fsf <at> gmail.com> <87d3j932n7.fsf <at> lifelogs.com>
<87zkmaopfs.fsf <at> lifelogs.com>
<91C69C7A-1980-4AF4-9B4B-4AFDB16D2C0B <at> simplegeo.com>
<87y61uldyj.fsf <at> lifelogs.com>
<70084BE3-710F-47B6-8949-B420F5BF47B4 <at> simplegeo.com>
Date: Tue, 07 Jun 2011 15:12:14 -0300
In-Reply-To: <70084BE3-710F-47B6-8949-B420F5BF47B4 <at> simplegeo.com> (Ian Eure's
message of "Tue, 7 Jun 2011 10:07:40 -0700")
User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/24.0.50 (gnu/linux)
MIME-Version: 1.0
Content-Type: text/plain
X-Spam-Score: -6.0 (------)
X-Debbugs-Envelope-To: 8706
Cc: Ted Zlatanov <tzz <at> lifelogs.com>, 8706 <at> debbugs.gnu.org
X-BeenThere: debbugs-submit <at> debbugs.gnu.org
X-Mailman-Version: 2.1.11
Precedence: list
List-Id: <debbugs-submit.debbugs.gnu.org>
List-Unsubscribe: <http://debbugs.gnu.org/cgi-bin/mailman/options/debbugs-submit>,
<mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=unsubscribe>
List-Archive: <http://debbugs.gnu.org/pipermail/debbugs-submit>
List-Post: <mailto:debbugs-submit <at> debbugs.gnu.org>
List-Help: <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=help>
List-Subscribe: <http://debbugs.gnu.org/cgi-bin/mailman/listinfo/debbugs-submit>,
<mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=subscribe>
Sender: debbugs-submit-bounces <at> debbugs.gnu.org
Errors-To: debbugs-submit-bounces <at> debbugs.gnu.org
X-Spam-Score: -6.0 (------)
> (url-parse-query-string "a=b&c=") -> (("c" "") ("a" "b"))
The question at hand is different and relates to what is returned by
(url-parse-query-string "a&c") which happens to be nil. Not sure if
that's right, tho.
> Here's an updated patch which should correctly support everything
> url-parse-query-string produces. I also updated it to allow empty
> keys, as this was fairly easy with the code refactored to support (key
> val val val) syntax.
> +symbols; if they are symbols, the string name will be used."
^^^^^^
symbol
-- Stefan
owner <at> debbugs.gnu.org, bug-gnu-emacs <at> gnu.org:bug#8706; Package emacs.
Full text available.
Received: (at 8706) by debbugs.gnu.org; 7 Jun 2011 17:07:50 +0000
From debbugs-submit-bounces <at> debbugs.gnu.org Tue Jun 07 13:07:50 2011
Received: from localhost ([127.0.0.1] helo=debbugs.gnu.org)
by debbugs.gnu.org with esmtp (Exim 4.69)
(envelope-from <debbugs-submit-bounces <at> debbugs.gnu.org>)
id 1QTzkr-0003F3-Uh
for submit <at> debbugs.gnu.org; Tue, 07 Jun 2011 13:07:50 -0400
Received: from mail-px0-f170.google.com ([209.85.212.170])
by debbugs.gnu.org with esmtp (Exim 4.69)
(envelope-from <ian <at> simplegeo.com>) id 1QTzkq-0003Er-9W
for 8706 <at> debbugs.gnu.org; Tue, 07 Jun 2011 13:07:49 -0400
Received: by pxi19 with SMTP id 19so4129687pxi.29
for <8706 <at> debbugs.gnu.org>; Tue, 07 Jun 2011 10:07:42 -0700 (PDT)
Received: by 10.68.65.110 with SMTP id w14mr266191pbs.382.1307466462355;
Tue, 07 Jun 2011 10:07:42 -0700 (PDT)
Received: from [10.0.1.153] (c-76-104-208-94.hsd1.wa.comcast.net
[76.104.208.94])
by mx.google.com with ESMTPS id y2sm262398pbg.72.2011.06.07.10.07.41
(version=TLSv1/SSLv3 cipher=OTHER);
Tue, 07 Jun 2011 10:07:41 -0700 (PDT)
Subject: Re: bug#8706: 24.0.50; [PATCH] Function to build a URL query-string
Mime-Version: 1.0 (Apple Message framework v1084)
Content-Type: text/plain; charset=us-ascii
From: Ian Eure <ian <at> simplegeo.com>
In-Reply-To: <87y61uldyj.fsf <at> lifelogs.com>
Date: Tue, 7 Jun 2011 10:07:40 -0700
Content-Transfer-Encoding: quoted-printable
Message-Id: <70084BE3-710F-47B6-8949-B420F5BF47B4 <at> simplegeo.com>
References: <m2aaehrzeu.fsf <at> gmail.com> <87d3j932n7.fsf <at> lifelogs.com>
<87zkmaopfs.fsf <at> lifelogs.com>
<91C69C7A-1980-4AF4-9B4B-4AFDB16D2C0B <at> simplegeo.com>
<87y61uldyj.fsf <at> lifelogs.com>
To: Ted Zlatanov <tzz <at> lifelogs.com>
X-Mailer: Apple Mail (2.1084)
X-Spam-Score: -4.8 (----)
X-Debbugs-Envelope-To: 8706
Cc: 8706 <at> debbugs.gnu.org
X-BeenThere: debbugs-submit <at> debbugs.gnu.org
X-Mailman-Version: 2.1.11
Precedence: list
List-Id: <debbugs-submit.debbugs.gnu.org>
List-Unsubscribe: <http://debbugs.gnu.org/cgi-bin/mailman/options/debbugs-submit>,
<mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=unsubscribe>
List-Archive: <http://debbugs.gnu.org/pipermail/debbugs-submit>
List-Post: <mailto:debbugs-submit <at> debbugs.gnu.org>
List-Help: <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=help>
List-Subscribe: <http://debbugs.gnu.org/cgi-bin/mailman/listinfo/debbugs-submit>,
<mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=subscribe>
Sender: debbugs-submit-bounces <at> debbugs.gnu.org
Errors-To: debbugs-submit-bounces <at> debbugs.gnu.org
X-Spam-Score: -4.6 (----)
Apologies for the late response, I got distracted by other things.
On May 25, 2011, at 1:31 PM, Ted Zlatanov wrote:
> On Wed, 25 May 2011 09:32:15 -0700 Ian Eure <ian <at> simplegeo.com> wrote:=20=
>=20
> IE> 1. Two-element sequences should work as they do now.
> IE> 2. One-element sequences should get an empty string appended.
> IE> 3. Invalid sequences ignored.
>=20
> IE> I'm not sure it makes sense to support #2, since it seems somewhat
> IE> opaque and you can do the same thing with an empty string in =
scenario
> IE> #1.=20
>=20
> Single-element parameters, shown as just "key" instead of "key=3Dval", =
are
> a well-known URL query string convention. They are not opaque. I =
think
> they should be explicitly supported.
>=20
As I said, they _are_ supported. You just have to explicitly pass an =
empty string in the pair:
(url-build-query-string '(("a" "b") ("c" "")) -> "a=3Db&c=3D"
I believe this is the correct behavior. It's also precisely what =
url-parse-query-string returns:
(url-parse-query-string "a=3Db&c=3D") -> (("c" "") ("a" "b"))
This is also relevant to Stefan's comment. All else being equal, I think =
we should support the same conventions it does. The one issue I =
discovered is how it handles sending multiple values for the same key. =
Given "a=3Done&a=3Dtwo", it returns: (("a" "one" "two")), which my =
previous iterations don't know what to do with.
Here's an updated patch which should correctly support everything =
url-parse-query-string produces. I also updated it to allow empty keys, =
as this was fairly easy with the code refactored to support (key val val =
val) syntax.
Updated patch:
--- url-util.el.orig 2011-06-07 09:56:36.000000000 -0700
+++ url-util.el 2011-06-07 10:06:09.000000000 -0700
@@ -281,6 +281,31 @@
(setq retval (cons (list key val) retval)))))
retval))
=20
+;;;###autoload
+(defun url-build-query-string (query)
+ "Build a query-string.
+
+Given a QUERY in the form:
+'((key1 val1)
+ (key2 val2)
+ (key3 val1 val2))
+
+\(This is the same format as produced by `url-parse-query-string')
+
+This will return a string
+`key1=3Dval1&key2=3Dval2&key3=3Dval1&key3=3Dval2'. Keys may be strings =
or
+symbols; if they are symbols, the string name will be used."
+
+ (mapconcat
+ (lambda (key-vals)
+ (let ((escaped
+ (mapcar (lambda (sym)
+ (url-hexify-string (format "%s" sym))) =
key-vals)))
+
+ (mapconcat (lambda (val) (format "%s=3D%s" (car escaped) val))
+ (or (cdr escaped) '("")) "&")))
+ query "&"))
+
(defun url-unhex (x)
(if (> x ?9)
(if (>=3D x ?a)=
owner <at> debbugs.gnu.org, bug-gnu-emacs <at> gnu.org:bug#8706; Package emacs.
Full text available.
Received: (at 8706) by debbugs.gnu.org; 26 May 2011 14:42:40 +0000
From debbugs-submit-bounces <at> debbugs.gnu.org Thu May 26 10:42:39 2011
Received: from localhost ([127.0.0.1] helo=debbugs.gnu.org)
by debbugs.gnu.org with esmtp (Exim 4.69)
(envelope-from <debbugs-submit-bounces <at> debbugs.gnu.org>)
id 1QPbln-0005db-A7
for submit <at> debbugs.gnu.org; Thu, 26 May 2011 10:42:39 -0400
Received: from chirelay1o.jumptrading.com ([38.98.147.153]
helo=chirelay1.jumptrading.com)
by debbugs.gnu.org with esmtp (Exim 4.69)
(envelope-from <tzz <at> lifelogs.com>) id 1QPbll-0005dP-5Z
for 8706 <at> debbugs.gnu.org; Thu, 26 May 2011 10:42:37 -0400
Received: from chirelay1.jumptrading.com (unknown [127.0.0.1])
by chirelay1.jumptrading.com (Symantec Mail Security) with ESMTP id
6F375320026
for <8706 <at> debbugs.gnu.org>; Thu, 26 May 2011 09:42:31 -0500 (CDT)
X-AuditID: 26629395-9aa85bb000004473-25-4dde66d74003
Received: from chiexchange02.w2k.jumptrading.com (unknown [38.98.147.140])
by chirelay1.jumptrading.com (Symantec Mail Security) with ESMTP id
35BB32DC007
for <8706 <at> debbugs.gnu.org>; Thu, 26 May 2011 09:42:31 -0500 (CDT)
Received: from internalsmtp.w2k.jumptrading.com (10.2.4.29) by
chiexchange02.w2k.jumptrading.com (10.2.4.71) with Microsoft SMTP
Server id 8.1.291.1; Thu, 26 May 2011 09:33:38 -0500
Received: from tzlatanov-ubuntu-desktop.jumptrading.com ([10.2.14.81]) by
internalsmtp.w2k.jumptrading.com with Microsoft SMTPSVC(6.0.3790.1830);
Thu, 26 May 2011 09:33:38 -0500
From: Ted Zlatanov <tzz <at> lifelogs.com>
To: Ian Eure <ian <at> simplegeo.com>, <8706 <at> debbugs.gnu.org>
Subject: Re: bug#8706: 24.0.50; [PATCH] Function to build a URL query-string
Organization: =?us-ascii?Q?=3D=3Futf-8=3FB=3F0KLQtdC+0LTQvtGAINCX0LvQsNGC0?=
=?us-ascii?Q?LDQvdC+0LI=3D=3F=3D?= @ Cienfuegos
References: <m2aaehrzeu.fsf <at> gmail.com> <87d3j932n7.fsf <at> lifelogs.com>
<87zkmaopfs.fsf <at> lifelogs.com>
<91C69C7A-1980-4AF4-9B4B-4AFDB16D2C0B <at> simplegeo.com>
<jwv1uzme3f6.fsf-monnier+emacs <at> gnu.org>
X-Face: bd.DQ~'29fIs`T_%O%C\g%6jW)yi[zuz6;
d4V0`@y-~$#3P_Ng{@m+e4o<4P'#(_GJQ%TT=
D}[Ep*b!\e,fBZ'j_+#"Ps?s2!4H2-Y"sx"
Date: Thu, 26 May 2011 09:33:37 -0500
In-Reply-To: <jwv1uzme3f6.fsf-monnier+emacs <at> gnu.org> (Stefan Monnier's message
of "Wed, 25 May 2011 21:02:56 -0300")
Message-ID: <87mxi95y66.fsf <at> lifelogs.com>
User-Agent: Gnus/5.110018 (No Gnus v0.18) Emacs/24.0.50 (gnu/linux)
MIME-Version: 1.0
Content-Type: text/plain
X-OriginalArrivalTime: 26 May 2011 14:33:38.0666 (UTC)
FILETIME=[E7102CA0:01CC1BB1]
X-Brightmail-Tracker: AAAAAA==
X-Spam-Score: -2.8 (--)
X-Debbugs-Envelope-To: 8706
X-BeenThere: debbugs-submit <at> debbugs.gnu.org
X-Mailman-Version: 2.1.11
Precedence: list
List-Id: <debbugs-submit.debbugs.gnu.org>
List-Unsubscribe: <http://debbugs.gnu.org/cgi-bin/mailman/options/debbugs-submit>,
<mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=unsubscribe>
List-Archive: <http://debbugs.gnu.org/pipermail/debbugs-submit>
List-Post: <mailto:debbugs-submit <at> debbugs.gnu.org>
List-Help: <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=help>
List-Subscribe: <http://debbugs.gnu.org/cgi-bin/mailman/listinfo/debbugs-submit>,
<mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=subscribe>
Sender: debbugs-submit-bounces <at> debbugs.gnu.org
Errors-To: debbugs-submit-bounces <at> debbugs.gnu.org
X-Spam-Score: -2.8 (--)
On Wed, 25 May 2011 21:02:56 -0300 Stefan Monnier <monnier <at> iro.umontreal.ca> wrote:
>> 1. Two-element sequences should work as they do now.
>> 2. One-element sequences should get an empty string appended.
>> 3. Invalid sequences ignored.
SM> Actually, I think that instead of a (KEY VAL) list, the code should use
SM> a (KEY . VAL) cons cell. And if you want to use VAL=nil as a convention
SM> to put just "key" rather than "key=VAL", that's fine.
Ian, let me know if I should implement that on top of the latest version
you posted. Should be trivial. I look forward to getting it into
Emacs :)
Thanks
Ted
owner <at> debbugs.gnu.org, bug-gnu-emacs <at> gnu.org:bug#8706; Package emacs.
Full text available.
Received: (at 8706) by debbugs.gnu.org; 26 May 2011 00:03:06 +0000
From debbugs-submit-bounces <at> debbugs.gnu.org Wed May 25 20:03:06 2011
Received: from localhost ([127.0.0.1] helo=debbugs.gnu.org)
by debbugs.gnu.org with esmtp (Exim 4.69)
(envelope-from <debbugs-submit-bounces <at> debbugs.gnu.org>)
id 1QPO2c-0000SN-IM
for submit <at> debbugs.gnu.org; Wed, 25 May 2011 20:03:06 -0400
Received: from fencepost.gnu.org ([140.186.70.10])
by debbugs.gnu.org with esmtp (Exim 4.69)
(envelope-from <monnier <at> iro.umontreal.ca>) id 1QPO2b-0000Rt-If
for 8706 <at> debbugs.gnu.org; Wed, 25 May 2011 20:03:05 -0400
Received: from 213-159-126-200.fibertel.com.ar ([200.126.159.213]:54358
helo=ceviche.home)
by fencepost.gnu.org with esmtpsa (TLS1.0:DHE_RSA_AES_256_CBC_SHA1:32)
(Exim 4.71) (envelope-from <monnier <at> iro.umontreal.ca>)
id 1QPO2V-0001RR-Qm; Wed, 25 May 2011 20:03:00 -0400
Received: by ceviche.home (Postfix, from userid 20848)
id 961C26610E; Wed, 25 May 2011 21:02:56 -0300 (ART)
From: Stefan Monnier <monnier <at> iro.umontreal.ca>
To: Ian Eure <ian <at> simplegeo.com>
Subject: Re: bug#8706: 24.0.50; [PATCH] Function to build a URL query-string
Message-ID: <jwv1uzme3f6.fsf-monnier+emacs <at> gnu.org>
References: <m2aaehrzeu.fsf <at> gmail.com> <87d3j932n7.fsf <at> lifelogs.com>
<87zkmaopfs.fsf <at> lifelogs.com>
<91C69C7A-1980-4AF4-9B4B-4AFDB16D2C0B <at> simplegeo.com>
Date: Wed, 25 May 2011 21:02:56 -0300
In-Reply-To: <91C69C7A-1980-4AF4-9B4B-4AFDB16D2C0B <at> simplegeo.com> (Ian Eure's
message of "Wed, 25 May 2011 09:32:15 -0700")
User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/24.0.50 (gnu/linux)
MIME-Version: 1.0
Content-Type: text/plain
X-Spam-Score: -6.0 (------)
X-Debbugs-Envelope-To: 8706
Cc: tzz <at> lifelogs.com, 8706 <at> debbugs.gnu.org
X-BeenThere: debbugs-submit <at> debbugs.gnu.org
X-Mailman-Version: 2.1.11
Precedence: list
List-Id: <debbugs-submit.debbugs.gnu.org>
List-Unsubscribe: <http://debbugs.gnu.org/cgi-bin/mailman/options/debbugs-submit>,
<mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=unsubscribe>
List-Archive: <http://debbugs.gnu.org/pipermail/debbugs-submit>
List-Post: <mailto:debbugs-submit <at> debbugs.gnu.org>
List-Help: <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=help>
List-Subscribe: <http://debbugs.gnu.org/cgi-bin/mailman/listinfo/debbugs-submit>,
<mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=subscribe>
Sender: debbugs-submit-bounces <at> debbugs.gnu.org
Errors-To: debbugs-submit-bounces <at> debbugs.gnu.org
X-Spam-Score: -6.0 (------)
> 1. Two-element sequences should work as they do now.
> 2. One-element sequences should get an empty string appended.
> 3. Invalid sequences ignored.
Actually, I think that instead of a (KEY VAL) list, the code should use
a (KEY . VAL) cons cell. And if you want to use VAL=nil as a convention
to put just "key" rather than "key=VAL", that's fine.
Stefan
owner <at> debbugs.gnu.org, bug-gnu-emacs <at> gnu.org:bug#8706; Package emacs.
Full text available.
Received: (at 8706) by debbugs.gnu.org; 25 May 2011 20:31:26 +0000
From debbugs-submit-bounces <at> debbugs.gnu.org Wed May 25 16:31:26 2011
Received: from localhost ([127.0.0.1] helo=debbugs.gnu.org)
by debbugs.gnu.org with esmtp (Exim 4.69)
(envelope-from <debbugs-submit-bounces <at> debbugs.gnu.org>)
id 1QPKjm-0003u9-EM
for submit <at> debbugs.gnu.org; Wed, 25 May 2011 16:31:26 -0400
Received: from chirelay1o.jumptrading.com ([38.98.147.153]
helo=chirelay1.jumptrading.com)
by debbugs.gnu.org with esmtp (Exim 4.69)
(envelope-from <tzz <at> lifelogs.com>) id 1QPKjk-0003ty-NG
for 8706 <at> debbugs.gnu.org; Wed, 25 May 2011 16:31:25 -0400
Received: from chirelay1.jumptrading.com (unknown [127.0.0.1])
by chirelay1.jumptrading.com (Symantec Mail Security) with ESMTP id
127E632003E
for <8706 <at> debbugs.gnu.org>; Wed, 25 May 2011 15:31:19 -0500 (CDT)
X-AuditID: 26629395-9b166bb0000049d2-6c-4ddd67160b6a
Received: from chiexchange02.w2k.jumptrading.com (unknown [38.98.147.140])
by chirelay1.jumptrading.com (Symantec Mail Security) with ESMTP id
C54992DC006
for <8706 <at> debbugs.gnu.org>; Wed, 25 May 2011 15:31:18 -0500 (CDT)
Received: from internalsmtp.w2k.jumptrading.com (10.2.4.29) by
chiexchange02.w2k.jumptrading.com (10.2.4.71) with Microsoft SMTP
Server id 8.1.291.1; Wed, 25 May 2011 15:31:18 -0500
Received: from tzlatanov-ubuntu-desktop.jumptrading.com ([10.2.14.81]) by
internalsmtp.w2k.jumptrading.com with Microsoft SMTPSVC(6.0.3790.1830);
Wed, 25 May 2011 15:31:18 -0500
From: Ted Zlatanov <tzz <at> lifelogs.com>
To: Ian Eure <ian <at> simplegeo.com>, <8706 <at> debbugs.gnu.org>
Subject: Re: bug#8706: 24.0.50; [PATCH] Function to build a URL query-string
Organization: =?us-ascii?Q?=3D=3Futf-8=3FB=3F0KLQtdC+0LTQvtGAINCX0LvQsNGC0?=
=?us-ascii?Q?LDQvdC+0LI=3D=3F=3D?= @ Cienfuegos
References: <m2aaehrzeu.fsf <at> gmail.com> <87d3j932n7.fsf <at> lifelogs.com>
<87zkmaopfs.fsf <at> lifelogs.com>
<91C69C7A-1980-4AF4-9B4B-4AFDB16D2C0B <at> simplegeo.com>
X-Face: bd.DQ~'29fIs`T_%O%C\g%6jW)yi[zuz6;
d4V0`@y-~$#3P_Ng{@m+e4o<4P'#(_GJQ%TT=
D}[Ep*b!\e,fBZ'j_+#"Ps?s2!4H2-Y"sx"
Date: Wed, 25 May 2011 15:31:16 -0500
In-Reply-To: <91C69C7A-1980-4AF4-9B4B-4AFDB16D2C0B <at> simplegeo.com> (Ian Eure's
message of "Wed, 25 May 2011 09:32:15 -0700")
Message-ID: <87y61uldyj.fsf <at> lifelogs.com>
User-Agent: Gnus/5.110018 (No Gnus v0.18) Emacs/24.0.50 (gnu/linux)
MIME-Version: 1.0
Content-Type: text/plain
X-OriginalArrivalTime: 25 May 2011 20:31:18.0270 (UTC)
FILETIME=[B39221E0:01CC1B1A]
X-Brightmail-Tracker: AAAAAA==
X-Spam-Score: -2.8 (--)
X-Debbugs-Envelope-To: 8706
X-BeenThere: debbugs-submit <at> debbugs.gnu.org
X-Mailman-Version: 2.1.11
Precedence: list
List-Id: <debbugs-submit.debbugs.gnu.org>
List-Unsubscribe: <http://debbugs.gnu.org/cgi-bin/mailman/options/debbugs-submit>,
<mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=unsubscribe>
List-Archive: <http://debbugs.gnu.org/pipermail/debbugs-submit>
List-Post: <mailto:debbugs-submit <at> debbugs.gnu.org>
List-Help: <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=help>
List-Subscribe: <http://debbugs.gnu.org/cgi-bin/mailman/listinfo/debbugs-submit>,
<mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=subscribe>
Sender: debbugs-submit-bounces <at> debbugs.gnu.org
Errors-To: debbugs-submit-bounces <at> debbugs.gnu.org
X-Spam-Score: -2.8 (--)
On Wed, 25 May 2011 09:32:15 -0700 Ian Eure <ian <at> simplegeo.com> wrote:
IE> 1. Two-element sequences should work as they do now.
IE> 2. One-element sequences should get an empty string appended.
IE> 3. Invalid sequences ignored.
IE> I'm not sure it makes sense to support #2, since it seems somewhat
IE> opaque and you can do the same thing with an empty string in scenario
IE> #1.
Single-element parameters, shown as just "key" instead of "key=val", are
a well-known URL query string convention. They are not opaque. I think
they should be explicitly supported.
IE> #3 I'm not sure how to do without using remove-if from cl-seq.
IE> I don't know why someone would pass in nil in place of a k/v pair, and
IE> it seems better to raise an error about that rather than silently
IE> accepting it, since it seems likely to be an error in the calling
IE> code.
OK, let's make #3 an error. That works for me. Can you just comment on
it in the source so it's clear we punt to the caller?
Thanks!
Ted
owner <at> debbugs.gnu.org, bug-gnu-emacs <at> gnu.org:bug#8706; Package emacs.
Full text available.
Received: (at submit) by debbugs.gnu.org; 25 May 2011 18:09:27 +0000
From debbugs-submit-bounces <at> debbugs.gnu.org Wed May 25 14:09:27 2011
Received: from localhost ([127.0.0.1] helo=debbugs.gnu.org)
by debbugs.gnu.org with esmtp (Exim 4.69)
(envelope-from <debbugs-submit-bounces <at> debbugs.gnu.org>)
id 1QPIWM-00084O-Md
for submit <at> debbugs.gnu.org; Wed, 25 May 2011 14:09:27 -0400
Received: from eggs.gnu.org ([140.186.70.92])
by debbugs.gnu.org with esmtp (Exim 4.69)
(envelope-from <ian <at> simplegeo.com>) id 1QPIWC-00083D-Is
for submit <at> debbugs.gnu.org; Wed, 25 May 2011 14:09:17 -0400
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
(envelope-from <ian <at> simplegeo.com>) id 1QPH0Q-0007kD-Kd
for submit <at> debbugs.gnu.org; Wed, 25 May 2011 12:32:23 -0400
X-Spam-Checker-Version: SpamAssassin 3.3.1 (2010-03-16) on eggs.gnu.org
X-Spam-Level:
X-Spam-Status: No, score=-2.6 required=5.0 tests=BAYES_00,RCVD_IN_DNSWL_LOW
autolearn=unavailable version=3.3.1
Received: from lists.gnu.org ([140.186.70.17]:59148)
by eggs.gnu.org with esmtp (Exim 4.71)
(envelope-from <ian <at> simplegeo.com>) id 1QPH0Q-0007k9-J5
for submit <at> debbugs.gnu.org; Wed, 25 May 2011 12:32:22 -0400
Received: from eggs.gnu.org ([140.186.70.92]:43055)
by lists.gnu.org with esmtp (Exim 4.71)
(envelope-from <ian <at> simplegeo.com>) id 1QPH0P-0005uF-EL
for bug-gnu-emacs <at> gnu.org; Wed, 25 May 2011 12:32:22 -0400
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
(envelope-from <ian <at> simplegeo.com>) id 1QPH0O-0007jk-74
for bug-gnu-emacs <at> gnu.org; Wed, 25 May 2011 12:32:21 -0400
Received: from mail-px0-f171.google.com ([209.85.212.171]:56002)
by eggs.gnu.org with esmtp (Exim 4.71)
(envelope-from <ian <at> simplegeo.com>) id 1QPH0N-0007jd-Uf
for bug-gnu-emacs <at> gnu.org; Wed, 25 May 2011 12:32:20 -0400
Received: by pxi7 with SMTP id 7so5257171pxi.30
for <bug-gnu-emacs <at> gnu.org>; Wed, 25 May 2011 09:32:18 -0700 (PDT)
Received: by 10.68.0.227 with SMTP id 3mr3435632pbh.284.1306341138356;
Wed, 25 May 2011 09:32:18 -0700 (PDT)
Received: from [10.0.1.153] (c-76-104-208-94.hsd1.wa.comcast.net
[76.104.208.94])
by mx.google.com with ESMTPS id t9sm5766793pbo.3.2011.05.25.09.32.16
(version=TLSv1/SSLv3 cipher=OTHER);
Wed, 25 May 2011 09:32:17 -0700 (PDT)
Content-Type: text/plain; charset=windows-1252
Mime-Version: 1.0 (Apple Message framework v1084)
Subject: Re: bug#8706: 24.0.50; [PATCH] Function to build a URL query-string
From: Ian Eure <ian <at> simplegeo.com>
In-Reply-To: <87zkmaopfs.fsf <at> lifelogs.com>
Date: Wed, 25 May 2011 09:32:15 -0700
Content-Transfer-Encoding: quoted-printable
Message-Id: <91C69C7A-1980-4AF4-9B4B-4AFDB16D2C0B <at> simplegeo.com>
References: <m2aaehrzeu.fsf <at> gmail.com> <87d3j932n7.fsf <at> lifelogs.com>
<87zkmaopfs.fsf <at> lifelogs.com>
To: Ted Zlatanov <tzz <at> lifelogs.com>,
bug-gnu-emacs <at> gnu.org
X-Mailer: Apple Mail (2.1084)
X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.6 (newer, 2)
X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.6 (newer, 3)
X-Received-From: 140.186.70.17
X-Spam-Score: -6.0 (------)
X-Debbugs-Envelope-To: submit
X-BeenThere: debbugs-submit <at> debbugs.gnu.org
X-Mailman-Version: 2.1.11
Precedence: list
List-Id: <debbugs-submit.debbugs.gnu.org>
List-Unsubscribe: <http://debbugs.gnu.org/cgi-bin/mailman/options/debbugs-submit>,
<mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=unsubscribe>
List-Archive: <http://debbugs.gnu.org/pipermail/debbugs-submit>
List-Post: <mailto:debbugs-submit <at> debbugs.gnu.org>
List-Help: <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=help>
List-Subscribe: <http://debbugs.gnu.org/cgi-bin/mailman/listinfo/debbugs-submit>,
<mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=subscribe>
Sender: debbugs-submit-bounces <at> debbugs.gnu.org
Errors-To: debbugs-submit-bounces <at> debbugs.gnu.org
X-Spam-Score: -6.0 (------)
On May 25, 2011, at 6:55 AM, Ted Zlatanov wrote:
> Ian, did you see my followup?
>=20
I didn't; I'm not on the list, so I only get direct replies.=09
> On Mon, 23 May 2011 09:36:12 -0500 Ted Zlatanov <tzz <at> lifelogs.com> =
wrote:=20
>=20
> TZ> On Fri, 20 May 2011 11:37:45 -0700 Ian Eure <ian <at> simplegeo.com> =
wrote:=20
> IE> This patch adds a url-build-query-string method, which performs =
the
> IE> opposite job of url-parse-query-string. I find myself needing this
> IE> method in many projects, and having it in url-util.el seems
> IE> beneficial.
>=20
> TZ> I think this is useful.
>=20
> IE> + (c-concat-separated
> IE> + (mapcar (lambda (pair) (apply 'format "%s=3D%s" pair)) query) =
"&"))
>=20
> TZ> I would use `mapconcat' (it's what `c-concat-separated' uses under =
the
> TZ> hood anyhow).
>=20
Done.
> TZ> Also `format' errors out if it doesn't have enough arguments and =
it's
> TZ> legitimate to build a URL query like "url?x;y;z" where x, y, and z =
don't
> TZ> have values. So I would change the lambda to (untested):
>=20
> TZ> (lambda (pair)
> TZ> (if (nth 1 pair)
> TZ> (apply 'format "%s=3D%s" pair)
> TZ> (format "%s" (car-safe pair))))
>=20
> TZ> This also handles the case where `pair' is nil by design or by =
accident.
>=20
You can do this by passing a sequence such as '((x "")), which results =
in "x=3D". I think this is fine, since this mirrors what you're actually =
doing =97 sending an empty string. I think if we wanted to accept lots =
of different formats, we'd need to do something like:
1. Two-element sequences should work as they do now.
2. One-element sequences should get an empty string appended.
3. Invalid sequences ignored.
I'm not sure it makes sense to support #2, since it seems somewhat =
opaque and you can do the same thing with an empty string in scenario =
#1. #3 I'm not sure how to do without using remove-if from cl-seq.
I don't know why someone would pass in nil in place of a k/v pair, and =
it seems better to raise an error about that rather than silently =
accepting it, since it seems likely to be an error in the calling code.
I'm happy to discuss further if you think there's a good reason to =
change it, but I feel like this iteration is acceptable.
> TZ> Finally, the key and the value should be URL-encoded. Do you =
assume
> TZ> that will be done before the function is called?
>=20
An oversight on my part; an updated patch is attached. Thank you for the =
feedback.
--- url-util.el.orig 2011-05-25 09:09:03.000000000 -0700
+++ url-util.el 2011-05-25 09:09:47.000000000 -0700
@@ -281,6 +281,25 @@
(setq retval (cons (list key val) retval)))))
retval))
=20
+;;;###autoload
+(defun url-build-query-string (query)
+ "Build a query-string.
+
+Given a QUERY in the form:
+'((key1 val1)
+ (key2 val2))
+
+This will return a string `key1=3Dval1&key2=3Dval2'. Keys may be =
strings
+or symbols; if they are symbols, the string name will be used."
+
+ (mapconcat
+ (lambda (pair)
+ (apply 'format "%s=3D%s"
+ (mapcar
+ (lambda (sym)
+ (url-hexify-string (if (symbolp sym) (symbol-name sym) =
sym)))
+ pair))) query "&"))
+
(defun url-unhex (x)
(if (> x ?9)
(if (>=3D x ?a)=
owner <at> debbugs.gnu.org, bug-gnu-emacs <at> gnu.org:bug#8706; Package emacs.
Full text available.
Received: (at submit) by debbugs.gnu.org; 23 May 2011 14:36:38 +0000
From debbugs-submit-bounces <at> debbugs.gnu.org Mon May 23 10:36:38 2011
Received: from localhost ([127.0.0.1] helo=debbugs.gnu.org)
by debbugs.gnu.org with esmtp (Exim 4.69)
(envelope-from <debbugs-submit-bounces <at> debbugs.gnu.org>)
id 1QOWFJ-0002wM-Jv
for submit <at> debbugs.gnu.org; Mon, 23 May 2011 10:36:37 -0400
Received: from eggs.gnu.org ([140.186.70.92])
by debbugs.gnu.org with esmtp (Exim 4.69)
(envelope-from <geb-bug-gnu-emacs <at> m.gmane.org>) id 1QOWFG-0002wA-N3
for submit <at> debbugs.gnu.org; Mon, 23 May 2011 10:36:35 -0400
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
(envelope-from <geb-bug-gnu-emacs <at> m.gmane.org>) id 1QOWFA-0000hG-HI
for submit <at> debbugs.gnu.org; Mon, 23 May 2011 10:36:29 -0400
X-Spam-Checker-Version: SpamAssassin 3.3.1 (2010-03-16) on eggs.gnu.org
X-Spam-Level:
X-Spam-Status: No, score=-3.0 required=5.0 tests=BAYES_00,RCVD_IN_DNSWL_MED,
RCVD_NUMERIC_HELO, T_RP_MATCHES_RCVD autolearn=unavailable version=3.3.1
Received: from lists.gnu.org ([140.186.70.17]:36782)
by eggs.gnu.org with esmtp (Exim 4.71)
(envelope-from <geb-bug-gnu-emacs <at> m.gmane.org>) id 1QOWFA-0000hC-Fw
for submit <at> debbugs.gnu.org; Mon, 23 May 2011 10:36:28 -0400
Received: from eggs.gnu.org ([140.186.70.92]:49869)
by lists.gnu.org with esmtp (Exim 4.71)
(envelope-from <geb-bug-gnu-emacs <at> m.gmane.org>) id 1QOWF9-0000sl-Hl
for bug-gnu-emacs <at> gnu.org; Mon, 23 May 2011 10:36:28 -0400
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
(envelope-from <geb-bug-gnu-emacs <at> m.gmane.org>) id 1QOWF8-0000h2-AD
for bug-gnu-emacs <at> gnu.org; Mon, 23 May 2011 10:36:27 -0400
Received: from lo.gmane.org ([80.91.229.12]:32897)
by eggs.gnu.org with esmtp (Exim 4.71)
(envelope-from <geb-bug-gnu-emacs <at> m.gmane.org>) id 1QOWF8-0000gw-04
for bug-gnu-emacs <at> gnu.org; Mon, 23 May 2011 10:36:26 -0400
Received: from list by lo.gmane.org with local (Exim 4.69)
(envelope-from <geb-bug-gnu-emacs <at> m.gmane.org>) id 1QOWF6-0002XP-4j
for bug-gnu-emacs <at> gnu.org; Mon, 23 May 2011 16:36:24 +0200
Received: from 38.98.147.130 ([38.98.147.130])
by main.gmane.org with esmtp (Gmexim 0.1 (Debian))
id 1AlnuQ-0007hv-00
for <bug-gnu-emacs <at> gnu.org>; Mon, 23 May 2011 16:36:24 +0200
Received: from tzz by 38.98.147.130 with local (Gmexim 0.1 (Debian))
id 1AlnuQ-0007hv-00
for <bug-gnu-emacs <at> gnu.org>; Mon, 23 May 2011 16:36:24 +0200
X-Injected-Via-Gmane: http://gmane.org/
To: bug-gnu-emacs <at> gnu.org
From: Ted Zlatanov <tzz <at> lifelogs.com>
Subject: Re: bug#8706: 24.0.50; [PATCH] Function to build a URL query-string
Date: Mon, 23 May 2011 09:36:12 -0500
Organization: =?utf-8?B?0KLQtdC+0LTQvtGAINCX0LvQsNGC0LDQvdC+0LI=?= @ Cienfuegos
Lines: 31
Message-ID: <87d3j932n7.fsf <at> lifelogs.com>
References: <m2aaehrzeu.fsf <at> gmail.com>
Mime-Version: 1.0
Content-Type: text/plain
X-Complaints-To: usenet <at> dough.gmane.org
X-Gmane-NNTP-Posting-Host: 38.98.147.130
X-Face: bd.DQ~'29fIs`T_%O%C\g%6jW)yi[zuz6;
d4V0`@y-~$#3P_Ng{@m+e4o<4P'#(_GJQ%TT=
D}[Ep*b!\e,fBZ'j_+#"Ps?s2!4H2-Y"sx"
User-Agent: Gnus/5.110018 (No Gnus v0.18) Emacs/24.0.50 (gnu/linux)
Cancel-Lock: sha1:WB196ngOcuI7mlkfnMnIeD7LO8E=
X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.6 (newer, 3)
X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.6 (newer, 3)
X-Received-From: 140.186.70.17
X-Spam-Score: -3.4 (---)
X-Debbugs-Envelope-To: submit
X-BeenThere: debbugs-submit <at> debbugs.gnu.org
X-Mailman-Version: 2.1.11
Precedence: list
List-Id: <debbugs-submit.debbugs.gnu.org>
List-Unsubscribe: <http://debbugs.gnu.org/cgi-bin/mailman/options/debbugs-submit>,
<mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=unsubscribe>
List-Archive: <http://debbugs.gnu.org/pipermail/debbugs-submit>
List-Post: <mailto:debbugs-submit <at> debbugs.gnu.org>
List-Help: <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=help>
List-Subscribe: <http://debbugs.gnu.org/cgi-bin/mailman/listinfo/debbugs-submit>,
<mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=subscribe>
Sender: debbugs-submit-bounces <at> debbugs.gnu.org
Errors-To: debbugs-submit-bounces <at> debbugs.gnu.org
X-Spam-Score: -3.4 (---)
On Fri, 20 May 2011 11:37:45 -0700 Ian Eure <ian <at> simplegeo.com> wrote:
IE> This patch adds a url-build-query-string method, which performs the
IE> opposite job of url-parse-query-string. I find myself needing this
IE> method in many projects, and having it in url-util.el seems
IE> beneficial.
I think this is useful.
IE> + (c-concat-separated
IE> + (mapcar (lambda (pair) (apply 'format "%s=%s" pair)) query) "&"))
I would use `mapconcat' (it's what `c-concat-separated' uses under the
hood anyhow).
Also `format' errors out if it doesn't have enough arguments and it's
legitimate to build a URL query like "url?x;y;z" where x, y, and z don't
have values. So I would change the lambda to (untested):
(lambda (pair)
(if (nth 1 pair)
(apply 'format "%s=%s" pair)
(format "%s" (car-safe pair))))
This also handles the case where `pair' is nil by design or by accident.
Finally, the key and the value should be URL-encoded. Do you assume
that will be done before the function is called?
Thanks
Ted
owner <at> debbugs.gnu.org, bug-gnu-emacs <at> gnu.org:bug#8706; Package emacs.
Full text available.
Received: (at submit) by debbugs.gnu.org; 20 May 2011 18:39:06 +0000
From debbugs-submit-bounces <at> debbugs.gnu.org Fri May 20 14:39:06 2011
Received: from localhost ([127.0.0.1] helo=debbugs.gnu.org)
by debbugs.gnu.org with esmtp (Exim 4.69)
(envelope-from <debbugs-submit-bounces <at> debbugs.gnu.org>)
id 1QNUbJ-0006uh-G3
for submit <at> debbugs.gnu.org; Fri, 20 May 2011 14:39:06 -0400
Received: from eggs.gnu.org ([140.186.70.92])
by debbugs.gnu.org with esmtp (Exim 4.69)
(envelope-from <ian <at> simplegeo.com>) id 1QNUaG-0006rq-BI
for submit <at> debbugs.gnu.org; Fri, 20 May 2011 14:38:05 -0400
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
(envelope-from <ian <at> simplegeo.com>) id 1QNUaA-0003R0-KE
for submit <at> debbugs.gnu.org; Fri, 20 May 2011 14:37:55 -0400
X-Spam-Checker-Version: SpamAssassin 3.3.1 (2010-03-16) on eggs.gnu.org
X-Spam-Level:
X-Spam-Status: No, score=-2.6 required=5.0 tests=BAYES_00,RCVD_IN_DNSWL_LOW
autolearn=unavailable version=3.3.1
Received: from lists.gnu.org ([140.186.70.17]:56583)
by eggs.gnu.org with esmtp (Exim 4.71)
(envelope-from <ian <at> simplegeo.com>) id 1QNUaA-0003Qw-IY
for submit <at> debbugs.gnu.org; Fri, 20 May 2011 14:37:54 -0400
Received: from eggs.gnu.org ([140.186.70.92]:39260)
by lists.gnu.org with esmtp (Exim 4.71)
(envelope-from <ian <at> simplegeo.com>) id 1QNUa9-0001Cq-L9
for bug-gnu-emacs <at> gnu.org; Fri, 20 May 2011 14:37:54 -0400
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
(envelope-from <ian <at> simplegeo.com>) id 1QNUa8-0003Qm-SO
for bug-gnu-emacs <at> gnu.org; Fri, 20 May 2011 14:37:53 -0400
Received: from mail-pz0-f41.google.com ([209.85.210.41]:60805)
by eggs.gnu.org with esmtp (Exim 4.71)
(envelope-from <ian <at> simplegeo.com>) id 1QNUa8-0003Qg-NX
for bug-gnu-emacs <at> gnu.org; Fri, 20 May 2011 14:37:52 -0400
Received: by pzk4 with SMTP id 4so2443541pzk.0
for <bug-gnu-emacs <at> gnu.org>; Fri, 20 May 2011 11:37:51 -0700 (PDT)
Received: by 10.68.38.10 with SMTP id c10mr7019018pbk.192.1305916671124;
Fri, 20 May 2011 11:37:51 -0700 (PDT)
Received: from hadron.local.simplegeo.com (c-76-104-208-94.hsd1.wa.comcast.net
[76.104.208.94])
by mx.google.com with ESMTPS id l9sm2600503pbc.14.2011.05.20.11.37.48
(version=TLSv1/SSLv3 cipher=OTHER);
Fri, 20 May 2011 11:37:50 -0700 (PDT)
From: Ian Eure <ian <at> simplegeo.com>
To: bug-gnu-emacs <at> gnu.org
Subject: 24.0.50; [PATCH] Function to build a URL query-string
Date: Fri, 20 May 2011 11:37:45 -0700
Message-ID: <m2aaehrzeu.fsf <at> gmail.com>
MIME-Version: 1.0
Content-Type: text/plain
X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.6 (newer, 2)
X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.6 (newer, 3)
X-Received-From: 140.186.70.17
X-Spam-Score: -6.0 (------)
X-Debbugs-Envelope-To: submit
X-Mailman-Approved-At: Fri, 20 May 2011 14:39:04 -0400
X-BeenThere: debbugs-submit <at> debbugs.gnu.org
X-Mailman-Version: 2.1.11
Precedence: list
List-Id: <debbugs-submit.debbugs.gnu.org>
List-Unsubscribe: <http://debbugs.gnu.org/cgi-bin/mailman/options/debbugs-submit>,
<mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=unsubscribe>
List-Archive: <http://debbugs.gnu.org/pipermail/debbugs-submit>
List-Post: <mailto:debbugs-submit <at> debbugs.gnu.org>
List-Help: <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=help>
List-Subscribe: <http://debbugs.gnu.org/cgi-bin/mailman/listinfo/debbugs-submit>,
<mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=subscribe>
Sender: debbugs-submit-bounces <at> debbugs.gnu.org
Errors-To: debbugs-submit-bounces <at> debbugs.gnu.org
X-Spam-Score: -6.0 (------)
This patch adds a url-build-query-string method, which performs the opposite job of url-parse-query-string. I find myself needing this method in many projects, and having it in url-util.el seems beneficial.
--- url-util.el.orig 2011-05-20 11:32:42.000000000 -0700
+++ url-util.el 2011-05-20 11:32:15.000000000 -0700
@@ -281,6 +281,20 @@
(setq retval (cons (list key val) retval)))))
retval))
+;;;###autoload
+(defun url-build-query-string (query)
+ "Build a query-string.
+
+Given a QUERY in the form:
+'((key1 val1)
+ (key2 val2))
+
+This will return a string `key1=val1&key2=val2'. Keys may be strings
+or symbols; if they are symbols, the string name will be used."
+
+ (c-concat-separated
+ (mapcar (lambda (pair) (apply 'format "%s=%s" pair)) query) "&"))
+
(defun url-unhex (x)
(if (> x ?9)
(if (>= x ?a)
Ian Eure <ian <at> simplegeo.com>:bug-gnu-emacs <at> gnu.org.
Full text available.owner <at> debbugs.gnu.org, bug-gnu-emacs <at> gnu.org:bug#8706; Package emacs.
Full text available.
GNU bug tracking system
Copyright (C) 1999 Darren O. Benham,
1997 nCipher Corporation Ltd,
1994-97 Ian Jackson.