GNU bug report logs - #910
leim-list.el is looked up in too many places at startup

Please note: This is a static page, with minimal formatting, updated once a day.
Click here to see this page with the latest information and nicer formatting.

Package: emacs; Severity: wishlist; Reported by: Dan Nicolaescu <dann <at> ics.uci.edu>; Keywords: notabug; merged with #4789, #4881; dated Sun, 7 Sep 2008 11:35:04 UTC; Maintainer for emacs is bug-gnu-emacs <at> gnu.org.

Forcibly Merged 910 4789 4881. Request was from Glenn Morris <rgm <at> gnu.org> to control <at> debbugs.gnu.org. Full text available.

Removed tag(s) wontfix. Request was from Dan Nicolaescu <dann <at> ics.uci.edu> to control <at> emacsbugs.donarmstrong.com. Full text available.

Message received at 910 <at> emacsbugs.donarmstrong.com:

Received: (at 910) by emacsbugs.donarmstrong.com; 23 Oct 2009 05:38:19 +0000
From dann <at> godzilla.ics.uci.edu Thu Oct 22 22:38:19 2009
X-Spam-Checker-Version: SpamAssassin 3.2.5-bugs.debian.org_2005_01_02
	(2008-06-10) on rzlab.ucr.edu
X-Spam-Level: 
X-Spam-Bayes: score:0.5 Bayes not run. spammytokens:Tokens not available.
	hammytokens:Tokens not available.
X-Spam-Status: No, score=-5.9 required=4.0 tests=AWL,VALID_BTS_CONTROL,
	X_DEBBUGS_NO_ACK autolearn=ham version=3.2.5-bugs.debian.org_2005_01_02
Received: from colin-baker-v0.ics.uci.edu (colin-baker-v0.ics.uci.edu [128.195.1.153])
	by rzlab.ucr.edu (8.14.3/8.14.3/Debian-5) with ESMTP id n9N5cHxZ020875;
	Thu, 22 Oct 2009 22:38:19 -0700
Received: from godzilla.ics.uci.edu (godzilla.ics.uci.edu [128.195.10.101])
	by colin-baker-v0.ics.uci.edu (8.13.8/8.13.8) with ESMTP id n9N5brIV002957;
	Thu, 22 Oct 2009 22:37:53 -0700
Received: (from dann <at> localhost)
	by godzilla.ics.uci.edu (8.13.8+Sun/8.13.6/Submit) id n9N5bqlO025118;
	Thu, 22 Oct 2009 22:37:52 -0700 (PDT)
Date: Thu, 22 Oct 2009 22:37:52 -0700 (PDT)
Message-Id: <200910230537.n9N5bqlO025118 <at> godzilla.ics.uci.edu>
From: Dan Nicolaescu <dann <at> ics.uci.edu>
To: 910 <at> debbugs.gnu.org
Subject: Re: leim-list.el is looked up in too many places at startup
X-Debbugs-No-Ack: yes
Lines: 6
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
X-ICS-MailScanner-Information: Please send mail to helpdesk <at> ics.uci.edu or more information
X-ICS-MailScanner-ID: n9N5brIV002957
X-ICS-MailScanner: Found to be clean
X-ICS-MailScanner-SpamCheck: not spam, SpamAssassin (not cached, score=-1.44,
	required 5, autolearn=disabled, ALL_TRUSTED -1.44)
X-ICS-MailScanner-From: dann <at> godzilla.ics.uci.edu

tags 910 - wontfix
quit


See http://permalink.gmane.org/gmane.emacs.devel/116301
for Handa-san's opinion on how this should be handled.

Information forwarded to bug-submit-list <at> lists.donarmstrong.com, Emacs Bugs <bug-gnu-emacs <at> gnu.org>:
bug#910; Package emacs. Full text available.

Severity set to `wishlist' from `normal' Request was from Glenn Morris <rgm <at> gnu.org> to control <at> emacsbugs.donarmstrong.com. Full text available.

Tags added: notabug, wontfix Request was from Glenn Morris <rgm <at> gnu.org> to control <at> emacsbugs.donarmstrong.com. Full text available.

Message received at (unknown):

Received: (at unknown) by unknown; unknown
X-Spam-Checker-Version: SpamAssassin 3.2.3-bugs.debian.org_2005_01_02
	(2007-08-08) on rzlab.ucr.edu
X-Spam-Level: 
X-Spam-Status: No, score=-12.2 required=4.0 tests=AWL,BAYES_00,HAS_BUG_NUMBER,
	RCVD_IN_DNSWL_HI autolearn=ham version=3.2.3-bugs.debian.org_2005_01_02
Received: (at 910) by emacsbugs.donarmstrong.com; 10 Sep 2008 08:11:09 +0000
Received: from mx1.suse.de (mail.suse.de [195.135.220.2])
	by rzlab.ucr.edu (8.13.8/8.13.8/Debian-3) with ESMTP id m8A8B5d5030450
	for <910 <at> emacsbugs.donarmstrong.com>; Wed, 10 Sep 2008 01:11:07 -0700
Received: from Relay1.suse.de (relay-ext.suse.de [195.135.221.8])
	(using TLSv1 with cipher DHE-RSA-AES256-SHA (256/256 bits))
	(No client certificate requested)
	by mx1.suse.de (Postfix) with ESMTP id A1680418AE;
	Wed, 10 Sep 2008 10:11:02 +0200 (CEST)
From: Andreas Schwab <schwab <at> suse.de>
To: Glenn Morris <rgm <at> gnu.org>
Cc: 910 <at> debbugs.gnu.org, Dan Nicolaescu <dann <at> ics.uci.edu>
Subject: Re: bug#910: leim-list.el is looked up in too many places at startup
References: <200809071125.m87BPSMV028737 <at> sallyv1.ics.uci.edu>
	<xv8wu03gfe.fsf <at> fencepost.gnu.org>
X-Yow: ..  I have a VISION!  It's a RANCID double-FISHWICH on an ENRICHED BUN!!
Date: Wed, 10 Sep 2008 10:11:00 +0200
In-Reply-To: <xv8wu03gfe.fsf <at> fencepost.gnu.org> (Glenn Morris's message of
	"Tue, 09 Sep 2008 22:04:05 -0400")
Message-ID: <jeljy0a0a3.fsf <at> sykes.suse.de>
User-Agent: Gnus/5.110009 (No Gnus v0.9) Emacs/22.2 (gnu/linux)
MIME-Version: 1.0
Content-Type: text/plain; charset=iso-8859-1
Content-Transfer-Encoding: 8bit

Glenn Morris <rgm <at> gnu.org> writes:

> Dan Nicolaescu wrote:
>
>> strace emacs -Q
>>
>> shows that leim-list.el is looked up in 32 locations at startup. We
>> only have it in a single place.  Is this a leftover from the time
>> when leim was distributed separately from emacs?
>>
>> It would be good if this redundant work would be avoided.
>
>
> It does seem superfluous.

Extensions can and do add their own leim-list.

Andreas.

-- 
Andreas Schwab, SuSE Labs, schwab <at> suse.de
SuSE Linux Products GmbH, Maxfeldstra�e 5, 90409 N�rnberg, Germany
PGP key fingerprint = 58CA 54C7 6D53 942B 1756  01D3 44D5 214B 8276 4ED5
"And now for something completely different."

Acknowledgement sent to Andreas Schwab <schwab <at> suse.de>:
Extra info received and forwarded to list. Copy sent to Emacs Bugs <bug-gnu-emacs <at> gnu.org>. Full text available.

Information forwarded to bug-submit-list <at> lists.donarmstrong.com, Emacs Bugs <bug-gnu-emacs <at> gnu.org>:
bug#910; Package emacs. Full text available.

Message received at (unknown):

Received: (at unknown) by unknown; unknown
X-Spam-Checker-Version: SpamAssassin 3.2.3-bugs.debian.org_2005_01_02
	(2007-08-08) on rzlab.ucr.edu
X-Spam-Level: 
X-Spam-Status: No, score=-12.0 required=4.0 tests=AWL,BAYES_00,FOURLA,
	HAS_BUG_NUMBER,MURPHY_DRUGS_REL8,RCVD_IN_DNSWL_MED,X_DEBBUGS_NO_ACK
	autolearn=ham version=3.2.3-bugs.debian.org_2005_01_02
Received: (at 910) by emacsbugs.donarmstrong.com; 10 Sep 2008 06:52:37 +0000
Received: from fencepost.gnu.org (fencepost.gnu.org [140.186.70.10])
	by rzlab.ucr.edu (8.13.8/8.13.8/Debian-3) with ESMTP id m8A6qX04001925
	for <910 <at> emacsbugs.donarmstrong.com>; Tue, 9 Sep 2008 23:52:35 -0700
Received: from rgm by fencepost.gnu.org with local (Exim 4.67)
	(envelope-from <rgm <at> gnu.org>)
	id 1KdJXK-0004Qh-6k; Wed, 10 Sep 2008 02:50:46 -0400
From: Glenn Morris <rgm <at> gnu.org>
To: 910 <at> debbugs.gnu.org
Cc: Dan Nicolaescu <dann <at> ics.uci.edu>
Subject: Re: bug#910: leim-list.el is looked up in too many places at startup
References: <200809071125.m87BPSMV028737 <at> sallyv1.ics.uci.edu>
	<xv8wu03gfe.fsf <at> fencepost.gnu.org>
	<200809100219.m8A2J5Cl011266 <at> sallyv1.ics.uci.edu>
	<rmtzcod3gt.fsf <at> fencepost.gnu.org>
X-Spook: chameleon man nuclear Bush Wired Serbian 64 Vauxhall
X-Ran: |nW}.j;hU8]q25y=qa2Jo"<>Wnr{]2zO[7p-ulx$aeTZrj<\KeU}!^vJU/r<VUAj&)C's>
X-Hue: blue
X-Debbugs-No-Ack: yes
X-Attribution: GM
Date: Wed, 10 Sep 2008 02:50:46 -0400
In-Reply-To: <rmtzcod3gt.fsf <at> fencepost.gnu.org> (Glenn Morris's message of
	"Wed, 10 Sep 2008 00:33:54 -0400")
Message-ID: <0d4p4omr3t.fsf <at> fencepost.gnu.org>
User-Agent: Gnus (www.gnus.org), GNU Emacs (www.gnu.org/software/emacs/)
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii


The original was also binding default-directory for some reason, so
here is a revised patch in case that matters.

Without having thought about it much, if leim-list is always loaded,
why isn't it dumped?

*** startup.el	23 Aug 2008 16:59:19 -0000	1.503
--- startup.el	10 Sep 2008 06:49:37 -0000
***************
*** 478,496 ****
      ;; Look in each dir in load-path for a subdirs.el file.
      ;; If we find one, load it, which will add the appropriate subdirs
      ;; of that dir into load-path,
-     ;; Look for a leim-list.el file too.  Loading it will register
-     ;; available input methods.
      (let ((tail load-path) dir)
        (while tail
          (setq dir (car tail))
          (let ((default-directory dir))
            (load (expand-file-name "subdirs.el") t t t))
-         (let ((default-directory dir))
-           (load (expand-file-name "leim-list.el") t t t))
          ;; We don't use a dolist loop and we put this "setq-cdr" command at
          ;; the end, because the subdirs.el files may add elements to the end
          ;; of load-path and we want to take it into account.
          (setq tail (cdr tail))))
      ;; If the PWD environment variable isn't accurate, delete it.
      (let ((pwd (getenv "PWD")))
        (and (stringp pwd)
--- 478,505 ----
      ;; Look in each dir in load-path for a subdirs.el file.
      ;; If we find one, load it, which will add the appropriate subdirs
      ;; of that dir into load-path,
      (let ((tail load-path) dir)
        (while tail
          (setq dir (car tail))
          (let ((default-directory dir))
            (load (expand-file-name "subdirs.el") t t t))
          ;; We don't use a dolist loop and we put this "setq-cdr" command at
          ;; the end, because the subdirs.el files may add elements to the end
          ;; of load-path and we want to take it into account.
          (setq tail (cdr tail))))
+     ;; Load leim-list.el to register available input methods.
+     ;; Bug#910.  We used to look for it in each directory in load-path.
+     ;; This is no longer necessary since leim is distributed with Emacs.
+     ;; doc-directory is used rather than data-directory for
+     ;; non-source-directory builds running uninstalled.
+     (let* ((leim (expand-file-name "../leim/leim-list.el" doc-directory))
+ 	   (default-directory (file-name-directory leim)))
+       (condition-case nil
+ 	  (load leim nil t t)
+ 	(error
+ 	 (display-warning 'initialization
+ 			  (format "Unable to load LEIM file `%s'" leim)
+ 			  :error))))
      ;; If the PWD environment variable isn't accurate, delete it.
      (let ((pwd (getenv "PWD")))
        (and (stringp pwd)

Information forwarded to bug-submit-list <at> lists.donarmstrong.com, Emacs Bugs <bug-gnu-emacs <at> gnu.org>:
bug#910; Package emacs. Full text available.

Message received at (unknown):

Received: (at unknown) by unknown; unknown
X-Spam-Checker-Version: SpamAssassin 3.2.3-bugs.debian.org_2005_01_02
	(2007-08-08) on rzlab.ucr.edu
X-Spam-Level: 
X-Spam-Status: No, score=-12.0 required=4.0 tests=AWL,BAYES_00,HAS_BUG_NUMBER,
	RCVD_IN_DNSWL_MED,X_DEBBUGS_NO_ACK autolearn=ham
	version=3.2.3-bugs.debian.org_2005_01_02
Received: (at 910) by emacsbugs.donarmstrong.com; 10 Sep 2008 04:35:44 +0000
Received: from fencepost.gnu.org (fencepost.gnu.org [140.186.70.10])
	by rzlab.ucr.edu (8.13.8/8.13.8/Debian-3) with ESMTP id m8A4Zfe1019496
	for <910 <at> emacsbugs.donarmstrong.com>; Tue, 9 Sep 2008 21:35:42 -0700
Received: from rgm by fencepost.gnu.org with local (Exim 4.67)
	(envelope-from <rgm <at> gnu.org>)
	id 1KdHOs-00007A-7x; Wed, 10 Sep 2008 00:33:54 -0400
From: Glenn Morris <rgm <at> gnu.org>
To: Dan Nicolaescu <dann <at> ics.uci.edu>
Cc: 910 <at> debbugs.gnu.org
Subject: Re: bug#910: leim-list.el is looked up in too many places at startup
References: <200809071125.m87BPSMV028737 <at> sallyv1.ics.uci.edu>
	<xv8wu03gfe.fsf <at> fencepost.gnu.org>
	<200809100219.m8A2J5Cl011266 <at> sallyv1.ics.uci.edu>
X-Spook: Serbian ASLET Tony Blair DES Venezuela Crypto AG global
X-Ran: vRa#^'t-MoOp;Y#:Kx#Sp]et;1#>'q@#wxx[(P%!,*4K?CJLB=q'2f{Ux7(G!'1lwn$dKK
X-Hue: cyan
X-Debbugs-No-Ack: yes
X-Attribution: GM
Date: Wed, 10 Sep 2008 00:33:54 -0400
In-Reply-To: <200809100219.m8A2J5Cl011266 <at> sallyv1.ics.uci.edu> (Dan
	Nicolaescu's message of "Tue, 09 Sep 2008 19:19:05 -0700")
Message-ID: <rmtzcod3gt.fsf <at> fencepost.gnu.org>
User-Agent: Gnus (www.gnus.org), GNU Emacs (www.gnu.org/software/emacs/)
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii

Dan Nicolaescu wrote:

>   > +     (let ((leim (expand-file-name "../leim/leim-list.el" data-directory)))
>                ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
>                This won't work when building in a separate directory:
>                leim-list.el is generated in the build tree, not the
>                source tree (unlike what happens for .elc files...)

Looks like I can just use doc-directory instead of data-directory
here, and all will be well.

The only question is, if people are supposed to be able to have
multiple leim-list files, or to be able to add their own. I guess not?

Information forwarded to bug-submit-list <at> lists.donarmstrong.com, Emacs Bugs <bug-gnu-emacs <at> gnu.org>:
bug#910; Package emacs. Full text available.

Message received at (unknown):

Received: (at unknown) by unknown; unknown
X-Spam-Checker-Version: SpamAssassin 3.2.3-bugs.debian.org_2005_01_02
	(2007-08-08) on rzlab.ucr.edu
X-Spam-Level: 
X-Spam-Status: No, score=-5.9 required=4.0 tests=AWL,BAYES_00,HAS_BUG_NUMBER
	autolearn=ham version=3.2.3-bugs.debian.org_2005_01_02
Received: (at 910) by emacsbugs.donarmstrong.com; 10 Sep 2008 02:22:06 +0000
Received: from sallyv1.ics.uci.edu (sallyv1.ics.uci.edu [128.195.1.109])
	by rzlab.ucr.edu (8.13.8/8.13.8/Debian-3) with ESMTP id m8A2M3sH004712
	for <910 <at> emacsbugs.donarmstrong.com>; Tue, 9 Sep 2008 19:22:04 -0700
X-ICS-MailScanner-Watermark: 1221617948.66331 <at> 7pYlSMhVfd8wl4mTrngoWQ
Received: from mothra.ics.uci.edu (mothra.ics.uci.edu [128.195.6.93])
	by sallyv1.ics.uci.edu (8.13.7+Sun/8.13.7) with ESMTP id m8A2J5Cl011266;
	Tue, 9 Sep 2008 19:19:05 -0700 (PDT)
Message-Id: <200809100219.m8A2J5Cl011266 <at> sallyv1.ics.uci.edu>
From: Dan Nicolaescu <dann <at> ics.uci.edu>
To: Glenn Morris <rgm <at> gnu.org>
Cc: 910 <at> debbugs.gnu.org
Subject: Re: bug#910: leim-list.el is looked up in too many places at startup
References: <200809071125.m87BPSMV028737 <at> sallyv1.ics.uci.edu>
	<xv8wu03gfe.fsf <at> fencepost.gnu.org>
In-Reply-To: <xv8wu03gfe.fsf <at> fencepost.gnu.org> (Glenn Morris's message of
	"Tue, 09 Sep 2008 22:04:05 -0400")
Lines: 60
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Date: Tue, 09 Sep 2008 19:19:05 -0700
Sender: dann <at> ics.uci.edu
X-ICS-MailScanner: Found to be clean
X-ICS-MailScanner-SpamCheck: not spam, SpamAssassin (score=-1.44, required 5,
	autolearn=disabled, ALL_TRUSTED -1.44)
X-ICS-MailScanner-From: dann <at> mothra.ics.uci.edu

Glenn Morris <rgm <at> gnu.org> writes:

  > Dan Nicolaescu wrote:
  > 
  > > strace emacs -Q
  > >
  > > shows that leim-list.el is looked up in 32 locations at startup. We
  > > only have it in a single place.  Is this a leftover from the time
  > > when leim was distributed separately from emacs?
  > >
  > > It would be good if this redundant work would be avoided.
  > 
  > 
  > It does seem superfluous. This works for me:

Thanks!

  > *** startup.el	23 Aug 2008 16:59:19 -0000	1.503
  > --- startup.el	10 Sep 2008 02:03:52 -0000
  > ***************
  > *** 478,496 ****
  >       ;; Look in each dir in load-path for a subdirs.el file.
  >       ;; If we find one, load it, which will add the appropriate subdirs
  >       ;; of that dir into load-path,
  > -     ;; Look for a leim-list.el file too.  Loading it will register
  > -     ;; available input methods.
  >       (let ((tail load-path) dir)
  >         (while tail
  >           (setq dir (car tail))
  >           (let ((default-directory dir))
  >             (load (expand-file-name "subdirs.el") t t t))
  > -         (let ((default-directory dir))
  > -           (load (expand-file-name "leim-list.el") t t t))
  >           ;; We don't use a dolist loop and we put this "setq-cdr" command at
  >           ;; the end, because the subdirs.el files may add elements to the end
  >           ;; of load-path and we want to take it into account.
  >           (setq tail (cdr tail))))
  >       ;; If the PWD environment variable isn't accurate, delete it.
  >       (let ((pwd (getenv "PWD")))
  >         (and (stringp pwd)
  > --- 478,501 ----
  >       ;; Look in each dir in load-path for a subdirs.el file.
  >       ;; If we find one, load it, which will add the appropriate subdirs
  >       ;; of that dir into load-path,
  >       (let ((tail load-path) dir)
  >         (while tail
  >           (setq dir (car tail))
  >           (let ((default-directory dir))
  >             (load (expand-file-name "subdirs.el") t t t))
  >           ;; We don't use a dolist loop and we put this "setq-cdr" command at
  >           ;; the end, because the subdirs.el files may add elements to the end
  >           ;; of load-path and we want to take it into account.
  >           (setq tail (cdr tail))))
  > +     ;; Look for a leim-list.el file.  Loading it will register
  > +     ;; available input methods.
  > +     (let ((leim (expand-file-name "../leim/leim-list.el" data-directory)))
               ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
               This won't work when building in a separate directory:
               leim-list.el is generated in the build tree, not the
               source tree (unlike what happens for .elc files...)

Acknowledgement sent to Dan Nicolaescu <dann <at> ics.uci.edu>:
Extra info received and forwarded to list. Copy sent to Emacs Bugs <bug-gnu-emacs <at> gnu.org>. Full text available.

Information forwarded to bug-submit-list <at> lists.donarmstrong.com, Emacs Bugs <bug-gnu-emacs <at> gnu.org>:
bug#910; Package emacs. Full text available.

Message received at (unknown):

Received: (at unknown) by unknown; unknown
X-Spam-Checker-Version: SpamAssassin 3.2.3-bugs.debian.org_2005_01_02
	(2007-08-08) on rzlab.ucr.edu
X-Spam-Level: 
X-Spam-Status: No, score=-12.0 required=4.0 tests=AWL,BAYES_00,FOURLA,
	HAS_BUG_NUMBER,RCVD_IN_DNSWL_MED,X_DEBBUGS_NO_ACK autolearn=ham
	version=3.2.3-bugs.debian.org_2005_01_02
Received: (at 910) by emacsbugs.donarmstrong.com; 10 Sep 2008 02:05:56 +0000
Received: from fencepost.gnu.org (fencepost.gnu.org [140.186.70.10])
	by rzlab.ucr.edu (8.13.8/8.13.8/Debian-3) with ESMTP id m8A25qaT031939
	for <910 <at> emacsbugs.donarmstrong.com>; Tue, 9 Sep 2008 19:05:53 -0700
Received: from rgm by fencepost.gnu.org with local (Exim 4.67)
	(envelope-from <rgm <at> gnu.org>)
	id 1KdF3t-0003W6-2e; Tue, 09 Sep 2008 22:04:05 -0400
From: Glenn Morris <rgm <at> gnu.org>
To: Dan Nicolaescu <dann <at> ics.uci.edu>
Cc: 910 <at> debbugs.gnu.org
Subject: Re: bug#910: leim-list.el is looked up in too many places at startup
References: <200809071125.m87BPSMV028737 <at> sallyv1.ics.uci.edu>
X-Spook: kilderkin Bin Laden Axis of Evil SAFE Peking Geraldton
X-Ran: :,R91qnFy%f/hZ#_|cNXf_rspUjrdt6%AcdOg"6Hn_b/"0YK{jL-Io%f6OxBa2f6mE;O`D
X-Hue: red
X-Debbugs-No-Ack: yes
X-Attribution: GM
Date: Tue, 09 Sep 2008 22:04:05 -0400
In-Reply-To: <200809071125.m87BPSMV028737 <at> sallyv1.ics.uci.edu> (Dan
	Nicolaescu's message of "Sun, 07 Sep 2008 04:25:28 -0700")
Message-ID: <xv8wu03gfe.fsf <at> fencepost.gnu.org>
User-Agent: Gnus (www.gnus.org), GNU Emacs (www.gnu.org/software/emacs/)
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii

Dan Nicolaescu wrote:

> strace emacs -Q
>
> shows that leim-list.el is looked up in 32 locations at startup. We
> only have it in a single place.  Is this a leftover from the time
> when leim was distributed separately from emacs?
>
> It would be good if this redundant work would be avoided.


It does seem superfluous. This works for me:


*** startup.el	23 Aug 2008 16:59:19 -0000	1.503
--- startup.el	10 Sep 2008 02:03:52 -0000
***************
*** 478,496 ****
      ;; Look in each dir in load-path for a subdirs.el file.
      ;; If we find one, load it, which will add the appropriate subdirs
      ;; of that dir into load-path,
-     ;; Look for a leim-list.el file too.  Loading it will register
-     ;; available input methods.
      (let ((tail load-path) dir)
        (while tail
          (setq dir (car tail))
          (let ((default-directory dir))
            (load (expand-file-name "subdirs.el") t t t))
-         (let ((default-directory dir))
-           (load (expand-file-name "leim-list.el") t t t))
          ;; We don't use a dolist loop and we put this "setq-cdr" command at
          ;; the end, because the subdirs.el files may add elements to the end
          ;; of load-path and we want to take it into account.
          (setq tail (cdr tail))))
      ;; If the PWD environment variable isn't accurate, delete it.
      (let ((pwd (getenv "PWD")))
        (and (stringp pwd)
--- 478,501 ----
      ;; Look in each dir in load-path for a subdirs.el file.
      ;; If we find one, load it, which will add the appropriate subdirs
      ;; of that dir into load-path,
      (let ((tail load-path) dir)
        (while tail
          (setq dir (car tail))
          (let ((default-directory dir))
            (load (expand-file-name "subdirs.el") t t t))
          ;; We don't use a dolist loop and we put this "setq-cdr" command at
          ;; the end, because the subdirs.el files may add elements to the end
          ;; of load-path and we want to take it into account.
          (setq tail (cdr tail))))
+     ;; Look for a leim-list.el file.  Loading it will register
+     ;; available input methods.
+     (let ((leim (expand-file-name "../leim/leim-list.el" data-directory)))
+       (condition-case nil
+ 	  (load leim nil t t)
+ 	(error
+ 	 (display-warning 'initialization
+ 			  (format "Unable to load LEIM file `%s'" leim)
+ 			  :error))))
      ;; If the PWD environment variable isn't accurate, delete it.
      (let ((pwd (getenv "PWD")))
        (and (stringp pwd)

Information forwarded to bug-submit-list <at> lists.donarmstrong.com, Emacs Bugs <bug-gnu-emacs <at> gnu.org>:
bug#910; Package emacs. Full text available.

Message received at (unknown):

Received: (at unknown) by unknown; unknown
X-Spam-Checker-Version: SpamAssassin 3.2.3-bugs.debian.org_2005_01_02
	(2007-08-08) on rzlab.ucr.edu
X-Spam-Level: 
X-Spam-Status: No, score=-4.8 required=4.0 tests=AWL,BAYES_00,
	RCVD_IN_DNSWL_LOW autolearn=ham version=3.2.3-bugs.debian.org_2005_01_02
Received: (at submit) by emacsbugs.donarmstrong.com; 7 Sep 2008 11:26:31 +0000
Received: from lists.gnu.org (lists.gnu.org [199.232.76.165])
	by rzlab.ucr.edu (8.13.8/8.13.8/Debian-3) with ESMTP id m87BQSkw032507
	for <submit <at> emacsbugs.donarmstrong.com>; Sun, 7 Sep 2008 04:26:29 -0700
Received: from mailman by lists.gnu.org with tmda-scanned (Exim 4.43)
	id 1KcIPT-00060M-Cu
	for bug-gnu-emacs <at> gnu.org; Sun, 07 Sep 2008 07:26:27 -0400
Received: from exim by lists.gnu.org with spam-scanned (Exim 4.43)
	id 1KcIPR-0005yB-LB
	for bug-gnu-emacs <at> gnu.org; Sun, 07 Sep 2008 07:26:26 -0400
Received: from [199.232.76.173] (port=56568 helo=monty-python.gnu.org)
	by lists.gnu.org with esmtp (Exim 4.43)
	id 1KcIPR-0005xf-9d
	for bug-gnu-emacs <at> gnu.org; Sun, 07 Sep 2008 07:26:25 -0400
Received: from sallyv1.ics.uci.edu ([128.195.1.109]:55780)
	by monty-python.gnu.org with esmtps (TLS-1.0:DHE_RSA_3DES_EDE_CBC_SHA1:24)
	(Exim 4.60)
	(envelope-from <dann <at> ics.uci.edu>)
	id 1KcIPQ-0003Pb-PA
	for bug-gnu-emacs <at> gnu.org; Sun, 07 Sep 2008 07:26:25 -0400
X-ICS-MailScanner-Watermark: 1221391528.59039 <at> yO3VAlKGMYvhLbkGj6R17Q
Received: from mothra.ics.uci.edu (mothra.ics.uci.edu [128.195.6.93])
	by sallyv1.ics.uci.edu (8.13.7+Sun/8.13.7) with ESMTP id m87BPSMV028737
	for <bug-gnu-emacs <at> gnu.org>; Sun, 7 Sep 2008 04:25:28 -0700 (PDT)
Message-Id: <200809071125.m87BPSMV028737 <at> sallyv1.ics.uci.edu>
From: Dan Nicolaescu <dann <at> ics.uci.edu>
To: bug-gnu-emacs <bug-gnu-emacs <at> gnu.org>
Subject: leim-list.el is looked up in too many places at startup
Lines: 9
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Date: Sun, 07 Sep 2008 04:25:28 -0700
Sender: dann <at> ics.uci.edu
X-ICS-MailScanner: Found to be clean
X-ICS-MailScanner-SpamCheck: not spam, SpamAssassin (score=-1.44, required 5,
	autolearn=disabled, ALL_TRUSTED -1.44)
X-ICS-MailScanner-From: dann <at> mothra.ics.uci.edu
X-detected-kernel: by monty-python.gnu.org: Solaris 10 (beta)


strace emacs -Q

shows that leim-list.el is looked up in 32 locations at startup.  We
only have it in a single place.
Is this a leftover from the time when leim was distributed separately
from emacs?

It would be good if this redundant work would be avoided.

Acknowledgement sent to Dan Nicolaescu <dann <at> ics.uci.edu>:
New bug report received and forwarded. Copy sent to Emacs Bugs <bug-gnu-emacs <at> gnu.org>. Full text available.

Report forwarded to bug-submit-list <at> lists.donarmstrong.com, Emacs Bugs <bug-gnu-emacs <at> gnu.org>:
bug#910; Package emacs. Full text available.

Please note: This is a static page, with minimal formatting, updated once a day.
Click here to see this page with the latest information and nicer formatting.

Last modified: Tue, 20 Sep 2011 19:45:02 UTC

GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997 nCipher Corporation Ltd, 1994-97 Ian Jackson.