GNU bug report logs - #69712
Package author/maintainer printing fix

Please note: This is a static page, with minimal formatting, updated once a day.
Click here to see this page with the latest information and nicer formatting.

Package: emacs; Reported by: Juri Linkov <juri@HIDDEN>; Done: Stefan Monnier <monnier@HIDDEN>; Maintainer for emacs is bug-gnu-emacs@HIDDEN.
bug unarchived. Request was from Juri Linkov <juri@HIDDEN> to control <at> debbugs.gnu.org. Full text available.
bug archived. Request was from Debbugs Internal Request <help-debbugs@HIDDEN> to internal_control <at> debbugs.gnu.org. Full text available.

Message received at 69712-done <at> debbugs.gnu.org:


Received: (at 69712-done) by debbugs.gnu.org; 23 Mar 2024 20:12:51 +0000
From debbugs-submit-bounces <at> debbugs.gnu.org Sat Mar 23 16:12:51 2024
Received: from localhost ([127.0.0.1]:51234 helo=debbugs.gnu.org)
	by debbugs.gnu.org with esmtp (Exim 4.84_2)
	(envelope-from <debbugs-submit-bounces <at> debbugs.gnu.org>)
	id 1ro7jW-0001c3-Qa
	for submit <at> debbugs.gnu.org; Sat, 23 Mar 2024 16:12:51 -0400
Received: from mailscanner.iro.umontreal.ca ([132.204.25.50]:38929)
 by debbugs.gnu.org with esmtp (Exim 4.84_2)
 (envelope-from <monnier@HIDDEN>) id 1ro7jV-0001bi-JI
 for 69712-done <at> debbugs.gnu.org; Sat, 23 Mar 2024 16:12:50 -0400
Received: from pmg2.iro.umontreal.ca (localhost.localdomain [127.0.0.1])
 by pmg2.iro.umontreal.ca (Proxmox) with ESMTP id C7DE280CD7;
 Sat, 23 Mar 2024 16:12:02 -0400 (EDT)
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=iro.umontreal.ca;
 s=mail; t=1711224721;
 bh=cuMwrNbR1bglgh/Tf+AbKL4Q6Mlqn3kX2dl30G0H+js=;
 h=From:To:Cc:Subject:In-Reply-To:References:Date:From;
 b=oj+KqekhvbhT8yllDvqo+QemT0cxEobrj9fWXqI0Sz+q1Sq/vwrMSWSJf/LNytArO
 MZa3uKtFwOkfpdSmfomxM3tbQLJTH0VpXvSZ2Srsl9Gf3ndCqTkbTrWIfSofLHoepN
 oQ1On+CzfF7TDpjeOTg2ltprbi19Gc7f2bW5cYTB9/2lHYjNp8VJ8J2Kl+0rgdGc3Y
 9lJrX+dgbhWv/RVaaDsor0OHU9QUQxMXeoG/wwlqNt5/73pFZac0tDhpnWdnBPAsHy
 D78i3tyLqbLbzkgmKSTO7R+shuiYjjdf14czlu5ZUUP/Z0Okp273YNnYJ9vcLcag+Z
 cacxJ6axUDz+A==
Received: from mail01.iro.umontreal.ca (unknown [172.31.2.1])
 by pmg2.iro.umontreal.ca (Proxmox) with ESMTP id CB92580244;
 Sat, 23 Mar 2024 16:12:01 -0400 (EDT)
Received: from pastel (unknown [104.247.238.200])
 by mail01.iro.umontreal.ca (Postfix) with ESMTPSA id A24A5120024;
 Sat, 23 Mar 2024 16:12:01 -0400 (EDT)
From: Stefan Monnier <monnier@HIDDEN>
To: Juri Linkov <juri@HIDDEN>
Subject: Re: bug#69712: Package author/maintainer printing fix
In-Reply-To: <86bk74vp10.fsf@HIDDEN> (Juri Linkov's message of "Sat, 
 23 Mar 2024 20:24:31 +0200")
Message-ID: <jwvh6gw7lof.fsf-monnier+emacs@HIDDEN>
References: <86h6hegr0b.fsf@HIDDEN>
 <jwvedc26ql6.fsf-monnier+emacs@HIDDEN>
 <86bk74vp10.fsf@HIDDEN>
Date: Sat, 23 Mar 2024 16:12:01 -0400
User-Agent: Gnus/5.13 (Gnus v5.13)
MIME-Version: 1.0
Content-Type: text/plain
X-SPAM-INFO: Spam detection results:  0
 ALL_TRUSTED                -1 Passed through trusted hosts only via SMTP
 AWL -0.206 Adjusted score from AWL reputation of From: address
 BAYES_00                 -1.9 Bayes spam probability is 0 to 1%
 DKIM_SIGNED               0.1 Message has a DKIM or DK signature,
 not necessarily valid
 DKIM_VALID -0.1 Message has at least one valid DKIM or DK signature
 DKIM_VALID_AU -0.1 Message has a valid DKIM or DK signature from author's
 domain
 DKIM_VALID_EF -0.1 Message has a valid DKIM or DK signature from envelope-from
 domain
X-SPAM-LEVEL: 
X-Spam-Score: -2.3 (--)
X-Debbugs-Envelope-To: 69712-done
Cc: 69712-done <at> debbugs.gnu.org
X-BeenThere: debbugs-submit <at> debbugs.gnu.org
X-Mailman-Version: 2.1.18
Precedence: list
List-Id: <debbugs-submit.debbugs.gnu.org>
List-Unsubscribe: <https://debbugs.gnu.org/cgi-bin/mailman/options/debbugs-submit>, 
 <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=unsubscribe>
List-Archive: <https://debbugs.gnu.org/cgi-bin/mailman/private/debbugs-submit/>
List-Post: <mailto:debbugs-submit <at> debbugs.gnu.org>
List-Help: <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=help>
List-Subscribe: <https://debbugs.gnu.org/cgi-bin/mailman/listinfo/debbugs-submit>, 
 <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=subscribe>
Errors-To: debbugs-submit-bounces <at> debbugs.gnu.org
Sender: "Debbugs-submit" <debbugs-submit-bounces <at> debbugs.gnu.org>
X-Spam-Score: -3.3 (---)

>> I suggest the following fix instead.
>> Can you confirm that it fixes the problem for you as well?
>>
>> diff --git a/lisp/emacs-lisp/package.el b/lisp/emacs-lisp/package.el
>> @@ -2941,7 +2941,7 @@ describe-package-1
>>          (insert " "))
>>        (insert "\n"))
>>      (when maintainers
>> -      (unless (proper-list-p maintainers)
>> +      (when (stringp (car maintainers))
>>          (setq maintainers (list maintainers)))
>
> I confirm this completely fixes the problem.

Thanks, pushed to `master`.


        Stefan





Notification sent to Juri Linkov <juri@HIDDEN>:
bug acknowledged by developer. Full text available.
Reply sent to Stefan Monnier <monnier@HIDDEN>:
You have taken responsibility. Full text available.

Message received at 69712 <at> debbugs.gnu.org:


Received: (at 69712) by debbugs.gnu.org; 23 Mar 2024 18:35:23 +0000
From debbugs-submit-bounces <at> debbugs.gnu.org Sat Mar 23 14:35:23 2024
Received: from localhost ([127.0.0.1]:46100 helo=debbugs.gnu.org)
	by debbugs.gnu.org with esmtp (Exim 4.84_2)
	(envelope-from <debbugs-submit-bounces <at> debbugs.gnu.org>)
	id 1ro6DD-0005iu-9m
	for submit <at> debbugs.gnu.org; Sat, 23 Mar 2024 14:35:23 -0400
Received: from relay7-d.mail.gandi.net ([217.70.183.200]:54705)
 by debbugs.gnu.org with esmtp (Exim 4.84_2)
 (envelope-from <juri@HIDDEN>) id 1ro6DB-0005iV-9r
 for 69712 <at> debbugs.gnu.org; Sat, 23 Mar 2024 14:35:21 -0400
Received: by mail.gandi.net (Postfix) with ESMTPSA id B102F20003;
 Sat, 23 Mar 2024 18:34:32 +0000 (UTC)
From: Juri Linkov <juri@HIDDEN>
To: Stefan Monnier <monnier@HIDDEN>
Subject: Re: bug#69712: Package author/maintainer printing fix
In-Reply-To: <jwvedc26ql6.fsf-monnier+emacs@HIDDEN> (Stefan Monnier's message
 of "Fri, 22 Mar 2024 15:02:35 -0400")
Organization: LINKOV.NET
References: <86h6hegr0b.fsf@HIDDEN>
 <jwvedc26ql6.fsf-monnier+emacs@HIDDEN>
Date: Sat, 23 Mar 2024 20:24:31 +0200
Message-ID: <86bk74vp10.fsf@HIDDEN>
User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/30.0.50 (x86_64-pc-linux-gnu)
MIME-Version: 1.0
Content-Type: text/plain
X-GND-Sasl: juri@HIDDEN
X-Spam-Score: -0.7 (/)
X-Debbugs-Envelope-To: 69712
Cc: 69712 <at> debbugs.gnu.org
X-BeenThere: debbugs-submit <at> debbugs.gnu.org
X-Mailman-Version: 2.1.18
Precedence: list
List-Id: <debbugs-submit.debbugs.gnu.org>
List-Unsubscribe: <https://debbugs.gnu.org/cgi-bin/mailman/options/debbugs-submit>, 
 <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=unsubscribe>
List-Archive: <https://debbugs.gnu.org/cgi-bin/mailman/private/debbugs-submit/>
List-Post: <mailto:debbugs-submit <at> debbugs.gnu.org>
List-Help: <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=help>
List-Subscribe: <https://debbugs.gnu.org/cgi-bin/mailman/listinfo/debbugs-submit>, 
 <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=subscribe>
Errors-To: debbugs-submit-bounces <at> debbugs.gnu.org
Sender: "Debbugs-submit" <debbugs-submit-bounces <at> debbugs.gnu.org>
X-Spam-Score: -1.7 (-)

> I suggest the following fix instead.
> Can you confirm that it fixes the problem for you as well?
>
> diff --git a/lisp/emacs-lisp/package.el b/lisp/emacs-lisp/package.el
> @@ -2941,7 +2941,7 @@ describe-package-1
>          (insert " "))
>        (insert "\n"))
>      (when maintainers
> -      (unless (proper-list-p maintainers)
> +      (when (stringp (car maintainers))
>          (setq maintainers (list maintainers)))

I confirm this completely fixes the problem.




Information forwarded to bug-gnu-emacs@HIDDEN:
bug#69712; Package emacs. Full text available.

Message received at 69712 <at> debbugs.gnu.org:


Received: (at 69712) by debbugs.gnu.org; 22 Mar 2024 19:10:22 +0000
From debbugs-submit-bounces <at> debbugs.gnu.org Fri Mar 22 15:10:22 2024
Received: from localhost ([127.0.0.1]:42506 helo=debbugs.gnu.org)
	by debbugs.gnu.org with esmtp (Exim 4.84_2)
	(envelope-from <debbugs-submit-bounces <at> debbugs.gnu.org>)
	id 1rnkHR-0006yh-Rs
	for submit <at> debbugs.gnu.org; Fri, 22 Mar 2024 15:10:22 -0400
Received: from mailscanner.iro.umontreal.ca ([132.204.25.50]:19714)
 by debbugs.gnu.org with esmtp (Exim 4.84_2)
 (envelope-from <monnier@HIDDEN>) id 1rnkAm-0006dn-DR
 for 69712 <at> debbugs.gnu.org; Fri, 22 Mar 2024 15:03:25 -0400
Received: from pmg1.iro.umontreal.ca (localhost.localdomain [127.0.0.1])
 by pmg1.iro.umontreal.ca (Proxmox) with ESMTP id AFF85100196;
 Fri, 22 Mar 2024 15:02:36 -0400 (EDT)
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=iro.umontreal.ca;
 s=mail; t=1711134155;
 bh=e8IhsV0UxS4EPlFaiHSxeKitLZnlYXum0lbvsr20sDo=;
 h=From:To:Cc:Subject:In-Reply-To:References:Date:From;
 b=P5hGFPr2LzkTJ1hezpew/XpVRA4YGtmV3GVsdtOfzQcJmbzHkbH3tu8kghSohZoOS
 7opHY9cHVAQRnUf78YVHXwVosz+BbpnPt6wvM1Md8FR98leAVbZu6YLvdDpjcfVRo2
 HSG226Wtnzl7Ll1rCywyOY5tQlvVTdX7fMcPiEtieWr/H/A6T1XaooQN+1zBWcNERr
 FdoqW4OsCDQk+kVQTGJxWGf7Y5I+0VZ+I2f8pIOozuvIPeD6liLCMJQuiIEHJ9SwZH
 fK/jPlZvHgJJrlVw2439XPSDM4m7nUGYhK/ZhhxOM2Cs1gzHFjl5ULt7NKrkuKm3Mz
 uEw0crWtubqCA==
Received: from mail01.iro.umontreal.ca (unknown [172.31.2.1])
 by pmg1.iro.umontreal.ca (Proxmox) with ESMTP id C23211000FC;
 Fri, 22 Mar 2024 15:02:35 -0400 (EDT)
Received: from alfajor (modemcable031.210-178-173.mc.videotron.ca
 [173.178.210.31])
 by mail01.iro.umontreal.ca (Postfix) with ESMTPSA id A4DA51203B3;
 Fri, 22 Mar 2024 15:02:35 -0400 (EDT)
From: Stefan Monnier <monnier@HIDDEN>
To: Juri Linkov <juri@HIDDEN>
Subject: Re: bug#69712: Package author/maintainer printing fix
In-Reply-To: <86h6hegr0b.fsf@HIDDEN> (Juri Linkov's message of "Sun, 
 10 Mar 2024 19:03:16 +0200")
Message-ID: <jwvedc26ql6.fsf-monnier+emacs@HIDDEN>
References: <86h6hegr0b.fsf@HIDDEN>
Date: Fri, 22 Mar 2024 15:02:35 -0400
User-Agent: Gnus/5.13 (Gnus v5.13)
MIME-Version: 1.0
Content-Type: text/plain
X-SPAM-INFO: Spam detection results:  0
 ALL_TRUSTED                -1 Passed through trusted hosts only via SMTP
 BAYES_00                 -1.9 Bayes spam probability is 0 to 1%
 DKIM_SIGNED               0.1 Message has a DKIM or DK signature,
 not necessarily valid
 DKIM_VALID -0.1 Message has at least one valid DKIM or DK signature
 DKIM_VALID_AU -0.1 Message has a valid DKIM or DK signature from author's
 domain
 DKIM_VALID_EF -0.1 Message has a valid DKIM or DK signature from envelope-from
 domain
X-SPAM-LEVEL: 
X-Spam-Score: -2.3 (--)
X-Debbugs-Envelope-To: 69712
Cc: 69712 <at> debbugs.gnu.org
X-BeenThere: debbugs-submit <at> debbugs.gnu.org
X-Mailman-Version: 2.1.18
Precedence: list
List-Id: <debbugs-submit.debbugs.gnu.org>
List-Unsubscribe: <https://debbugs.gnu.org/cgi-bin/mailman/options/debbugs-submit>, 
 <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=unsubscribe>
List-Archive: <https://debbugs.gnu.org/cgi-bin/mailman/private/debbugs-submit/>
List-Post: <mailto:debbugs-submit <at> debbugs.gnu.org>
List-Help: <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=help>
List-Subscribe: <https://debbugs.gnu.org/cgi-bin/mailman/listinfo/debbugs-submit>, 
 <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=subscribe>
Errors-To: debbugs-submit-bounces <at> debbugs.gnu.org
Sender: "Debbugs-submit" <debbugs-submit-bounces <at> debbugs.gnu.org>
X-Spam-Score: -3.3 (---)

> Here is the fix:

I suggest the following fix instead.
Can you confirm that it fixes the problem for you as well?


        Stefan


diff --git a/lisp/emacs-lisp/package.el b/lisp/emacs-lisp/package.el
index fe7b10f569a..ab1731aeb54 100644
--- a/lisp/emacs-lisp/package.el
+++ b/lisp/emacs-lisp/package.el
@@ -2941,7 +2941,7 @@ describe-package-1
         (insert " "))
       (insert "\n"))
     (when maintainers
-      (unless (proper-list-p maintainers)
+      (when (stringp (car maintainers))
         (setq maintainers (list maintainers)))
       (package--print-help-section
           (if (cdr maintainers) "Maintainers" "Maintainer"))





Information forwarded to bug-gnu-emacs@HIDDEN:
bug#69712; Package emacs. Full text available.

Message received at 69712 <at> debbugs.gnu.org:


Received: (at 69712) by debbugs.gnu.org; 22 Mar 2024 16:18:46 +0000
From debbugs-submit-bounces <at> debbugs.gnu.org Fri Mar 22 12:18:45 2024
Received: from localhost ([127.0.0.1]:34458 helo=debbugs.gnu.org)
	by debbugs.gnu.org with esmtp (Exim 4.84_2)
	(envelope-from <debbugs-submit-bounces <at> debbugs.gnu.org>)
	id 1rnhbR-0007jD-Mc
	for submit <at> debbugs.gnu.org; Fri, 22 Mar 2024 12:18:45 -0400
Received: from relay8-d.mail.gandi.net ([217.70.183.201]:35719)
 by debbugs.gnu.org with esmtp (Exim 4.84_2)
 (envelope-from <juri@HIDDEN>) id 1rnhbO-0007ih-0N
 for 69712 <at> debbugs.gnu.org; Fri, 22 Mar 2024 12:18:43 -0400
Received: by mail.gandi.net (Postfix) with ESMTPSA id 6DA891BF205;
 Fri, 22 Mar 2024 16:17:52 +0000 (UTC)
From: Juri Linkov <juri@HIDDEN>
To: Stefan Monnier <monnier@HIDDEN>
Subject: Re: bug#69712: Package author/maintainer printing fix
In-Reply-To: <jwvwmpu8o3a.fsf-monnier+emacs@HIDDEN> (Stefan Monnier's message
 of "Fri, 22 Mar 2024 08:10:31 -0400")
Organization: LINKOV.NET
References: <86h6hegr0b.fsf@HIDDEN>
 <jwvwmpu8o3a.fsf-monnier+emacs@HIDDEN>
Date: Fri, 22 Mar 2024 18:08:46 +0200
Message-ID: <864jcy8dhl.fsf@HIDDEN>
User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/30.0.50 (x86_64-pc-linux-gnu)
MIME-Version: 1.0
Content-Type: text/plain
X-GND-Sasl: juri@HIDDEN
X-Spam-Score: -0.7 (/)
X-Debbugs-Envelope-To: 69712
Cc: 69712 <at> debbugs.gnu.org
X-BeenThere: debbugs-submit <at> debbugs.gnu.org
X-Mailman-Version: 2.1.18
Precedence: list
List-Id: <debbugs-submit.debbugs.gnu.org>
List-Unsubscribe: <https://debbugs.gnu.org/cgi-bin/mailman/options/debbugs-submit>, 
 <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=unsubscribe>
List-Archive: <https://debbugs.gnu.org/cgi-bin/mailman/private/debbugs-submit/>
List-Post: <mailto:debbugs-submit <at> debbugs.gnu.org>
List-Help: <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=help>
List-Subscribe: <https://debbugs.gnu.org/cgi-bin/mailman/listinfo/debbugs-submit>, 
 <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=subscribe>
Errors-To: debbugs-submit-bounces <at> debbugs.gnu.org
Sender: "Debbugs-submit" <debbugs-submit-bounces <at> debbugs.gnu.org>
X-Spam-Score: -1.7 (-)

>> There are many packages with non-dot author/maintainer format that fail with
>
> Could you give some examples?

An example is chaos-mode on MELPA.  There are many more.
For example, few of them near chaos-mode:
challenger-deep-theme, chatgpt-shell, etc.




Information forwarded to bug-gnu-emacs@HIDDEN:
bug#69712; Package emacs. Full text available.

Message received at 69712 <at> debbugs.gnu.org:


Received: (at 69712) by debbugs.gnu.org; 22 Mar 2024 16:18:40 +0000
From debbugs-submit-bounces <at> debbugs.gnu.org Fri Mar 22 12:18:40 2024
Received: from localhost ([127.0.0.1]:34455 helo=debbugs.gnu.org)
	by debbugs.gnu.org with esmtp (Exim 4.84_2)
	(envelope-from <debbugs-submit-bounces <at> debbugs.gnu.org>)
	id 1rnhbM-0007iu-Ea
	for submit <at> debbugs.gnu.org; Fri, 22 Mar 2024 12:18:40 -0400
Received: from relay5-d.mail.gandi.net ([217.70.183.197]:43279)
 by debbugs.gnu.org with esmtp (Exim 4.84_2)
 (envelope-from <juri@HIDDEN>) id 1rnhbK-0007ib-FA
 for 69712 <at> debbugs.gnu.org; Fri, 22 Mar 2024 12:18:39 -0400
Received: by mail.gandi.net (Postfix) with ESMTPSA id C42131C0007;
 Fri, 22 Mar 2024 16:17:50 +0000 (UTC)
From: Juri Linkov <juri@HIDDEN>
To: Philip Kaludercic <philipk@HIDDEN>
Subject: Re: bug#69712: Package author/maintainer printing fix
In-Reply-To: <87frwifyad.fsf@HIDDEN> (Philip Kaludercic's message of "Fri, 
 22 Mar 2024 08:47:38 +0000")
Organization: LINKOV.NET
References: <86h6hegr0b.fsf@HIDDEN> <87frwifyad.fsf@HIDDEN>
Date: Fri, 22 Mar 2024 18:07:01 +0200
Message-ID: <86a5mq8dki.fsf@HIDDEN>
User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/30.0.50 (x86_64-pc-linux-gnu)
MIME-Version: 1.0
Content-Type: text/plain
X-GND-Sasl: juri@HIDDEN
X-Spam-Score: -0.7 (/)
X-Debbugs-Envelope-To: 69712
Cc: 69712 <at> debbugs.gnu.org
X-BeenThere: debbugs-submit <at> debbugs.gnu.org
X-Mailman-Version: 2.1.18
Precedence: list
List-Id: <debbugs-submit.debbugs.gnu.org>
List-Unsubscribe: <https://debbugs.gnu.org/cgi-bin/mailman/options/debbugs-submit>, 
 <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=unsubscribe>
List-Archive: <https://debbugs.gnu.org/cgi-bin/mailman/private/debbugs-submit/>
List-Post: <mailto:debbugs-submit <at> debbugs.gnu.org>
List-Help: <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=help>
List-Subscribe: <https://debbugs.gnu.org/cgi-bin/mailman/listinfo/debbugs-submit>, 
 <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=subscribe>
Errors-To: debbugs-submit-bounces <at> debbugs.gnu.org
Sender: "Debbugs-submit" <debbugs-submit-bounces <at> debbugs.gnu.org>
X-Spam-Score: -1.7 (-)

>> Here is the fix:
>
> Is there any reason not to apply this?  It makes sense to me.

I waited until the related bug#68660 will be fixed, as J.P. noted.
But maybe fixing doesn't depend on bug#68660?




Information forwarded to bug-gnu-emacs@HIDDEN:
bug#69712; Package emacs. Full text available.

Message received at 69712 <at> debbugs.gnu.org:


Received: (at 69712) by debbugs.gnu.org; 22 Mar 2024 12:11:26 +0000
From debbugs-submit-bounces <at> debbugs.gnu.org Fri Mar 22 08:11:26 2024
Received: from localhost ([127.0.0.1]:47603 helo=debbugs.gnu.org)
	by debbugs.gnu.org with esmtp (Exim 4.84_2)
	(envelope-from <debbugs-submit-bounces <at> debbugs.gnu.org>)
	id 1rndk6-00029V-Jq
	for submit <at> debbugs.gnu.org; Fri, 22 Mar 2024 08:11:26 -0400
Received: from mailscanner.iro.umontreal.ca ([132.204.25.50]:54547)
 by debbugs.gnu.org with esmtp (Exim 4.84_2)
 (envelope-from <monnier@HIDDEN>) id 1rndk4-000296-Hd
 for 69712 <at> debbugs.gnu.org; Fri, 22 Mar 2024 08:11:25 -0400
Received: from pmg1.iro.umontreal.ca (localhost.localdomain [127.0.0.1])
 by pmg1.iro.umontreal.ca (Proxmox) with ESMTP id 7289210004C;
 Fri, 22 Mar 2024 08:10:37 -0400 (EDT)
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=iro.umontreal.ca;
 s=mail; t=1711109432;
 bh=hM4+7K1OjosGDWMh0WwDX0MrtPra+Qq4rwqOwM8MxXQ=;
 h=From:To:Cc:Subject:In-Reply-To:References:Date:From;
 b=A8+AjXCLLDpAO8ufUc3+Ozf/t/H4E5h5uhlPJqjJeOl2sIKXZdu7I2mPZTLDKdsGg
 qvRssNymjSzkfM0MyOf0XsFgovVieabns7OBOxV1R6MhcgiNZmsu9h7v1b4iDl95b5
 1eQGkEzhCrqGwKr4Q2IrzIOe5aoiw6CWa5HRuOm5hdOrKkcVjWZ5jvEwYnzhD+vFr1
 7UGrJS1sQ5zUm0KS+tcOot4OoTP9J2v7oAMr+oanKRzXiC69G+rFVc4+N+/GQSRK+N
 suCzVybDxYpkTctgCYpS5vsIsLX/owNMZtOp/2aLOqgw6ZriuIaMRXb9UA4qGIWvAH
 8k6/iS9NYi+4g==
Received: from mail01.iro.umontreal.ca (unknown [172.31.2.1])
 by pmg1.iro.umontreal.ca (Proxmox) with ESMTP id 2D560100046;
 Fri, 22 Mar 2024 08:10:32 -0400 (EDT)
Received: from pastel (unknown [104.247.238.200])
 by mail01.iro.umontreal.ca (Postfix) with ESMTPSA id 05ACD12030C;
 Fri, 22 Mar 2024 08:10:32 -0400 (EDT)
From: Stefan Monnier <monnier@HIDDEN>
To: Juri Linkov <juri@HIDDEN>
Subject: Re: bug#69712: Package author/maintainer printing fix
In-Reply-To: <86h6hegr0b.fsf@HIDDEN> (Juri Linkov's message of "Sun, 
 10 Mar 2024 19:03:16 +0200")
Message-ID: <jwvwmpu8o3a.fsf-monnier+emacs@HIDDEN>
References: <86h6hegr0b.fsf@HIDDEN>
Date: Fri, 22 Mar 2024 08:10:31 -0400
User-Agent: Gnus/5.13 (Gnus v5.13)
MIME-Version: 1.0
Content-Type: text/plain
X-SPAM-INFO: Spam detection results:  0
 ALL_TRUSTED                -1 Passed through trusted hosts only via SMTP
 AWL -0.168 Adjusted score from AWL reputation of From: address
 BAYES_00                 -1.9 Bayes spam probability is 0 to 1%
 DKIM_SIGNED               0.1 Message has a DKIM or DK signature,
 not necessarily valid
 DKIM_VALID -0.1 Message has at least one valid DKIM or DK signature
 DKIM_VALID_AU -0.1 Message has a valid DKIM or DK signature from author's
 domain
 DKIM_VALID_EF -0.1 Message has a valid DKIM or DK signature from envelope-from
 domain
X-SPAM-LEVEL: 
X-Spam-Score: -2.3 (--)
X-Debbugs-Envelope-To: 69712
Cc: 69712 <at> debbugs.gnu.org
X-BeenThere: debbugs-submit <at> debbugs.gnu.org
X-Mailman-Version: 2.1.18
Precedence: list
List-Id: <debbugs-submit.debbugs.gnu.org>
List-Unsubscribe: <https://debbugs.gnu.org/cgi-bin/mailman/options/debbugs-submit>, 
 <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=unsubscribe>
List-Archive: <https://debbugs.gnu.org/cgi-bin/mailman/private/debbugs-submit/>
List-Post: <mailto:debbugs-submit <at> debbugs.gnu.org>
List-Help: <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=help>
List-Subscribe: <https://debbugs.gnu.org/cgi-bin/mailman/listinfo/debbugs-submit>, 
 <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=subscribe>
Errors-To: debbugs-submit-bounces <at> debbugs.gnu.org
Sender: "Debbugs-submit" <debbugs-submit-bounces <at> debbugs.gnu.org>
X-Spam-Score: -3.3 (---)

> There are many packages with non-dot author/maintainer format that fail with

Could you give some examples?


        Stefan





Information forwarded to bug-gnu-emacs@HIDDEN:
bug#69712; Package emacs. Full text available.

Message received at 69712 <at> debbugs.gnu.org:


Received: (at 69712) by debbugs.gnu.org; 22 Mar 2024 11:40:23 +0000
From debbugs-submit-bounces <at> debbugs.gnu.org Fri Mar 22 07:40:23 2024
Received: from localhost ([127.0.0.1]:45162 helo=debbugs.gnu.org)
	by debbugs.gnu.org with esmtp (Exim 4.84_2)
	(envelope-from <debbugs-submit-bounces <at> debbugs.gnu.org>)
	id 1rndFu-0000YB-JP
	for submit <at> debbugs.gnu.org; Fri, 22 Mar 2024 07:40:23 -0400
Received: from eggs.gnu.org ([209.51.188.92]:48914)
 by debbugs.gnu.org with esmtp (Exim 4.84_2)
 (envelope-from <eliz@HIDDEN>) id 1rndFD-0000Vh-PN
 for 69712 <at> debbugs.gnu.org; Fri, 22 Mar 2024 07:39:32 -0400
Received: from fencepost.gnu.org ([2001:470:142:3::e])
 by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256)
 (Exim 4.90_1) (envelope-from <eliz@HIDDEN>)
 id 1rndES-0005Lk-Aj; Fri, 22 Mar 2024 07:38:44 -0400
DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=gnu.org;
 s=fencepost-gnu-org; h=References:Subject:In-Reply-To:To:From:Date:
 mime-version; bh=yp/EuC/Tia2iAclU5h1+N6W1CGJvG6ojL3VARAKshIo=; b=ouhhqYCg1VZt
 e/Vqf00CFB6MbVvrEwTsylU7bIbRLMnUFNLhYM6cinJ2OGnUT88Jrw7OV/yrE6gKBTGmmZDX9lJjQ
 /WEwoblO9yt2+ZEjDO1jGQ1iYUqhvtTizCQ/tUP6pgUDcuaUo+bVB9mGJmUERpRf9yHNHhP0y5h1/
 dNp7kJrErIlVPU9YOh3kbpWB5oeO1ktHgohTy4sQDgYI6sIboTTPcWpceYs+7xSMJsLepA/KrkHSR
 sLvl6TSRVPGmOa0BbIpJtvbPXnN20hO5suiqWEk23agb3xa+BJFagF1vc22//GVSX2bYcdq4dHs8O
 e6/ldQfKM06nMmknsYZkaQ==;
Date: Fri, 22 Mar 2024 13:38:38 +0200
Message-Id: <86a5mq1oox.fsf@HIDDEN>
From: Eli Zaretskii <eliz@HIDDEN>
To: Philip Kaludercic <philipk@HIDDEN>,
 Stefan Monnier <monnier@HIDDEN>
In-Reply-To: <87frwifyad.fsf@HIDDEN> (message from Philip Kaludercic on
 Fri, 22 Mar 2024 08:47:38 +0000)
Subject: Re: bug#69712: Package author/maintainer printing fix
References: <86h6hegr0b.fsf@HIDDEN> <87frwifyad.fsf@HIDDEN>
X-Spam-Score: -2.3 (--)
X-Debbugs-Envelope-To: 69712
Cc: 69712 <at> debbugs.gnu.org, juri@HIDDEN
X-BeenThere: debbugs-submit <at> debbugs.gnu.org
X-Mailman-Version: 2.1.18
Precedence: list
List-Id: <debbugs-submit.debbugs.gnu.org>
List-Unsubscribe: <https://debbugs.gnu.org/cgi-bin/mailman/options/debbugs-submit>, 
 <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=unsubscribe>
List-Archive: <https://debbugs.gnu.org/cgi-bin/mailman/private/debbugs-submit/>
List-Post: <mailto:debbugs-submit <at> debbugs.gnu.org>
List-Help: <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=help>
List-Subscribe: <https://debbugs.gnu.org/cgi-bin/mailman/listinfo/debbugs-submit>, 
 <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=subscribe>
Errors-To: debbugs-submit-bounces <at> debbugs.gnu.org
Sender: "Debbugs-submit" <debbugs-submit-bounces <at> debbugs.gnu.org>
X-Spam-Score: -3.3 (---)

> Cc: 69712 <at> debbugs.gnu.org
> From: Philip Kaludercic <philipk@HIDDEN>
> Date: Fri, 22 Mar 2024 08:47:38 +0000
> 
> Juri Linkov <juri@HIDDEN> writes:
> 
> > There are many packages with non-dot author/maintainer format that fail with
> >
> > Debugger entered--Lisp error: (wrong-type-argument listp "XXIV")
> >   car("XXIV")
> >   package--print-email-button("XXIV")
> >   describe-package-1(#s(package-desc :name chaos-mode ((:authors ("XXIV")) (:maintainers ("XXIV")) (:maintainer "XXIV"))))
> >   describe-package(#s(package-desc :name chaos-mode ((:authors ("XXIV")) (:maintainers ("XXIV")) (:maintainer "XXIV"))))
> >   package-menu-describe-package(#<marker (moves after insertion) at 67389 in *Packages*>)
> >   button-activate(#<marker (moves after insertion) at 67389 in *Packages*> nil)
> >   push-button(67389)
> >   funcall-interactively(push-button 67389)
> >   command-execute(push-button)
> >
> > Here is the fix:
> 
> Is there any reason not to apply this?  It makes sense to me.

Stefan, any comments on the proposal below?

> > diff --git a/lisp/emacs-lisp/package.el b/lisp/emacs-lisp/package.el
> > index fe7b10f569a..790860df2a7 100644
> > --- a/lisp/emacs-lisp/package.el
> > +++ b/lisp/emacs-lisp/package.el
> > @@ -3082,19 +3082,21 @@ package--print-email-button
> >    "Insert a button whose action will send an email to RECIPIENT.
> >  NAME should have the form (FULLNAME . EMAIL) where FULLNAME is
> >  either a full name or nil, and EMAIL is a valid email address."
> > -  (when (car recipient)
> > -    (insert (car recipient)))
> > -  (when (and (car recipient) (cdr recipient))
> > -    (insert " "))
> > -  (when (cdr recipient)
> > -    (insert "<")
> > -    (insert-text-button (cdr recipient)
> > -                        'follow-link t
> > -                        'action (lambda (_)
> > -                                  (compose-mail
> > -                                   (format "%s <%s>" (car recipient) (cdr recipient)))))
> > -    (insert ">"))
> > -  (insert "\n"))
> > +  (if (stringp recipient)
> > +      (insert recipient "\n")
> > +    (when (car recipient)
> > +      (insert (car recipient)))
> > +    (when (and (car recipient) (cdr recipient))
> > +      (insert " "))
> > +    (when (cdr recipient)
> > +      (insert "<")
> > +      (insert-text-button (cdr recipient)
> > +                          'follow-link t
> > +                          'action (lambda (_)
> > +                                    (compose-mail
> > +                                     (format "%s <%s>" (car recipient) (cdr recipient)))))
> > +      (insert ">"))
> > +    (insert "\n")))
> >  
> >  
> >  ;;;; Package menu mode.
> >
> 
> -- 
> 	Philip Kaludercic on peregrine
> 
> 
> 
> 




Information forwarded to bug-gnu-emacs@HIDDEN:
bug#69712; Package emacs. Full text available.

Message received at 69712 <at> debbugs.gnu.org:


Received: (at 69712) by debbugs.gnu.org; 22 Mar 2024 08:55:24 +0000
From debbugs-submit-bounces <at> debbugs.gnu.org Fri Mar 22 04:55:23 2024
Received: from localhost ([127.0.0.1]:33973 helo=debbugs.gnu.org)
	by debbugs.gnu.org with esmtp (Exim 4.84_2)
	(envelope-from <debbugs-submit-bounces <at> debbugs.gnu.org>)
	id 1rnagN-0003c1-4D
	for submit <at> debbugs.gnu.org; Fri, 22 Mar 2024 04:55:23 -0400
Received: from mout02.posteo.de ([185.67.36.66]:39379)
 by debbugs.gnu.org with esmtp (Exim 4.84_2)
 (envelope-from <philipk@HIDDEN>) id 1rnaZe-00039f-V8
 for 69712 <at> debbugs.gnu.org; Fri, 22 Mar 2024 04:48:28 -0400
Received: from submission (posteo.de [185.67.36.169]) 
 by mout02.posteo.de (Postfix) with ESMTPS id 5E024240103
 for <69712 <at> debbugs.gnu.org>; Fri, 22 Mar 2024 09:47:40 +0100 (CET)
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=posteo.net; s=2017;
 t=1711097260; bh=yD25mcGXo2dD+HZ4drVDFkQoII7ORrKpBov0rTb0NVg=;
 h=From:To:Cc:Subject:OpenPGP:Date:Message-ID:MIME-Version:
 Content-Type:From;
 b=RR/zfn2FsohQ4qx+e+x1rNz7X3rdPbVTeMqYeVMOSvKwj0GrxWY6zfK9o0r3Qk+8M
 B3n8FlgOYhya90Luxb4QOnyOX9uTMhl/A/Bp0Ablsqi0P4/hKXMl3o+qTW3Zgntv9c
 VhFqI7QZ+h6+fJZrC85FlkCEJvHOFgY4jN0E6S/IOmbox5Zdf896++DJ0aIQ+lPUrx
 Ond9xrdJ5OANA5h6jpjbwitbdWiZJyIULQbJ9vX2lVdyzXdZVi38iy+0qTtLdK7v6z
 A0vJjvKDqzyXNOgLrcloXtXtEXZSUgqNdK4Y+ANvfCBlEJKZUIE3JDzUyK93gHeRBq
 b9LkGuV0bE9iw==
Received: from customer (localhost [127.0.0.1])
 by submission (posteo.de) with ESMTPSA id 4V1GDW4czBz9rxD;
 Fri, 22 Mar 2024 09:47:39 +0100 (CET)
From: Philip Kaludercic <philipk@HIDDEN>
To: Juri Linkov <juri@HIDDEN>
Subject: Re: bug#69712: Package author/maintainer printing fix
In-Reply-To: <86h6hegr0b.fsf@HIDDEN> (Juri Linkov's message of "Sun, 
 10 Mar 2024 19:03:16 +0200")
References: <86h6hegr0b.fsf@HIDDEN>
OpenPGP: id=7126E1DE2F0CE35C770BED01F2C3CC513DB89F66;
 url="https://keys.openpgp.org/vks/v1/by-fingerprint/7126E1DE2F0CE35C770BED01F2C3CC513DB89F66";
 preference=signencrypt
Date: Fri, 22 Mar 2024 08:47:38 +0000
Message-ID: <87frwifyad.fsf@HIDDEN>
MIME-Version: 1.0
Content-Type: text/plain
X-Spam-Score: -2.3 (--)
X-Debbugs-Envelope-To: 69712
Cc: 69712 <at> debbugs.gnu.org
X-BeenThere: debbugs-submit <at> debbugs.gnu.org
X-Mailman-Version: 2.1.18
Precedence: list
List-Id: <debbugs-submit.debbugs.gnu.org>
List-Unsubscribe: <https://debbugs.gnu.org/cgi-bin/mailman/options/debbugs-submit>, 
 <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=unsubscribe>
List-Archive: <https://debbugs.gnu.org/cgi-bin/mailman/private/debbugs-submit/>
List-Post: <mailto:debbugs-submit <at> debbugs.gnu.org>
List-Help: <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=help>
List-Subscribe: <https://debbugs.gnu.org/cgi-bin/mailman/listinfo/debbugs-submit>, 
 <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=subscribe>
Errors-To: debbugs-submit-bounces <at> debbugs.gnu.org
Sender: "Debbugs-submit" <debbugs-submit-bounces <at> debbugs.gnu.org>
X-Spam-Score: -3.3 (---)

Juri Linkov <juri@HIDDEN> writes:

> There are many packages with non-dot author/maintainer format that fail with
>
> Debugger entered--Lisp error: (wrong-type-argument listp "XXIV")
>   car("XXIV")
>   package--print-email-button("XXIV")
>   describe-package-1(#s(package-desc :name chaos-mode ((:authors ("XXIV")) (:maintainers ("XXIV")) (:maintainer "XXIV"))))
>   describe-package(#s(package-desc :name chaos-mode ((:authors ("XXIV")) (:maintainers ("XXIV")) (:maintainer "XXIV"))))
>   package-menu-describe-package(#<marker (moves after insertion) at 67389 in *Packages*>)
>   button-activate(#<marker (moves after insertion) at 67389 in *Packages*> nil)
>   push-button(67389)
>   funcall-interactively(push-button 67389)
>   command-execute(push-button)
>
> Here is the fix:

Is there any reason not to apply this?  It makes sense to me.

> diff --git a/lisp/emacs-lisp/package.el b/lisp/emacs-lisp/package.el
> index fe7b10f569a..790860df2a7 100644
> --- a/lisp/emacs-lisp/package.el
> +++ b/lisp/emacs-lisp/package.el
> @@ -3082,19 +3082,21 @@ package--print-email-button
>    "Insert a button whose action will send an email to RECIPIENT.
>  NAME should have the form (FULLNAME . EMAIL) where FULLNAME is
>  either a full name or nil, and EMAIL is a valid email address."
> -  (when (car recipient)
> -    (insert (car recipient)))
> -  (when (and (car recipient) (cdr recipient))
> -    (insert " "))
> -  (when (cdr recipient)
> -    (insert "<")
> -    (insert-text-button (cdr recipient)
> -                        'follow-link t
> -                        'action (lambda (_)
> -                                  (compose-mail
> -                                   (format "%s <%s>" (car recipient) (cdr recipient)))))
> -    (insert ">"))
> -  (insert "\n"))
> +  (if (stringp recipient)
> +      (insert recipient "\n")
> +    (when (car recipient)
> +      (insert (car recipient)))
> +    (when (and (car recipient) (cdr recipient))
> +      (insert " "))
> +    (when (cdr recipient)
> +      (insert "<")
> +      (insert-text-button (cdr recipient)
> +                          'follow-link t
> +                          'action (lambda (_)
> +                                    (compose-mail
> +                                     (format "%s <%s>" (car recipient) (cdr recipient)))))
> +      (insert ">"))
> +    (insert "\n")))
>  
>  
>  ;;;; Package menu mode.
>

-- 
	Philip Kaludercic on peregrine




Information forwarded to bug-gnu-emacs@HIDDEN:
bug#69712; Package emacs. Full text available.

Message received at 69712 <at> debbugs.gnu.org:


Received: (at 69712) by debbugs.gnu.org; 12 Mar 2024 04:56:21 +0000
From debbugs-submit-bounces <at> debbugs.gnu.org Tue Mar 12 00:56:21 2024
Received: from localhost ([127.0.0.1]:41582 helo=debbugs.gnu.org)
	by debbugs.gnu.org with esmtp (Exim 4.84_2)
	(envelope-from <debbugs-submit-bounces <at> debbugs.gnu.org>)
	id 1rjuBY-0005CJ-UU
	for submit <at> debbugs.gnu.org; Tue, 12 Mar 2024 00:56:21 -0400
Received: from mail-108-mta41.mxroute.com ([136.175.108.41]:45375)
 by debbugs.gnu.org with esmtp (Exim 4.84_2)
 (envelope-from <jp@HIDDEN>) id 1rjuBT-0005C5-TX
 for 69712 <at> debbugs.gnu.org; Tue, 12 Mar 2024 00:56:19 -0400
Received: from filter006.mxroute.com ([136.175.111.2] filter006.mxroute.com)
 (Authenticated sender: mN4UYu2MZsgR)
 by mail-108-mta41.mxroute.com (ZoneMTA) with ESMTPSA id 18e31041ca60003bea.001
 for <69712 <at> debbugs.gnu.org>
 (version=TLSv1.3 cipher=TLS_AES_256_GCM_SHA384);
 Tue, 12 Mar 2024 04:55:36 +0000
X-Zone-Loop: b0b90c9c4fb65ff9f030bc29a3ac42fa7000a6b44913
X-Originating-IP: [136.175.111.2]
DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=neverwas.me
 ; s=x;
 h=Content-Type:MIME-Version:Message-ID:Date:References:In-Reply-To:
 Subject:Cc:To:From:Sender:Reply-To:Content-Transfer-Encoding:Content-ID:
 Content-Description:Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc
 :Resent-Message-ID:List-Id:List-Help:List-Unsubscribe:List-Subscribe:
 List-Post:List-Owner:List-Archive;
 bh=OqZf+TRluCEs9RdHZWv63cx2uXmX4eAj6/4WEKH8vjw=; b=YQoYWW1j123gleU9UMNI1XSYC8
 nDz1cVZEjSqpfbzowm9yVN4IMoJ4tSjDB7KU4B2DiST1ZcTuSVLeazkmn0pG77EcCo5dJ6Y+Qn4Ad
 7Yp+12JW1LGuzZFIPSeJALLaVqCoDBpliQAKBo8TQ1aCa4le9e+3HudTEJkiVaE/0GitrM4ws5/rw
 qXCzIF/KJ7zlGiyB+pMVRNHqxLBR2LxETagZSOo1938IQKwo4WwZAbS+cL/3f51Qqsb1tDKonV88b
 w15kGnqvv2JUgtOq3979hUfM03uKTOjJDgx7h2AS6Y0ppcQy4iNwYimJLipWHLo24z37nS9ScevS2
 Nf2XlUSg==;
From: "J.P." <jp@HIDDEN>
To: Juri Linkov <juri@HIDDEN>
Subject: Re: bug#69712: Package author/maintainer printing fix
In-Reply-To: <86h6hegr0b.fsf@HIDDEN> (Juri Linkov's message of "Sun, 
 10 Mar 2024 19:03:16 +0200")
References: <86h6hegr0b.fsf@HIDDEN>
Date: Mon, 11 Mar 2024 21:55:33 -0700
Message-ID: <87h6hc6oca.fsf@HIDDEN>
User-Agent: Gnus/5.13 (Gnus v5.13)
MIME-Version: 1.0
Content-Type: text/plain
X-Authenticated-Id: masked@HIDDEN
X-Spam-Score: -0.0 (/)
X-Debbugs-Envelope-To: 69712
Cc: 69712 <at> debbugs.gnu.org
X-BeenThere: debbugs-submit <at> debbugs.gnu.org
X-Mailman-Version: 2.1.18
Precedence: list
List-Id: <debbugs-submit.debbugs.gnu.org>
List-Unsubscribe: <https://debbugs.gnu.org/cgi-bin/mailman/options/debbugs-submit>, 
 <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=unsubscribe>
List-Archive: <https://debbugs.gnu.org/cgi-bin/mailman/private/debbugs-submit/>
List-Post: <mailto:debbugs-submit <at> debbugs.gnu.org>
List-Help: <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=help>
List-Subscribe: <https://debbugs.gnu.org/cgi-bin/mailman/listinfo/debbugs-submit>, 
 <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=subscribe>
Errors-To: debbugs-submit-bounces <at> debbugs.gnu.org
Sender: "Debbugs-submit" <debbugs-submit-bounces <at> debbugs.gnu.org>
X-Spam-Score: -1.0 (-)

Hi Juri,

Don't mind me. Just wanted to note a somewhat related bug:

  https://debbugs.gnu.org/cgi/bugreport.cgi?bug=68660

Thanks,
J.P.




Information forwarded to bug-gnu-emacs@HIDDEN:
bug#69712; Package emacs. Full text available.

Message received at submit <at> debbugs.gnu.org:


Received: (at submit) by debbugs.gnu.org; 10 Mar 2024 17:35:31 +0000
From debbugs-submit-bounces <at> debbugs.gnu.org Sun Mar 10 13:35:31 2024
Received: from localhost ([127.0.0.1]:37826 helo=debbugs.gnu.org)
	by debbugs.gnu.org with esmtp (Exim 4.84_2)
	(envelope-from <debbugs-submit-bounces <at> debbugs.gnu.org>)
	id 1rjN58-0008AS-QA
	for submit <at> debbugs.gnu.org; Sun, 10 Mar 2024 13:35:31 -0400
Received: from lists.gnu.org ([209.51.188.17]:59330)
 by debbugs.gnu.org with esmtp (Exim 4.84_2)
 (envelope-from <juri@HIDDEN>) id 1rjN57-0008AI-Be
 for submit <at> debbugs.gnu.org; Sun, 10 Mar 2024 13:35:30 -0400
Received: from eggs.gnu.org ([2001:470:142:3::10])
 by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256)
 (Exim 4.90_1) (envelope-from <juri@HIDDEN>) id 1rjN2R-0002PT-6Y
 for bug-gnu-emacs@HIDDEN; Sun, 10 Mar 2024 13:32:44 -0400
Received: from relay5-d.mail.gandi.net ([2001:4b98:dc4:8::225])
 by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256)
 (Exim 4.90_1) (envelope-from <juri@HIDDEN>) id 1rjN2O-0002S4-D1
 for bug-gnu-emacs@HIDDEN; Sun, 10 Mar 2024 13:32:42 -0400
Received: by mail.gandi.net (Postfix) with ESMTPSA id 2D5581C0002
 for <bug-gnu-emacs@HIDDEN>; Sun, 10 Mar 2024 17:32:35 +0000 (UTC)
From: Juri Linkov <juri@HIDDEN>
To: bug-gnu-emacs@HIDDEN
Subject: Package author/maintainer printing fix
Organization: LINKOV.NET
Date: Sun, 10 Mar 2024 19:03:16 +0200
Message-ID: <86h6hegr0b.fsf@HIDDEN>
User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/30.0.50 (x86_64-pc-linux-gnu)
MIME-Version: 1.0
Content-Type: multipart/mixed; boundary="=-=-="
X-GND-Sasl: juri@HIDDEN
Received-SPF: pass client-ip=2001:4b98:dc4:8::225;
 envelope-from=juri@HIDDEN; helo=relay5-d.mail.gandi.net
X-Spam_score_int: -25
X-Spam_score: -2.6
X-Spam_bar: --
X-Spam_report: (-2.6 / 5.0 requ) BAYES_00=-1.9, RCVD_IN_DNSWL_LOW=-0.7,
 SPF_HELO_PASS=-0.001, SPF_PASS=-0.001,
 T_SCC_BODY_TEXT_LINE=-0.01 autolearn=ham autolearn_force=no
X-Spam_action: no action
X-Spam-Score: -1.7 (-)
X-Debbugs-Envelope-To: submit
X-BeenThere: debbugs-submit <at> debbugs.gnu.org
X-Mailman-Version: 2.1.18
Precedence: list
List-Id: <debbugs-submit.debbugs.gnu.org>
List-Unsubscribe: <https://debbugs.gnu.org/cgi-bin/mailman/options/debbugs-submit>, 
 <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=unsubscribe>
List-Archive: <https://debbugs.gnu.org/cgi-bin/mailman/private/debbugs-submit/>
List-Post: <mailto:debbugs-submit <at> debbugs.gnu.org>
List-Help: <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=help>
List-Subscribe: <https://debbugs.gnu.org/cgi-bin/mailman/listinfo/debbugs-submit>, 
 <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=subscribe>
Errors-To: debbugs-submit-bounces <at> debbugs.gnu.org
Sender: "Debbugs-submit" <debbugs-submit-bounces <at> debbugs.gnu.org>
X-Spam-Score: -2.7 (--)

--=-=-=
Content-Type: text/plain

There are many packages with non-dot author/maintainer format that fail with

Debugger entered--Lisp error: (wrong-type-argument listp "XXIV")
  car("XXIV")
  package--print-email-button("XXIV")
  describe-package-1(#s(package-desc :name chaos-mode ((:authors ("XXIV")) (:maintainers ("XXIV")) (:maintainer "XXIV"))))
  describe-package(#s(package-desc :name chaos-mode ((:authors ("XXIV")) (:maintainers ("XXIV")) (:maintainer "XXIV"))))
  package-menu-describe-package(#<marker (moves after insertion) at 67389 in *Packages*>)
  button-activate(#<marker (moves after insertion) at 67389 in *Packages*> nil)
  push-button(67389)
  funcall-interactively(push-button 67389)
  command-execute(push-button)

Here is the fix:


--=-=-=
Content-Type: text/x-diff
Content-Disposition: inline; filename=package--print-email-button.patch

diff --git a/lisp/emacs-lisp/package.el b/lisp/emacs-lisp/package.el
index fe7b10f569a..790860df2a7 100644
--- a/lisp/emacs-lisp/package.el
+++ b/lisp/emacs-lisp/package.el
@@ -3082,19 +3082,21 @@ package--print-email-button
   "Insert a button whose action will send an email to RECIPIENT.
 NAME should have the form (FULLNAME . EMAIL) where FULLNAME is
 either a full name or nil, and EMAIL is a valid email address."
-  (when (car recipient)
-    (insert (car recipient)))
-  (when (and (car recipient) (cdr recipient))
-    (insert " "))
-  (when (cdr recipient)
-    (insert "<")
-    (insert-text-button (cdr recipient)
-                        'follow-link t
-                        'action (lambda (_)
-                                  (compose-mail
-                                   (format "%s <%s>" (car recipient) (cdr recipient)))))
-    (insert ">"))
-  (insert "\n"))
+  (if (stringp recipient)
+      (insert recipient "\n")
+    (when (car recipient)
+      (insert (car recipient)))
+    (when (and (car recipient) (cdr recipient))
+      (insert " "))
+    (when (cdr recipient)
+      (insert "<")
+      (insert-text-button (cdr recipient)
+                          'follow-link t
+                          'action (lambda (_)
+                                    (compose-mail
+                                     (format "%s <%s>" (car recipient) (cdr recipient)))))
+      (insert ">"))
+    (insert "\n")))
 
 
 ;;;; Package menu mode.

--=-=-=--




Acknowledgement sent to Juri Linkov <juri@HIDDEN>:
New bug report received and forwarded. Copy sent to bug-gnu-emacs@HIDDEN. Full text available.
Report forwarded to bug-gnu-emacs@HIDDEN:
bug#69712; Package emacs. Full text available.
Please note: This is a static page, with minimal formatting, updated once a day.
Click here to see this page with the latest information and nicer formatting.
Last modified: Tue, 14 May 2024 07:00:02 UTC

GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997 nCipher Corporation Ltd, 1994-97 Ian Jackson.