GNU bug report logs -
#70249
[PATCH] gnu: open-ssh-session: Don’t require public key.
Previous Next
Reported by: Ian Eure <ian <at> retrospec.tv>
Date: Sat, 6 Apr 2024 23:18:02 UTC
Severity: normal
Tags: patch
Done: Christopher Baines <mail <at> cbaines.net>
Bug is archived. No further changes may be made.
To add a comment to this bug, you must first unarchive it, by sending
a message to control AT debbugs.gnu.org, with unarchive 70249 in the body.
You can then email your comments to 70249 AT debbugs.gnu.org in the normal way.
Toggle the display of automated, internal messages from the tracker.
Report forwarded
to
guix <at> cbaines.net, dev <at> jpoiret.xyz, ludo <at> gnu.org, othacehe <at> gnu.org, rekado <at> elephly.net, zimon.toutoune <at> gmail.com, me <at> tobias.gr, guix-patches <at> gnu.org
:
bug#70249
; Package
guix-patches
.
(Sat, 06 Apr 2024 23:18:02 GMT)
Full text and
rfc822 format available.
Acknowledgement sent
to
Ian Eure <ian <at> retrospec.tv>
:
New bug report received and forwarded. Copy sent to
guix <at> cbaines.net, dev <at> jpoiret.xyz, ludo <at> gnu.org, othacehe <at> gnu.org, rekado <at> elephly.net, zimon.toutoune <at> gmail.com, me <at> tobias.gr, guix-patches <at> gnu.org
.
(Sat, 06 Apr 2024 23:18:02 GMT)
Full text and
rfc822 format available.
Message #5 received at submit <at> debbugs.gnu.org (full text, mbox):
* guix/scripts/offload.scm (open-ssh-session): Delete `public' binding.
Public keys aren’t required for client connections, and this binding is
unused. The behavior of assuming a ".pub"-suffixed file exists in the same
directory as the secret key is undocumented and surprising.
Change-Id: I9b532be2abe68dae0323e4ef6e1ceab1e5603359
---
guix/scripts/offload.scm | 3 ---
1 file changed, 3 deletions(-)
diff --git a/guix/scripts/offload.scm b/guix/scripts/offload.scm
index 137e3b5fe3..93e9d3759c 100644
--- a/guix/scripts/offload.scm
+++ b/guix/scripts/offload.scm
@@ -213,9 +213,6 @@ (define* (open-ssh-session machine #:optional max-silent-time)
When MAX-SILENT-TIME is true, it must be a positive integer denoting the
number of seconds after which the connection times out."
(let ((private (private-key-from-file* (build-machine-private-key machine)))
- (public (public-key-from-file
- (string-append (build-machine-private-key machine)
- ".pub")))
(session (make-session #:user (build-machine-user machine)
#:host (build-machine-name machine)
#:port (build-machine-port machine)
base-commit: ab3731d255ff1ac8d6874bc0f68ad94f21f08e79
--
2.41.0
Reply sent
to
Christopher Baines <mail <at> cbaines.net>
:
You have taken responsibility.
(Sun, 07 Apr 2024 19:34:01 GMT)
Full text and
rfc822 format available.
Notification sent
to
Ian Eure <ian <at> retrospec.tv>
:
bug acknowledged by developer.
(Sun, 07 Apr 2024 19:34:02 GMT)
Full text and
rfc822 format available.
Message #10 received at 70249-done <at> debbugs.gnu.org (full text, mbox):
[Message part 1 (text/plain, inline)]
Ian Eure <ian <at> retrospec.tv> writes:
> * guix/scripts/offload.scm (open-ssh-session): Delete `public' binding.
> Public keys aren’t required for client connections, and this binding is
> unused. The behavior of assuming a ".pub"-suffixed file exists in the same
> directory as the secret key is undocumented and surprising.
>
> Change-Id: I9b532be2abe68dae0323e4ef6e1ceab1e5603359
> ---
> guix/scripts/offload.scm | 3 ---
> 1 file changed, 3 deletions(-)
I can't see how this binding is used either, so I've pushed this to
master as 298aed72a2a76be33f9a55bed22636acd7a4f9b9.
Chris
[signature.asc (application/pgp-signature, inline)]
bug archived.
Request was from
Debbugs Internal Request <help-debbugs <at> gnu.org>
to
internal_control <at> debbugs.gnu.org
.
(Mon, 06 May 2024 11:24:08 GMT)
Full text and
rfc822 format available.
This bug report was last modified 12 days ago.
Previous Next
GNU bug tracking system
Copyright (C) 1999 Darren O. Benham,
1997,2003 nCipher Corporation Ltd,
1994-97 Ian Jackson.