Received: (at 70344-done) by debbugs.gnu.org; 18 May 2024 03:09:02 +0000 From debbugs-submit-bounces <at> debbugs.gnu.org Fri May 17 23:09:02 2024 Received: from localhost ([127.0.0.1]:58735 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from <debbugs-submit-bounces <at> debbugs.gnu.org>) id 1s8ARR-0006Gi-ST for submit <at> debbugs.gnu.org; Fri, 17 May 2024 23:09:02 -0400 Received: from cascadia.aikidev.net ([173.255.214.101]:45312) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from <vagrant@HIDDEN>) id 1s8ARO-0006GB-KB for 70344-done <at> debbugs.gnu.org; Fri, 17 May 2024 23:08:59 -0400 Received: from localhost (unknown [IPv6:2600:3c01:e000:21:7:77:0:50]) (Authenticated sender: vagrant@HIDDEN) by cascadia.aikidev.net (Postfix) with ESMTPSA id 573C71AB90; Fri, 17 May 2024 20:08:46 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=reproducible-builds.org; s=1.vagrant; t=1716001726; bh=+RuI/YWiHbaZXMzfQz3f1Xsd1H9jN1UCtniumyuEMxM=; h=From:To:Cc:Subject:In-Reply-To:References:Date:From; b=qA0NbZ0NXy1gYU/O+8dw2SxDxhE1UegvxlC6sQ8d7DXvDvwfewOqx0v5i6rwU5Lln RPZWCGDEoeVAxRvS7UlIHpcNZIu5AF9Rl/7/0q2ZM9ucUk7otdwC1e6nm+a57UiKfh mRK01GNF1xsClt/MtgP8KoERJVcaCRYOSGDZr9OULp5J3uUunQpKL/G0Y1j1wNvYda uU110pLJ9PzpC9pNlgiez+c4Ore0lW+jFaYJcjBhxp9FUL/Kjv6H343HjEnbnkHnxr /zHaCzHCECQWuy2U7T987vO/Ym15cyTlXpGbvI6JUEZgK9ds0+jB9KPCGHhdsxX6Sl Il+lKlkKcQbYA== From: Vagrant Cascadian <vagrant@HIDDEN> To: Christopher Baines <mail@HIDDEN> Subject: Re: Increase verbosity of diffoscope test suite In-Reply-To: <87bk6byndq.fsf@HIDDEN> References: <87r0fb3cgx.fsf@wireframe> <87bk6byndq.fsf@HIDDEN> Date: Fri, 17 May 2024 20:08:39 -0700 Message-ID: <87ed9zrf48.fsf@wireframe> MIME-Version: 1.0 Content-Type: multipart/signed; boundary="=-=-="; micalg=pgp-sha512; protocol="application/pgp-signature" X-Spam-Score: 0.0 (/) X-Debbugs-Envelope-To: 70344-done Cc: Wilko Meyer <w@HIDDEN>, 70344-done <at> debbugs.gnu.org X-BeenThere: debbugs-submit <at> debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: <debbugs-submit.debbugs.gnu.org> List-Unsubscribe: <https://debbugs.gnu.org/cgi-bin/mailman/options/debbugs-submit>, <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=unsubscribe> List-Archive: <https://debbugs.gnu.org/cgi-bin/mailman/private/debbugs-submit/> List-Post: <mailto:debbugs-submit <at> debbugs.gnu.org> List-Help: <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=help> List-Subscribe: <https://debbugs.gnu.org/cgi-bin/mailman/listinfo/debbugs-submit>, <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=subscribe> Errors-To: debbugs-submit-bounces <at> debbugs.gnu.org Sender: "Debbugs-submit" <debbugs-submit-bounces <at> debbugs.gnu.org> X-Spam-Score: -1.0 (-) --=-=-= Content-Type: text/plain On 2024-04-15, Christopher Baines wrote: > Vagrant Cascadian <vagrant@HIDDEN> writes: > >> The attached patch increases the verbosity of the test suite, showing >> each test on it's own line and provides a useful summary, often >> including a reason why skipped tests were skipped. >> >> This can be useful to help find additional packages to add for broader >> test coverage, inspired by discussion in >> https://issues.guix.gnu.org/70293 >> >> This also reveals that the conditional to add "enjarify" to >> native-inputs on x86_64 is not working correctly... and plausibly could >> reveal other similar issues with other missing native-inputs. >> >> live well, >> vagrant >> >> [2. text/x-diff; 0001-gnu-diffoscope-Increase-test-verbosity.patch] >> From b1475226dc655986e97445dca889d4b0c362215c Mon Sep 17 00:00:00 2001 >> From: Vagrant Cascadian <vagrant@HIDDEN> >> Date: Thu, 11 Apr 2024 12:40:19 -0700 >> Subject: [PATCH] gnu: diffoscope: Increase test verbosity. >> >> * gnu/packages/diffoscope.scm (diffoscope)[phases]: Replace 'check. >> --- >> gnu/packages/diffoscope.scm | 5 +++++ >> 1 file changed, 5 insertions(+) > > This looks great, I've pushed it to master as > 4dec6e9fb74a688e0297b127773b88a699531785. Sending to the correct -done address. :) live well, vagrant --=-=-= Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- iHUEARYKAB0WIQRlgHNhO/zFx+LkXUXcUY/If5cWqgUCZkgbtwAKCRDcUY/If5cW qu4MAQC7yMX87FLQ/SP1kbXLbTou8AIBi22ekBDHYf+rNZp4hAEAx2wi07I/X5wj EspB1TRhSL+n+9JdGMeDPJ6DYz7nlQA= =XZLe -----END PGP SIGNATURE----- --=-=-=--
Vagrant Cascadian <vagrant@HIDDEN>:Vagrant Cascadian <vagrant@HIDDEN>:
Received: (at submit) by debbugs.gnu.org; 11 Apr 2024 19:51:31 +0000
From debbugs-submit-bounces <at> debbugs.gnu.org Thu Apr 11 15:51:31 2024
Received: from localhost ([127.0.0.1]:57375 helo=debbugs.gnu.org)
by debbugs.gnu.org with esmtp (Exim 4.84_2)
(envelope-from <debbugs-submit-bounces <at> debbugs.gnu.org>)
id 1rv0SI-0007ZD-52
for submit <at> debbugs.gnu.org; Thu, 11 Apr 2024 15:51:31 -0400
Received: from lists.gnu.org ([2001:470:142::17]:59366)
by debbugs.gnu.org with esmtp (Exim 4.84_2)
(envelope-from <vagrant@HIDDEN>) id 1rv0SF-0007XY-37
for submit <at> debbugs.gnu.org; Thu, 11 Apr 2024 15:51:28 -0400
Received: from eggs.gnu.org ([2001:470:142:3::10])
by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256)
(Exim 4.90_1) (envelope-from <vagrant@HIDDEN>)
id 1rv0Rx-0000Tb-0j
for guix-patches@HIDDEN; Thu, 11 Apr 2024 15:51:09 -0400
Received: from cascadia.aikidev.net ([173.255.214.101])
by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256)
(Exim 4.90_1) (envelope-from <vagrant@HIDDEN>)
id 1rv0Ru-00045x-BD
for guix-patches@HIDDEN; Thu, 11 Apr 2024 15:51:08 -0400
Received: from localhost (unknown [IPv6:2600:3c01:e000:21:7:77:0:50])
(Authenticated sender: vagrant@HIDDEN)
by cascadia.aikidev.net (Postfix) with ESMTPSA id 2790E1AE55;
Thu, 11 Apr 2024 12:50:58 -0700 (PDT)
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple;
d=reproducible-builds.org; s=1.vagrant; t=1712865058;
bh=DaKKNeoHrtzVj9MeXdeiHI7x+iiUvsPIHf4ozf/+v+M=;
h=From:To:Cc:Subject:Date:From;
b=renv0u89cnOvSZHvkDFXdHuonR/b3YOrs8PTBrO4mfTcDJH/iyRo++z/8/SyYK44S
7JZQkxkxw96nk+Pn+dDy+drB4qlIJ63XwOUJ18rshAAympMNApDRkpnqyXTHMQ77UL
BMMFRSVVKFQUY8UK+4Wz0OsEsIx84d5PYWSl2mTRaMNAvO8j6DR8BLKBSQ4xwzav+q
ZYn4E3/IT6dIcIB8O2BTrjJEGz0pZrWUoLf7WUxVvzP/AROqXr4PKM32Wq3YHnN//5
mPh3THBqjSv77EqNPZnOhFrLlf2mUwQskxyL2Y0G1Z7ieRqouBNJeuFGBEd/qc04pb
cB1RYQc7KLbgA==
From: Vagrant Cascadian <vagrant@HIDDEN>
To: guix-patches@HIDDEN
Subject: Increase verbosity of diffoscope test suite
Date: Thu, 11 Apr 2024 12:50:54 -0700
Message-ID: <87r0fb3cgx.fsf@wireframe>
MIME-Version: 1.0
Content-Type: multipart/signed; boundary="==-=-=";
micalg=pgp-sha512; protocol="application/pgp-signature"
Received-SPF: pass client-ip=173.255.214.101;
envelope-from=vagrant@HIDDEN; helo=cascadia.aikidev.net
X-Spam_score_int: -20
X-Spam_score: -2.1
X-Spam_bar: --
X-Spam_report: (-2.1 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1,
DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, SPF_HELO_NONE=0.001,
SPF_PASS=-0.001 autolearn=ham autolearn_force=no
X-Spam_action: no action
X-Spam-Score: 1.0 (+)
X-Debbugs-Envelope-To: submit
Cc: Wilko Meyer <w@HIDDEN>, Christopher Baines <mail@HIDDEN>
X-BeenThere: debbugs-submit <at> debbugs.gnu.org
X-Mailman-Version: 2.1.18
Precedence: list
List-Id: <debbugs-submit.debbugs.gnu.org>
List-Unsubscribe: <https://debbugs.gnu.org/cgi-bin/mailman/options/debbugs-submit>,
<mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=unsubscribe>
List-Archive: <https://debbugs.gnu.org/cgi-bin/mailman/private/debbugs-submit/>
List-Post: <mailto:debbugs-submit <at> debbugs.gnu.org>
List-Help: <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=help>
List-Subscribe: <https://debbugs.gnu.org/cgi-bin/mailman/listinfo/debbugs-submit>,
<mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=subscribe>
Errors-To: debbugs-submit-bounces <at> debbugs.gnu.org
Sender: "Debbugs-submit" <debbugs-submit-bounces <at> debbugs.gnu.org>
X-Spam-Score: -0.0 (/)
--==-=-=
Content-Type: multipart/mixed; boundary="=-=-="
--=-=-=
Content-Type: text/plain
The attached patch increases the verbosity of the test suite, showing
each test on it's own line and provides a useful summary, often
including a reason why skipped tests were skipped.
This can be useful to help find additional packages to add for broader
test coverage, inspired by discussion in
https://issues.guix.gnu.org/70293
This also reveals that the conditional to add "enjarify" to
native-inputs on x86_64 is not working correctly... and plausibly could
reveal other similar issues with other missing native-inputs.
live well,
vagrant
--=-=-=
Content-Type: text/x-diff
Content-Disposition: inline;
filename=0001-gnu-diffoscope-Increase-test-verbosity.patch
Content-Transfer-Encoding: quoted-printable
From=20b1475226dc655986e97445dca889d4b0c362215c Mon Sep 17 00:00:00 2001
From: Vagrant Cascadian <vagrant@HIDDEN>
Date: Thu, 11 Apr 2024 12:40:19 -0700
Subject: [PATCH] gnu: diffoscope: Increase test verbosity.
* gnu/packages/diffoscope.scm (diffoscope)[phases]: Replace 'check.
=2D--
gnu/packages/diffoscope.scm | 5 +++++
1 file changed, 5 insertions(+)
diff --git a/gnu/packages/diffoscope.scm b/gnu/packages/diffoscope.scm
index 3db52e5008..8106a6d258 100644
=2D-- a/gnu/packages/diffoscope.scm
+++ b/gnu/packages/diffoscope.scm
@@ -139,6 +139,11 @@ (define (bin command)
(lambda _
;; This requires /sbin to be in $PATH.
(delete-file "tests/test_tools.py")))
+ (replace 'check
+ (lambda* (#:key tests? #:allow-other-keys)
+ (when tests?
+ ;; Increase verbosity of tests and provide a summary
+ (invoke "pytest" "-vv" "-r" "sxX"))))
(add-after 'install 'install-man-page
(lambda* (#:key outputs #:allow-other-keys)
(let* ((out (assoc-ref outputs "out"))
=2D-=20
2.39.2
--=-=-=--
--==-=-=
Content-Type: application/pgp-signature; name="signature.asc"
-----BEGIN PGP SIGNATURE-----
iHUEARYKAB0WIQRlgHNhO/zFx+LkXUXcUY/If5cWqgUCZhg/HgAKCRDcUY/If5cW
qgW5AQDzQ7f7cJAMcFuWYQn+QzKZ232WSPuBPZYNO174a61EwAEA1OKOc9dj92dJ
gosZBACXOiuHDyy99tk3SlkjZve9Bg4=
=hxq0
-----END PGP SIGNATURE-----
--==-=-=--
Vagrant Cascadian <vagrant@HIDDEN>:guix-patches@HIDDEN.
Full text available.guix-patches@HIDDEN:bug#70344; Package guix-patches.
Full text available.
GNU bug tracking system
Copyright (C) 1999 Darren O. Benham,
1997 nCipher Corporation Ltd,
1994-97 Ian Jackson.