GNU bug report logs - #70432
30.0.50; C-h for help not working with C-h k

Previous Next

To add a comment to this bug, you must first unarchive it, by sending
a message to control AT debbugs.gnu.org, with unarchive 70432 in the body.
You can then email your comments to 70432 AT debbugs.gnu.org in the normal way.

Toggle the display of automated, internal messages from the tracker.

Message #5 received at submit <at> debbugs.gnu.org (full text, mbox):

From: Gerd Möllmann <gerd.moellmann <at> gmail.com>
To: bug-gnu-emacs <at> gnu.org
Subject: 30.0.50; C-h for help not working with C-h k
Date: Wed, 17 Apr 2024 09:36:04 +0200

To reproduce

1. emacs -Q
2. C-h k C-x t
3. display says Press C-h for help
4. C-h
=> C-x t C-h is undefined

In GNU Emacs 30.0.50 (build 1, x86_64-apple-darwin23.4.0, NS
 appkit-2487.50 Version 14.4.1 (Build 23E224)) of 2024-04-16 built on
 Pro.fritz.box
Repository revision: 1be21dd95388037cfb71474a1fbd2a7d3583a80a
Repository branch: master
Windowing system distributor 'Apple', version 10.3.2487
System Description:  macOS 14.4.1

Message #8 received at 70432 <at> debbugs.gnu.org (full text, mbox):

From: Eli Zaretskii <eliz <at> gnu.org>
To: Gerd Möllmann <gerd.moellmann <at> gmail.com>, Dmitry
 Gutov <dmitry <at> gutov.dev>, Stefan Monnier <monnier <at> iro.umontreal.ca>
Cc: 70432 <at> debbugs.gnu.org
Subject: Re: bug#70432: 30.0.50; C-h for help not working with C-h k
Date: Thu, 18 Apr 2024 15:02:30 +0300

> From: Gerd Möllmann <gerd.moellmann <at> gmail.com>
> Date: Wed, 17 Apr 2024 09:36:04 +0200
> 
> To reproduce
> 
> 1. emacs -Q
> 2. C-h k C-x t
> 3. display says Press C-h for help
> 4. C-h
> => C-x t C-h is undefined

Because "C-x t C-h" is indeed undefined.

I think it makes no sense to tell users about C-h that shows the
available sequences when they already invoked a C-h command to ask
about a particular sequence.  So the patch below seems to be in order.
Also, "C-h K" will need a similar treatment (which is complicated by
the fact that it uses (interactive "k")).

Dmitry and Stefan, any better ideas?

diff --git a/lisp/help.el b/lisp/help.el
index d4e39f0..e6117ec 100644
--- a/lisp/help.el
+++ b/lisp/help.el
@@ -1049,6 +1049,9 @@ help--read-key-sequence
   (let ((enable-disabled-menus-and-buttons t)
         (cursor-in-echo-area t)
         (side-event nil)
+        ;; Showing the list of key sequences makes no sense when they
+        ;; asked about a key sequence.
+        (echo-keystrokes-help nil)
         saved-yank-menu)
     (unwind-protect
         (let (last-modifiers key-list)

Message #11 received at 70432 <at> debbugs.gnu.org (full text, mbox):

From: Stefan Monnier <monnier <at> iro.umontreal.ca>
To: Eli Zaretskii <eliz <at> gnu.org>
Cc: Gerd Möllmann <gerd.moellmann <at> gmail.com>,
 Dmitry Gutov <dmitry <at> gutov.dev>, 70432 <at> debbugs.gnu.org
Subject: Re: bug#70432: 30.0.50; C-h for help not working with C-h k
Date: Thu, 18 Apr 2024 09:51:54 -0400

> Dmitry and Stefan, any better ideas?
>
> diff --git a/lisp/help.el b/lisp/help.el
> index d4e39f0..e6117ec 100644
> --- a/lisp/help.el
> +++ b/lisp/help.el
> @@ -1049,6 +1049,9 @@ help--read-key-sequence
>    (let ((enable-disabled-menus-and-buttons t)
>          (cursor-in-echo-area t)
>          (side-event nil)
> +        ;; Showing the list of key sequences makes no sense when they
> +        ;; asked about a key sequence.
> +        (echo-keystrokes-help nil)
>          saved-yank-menu)
>      (unwind-protect
>          (let (last-modifiers key-list)

Loos OK to me, tho maybe it should be the other way around: we should
bind it to non-nil around those places where we know it makes sense?


        Stefan

Message #14 received at 70432 <at> debbugs.gnu.org (full text, mbox):

From: Eli Zaretskii <eliz <at> gnu.org>
To: Stefan Monnier <monnier <at> iro.umontreal.ca>
Cc: gerd.moellmann <at> gmail.com, dmitry <at> gutov.dev, 70432 <at> debbugs.gnu.org
Subject: Re: bug#70432: 30.0.50; C-h for help not working with C-h k
Date: Thu, 18 Apr 2024 17:19:06 +0300

> From: Stefan Monnier <monnier <at> iro.umontreal.ca>
> Cc: Gerd Möllmann <gerd.moellmann <at> gmail.com>,  Dmitry
>  Gutov
>  <dmitry <at> gutov.dev>,  70432 <at> debbugs.gnu.org
> Date: Thu, 18 Apr 2024 09:51:54 -0400
> 
> > Dmitry and Stefan, any better ideas?
> >
> > diff --git a/lisp/help.el b/lisp/help.el
> > index d4e39f0..e6117ec 100644
> > --- a/lisp/help.el
> > +++ b/lisp/help.el
> > @@ -1049,6 +1049,9 @@ help--read-key-sequence
> >    (let ((enable-disabled-menus-and-buttons t)
> >          (cursor-in-echo-area t)
> >          (side-event nil)
> > +        ;; Showing the list of key sequences makes no sense when they
> > +        ;; asked about a key sequence.
> > +        (echo-keystrokes-help nil)
> >          saved-yank-menu)
> >      (unwind-protect
> >          (let (last-modifiers key-list)
> 
> Loos OK to me, tho maybe it should be the other way around: we should
> bind it to non-nil around those places where we know it makes sense?

It's a user option, so I don't think that would be a good idea.

Message #19 received at 70432-done <at> debbugs.gnu.org (full text, mbox):

From: Eli Zaretskii <eliz <at> gnu.org>
To: gerd.moellmann <at> gmail.com
Cc: dmitry <at> gutov.dev, monnier <at> iro.umontreal.ca, 70432-done <at> debbugs.gnu.org
Subject: Re: bug#70432: 30.0.50; C-h for help not working with C-h k
Date: Sat, 20 Apr 2024 12:13:50 +0300

> Cc: gerd.moellmann <at> gmail.com, dmitry <at> gutov.dev, 70432 <at> debbugs.gnu.org
> Date: Thu, 18 Apr 2024 17:19:06 +0300
> From: Eli Zaretskii <eliz <at> gnu.org>
> 
> > From: Stefan Monnier <monnier <at> iro.umontreal.ca>
> > Cc: Gerd Möllmann <gerd.moellmann <at> gmail.com>,  Dmitry
> >  Gutov
> >  <dmitry <at> gutov.dev>,  70432 <at> debbugs.gnu.org
> > Date: Thu, 18 Apr 2024 09:51:54 -0400
> > 
> > > Dmitry and Stefan, any better ideas?
> > >
> > > diff --git a/lisp/help.el b/lisp/help.el
> > > index d4e39f0..e6117ec 100644
> > > --- a/lisp/help.el
> > > +++ b/lisp/help.el
> > > @@ -1049,6 +1049,9 @@ help--read-key-sequence
> > >    (let ((enable-disabled-menus-and-buttons t)
> > >          (cursor-in-echo-area t)
> > >          (side-event nil)
> > > +        ;; Showing the list of key sequences makes no sense when they
> > > +        ;; asked about a key sequence.
> > > +        (echo-keystrokes-help nil)
> > >          saved-yank-menu)
> > >      (unwind-protect
> > >          (let (last-modifiers key-list)
> > 
> > Loos OK to me, tho maybe it should be the other way around: we should
> > bind it to non-nil around those places where we know it makes sense?
> 
> It's a user option, so I don't think that would be a good idea.

I've now installed a fix for this on master, and I'm therefore closing
this bug.

Previous Next

GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson.