GNU bug report logs - #70442
[PATCH] Open new previews when they cover point

Previous Next

To add a comment to this bug, you must first unarchive it, by sending
a message to control AT debbugs.gnu.org, with unarchive 70442 in the body.
You can then email your comments to 70442 AT debbugs.gnu.org in the normal way.

Toggle the display of automated, internal messages from the tracker.

Message #5 received at submit <at> debbugs.gnu.org (full text, mbox):

From: Paul Nelson <ultrono <at> gmail.com>
To: bug-auctex <at> gnu.org
Subject: [PATCH] Open new previews when they cover point
Date: Wed, 17 Apr 2024 22:55:40 +0200

[Message part 1 (text/plain, inline)]

Steps to reproduce:
- Create test.tex with a valid equation environment.
- Put the point inside the equation environment.
- preview-buffer

When the preview generates, the point is ejected from the equation
environment due to the new overlay.

With this patch, the preview instead temporarily opens, as if the user
had entered it.

I view the latter behavior as "clearly" better, but if I missed some
advantage of the current approach or if my suggestion is deemed
subjective, then I would be happy to resubmit the patch with this
behavior enabled by a user option.

Thanks, best,

Paul

[0001-Open-new-previews-when-they-cover-point.patch (application/octet-stream, attachment)]

Message #8 received at 70442 <at> debbugs.gnu.org (full text, mbox):

From: Arash Esbati <arash <at> gnu.org>
To: Paul Nelson <ultrono <at> gmail.com>
Cc: 70442 <at> debbugs.gnu.org
Subject: Re: bug#70442: [PATCH] Open new previews when they cover point
Date: Thu, 18 Apr 2024 14:49:51 +0200

Hi Paul,

Paul Nelson <ultrono <at> gmail.com> writes:

> Steps to reproduce:
> - Create test.tex with a valid equation environment.
> - Put the point inside the equation environment.
> - preview-buffer
>
> When the preview generates, the point is ejected from the equation
> environment due to the new overlay.
>
> With this patch, the preview instead temporarily opens, as if the user
> had entered it.
>
> I view the latter behavior as "clearly" better, but if I missed some
> advantage of the current approach or if my suggestion is deemed
> subjective, then I would be happy to resubmit the patch with this
> behavior enabled by a user option.

thanks for looking at this.  I'm not sure which behavior is better, but
since we're about to change something which was there "since forever", I
suggest to introduce an user option and make the new behavior "opt-in".

Does this make sense?

Best, Arash

Message #11 received at 70442 <at> debbugs.gnu.org (full text, mbox):

From: Paul Nelson <ultrono <at> gmail.com>
To: Arash Esbati <arash <at> gnu.org>
Cc: 70442 <at> debbugs.gnu.org
Subject: Re: bug#70442: [PATCH] Open new previews when they cover point
Date: Thu, 18 Apr 2024 14:51:40 +0200

Hi Arash, sure thing.  I'll use "preview-protect-point" for the name
of the user option unless you can immediately think of something
better, and send the patch in a bit.  Thanks, Paul

Message #14 received at 70442 <at> debbugs.gnu.org (full text, mbox):

From: Paul Nelson <ultrono <at> gmail.com>
To: Arash Esbati <arash <at> gnu.org>
Cc: 70442 <at> debbugs.gnu.org
Subject: Re: bug#70442: [PATCH] Open new previews when they cover point
Date: Thu, 18 Apr 2024 14:53:21 +0200

Actually, I'll wait until the correction for the parenthesis from
bug#70348 is available on master, so as to avoid faulty patches.

Message #17 received at 70442 <at> debbugs.gnu.org (full text, mbox):

From: Arash Esbati <arash <at> gnu.org>
To: Paul Nelson <ultrono <at> gmail.com>
Cc: 70442 <at> debbugs.gnu.org
Subject: Re: bug#70442: [PATCH] Open new previews when they cover point
Date: Thu, 18 Apr 2024 15:06:57 +0200

Paul Nelson <ultrono <at> gmail.com> writes:

> Actually, I'll wait until the correction for the parenthesis from
> bug#70348 is available on master, so as to avoid faulty patches.

That issue is already fixed with commit ed37457621.  Note that I also
deleted the unused lexical variable '(ov (car ovl))'.  Do you see the
commit after 'git pull'?

Best, Arash

Message #20 received at 70442 <at> debbugs.gnu.org (full text, mbox):

From: Paul Nelson <ultrono <at> gmail.com>
To: Arash Esbati <arash <at> gnu.org>
Cc: 70442 <at> debbugs.gnu.org
Subject: Re: bug#70442: [PATCH] Open new previews when they cover point
Date: Thu, 18 Apr 2024 15:13:05 +0200

[Message part 1 (text/plain, inline)]

Thanks, I see it now.  Please see attached.

[0001-Add-new-custom-option-preview-protect-point.patch (application/octet-stream, attachment)]

Message #25 received at 70442-done <at> debbugs.gnu.org (full text, mbox):

From: Arash Esbati <arash <at> gnu.org>
To: Paul Nelson <ultrono <at> gmail.com>
Cc: 70442-done <at> debbugs.gnu.org
Subject: Re: bug#70442: [PATCH] Open new previews when they cover point
Date: Thu, 18 Apr 2024 16:27:45 +0200

Paul Nelson <ultrono <at> gmail.com> writes:

> Thanks, I see it now.  Please see attached.

Thanks.  I slightly changed your patch (most notably, the value of
:group tag) and installed it, closing.

Best, Arash

Previous Next

GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson.