GNU bug report logs - #70665
[PATCH] Add font-locking for typed parameters in python-ts-mode

Previous Next

To reply to this bug, email your comments to 70665 AT debbugs.gnu.org.
There is no need to reopen the bug first.

Toggle the display of automated, internal messages from the tracker.

Message #5 received at submit <at> debbugs.gnu.org (full text, mbox):

From: Noah Peart <noah.v.peart <at> gmail.com>
To: bug-gnu-emacs <at> gnu.org
Subject: [PATCH] Add font-locking for typed parameters in python-ts-mode
Date: Tue, 30 Apr 2024 03:09:07 -0700

[Message part 1 (text/plain, inline)]

Tags: patch

This patch adds a rule to python--treesit-settings to apply
font-lock-variable-name-face to typed parameters in python-ts-mode.
Currently, function parameters with type annotations are missing
font-lock-variable-name-face.

For example, this patch adds font-locking in the following case:

    def foo(val: str) -> str
    #        ^ font-lock-variable-name-face


In GNU Emacs 30.0.50 (build 1, x86_64-pc-linux-gnu, GTK+ Version
3.24.33, cairo version 1.16.0) of 2024-04-29 built on noah-X580VD
Repository revision: 3000edc6179dfe0b5f24ae2e472826530809dfd1
Repository branch: master
Windowing system distributor 'The X.Org Foundation', version 11.0.12101004
System Description: Ubuntu 22.04.4 LTS

Configured using:
 'configure --prefix=/usr/local --with-modules --with-tree-sitter
--with-threads --with-x-toolkit=gtk3 --with-xwidgets --with-gnutls
--with-json --with-mailutils --with-jpeg --with-png --with-rsvg
--with-tiff --with-xml2 --with-xpm --with-imagemagick CC=gcc-12
CXX=gcc-12'

[Message part 2 (text/html, inline)]

[0001-Add-font-locking-for-typed-parameters-in-python-ts-m.patch (text/x-patch, attachment)]

Message #8 received at submit <at> debbugs.gnu.org (full text, mbox):

From: Noah Peart <noah.v.peart <at> gmail.com>
To: bug-gnu-emacs <at> gnu.org
Subject: bug#70665: [PATCH] Add font-locking for typed parameters in
 python-ts-mode
Date: Tue, 30 Apr 2024 03:27:36 -0700

[Message part 1 (text/plain, inline)]

Sorry, previous patch added an extra file by accident.

Fixed patch attached.


On Tue, Apr 30, 2024 at 3:09 AM Noah Peart <noah.v.peart <at> gmail.com> wrote:

> Tags: patch
>
> This patch adds a rule to python--treesit-settings to apply
> font-lock-variable-name-face to typed parameters in python-ts-mode.
> Currently, function parameters with type annotations are missing
> font-lock-variable-name-face.
>
> For example, this patch adds font-locking in the following case:
>
>     def foo(val: str) -> str
>     #        ^ font-lock-variable-name-face
>
>
> In GNU Emacs 30.0.50 (build 1, x86_64-pc-linux-gnu, GTK+ Version
> 3.24.33, cairo version 1.16.0) of 2024-04-29 built on noah-X580VD
> Repository revision: 3000edc6179dfe0b5f24ae2e472826530809dfd1
> Repository branch: master
> Windowing system distributor 'The X.Org Foundation', version 11.0.12101004
> System Description: Ubuntu 22.04.4 LTS
>
> Configured using:
>  'configure --prefix=/usr/local --with-modules --with-tree-sitter
> --with-threads --with-x-toolkit=gtk3 --with-xwidgets --with-gnutls
> --with-json --with-mailutils --with-jpeg --with-png --with-rsvg
> --with-tiff --with-xml2 --with-xpm --with-imagemagick CC=gcc-12
> CXX=gcc-12'
>

[Message part 2 (text/html, inline)]

[0001-Add-font-locking-for-typed-parameters-in-python-ts-m.patch (text/x-patch, attachment)]

Message #11 received at 70665 <at> debbugs.gnu.org (full text, mbox):

From: Yuan Fu <casouri <at> gmail.com>
To: Noah Peart <noah.v.peart <at> gmail.com>
Cc: 70665 <at> debbugs.gnu.org
Subject: Re: bug#70665: [PATCH] Add font-locking for typed parameters in
 python-ts-mode
Date: Wed, 1 May 2024 08:04:07 -0700

> On Apr 30, 2024, at 3:27 AM, Noah Peart <noah.v.peart <at> gmail.com> wrote:
> 
> Sorry, previous patch added an extra file by accident.
> 
> Fixed patch attached.
> 
> 
> On Tue, Apr 30, 2024 at 3:09 AM Noah Peart <noah.v.peart <at> gmail.com> wrote:
> Tags: patch
> 
> This patch adds a rule to python--treesit-settings to apply
> font-lock-variable-name-face to typed parameters in python-ts-mode.
> Currently, function parameters with type annotations are missing
> font-lock-variable-name-face.
> 
> For example, this patch adds font-locking in the following case:
> 
>     def foo(val: str) -> str
>     #        ^ font-lock-variable-name-face

Thank you!! Had some issue with my Emacs build last night. I’ll try to get it merged tonight.

Yuan

Message #16 received at 70665-done <at> debbugs.gnu.org (full text, mbox):

From: Yuan Fu <casouri <at> gmail.com>
To: Noah Peart <noah.v.peart <at> gmail.com>
Cc: 70665-done <at> debbugs.gnu.org
Subject: Re: bug#70665: [PATCH] Add font-locking for typed parameters in
 python-ts-mode
Date: Wed, 1 May 2024 21:28:12 -0700

> On May 1, 2024, at 8:04 AM, Yuan Fu <casouri <at> gmail.com> wrote:
> 
> 
> 
>> On Apr 30, 2024, at 3:27 AM, Noah Peart <noah.v.peart <at> gmail.com> wrote:
>> 
>> Sorry, previous patch added an extra file by accident.
>> 
>> Fixed patch attached.
>> 
>> 
>> On Tue, Apr 30, 2024 at 3:09 AM Noah Peart <noah.v.peart <at> gmail.com> wrote:
>> Tags: patch
>> 
>> This patch adds a rule to python--treesit-settings to apply
>> font-lock-variable-name-face to typed parameters in python-ts-mode.
>> Currently, function parameters with type annotations are missing
>> font-lock-variable-name-face.
>> 
>> For example, this patch adds font-locking in the following case:
>> 
>>    def foo(val: str) -> str
>>    #        ^ font-lock-variable-name-face
> 
> Thank you!! Had some issue with my Emacs build last night. I’ll try to get it merged tonight.
> 
> Yuan

Merged, thanks again!

Yuan

Previous Next

GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson.