Eli Zaretskii <eliz@HIDDEN>
to control <at> debbugs.gnu.org.
Full text available.Eli Zaretskii <eliz@HIDDEN>
to control <at> debbugs.gnu.org.
Full text available.Received: (at 70691) by debbugs.gnu.org; 2 May 2024 06:07:50 +0000 From debbugs-submit-bounces <at> debbugs.gnu.org Thu May 02 02:07:50 2024 Received: from localhost ([127.0.0.1]:41691 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from <debbugs-submit-bounces <at> debbugs.gnu.org>) id 1s2Pbi-0001KW-76 for submit <at> debbugs.gnu.org; Thu, 02 May 2024 02:07:50 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]:43632) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from <eliz@HIDDEN>) id 1s2Pbh-0001KH-1e; Thu, 02 May 2024 02:07:49 -0400 Received: from fencepost.gnu.org ([2001:470:142:3::e]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from <eliz@HIDDEN>) id 1s2PbG-0006vX-37; Thu, 02 May 2024 02:07:22 -0400 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=gnu.org; s=fencepost-gnu-org; h=References:Subject:In-Reply-To:To:From:Date: mime-version; bh=1YTkoZssKU7hCYgk7piBRAKCl8H+SXTlzANx5gPncV8=; b=YrnWGhKIKpap 6dhaKe1oOhjccvnXG5qKooFyf57mPpZmN3jBkgmQlOBTMug2QHIEzq357wNnM+0iVn020XnG3fHw7 EMGLvDMe3m5GSMD/Sjyad6NI6lLz/THZQmm7V/1g7V1rQlmsEnmcMnaoFzCtCfcFXoQoVsQNRXqYA 4xg8cHhnKfGhnJ2SPAL7yahQagjenV5dI5SIwf/9nbWbOTEb4y5wYdU7h2Ew2p6eoSGNsszXgjbl4 1UzPTdA8ivie13QJ1J7j5jxOoMD85IWoSFfZkfX7rrOkfKkotT+brzSkghIyo6ZH8nG2ERe3PLjms ZQnJxfYn5qh2e5dOpuY+tg==; Date: Thu, 02 May 2024 09:07:16 +0300 Message-Id: <864jbgoigb.fsf@HIDDEN> From: Eli Zaretskii <eliz@HIDDEN> To: Lin Sun <sunlin7.mail@HIDDEN> In-Reply-To: <CABCREdodpLVvvYRwu97r+yDnCw=bYjktje+saEaCUdnq+KmmYA@HIDDEN> (message from Lin Sun on Wed, 1 May 2024 19:37:08 +0000) Subject: Re: bug#70691: 30.0.50; [PATCH] Eshell's TERM env varible use eshell-term-name as default References: <CABCREdq_VzV=MdmzU7Pta+5aoDqK_Z7gxrkYARa8vm9V3Mmh9A@HIDDEN> <865xvxpw3c.fsf@HIDDEN> <24c6739d-d276-aea1-aa9b-99852dcf744f@HIDDEN> <CABCREdodpLVvvYRwu97r+yDnCw=bYjktje+saEaCUdnq+KmmYA@HIDDEN> X-Spam-Score: -2.3 (--) X-Debbugs-Envelope-To: 70691 Cc: 70691 <at> debbugs.gnu.org, jporterbugs@HIDDEN X-BeenThere: debbugs-submit <at> debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: <debbugs-submit.debbugs.gnu.org> List-Unsubscribe: <https://debbugs.gnu.org/cgi-bin/mailman/options/debbugs-submit>, <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=unsubscribe> List-Archive: <https://debbugs.gnu.org/cgi-bin/mailman/private/debbugs-submit/> List-Post: <mailto:debbugs-submit <at> debbugs.gnu.org> List-Help: <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=help> List-Subscribe: <https://debbugs.gnu.org/cgi-bin/mailman/listinfo/debbugs-submit>, <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=subscribe> Errors-To: debbugs-submit-bounces <at> debbugs.gnu.org Sender: "Debbugs-submit" <debbugs-submit-bounces <at> debbugs.gnu.org> X-Spam-Score: -3.3 (---) tags 70691 notabug wontfix close 70691 thanks > From: Lin Sun <sunlin7.mail@HIDDEN> > Date: Wed, 1 May 2024 19:37:08 +0000 > Cc: Eli Zaretskii <eliz@HIDDEN>, 70691 <at> debbugs.gnu.org > > Thank you for the explanation, very clear. > Please feel free to ignore the patch and close this ticket. Thanks Done.
bug-gnu-emacs@HIDDEN:bug#70691; Package emacs.
Full text available.Received: (at 70691) by debbugs.gnu.org; 1 May 2024 19:50:00 +0000 From debbugs-submit-bounces <at> debbugs.gnu.org Wed May 01 15:49:59 2024 Received: from localhost ([127.0.0.1]:39099 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from <debbugs-submit-bounces <at> debbugs.gnu.org>) id 1s2Fxn-0005ms-Ma for submit <at> debbugs.gnu.org; Wed, 01 May 2024 15:49:59 -0400 Received: from mail-ed1-x535.google.com ([2a00:1450:4864:20::535]:42278) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from <sunlin7.mail@HIDDEN>) id 1s2Fxl-0005mm-B1 for 70691 <at> debbugs.gnu.org; Wed, 01 May 2024 15:49:57 -0400 Received: by mail-ed1-x535.google.com with SMTP id 4fb4d7f45d1cf-572adaa172cso1390322a12.1 for <70691 <at> debbugs.gnu.org>; Wed, 01 May 2024 12:49:35 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1714592970; x=1715197770; darn=debbugs.gnu.org; h=cc:to:subject:message-id:date:from:in-reply-to:references :mime-version:from:to:cc:subject:date:message-id:reply-to; bh=BPlvGd2Az4jSYYl8zm+DK+T3iM0LvohN1zg+S23Y7q4=; b=boS5CB1Q7g+WstBatR6ohbe8nBWTzkCeF4OKfbnzALNOCCR40jUT9FlvDddMhkdv6T D4sx895F5LkNLdc3dAoZCDLvsH00KXJZg46+dlMy1QQxsvc1nufqYaPgMxg8x0hVDI7E N/+BEQ2AWEw7f8c5m8QMC1EBphHI6y0Wj2P/M/Z/cNPDJLPyY76VMBz7IamhZFVyXZq9 4LrVyKb4jhxMhpkayXKBBrMS6psSdpul1AAaVCN/k2NmEEE1ATvj8llfaMT1emPmLf17 ifiFHt+lomKSgldU66CZJQxb8nDskCFU38jXYOe6Iy48ColMpjXy6e9G4AtC5lhyvN1V sn7w== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1714592970; x=1715197770; h=cc:to:subject:message-id:date:from:in-reply-to:references :mime-version:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=BPlvGd2Az4jSYYl8zm+DK+T3iM0LvohN1zg+S23Y7q4=; b=lHSRyNyuXHdkfrjhWJ6Rxhw4AOl19JVs50P/nR0BC8eQw9VqcVkCenrUKzXxREM8By QHK+y5VG+bf2CiDMPx+yOq56AGV8fP9kY2c60gFkQloUGXfoMCCK88Jl9Wfbgu8aL1pf YJE3VkCuWUn0U6S2KVRXItJLKaQFTcIcbOs47aCKa07J9Cej8n56UFeHW5m8mhn9Kwhk rwUnUwmjOmexvIxeQY8usYDHw9iIy+2XfYMrQcYDBw5BbrzPjJH3K/ufslk1dkXNuQ/O YLVr94dnqBzxrwdOb2wP2q+avkg+tE8STq4SMECiWZgdMGKkQ3K1Cnu7keLwu9KZ8xss /wdw== X-Forwarded-Encrypted: i=1; AJvYcCUzf6/shrnTL8OBBuuCmV5+dFACeeXySGicHwQmDM73adhc+6iQDhklTxm0XgfJunAjUCCDjVOqvU+WEVLEuNovlUuum5w= X-Gm-Message-State: AOJu0Yx2jN1P/atdy0agRXU+TyhEa3UK0Hds3mA2uHMj4CQQDAvhbp1D bSD0gYJwGECcfYYFyaR1eEzkfV/yjmGIDCKAg9+YCL0FfriwRNUDFc48VB6kp3t/3pa76ox93VB JGrCL8/cIh+Fgsy6a8f9W9pvnspM= X-Google-Smtp-Source: AGHT+IHt4ZXBe2KWX8m8uN4MdyFfaebgNXitpEnCRKXMo9Lz8BwXpdVAnlJ22mk7MEFAdnsk68nDNl3DgHXVI3EVtms= X-Received: by 2002:a50:a6ce:0:b0:572:b83e:e062 with SMTP id f14-20020a50a6ce000000b00572b83ee062mr485237edc.3.1714592969698; Wed, 01 May 2024 12:49:29 -0700 (PDT) MIME-Version: 1.0 References: <CABCREdq_VzV=MdmzU7Pta+5aoDqK_Z7gxrkYARa8vm9V3Mmh9A@HIDDEN> <865xvxpw3c.fsf@HIDDEN> <24c6739d-d276-aea1-aa9b-99852dcf744f@HIDDEN> <CABCREdodpLVvvYRwu97r+yDnCw=bYjktje+saEaCUdnq+KmmYA@HIDDEN> In-Reply-To: <CABCREdodpLVvvYRwu97r+yDnCw=bYjktje+saEaCUdnq+KmmYA@HIDDEN> From: Lin Sun <sunlin7.mail@HIDDEN> Date: Wed, 1 May 2024 19:49:18 +0000 Message-ID: <CABCREdq2_xK5ZWOMPK8na3cR8bHafn8hw48jfMu7HzQbdf-O=w@HIDDEN> Subject: Re: bug#70691: 30.0.50; [PATCH] Eshell's TERM env varible use eshell-term-name as default To: Jim Porter <jporterbugs@HIDDEN> Content-Type: text/plain; charset="UTF-8" X-Spam-Score: 0.0 (/) X-Debbugs-Envelope-To: 70691 Cc: 70691 <at> debbugs.gnu.org, Eli Zaretskii <eliz@HIDDEN> X-BeenThere: debbugs-submit <at> debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: <debbugs-submit.debbugs.gnu.org> List-Unsubscribe: <https://debbugs.gnu.org/cgi-bin/mailman/options/debbugs-submit>, <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=unsubscribe> List-Archive: <https://debbugs.gnu.org/cgi-bin/mailman/private/debbugs-submit/> List-Post: <mailto:debbugs-submit <at> debbugs.gnu.org> List-Help: <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=help> List-Subscribe: <https://debbugs.gnu.org/cgi-bin/mailman/listinfo/debbugs-submit>, <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=subscribe> Errors-To: debbugs-submit-bounces <at> debbugs.gnu.org Sender: "Debbugs-submit" <debbugs-submit-bounces <at> debbugs.gnu.org> X-Spam-Score: -1.0 (-) > it's best to change 'comint-terminfo-terminal' instead to "dumb-emacs-ansi" And the "dumb-emacs-ansi" is included in the `ncurses-term` package (ncurses-term-6.1 in my local).
bug-gnu-emacs@HIDDEN:bug#70691; Package emacs.
Full text available.Received: (at 70691) by debbugs.gnu.org; 1 May 2024 19:37:49 +0000 From debbugs-submit-bounces <at> debbugs.gnu.org Wed May 01 15:37:49 2024 Received: from localhost ([127.0.0.1]:39052 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from <debbugs-submit-bounces <at> debbugs.gnu.org>) id 1s2Fm1-0005hf-6b for submit <at> debbugs.gnu.org; Wed, 01 May 2024 15:37:49 -0400 Received: from mail-lf1-x12e.google.com ([2a00:1450:4864:20::12e]:46294) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from <sunlin7.mail@HIDDEN>) id 1s2Flz-0005hZ-Ih for 70691 <at> debbugs.gnu.org; Wed, 01 May 2024 15:37:48 -0400 Received: by mail-lf1-x12e.google.com with SMTP id 2adb3069b0e04-5171a529224so9044049e87.0 for <70691 <at> debbugs.gnu.org>; Wed, 01 May 2024 12:37:26 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1714592240; x=1715197040; darn=debbugs.gnu.org; h=content-transfer-encoding:cc:to:subject:message-id:date:from :in-reply-to:references:mime-version:from:to:cc:subject:date :message-id:reply-to; bh=vahrVLDD4cvfQmUME7DKmj3atjR3EXtOOjVYTW9Cm60=; b=hrUcEO0o7s+szf+hD3ALScwVl6Cs1zcrfAwT15MvZrF4lAZZQ4La2Fn4JHTrn1YnfG 5qpfBd9IDP1w8m8p1L2E7QpuymIgR5VSx1r3Ku9HkjBCyjO5eP5maCJ89ZYE8zrRPBe8 ClagYPAbG2jeRxteuNYINKYVw73RE2cCObRGpEzDCDUA1xZFqsSnTOYdYi0dChnsZ2d/ L1aDMDvsQLAVKyyuhePOAUfQYmmfn7O8fZWNKRLNTJ6jOCC6htl6jJ1W/YpzNuKGktAh DPLyWTKcCd6Ph3skhAJ3YpYSPDL6npsOMbc7fbpK6d+1UP2ZMX1WQjwrT1AhGoan8HvU aqow== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1714592240; x=1715197040; h=content-transfer-encoding:cc:to:subject:message-id:date:from :in-reply-to:references:mime-version:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=vahrVLDD4cvfQmUME7DKmj3atjR3EXtOOjVYTW9Cm60=; b=HO2HwihUZsL1bUQL5Fv5N+8OHOAXrwblWC0h9Hp//hKOTy1NW3lj2CEmMlatSIJTO6 MUcZMQmxWWVy+Iq3fT59j0VrXiey5x3yFUSFxroqANJwGYm9BL/virpfuln77VIx6PUR 7II4hM+9OcZUrCSlnow2HnmjENxSwJqM8fBMBB/cHzHcboKJSYHOoCOrelmF/HBlYZga oXR8q4C3SVX13+BChpNuLHg23fiGSYU8Jff7/TdGYCtjsOrd4e1KVR27++nMPGnBagCa uBcva0ArEiO8w5MslR4qxHyEiC6TrlY/gyDJKr+BtZymro4Ls6kOVDkJD+1spgrtS+ql Ez4Q== X-Forwarded-Encrypted: i=1; AJvYcCUUVj7OBHWXNFegNDwxOnfKhRlApyBDl5DMzajpiFlXhxVQfBz7xp40GBFIZp9tsGbep7erev+EZHpHKXqrnaGEpyMa7eM= X-Gm-Message-State: AOJu0YzEetWnpn31zEfGWZKlmGgriPf24b3E7b68O/gNS9gUa158a/1A EzJ3M6sM01EmDK0NvWjkPsh/Qbnt1YjA9GvEo5EMXIxYD/OvPi/sTQ+zC8WkVW/oidjuFKorPeV 2yp8l16Zjt5El6HpVZo7JgDXfJyU= X-Google-Smtp-Source: AGHT+IEpq98+fUoplWr4n2LFwBGik60wdtg/Brvwst8YlQbouf2yCms7PzNDB1w1v6fCTD8qn7XiWsUj1f854oh/Bps= X-Received: by 2002:a05:6512:234b:b0:51d:895c:5a0d with SMTP id p11-20020a056512234b00b0051d895c5a0dmr2529001lfu.5.1714592239859; Wed, 01 May 2024 12:37:19 -0700 (PDT) MIME-Version: 1.0 References: <CABCREdq_VzV=MdmzU7Pta+5aoDqK_Z7gxrkYARa8vm9V3Mmh9A@HIDDEN> <865xvxpw3c.fsf@HIDDEN> <24c6739d-d276-aea1-aa9b-99852dcf744f@HIDDEN> In-Reply-To: <24c6739d-d276-aea1-aa9b-99852dcf744f@HIDDEN> From: Lin Sun <sunlin7.mail@HIDDEN> Date: Wed, 1 May 2024 19:37:08 +0000 Message-ID: <CABCREdodpLVvvYRwu97r+yDnCw=bYjktje+saEaCUdnq+KmmYA@HIDDEN> Subject: Re: bug#70691: 30.0.50; [PATCH] Eshell's TERM env varible use eshell-term-name as default To: Jim Porter <jporterbugs@HIDDEN> Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable X-Spam-Score: 0.0 (/) X-Debbugs-Envelope-To: 70691 Cc: 70691 <at> debbugs.gnu.org, Eli Zaretskii <eliz@HIDDEN> X-BeenThere: debbugs-submit <at> debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: <debbugs-submit.debbugs.gnu.org> List-Unsubscribe: <https://debbugs.gnu.org/cgi-bin/mailman/options/debbugs-submit>, <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=unsubscribe> List-Archive: <https://debbugs.gnu.org/cgi-bin/mailman/private/debbugs-submit/> List-Post: <mailto:debbugs-submit <at> debbugs.gnu.org> List-Help: <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=help> List-Subscribe: <https://debbugs.gnu.org/cgi-bin/mailman/listinfo/debbugs-submit>, <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=subscribe> Errors-To: debbugs-submit-bounces <at> debbugs.gnu.org Sender: "Debbugs-submit" <debbugs-submit-bounces <at> debbugs.gnu.org> X-Spam-Score: -1.0 (-) On Wed, May 1, 2024 at 6:19=E2=80=AFPM Jim Porter <jporterbugs@HIDDEN> w= rote: > > On 5/1/2024 5:15 AM, Eli Zaretskii wrote: > >> From: Lin Sun <sunlin7.mail@HIDDEN> > >> Date: Wed, 1 May 2024 06:40:25 +0000 > >> > >> Since emacs-29 the Eshell has been enhanced for the ansi-color a lot. > [snip] > >> > >> So we can safely export eshell's "TERM" with `eshell-term-name` to > >> support executables with colors. > >> I attached the patch, please help review it. Thanks. > > > > The fact that we can safely do that does not yet mean we _should_ do > > it. In my book, setting TERM is a user preference, more or less. > > IOW, this is a change in the default behavior. > > > > Jim, WDYT? > > Unfortunately, I don't think this is the right way to do things (or else > I'm just not understanding some part of it). The docstring for > 'eshell-term-name' says, "Name to use for the TERM variable when running > visual commands," and its value defaults to 'term-term-name'. For visual > commands (which use term.el), the terminal can do a lot more than just > setting colors, such as moving the cursor around. "Normal", non-visual > Eshell can't do that, so I think using the same setting for $TERM would > be wrong. > > We could make Eshell set $TERM to "dumb-emacs-ansi", which should have > the correct terminal settings. I believe that terminfo has been > upstreamed into ncurses. > > However, I think if you want colors, it's best to change > 'comint-terminfo-terminal' instead to "dumb-emacs-ansi" (and then Eshell > will use that setting automatically). I *don't* think we should change > 'comint-terminfo-terminal' by default though; that would be pretty > invasive. Maybe we could use the Customize interface to make selecting > "dumb-emacs-ansi" a matter of just checking a box, instead of typing it > out by hand? Thank you for the explanation, very clear. Please feel free to ignore the patch and close this ticket. Thanks
bug-gnu-emacs@HIDDEN:bug#70691; Package emacs.
Full text available.Received: (at 70691) by debbugs.gnu.org; 1 May 2024 18:20:12 +0000 From debbugs-submit-bounces <at> debbugs.gnu.org Wed May 01 14:20:12 2024 Received: from localhost ([127.0.0.1]:38724 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from <debbugs-submit-bounces <at> debbugs.gnu.org>) id 1s2EYt-00051D-TZ for submit <at> debbugs.gnu.org; Wed, 01 May 2024 14:20:12 -0400 Received: from mail-pf1-x433.google.com ([2607:f8b0:4864:20::433]:42247) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from <jporterbugs@HIDDEN>) id 1s2EYr-000517-LS for 70691 <at> debbugs.gnu.org; Wed, 01 May 2024 14:20:10 -0400 Received: by mail-pf1-x433.google.com with SMTP id d2e1a72fcca58-6f0aeee172dso772991b3a.1 for <70691 <at> debbugs.gnu.org>; Wed, 01 May 2024 11:19:48 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1714587582; x=1715192382; darn=debbugs.gnu.org; h=content-transfer-encoding:in-reply-to:from:content-language :references:cc:to:subject:mime-version:date:message-id:from:to:cc :subject:date:message-id:reply-to; bh=CbaQuCHATbQ6Svz3umgj7ru4sVoV/vRHNRgn3CZcvfU=; b=UKm78UOzRC5a8Jbnhu3lHSctBR44Y7ZDPBYu6PtteGgeY5YAAOKdmehw8egAOy37rp 3eb8dGk/D9GedKk4JdP6veISDjalktUPw5kcqzAx0XUMW1A+78pficL4ZGSU1DG1xBzA f6sfkbxrl1pEpPjiYkJ1HK8t5StcTlj4Hultq5CzftVDH5lujQTmN39cSNIwlMYQKP4y ZjZIi2ReY0/MJlXWB5Pj//toVLDqWdiXDQVRrxVoSsJ71k/wxSNXbew0XTdY33Hdf5+j 9JV+maS57rrdDxpIA1xiMJK0aie95f25jTok5YD53fwz0xzV+YF7neZXC05Vb6AZS9jx bSKA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1714587582; x=1715192382; h=content-transfer-encoding:in-reply-to:from:content-language :references:cc:to:subject:mime-version:date:message-id :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=CbaQuCHATbQ6Svz3umgj7ru4sVoV/vRHNRgn3CZcvfU=; b=iOBu4GLLi+RbqRc7e0F9PPRFxrNsXHYZCB9HQGv7tt+MQSCXTrh7AAPeUWxMd1LlaD UNZHXDQHn1FFIawB1hl0luK28kX0XckOpbhPMBMkIVfAXdxEeFcJTnoL5f5tQkiMyyKt PBJiNSFtMRGScJbYOlKyt14m//0Ttb23ZBvhCbYUZNmlyzrLfkJgSAc95K7XYWcAkBgK 3291w3YkHUD7yojehAD6xx3I4AYrnqUlP7hMdzaqigoBNm1HNbKgunvZ2M/aAhpqqN5g DBJrh6mhOCwox383FnBweVFZEy9Gz0BWhwHWLC2enaCtheTtVWdBf17T1qvmvGnyCIU1 +jLw== X-Gm-Message-State: AOJu0YyU/DNwYIIociUc7lwgo8dfMcANGOxE7mUKAd/r15Z22R0QzTDK wyEYnQpxE8pIj8HOSJeSQZxGLq4cGu4VKyfCTW+i+dAE6BxnQ29t X-Google-Smtp-Source: AGHT+IFjP08u2yce+AKFTncL1kA7QcHZegzczTvAcMqmuLRdnkQKHQBxoI9bTiyoWCv/NyPH3WWJLw== X-Received: by 2002:a05:6a00:4b0a:b0:6ec:ef1c:4dcd with SMTP id kq10-20020a056a004b0a00b006ecef1c4dcdmr676776pfb.6.1714587581786; Wed, 01 May 2024 11:19:41 -0700 (PDT) Received: from [192.168.1.2] (syn-023-240-098-037.res.spectrum.com. [23.240.98.37]) by smtp.googlemail.com with ESMTPSA id t8-20020a056a0021c800b006ecffb316ccsm22812865pfj.202.2024.05.01.11.19.40 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Wed, 01 May 2024 11:19:41 -0700 (PDT) Message-ID: <24c6739d-d276-aea1-aa9b-99852dcf744f@HIDDEN> Date: Wed, 1 May 2024 11:19:39 -0700 MIME-Version: 1.0 Subject: Re: bug#70691: 30.0.50; [PATCH] Eshell's TERM env varible use eshell-term-name as default To: Eli Zaretskii <eliz@HIDDEN>, Lin Sun <sunlin7.mail@HIDDEN> References: <CABCREdq_VzV=MdmzU7Pta+5aoDqK_Z7gxrkYARa8vm9V3Mmh9A@HIDDEN> <865xvxpw3c.fsf@HIDDEN> Content-Language: en-US From: Jim Porter <jporterbugs@HIDDEN> In-Reply-To: <865xvxpw3c.fsf@HIDDEN> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit X-Spam-Score: 0.0 (/) X-Debbugs-Envelope-To: 70691 Cc: 70691 <at> debbugs.gnu.org X-BeenThere: debbugs-submit <at> debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: <debbugs-submit.debbugs.gnu.org> List-Unsubscribe: <https://debbugs.gnu.org/cgi-bin/mailman/options/debbugs-submit>, <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=unsubscribe> List-Archive: <https://debbugs.gnu.org/cgi-bin/mailman/private/debbugs-submit/> List-Post: <mailto:debbugs-submit <at> debbugs.gnu.org> List-Help: <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=help> List-Subscribe: <https://debbugs.gnu.org/cgi-bin/mailman/listinfo/debbugs-submit>, <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=subscribe> Errors-To: debbugs-submit-bounces <at> debbugs.gnu.org Sender: "Debbugs-submit" <debbugs-submit-bounces <at> debbugs.gnu.org> X-Spam-Score: -1.0 (-) On 5/1/2024 5:15 AM, Eli Zaretskii wrote: >> From: Lin Sun <sunlin7.mail@HIDDEN> >> Date: Wed, 1 May 2024 06:40:25 +0000 >> >> Since emacs-29 the Eshell has been enhanced for the ansi-color a lot. [snip] >> >> So we can safely export eshell's "TERM" with `eshell-term-name` to >> support executables with colors. >> I attached the patch, please help review it. Thanks. > > The fact that we can safely do that does not yet mean we _should_ do > it. In my book, setting TERM is a user preference, more or less. > IOW, this is a change in the default behavior. > > Jim, WDYT? Unfortunately, I don't think this is the right way to do things (or else I'm just not understanding some part of it). The docstring for 'eshell-term-name' says, "Name to use for the TERM variable when running visual commands," and its value defaults to 'term-term-name'. For visual commands (which use term.el), the terminal can do a lot more than just setting colors, such as moving the cursor around. "Normal", non-visual Eshell can't do that, so I think using the same setting for $TERM would be wrong. We could make Eshell set $TERM to "dumb-emacs-ansi", which should have the correct terminal settings. I believe that terminfo has been upstreamed into ncurses. However, I think if you want colors, it's best to change 'comint-terminfo-terminal' instead to "dumb-emacs-ansi" (and then Eshell will use that setting automatically). I *don't* think we should change 'comint-terminfo-terminal' by default though; that would be pretty invasive. Maybe we could use the Customize interface to make selecting "dumb-emacs-ansi" a matter of just checking a box, instead of typing it out by hand?
bug-gnu-emacs@HIDDEN:bug#70691; Package emacs.
Full text available.Received: (at 70691) by debbugs.gnu.org; 1 May 2024 15:52:42 +0000 From debbugs-submit-bounces <at> debbugs.gnu.org Wed May 01 11:52:42 2024 Received: from localhost ([127.0.0.1]:38069 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from <debbugs-submit-bounces <at> debbugs.gnu.org>) id 1s2CG6-0000Fr-C8 for submit <at> debbugs.gnu.org; Wed, 01 May 2024 11:52:42 -0400 Received: from mail-ed1-x535.google.com ([2a00:1450:4864:20::535]:52600) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from <sunlin7.mail@HIDDEN>) id 1s2CG0-0000Fj-Po for 70691 <at> debbugs.gnu.org; Wed, 01 May 2024 11:52:36 -0400 Received: by mail-ed1-x535.google.com with SMTP id 4fb4d7f45d1cf-571c2055cb1so1767379a12.1 for <70691 <at> debbugs.gnu.org>; Wed, 01 May 2024 08:52:11 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1714578725; x=1715183525; darn=debbugs.gnu.org; h=content-transfer-encoding:cc:to:subject:message-id:date:from :in-reply-to:references:mime-version:from:to:cc:subject:date :message-id:reply-to; bh=9bhygbNR/3dBQ/QJ8eDS+NV9wsTkMuu1FCSbD8liA4A=; b=Xab0OaQHnx/B6QGEQod8tUNN3oD8drtvpUvQ24ENycATVJzRFTxWwmvDV8U8f7/DXx Zl2RZk0QYh6qWXEe46JnwHwe1aK6lQkjJQsrk/G9+IgcjHD8AHY7ct9RAAkpxyNOuXvq G4E3MyJ3ZODENmm8zJF/9XroYlLu2s2EJHksZNQKrzTpTC3fIyRBlEfJsPbkVUzoLcu0 Zj8qgzilVyvacXYUeeoF1fcwtNMbMuzKvtQG4qxP+0cOYyc8UjOxf4YDCnF8sq5A4dNr OZpHaDkPl+8YdnGsVX8eY2jEUT7XbsNgIZAppEVbKJ53JDSyT92OZd17VNkvFpvigb1w 96nA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1714578726; x=1715183526; h=content-transfer-encoding:cc:to:subject:message-id:date:from :in-reply-to:references:mime-version:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=9bhygbNR/3dBQ/QJ8eDS+NV9wsTkMuu1FCSbD8liA4A=; b=qTWn8C9IjWopKK24MRoVwDsItOR8oPW2HH0IagK0Uk04yBaeRL0FxHxy8LY2nOq2Xh hvA6+GxQM8S+QkutWAiDUKyCxA940NP1LA8xBuILid+UNuNkvroll69k+PfJhZ7WNT0m vKMGylH2BX6jbi5Gkh324sYQdecmEIimrCl0gOXTmDfXjQKDDcY6FR1BUQ047ZayqBGT 0WrT45MgPBWLuNBBLgcWGvEHPfKYPGL9qDPxUjN83DDP5aanCCcsSVPwCqAQScnCfGaz AHs8z2PYMrWz6/l3QXEkmOx3JE9+aw6JC1H4fSCQhXW8Qle83FW6U1Kq3tCnzjNaA+KA tTWA== X-Forwarded-Encrypted: i=1; AJvYcCV0ipSCR0p/+OLNbbSR8CEuwtrsigAu9AQ22qDKMSL5BM/vkyj9jN2m/kD8cVL4/HaMtQWkStEFO/CDwJRxsEllWmNqSh8= X-Gm-Message-State: AOJu0YzUVT38fdgjMeHBCpxsUsrsFiNQwASTCOPh1veOnh6HiXyglJS4 z/4DI2fj7xM1pxvfDA15UJ+iABdXafN2nXOoZHpDhx1B4tYlSIRqY3jZwkOr/rnKrAYrqn+OB7q p9P9liivSSJCpnW7fC1jcWE3YCxw= X-Google-Smtp-Source: AGHT+IGTMo48xQprT+ijlIVoZVBAIGRZoHXMv7wi4WDdaBX7EjoW40sfj/Q/0ZveFKuz53KNklsXAH3qOD1DenjzDig= X-Received: by 2002:a50:9fca:0:b0:572:a089:75cc with SMTP id c68-20020a509fca000000b00572a08975ccmr2298533edf.5.1714578725448; Wed, 01 May 2024 08:52:05 -0700 (PDT) MIME-Version: 1.0 References: <CABCREdq_VzV=MdmzU7Pta+5aoDqK_Z7gxrkYARa8vm9V3Mmh9A@HIDDEN> <865xvxpw3c.fsf@HIDDEN> In-Reply-To: <865xvxpw3c.fsf@HIDDEN> From: Lin Sun <sunlin7.mail@HIDDEN> Date: Wed, 1 May 2024 15:51:54 +0000 Message-ID: <CABCREdpnyuJ2D3K799bbVJLDXVvcXSZNGJj_dFas=XWMMoZUYw@HIDDEN> Subject: Re: bug#70691: 30.0.50; [PATCH] Eshell's TERM env varible use eshell-term-name as default To: Eli Zaretskii <eliz@HIDDEN> Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable X-Spam-Score: 0.0 (/) X-Debbugs-Envelope-To: 70691 Cc: 70691 <at> debbugs.gnu.org, Jim Porter <jporterbugs@HIDDEN> X-BeenThere: debbugs-submit <at> debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: <debbugs-submit.debbugs.gnu.org> List-Unsubscribe: <https://debbugs.gnu.org/cgi-bin/mailman/options/debbugs-submit>, <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=unsubscribe> List-Archive: <https://debbugs.gnu.org/cgi-bin/mailman/private/debbugs-submit/> List-Post: <mailto:debbugs-submit <at> debbugs.gnu.org> List-Help: <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=help> List-Subscribe: <https://debbugs.gnu.org/cgi-bin/mailman/listinfo/debbugs-submit>, <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=subscribe> Errors-To: debbugs-submit-bounces <at> debbugs.gnu.org Sender: "Debbugs-submit" <debbugs-submit-bounces <at> debbugs.gnu.org> X-Spam-Score: -1.0 (-) On Wed, May 1, 2024 at 12:15=E2=80=AFPM Eli Zaretskii <eliz@HIDDEN> wrote: > > > From: Lin Sun <sunlin7.mail@HIDDEN> > > Date: Wed, 1 May 2024 06:40:25 +0000 > > > > Since emacs-29 the Eshell has been enhanced for the ansi-color a lot. > > And the function `eshell-exec-visual` can support the executables with > > colors, eg VIM, tmux... > > I have tested the "/bin/ls --color=3Dtty", "/bin/grep --color=3Dtty" ..= . > > and other executables in Eshell with "export TERM=3Deshell-color", they > > all work great. > > > > So we can safely export eshell's "TERM" with `eshell-term-name` to > > support executables with colors. > > I attached the patch, please help review it. Thanks. > > Thanks. > > The fact that we can safely do that does not yet mean we _should_ do > it. In my book, setting TERM is a user preference, more or less. > IOW, this is a change in the default behavior. > > Jim, WDYT? The patch tries to uniform the behavior of "eshell" and "eshell-exec-visual= ". When I tried the eshell visual commands, I noticed its experience is better than eshell, and I figured out the eshell exec visual gives TERM with "eshell-term-name", but eshell didn't do that. And this patch will not affect the users who customized their TERM environment in eshell profile or eshell hook functions.
bug-gnu-emacs@HIDDEN:bug#70691; Package emacs.
Full text available.Received: (at 70691) by debbugs.gnu.org; 1 May 2024 12:15:36 +0000 From debbugs-submit-bounces <at> debbugs.gnu.org Wed May 01 08:15:36 2024 Received: from localhost ([127.0.0.1]:37177 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from <debbugs-submit-bounces <at> debbugs.gnu.org>) id 1s28s4-00059H-Bw for submit <at> debbugs.gnu.org; Wed, 01 May 2024 08:15:36 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]:51272) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from <eliz@HIDDEN>) id 1s28s3-0004pU-6O for 70691 <at> debbugs.gnu.org; Wed, 01 May 2024 08:15:35 -0400 Received: from fencepost.gnu.org ([2001:470:142:3::e]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from <eliz@HIDDEN>) id 1s28rb-0005rx-Bw; Wed, 01 May 2024 08:15:07 -0400 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=gnu.org; s=fencepost-gnu-org; h=References:Subject:In-Reply-To:To:From:Date: mime-version; bh=j6aMuQ7KUU5FhwkvVyKAe6+3ur9rP1S71F1F9dGIvgM=; b=Udn9yAq/Fleq 63kqsLsZQ6sa7s8LQWEm5fQQVM6gC7sPA448ZLeBKbi6pmHbVOcQnR4e9WUTtu0MXR1PuIzC8qgTs Mb6kXL+H5lFBvr0NPLMlS4hQWCPEDjRIOcr0CFQBnL/D/ZPjeAYBtb1lU5xlIJoB+IMH4+KiNWWaw GznIC6k9vKgju4iDFIeyynZ7Od9C8mkOI+me/OqUkeSDvkh9dQMJcyJpnQuJ/0DZM3tm6tZjTRq49 4U8mUV0juGSAloqC3CkEC2nTjKAsohb0Q0sjmgh360L1W5dGaJgPb3+0OsipeIp4bsXrRApI7P8H6 33okFjg9M0M0lIFWvEmdTA==; Date: Wed, 01 May 2024 15:15:03 +0300 Message-Id: <865xvxpw3c.fsf@HIDDEN> From: Eli Zaretskii <eliz@HIDDEN> To: Lin Sun <sunlin7.mail@HIDDEN>, Jim Porter <jporterbugs@HIDDEN> In-Reply-To: <CABCREdq_VzV=MdmzU7Pta+5aoDqK_Z7gxrkYARa8vm9V3Mmh9A@HIDDEN> (message from Lin Sun on Wed, 1 May 2024 06:40:25 +0000) Subject: Re: bug#70691: 30.0.50; [PATCH] Eshell's TERM env varible use eshell-term-name as default References: <CABCREdq_VzV=MdmzU7Pta+5aoDqK_Z7gxrkYARa8vm9V3Mmh9A@HIDDEN> X-Spam-Score: -2.3 (--) X-Debbugs-Envelope-To: 70691 Cc: 70691 <at> debbugs.gnu.org X-BeenThere: debbugs-submit <at> debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: <debbugs-submit.debbugs.gnu.org> List-Unsubscribe: <https://debbugs.gnu.org/cgi-bin/mailman/options/debbugs-submit>, <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=unsubscribe> List-Archive: <https://debbugs.gnu.org/cgi-bin/mailman/private/debbugs-submit/> List-Post: <mailto:debbugs-submit <at> debbugs.gnu.org> List-Help: <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=help> List-Subscribe: <https://debbugs.gnu.org/cgi-bin/mailman/listinfo/debbugs-submit>, <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=subscribe> Errors-To: debbugs-submit-bounces <at> debbugs.gnu.org Sender: "Debbugs-submit" <debbugs-submit-bounces <at> debbugs.gnu.org> X-Spam-Score: -3.3 (---) > From: Lin Sun <sunlin7.mail@HIDDEN> > Date: Wed, 1 May 2024 06:40:25 +0000 > > Since emacs-29 the Eshell has been enhanced for the ansi-color a lot. > And the function `eshell-exec-visual` can support the executables with > colors, eg VIM, tmux... > I have tested the "/bin/ls --color=tty", "/bin/grep --color=tty" ... > and other executables in Eshell with "export TERM=eshell-color", they > all work great. > > So we can safely export eshell's "TERM" with `eshell-term-name` to > support executables with colors. > I attached the patch, please help review it. Thanks. Thanks. The fact that we can safely do that does not yet mean we _should_ do it. In my book, setting TERM is a user preference, more or less. IOW, this is a change in the default behavior. Jim, WDYT?
bug-gnu-emacs@HIDDEN:bug#70691; Package emacs.
Full text available.Received: (at submit) by debbugs.gnu.org; 1 May 2024 06:41:17 +0000 From debbugs-submit-bounces <at> debbugs.gnu.org Wed May 01 02:41:17 2024 Received: from localhost ([127.0.0.1]:35669 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from <debbugs-submit-bounces <at> debbugs.gnu.org>) id 1s23eX-0001tO-27 for submit <at> debbugs.gnu.org; Wed, 01 May 2024 02:41:17 -0400 Received: from lists.gnu.org ([2001:470:142::17]:35984) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from <sunlin7.mail@HIDDEN>) id 1s23eR-0001t6-8o for submit <at> debbugs.gnu.org; Wed, 01 May 2024 02:41:15 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from <sunlin7.mail@HIDDEN>) id 1s23dw-0004iu-UP for bug-gnu-emacs@HIDDEN; Wed, 01 May 2024 02:40:42 -0400 Received: from mail-ej1-x634.google.com ([2a00:1450:4864:20::634]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from <sunlin7.mail@HIDDEN>) id 1s23dv-0001up-2F for bug-gnu-emacs@HIDDEN; Wed, 01 May 2024 02:40:40 -0400 Received: by mail-ej1-x634.google.com with SMTP id a640c23a62f3a-a51a80b190bso419387966b.3 for <bug-gnu-emacs@HIDDEN>; Tue, 30 Apr 2024 23:40:38 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1714545637; x=1715150437; darn=gnu.org; h=to:subject:message-id:date:from:mime-version:from:to:cc:subject :date:message-id:reply-to; bh=1kVkLu2ycqv+NhfWRuItdRObq/mHxsWOZ+S+llSB0mI=; b=lV4woNP0U3XriPGihAsKUTS8mN1Lcr1te6x0SLoxQs/ku+e8WN5bje+4MW9i95ghML wzUlrl/0m77FYvP1S/sZ1dBH20+lCf4MIQUt8xrvKs3qsM7sk2cw/V+nZW0triSIZzIY 0MvseAb7YpbmE1Yn6SqUZL+gkjaGclGvjfrvuOFSyr8NYYBfs1ghX2vjW0dVh1JwM2j3 xQDtrTHZU/SbrGqtD3LKh23SU9Y0JT8TnzUMO8oQT/0y/bsyXQfmXdAecg7Toa7xpP9j V0koD2/xkRew6ZkBd4TuaWC/cjPpSiVnX4mc6HKnYKsrBzBCNQRhIPwdYdamZh0T/eyw os0A== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1714545637; x=1715150437; h=to:subject:message-id:date:from:mime-version:x-gm-message-state :from:to:cc:subject:date:message-id:reply-to; bh=1kVkLu2ycqv+NhfWRuItdRObq/mHxsWOZ+S+llSB0mI=; b=KJyoilUAzuBERYn3hapZgYasfnczn2Tyh+0wRdoAbDzUlcF9uPcegVgQwKGh3w4zZg E/1boxJFskhjmBIS7eClX+CmgEM7ks8oTzMEYwjdzKHUvwGO8tiOFiFD6m+XxBkdtN1n OVHEMGM0QPPsEcVBHMwnsoQzIj13p5LaOSA3odyRZwhOlKiKbVb0KmFAQ82TvRThgJkP db7+cUutAKQX8HesqchpDmWjTAb80O+g9hEuu8hT71/hpdB87T1SvcNGWlGfrVVekSK0 jcXE83qerR7n6xnxS+YZ4VAyzzIzGhS1xfcAj1dr6mx6tCc/KuDo2sPYlGQWVZ0qkJsW kAeQ== X-Gm-Message-State: AOJu0Yx2OhM6vj399JmYY7kL/oE00yoaX+lsM98+FKbsap8/OfsJBtQY RvmSAk1xZ+W4YOhofEp5BdOElGfWj4dhiTsH9zImXMZG0lItxcE7ekZTT56V2KOaqKueCKQILXf lMt+8Ldvzduqtkd9SCm0R1z0X2SkR8x+G X-Google-Smtp-Source: AGHT+IEagIDIygcrsiyYbVLQwrp50DUxMyy9Og7/FSUBHekj3gfsWBwIb3NKxP1urpSJ3EcMnevZ5kO2tzqcGinYNt0= X-Received: by 2002:a50:9549:0:b0:572:5630:d8d6 with SMTP id v9-20020a509549000000b005725630d8d6mr1182035eda.22.1714545636972; Tue, 30 Apr 2024 23:40:36 -0700 (PDT) MIME-Version: 1.0 From: Lin Sun <sunlin7.mail@HIDDEN> Date: Wed, 1 May 2024 06:40:25 +0000 Message-ID: <CABCREdq_VzV=MdmzU7Pta+5aoDqK_Z7gxrkYARa8vm9V3Mmh9A@HIDDEN> Subject: 30.0.50; [PATCH] Eshell's TERM env varible use eshell-term-name as default To: bug-gnu-emacs@HIDDEN Content-Type: multipart/mixed; boundary="000000000000a4cb1f06175ec34b" Received-SPF: pass client-ip=2a00:1450:4864:20::634; envelope-from=sunlin7.mail@HIDDEN; helo=mail-ej1-x634.google.com X-Spam_score_int: -20 X-Spam_score: -2.1 X-Spam_bar: -- X-Spam_report: (-2.1 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, FREEMAIL_FROM=0.001, RCVD_IN_DNSWL_NONE=-0.0001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-Spam-Score: 1.0 (+) X-Debbugs-Envelope-To: submit X-BeenThere: debbugs-submit <at> debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: <debbugs-submit.debbugs.gnu.org> List-Unsubscribe: <https://debbugs.gnu.org/cgi-bin/mailman/options/debbugs-submit>, <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=unsubscribe> List-Archive: <https://debbugs.gnu.org/cgi-bin/mailman/private/debbugs-submit/> List-Post: <mailto:debbugs-submit <at> debbugs.gnu.org> List-Help: <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=help> List-Subscribe: <https://debbugs.gnu.org/cgi-bin/mailman/listinfo/debbugs-submit>, <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=subscribe> Errors-To: debbugs-submit-bounces <at> debbugs.gnu.org Sender: "Debbugs-submit" <debbugs-submit-bounces <at> debbugs.gnu.org> X-Spam-Score: -0.0 (/) --000000000000a4cb1f06175ec34b Content-Type: text/plain; charset="UTF-8" Hi, Since emacs-29 the Eshell has been enhanced for the ansi-color a lot. And the function `eshell-exec-visual` can support the executables with colors, eg VIM, tmux... I have tested the "/bin/ls --color=tty", "/bin/grep --color=tty" ... and other executables in Eshell with "export TERM=eshell-color", they all work great. So we can safely export eshell's "TERM" with `eshell-term-name` to support executables with colors. I attached the patch, please help review it. Thanks. --000000000000a4cb1f06175ec34b Content-Type: text/x-patch; charset="US-ASCII"; name="0001-Eshell-s-TERM-env-varible-use-eshell-term-name-as-de.patch" Content-Disposition: attachment; filename="0001-Eshell-s-TERM-env-varible-use-eshell-term-name-as-de.patch" Content-Transfer-Encoding: base64 Content-ID: <f_lvng71r30> X-Attachment-Id: f_lvng71r30 RnJvbSA1YTQzNDMwZTg4ZTQxNGE3OTg5MjNkODgyZWZmN2MzYjdjYjg2YzFjIE1vbiBTZXAgMTcg MDA6MDA6MDAgMjAwMQpGcm9tOiBMaW4gU3VuIDxzdW5saW43QGhvdG1haWwuY29tPgpEYXRlOiBX ZWQsIDEgTWF5IDIwMjQgMDY6NTU6MjMgKzAwMDAKU3ViamVjdDogW1BBVENIXSBFc2hlbGwncyBU RVJNIGVudiB2YXJpYmxlIHVzZSBlc2hlbGwtdGVybS1uYW1lIGFzIGRlZmF1bHQKCiogbGlzcC9l c2hlbGwvZXNoLXZhci5lbCAoZXNoZWxsLXZhcmlhYmxlLWFsaWFzZXMtbGlzdCk6CiAgSW5pdGlh bGl6ZSB0aGUgVEVSTSBlbnZpcm9ubWVudCB2YXJpYWJsZSB3aXRoIGVzaGVsbC10ZXJtLW5hbWUu CiogZG9jL21pc2MvZXNoZWxsLnRleGk6IERvY3VtZW50IGZvciBURVJNIGVudmlyb25tZW50IHZh cmlhYmxlLgoqIGV0Yy9ORVdTOiBBZGQgZW50cnkgaW4gTkVXUyBmaWxlLgotLS0KIGRvYy9taXNj L2VzaGVsbC50ZXhpICAgfCA1ICsrKysrCiBldGMvTkVXUyAgICAgICAgICAgICAgIHwgNCArKysr CiBsaXNwL2VzaGVsbC9lc2gtdmFyLmVsIHwgMSArCiAzIGZpbGVzIGNoYW5nZWQsIDEwIGluc2Vy dGlvbnMoKykKCmRpZmYgLS1naXQgYS9kb2MvbWlzYy9lc2hlbGwudGV4aSBiL2RvYy9taXNjL2Vz aGVsbC50ZXhpCmluZGV4IDMwYzg1ZGE3OTUuLjA3NjExYzQ5ZWYgMTAwNjQ0Ci0tLSBhL2RvYy9t aXNjL2VzaGVsbC50ZXhpCisrKyBiL2RvYy9taXNjL2VzaGVsbC50ZXhpCkBAIC0xNDU2LDYgKzE0 NTYsMTEgQEAgVmFyaWFibGVzCiBAY29kZXtjb21pbnQtcGFnZXJ9IGlmIG5vbi1AY29kZXtuaWx9 OyBvdGhlcndpc2UsIGl0IHVzZXMgdGhlIHZhbHVlIG9mCiBAY29kZXskUEFHRVJ9IGZyb20gdGhl IEBjb2Rle3Byb2Nlc3MtZW52aXJvbm1lbnR9LgogCitAdmluZGV4ICRURVJNCitAaXRlbSAkVEVS TQorVGhpcyB2YXJpYWJsZSBpbmRpY2F0ZXMgdGhlIHRlcm1pbmFsIHR5cGUgb2YgdGhlIGVzaGVs bC4gIEl0cyBkZWZhdWx0Cit2YWx1ZSBpcyBAY29kZXtlc2hlbGwtdGVybS1uYW1lfS4KKwogQGVu ZCB0YWJsZQogCiBAeHJlZntBbGlhc2VzfSwgZm9yIHRoZSBidWlsdC1pbiB2YXJpYWJsZXMgQHNh bXB7JCp9LCBAc2FtcHskMX0sCmRpZmYgLS1naXQgYS9ldGMvTkVXUyBiL2V0Yy9ORVdTCmluZGV4 IDRiMDEwNmZjYjAuLjVlYmM1MTcyZjYgMTAwNjQ0Ci0tLSBhL2V0Yy9ORVdTCisrKyBiL2V0Yy9O RVdTCkBAIC04NjQsNiArODY0LDEwIEBAIGNvbW1hbmQgcGFzc2VkIGFzIGFyZ3VtZW50cyB0byAn ZW52Jy4gIElmIHlvdSBwYXNzIGFueSBpbml0aWFsCiBhcmd1bWVudHMgb2YgdGhlIGZvcm0gJ1ZB Uj1WQUxVRScsICdlbnYnIHdpbGwgZmlyc3Qgc2V0ICdWQVInIHRvCiAnVkFMVUUnIGJlZm9yZSBy dW5uaW5nIHRoZSBjb21tYW5kLgogCisrKysKKyoqKiBFc2hlbGwncyAnVEVSTScgZW52IHZhciB1 c2VzICdlc2hlbGwtdGVybS1uYW1lJyBhcyBkZWZhdWx0LgorVGhlIGVzaGVsbCdzICdURVJNJyBl bnZpcm9ubWVudCB2YXJpYWJsZSB1c2VzICdlc2hlbGwtdGVybS1uYW1lJyBhcyBkZWZhdWx0Lgor CiAtLS0KICoqKiBFc2hlbGwncyAndW1hc2snIGNvbW1hbmQgbm93IHN1cHBvcnRzIHNldHRpbmcg dGhlIG1hc2sgc3ltYm9saWNhbGx5LgogTm93LCB5b3UgY2FuIHBhc3MgYW4gYXJndW1lbnQgbGlr ZSAidSt3LG8tciIgdG8gRXNoZWxsJ3MgJ3VtYXNrJwpkaWZmIC0tZ2l0IGEvbGlzcC9lc2hlbGwv ZXNoLXZhci5lbCBiL2xpc3AvZXNoZWxsL2VzaC12YXIuZWwKaW5kZXggMDJiNWM3ODU2Mi4uOGRk OGE4NGRhOCAxMDA2NDQKLS0tIGEvbGlzcC9lc2hlbGwvZXNoLXZhci5lbAorKysgYi9saXNwL2Vz aGVsbC9lc2gtdmFyLmVsCkBAIC0xNjEsNiArMTYxLDcgQEAgZXNoZWxsLXZhcmlhYmxlLWFsaWFz ZXMtbGlzdAogICBgKDs7IGZvciBlc2hlbGwuZWwKICAgICAoIkNPTFVNTlMiICwobGFtYmRhICgp ICh3aW5kb3ctYm9keS13aWR0aCBuaWwgJ3JlbWFwKSkgdCB0KQogICAgICgiTElORVMiICwobGFt YmRhICgpICh3aW5kb3ctYm9keS1oZWlnaHQgbmlsICdyZW1hcCkpIHQgdCkKKyAgICAoIlRFUk0i IGVzaGVsbC10ZXJtLW5hbWUgdCkKICAgICAoIklOU0lERV9FTUFDUyIgZXNoZWxsLWluc2lkZS1l bWFjcyB0KQogICAgICgiUEFHRVIiICgsKGxhbWJkYSAoKSAob3IgY29taW50LXBhZ2VyIChnZXRl bnYgIlBBR0VSIikpKQogICAgICAgICAgICAgICAuICwobGFtYmRhIChfIHZhbHVlKQotLSAKMi4y MC41Cgo= --000000000000a4cb1f06175ec34b--
Lin Sun <sunlin7.mail@HIDDEN>:bug-gnu-emacs@HIDDEN.
Full text available.bug-gnu-emacs@HIDDEN:bug#70691; Package emacs.
Full text available.
GNU bug tracking system
Copyright (C) 1999 Darren O. Benham,
1997 nCipher Corporation Ltd,
1994-97 Ian Jackson.