X-Loop: help-debbugs@HIDDEN
Subject: [bug#70715] [PATCH 0/4] Change imported crate style.
Resent-From: Herman Rimm <herman@HIDDEN>
Original-Sender: "Debbugs-submit" <debbugs-submit-bounces <at> debbugs.gnu.org>
Resent-CC: guix-patches@HIDDEN
Resent-Date: Thu, 02 May 2024 12:58:01 +0000
Resent-Message-ID: <handler.70715.B.171465467421713 <at> debbugs.gnu.org>
Resent-Sender: help-debbugs@HIDDEN
X-GNU-PR-Message: report 70715
X-GNU-PR-Package: guix-patches
X-GNU-PR-Keywords: patch
To: 70715 <at> debbugs.gnu.org
X-Debbugs-Original-To: guix-patches@HIDDEN
Received: via spool by submit <at> debbugs.gnu.org id=B.171465467421713
(code B ref -1); Thu, 02 May 2024 12:58:01 +0000
Received: (at submit) by debbugs.gnu.org; 2 May 2024 12:57:54 +0000
Received: from localhost ([127.0.0.1]:43619 helo=debbugs.gnu.org)
by debbugs.gnu.org with esmtp (Exim 4.84_2)
(envelope-from <debbugs-submit-bounces <at> debbugs.gnu.org>)
id 1s2W0X-0005e9-Sg
for submit <at> debbugs.gnu.org; Thu, 02 May 2024 08:57:54 -0400
Received: from lists.gnu.org ([2001:470:142::17]:51058)
by debbugs.gnu.org with esmtp (Exim 4.84_2)
(envelope-from <herman@HIDDEN>) id 1s2W0U-0005e1-TY
for submit <at> debbugs.gnu.org; Thu, 02 May 2024 08:57:52 -0400
Received: from eggs.gnu.org ([2001:470:142:3::10])
by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256)
(Exim 4.90_1) (envelope-from <herman@HIDDEN>) id 1s2W03-00009D-4J
for guix-patches@HIDDEN; Thu, 02 May 2024 08:57:23 -0400
Received: from 81-205-150-117.fixed.kpn.net ([81.205.150.117]
helo=email.rimm.ee)
by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_CHACHA20_POLY1305:256)
(Exim 4.90_1) (envelope-from <herman@HIDDEN>) id 1s2Vzu-00005a-87
for guix-patches@HIDDEN; Thu, 02 May 2024 08:57:22 -0400
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=rimm.ee; s=herman;
t=1714654626;
h=from:from:reply-to:subject:subject:date:date:message-id:message-id:
to:to:cc:mime-version:mime-version:
content-transfer-encoding:content-transfer-encoding;
bh=0wIoS7kH+DmddOyUQypV9LtA32zV+aXfM8vBdBn9pRY=;
b=ZxP2HXstNZ2UwUtFtn2ZrWeQ7wNsv7UcmrJAZp2UCk5p/e1dFWw0xg7qNhISVn5GM2QVox
EIRRyykh2q8tdi1Uam99m5pJ40waYozBVeBe0k5l7pPWxETu0/K9bjeozPM2FNtB+uNPjq
g8pBB0RlNsnDXiLTic/p56vG28AlxlqI9bjKuhgvvQnD+X/7mN0UBgRMOXXzmZ6Xn5NSDA
BQ7AlIluPqNhtiRgYGepIYJiW5rNC//+XlFXxe31N+99OY8EwgkkoxmvTgZaJnvSIYzWbI
/nPDAIja81qtgMcYzuca18SZDcqEG0bB1Y68Zi1wiPUklNzACIpyk37ZvjjhNg==
Received: by 81-205-150-117.fixed.kpn.net (OpenSMTPD) with ESMTPSA id 8e32b643
(TLSv1.3:TLS_CHACHA20_POLY1305_SHA256:256:NO)
for <guix-patches@HIDDEN>; Thu, 2 May 2024 12:57:06 +0000 (UTC)
From: Herman Rimm <herman@HIDDEN>
Date: Thu, 2 May 2024 14:57:00 +0200
Message-ID: <20240502125700.15062-1-herman@HIDDEN>
X-Mailer: git-send-email 2.41.0
MIME-Version: 1.0
Content-Transfer-Encoding: 8bit
Received-SPF: pass client-ip=81.205.150.117; envelope-from=herman@HIDDEN;
helo=email.rimm.ee
X-Spam_score_int: -20
X-Spam_score: -2.1
X-Spam_bar: --
X-Spam_report: (-2.1 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1,
DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, SPF_HELO_NONE=0.001,
SPF_PASS=-0.001, TVD_RCVD_IP=0.001 autolearn=ham autolearn_force=no
X-Spam_action: no action
X-Spam-Score: 0.9 (/)
X-BeenThere: debbugs-submit <at> debbugs.gnu.org
X-Mailman-Version: 2.1.18
Precedence: list
List-Id: <debbugs-submit.debbugs.gnu.org>
List-Unsubscribe: <https://debbugs.gnu.org/cgi-bin/mailman/options/debbugs-submit>,
<mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=unsubscribe>
List-Archive: <https://debbugs.gnu.org/cgi-bin/mailman/private/debbugs-submit/>
List-Post: <mailto:debbugs-submit <at> debbugs.gnu.org>
List-Help: <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=help>
List-Subscribe: <https://debbugs.gnu.org/cgi-bin/mailman/listinfo/debbugs-submit>,
<mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=subscribe>
Errors-To: debbugs-submit-bounces <at> debbugs.gnu.org
Sender: "Debbugs-submit" <debbugs-submit-bounces <at> debbugs.gnu.org>
X-Spam-Score: -0.1 (/)
Hello,
Having created about 60 packages with the crate importer, I did it
slightly faster than usual with this patch series applied.
I would say 75% of the time the unindented #:cargo-development-inputs
exceeded 72 characters.
About 20% of the time a crate synopsis and description start with a
proper noun (Rust) or an acronym (FFI). Adding 'This package provides '
makes the description into more of a sentence, though sometimes an
indefinite article is missing. I could also instead add a flag to 'guix
import' for extending the description in this way.
Cheers,
Herman
Herman Rimm (4):
guix: Indent cargo-development-inputs.
guix: Beautify crate importer synopses.
guix: Include a main verb in crate importer descriptions.
guix: End package descriptions with period.
guix/import/crate.scm | 12 ++++++++----
guix/import/utils.scm | 7 +++++++
guix/read-print.scm | 1 +
3 files changed, 16 insertions(+), 4 deletions(-)
--
2.41.0
Content-Disposition: inline Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 X-Mailer: MIME-tools 5.505 (Entity 5.505) Content-Type: text/plain; charset=utf-8 X-Loop: help-debbugs@HIDDEN From: help-debbugs@HIDDEN (GNU bug Tracking System) To: Herman Rimm <herman@HIDDEN> Subject: bug#70715: Acknowledgement ([PATCH 0/4] Change imported crate style.) Message-ID: <handler.70715.B.171465467421713.ack <at> debbugs.gnu.org> References: <20240502125700.15062-1-herman@HIDDEN> X-Gnu-PR-Message: ack 70715 X-Gnu-PR-Package: guix-patches X-Gnu-PR-Keywords: patch Reply-To: 70715 <at> debbugs.gnu.org Date: Thu, 02 May 2024 12:58:02 +0000 Thank you for filing a new bug report with debbugs.gnu.org. This is an automatically generated reply to let you know your message has been received. Your message is being forwarded to the package maintainers and other interested parties for their attention; they will reply in due course. Your message has been sent to the package maintainer(s): guix-patches@HIDDEN If you wish to submit further information on this problem, please send it to 70715 <at> debbugs.gnu.org. Please do not send mail to help-debbugs@HIDDEN unless you wish to report a problem with the Bug-tracking system. --=20 70715: https://debbugs.gnu.org/cgi/bugreport.cgi?bug=3D70715 GNU Bug Tracking System Contact help-debbugs@HIDDEN with problems
X-Loop: help-debbugs@HIDDEN
Subject: [bug#70715] [PATCH 1/4] guix: Indent cargo-development-inputs.
References: <20240502125700.15062-1-herman@HIDDEN>
In-Reply-To: <20240502125700.15062-1-herman@HIDDEN>
Resent-From: Herman Rimm <herman@HIDDEN>
Original-Sender: "Debbugs-submit" <debbugs-submit-bounces <at> debbugs.gnu.org>
Resent-CC: guix-patches@HIDDEN
Resent-Date: Thu, 02 May 2024 13:00:01 +0000
Resent-Message-ID: <handler.70715.B70715.171465477921832 <at> debbugs.gnu.org>
Resent-Sender: help-debbugs@HIDDEN
X-GNU-PR-Message: followup 70715
X-GNU-PR-Package: guix-patches
X-GNU-PR-Keywords: patch
To: 70715 <at> debbugs.gnu.org
Received: via spool by 70715-submit <at> debbugs.gnu.org id=B70715.171465477921832
(code B ref 70715); Thu, 02 May 2024 13:00:01 +0000
Received: (at 70715) by debbugs.gnu.org; 2 May 2024 12:59:39 +0000
Received: from localhost ([127.0.0.1]:43632 helo=debbugs.gnu.org)
by debbugs.gnu.org with esmtp (Exim 4.84_2)
(envelope-from <debbugs-submit-bounces <at> debbugs.gnu.org>)
id 1s2W2F-0005g3-C2
for submit <at> debbugs.gnu.org; Thu, 02 May 2024 08:59:39 -0400
Received: from 81-205-150-117.fixed.kpn.net ([81.205.150.117]:53769
helo=email.rimm.ee) by debbugs.gnu.org with esmtp (Exim 4.84_2)
(envelope-from <herman@HIDDEN>) id 1s2W2D-0005fj-ES
for 70715 <at> debbugs.gnu.org; Thu, 02 May 2024 08:59:38 -0400
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=rimm.ee; s=herman;
t=1714654749;
h=from:from:reply-to:subject:subject:date:date:message-id:message-id:
to:to:cc:mime-version:mime-version:
content-transfer-encoding:content-transfer-encoding;
bh=NAtQpeOnGjzELXOfwBw88U3gMEVaL898HkOT2yEiImg=;
b=MZwa1hxktAYVX3NC+k31ocWGLninjjZwxVuSphaLWAms12Ib5hRUo1qdhNJT5jTmuhNDsw
g6AUB1Y6CTovWuUSaR6j+cfxAHH6c0ZJJPSvxCsFIisTO3wkKnjoNPhKSmtdjnqurZ4HeU
pZMbXJS3AAWKJ0nSWY8uRFGD6h8leW6losTuMDsAd3tTsKf2pLXuxxukzEUui1iJCNJ7qA
JkRovsWU+fB0s6llQ0sAwHd0jbTmqZzrS0BlnVpd/diayg5bapbo4TiO8qWs2sNw6MdGGh
47MO59tNJ53FT4Z0qbmXxfii6P1GB1DsYUMPXKX47L8KSff6fwCaGX5ZdW4emA==
Received: by 81-205-150-117.fixed.kpn.net (OpenSMTPD) with ESMTPSA id 1c252a8d
(TLSv1.3:TLS_CHACHA20_POLY1305_SHA256:256:NO)
for <70715 <at> debbugs.gnu.org>; Thu, 2 May 2024 12:59:08 +0000 (UTC)
From: Herman Rimm <herman@HIDDEN>
Date: Thu, 2 May 2024 14:58:57 +0200
Message-ID: <20240502125900.15177-1-herman@HIDDEN>
X-Mailer: git-send-email 2.41.0
MIME-Version: 1.0
Content-Transfer-Encoding: 8bit
X-Spam-Score: 3.6 (+++)
X-Spam-Report: Spam detection software, running on the system "debbugs.gnu.org",
has NOT identified this incoming email as spam. The original
message has been attached to this so you can view it or label
similar future email. If you have any questions, see
the administrator of that system for details.
Content preview: * guix/import/crate.scm (make-crate-sexp): Swap
cargo-development-inputs
and cargo-inputs. * guix/read-print.scm (%newline-forms): Add
#:cargo-development-inputs.
Change-Id: I54a8c1934381cdb25b6d05e503d2bd2315d010b6 --- guix/import/crate.scm
| 4 ++-- guix/read-print.scm | 1 + 2 files changed, 3 insertions(+),
2 deletions(-)
Content analysis details: (3.6 points, 10.0 required)
pts rule name description
---- ---------------------- --------------------------------------------------
3.6 RCVD_IN_PBL RBL: Received via a relay in Spamhaus PBL
[81.205.150.117 listed in zen.spamhaus.org]
0.0 TVD_RCVD_IP Message was received from an IP address
-0.0 SPF_PASS SPF: sender matches SPF record
0.0 SPF_HELO_NONE SPF: HELO does not publish an SPF Record
X-BeenThere: debbugs-submit <at> debbugs.gnu.org
X-Mailman-Version: 2.1.18
Precedence: list
List-Id: <debbugs-submit.debbugs.gnu.org>
List-Unsubscribe: <https://debbugs.gnu.org/cgi-bin/mailman/options/debbugs-submit>,
<mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=unsubscribe>
List-Archive: <https://debbugs.gnu.org/cgi-bin/mailman/private/debbugs-submit/>
List-Post: <mailto:debbugs-submit <at> debbugs.gnu.org>
List-Help: <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=help>
List-Subscribe: <https://debbugs.gnu.org/cgi-bin/mailman/listinfo/debbugs-submit>,
<mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=subscribe>
Errors-To: debbugs-submit-bounces <at> debbugs.gnu.org
Sender: "Debbugs-submit" <debbugs-submit-bounces <at> debbugs.gnu.org>
X-Spam-Score: 2.6 (++)
X-Spam-Report: Spam detection software, running on the system "debbugs.gnu.org",
has NOT identified this incoming email as spam. The original
message has been attached to this so you can view it or label
similar future email. If you have any questions, see
the administrator of that system for details.
Content preview: * guix/import/crate.scm (make-crate-sexp): Swap cargo-development-inputs
and cargo-inputs. * guix/read-print.scm (%newline-forms): Add #:cargo-development-inputs.
Change-Id: I54a8c1934381cdb25b6d05e503d2bd2315d010b6 --- guix/import/crate.scm
| 4 ++-- guix/read-print.scm | 1 + 2 files changed, 3 insertions(+), 2 deletions(-)
Content analysis details: (2.6 points, 10.0 required)
pts rule name description
---- ---------------------- --------------------------------------------------
3.6 RCVD_IN_PBL RBL: Received via a relay in Spamhaus PBL
[81.205.150.117 listed in zen.spamhaus.org]
-0.0 SPF_PASS SPF: sender matches SPF record
0.0 SPF_HELO_NONE SPF: HELO does not publish an SPF Record
-1.0 MAILING_LIST_MULTI Multiple indicators imply a widely-seen list
manager
* guix/import/crate.scm (make-crate-sexp): Swap cargo-development-inputs
and cargo-inputs.
* guix/read-print.scm (%newline-forms): Add #:cargo-development-inputs.
Change-Id: I54a8c1934381cdb25b6d05e503d2bd2315d010b6
---
guix/import/crate.scm | 4 ++--
guix/read-print.scm | 1 +
2 files changed, 3 insertions(+), 2 deletions(-)
diff --git a/guix/import/crate.scm b/guix/import/crate.scm
index 7a25b2243c..81e442141b 100644
--- a/guix/import/crate.scm
+++ b/guix/import/crate.scm
@@ -207,9 +207,9 @@ (define (format-inputs inputs)
,@(maybe-arguments (append (if build?
'()
'(#:skip-build? #t))
- (maybe-cargo-inputs cargo-inputs)
(maybe-cargo-development-inputs
- cargo-development-inputs)))
+ cargo-development-inputs)
+ (maybe-cargo-inputs cargo-inputs)))
(home-page ,home-page)
(synopsis ,synopsis)
(description ,(beautify-description description))
diff --git a/guix/read-print.scm b/guix/read-print.scm
index 6421b79737..80662f7189 100644
--- a/guix/read-print.scm
+++ b/guix/read-print.scm
@@ -365,6 +365,7 @@ (define %newline-forms
('git-reference '(uri origin source))
('sha256 '(origin source package))
('arguments '(package))
+ ('#:cargo-development-inputs '(arguments))
('list '(arguments package))
('search-paths '(package))
('native-search-paths '(package))
--
2.41.0
X-Loop: help-debbugs@HIDDEN
Subject: [bug#70715] [PATCH 2/4] guix: Beautify crate importer synopses.
Resent-From: Herman Rimm <herman@HIDDEN>
Original-Sender: "Debbugs-submit" <debbugs-submit-bounces <at> debbugs.gnu.org>
Resent-CC: guix-patches@HIDDEN
Resent-Date: Thu, 02 May 2024 13:00:02 +0000
Resent-Message-ID: <handler.70715.B70715.171465478021844 <at> debbugs.gnu.org>
Resent-Sender: help-debbugs@HIDDEN
X-GNU-PR-Message: followup 70715
X-GNU-PR-Package: guix-patches
X-GNU-PR-Keywords: patch
To: 70715 <at> debbugs.gnu.org
Received: via spool by 70715-submit <at> debbugs.gnu.org id=B70715.171465478021844
(code B ref 70715); Thu, 02 May 2024 13:00:02 +0000
Received: (at 70715) by debbugs.gnu.org; 2 May 2024 12:59:40 +0000
Received: from localhost ([127.0.0.1]:43634 helo=debbugs.gnu.org)
by debbugs.gnu.org with esmtp (Exim 4.84_2)
(envelope-from <debbugs-submit-bounces <at> debbugs.gnu.org>)
id 1s2W2F-0005g5-M7
for submit <at> debbugs.gnu.org; Thu, 02 May 2024 08:59:40 -0400
Received: from 81-205-150-117.fixed.kpn.net ([81.205.150.117]:53769
helo=email.rimm.ee) by debbugs.gnu.org with esmtp (Exim 4.84_2)
(envelope-from <herman@HIDDEN>) id 1s2W2E-0005fj-FR
for 70715 <at> debbugs.gnu.org; Thu, 02 May 2024 08:59:38 -0400
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=rimm.ee; s=herman;
t=1714654749;
h=from:from:reply-to:subject:subject:date:date:message-id:message-id:
to:to:cc:mime-version:mime-version:
content-transfer-encoding:content-transfer-encoding:
in-reply-to:in-reply-to:references:references;
bh=1gKiFeLS2qdzauVj0in3hDBSvz+CG2TxLnjtSH7gSUk=;
b=D9OuMjxpH1vve6XNhqZamzDyXH4RYEYYmhc9iqjUJWzG9lw1cbCqxcNof+JxT5I9uxkxuJ
h3BWB06usWzVfd4gbetjb+/HLh2tczQq1XhjjYHqiLAuvY5hWCvK98rsasb6+oVnpXNNGh
AUBf+zlX9Scbn/8PsIXO7JBwjNKPcW1V/3sKAoD/8zG94g+ii5YLX1O2j7z1ox7PVt/9Yb
APuG1Tb4aBooXt1yrL0cd/nR4Pt2uV2U/rH2n/n8WBIB6Rz8H1nGS/P77x8WRqk16I132M
oIYW+Qy4//APxQIvj7y/msbSH8ytBnJa7/nSuGgtCS7P6vbuqXRVVqU1Du8chw==
Received: by 81-205-150-117.fixed.kpn.net (OpenSMTPD) with ESMTPSA id ddfa2a48
(TLSv1.3:TLS_CHACHA20_POLY1305_SHA256:256:NO)
for <70715 <at> debbugs.gnu.org>; Thu, 2 May 2024 12:59:09 +0000 (UTC)
From: Herman Rimm <herman@HIDDEN>
Date: Thu, 2 May 2024 14:58:58 +0200
Message-ID: <20240502125900.15177-2-herman@HIDDEN>
X-Mailer: git-send-email 2.41.0
In-Reply-To: <20240502125900.15177-1-herman@HIDDEN>
References: <20240502125900.15177-1-herman@HIDDEN>
MIME-Version: 1.0
Content-Transfer-Encoding: 8bit
X-Spam-Score: 3.6 (+++)
X-Spam-Report: Spam detection software, running on the system "debbugs.gnu.org",
has NOT identified this incoming email as spam. The original
message has been attached to this so you can view it or label
similar future email. If you have any questions, see
the administrator of that system for details.
Content preview: * guix/import/crate.scm (make-crate-sexp): Use
beautify-synopsis.
Change-Id: I4e30e043d34da7a3c355e098f155c0c75b619063 --- guix/import/crate.scm
| 2 +- 1 file changed, 1 insertion(+),
1 deletion(-) diff --git a/guix/import/crate.scm
b/guix/import/crate.scm index 81e442141b..2f74333fa9 100644 ---
a/guix/import/crate.scm
+++ b/guix/import/crate.scm @@ -211, 7 +211, 7 @@ (define (format-inputs inputs
[...] Content analysis details: (3.6 points, 10.0 required)
pts rule name description
---- ---------------------- --------------------------------------------------
3.6 RCVD_IN_PBL RBL: Received via a relay in Spamhaus PBL
[81.205.150.117 listed in zen.spamhaus.org]
0.0 TVD_RCVD_IP Message was received from an IP address
-0.0 SPF_PASS SPF: sender matches SPF record
0.0 SPF_HELO_NONE SPF: HELO does not publish an SPF Record
X-BeenThere: debbugs-submit <at> debbugs.gnu.org
X-Mailman-Version: 2.1.18
Precedence: list
List-Id: <debbugs-submit.debbugs.gnu.org>
List-Unsubscribe: <https://debbugs.gnu.org/cgi-bin/mailman/options/debbugs-submit>,
<mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=unsubscribe>
List-Archive: <https://debbugs.gnu.org/cgi-bin/mailman/private/debbugs-submit/>
List-Post: <mailto:debbugs-submit <at> debbugs.gnu.org>
List-Help: <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=help>
List-Subscribe: <https://debbugs.gnu.org/cgi-bin/mailman/listinfo/debbugs-submit>,
<mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=subscribe>
Errors-To: debbugs-submit-bounces <at> debbugs.gnu.org
Sender: "Debbugs-submit" <debbugs-submit-bounces <at> debbugs.gnu.org>
X-Spam-Score: 2.6 (++)
X-Spam-Report: Spam detection software, running on the system "debbugs.gnu.org",
has NOT identified this incoming email as spam. The original
message has been attached to this so you can view it or label
similar future email. If you have any questions, see
the administrator of that system for details.
Content preview: * guix/import/crate.scm (make-crate-sexp): Use beautify-synopsis.
Change-Id: I4e30e043d34da7a3c355e098f155c0c75b619063 --- guix/import/crate.scm
| 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/guix/import/crate.scm
b/guix/import/crate.scm index 81e442141b..2f74333fa9 100644 --- a/guix/import/crate.scm
+++ b/guix/import/crate.scm @@ -211,7 +211,7 @@ (define (format-inputs inputs
[...]
Content analysis details: (2.6 points, 10.0 required)
pts rule name description
---- ---------------------- --------------------------------------------------
3.6 RCVD_IN_PBL RBL: Received via a relay in Spamhaus PBL
[81.205.150.117 listed in zen.spamhaus.org]
-0.0 SPF_PASS SPF: sender matches SPF record
0.0 SPF_HELO_NONE SPF: HELO does not publish an SPF Record
-1.0 MAILING_LIST_MULTI Multiple indicators imply a widely-seen list
manager
* guix/import/crate.scm (make-crate-sexp): Use beautify-synopsis.
Change-Id: I4e30e043d34da7a3c355e098f155c0c75b619063
---
guix/import/crate.scm | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/guix/import/crate.scm b/guix/import/crate.scm
index 81e442141b..2f74333fa9 100644
--- a/guix/import/crate.scm
+++ b/guix/import/crate.scm
@@ -211,7 +211,7 @@ (define (format-inputs inputs)
cargo-development-inputs)
(maybe-cargo-inputs cargo-inputs)))
(home-page ,home-page)
- (synopsis ,synopsis)
+ (synopsis ,(beautify-synopsis synopsis))
(description ,(beautify-description description))
(license ,(match license
(() #f)
--
2.41.0
X-Loop: help-debbugs@HIDDEN
Subject: [bug#70715] [PATCH 3/4] guix: Include a main verb in crate importer descriptions.
Resent-From: Herman Rimm <herman@HIDDEN>
Original-Sender: "Debbugs-submit" <debbugs-submit-bounces <at> debbugs.gnu.org>
Resent-CC: guix-patches@HIDDEN
Resent-Date: Thu, 02 May 2024 13:00:03 +0000
Resent-Message-ID: <handler.70715.B70715.171465478221857 <at> debbugs.gnu.org>
Resent-Sender: help-debbugs@HIDDEN
X-GNU-PR-Message: followup 70715
X-GNU-PR-Package: guix-patches
X-GNU-PR-Keywords: patch
To: 70715 <at> debbugs.gnu.org
Received: via spool by 70715-submit <at> debbugs.gnu.org id=B70715.171465478221857
(code B ref 70715); Thu, 02 May 2024 13:00:03 +0000
Received: (at 70715) by debbugs.gnu.org; 2 May 2024 12:59:42 +0000
Received: from localhost ([127.0.0.1]:43637 helo=debbugs.gnu.org)
by debbugs.gnu.org with esmtp (Exim 4.84_2)
(envelope-from <debbugs-submit-bounces <at> debbugs.gnu.org>)
id 1s2W2I-0005gS-4j
for submit <at> debbugs.gnu.org; Thu, 02 May 2024 08:59:42 -0400
Received: from 81-205-150-117.fixed.kpn.net ([81.205.150.117]:53769
helo=email.rimm.ee) by debbugs.gnu.org with esmtp (Exim 4.84_2)
(envelope-from <herman@HIDDEN>) id 1s2W2F-0005fj-59
for 70715 <at> debbugs.gnu.org; Thu, 02 May 2024 08:59:39 -0400
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=rimm.ee; s=herman;
t=1714654749;
h=from:from:reply-to:subject:subject:date:date:message-id:message-id:
to:to:cc:mime-version:mime-version:
content-transfer-encoding:content-transfer-encoding:
in-reply-to:in-reply-to:references:references;
bh=fByKIBXthAvsfmMnnC31qnD8RjAj8a92j01AGIDNn4c=;
b=dwhTSsLzyc0EsoRLJd+qCermNcz26Q0gj99KnBjyp6X3OnGPYfBbrgHQNo+vNrp9g9Zo56
fp14/ALxb6OIxWvj/V9gkKRZWiMWHSaKkIPn8+Mx4krwml0x6v6ZL8PaBIIWgs1CPd74FX
Zf63MnDGhFBV5YYxTg6GLVvAfshk1ZAlAEBDqwPpKkEYN0xo+1avRL/OYAh//im+QU3n/s
5YDjKOz8GZSHIwDVDq9AigMsxochyt+Cc+8Vu0RE9+o6hzGY/48SBct3bDE6W+BJpK2vrJ
0stIjakRxCBMt5Edbb4ALE8nmp33tnGs6gZMtlLvWA04rE7+1yA4ZCyUMqGCSQ==
Received: by 81-205-150-117.fixed.kpn.net (OpenSMTPD) with ESMTPSA id 331010a5
(TLSv1.3:TLS_CHACHA20_POLY1305_SHA256:256:NO)
for <70715 <at> debbugs.gnu.org>; Thu, 2 May 2024 12:59:09 +0000 (UTC)
From: Herman Rimm <herman@HIDDEN>
Date: Thu, 2 May 2024 14:58:59 +0200
Message-ID: <20240502125900.15177-3-herman@HIDDEN>
X-Mailer: git-send-email 2.41.0
In-Reply-To: <20240502125900.15177-1-herman@HIDDEN>
References: <20240502125900.15177-1-herman@HIDDEN>
MIME-Version: 1.0
Content-Transfer-Encoding: 8bit
X-Spam-Score: 3.6 (+++)
X-Spam-Report: Spam detection software, running on the system "debbugs.gnu.org",
has NOT identified this incoming email as spam. The original
message has been attached to this so you can view it or label
similar future email. If you have any questions, see
the administrator of that system for details.
Content preview: * guix/import/crate.scm (make-crate-sexp): Start description
with 'This package provides '. Change-Id:
Id627759fb23da14fa7cb84e5dffb3bfc41950eab
--- guix/import/crate.scm | 6 +++++- 1 file changed, 5 insertions(+),
1 deletion(-)
Content analysis details: (3.6 points, 10.0 required)
pts rule name description
---- ---------------------- --------------------------------------------------
3.6 RCVD_IN_PBL RBL: Received via a relay in Spamhaus PBL
[81.205.150.117 listed in zen.spamhaus.org]
0.0 TVD_RCVD_IP Message was received from an IP address
-0.0 SPF_PASS SPF: sender matches SPF record
0.0 SPF_HELO_NONE SPF: HELO does not publish an SPF Record
0.0 T_FILL_THIS_FORM_SHORT Fill in a short form with personal
information
X-BeenThere: debbugs-submit <at> debbugs.gnu.org
X-Mailman-Version: 2.1.18
Precedence: list
List-Id: <debbugs-submit.debbugs.gnu.org>
List-Unsubscribe: <https://debbugs.gnu.org/cgi-bin/mailman/options/debbugs-submit>,
<mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=unsubscribe>
List-Archive: <https://debbugs.gnu.org/cgi-bin/mailman/private/debbugs-submit/>
List-Post: <mailto:debbugs-submit <at> debbugs.gnu.org>
List-Help: <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=help>
List-Subscribe: <https://debbugs.gnu.org/cgi-bin/mailman/listinfo/debbugs-submit>,
<mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=subscribe>
Errors-To: debbugs-submit-bounces <at> debbugs.gnu.org
Sender: "Debbugs-submit" <debbugs-submit-bounces <at> debbugs.gnu.org>
X-Spam-Score: 2.6 (++)
X-Spam-Report: Spam detection software, running on the system "debbugs.gnu.org",
has NOT identified this incoming email as spam. The original
message has been attached to this so you can view it or label
similar future email. If you have any questions, see
the administrator of that system for details.
Content preview: * guix/import/crate.scm (make-crate-sexp): Start description
with 'This package provides '. Change-Id: Id627759fb23da14fa7cb84e5dffb3bfc41950eab
--- guix/import/crate.scm | 6 +++++- 1 file changed, 5 insertions(+), 1 deletion(-)
Content analysis details: (2.6 points, 10.0 required)
pts rule name description
---- ---------------------- --------------------------------------------------
3.6 RCVD_IN_PBL RBL: Received via a relay in Spamhaus PBL
[81.205.150.117 listed in zen.spamhaus.org]
-0.0 SPF_PASS SPF: sender matches SPF record
0.0 SPF_HELO_NONE SPF: HELO does not publish an SPF Record
-1.0 MAILING_LIST_MULTI Multiple indicators imply a widely-seen list
manager
* guix/import/crate.scm (make-crate-sexp): Start description with
'This package provides '.
Change-Id: Id627759fb23da14fa7cb84e5dffb3bfc41950eab
---
guix/import/crate.scm | 6 +++++-
1 file changed, 5 insertions(+), 1 deletion(-)
diff --git a/guix/import/crate.scm b/guix/import/crate.scm
index 2f74333fa9..e739faa503 100644
--- a/guix/import/crate.scm
+++ b/guix/import/crate.scm
@@ -187,6 +187,7 @@ (define (format-inputs inputs)
(guix-name (crate-name->package-name name))
(cargo-inputs (format-inputs cargo-inputs))
(cargo-development-inputs (format-inputs cargo-development-inputs))
+ (description (beautify-description description))
(pkg `(package
(name ,guix-name)
(version ,version)
@@ -212,7 +213,10 @@ (define (format-inputs inputs)
(maybe-cargo-inputs cargo-inputs)))
(home-page ,home-page)
(synopsis ,(beautify-synopsis synopsis))
- (description ,(beautify-description description))
+ (description ,(if (string-prefix? "This" description)
+ description
+ (string-append "This package provides "
+ description)))
(license ,(match license
(() #f)
(#f #f)
--
2.41.0
X-Loop: help-debbugs@HIDDEN
Subject: [bug#70715] [PATCH 4/4] guix: End package descriptions with period.
Resent-From: Herman Rimm <herman@HIDDEN>
Original-Sender: "Debbugs-submit" <debbugs-submit-bounces <at> debbugs.gnu.org>
Resent-CC: guix-patches@HIDDEN
Resent-Date: Thu, 02 May 2024 13:00:03 +0000
Resent-Message-ID: <handler.70715.B70715.171465478221863 <at> debbugs.gnu.org>
Resent-Sender: help-debbugs@HIDDEN
X-GNU-PR-Message: followup 70715
X-GNU-PR-Package: guix-patches
X-GNU-PR-Keywords: patch
To: 70715 <at> debbugs.gnu.org
Received: via spool by 70715-submit <at> debbugs.gnu.org id=B70715.171465478221863
(code B ref 70715); Thu, 02 May 2024 13:00:03 +0000
Received: (at 70715) by debbugs.gnu.org; 2 May 2024 12:59:42 +0000
Received: from localhost ([127.0.0.1]:43639 helo=debbugs.gnu.org)
by debbugs.gnu.org with esmtp (Exim 4.84_2)
(envelope-from <debbugs-submit-bounces <at> debbugs.gnu.org>)
id 1s2W2I-0005gU-Ey
for submit <at> debbugs.gnu.org; Thu, 02 May 2024 08:59:42 -0400
Received: from 81-205-150-117.fixed.kpn.net ([81.205.150.117]:53769
helo=email.rimm.ee) by debbugs.gnu.org with esmtp (Exim 4.84_2)
(envelope-from <herman@HIDDEN>) id 1s2W2F-0005fj-Vk
for 70715 <at> debbugs.gnu.org; Thu, 02 May 2024 08:59:40 -0400
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=rimm.ee; s=herman;
t=1714654749;
h=from:from:reply-to:subject:subject:date:date:message-id:message-id:
to:to:cc:mime-version:mime-version:
content-transfer-encoding:content-transfer-encoding:
in-reply-to:in-reply-to:references:references;
bh=tBpnVgqP1ug8BId/7VqzrO7z19d3qaQF1qCPyATmd60=;
b=eApCf5w7rj6r13q6y28nyjwUqgq6gmRAQRLNn1GmwjNZKwb0e7GqGdWg0N6eJsALYbWhfY
2UCGae5/WqxGmqkzyfQDVfBW34ZsFXZJwY9DtfPV5JV5Q4gOSnx4X8UB4LqIvaIT9h6rfW
i4NwvQCZ1vcySSs3JKlOMZ1VGmKJqzpDPl3XGlcuxnesO/G9uoV34Rmro98NJzvoS0/Jhl
X1N2p4OJQ7zgzKOrqobi0cyz8PAcJ/eY4mVKh18bHIuhGF4KWvyRPuvKFTYNItgmcmcFct
1RkpFW50Lp6Kw3pBYi4fvdgeWN46X3TwHQV7s/IyvARamcXNa2M9KPE2R2iJ2w==
Received: by 81-205-150-117.fixed.kpn.net (OpenSMTPD) with ESMTPSA id f9631cf8
(TLSv1.3:TLS_CHACHA20_POLY1305_SHA256:256:NO)
for <70715 <at> debbugs.gnu.org>; Thu, 2 May 2024 12:59:09 +0000 (UTC)
From: Herman Rimm <herman@HIDDEN>
Date: Thu, 2 May 2024 14:59:00 +0200
Message-ID: <20240502125900.15177-4-herman@HIDDEN>
X-Mailer: git-send-email 2.41.0
In-Reply-To: <20240502125900.15177-1-herman@HIDDEN>
References: <20240502125900.15177-1-herman@HIDDEN>
MIME-Version: 1.0
Content-Transfer-Encoding: 8bit
X-Spam-Score: 3.6 (+++)
X-Spam-Report: Spam detection software, running on the system "debbugs.gnu.org",
has NOT identified this incoming email as spam. The original
message has been attached to this so you can view it or label
similar future email. If you have any questions, see
the administrator of that system for details.
Content preview: * guix/import/utils.scm (beautify-description): Append period
to last words which do not end with one. Change-Id:
Ia901dccadee6b4fef6c7f0176ce5871409ff6ce6
--- guix/import/utils.scm | 7 +++++++ 1 file changed, 7 insertions(+)
Content analysis details: (3.6 points, 10.0 required)
pts rule name description
---- ---------------------- --------------------------------------------------
3.6 RCVD_IN_PBL RBL: Received via a relay in Spamhaus PBL
[81.205.150.117 listed in zen.spamhaus.org]
0.0 TVD_RCVD_IP Message was received from an IP address
-0.0 SPF_PASS SPF: sender matches SPF record
0.0 SPF_HELO_NONE SPF: HELO does not publish an SPF Record
X-BeenThere: debbugs-submit <at> debbugs.gnu.org
X-Mailman-Version: 2.1.18
Precedence: list
List-Id: <debbugs-submit.debbugs.gnu.org>
List-Unsubscribe: <https://debbugs.gnu.org/cgi-bin/mailman/options/debbugs-submit>,
<mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=unsubscribe>
List-Archive: <https://debbugs.gnu.org/cgi-bin/mailman/private/debbugs-submit/>
List-Post: <mailto:debbugs-submit <at> debbugs.gnu.org>
List-Help: <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=help>
List-Subscribe: <https://debbugs.gnu.org/cgi-bin/mailman/listinfo/debbugs-submit>,
<mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=subscribe>
Errors-To: debbugs-submit-bounces <at> debbugs.gnu.org
Sender: "Debbugs-submit" <debbugs-submit-bounces <at> debbugs.gnu.org>
X-Spam-Score: 2.6 (++)
X-Spam-Report: Spam detection software, running on the system "debbugs.gnu.org",
has NOT identified this incoming email as spam. The original
message has been attached to this so you can view it or label
similar future email. If you have any questions, see
the administrator of that system for details.
Content preview: * guix/import/utils.scm (beautify-description): Append period
to last words which do not end with one. Change-Id: Ia901dccadee6b4fef6c7f0176ce5871409ff6ce6
--- guix/import/utils.scm | 7 +++++++ 1 file changed, 7 insertions(+)
Content analysis details: (2.6 points, 10.0 required)
pts rule name description
---- ---------------------- --------------------------------------------------
3.6 RCVD_IN_PBL RBL: Received via a relay in Spamhaus PBL
[81.205.150.117 listed in zen.spamhaus.org]
-0.0 SPF_PASS SPF: sender matches SPF record
0.0 SPF_HELO_NONE SPF: HELO does not publish an SPF Record
-1.0 MAILING_LIST_MULTI Multiple indicators imply a widely-seen list
manager
* guix/import/utils.scm (beautify-description): Append period to last
words which do not end with one.
Change-Id: Ia901dccadee6b4fef6c7f0176ce5871409ff6ce6
---
guix/import/utils.scm | 7 +++++++
1 file changed, 7 insertions(+)
diff --git a/guix/import/utils.scm b/guix/import/utils.scm
index 09a01cf315..e06f06e196 100644
--- a/guix/import/utils.scm
+++ b/guix/import/utils.scm
@@ -370,6 +370,13 @@ (define* (beautify-description description #:optional (length 80))
(cons* "This" "package"
(string-downcase first) rest))
(_ words)))
+ (new-words
+ (match new-words
+ ((rest ... last)
+ (reverse (cons (if (string-suffix? "." last)
+ last
+ (string-append last "."))
+ (reverse rest))))))
(cleaned
(string-join (map fix-word new-words))))
;; Use double spacing between sentences
--
2.41.0
GNU bug tracking system
Copyright (C) 1999 Darren O. Benham,
1997 nCipher Corporation Ltd,
1994-97 Ian Jackson.