GNU bug report logs - #70786
[PATCH] Quietly skip 'lua-ts-mode' tests

Previous Next

To add a comment to this bug, you must first unarchive it, by sending
a message to control AT debbugs.gnu.org, with unarchive 70786 in the body.
You can then email your comments to 70786 AT debbugs.gnu.org in the normal way.

Toggle the display of automated, internal messages from the tracker.

Message #5 received at submit <at> debbugs.gnu.org (full text, mbox):

From: john muhl <jm <at> pub.pink>
To: bug-gnu-emacs <at> gnu.org
Subject: [PATCH] Quietly skip 'lua-ts-mode' tests
Date: Sun, 05 May 2024 08:34:23 -0500

Tags: patch

Change the test to be silent when they’re skipped due to the
grammar being unavailable.


In GNU Emacs 30.0.50 (build 1, x86_64-pc-linux-gnu, GTK+ Version
 3.24.41, cairo version 1.18.0) of 2024-05-02 built on localhost
Repository revision: 962bb71b4a813eb9c3832494746695d32d6f9109
Repository branch: master
System Description: Fedora Linux 39 (Thirty Nine)

Configured using:
 'configure --with-pgtk --prefix=/home/jm/.local'

Message #8 received at 70786 <at> debbugs.gnu.org (full text, mbox):

From: john muhl <jm <at> pub.pink>
To: 70786 <at> debbugs.gnu.org
Subject: Re: bug#70786: [PATCH] Quietly skip 'lua-ts-mode' tests
Date: Sun, 05 May 2024 08:37:25 -0500

[0001-Quietly-skip-lua-ts-mode-tests-bug-70786.patch (text/x-patch, attachment)]

From 96f1af589a7cef3fba3ff05a67af6659a58f9be1 Mon Sep 17 00:00:00 2001
From: john muhl <jm <at> pub.pink>
Date: Sat, 27 Apr 2024 18:52:41 -0500
Subject: [PATCH] Quietly skip 'lua-ts-mode' tests (bug#70786)

* test/lisp/align-tests.el (align-lua):
* test/lisp/progmodes/lua-ts-mode-tests.el
(lua-ts-test-indentation):
(lua-ts-test-movement):
(lua-ts-test-font-lock):
(lua-ts-test-which-function): Suppress warnings when the grammar is not
installed.
---
 test/lisp/align-tests.el                 | 2 +-
 test/lisp/progmodes/lua-ts-mode-tests.el | 8 ++++----
 2 files changed, 5 insertions(+), 5 deletions(-)

diff --git a/test/lisp/align-tests.el b/test/lisp/align-tests.el
index cd309ea07bf..eaebaf8360c 100644
--- a/test/lisp/align-tests.el
+++ b/test/lisp/align-tests.el
@@ -52,7 +52,7 @@ align-latex
 (autoload 'treesit-ready-p "treesit")
 
 (ert-deftest align-lua ()
-  (skip-unless (treesit-ready-p 'lua))
+  (skip-unless (treesit-ready-p 'lua t))
   (let ((comment-column 20)
         (indent-tabs-mode nil))
     (ert-test-erts-file (ert-resource-file "lua-ts-mode.erts")
diff --git a/test/lisp/progmodes/lua-ts-mode-tests.el b/test/lisp/progmodes/lua-ts-mode-tests.el
index a7b637d18d1..68b8c9ccfaa 100644
--- a/test/lisp/progmodes/lua-ts-mode-tests.el
+++ b/test/lisp/progmodes/lua-ts-mode-tests.el
@@ -26,20 +26,20 @@
 (require 'which-func)
 
 (ert-deftest lua-ts-test-indentation ()
-  (skip-unless (treesit-ready-p 'lua))
+  (skip-unless (treesit-ready-p 'lua t))
   (ert-test-erts-file (ert-resource-file "indent.erts")))
 
 (ert-deftest lua-ts-test-movement ()
-  (skip-unless (treesit-ready-p 'lua))
+  (skip-unless (treesit-ready-p 'lua t))
   (ert-test-erts-file (ert-resource-file "movement.erts")))
 
 (ert-deftest lua-ts-test-font-lock ()
-  (skip-unless (treesit-ready-p 'lua))
+  (skip-unless (treesit-ready-p 'lua t))
   (let ((treesit-font-lock-level 4))
     (ert-font-lock-test-file (ert-resource-file "font-lock.lua") 'lua-ts-mode)))
 
 (ert-deftest lua-ts-test-which-function ()
-  (skip-unless (treesit-ready-p 'lua))
+  (skip-unless (treesit-ready-p 'lua t))
   (with-temp-buffer
     (insert-file-contents (ert-resource-file "which-function.lua"))
     (lua-ts-mode)
-- 
2.41.0

Message #11 received at 70786 <at> debbugs.gnu.org (full text, mbox):

From: john muhl <jm <at> pub.pink>
To: 70786 <at> debbugs.gnu.org
Subject: Re: bug#70786: [PATCH] Quietly skip 'lua-ts-mode' tests
Date: Sun, 05 May 2024 08:46:11 -0500

[Message part 1 (text/plain, inline)]

Forgot a semicolon.

[0001-Quietly-skip-lua-ts-mode-tests-bug-70786.patch (text/x-patch, attachment)]

[Message part 3 (text/plain, inline)]

john muhl <jm <at> pub.pink> writes:

> [1. text/x-patch; 0001-Quietly-skip-lua-ts-mode-tests-bug-70786.patch]...

Message #14 received at 70786 <at> debbugs.gnu.org (full text, mbox):

From: Yuan Fu <casouri <at> gmail.com>
To: john muhl <jm <at> pub.pink>
Cc: 70786 <at> debbugs.gnu.org
Subject: Re: bug#70786: [PATCH] Quietly skip 'lua-ts-mode' tests
Date: Wed, 8 May 2024 20:38:12 -0700

> On May 5, 2024, at 6:46 AM, john muhl <jm <at> pub.pink> wrote:
> 
> Forgot a semicolon.

Merged, thanks!

Yuan

Previous Next

GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson.