GNU bug report logs - #70843
[PATCH] guix-install.sh: Relax check for OpenRC.

Previous Next

Package: guix-patches;

Reported by: Tomas Volf <~@wolfsden.cz>

Date: Thu, 9 May 2024 10:16:02 UTC

Severity: normal

Tags: patch

Done: Ludovic Courtès <ludo <at> gnu.org>

To reply to this bug, email your comments to 70843 AT debbugs.gnu.org.
There is no need to reopen the bug first.

Toggle the display of automated, internal messages from the tracker.

View this report as an mbox folder, status mbox, maintainer mbox


Report forwarded to guix-patches <at> gnu.org:
bug#70843; Package guix-patches. (Thu, 09 May 2024 10:16:02 GMT) Full text and rfc822 format available.

Acknowledgement sent to Tomas Volf <~@wolfsden.cz>:
New bug report received and forwarded. Copy sent to guix-patches <at> gnu.org. (Thu, 09 May 2024 10:16:02 GMT) Full text and rfc822 format available.

Message #5 received at submit <at> debbugs.gnu.org (full text, mbox):

From: Tomas Volf <~@wolfsden.cz>
To: guix-patches <at> gnu.org
Cc: Tomas Volf <~@wolfsden.cz>
Subject: [PATCH] guix-install.sh: Relax check for OpenRC.
Date: Thu,  9 May 2024 12:14:19 +0200
On my virtual private servers running Alpine, the install script failed to
identify the init system.  The virtual server is LXC based, and OpenRC
identifies itself like this:

    # openrc --version
    openrc (OpenRC [LXC]) 0.52.1

The regular expression failed to match it.  After relaxing the check (by
removing the trailing `)' requirement) the installation went fine and I got
functional Guix installation.

* etc/guix-install.sh (chk_init_sys): Drop trailing \) from the regular
expression.

Change-Id: I5f951226341e631fb34cc6c26cfbb87656dab77a
---
 etc/guix-install.sh | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/etc/guix-install.sh b/etc/guix-install.sh
index 82accfd5d5..c5a04bb1f4 100755
--- a/etc/guix-install.sh
+++ b/etc/guix-install.sh
@@ -217,7 +217,7 @@ chk_init_sys()
         _msg "${INF}init system is: sysv-init"
         INIT_SYS="sysv-init"
         return 0
-    elif [[ $(openrc --version 2>/dev/null) =~ \(OpenRC\) ]]; then
+    elif [[ $(openrc --version 2>/dev/null) =~ \(OpenRC ]]; then
         _msg "${INF}init system is: OpenRC"
         INIT_SYS="openrc"
         return 0
-- 
2.41.0





Reply sent to Ludovic Courtès <ludo <at> gnu.org>:
You have taken responsibility. (Sun, 02 Jun 2024 09:42:03 GMT) Full text and rfc822 format available.

Notification sent to Tomas Volf <~@wolfsden.cz>:
bug acknowledged by developer. (Sun, 02 Jun 2024 09:42:03 GMT) Full text and rfc822 format available.

Message #10 received at 70843-done <at> debbugs.gnu.org (full text, mbox):

From: Ludovic Courtès <ludo <at> gnu.org>
To: Tomas Volf <~@wolfsden.cz>
Cc: 70843-done <at> debbugs.gnu.org
Subject: Re: [bug#70843] [PATCH] guix-install.sh: Relax check for OpenRC.
Date: Sun, 02 Jun 2024 11:41:02 +0200
Tomas Volf <~@wolfsden.cz> skribis:

> On my virtual private servers running Alpine, the install script failed to
> identify the init system.  The virtual server is LXC based, and OpenRC
> identifies itself like this:
>
>     # openrc --version
>     openrc (OpenRC [LXC]) 0.52.1
>
> The regular expression failed to match it.  After relaxing the check (by
> removing the trailing `)' requirement) the installation went fine and I got
> functional Guix installation.
>
> * etc/guix-install.sh (chk_init_sys): Drop trailing \) from the regular
> expression.
>
> Change-Id: I5f951226341e631fb34cc6c26cfbb87656dab77a

Applied, thanks!




This bug report was last modified 15 days ago.

Previous Next


GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson.