Received: (at 70871) by debbugs.gnu.org; 11 May 2024 16:53:40 +0000 From debbugs-submit-bounces <at> debbugs.gnu.org Sat May 11 12:53:40 2024 Received: from localhost ([127.0.0.1]:49257 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from <debbugs-submit-bounces <at> debbugs.gnu.org>) id 1s5pyd-0000nJ-KQ for submit <at> debbugs.gnu.org; Sat, 11 May 2024 12:53:40 -0400 Received: from mugam.systemreboot.net ([139.59.75.54]:43662) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from <arunisaac@HIDDEN>) id 1s5pya-0000n1-1J for 70871 <at> debbugs.gnu.org; Sat, 11 May 2024 12:53:38 -0400 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=systemreboot.net; s=default; h=Content-Type:MIME-Version:Message-ID:Date: References:In-Reply-To:Subject:Cc:To:From:Sender:Reply-To: Content-Transfer-Encoding:Content-ID:Content-Description:Resent-Date: Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Id: List-Help:List-Unsubscribe:List-Subscribe:List-Post:List-Owner:List-Archive; bh=JNztq7KXEiH9LX+fzRKblPDFYEdvBQ2N7bWz1cZgHAM=; b=QzAY2NQgQolMUrqH44QNuDQxt5 2Lua3zU5+jv8oA1ClXGcO2FZeC6y6HO/Z+gpM71Xiw7uq/verp3GKk7EMepO3Oy8yrU5eQPvoKOTZ D0fYfFmlmp5kS4lLnVcnUcZlUmKYFdwPVVqbjs7NMUsWy79GhSyh8LtiGDugfWyiOH3Qqq2nbWmWI pv3elJ4zr/pQ4/6n92hzqK9uER++ruO39TJjZupOFQAcCK+9NaUD0+sIM07wSAtMFJWfF3H3evYsp YkBq3gvFvYTQ8QYJpeODhXoElzx44B2RwwcimNLqfM4DSxRf1eR17Pgmw06D60FhHBttthQArNXH6 I/wYXcwg==; Received: from [192.168.2.1] (port=33640 helo=localhost) by systemreboot.net with esmtpsa (TLS1.3) tls TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384 (Exim 4.96.1) (envelope-from <arunisaac@HIDDEN>) id 1s5pvs-0000qX-1e; Sat, 11 May 2024 17:50:49 +0100 From: Arun Isaac <arunisaac@HIDDEN> To: Felix Lechner <felix.lechner@HIDDEN> Subject: Re: bug#70871: [PATCH] Show avatars from Libravatar. In-Reply-To: <20240511032008.16270-1-felix.lechner@HIDDEN> References: <20240511032008.16270-1-felix.lechner@HIDDEN> Date: Sat, 11 May 2024 17:53:25 +0100 Message-ID: <87plts5lyy.fsf@HIDDEN> MIME-Version: 1.0 Content-Type: text/plain X-Spam-Score: 0.0 (/) X-Debbugs-Envelope-To: 70871 Cc: 70871 <at> debbugs.gnu.org X-BeenThere: debbugs-submit <at> debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: <debbugs-submit.debbugs.gnu.org> List-Unsubscribe: <https://debbugs.gnu.org/cgi-bin/mailman/options/debbugs-submit>, <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=unsubscribe> List-Archive: <https://debbugs.gnu.org/cgi-bin/mailman/private/debbugs-submit/> List-Post: <mailto:debbugs-submit <at> debbugs.gnu.org> List-Help: <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=help> List-Subscribe: <https://debbugs.gnu.org/cgi-bin/mailman/listinfo/debbugs-submit>, <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=subscribe> Errors-To: debbugs-submit-bounces <at> debbugs.gnu.org Sender: "Debbugs-submit" <debbugs-submit-bounces <at> debbugs.gnu.org> X-Spam-Score: -1.0 (-) Hi Felix, Libravatar for mumi is a cool idea. I am happy to merge this patch with the suggested changes. There seems to be one more place (a total of three places) in mumi/web/view/html.scm where there is an avatar. Search for "string-upcase" in the code. Could you change that to Libravatar as well? And, while you are at it, would you mind deduplicating these three avatars into a single function or similar? Also, we now need to check for guile-avatar in configure.ac. BTW, what is patchwise.org? Did I miss some conversation about it? I was under the impression that we should be sending to bug-mumi@HIDDEN Thank you for the clarification! Regards, Arun
bug-mumi@HIDDEN:bug#70871; Package mumi.
Full text available.Felix Lechner <felix.lechner@HIDDEN>
to control <at> debbugs.gnu.org.
Full text available.
Received: (at submit) by debbugs.gnu.org; 11 May 2024 03:20:37 +0000
From debbugs-submit-bounces <at> debbugs.gnu.org Fri May 10 23:20:37 2024
Received: from localhost ([127.0.0.1]:45726 helo=debbugs.gnu.org)
by debbugs.gnu.org with esmtp (Exim 4.84_2)
(envelope-from <debbugs-submit-bounces <at> debbugs.gnu.org>)
id 1s5dHp-0006EX-6t
for submit <at> debbugs.gnu.org; Fri, 10 May 2024 23:20:37 -0400
Received: from lists.gnu.org ([209.51.188.17]:37430)
by debbugs.gnu.org with esmtp (Exim 4.84_2)
(envelope-from <felix.lechner@HIDDEN>) id 1s5dHm-0006ER-R4
for submit <at> debbugs.gnu.org; Fri, 10 May 2024 23:20:36 -0400
Received: from eggs.gnu.org ([2001:470:142:3::10])
by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256)
(Exim 4.90_1) (envelope-from <felix.lechner@HIDDEN>)
id 1s5dHg-0007RZ-ID
for bug-mumi@HIDDEN; Fri, 10 May 2024 23:20:33 -0400
Received: from sail-ipv4.us-core.com ([208.82.101.137])
by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_CHACHA20_POLY1305:256)
(Exim 4.90_1) (envelope-from <felix.lechner@HIDDEN>)
id 1s5dHd-0006JP-Vq
for bug-mumi@HIDDEN; Fri, 10 May 2024 23:20:28 -0400
DKIM-Signature: v=1; a=rsa-sha256; c=simple/simple; s=2017; bh=X9LxgqXX3dNbzIq
SeLeQRjv7Y+f9VFcSJBMEvHYV45w=; h=date:subject:cc:to:from;
d=lease-up.com; b=CF0nU/sgnfqevCMwh2kKXpmhY5JB8k9F05W+COrkBXntB/vgx9pp
qauuDLgqjhPxUv/2sMShkqf7EcArWm086JLdsxHMsiSFdxLil+2E5VjYLFNczkz26iXtdx
+AsO52IgTJb5t8c441D33SaTTnur4n9anlaVjLTvP4yAz91xQ=
Received: by localhost (OpenSMTPD) with ESMTPA id f2394414
for <bug-mumi@HIDDEN>; Sat, 11 May 2024 03:20:24 +0000 (UTC)
Delivered-To: bug-mumi@HIDDEN
DKIM-Signature: v=1; a=rsa-sha256; c=simple/simple; s=2017; bh=X9LxgqXX3dNbzIq
SeLeQRjv7Y+f9VFcSJBMEvHYV45w=; h=date:subject:cc:to:from;
d=lease-up.com; b=CF0nU/sgnfqevCMwh2kKXpmhY5JB8k9F05W+COrkBXntB/vgx9pp
qauuDLgqjhPxUv/2sMShkqf7EcArWm086JLdsxHMsiSFdxLil+2E5VjYLFNczkz26iXtdx
+AsO52IgTJb5t8c441D33SaTTnur4n9anlaVjLTvP4yAz91xQ=
Received: by sail-ipv4.us-core.com (OpenSMTPD) with ESMTPSA id 6c0c0bcf
(TLSv1.3:TLS_CHACHA20_POLY1305_SHA256:256:NO);
Sat, 11 May 2024 03:20:24 +0000 (UTC)
Received: from localhost (localhost [local])
by localhost (OpenSMTPD) with ESMTPA id bb2c4433;
Sat, 11 May 2024 03:20:23 +0000 (UTC)
From: Felix Lechner <felix.lechner@HIDDEN>
To: bug-mumi@HIDDEN
Subject: [PATCH] Show avatars from Libravatar.
Date: Fri, 10 May 2024 20:20:08 -0700
Message-ID: <20240511032008.16270-1-felix.lechner@HIDDEN>
X-Mailer: git-send-email 2.41.0
MIME-Version: 1.0
Content-Transfer-Encoding: 8bit
Received-SPF: pass client-ip=208.82.101.137;
envelope-from=felix.lechner@HIDDEN; helo=sail-ipv4.us-core.com
X-Spam_score_int: -17
X-Spam_score: -1.8
X-Spam_bar: -
X-Spam_report: (-1.8 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1,
DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, HEADER_FROM_DIFFERENT_DOMAINS=0.249,
SPF_HELO_NONE=0.001, SPF_PASS=-0.001,
UNPARSEABLE_RELAY=0.001 autolearn=no autolearn_force=no
X-Spam_action: no action
X-Spam-Score: -1.1 (-)
X-Debbugs-Envelope-To: submit
Cc: Felix Lechner <felix.lechner@HIDDEN>
X-BeenThere: debbugs-submit <at> debbugs.gnu.org
X-Mailman-Version: 2.1.18
Precedence: list
List-Id: <debbugs-submit.debbugs.gnu.org>
List-Unsubscribe: <https://debbugs.gnu.org/cgi-bin/mailman/options/debbugs-submit>,
<mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=unsubscribe>
List-Archive: <https://debbugs.gnu.org/cgi-bin/mailman/private/debbugs-submit/>
List-Post: <mailto:debbugs-submit <at> debbugs.gnu.org>
List-Help: <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=help>
List-Subscribe: <https://debbugs.gnu.org/cgi-bin/mailman/listinfo/debbugs-submit>,
<mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=subscribe>
Errors-To: debbugs-submit-bounces <at> debbugs.gnu.org
Sender: "Debbugs-submit" <debbugs-submit-bounces <at> debbugs.gnu.org>
X-Spam-Score: -2.1 (--)
Requires guile-avatar from here:
https://codeberg.org/lechner/guile-avatar
The packaging code for guile-avatar can be added to Guix by accepting
this patch:
https://debbugs.gnu.org/70870
In Guix, the package should then be mentioned as an "input" to mumi,
together with an updated commit hash or version for mumi.
A live preview of this change is available at:
https://patchwise.org/38809
---
mumi/web/view/html.scm | 25 +++++++++++++------------
1 file changed, 13 insertions(+), 12 deletions(-)
diff --git a/mumi/web/view/html.scm b/mumi/web/view/html.scm
index 2275799..bd5caec 100644
--- a/mumi/web/view/html.scm
+++ b/mumi/web/view/html.scm
@@ -19,6 +19,7 @@
;;; <http://www.gnu.org/licenses/>.
(define-module (mumi web view html)
+ #:use-module (avatar url)
#:use-module (email email)
#:use-module (mumi config)
#:use-module (mumi debbugs)
@@ -451,12 +452,12 @@ failed to process associated messages.")
,(map (match-lambda
((message-number message)
`(li
- (div
- (@ (class "avatar")
- (style ,(string-append "background-color:"
- (avatar-color (sender-email message)
- (map extract-email parties)))))
- ,(string-upcase (string-take (sender-name message) 1)))
+ (img (@ (class "avatar")
+ (style ,(string-append "background-color:"
+ (avatar-color (sender-email message)
+ (map extract-email parties))))
+ (src ,(libravatar-url (sender-email message) #:default "404"))
+ (alt ,(string-upcase (string-take (sender-name message) 1)))))
(span (@ (class "date"))
(a (@ (href ,(string-append "#" (number->string
message-number))))
@@ -621,12 +622,12 @@ currently disabled."))
(id ,(number->string message-number))))
(a (@ (class "message-anchor")
(id ,(format #false "msgid-~a" (msgid-hash (message-id message))))))
- (div
- (@ (class "avatar")
- (style ,(string-append "background-color:"
- (avatar-color (sender-email message)
- (map extract-email parties)))))
- ,(string-upcase (string-take (sender-name message) 1)))
+ (img (@ (class "avatar")
+ (style ,(string-append "background-color:"
+ (avatar-color (sender-email message)
+ (map extract-email parties))))
+ (src ,(libravatar-url (sender-email message) #:default "404"))
+ (alt ,(string-upcase (string-take (sender-name message) 1)))))
(article
(@ (class "message"))
(header
base-commit: 394c90d4a176756b9f0f4a716a2646ab98d8f167
--
2.41.0
Felix Lechner <felix.lechner@HIDDEN>:help-debbugs@HIDDEN.
Full text available.help-debbugs@HIDDEN:bug#70871; Package debbugs.gnu.org.
Full text available.
GNU bug tracking system
Copyright (C) 1999 Darren O. Benham,
1997 nCipher Corporation Ltd,
1994-97 Ian Jackson.