GNU bug report logs - #70882
30.0.50; [PATCH] Print the real direction in the prompt for '(previous|next)-matching-history-element'

Previous Next

To reply to this bug, email your comments to 70882 AT debbugs.gnu.org.
There is no need to reopen the bug first.

Toggle the display of automated, internal messages from the tracker.

Message #5 received at submit <at> debbugs.gnu.org (full text, mbox):

From: Jim Porter <jporterbugs <at> gmail.com>
To: bug-gnu-emacs <at> gnu.org
Subject: 30.0.50; [PATCH] Print the real direction in the prompt for
 '(previous|next)-matching-history-element'
Date: Sat, 11 May 2024 11:53:18 -0700

[Message part 1 (text/plain, inline)]

To see the problem, start from "emacs -Q":

  M-x
  M-r      ;; Emacs prompts "Previous element matching regexp:"
  C-g

  M-- M-r  ;; Emacs prompts "Previous element matching regexp:" (?!)

In the last line, the prefix argument is negative, so the search will 
actually be for the *next* matching element. The attached patch fixes 
this so that the prompt message accounts for the prefix arg.

While I was here, I also made 'next-matching-history-element' use 
'format-prompt' like its 'previous-...' sibling.

[0001-Tell-direction-in-prompts-for-previous-next-matching.patch (text/plain, attachment)]

Message #8 received at 70882 <at> debbugs.gnu.org (full text, mbox):

From: Eli Zaretskii <eliz <at> gnu.org>
To: Jim Porter <jporterbugs <at> gmail.com>
Cc: 70882 <at> debbugs.gnu.org
Subject: Re: bug#70882: 30.0.50;
 [PATCH] Print the real direction in the prompt for
 '(previous|next)-matching-history-element'
Date: Sat, 18 May 2024 12:18:55 +0300

> Date: Sat, 11 May 2024 11:53:18 -0700
> From: Jim Porter <jporterbugs <at> gmail.com>
> 
> To see the problem, start from "emacs -Q":
> 
>    M-x
>    M-r      ;; Emacs prompts "Previous element matching regexp:"
>    C-g
> 
>    M-- M-r  ;; Emacs prompts "Previous element matching regexp:" (?!)
> 
> In the last line, the prefix argument is negative, so the search will 
> actually be for the *next* matching element. The attached patch fixes 
> this so that the prompt message accounts for the prefix arg.
> 
> While I was here, I also made 'next-matching-history-element' use 
> 'format-prompt' like its 'previous-...' sibling.

Thanks, LGTM.

Message #13 received at 70882-done <at> debbugs.gnu.org (full text, mbox):

From: Jim Porter <jporterbugs <at> gmail.com>
To: Eli Zaretskii <eliz <at> gnu.org>
Cc: 70882-done <at> debbugs.gnu.org
Subject: Re: bug#70882: 30.0.50; [PATCH] Print the real direction in the
 prompt for '(previous|next)-matching-history-element'
Date: Sun, 19 May 2024 18:35:27 -0700

On 5/18/2024 2:18 AM, Eli Zaretskii wrote:
> Thanks, LGTM.

Thanks for checking. Merged as 44d1687f1f6, and closing this bug.

Previous Next

GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson.