GNU bug report logs - #70960
Remove mozjs and icu4c versions

Previous Next

To add a comment to this bug, you must first unarchive it, by sending
a message to control AT debbugs.gnu.org, with unarchive 70960 in the body.
You can then email your comments to 70960 AT debbugs.gnu.org in the normal way.

Toggle the display of automated, internal messages from the tracker.

Message #5 received at submit <at> debbugs.gnu.org (full text, mbox):

From: Andreas Enge <andreas <at> enge.fr>
To: bug-guix <at> gnu.org
Subject: Remove mozjs and icu4c versions
Date: Wed, 15 May 2024 17:46:47 +0200

After a recent patch updating the icu4c <at> 68 dependency of 0ad to icu4c,
I have gone through icu4c and mozjs dependents.

It turns out that nothing depends on mozjs <at> 91. Can it be removed?
Then I think that icu4c <at> 69 can also be removed.

The only package depending on mozjs <at> 78 is 0ad. Maybe the dependency
can be upgraded? (Well, we should check this first, upgrading to
mozjs <at> 91 will prevent us from removing this...)

Andreas

Message #8 received at 70960 <at> debbugs.gnu.org (full text, mbox):

From: Andreas Enge <andreas <at> enge.fr>
To: 70960 <at> debbugs.gnu.org
Subject: Re: Remove mozjs and icu4c versions
Date: Wed, 15 May 2024 21:06:08 +0200

To partially answer my questions:

Am Wed, May 15, 2024 at 05:46:47PM +0200 schrieb Andreas Enge:
> The only package depending on mozjs <at> 78 is 0ad. Maybe the dependency
> can be upgraded?

0ad is on the latest release, and cannot be built with any other of the
mozjs versions we currently have. So I would suggest to remove mozjs-91
and icu4c-69.

Thoughts?

Andreas

Message #11 received at 70960 <at> debbugs.gnu.org (full text, mbox):

From: Andreas Enge <andreas <at> enge.fr>
To: 70960 <at> debbugs.gnu.org
Subject: Re: Remove mozjs and icu4c versions
Date: Wed, 15 May 2024 21:15:08 +0200

Well, icu4c-69 is needed by mozjs-78, so we cannot remove it.
But mozjs-91 should be good to remove. Let QA give us its opinion.

Andreas

Message #14 received at 70960 <at> debbugs.gnu.org (full text, mbox):

From: Andreas Enge <andreas <at> enge.fr>
To: 70960 <at> debbugs.gnu.org
Cc: Andreas Enge <andreas <at> enge.fr>
Subject: [PATCH] gnu: Remove mozjs-91.
Date: Wed, 15 May 2024 21:13:05 +0200

* gnu/packages/gnuzilla.scm (mozjs-91): Delete variable.

Change-Id: I121a480eb15d670461a70b7703a3a658d9db6732
---
 gnu/packages/gnuzilla.scm | 31 -------------------------------
 1 file changed, 31 deletions(-)

diff --git a/gnu/packages/gnuzilla.scm b/gnu/packages/gnuzilla.scm
index 814b610bba..6ec5ba272b 100644
--- a/gnu/packages/gnuzilla.scm
+++ b/gnu/packages/gnuzilla.scm
@@ -223,37 +223,6 @@ (define-public mozjs
 in C/C++.")
     (license license:mpl2.0))) ; and others for some files
 
-(define-public mozjs-91
-  (package
-    (inherit mozjs)
-    (version "91.13.0")
-    (source (origin
-              (method url-fetch)
-              (uri (string-append "https://ftp.mozilla.org/pub/firefox"
-                                  "/releases/" version "esr/source/firefox-"
-                                  version "esr.source.tar.xz"))
-              (sha256
-               (base32
-                "0qh7j960wdp5zcfqhkj8ki47spp9i9ms12xx0v0kxvmmw36jpgjk"))))
-    (arguments
-     (substitute-keyword-arguments (package-arguments mozjs)
-       ((#:phases phases)
-        #~(modify-phases #$phases
-            (add-before 'check 'disable-timezone-tests
-              (lambda _
-                (with-directory-excursion "../js/src/tests"
-                  ;; FIXME: Assertion failed: got "2021a", expected "2021a3"?
-                  (delete-file "non262/Intl/DateTimeFormat/timeZone_version.js")
-                  ;; XXX: Delete all tests that test time zone functionality,
-                  ;; because the test suite uses /etc/localtime to figure out
-                  ;; the offset from the hardware clock, which does not work
-                  ;; in the build container.  See <tests/non262/Date/shell.js>.
-                  (delete-file-recursively "non262/Date")
-                  (delete-file
-                   "non262/Intl/DateTimeFormat/tz-environment-variable.js"))))))))
-    (inputs (modify-inputs (package-inputs mozjs)
-              (replace "icu4c" icu4c-69)))))
-
 (define-public mozjs-78
   (package
     (inherit mozjs)

base-commit: bc6742e168f4af9d6479e00f482998b03653787a
prerequisite-patch-id: c4d3caa64171c21ee75b8ba30c80cab10c3674ef
-- 
2.41.0

Message #17 received at 70960 <at> debbugs.gnu.org (full text, mbox):

From: Jonathan Brielmaier <jonathan.brielmaier <at> web.de>
To: Andreas Enge <andreas <at> enge.fr>, 70960 <at> debbugs.gnu.org
Cc: Mark H Weaver <mhw <at> netris.org>,
 Clément Lassieur <clement <at> lassieur.org>
Subject: Re: bug#70960: [PATCH] gnu: Remove mozjs-91.
Date: Wed, 15 May 2024 22:12:10 +0200

Hallo Andreas,

Am 15.05.24 um 21:13 schrieb Andreas Enge:
> * gnu/packages/gnuzilla.scm (mozjs-91): Delete variable.

I'm not sure we should remove it yet.

0ad (the only reverse-dependency of mozjs <at> 78) at master branch uses
mozjs <at> 91. So the next release of it would require mozjs <at> 91.

See:
https://trac.wildfiregames.com/wiki/SpiderMonkey
https://code.wildfiregames.com/D4428

~Jonathan

Message #22 received at 70960-done <at> debbugs.gnu.org (full text, mbox):

From: Andreas Enge <andreas <at> enge.fr>
To: Jonathan Brielmaier <jonathan.brielmaier <at> web.de>
Cc: Mark H Weaver <mhw <at> netris.org>, 70960-done <at> debbugs.gnu.org,
 Clément Lassieur <clement <at> lassieur.org>
Subject: Re: bug#70960: [PATCH] gnu: Remove mozjs-91.
Date: Wed, 15 May 2024 23:13:56 +0200

Hallo, Jonathan!

Am Wed, May 15, 2024 at 10:12:10PM +0200 schrieb Jonathan Brielmaier:
> I'm not sure we should remove it yet.
> 0ad (the only reverse-dependency of mozjs <at> 78) at master branch uses
> mozjs <at> 91. So the next release of it would require mozjs <at> 91.

thanks for the info! It agrees with the feeling that it is strange to
remove @91 while keeping @78.

So I will just close this bug report, which will store the info for
future use.

Andreas

Previous Next

GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson.