GNU bug report logs - #70965
[PATCH 0/4] gnu: libsecp256k1: Update to 0.5.0.

Previous Next

To reply to this bug, email your comments to 70965 AT debbugs.gnu.org.

Toggle the display of automated, internal messages from the tracker.

Message #5 received at submit <at> debbugs.gnu.org (full text, mbox):

From: Jean-Pierre De Jesus DIAZ <jean <at> foundation.xyz>
To: guix-patches <at> gnu.org
Cc: Jean-Pierre De Jesus DIAZ <jean <at> foundation.xyz>
Subject: [PATCH 0/4] gnu: libsecp256k1: Update to 0.5.0.
Date: Wed, 15 May 2024 19:55:28 +0200

This patch series updates libsecp256k1 to 0.5.0 (latest version),
moves the location of home-page for consistency, removes configuration
flags that are (now) enabled by default on 0.5.0 and also removes some
pre-generated files.

Jean-Pierre De Jesus DIAZ (4):
  gnu: libsecp256k1: Update to 0.5.0.
  gnu: libsecp256k1: Move home-page field.
  gnu: libsecp256k1: Remove features enabled by default.
  gnu: libsecp256k1: Remove pre-generated files.

 gnu/packages/crypto.scm | 16 ++++++++++------
 1 file changed, 10 insertions(+), 6 deletions(-)


base-commit: b31a49cb5ea036a9869f3c2cd40d0f8b99af01f9
-- 
2.41.0

Message #8 received at 70965 <at> debbugs.gnu.org (full text, mbox):

From: Jean-Pierre De Jesus DIAZ <jean <at> foundation.xyz>
To: 70965 <at> debbugs.gnu.org
Cc: Jean-Pierre De Jesus DIAZ <jean <at> foundation.xyz>
Subject: [PATCH 1/4] gnu: libsecp256k1: Update to 0.5.0.
Date: Wed, 15 May 2024 20:00:03 +0200

* gnu/packages/crypto.scm (libsecp256k1): Update to 0.5.0.

Change-Id: I441085a0914f5998fd30d5dbdcc4d8b82f4aa332
---
 gnu/packages/crypto.scm | 6 +++---
 1 file changed, 3 insertions(+), 3 deletions(-)

diff --git a/gnu/packages/crypto.scm b/gnu/packages/crypto.scm
index 9c62689d18..e1b6b4d2ec 100644
--- a/gnu/packages/crypto.scm
+++ b/gnu/packages/crypto.scm
@@ -26,7 +26,7 @@
 ;;; Copyright © 2022 Maxim Cournoyer <maxim.cournoyer <at> gmail.com>
 ;;; Copyright © 2022 Denis 'GNUtoo' Carikli <GNUtoo <at> cyberdimension.org>
 ;;; Copyright © 2023 Ivan Vilata-i-Balaguer <ivan <at> selidor.net>
-;;; Copyright © 2023 Foundation Devices, Inc. <hello <at> foundationdevices.com>
+;;; Copyright © 2023,2024 Foundation Devices, Inc. <hello <at> foundation.xyz>
 ;;;
 ;;; This file is part of GNU Guix.
 ;;;
@@ -1078,7 +1078,7 @@ (define-public enchive
 (define-public libsecp256k1
   (package
     (name "libsecp256k1")
-    (version "0.3.2")
+    (version "0.5.0")
     (source (origin
               (method git-fetch)
               (uri (git-reference
@@ -1087,7 +1087,7 @@ (define-public libsecp256k1
               (file-name (git-file-name name version))
               (sha256
                (base32
-                "12wksk7bi3yfzmk1zwh5b6846zcaycqz1w4w4p23apjc8da4jwpn"))))
+                "1b5mi1byg46waa7v4z4b4vdhg5zaaaqg2f1vnfsvk0k7wb643k2x"))))
     (build-system gnu-build-system)
     (arguments
      '(#:configure-flags '("--enable-module-recovery"
-- 
2.41.0

Message #11 received at 70965 <at> debbugs.gnu.org (full text, mbox):

From: Jean-Pierre De Jesus DIAZ <jean <at> foundation.xyz>
To: 70965 <at> debbugs.gnu.org
Cc: Jean-Pierre De Jesus DIAZ <jean <at> foundation.xyz>
Subject: [PATCH 2/4] gnu: libsecp256k1: Move home-page field.
Date: Wed, 15 May 2024 20:00:04 +0200

* gnu/packages/crypto.scm (libsecp256k1) <home-page>: Move above
synopsis.

Change-Id: I3bc91a1eece7c739d77f327094099d3df4d4e38b
---
 gnu/packages/crypto.scm | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/gnu/packages/crypto.scm b/gnu/packages/crypto.scm
index e1b6b4d2ec..1f3ec5bb06 100644
--- a/gnu/packages/crypto.scm
+++ b/gnu/packages/crypto.scm
@@ -1099,6 +1099,7 @@ (define-public libsecp256k1
                            "--disable-benchmark")))
     (native-inputs
      (list autoconf automake libtool))
+    (home-page "https://github.com/bitcoin-core/secp256k1")
     (synopsis "C library for EC operations on curve secp256k1")
     (description
      "Optimized C library for EC operations on curve secp256k1.
@@ -1118,7 +1119,6 @@ (define-public libsecp256k1
 @item Optional module for ECDH key exchange.
 @item Optional module for Schnorr signatures according to BIP-340.
 @end itemize\n")
-    (home-page "https://github.com/bitcoin-core/secp256k1")
     (license license:expat)))
 
 (define-public libsecp256k1-bitcoin-cash
-- 
2.41.0

Message #14 received at 70965 <at> debbugs.gnu.org (full text, mbox):

From: Jean-Pierre De Jesus DIAZ <jean <at> foundation.xyz>
To: 70965 <at> debbugs.gnu.org
Cc: Jean-Pierre De Jesus DIAZ <jean <at> foundation.xyz>
Subject: [PATCH 3/4] gnu: libsecp256k1: Remove features enabled by default.
Date: Wed, 15 May 2024 20:00:05 +0200

These features are enabled by default so it doesn't make sense to have
these here.

* gnu/packages/crypto.scm (libsecp256k1) <arguments>: Remove
--enable-module-ecdh and --enable-module-schnorrsig from
configure-flags.

Change-Id: I64935d5c9725e13e8d6c191a30bd79381b630a24
---
 gnu/packages/crypto.scm | 2 --
 1 file changed, 2 deletions(-)

diff --git a/gnu/packages/crypto.scm b/gnu/packages/crypto.scm
index 1f3ec5bb06..abc535c0a2 100644
--- a/gnu/packages/crypto.scm
+++ b/gnu/packages/crypto.scm
@@ -1092,8 +1092,6 @@ (define-public libsecp256k1
     (arguments
      '(#:configure-flags '("--enable-module-recovery"
                            "--enable-experimental"
-                           "--enable-module-ecdh"
-                           "--enable-module-schnorrsig"
                            "--enable-shared"
                            "--disable-static"
                            "--disable-benchmark")))
-- 
2.41.0

Message #17 received at 70965 <at> debbugs.gnu.org (full text, mbox):

From: Jean-Pierre De Jesus DIAZ <jean <at> foundation.xyz>
To: 70965 <at> debbugs.gnu.org
Cc: Jean-Pierre De Jesus DIAZ <jean <at> foundation.xyz>
Subject: [PATCH 4/4] gnu: libsecp256k1: Remove pre-generated files.
Date: Wed, 15 May 2024 20:00:06 +0200

* gnu/packages/crypto.scm (libsecp256k1) <source>: Remove pre-generated
files.

Change-Id: Iac49ee8c4caedf7bf997f00640f32bab98e25c52
---
 gnu/packages/crypto.scm | 6 ++++++
 1 file changed, 6 insertions(+)

diff --git a/gnu/packages/crypto.scm b/gnu/packages/crypto.scm
index abc535c0a2..15d9188769 100644
--- a/gnu/packages/crypto.scm
+++ b/gnu/packages/crypto.scm
@@ -1085,6 +1085,12 @@ (define-public libsecp256k1
                     (url "https://github.com/bitcoin-core/secp256k1")
                     (commit (string-append "v" version))))
               (file-name (git-file-name name version))
+              (modules '((guix build utils)))
+              (snippet
+               ;; These files are pre-generated, the build system is able to
+               ;; re-generate those.
+               #~(for-each delete-file '("src/precomputed_ecmult.c"
+                                         "src/precomputed_ecmult_gen.c")))
               (sha256
                (base32
                 "1b5mi1byg46waa7v4z4b4vdhg5zaaaqg2f1vnfsvk0k7wb643k2x"))))
-- 
2.41.0

Previous Next

GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson.