GNU bug report logs - #70997
[PATCH] gnu: python-scikit-image: Disable test_ellipse_parameter_stability.

Previous Next

To reply to this bug, email your comments to 70997 AT debbugs.gnu.org.
There is no need to reopen the bug first.

Toggle the display of automated, internal messages from the tracker.

Message #5 received at submit <at> debbugs.gnu.org (full text, mbox):

From: Christopher Baines <mail <at> cbaines.net>
To: guix-patches <at> gnu.org
Subject: [PATCH] gnu: python-scikit-image: Disable
 test_ellipse_parameter_stability.
Date: Fri, 17 May 2024 09:00:52 +0100

As it's flaky, see https://github.com/scikit-image/scikit-image/issues/7061

* gnu/packages/python-science.scm (python-scikit-image)[arguments]: Add 'patch
phase.

Change-Id: Ic1fc301eb0fad5330c34780ce096c446c1076824
---
 gnu/packages/python-science.scm | 7 +++++++
 1 file changed, 7 insertions(+)

diff --git a/gnu/packages/python-science.scm b/gnu/packages/python-science.scm
index 861badad2e..d1a43b23ed 100644
--- a/gnu/packages/python-science.scm
+++ b/gnu/packages/python-science.scm
@@ -475,6 +475,13 @@ (define-public python-scikit-image
      (list
       #:phases
       #~(modify-phases %standard-phases
+          (add-after 'unpack 'patch
+            (lambda _
+              ;; Disable flaky test
+              (substitute* "skimage/measure/tests/test_fit.py"
+                (("def test_ellipse_parameter_stability():")
+                 "@pytest.mark.xfail(reason=\"https://github.com/scikit-image/scikit-image/issues/7061\")
+def test_ellipse_parameter_stability():"))))
           (add-before 'build 'change-home-dir
             (lambda _
               ;; Change from /homeless-shelter to /tmp for write permission.

base-commit: 0846eaecd45783bf40e8dc67b0c16f71068524b7
-- 
2.41.0

Message #8 received at 70997 <at> debbugs.gnu.org (full text, mbox):

From: Sharlatan Hellseher <sharlatanus <at> gmail.com>
To: 70997 <at> debbugs.gnu.org
Subject: [PATCH] gnu: python-scikit-image: Disable
 test_ellipse_parameter_stability.
Date: Fri, 17 May 2024 17:00:43 +0100

[Message part 1 (text/plain, inline)]

Hi Christopher


I think you may add the test to ignore list without substituting it.

--8<---------------cut here---------------start------------->8---
#:test-flags #~(list "-k" "test_ellipse_parameter_stability")
--8<---------------cut here---------------end--------------->8---

--
Oleg

[signature.asc (application/pgp-signature, inline)]

Message #13 received at 70997-done <at> debbugs.gnu.org (full text, mbox):

From: Christopher Baines <mail <at> cbaines.net>
To: Sharlatan Hellseher <sharlatanus <at> gmail.com>
Cc: 70997-done <at> debbugs.gnu.org
Subject: Re: [bug#70997] [PATCH] gnu: python-scikit-image: Disable
 test_ellipse_parameter_stability.
Date: Sun, 26 May 2024 17:20:43 +0100

[Message part 1 (text/plain, inline)]

Sharlatan Hellseher <sharlatanus <at> gmail.com> writes:

> I think you may add the test to ignore list without substituting it.
>
> --8<---------------cut here---------------start------------->8---
> #:test-flags #~(list "-k" "test_ellipse_parameter_stability")
> --8<---------------cut here---------------end--------------->8---

Thanks for the suggestion, I think that actually selects the test to
run, but adding not to the start seems to skip the named test, so I've
pushed this as a4a45669c76f80d5126add818df22f42547bb4a2.

Chris

[signature.asc (application/pgp-signature, inline)]

Previous Next

GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson.