GNU bug report logs - #71022
[PATCH] configure.ac: Set default value for the 'prefix' variable.

Please note: This is a static page, with minimal formatting, updated once a day.
Click here to see this page with the latest information and nicer formatting.
Package: guix-patches; Reported by: Maxim Cournoyer <maxim.cournoyer@HIDDEN>; Keywords: patch; dated Fri, 17 May 2024 23:56:02 UTC; Maintainer for guix-patches is guix-patches@HIDDEN.

Message received at submit <at> debbugs.gnu.org:


Received: (at submit) by debbugs.gnu.org; 22 May 2024 00:24:19 +0000
From debbugs-submit-bounces <at> debbugs.gnu.org Tue May 21 20:24:19 2024
Received: from localhost ([127.0.0.1]:52060 helo=debbugs.gnu.org)
	by debbugs.gnu.org with esmtp (Exim 4.84_2)
	(envelope-from <debbugs-submit-bounces <at> debbugs.gnu.org>)
	id 1s9ZmE-0008PX-NA
	for submit <at> debbugs.gnu.org; Tue, 21 May 2024 20:24:19 -0400
Received: from lists.gnu.org ([209.51.188.17]:39762)
 by debbugs.gnu.org with esmtp (Exim 4.84_2)
 (envelope-from <maxim.cournoyer@HIDDEN>) id 1s9Zm9-0008PR-IN
 for submit <at> debbugs.gnu.org; Tue, 21 May 2024 20:24:17 -0400
Received: from eggs.gnu.org ([2001:470:142:3::10])
 by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256)
 (Exim 4.90_1) (envelope-from <maxim.cournoyer@HIDDEN>)
 id 1s9Zm2-00053X-Rk
 for guix-patches@HIDDEN; Tue, 21 May 2024 20:24:06 -0400
Received: from mail-yw1-x1131.google.com ([2607:f8b0:4864:20::1131])
 by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128)
 (Exim 4.90_1) (envelope-from <maxim.cournoyer@HIDDEN>)
 id 1s9Zm1-0001As-1o; Tue, 21 May 2024 20:24:06 -0400
Received: by mail-yw1-x1131.google.com with SMTP id
 00721157ae682-62036051972so47370127b3.1; 
 Tue, 21 May 2024 17:24:03 -0700 (PDT)
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed;
 d=gmail.com; s=20230601; t=1716337442; x=1716942242; darn=gnu.org;
 h=mime-version:user-agent:message-id:date:references:in-reply-to
 :subject:cc:to:from:from:to:cc:subject:date:message-id:reply-to;
 bh=0jcIdBee1R2rZTljm33wefbwO8181SGEyosUpIEfbdI=;
 b=PhG+31BsV+UdeiPptZYNxxSPSw4PH2/fqTDx079eUIajKCz/xgzBH4SEGnAnzwOh/J
 Lhaqz1Nh9WHpx8WCXzQcIpnuTRVDC5xykMab0j+E5cT3r6REpjz9DBo1/3sFiFVrCa9s
 +ggL8uEm3IonOH5OD+8xfJWbbDPUIkM8Flf1ogDHFKjLzLquetthAa1LmvMGj1TGAnXZ
 EOguGHP2mJP1ef046i0+qT0kx20wdKtfEGRFpErX+5Mrb2TkcnM1jAUi4cdSpAwza+Dj
 hc1YdhPeMSCthCWMsfHjhjzDa129uLVcxvMAB2FJkwLzTiqiWqwJS2vA6L/z01Y080YF
 ulOg==
X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed;
 d=1e100.net; s=20230601; t=1716337442; x=1716942242;
 h=mime-version:user-agent:message-id:date:references:in-reply-to
 :subject:cc:to:from:x-gm-message-state:from:to:cc:subject:date
 :message-id:reply-to;
 bh=0jcIdBee1R2rZTljm33wefbwO8181SGEyosUpIEfbdI=;
 b=EsqcHHgGs9hsYvg9H8sgycY9YENnb6jccyaThNxvS+mMXitC2blJqVlmhzo7h1UOf4
 xRwsT4y9sD/Ve3+MBrtYyzEX7Y+VScYyY3e3GUPNRNzRqQto8b5xKKlwEXiaa7ttWP3U
 yYMQM6IOJRS6GYvhXYqSje5B2VIA0LjpsLR9v8WAUPQKEGYWbWknmisAwJiuvjWhcbiS
 kbl+bu2owbUqN/jDi5jX9XiqJ0dHzoEdnXkkUy8mGP5aWIutg7W0QhpYCm18yfIhWkug
 tHiL2Pf2cNX5LFbTEbPi7R69QYsBNxS2FZ2BkMOJlLoA9z1Yj/2F2K5QdYXRHE/aGlFy
 FRig==
X-Forwarded-Encrypted: i=1;
 AJvYcCU6saXX7BMzY1Xxxt8zVKbgNGljV/wR3WhmH77pAHNxVwUmthvOQeDJQ5MjJnlS41wRyvosbMu3PWQ2ncbdPp8=
X-Gm-Message-State: AOJu0Ywbd4tDCTWhZv5el/DNMPxlS1p865c4vVa8FU4E5nTduvqMdKnL
 ab8QGCJ2r+nPW+EYOeke9+bkbkaRXUjHXYLHnqswCDiTnYOmll63
X-Google-Smtp-Source: AGHT+IF5+EuxM+kjYMoESdlU6MbKOmusdnchNNN4mONSAmjyFpdYdZ6SPJdk/DamIDdrRmkri3oTnQ==
X-Received: by 2002:a81:4c53:0:b0:618:79f5:8d32 with SMTP id
 00721157ae682-627e4896f89mr6045417b3.48.1716337442202; 
 Tue, 21 May 2024 17:24:02 -0700 (PDT)
Received: from hurd (dsl-205-233-124-234.b2b2c.ca. [205.233.124.234])
 by smtp.gmail.com with ESMTPSA id
 6a1803df08f44-6ab8231dc95sm999186d6.69.2024.05.21.17.24.01
 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256);
 Tue, 21 May 2024 17:24:01 -0700 (PDT)
From: Maxim Cournoyer <maxim.cournoyer@HIDDEN>
To: guix-patches@HIDDEN
Subject: Re: [PATCH] configure.ac: Set default value for the 'prefix' variable.
In-Reply-To: <9ac2df37867548ae5e15e4c262458d8fc63ba9a1.1715989953.git.maxim.cournoyer@HIDDEN>
 (Maxim Cournoyer's message of "Fri, 17 May 2024 19:52:33 -0400")
References: <9ac2df37867548ae5e15e4c262458d8fc63ba9a1.1715989953.git.maxim.cournoyer@HIDDEN>
Date: Tue, 21 May 2024 20:24:00 -0400
Message-ID: <87jzjm4rtr.fsf@HIDDEN>
User-Agent: Gnus/5.13 (Gnus v5.13)
MIME-Version: 1.0
Content-Type: text/plain
Received-SPF: pass client-ip=2607:f8b0:4864:20::1131;
 envelope-from=maxim.cournoyer@HIDDEN; helo=mail-yw1-x1131.google.com
X-Spam_score_int: -20
X-Spam_score: -2.1
X-Spam_bar: --
X-Spam_report: (-2.1 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1,
 DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, FREEMAIL_FROM=0.001,
 RCVD_IN_DNSWL_NONE=-0.0001, SPF_HELO_NONE=0.001,
 SPF_PASS=-0.001 autolearn=ham autolearn_force=no
X-Spam_action: no action
X-Spam-Score: -1.3 (-)
X-Debbugs-Envelope-To: submit
Cc: Simon Tournier <zimon.toutoune@HIDDEN>,
 Vagrant Cascadian <vagrant@HIDDEN>, ludo@HIDDEN,
 Efraim Flashner <efraim@HIDDEN>, Ricardo Wurmus <rekado@HIDDEN>,
 Andreas Enge <andreas@HIDDEN>, Attila Lendvai <attila@HIDDEN>,
 Richard Sent <richard@HIDDEN>,
 Janneke Nieuwenhuizen <janneke@HIDDEN>
X-BeenThere: debbugs-submit <at> debbugs.gnu.org
X-Mailman-Version: 2.1.18
Precedence: list
List-Id: <debbugs-submit.debbugs.gnu.org>
List-Unsubscribe: <https://debbugs.gnu.org/cgi-bin/mailman/options/debbugs-submit>, 
 <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=unsubscribe>
List-Archive: <https://debbugs.gnu.org/cgi-bin/mailman/private/debbugs-submit/>
List-Post: <mailto:debbugs-submit <at> debbugs.gnu.org>
List-Help: <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=help>
List-Subscribe: <https://debbugs.gnu.org/cgi-bin/mailman/listinfo/debbugs-submit>, 
 <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=subscribe>
Errors-To: debbugs-submit-bounces <at> debbugs.gnu.org
Sender: "Debbugs-submit" <debbugs-submit-bounces <at> debbugs.gnu.org>
X-Spam-Score: -2.3 (--)

Hi,

Maxim Cournoyer <maxim.cournoyer@HIDDEN> writes:

> The Guix standard configuration uses a localstatedir of /var and a sysconfdir
> of /etc.  To ease things for everyone, make the default values match that
> standard expected configuration.  See
> <https://lists.gnu.org/archive/html/guix-devel/2024-05/msg00003.html> for a
> related discussion.
>
> * configure.ac: Default $prefix to '' unless already set.
> * doc/contributing.texi (Building from Git): Streamline doc.
> * doc/guix-cookbook.texi (Guix environment via direnv): Likewise.
>
> Change-Id: I23cd12b58a842d246fbc9fdc740311c573eb0212

While authoring the above, I got thinking about *why* we can't default
to the default GNU /usr/local prefix, since Guix *should* handle this
correctly, via paths registered in the (guix config).  I guess the only
reason is that /var is the hard-coded $localstatedir value we chose for
any Guix package and can't meaningfully be changed (without rewritting
the graft), so if it must exists anyway, we might as well use it for
Guix itself by default.

In other words, I believe this change does the right thing (the other
idea I was musing with defaulting '--prefix=' or '--localstatedir' to
the value of any installed guix, unless the user had provided one
explicitly).

-- 
Thanks,
Maxim
Information forwarded to guix-patches@HIDDEN:
bug#71022; Package guix-patches. Full text available.

Message received at submit <at> debbugs.gnu.org:


Received: (at submit) by debbugs.gnu.org; 22 May 2024 00:16:48 +0000
From debbugs-submit-bounces <at> debbugs.gnu.org Tue May 21 20:16:48 2024
Received: from localhost ([127.0.0.1]:52020 helo=debbugs.gnu.org)
	by debbugs.gnu.org with esmtp (Exim 4.84_2)
	(envelope-from <debbugs-submit-bounces <at> debbugs.gnu.org>)
	id 1s9Zey-0008K3-14
	for submit <at> debbugs.gnu.org; Tue, 21 May 2024 20:16:48 -0400
Received: from lists.gnu.org ([209.51.188.17]:54322)
 by debbugs.gnu.org with esmtp (Exim 4.84_2)
 (envelope-from <maxim.cournoyer@HIDDEN>) id 1s9Zew-0008Jx-2z
 for submit <at> debbugs.gnu.org; Tue, 21 May 2024 20:16:47 -0400
Received: from eggs.gnu.org ([2001:470:142:3::10])
 by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256)
 (Exim 4.90_1) (envelope-from <maxim.cournoyer@HIDDEN>)
 id 1s9Zem-0002SZ-2W
 for guix-patches@HIDDEN; Tue, 21 May 2024 20:16:38 -0400
Received: from mail-qk1-x72c.google.com ([2607:f8b0:4864:20::72c])
 by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128)
 (Exim 4.90_1) (envelope-from <maxim.cournoyer@HIDDEN>)
 id 1s9Zek-0007lf-Fx; Tue, 21 May 2024 20:16:35 -0400
Received: by mail-qk1-x72c.google.com with SMTP id
 af79cd13be357-792e4c2a002so55548885a.0; 
 Tue, 21 May 2024 17:16:32 -0700 (PDT)
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed;
 d=gmail.com; s=20230601; t=1716336991; x=1716941791; darn=gnu.org;
 h=mime-version:user-agent:message-id:date:references:in-reply-to
 :subject:cc:to:from:from:to:cc:subject:date:message-id:reply-to;
 bh=wqGtuEYnO2wBZXhocr4chnr/1qI/HebSLvOvcX6Zd4Q=;
 b=h8uQa3yWBsXWNN7Zjc41c2GVu+XlhCwRBT4bu7n+uNgVezaWUlJrgRYQ5MEoN4g5hM
 aolYCVa7DCMjgvDjbJtM5drbGAvLZZTGkS6+rdOgnO0MipdZr+fIwYd+XLXLa0n6G43D
 03KFe7lkXY/1mwqzUJRLm3YzL34DBFL5LUt7rnGbibgQh7YmVuCvBPY7nSSeHYOwSwjJ
 5/ZqtFxfSMuCr8nRbzxFm64HvmSRptPlEJ7+qJ9xC6iDm6QTwtumrYDVkHG28BAy9Ijk
 i+20fAltqMl5jQDylTiZGn01R8xNXJ6ftFgDD/6vnsQhoHq6Y352HHXNy7vyn5udhhpp
 yz0Q==
X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed;
 d=1e100.net; s=20230601; t=1716336991; x=1716941791;
 h=mime-version:user-agent:message-id:date:references:in-reply-to
 :subject:cc:to:from:x-gm-message-state:from:to:cc:subject:date
 :message-id:reply-to;
 bh=wqGtuEYnO2wBZXhocr4chnr/1qI/HebSLvOvcX6Zd4Q=;
 b=kfMu2yFgSXBf40SR2dPRf2AA8++ybf0LWUZ6Ovah0ws/rmuWjWvvZzDDVWqrXfUgNs
 LAu2ZCZczzbK8Aq9+BeMPOVrgnDGsHDFAPR88kZB1X0UZCuXOG+x9lwLF+5AeCCPpDL1
 CdnoCHgi/Bheq3Y8BzlkbkqlhpZeJ6NNsoTCZUip7MAXDD7DKmrBFSWEY6wFxMaepwpE
 dhRCEClMApAVppkqkEYgp1f7/chYw4EPGTT7I8yFdnS/JnsFuOiQLeiHUwl7xAKLUJe/
 rGlKtxoU3DgfxlxFMyei1a/EthyB46MWImVd817zoWkmiMWO4f4IOaHI9S3Whp2S90P4
 xL1Q==
X-Forwarded-Encrypted: i=1;
 AJvYcCWjgU0PY+eYmA5xXxZdgZDHlx6o6xoKSz1OSkk0HVG5arparregpOP8naLfB02f4XlIx85LVT0bpIY2VjHcsX5q42wYYk9WktVkPmh88g==
X-Gm-Message-State: AOJu0Yw9GdaAjFHeK39TRV1fxbWoPwCIfntuMLkiQGtkshjrSQN8qO8X
 zosCPxp8zU5xpNLxhpgV10cMoARe8ZIyP7F8+HBKdknbf/FDzJkI
X-Google-Smtp-Source: AGHT+IEWBoo8aKQ+rhH3wECek+er/5s3+pgrDtnmm/i6RTQEI2dsnRcEdQUdqHyCbbcfWAsQO+YxXQ==
X-Received: by 2002:a05:620a:4ce:b0:792:989e:7c5b with SMTP id
 af79cd13be357-794994b3f82mr46181585a.60.1716336991148; 
 Tue, 21 May 2024 17:16:31 -0700 (PDT)
Received: from hurd (dsl-205-233-124-234.b2b2c.ca. [205.233.124.234])
 by smtp.gmail.com with ESMTPSA id
 af79cd13be357-792bf2972cdsm1325371785a.54.2024.05.21.17.16.29
 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256);
 Tue, 21 May 2024 17:16:30 -0700 (PDT)
From: Maxim Cournoyer <maxim.cournoyer@HIDDEN>
To: Ricardo Wurmus <rekado@HIDDEN>
Subject: Re: [PATCH] configure.ac: Set default value for the 'prefix' variable.
In-Reply-To: <87h6eunkw3.fsf@HIDDEN> (Ricardo Wurmus's message of "Sun,
 19 May 2024 12:42:04 +0200")
References: <9ac2df37867548ae5e15e4c262458d8fc63ba9a1.1715989953.git.maxim.cournoyer@HIDDEN>
 <87h6eunkw3.fsf@HIDDEN>
Date: Tue, 21 May 2024 20:16:28 -0400
Message-ID: <87r0du4s6b.fsf@HIDDEN>
User-Agent: Gnus/5.13 (Gnus v5.13)
MIME-Version: 1.0
Content-Type: text/plain
Received-SPF: pass client-ip=2607:f8b0:4864:20::72c;
 envelope-from=maxim.cournoyer@HIDDEN; helo=mail-qk1-x72c.google.com
X-Spam_score_int: -20
X-Spam_score: -2.1
X-Spam_bar: --
X-Spam_report: (-2.1 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1,
 DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, FREEMAIL_FROM=0.001,
 RCVD_IN_DNSWL_NONE=-0.0001, SPF_HELO_NONE=0.001,
 SPF_PASS=-0.001 autolearn=ham autolearn_force=no
X-Spam_action: no action
X-Spam-Score: -1.3 (-)
X-Debbugs-Envelope-To: submit
Cc: Simon Tournier <zimon.toutoune@HIDDEN>,
 Vagrant Cascadian <vagrant@HIDDEN>, ludo@HIDDEN,
 Efraim Flashner <efraim@HIDDEN>, Andreas Enge <andreas@HIDDEN>,
 Attila Lendvai <attila@HIDDEN>,
 Richard Sent <richard@HIDDEN>, guix-patches@HIDDEN,
 Janneke Nieuwenhuizen <janneke@HIDDEN>
X-BeenThere: debbugs-submit <at> debbugs.gnu.org
X-Mailman-Version: 2.1.18
Precedence: list
List-Id: <debbugs-submit.debbugs.gnu.org>
List-Unsubscribe: <https://debbugs.gnu.org/cgi-bin/mailman/options/debbugs-submit>, 
 <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=unsubscribe>
List-Archive: <https://debbugs.gnu.org/cgi-bin/mailman/private/debbugs-submit/>
List-Post: <mailto:debbugs-submit <at> debbugs.gnu.org>
List-Help: <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=help>
List-Subscribe: <https://debbugs.gnu.org/cgi-bin/mailman/listinfo/debbugs-submit>, 
 <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=subscribe>
Errors-To: debbugs-submit-bounces <at> debbugs.gnu.org
Sender: "Debbugs-submit" <debbugs-submit-bounces <at> debbugs.gnu.org>
X-Spam-Score: -2.3 (--)

Hi Ricardo,

Ricardo Wurmus <rekado@HIDDEN> writes:

> Maxim Cournoyer <maxim.cournoyer@HIDDEN> writes:
>
>> -When configuring Guix on a system that already has a Guix installation,
>> -be sure to specify the same state directory as the existing installation
>> -using the @option{--localstatedir} option of the @command{configure}
>> -script (@pxref{Directory Variables, @code{localstatedir},, standards,
>> -GNU Coding Standards}).  Usually, this @var{localstatedir} option is set
>> -to the value @file{/var}.  The @command{configure} script protects
>> -against unintended misconfiguration of @var{localstatedir} so you do not
>> -inadvertently corrupt your store (@pxref{The Store}).  The configuration
>> -directory should also be configured by setting the @option{--sysconfdir}
>> -option to the @file{/etc} value, which is the location used by Guix to
>> -store for example the access control list of authorized machines and the
>> -definition of offload machines.
>
> This information is still useful, isn't it?  It's important for people
> who intend to modify these locations, such as system administrators who
> might want to install things elsewhere.  Perhaps this could be rewritten
> to explain why this would be a bad idea.

It's useful, but it's duplicated with the warning you'd get from
the GUIX_CHECK_LOCALSTATEDIR m4/guix.m4 macro:

--8<---------------cut here---------------start------------->8---
dnl GUIX_CHECK_LOCALSTATEDIR
dnl
dnl Check that the LOCALSTATEDIR value is consistent with that of the existing
dnl Guix installation, if any.  Error out or warn if they do not match.
AC_DEFUN([GUIX_CHECK_LOCALSTATEDIR], [
  AC_REQUIRE([GUIX_CURRENT_LOCALSTATEDIR])
  if test "x$guix_cv_current_localstatedir" != "xnone"; then
    if test "$guix_cv_current_localstatedir" != "$guix_localstatedir"; then
      case "$localstatedir" in
        NONE|\${prefix}*)
          # User kept the default value---i.e., did not pass '--localstatedir'.
          AC_MSG_ERROR([chosen localstatedir '$guix_localstatedir' does not match \
that of the existing installation '$guix_cv_current_localstatedir'
Installing may corrupt $storedir!
Use './configure --localstatedir=$guix_cv_current_localstatedir'.])
          ;;
        *)
          # User passed an explicit '--localstatedir'.  Assume they know what
          # they're doing.
          AC_MSG_WARN([chosen localstatedir '$guix_localstatedir' does not match \
that of the existing installation '$guix_cv_current_localstatedir'])
          AC_MSG_WARN([installing may corrupt $storedir!])
         ;;
      esac
    fi
  fi])
--8<---------------cut here---------------end--------------->8---

So it seems judicious to remove it, especially since with this change
the default `./configure` would no longer require the user to think
about '--localstatedir' and friends (unless their system was an odd
snowflake, in which case the macro would do its job to warn them).

Does that clarify the intent?

-- 
Thanks,
Maxim
Information forwarded to guix-patches@HIDDEN:
bug#71022; Package guix-patches. Full text available.

Message received at 71022 <at> debbugs.gnu.org:


Received: (at 71022) by debbugs.gnu.org; 19 May 2024 14:16:28 +0000
From debbugs-submit-bounces <at> debbugs.gnu.org Sun May 19 10:16:28 2024
Received: from localhost ([127.0.0.1]:36379 helo=debbugs.gnu.org)
	by debbugs.gnu.org with esmtp (Exim 4.84_2)
	(envelope-from <debbugs-submit-bounces <at> debbugs.gnu.org>)
	id 1s8hKt-0001Y8-U7
	for submit <at> debbugs.gnu.org; Sun, 19 May 2024 10:16:28 -0400
Received: from eggs.gnu.org ([209.51.188.92]:39880)
 by debbugs.gnu.org with esmtp (Exim 4.84_2)
 (envelope-from <ludo@HIDDEN>) id 1s8hKt-0001Y2-31
 for 71022 <at> debbugs.gnu.org; Sun, 19 May 2024 10:16:27 -0400
Received: from fencepost.gnu.org ([2001:470:142:3::e])
 by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256)
 (Exim 4.90_1) (envelope-from <ludo@HIDDEN>)
 id 1s8hKg-0005vg-3i; Sun, 19 May 2024 10:16:14 -0400
DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=gnu.org;
 s=fencepost-gnu-org; h=MIME-Version:Date:References:In-Reply-To:Subject:To:
 From; bh=LzXnz2IjXo6EyXSnVaCRGrBfP9rY27Z0GT/hJe6IsDQ=; b=Dy9OYS+K414sv3/CBXct
 Fwpdo00mX1Ip9Pc8QJLx7k7YR76TU6zlQ1Ai+eIaUuCSNULobuPRZk48nFQkw9rD25R6c6k2VGlux
 qlZ9Pa+tB8iwWUqInp/7FuNT4Pc/UyFGbYaEtpHunN6dJ/2Cap5M4J0IPBZD/nRxqUbefHeq4bvB8
 fFVvfMM29uo/wjLi0D7aS8DxcjLiipqsUd5BBNhW/fUGJjrYmgZgm/UhpL98jE3llvv25mNh/LN0L
 ppM3RFQ0zukJvAktImBtfQzrLbQawqNbPLXkxhohyJxUwIbyDaj+NIdY2oknw2LmweJxTecuvNDO9
 RNdkkVMITFEbzw==;
From: =?utf-8?Q?Ludovic_Court=C3=A8s?= <ludo@HIDDEN>
To: Maxim Cournoyer <maxim.cournoyer@HIDDEN>
Subject: Re: [bug#71022] [PATCH] configure.ac: Set default value for the
 'prefix' variable.
In-Reply-To: <9ac2df37867548ae5e15e4c262458d8fc63ba9a1.1715989953.git.maxim.cournoyer@HIDDEN>
 (Maxim Cournoyer's message of "Fri, 17 May 2024 19:52:33 -0400")
References: <9ac2df37867548ae5e15e4c262458d8fc63ba9a1.1715989953.git.maxim.cournoyer@HIDDEN>
X-URL: http://www.fdn.fr/~lcourtes/
X-Revolutionary-Date: Primidi 1 Prairial an 232 de la =?utf-8?Q?R=C3=A9vol?=
 =?utf-8?Q?ution=2C?= jour de la Luzerne
X-PGP-Key-ID: 0x090B11993D9AEBB5
X-PGP-Key: http://www.fdn.fr/~lcourtes/ludovic.asc
X-PGP-Fingerprint: 3CE4 6455 8A84 FDC6 9DB4  0CFB 090B 1199 3D9A EBB5
X-OS: x86_64-pc-linux-gnu
Date: Sun, 19 May 2024 16:16:10 +0200
Message-ID: <87ttit3n11.fsf@HIDDEN>
User-Agent: Gnus/5.13 (Gnus v5.13)
MIME-Version: 1.0
Content-Type: text/plain; charset=utf-8
Content-Transfer-Encoding: quoted-printable
X-Spam-Score: 0.7 (/)
X-Debbugs-Envelope-To: 71022
Cc: Simon Tournier <zimon.toutoune@HIDDEN>,
 Vagrant Cascadian <vagrant@HIDDEN>,
 Richard Sent <richard@HIDDEN>, 71022 <at> debbugs.gnu.org,
 Efraim Flashner <efraim@HIDDEN>,
 Florian Pelz <pelzflorian@HIDDEN>, Ricardo Wurmus <rekado@HIDDEN>,
 Andreas Enge <andreas@HIDDEN>, Attila Lendvai <attila@HIDDEN>,
 Matthew Trzcinski <matt@HIDDEN>,
 Janneke Nieuwenhuizen <janneke@HIDDEN>
X-BeenThere: debbugs-submit <at> debbugs.gnu.org
X-Mailman-Version: 2.1.18
Precedence: list
List-Id: <debbugs-submit.debbugs.gnu.org>
List-Unsubscribe: <https://debbugs.gnu.org/cgi-bin/mailman/options/debbugs-submit>, 
 <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=unsubscribe>
List-Archive: <https://debbugs.gnu.org/cgi-bin/mailman/private/debbugs-submit/>
List-Post: <mailto:debbugs-submit <at> debbugs.gnu.org>
List-Help: <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=help>
List-Subscribe: <https://debbugs.gnu.org/cgi-bin/mailman/listinfo/debbugs-submit>, 
 <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=subscribe>
Errors-To: debbugs-submit-bounces <at> debbugs.gnu.org
Sender: "Debbugs-submit" <debbugs-submit-bounces <at> debbugs.gnu.org>
X-Spam-Score: -0.3 (/)

Hi Maxim,

Maxim Cournoyer <maxim.cournoyer@HIDDEN> skribis:

> The Guix standard configuration uses a localstatedir of /var and a syscon=
fdir
> of /etc.  To ease things for everyone, make the default values match that
> standard expected configuration.  See
> <https://lists.gnu.org/archive/html/guix-devel/2024-05/msg00003.html> for=
 a
> related discussion.
>
> * configure.ac: Default $prefix to '' unless already set.
> * doc/contributing.texi (Building from Git): Streamline doc.
> * doc/guix-cookbook.texi (Guix environment via direnv): Likewise.
>
> Change-Id: I23cd12b58a842d246fbc9fdc740311c573eb0212

[...]

> +dnl Set some sane default directory variables for use with the Guix.  Th=
is
> +dnl also causes localstatedir to be /var and sysconfdir to be /etc.
> +test "$prefix" =3D NONE && prefix=3D

Shouldn=E2=80=99t it read =E2=80=9Cprefix=3D/=E2=80=9D?

Might be good to check whether this breaks =E2=80=9Cmake distcheck=E2=80=9D=
, so I
suppose it should be fine.

Apart from that it LGTM.  Thanks for this patch!

Ludo=E2=80=99.
Information forwarded to guix-patches@HIDDEN:
bug#71022; Package guix-patches. Full text available.

Message received at submit <at> debbugs.gnu.org:


Received: (at submit) by debbugs.gnu.org; 19 May 2024 10:42:27 +0000
From debbugs-submit-bounces <at> debbugs.gnu.org Sun May 19 06:42:27 2024
Received: from localhost ([127.0.0.1]:35940 helo=debbugs.gnu.org)
	by debbugs.gnu.org with esmtp (Exim 4.84_2)
	(envelope-from <debbugs-submit-bounces <at> debbugs.gnu.org>)
	id 1s8dzm-0003ys-Mf
	for submit <at> debbugs.gnu.org; Sun, 19 May 2024 06:42:27 -0400
Received: from lists.gnu.org ([209.51.188.17]:56110)
 by debbugs.gnu.org with esmtp (Exim 4.84_2)
 (envelope-from <rekado@HIDDEN>) id 1s8dzl-0003ym-3x
 for submit <at> debbugs.gnu.org; Sun, 19 May 2024 06:42:25 -0400
Received: from eggs.gnu.org ([2001:470:142:3::10])
 by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256)
 (Exim 4.90_1) (envelope-from <rekado@HIDDEN>)
 id 1s8dzg-0006jr-SN
 for guix-patches@HIDDEN; Sun, 19 May 2024 06:42:20 -0400
Received: from sender4-of-o51.zoho.com ([136.143.188.51])
 by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256)
 (Exim 4.90_1) (envelope-from <rekado@HIDDEN>)
 id 1s8dze-0007Ix-8y; Sun, 19 May 2024 06:42:20 -0400
ARC-Seal: i=1; a=rsa-sha256; t=1716115331; cv=none; 
 d=zohomail.com; s=zohoarc; 
 b=oJB/k1MHAPzbARd9QAa9VNCpO5+OpbkZuFK3rbmT1RhSbtMm30HqOUOiJiR9CtmYPJlT+wZtyZLLz7BE0dTSfrrTXc/8YTuUphqNSbltadL1uzggRcA95pkfl5em37b3uxEK5pbqBVAW4hpKVdh0E6pqQsRRAKbU8yQYfI1Pf08=
ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com;
 s=zohoarc; t=1716115331;
 h=Content-Type:Cc:Cc:Date:Date:From:From:In-Reply-To:MIME-Version:Message-ID:References:Subject:Subject:To:To:Message-Id:Reply-To;
 bh=0zug476CqosrN+2qAGb+zoiGy+amoN2kQtPHfeeVqDI=; 
 b=MLJFrD+ii1CpEjEdp2yd514jqnIPHdidqsNM7BQHk2y3eMpj8Em//vOmymqSKj0VGYbNK8R+pvwNzLCMTRGhGZnUZgo8fXD19SFyVDkf4Cxr1M6HbzHdQU3GUc6I9F0Ub7EVDpEtZjKzOgpLZc5LgT0enTyLabjdbciMIyqEH08=
ARC-Authentication-Results: i=1; mx.zohomail.com;
 dkim=pass  header.i=elephly.net;
 spf=pass  smtp.mailfrom=rekado@HIDDEN;
 dmarc=pass header.from=<rekado@HIDDEN>
DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; t=1716115331; 
 s=zoho; d=elephly.net; i=rekado@HIDDEN;
 h=From:From:To:To:Cc:Cc:Subject:Subject:In-Reply-To:References:Date:Date:Message-ID:MIME-Version:Content-Type:Message-Id:Reply-To;
 bh=0zug476CqosrN+2qAGb+zoiGy+amoN2kQtPHfeeVqDI=;
 b=JXIU80EOEj/xgKPkPmbXf+JQt5NP/x+nsk1C5XOTrKIoeDResZ1mGgadZLMdiG4L
 ySxDtY+WpBNMksYP90p7EnsvtdLMLH2nHVhOu6ityhW1tSDhUURR5+iV9TsmQr9gSWH
 pReZ0onKLXx9idWmoafO1/N6Aq3QT1Uo/bPXFr+o=
Received: by mx.zohomail.com with SMTPS id 1716115329496962.3010355461726;
 Sun, 19 May 2024 03:42:09 -0700 (PDT)
From: Ricardo Wurmus <rekado@HIDDEN>
To: Maxim Cournoyer <maxim.cournoyer@HIDDEN>
Subject: Re: [PATCH] configure.ac: Set default value for the 'prefix' variable.
In-Reply-To: <9ac2df37867548ae5e15e4c262458d8fc63ba9a1.1715989953.git.maxim.cournoyer@HIDDEN>
 (Maxim Cournoyer's message of "Fri, 17 May 2024 19:52:33 -0400")
References: <9ac2df37867548ae5e15e4c262458d8fc63ba9a1.1715989953.git.maxim.cournoyer@HIDDEN>
User-Agent: mu4e 1.12.4; emacs 29.3
Date: Sun, 19 May 2024 12:42:04 +0200
Message-ID: <87h6eunkw3.fsf@HIDDEN>
MIME-Version: 1.0
Content-Type: text/plain
X-ZohoMailClient: External
Received-SPF: pass client-ip=136.143.188.51; envelope-from=rekado@HIDDEN;
 helo=sender4-of-o51.zoho.com
X-Spam_score_int: -20
X-Spam_score: -2.1
X-Spam_bar: --
X-Spam_report: (-2.1 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1,
 DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1,
 RCVD_IN_DNSWL_NONE=-0.0001, RCVD_IN_MSPIKE_H4=0.001, RCVD_IN_MSPIKE_WL=0.001,
 SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no
X-Spam_action: no action
X-Spam-Score: -1.3 (-)
X-Debbugs-Envelope-To: submit
Cc: Simon Tournier <zimon.toutoune@HIDDEN>,
 Vagrant Cascadian <vagrant@HIDDEN>, ludo@HIDDEN,
 Efraim Flashner <efraim@HIDDEN>, Andreas Enge <andreas@HIDDEN>,
 Attila Lendvai <attila@HIDDEN>,
 Richard Sent <richard@HIDDEN>, guix-patches@HIDDEN,
 Janneke Nieuwenhuizen <janneke@HIDDEN>
X-BeenThere: debbugs-submit <at> debbugs.gnu.org
X-Mailman-Version: 2.1.18
Precedence: list
List-Id: <debbugs-submit.debbugs.gnu.org>
List-Unsubscribe: <https://debbugs.gnu.org/cgi-bin/mailman/options/debbugs-submit>, 
 <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=unsubscribe>
List-Archive: <https://debbugs.gnu.org/cgi-bin/mailman/private/debbugs-submit/>
List-Post: <mailto:debbugs-submit <at> debbugs.gnu.org>
List-Help: <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=help>
List-Subscribe: <https://debbugs.gnu.org/cgi-bin/mailman/listinfo/debbugs-submit>, 
 <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=subscribe>
Errors-To: debbugs-submit-bounces <at> debbugs.gnu.org
Sender: "Debbugs-submit" <debbugs-submit-bounces <at> debbugs.gnu.org>
X-Spam-Score: -2.3 (--)

Maxim Cournoyer <maxim.cournoyer@HIDDEN> writes:

> -When configuring Guix on a system that already has a Guix installation,
> -be sure to specify the same state directory as the existing installation
> -using the @option{--localstatedir} option of the @command{configure}
> -script (@pxref{Directory Variables, @code{localstatedir},, standards,
> -GNU Coding Standards}).  Usually, this @var{localstatedir} option is set
> -to the value @file{/var}.  The @command{configure} script protects
> -against unintended misconfiguration of @var{localstatedir} so you do not
> -inadvertently corrupt your store (@pxref{The Store}).  The configuration
> -directory should also be configured by setting the @option{--sysconfdir}
> -option to the @file{/etc} value, which is the location used by Guix to
> -store for example the access control list of authorized machines and the
> -definition of offload machines.

This information is still useful, isn't it?  It's important for people
who intend to modify these locations, such as system administrators who
might want to install things elsewhere.  Perhaps this could be rewritten
to explain why this would be a bad idea.

-- 
Ricardo
Information forwarded to guix-patches@HIDDEN:
bug#71022; Package guix-patches. Full text available.

Message received at submit <at> debbugs.gnu.org:


Received: (at submit) by debbugs.gnu.org; 17 May 2024 23:55:35 +0000
From debbugs-submit-bounces <at> debbugs.gnu.org Fri May 17 19:55:35 2024
Received: from localhost ([127.0.0.1]:57947 helo=debbugs.gnu.org)
	by debbugs.gnu.org with esmtp (Exim 4.84_2)
	(envelope-from <debbugs-submit-bounces <at> debbugs.gnu.org>)
	id 1s87QF-0003mU-CJ
	for submit <at> debbugs.gnu.org; Fri, 17 May 2024 19:55:35 -0400
Received: from lists.gnu.org ([209.51.188.17]:45196)
 by debbugs.gnu.org with esmtp (Exim 4.84_2)
 (envelope-from <maxim.cournoyer@HIDDEN>) id 1s87QC-0003mO-A2
 for submit <at> debbugs.gnu.org; Fri, 17 May 2024 19:55:33 -0400
Received: from eggs.gnu.org ([2001:470:142:3::10])
 by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256)
 (Exim 4.90_1) (envelope-from <maxim.cournoyer@HIDDEN>)
 id 1s87O2-0004DJ-TO
 for guix-patches@HIDDEN; Fri, 17 May 2024 19:53:18 -0400
Received: from mail-yw1-x1135.google.com ([2607:f8b0:4864:20::1135])
 by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128)
 (Exim 4.90_1) (envelope-from <maxim.cournoyer@HIDDEN>)
 id 1s87O0-000893-QH; Fri, 17 May 2024 19:53:18 -0400
Received: by mail-yw1-x1135.google.com with SMTP id
 00721157ae682-62036051972so7978907b3.1; 
 Fri, 17 May 2024 16:53:14 -0700 (PDT)
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed;
 d=gmail.com; s=20230601; t=1715989993; x=1716594793; darn=gnu.org;
 h=content-transfer-encoding:mime-version:message-id:date:subject:cc
 :to:from:from:to:cc:subject:date:message-id:reply-to;
 bh=Uaq2gwSO2xGxuaRVUpI2osQam0rhtAlAigodtEs01/4=;
 b=aj7iRlwQHXOfxAYxxLiT7JH33Hji+B6+Ntc0jMZZ4KYzbZBB9LGuVvsZX/uMn5LeYR
 834E5Ws/9NHvuK21BsxxZwKoVSN/sy57ED1nQ3C6t+mfGrlL2KH49Ti2V+eAKsdKcleu
 Ey7xPBWIprKfYGBdl6X6dTfLfb5AnEGKcS3BDrXDbz4r4jeK9YkBt1o0tpTV9ea3jqry
 aAYr/OppYtahv1WVwuUckx7hTNr8En1UAr1e4X/qwdhMhD5CjycT+S80V13XBf5RX19W
 dEAi0UN0RC/ZkScw9N7kL6k+vvQY3Q/9aeFRspjK49fbuE1nocbyO9EZC+n4E/B5geBn
 PDZQ==
X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed;
 d=1e100.net; s=20230601; t=1715989993; x=1716594793;
 h=content-transfer-encoding:mime-version:message-id:date:subject:cc
 :to:from:x-gm-message-state:from:to:cc:subject:date:message-id
 :reply-to;
 bh=Uaq2gwSO2xGxuaRVUpI2osQam0rhtAlAigodtEs01/4=;
 b=A7TC7FtgatLYsfiCIjUcDYHk1x8L3ZdgNmB9TDtLFuzoUmgx8PP5a7fICaQIipEuAO
 Eq7p8SMwdppMJaKPL/oDfs2K5OvZBe2NtNuS2WsCJWfoh6rAmmRbw5LZc/istQcHWztl
 yeo1djqWBw7eGlegXgA3iVA58GnMaTFe7vYSpgMOUQfLymK0UPzvOpf3SKRo3eZQhNuU
 zfQrWsQPJKRyTqS+W+pgmkzzbyMX6jrGMcRaiF85h3tf20AV6FvSUJKPLU3iyQz/6I8M
 iz8t8ajeSuruz0bctZQz1yYcwIEX4OQRAYlFIvkANM6t/rzAqdHwgHRH4r/pHN7EWj2n
 kdYA==
X-Forwarded-Encrypted: i=1;
 AJvYcCWEbqbOcMyspNuyfRTJypM8+IzRVBfqIURoWKaJD87edpAXVw9bAXlh4OTQAUYWTAb+abof8egqjz6RPaMaUQg=
X-Gm-Message-State: AOJu0YzfwBAwdlVjoKhM0ulievoNe208apQn7QviwaRar/BSCEOb4ABe
 Ho3mLYlGXM1ePoSlEKK+XbhM0Rbzyyw5Z14MKAfdnze1oIvprIkACZFU4MxX
X-Google-Smtp-Source: AGHT+IFZkux2PKjVBZsjNvV/vJWkVk30JTk1kEI3KrCUFGHxpjhELcr/7h/pktSfxuyUoieG5XTKRw==
X-Received: by 2002:a0d:e605:0:b0:627:788e:94c7 with SMTP id
 00721157ae682-627788e96fbmr69281697b3.6.1715989992676; 
 Fri, 17 May 2024 16:53:12 -0700 (PDT)
Received: from localhost.localdomain (dsl-155-127.b2b2c.ca. [66.158.155.127])
 by smtp.gmail.com with ESMTPSA id
 d75a77b69052e-43df54b590csm116150041cf.13.2024.05.17.16.53.11
 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256);
 Fri, 17 May 2024 16:53:12 -0700 (PDT)
From: Maxim Cournoyer <maxim.cournoyer@HIDDEN>
To: guix-patches@HIDDEN
Subject: [PATCH] configure.ac: Set default value for the 'prefix' variable.
Date: Fri, 17 May 2024 19:52:33 -0400
Message-ID: <9ac2df37867548ae5e15e4c262458d8fc63ba9a1.1715989953.git.maxim.cournoyer@HIDDEN>
X-Mailer: git-send-email 2.41.0
MIME-Version: 1.0
X-Debbugs-Cc: Florian Pelz <pelzflorian@HIDDEN>, Ludovic Courtès <ludo@HIDDEN>, Matthew Trzcinski <matt@HIDDEN>, Maxim Cournoyer <maxim.cournoyer@HIDDEN>
Content-Transfer-Encoding: 8bit
Received-SPF: pass client-ip=2607:f8b0:4864:20::1135;
 envelope-from=maxim.cournoyer@HIDDEN; helo=mail-yw1-x1135.google.com
X-Spam_score_int: -20
X-Spam_score: -2.1
X-Spam_bar: --
X-Spam_report: (-2.1 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1,
 DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, FREEMAIL_FROM=0.001,
 RCVD_IN_DNSWL_NONE=-0.0001, SPF_HELO_NONE=0.001,
 SPF_PASS=-0.001 autolearn=ham autolearn_force=no
X-Spam_action: no action
X-Spam-Score: 1.7 (+)
X-Spam-Report: Spam detection software, running on the system "debbugs.gnu.org",
 has NOT identified this incoming email as spam.  The original
 message has been attached to this so you can view it or label
 similar future email.  If you have any questions, see
 the administrator of that system for details.
 Content preview: The Guix standard configuration uses a localstatedir of /var
 and a sysconfdir of /etc. To ease things for everyone, make the default values
 match that standard expected configuration. See <https://lis [...] 
 Content analysis details:   (1.7 points, 10.0 required)
 pts rule name              description
 ---- ---------------------- --------------------------------------------------
 3.0 MANY_TO_CC             Sent to 10+ recipients
 -2.3 RCVD_IN_DNSWL_MED      RBL: Sender listed at https://www.dnswl.org/,
 medium trust [209.51.188.17 listed in list.dnswl.org]
 0.0 FREEMAIL_FROM          Sender email is commonly abused enduser mail
 provider (maxim.cournoyer[at]gmail.com)
 -0.0 SPF_HELO_PASS          SPF: HELO matches SPF record
 1.0 SPF_SOFTFAIL           SPF: sender does not match SPF record (softfail)
X-Debbugs-Envelope-To: submit
Cc: Maxim Cournoyer <maxim.cournoyer@HIDDEN>,
 Simon Tournier <zimon.toutoune@HIDDEN>,
 Vagrant Cascadian <vagrant@HIDDEN>, ludo@HIDDEN,
 Efraim Flashner <efraim@HIDDEN>, Ricardo Wurmus <rekado@HIDDEN>,
 Andreas Enge <andreas@HIDDEN>, Attila Lendvai <attila@HIDDEN>,
 Richard Sent <richard@HIDDEN>,
 Janneke Nieuwenhuizen <janneke@HIDDEN>
X-BeenThere: debbugs-submit <at> debbugs.gnu.org
X-Mailman-Version: 2.1.18
Precedence: list
List-Id: <debbugs-submit.debbugs.gnu.org>
List-Unsubscribe: <https://debbugs.gnu.org/cgi-bin/mailman/options/debbugs-submit>, 
 <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=unsubscribe>
List-Archive: <https://debbugs.gnu.org/cgi-bin/mailman/private/debbugs-submit/>
List-Post: <mailto:debbugs-submit <at> debbugs.gnu.org>
List-Help: <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=help>
List-Subscribe: <https://debbugs.gnu.org/cgi-bin/mailman/listinfo/debbugs-submit>, 
 <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=subscribe>
Errors-To: debbugs-submit-bounces <at> debbugs.gnu.org
Sender: "Debbugs-submit" <debbugs-submit-bounces <at> debbugs.gnu.org>
X-Spam-Score: 0.7 (/)

The Guix standard configuration uses a localstatedir of /var and a sysconfdir
of /etc.  To ease things for everyone, make the default values match that
standard expected configuration.  See
<https://lists.gnu.org/archive/html/guix-devel/2024-05/msg00003.html> for a
related discussion.

* configure.ac: Default $prefix to '' unless already set.
* doc/contributing.texi (Building from Git): Streamline doc.
* doc/guix-cookbook.texi (Guix environment via direnv): Likewise.

Change-Id: I23cd12b58a842d246fbc9fdc740311c573eb0212
---

 configure.ac           |  4 ++++
 doc/contributing.texi  | 15 +--------------
 doc/guix-cookbook.texi |  2 +-
 3 files changed, 6 insertions(+), 15 deletions(-)

diff --git a/configure.ac b/configure.ac
index 8c3a06da37..f831416650 100644
--- a/configure.ac
+++ b/configure.ac
@@ -73,6 +73,10 @@ AC_ARG_ENABLE([daemon],
   [guix_build_daemon="$enableval"],
   [guix_build_daemon="yes"])
 
+dnl Set some sane default directory variables for use with the Guix.  This
+dnl also causes localstatedir to be /var and sysconfdir to be /etc.
+test "$prefix" = NONE && prefix=
+
 # Prepare a version of $localstatedir & co. that does not contain references
 # to shell variables.
 guix_prefix="`eval echo $prefix | sed -e"s|NONE|/usr/local|g"`"
diff --git a/doc/contributing.texi b/doc/contributing.texi
index 66f4e86d0a..539b4dd0d3 100644
--- a/doc/contributing.texi
+++ b/doc/contributing.texi
@@ -235,7 +235,7 @@ Building from Git
 Then, run:
 
 @example
-./configure --localstatedir=/var --sysconfdir=/etc
+./configure
 @end example
 
 @noindent
@@ -246,19 +246,6 @@ Building from Git
 important to pass the right @code{localstatedir} and @code{sysconfdir}
 values, which get recorded in the @code{(guix config)} Guile module.
 
-When configuring Guix on a system that already has a Guix installation,
-be sure to specify the same state directory as the existing installation
-using the @option{--localstatedir} option of the @command{configure}
-script (@pxref{Directory Variables, @code{localstatedir},, standards,
-GNU Coding Standards}).  Usually, this @var{localstatedir} option is set
-to the value @file{/var}.  The @command{configure} script protects
-against unintended misconfiguration of @var{localstatedir} so you do not
-inadvertently corrupt your store (@pxref{The Store}).  The configuration
-directory should also be configured by setting the @option{--sysconfdir}
-option to the @file{/etc} value, which is the location used by Guix to
-store for example the access control list of authorized machines and the
-definition of offload machines.
-
 Finally, you can build Guix and, if you feel so inclined, run the tests
 (@pxref{Running the Test Suite}):
 
diff --git a/doc/guix-cookbook.texi b/doc/guix-cookbook.texi
index 3bc63cba7a..cbd088632a 100644
--- a/doc/guix-cookbook.texi
+++ b/doc/guix-cookbook.texi
@@ -5076,7 +5076,7 @@ Guix environment via direnv
     # Predefine configure flags.
     configure()
     @{
-        ./configure --localstatedir=/var --prefix=
+        ./configure
     @}
     export_function configure
 

base-commit: 5a624adfd7b14c3717237d137bd0766c77f0f570
-- 
2.41.0
Acknowledgement sent to Maxim Cournoyer <maxim.cournoyer@HIDDEN>:
New bug report received and forwarded. Copy sent to pelzflorian@HIDDEN, ludo@HIDDEN, matt@HIDDEN, maxim.cournoyer@HIDDEN, guix-patches@HIDDEN. Full text available.
Report forwarded to pelzflorian@HIDDEN, ludo@HIDDEN, matt@HIDDEN, maxim.cournoyer@HIDDEN, guix-patches@HIDDEN:
bug#71022; Package guix-patches. Full text available.
Please note: This is a static page, with minimal formatting, updated once a day.
Click here to see this page with the latest information and nicer formatting.
Last modified: Wed, 22 May 2024 00:30:02 UTC

GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997 nCipher Corporation Ltd, 1994-97 Ian Jackson.