GNU bug report logs - #12939
24.3.50; [PATCH] `icomplete-mode' should respect `completion-ignored-extensions'

Previous Next

To add a comment to this bug, you must first unarchive it, by sending
a message to control AT debbugs.gnu.org, with unarchive 12939 in the body.
You can then email your comments to 12939 AT debbugs.gnu.org in the normal way.

Toggle the display of automated, internal messages from the tracker.

Message #5 received at submit <at> debbugs.gnu.org (full text, mbox):

From: "Drew Adams" <drew.adams <at> oracle.com>
To: <bug-gnu-emacs <at> gnu.org>
Subject: 24.3.50; [PATCH] `icomplete-mode' should respect
	`completion-ignored-extensions'
Date: Mon, 19 Nov 2012 14:15:39 -0800

[Message part 1 (text/plain, inline)]

(setq icomplete-with-completion-tables  t)
 
`icomplete-mode' shows, e.g., names of files ending with `~'.  It should, but it
does not, respect `completion-ignored-extensions'.

This is apparently because `completion-all-sorted-completions' does not respect
it either (which is, however, TRT).

Seems like some other function should be used, which returns all completions
like `completion-all-sorted-completions' does (and like `all-completions' does),
but which also respects `completion-ignored-extensions'.

I see comments in minibuffer.el indicating that this is a more general bug,
which you presumably intend to fix in a more general way.

But this problem for icomplete.el has existed since Emacs 23.1, so why not fix
it there while waiting for an ideal, general solution.  Attached is a patch that
I think DTRT.

(FWIW, I do something similar in icomplete+.el, and it seems to work fine.  I
use `all-completions' instead of `completion-all-sorted-completions', however,
so the call to `completion-pcm--filename-try-filter' need not come after setting
the last cdr to nil.)

[BTW - `completion-pcm--filename-try-filter' should not be considered internal
(internal to what?), IMO.  And it should be renamed.  It has nothing to do with
pcm (or with icompletion, for that matter).  And it really doesn't have anything
particular to do with `all-completions' vs `try-completion'.  All it does is
filter its list arg ALL to make the elements respect
`completion-ignored-extensions'.  It is essentially a remove-if
ignored-extension function - name it accordingly.]

[BTW2 - Remind me again why `icomplete-with-completion-tables' is not a
defcustom?  And why the default value, even for the defvar, is not t?]

In GNU Emacs 24.3.50.1 (i386-mingw-nt5.1.2600)
 of 2012-11-05 on MS-W7-DANI
Bzr revision: 110809 lekktu <at> gmail.com-20121105172930-a5gn0bwi4lndchhw
Windowing system distributor `Microsoft Corp.', version 5.1.2600
Configured using:
 `configure --with-gcc (4.7) --no-opt --enable-checking --cflags
 -I../../libs/libXpm-3.5.10/include -I../../libs/libXpm-3.5.10/src
 -I../../libs/libpng-1.2.37-lib/include -I../../libs/zlib-1.2.5
 -I../../libs/giflib-4.1.4-1-lib/include
 -I../../libs/jpeg-6b-4-lib/include
 -I../../libs/tiff-3.8.2-1-lib/include
 -I../../libs/libxml2-2.7.8-w32-bin/include/libxml2
 -I../../libs/gnutls-3.0.9-w32-bin/include
 -I../../libs/libiconv-1.9.2-1-lib/include'
 

[icomplete-patched-2012-11-19.el (application/octet-stream, attachment)]

Message #8 received at 12939 <at> debbugs.gnu.org (full text, mbox):

From: Lars Ingebrigtsen <larsi <at> gnus.org>
To: "Drew Adams" <drew.adams <at> oracle.com>
Cc: 12939 <at> debbugs.gnu.org
Subject: Re: bug#12939: 24.3.50; [PATCH] `icomplete-mode' should respect
 `completion-ignored-extensions'
Date: Wed, 24 Feb 2016 17:01:33 +1100

"Drew Adams" <drew.adams <at> oracle.com> writes:

> `icomplete-mode' shows, e.g., names of files ending with `~'.  It should, but it
> does not, respect `completion-ignored-extensions'.
>
> This is apparently because `completion-all-sorted-completions' does not respect
> it either (which is, however, TRT).

You included an entire version of icomplete.el, which, of course, can't
be compared for code changes now.

Could you submit a patch for the changes you want to see happen?

-- 
(domestic pets only, the antidote for overdose, milk.)
   bloggy blog: http://lars.ingebrigtsen.no

Message #11 received at 12939 <at> debbugs.gnu.org (full text, mbox):

From: Drew Adams <drew.adams <at> oracle.com>
To: Lars Ingebrigtsen <larsi <at> gnus.org>
Cc: 12939 <at> debbugs.gnu.org
Subject: RE: bug#12939: 24.3.50; [PATCH] `icomplete-mode' should respect
 `completion-ignored-extensions'
Date: Wed, 24 Feb 2016 07:10:22 -0800 (PST)

[Message part 1 (text/plain, inline)]

> > `icomplete-mode' shows, e.g., names of files ending with `~'.  It
> > should, but it does not, respect `completion-ignored-extensions'.
> >
> > This is apparently because `completion-all-sorted-completions'
> > does not respect it either (which is, however, TRT).
> 
> You included an entire version of icomplete.el, which, of course,
> can't be compared for code changes now.
> 
> Could you submit a patch for the changes you want to see happen?

I meant to send the attached 2012 patch; sorry.  Of course, you might
need to adjust something because the code base has probably changed
a bit since 2012. ;-)

[icomplete-2012-11-19.patch (application/octet-stream, attachment)]

Message #14 received at 12939 <at> debbugs.gnu.org (full text, mbox):

From: Lars Ingebrigtsen <larsi <at> gnus.org>
To: Drew Adams <drew.adams <at> oracle.com>
Cc: 12939 <at> debbugs.gnu.org
Subject: Re: bug#12939: 24.3.50; [PATCH] `icomplete-mode' should respect
 `completion-ignored-extensions'
Date: Thu, 28 Apr 2016 19:31:59 +0200

Drew Adams <drew.adams <at> oracle.com> writes:

>> > `icomplete-mode' shows, e.g., names of files ending with `~'.  It
>> > should, but it does not, respect `completion-ignored-extensions'.
>> >
>> > This is apparently because `completion-all-sorted-completions'
>> > does not respect it either (which is, however, TRT).
>> 
>> You included an entire version of icomplete.el, which, of course,
>> can't be compared for code changes now.
>> 
>> Could you submit a patch for the changes you want to see happen?
>
> I meant to send the attached 2012 patch; sorry.  Of course, you might
> need to adjust something because the code base has probably changed
> a bit since 2012. ;-)

Looks fine; applied to the trunk.

-- 
(domestic pets only, the antidote for overdose, milk.)
   bloggy blog: http://lars.ingebrigtsen.no

Previous Next

GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson.