GNU bug report logs - #14524
wisent-javascript-jv-wy--token-table multiple defaults for "no-type"

Previous Next

To add a comment to this bug, you must first unarchive it, by sending
a message to control AT debbugs.gnu.org, with unarchive 14524 in the body.
You can then email your comments to 14524 AT debbugs.gnu.org in the normal way.

Toggle the display of automated, internal messages from the tracker.

Message #3 received at submit <at> debbugs.gnu.org (full text, mbox):

From: Glenn Morris <rgm <at> gnu.org>
To: submit <at> debbugs.gnu.org
Subject: wisent-javascript-jv-wy--token-table multiple defaults for "no-type"
Date: Fri, 31 May 2013 19:52:38 -0400

Package: emacs
Version: 24.3
Severity: minor
User: emacs
Usertags: cedet

Part of the (generated?) code in cedet/semantic/wisent/js-wy.el for
wisent-javascript-jv-wy--token-table doesn't make sense. This part:

("<no-type>"
   (NULL_TOKEN)
   (QUERY)
   (TRUE)
   (FALSE))

is equivalent to:

("<no-type>" (FALSE))

It results in a warning on loading the file (and hence during bootstrap,
since other files require it):

*Warning* default value of <<no-type>> tokens changed to NULL_TOKEN, was QUERY
*Warning* default value of <<no-type>> tokens changed to QUERY, was TRUE
*Warning* default value of <<no-type>> tokens changed to TRUE, was FALSE

It seems that in the arguments of semantic-lex-make-type-table, there
can only be one TOKENS element per TYPE that has no MATCHER, which gets
used for the default. (BTW, this isn't mentioned at all in the doc-string
of semantic-lex-make-type-table AFAICS.)

Also, the warning message is backwards. It should be:

(message "*Warning* default value of <%s> tokens changed to %S, was %S"
    type token default)

ie, `token default' rather than `default token'.

Previous Next

GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson.