GNU bug report logs - #17001
`documentation' fails with void-function help-split-fundoc, due to advice

Previous Next

To add a comment to this bug, you must first unarchive it, by sending
a message to control AT debbugs.gnu.org, with unarchive 17001 in the body.
You can then email your comments to 17001 AT debbugs.gnu.org in the normal way.

Toggle the display of automated, internal messages from the tracker.

Message #3 received at submit <at> debbugs.gnu.org (full text, mbox):

From: Glenn Morris <rgm <at> gnu.org>
To: submit <at> debbugs.gnu.org
Subject: `documentation' fails with void-function help-split-fundoc,
 due to advice
Date: Wed, 12 Mar 2014 16:04:45 -0400

Package: emacs
Version: 24.3.50

Current trunk on GNU/Linux.

emacs -Q
(documentation 'rename-buffer)
  ->  void-function help-split-fundoc

The error comes from advice--make-docstring.

nadvice.el could autoload help-split-fundoc. Since nadvice.el is
preloaded, that's equivalent to sticking an autoload cookie on
help-split-fundoc. Which might be a good thing, since several files
autoload it manually.

Or advice--make-docstring could require help-fns.



PS Presumably the lispref statement "Emacs's own source files should not
put advice on functions in Emacs." no longer applies, since nadvice.el
is preloaded and eg simple.el uses it.

Message #6 received at 17001 <at> debbugs.gnu.org (full text, mbox):

From: Glenn Morris <rgm <at> gnu.org>
To: 17001 <at> debbugs.gnu.org
Subject: Re: bug#17001: `documentation' fails with void-function
 help-split-fundoc, due to advice
Date: Wed, 12 Mar 2014 16:44:16 -0400

Glenn Morris wrote:

> emacs -Q
> (documentation 'rename-buffer)
>   ->  void-function help-split-fundoc

PS I wondered why the byte-compiler does not warn about this.
Seems bytecomp.el now requires help-fns in some cases.
That seems like it could cause precisely this kind of problem.

Message #9 received at 17001 <at> debbugs.gnu.org (full text, mbox):

From: Glenn Morris <rgm <at> gnu.org>
To: 17001 <at> debbugs.gnu.org
Subject: Re: bug#17001: `documentation' fails with void-function
 help-split-fundoc, due to advice
Date: Wed, 12 Mar 2014 17:13:09 -0400

Glenn Morris wrote:

>> emacs -Q
>> (documentation 'rename-buffer)
>>   ->  void-function help-split-fundoc
>
> PS I wondered why the byte-compiler does not warn about this.
> Seems bytecomp.el now requires help-fns in some cases.
> That seems like it could cause precisely this kind of problem.

PPS I see some wise person added related comments to help-fns.el some
time ago; e.g.:

  ;; FIXME: Move to subr.el?
  (defun help-function-arglist (def &optional preserve-names)

(why not to help.el, which is preloaded?)

Message #12 received at 17001 <at> debbugs.gnu.org (full text, mbox):

From: Stefan Monnier <monnier <at> iro.umontreal.ca>
To: Glenn Morris <rgm <at> gnu.org>
Cc: 17001 <at> debbugs.gnu.org
Subject: Re: bug#17001: `documentation' fails with void-function
 help-split-fundoc, due to advice
Date: Thu, 13 Mar 2014 09:36:32 -0400

>   ;; FIXME: Move to subr.el?
>   (defun help-function-arglist (def &optional preserve-names)
> (why not to help.el, which is preloaded?)

help.el sounds good, indeed.


        Stefan

Previous Next

GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson.