GNU bug report logs - #25690
make install-html broken

Previous Next

To add a comment to this bug, you must first unarchive it, by sending
a message to control AT debbugs.gnu.org, with unarchive 25690 in the body.
You can then email your comments to 25690 AT debbugs.gnu.org in the normal way.

Toggle the display of automated, internal messages from the tracker.

Message #5 received at submit <at> debbugs.gnu.org (full text, mbox):

From: Eric Blake <eblake <at> redhat.com>
To: bug-sed <at> gnu.org
Subject: make install-html broken
Date: Sat, 11 Feb 2017 09:18:11 -0600

[Message part 1 (text/plain, inline)]

Attempts to do 'make install-html' fail with:

make[1]: Leaving directory '/usr/src/sed-4.4-1.i686/build'
Making install-html in po
make[1]: Entering directory '/usr/src/sed-4.4-1.i686/build/po'
make[1]: *** No rule to make target 'install-html'.  Stop.
make[1]: Leaving directory '/usr/src/sed-4.4-1.i686/build/po'
make: *** [Makefile:3027: install-html-recursive] Error 1

Prior to sed 4.3, this didn't matter - you could work around the problem
by using 'make -C doc install-html'.  But with the addition of commit
3b29bece converting to non-recursive makefiles, there is now no
doc/Makefile, and therefore no way to install the html.  I'm not quite
sure of the best way to get po/Makefile to support a no-op install-html
target.

-- 
Eric Blake   eblake redhat com    +1-919-301-3266
Libvirt virtualization library http://libvirt.org

[signature.asc (application/pgp-signature, attachment)]

Message #8 received at 25690 <at> debbugs.gnu.org (full text, mbox):

From: Assaf Gordon <assafgordon <at> gmail.com>
To: Eric Blake <eblake <at> redhat.com>
Cc: 25690 <at> debbugs.gnu.org
Subject: Re: bug#25690: make install-html broken
Date: Sat, 11 Feb 2017 21:52:33 +0000

Hello Eric,

On Sat, Feb 11, 2017 at 09:18:11AM -0600, Eric Blake wrote:
>Attempts to do 'make install-html' fail with:
>
>make[1]: Leaving directory '/usr/src/sed-4.4-1.i686/build'
>Making install-html in po
>make[1]: Entering directory '/usr/src/sed-4.4-1.i686/build/po'
>make[1]: *** No rule to make target 'install-html'.  Stop.
>make[1]: Leaving directory '/usr/src/sed-4.4-1.i686/build/po'
>make: *** [Makefile:3027: install-html-recursive] Error 1
>
>Prior to sed 4.3, this didn't matter - you could work around the problem
>by using 'make -C doc install-html'.  But with the addition of commit
>3b29bece converting to non-recursive makefiles, there is now no
>doc/Makefile, and therefore no way to install the html.  I'm not quite
>sure of the best way to get po/Makefile to support a no-op install-html
>target.

The switch to non-recursive makefiles was modeld as closely as
possible after coreutils, and I see the same error when trying
'make install-html' in coreutils.

Not that this makes it OK, but it hints that this is not
specific problem in sed's build system.

If there's a suggested solution, I'm happy to use it.
Otherwise, I'll try to dig in and see how to fix it,
but it might take a bit longer.

regards,
- assaf

Message #11 received at 25690 <at> debbugs.gnu.org (full text, mbox):

From: Eric Blake <eblake <at> redhat.com>
To: Assaf Gordon <assafgordon <at> gmail.com>
Cc: 25690 <at> debbugs.gnu.org, bug-gettext <at> gnu.org
Subject: Re: bug#25690: make install-html broken
Date: Mon, 13 Feb 2017 11:23:46 -0600

[Message part 1 (text/plain, inline)]

On 02/11/2017 03:52 PM, Assaf Gordon wrote:

>> Attempts to do 'make install-html' fail with:
>>
>> make[1]: Leaving directory '/usr/src/sed-4.4-1.i686/build'
>> Making install-html in po
>> make[1]: Entering directory '/usr/src/sed-4.4-1.i686/build/po'
>> make[1]: *** No rule to make target 'install-html'.  Stop.
>> make[1]: Leaving directory '/usr/src/sed-4.4-1.i686/build/po'
>> make: *** [Makefile:3027: install-html-recursive] Error 1

> The switch to non-recursive makefiles was modeld as closely as
> possible after coreutils, and I see the same error when trying
> 'make install-html' in coreutils.
> 
> Not that this makes it OK, but it hints that this is not
> specific problem in sed's build system.

I worked around it while packaging sed for Cygwin by doing:

--- origsrc/sed-4.4/po/Makefile.in.in   2017-02-03 19:15:46.000000000 -0600
+++ src/sed-4.4/po/Makefile.in.in       2017-02-11 09:30:51.544239400 -0600
@@ -473,3 +473,5 @@ force:
 # Tell versions [3.59,3.63) of GNU make not to export all variables.
 # Otherwise a system limit (for SysV at least) may be exceeded.
 .NOEXPORT:
+
+install-html:

so maybe that argues that the bootstrap process should tweak
po/Makefile.in.in and/or makevars in such a manner.  I don't know if it
is a weakness of gettext in general that it's makefiles do not play
nicely with all of the usual supported targets.

> 
> If there's a suggested solution, I'm happy to use it.
> Otherwise, I'll try to dig in and see how to fix it,
> but it might take a bit longer.

Maybe one of the gettext developers has an idea, since it is the
generated po/Makefile that needs the tweak?  Adding them in cc.

-- 
Eric Blake   eblake redhat com    +1-919-301-3266
Libvirt virtualization library http://libvirt.org

[signature.asc (application/pgp-signature, attachment)]

Message #14 received at 25690 <at> debbugs.gnu.org (full text, mbox):

From: Assaf Gordon <assafgordon <at> gmail.com>
To: Eric Blake <eblake <at> redhat.com>
Cc: 25690 <at> debbugs.gnu.org, bug-gettext <at> gnu.org
Subject: Re: bug#25690: make install-html broken
Date: Wed, 15 Feb 2017 15:50:04 +0000

Hello Eric and all,

On Mon, Feb 13, 2017 at 11:23:46AM -0600, Eric Blake wrote:
>>> Attempts to do 'make install-html' fail with:
>
>I worked around it while packaging sed for Cygwin by doing:
>
>--- origsrc/sed-4.4/po/Makefile.in.in   2017-02-03 19:15:46.000000000 -0600
>+++ src/sed-4.4/po/Makefile.in.in       2017-02-11 09:30:51.544239400 -0600
>@@ -473,3 +473,5 @@ force:
> # Tell versions [3.59,3.63) of GNU make not to export all variables.
> # Otherwise a system limit (for SysV at least) may be exceeded.
> .NOEXPORT:
>+
>+install-html:
>
>so maybe that argues that the bootstrap process should tweak
>po/Makefile.in.in and/or makevars in such a manner.  I don't know if it
>is a weakness of gettext in general that it's makefiles do not play
>nicely with all of the usual supported targets.

Thanks for the fix.

I think 'po/Makefile.in.in' is not a checked-in file
(it's autogenerated during the bootstrapping process),
so this patch is good for the tarballs, but not for the git
repositories.

I do see that projects the use gnulib with non-recursive makefiles
include gnulib's 'non-recursive-gnulib-prefix-hack' module
and contain this in 'bootstrap.conf':

   bootstrap_post_import_hook ()
   {
       ...
       # Massage lib/gnulib.mk before using it later in the bootstrapping process.
       build-aux/prefix-gnulib-mk --lib-name=$gnulib_name lib/$gnulib_mk
   }

So perhaps that would be a good place to
patch Makefile.in.in as you suggested ?

regards,
- assaf

Message #17 received at 25690 <at> debbugs.gnu.org (full text, mbox):

From: Bruno Haible <bruno <at> clisp.org>
To: bug-gettext <at> gnu.org
Cc: 25690 <at> debbugs.gnu.org, Assaf Gordon <assafgordon <at> gmail.com>,
 Eric Blake <eblake <at> redhat.com>
Subject: Re: [bug-gettext] bug#25690: make install-html broken
Date: Thu, 16 Feb 2017 15:29:28 +0100

Hello Eric and Assaf,

Eric, thanks for the report.
Assaf, thanks for the forward to bug-gettext.

> Making install-html in po
> make[1]: Entering directory '/usr/src/sed-4.4-1.i686/build/po'
> make[1]: *** No rule to make target 'install-html'.  Stop.

Fixed in gettext git:
http://git.savannah.gnu.org/gitweb/?p=gettext.git;a=commit;h=e5a008ae54ffa54a5343632f88f10ba2e63c4595

These targets install-{dvi,ps,pdf,html} are mandated by GNU standards,
and for more than 12 years Automake reports them as supported:
  - New targets mandated by GNU Coding Standards:
      install-dvi
      install-html
      install-ps
      install-pdf
And since then, they don't work on packages with a po/ directory. Oh well.

> I do see that projects the use gnulib with non-recursive makefiles
> include gnulib's 'non-recursive-gnulib-prefix-hack' module
> and contain this in 'bootstrap.conf':
> 
>     bootstrap_post_import_hook ()
>     {

Many more packages use gettext's po/Makefile.in.in than those that use
gnulib's 'bootstrap'.

Bruno

Message #20 received at 25690 <at> debbugs.gnu.org (full text, mbox):

From: Eric Blake <eblake <at> redhat.com>
To: Bruno Haible <bruno <at> clisp.org>, bug-gettext <at> gnu.org
Cc: 25690 <at> debbugs.gnu.org, Assaf Gordon <assafgordon <at> gmail.com>
Subject: Re: bug#25690: [bug-gettext] bug#25690: make install-html broken
Date: Thu, 16 Feb 2017 09:29:42 -0600

[Message part 1 (text/plain, inline)]

On 02/16/2017 08:29 AM, Bruno Haible wrote:
> 
>> I do see that projects the use gnulib with non-recursive makefiles
>> include gnulib's 'non-recursive-gnulib-prefix-hack' module
>> and contain this in 'bootstrap.conf':
>>
>>     bootstrap_post_import_hook ()
>>     {
> 
> Many more packages use gettext's po/Makefile.in.in than those that use
> gnulib's 'bootstrap'.

But until the new gettext release is widely available prior to the
creation of tarballs, the gnulib hack is at least useful for creating
working tarballs with an older gettext installed.

-- 
Eric Blake   eblake redhat com    +1-919-301-3266
Libvirt virtualization library http://libvirt.org

[signature.asc (application/pgp-signature, attachment)]

Message #23 received at 25690 <at> debbugs.gnu.org (full text, mbox):

From: Assaf Gordon <assafgordon <at> gmail.com>
To: Eric Blake <eblake <at> redhat.com>
Cc: 25690 <at> debbugs.gnu.org, Bruno Haible <bruno <at> clisp.org>, bug-gettext <at> gnu.org
Subject: Re: bug#25690: make install-html broken
Date: Thu, 16 Feb 2017 23:21:23 +0000

[Message part 1 (text/plain, inline)]

Hello Eric and all,

On Thu, Feb 16, 2017 at 09:29:42AM -0600, Eric Blake wrote:
>But until the new gettext release is widely available prior to the
>creation of tarballs, the gnulib hack is at least useful for creating
>working tarballs with an older gettext installed.
>


I just noticed that sed's 'bootstrap.conf' already patches 
po/Makefile.in.in (and coreutils' too).

So there's already a Right Place to do so :)

How about the following patch (perhaps for coreutils as well) ?

regards,
- assaf

[0001-build-fix-install-html-target.patch (text/x-diff, attachment)]

Message #26 received at 25690 <at> debbugs.gnu.org (full text, mbox):

From: Jim Meyering <jim <at> meyering.net>
To: Assaf Gordon <assafgordon <at> gmail.com>
Cc: Bruno Haible <bruno <at> clisp.org>, 25690 <at> debbugs.gnu.org,
 Eric Blake <eblake <at> redhat.com>, bug-gettext <at> gnu.org
Subject: Re: bug#25690: make install-html broken
Date: Thu, 16 Feb 2017 16:20:13 -0800

On Thu, Feb 16, 2017 at 3:21 PM, Assaf Gordon <assafgordon <at> gmail.com> wrote:
> Hello Eric and all,
>
> On Thu, Feb 16, 2017 at 09:29:42AM -0600, Eric Blake wrote:
>>
>> But until the new gettext release is widely available prior to the
>> creation of tarballs, the gnulib hack is at least useful for creating
>> working tarballs with an older gettext installed.
>>
>
>
> I just noticed that sed's 'bootstrap.conf' already patches po/Makefile.in.in
> (and coreutils' too).
>
> So there's already a Right Place to do so :)
>
> How about the following patch (perhaps for coreutils as well) ?

Thank you for doing that.
I like it.  In case you'd prefer a slightly different spelling:

$ printf 'install-%s:;\n' dvi ps pdf html
install-dvi:;
install-ps:;
install-pdf:;
install-html:;

Message #29 received at 25690 <at> debbugs.gnu.org (full text, mbox):

From: Assaf Gordon <assafgordon <at> gmail.com>
To: Jim Meyering <jim <at> meyering.net>
Cc: Bruno Haible <bruno <at> clisp.org>, 25690 <at> debbugs.gnu.org,
 Eric Blake <eblake <at> redhat.com>, bug-gettext <at> gnu.org
Subject: Re: bug#25690: make install-html broken
Date: Thu, 16 Feb 2017 21:12:47 -0500

tags 25690 fixed
close 25690
stop


Thanks for the review.
Pushed (with your suggestion) here:
https://git.savannah.gnu.org/cgit/sed.git/commit/?id=75e5a9b6


regards,
 - assaf

Previous Next

GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson.