GNU bug report logs - #27202
26.0.50; Eldoc mode not enabled in minibuffer

Previous Next

To add a comment to this bug, you must first unarchive it, by sending
a message to control AT debbugs.gnu.org, with unarchive 27202 in the body.
You can then email your comments to 27202 AT debbugs.gnu.org in the normal way.

Toggle the display of automated, internal messages from the tracker.

Message #5 received at submit <at> debbugs.gnu.org (full text, mbox):

From: Stephen Berman <stephen.berman <at> gmx.net>
To: bug-gnu-emacs <at> gnu.org
Subject: 26.0.50; Eldoc mode is broken
Date: Fri, 02 Jun 2017 21:53:18 +0200

0. emacs -Q
1. M-: (car SPC
=> No function signature in the mode line, whereas before the breakage
   the mode line would display this:
   car: (LIST)

Git bisect says:

2349f1df1b11381c421287670ffd0f84725d7818 is the first bad commit
commit 2349f1df1b11381c421287670ffd0f84725d7818
Author: Dmitry Gutov <dgutov <at> yandex.ru>
Date:   Tue May 30 02:55:28 2017 +0300

    Turn global-eldoc-mode into a globalized minor mode
    
    * lisp/emacs-lisp/eldoc.el (global-eldoc-mode):
    Turn into globalized mode (bug#19853).
    (turn-on-eldoc-mode): Make it into a wrapper instead of alias.
    (eldoc-mode): Only show the message when called interactively.


In GNU Emacs 26.0.50 (build 36, x86_64-pc-linux-gnu, GTK+ Version 3.22.8)
 of 2017-06-01 built on rosalinde
Repository revision: 5dc0129c299f6cc7a0bdfbf7edc92a85bb3a0597
Windowing system distributor 'The X.Org Foundation', version 11.0.11901000

Configured using:
 'configure 'CFLAGS=-Og -g3''

Configured features:
XPM JPEG TIFF GIF PNG RSVG IMAGEMAGICK SOUND GPM DBUS GSETTINGS NOTIFY
ACL GNUTLS LIBXML2 FREETYPE M17N_FLT LIBOTF XFT ZLIB TOOLKIT_SCROLL_BARS
GTK3 X11

Important settings:
  value of $LANG: en_US.UTF-8
  locale-coding-system: utf-8-unix

Message #8 received at 27202 <at> debbugs.gnu.org (full text, mbox):

From: Dmitry Gutov <dgutov <at> yandex.ru>
To: Stephen Berman <stephen.berman <at> gmx.net>, 27202 <at> debbugs.gnu.org
Subject: Re: bug#27202: 26.0.50; Eldoc mode is broken
Date: Sat, 3 Jun 2017 00:18:33 +0300

On 6/2/17 10:53 PM, Stephen Berman wrote:
> 0. emacs -Q
> 1. M-: (car SPC
> => No function signature in the mode line, whereas before the breakage
>     the mode line would display this:
>     car: (LIST)

Please try 'make bootstrap'. It also stopped working on my machine until 
I've done that.

Maybe because of ':initialize 'custom-initialize-delay'.

Message #11 received at 27202 <at> debbugs.gnu.org (full text, mbox):

From: Stephen Berman <stephen.berman <at> gmx.net>
To: Dmitry Gutov <dgutov <at> yandex.ru>
Cc: 27202 <at> debbugs.gnu.org
Subject: Re: bug#27202: 26.0.50; Eldoc mode is broken
Date: Sat, 03 Jun 2017 00:16:25 +0200

On Sat, 3 Jun 2017 00:18:33 +0300 Dmitry Gutov <dgutov <at> yandex.ru> wrote:

> On 6/2/17 10:53 PM, Stephen Berman wrote:
>> 0. emacs -Q
>> 1. M-: (car SPC
>> => No function signature in the mode line, whereas before the breakage
>>     the mode line would display this:
>>     car: (LIST)
>
> Please try 'make bootstrap'. It also stopped working on my machine until I've
> done that.

Boostrapping latest master didn't fix it here.

Steve Berman

Message #14 received at 27202 <at> debbugs.gnu.org (full text, mbox):

From: Stephen Berman <stephen.berman <at> gmx.net>
To: Dmitry Gutov <dgutov <at> yandex.ru>
Cc: 27202 <at> debbugs.gnu.org
Subject: Re: bug#27202: 26.0.50; Eldoc mode is broken
Date: Sat, 03 Jun 2017 00:47:22 +0200

On Sat, 03 Jun 2017 00:16:25 +0200 Stephen Berman <stephen.berman <at> gmx.net> wrote:

> On Sat, 3 Jun 2017 00:18:33 +0300 Dmitry Gutov <dgutov <at> yandex.ru> wrote:
>
>> On 6/2/17 10:53 PM, Stephen Berman wrote:
>>> 0. emacs -Q
>>> 1. M-: (car SPC
>>> => No function signature in the mode line, whereas before the breakage
>>>     the mode line would display this:
>>>     car: (LIST)
>>
>> Please try 'make bootstrap'. It also stopped working on my machine until I've
>> done that.
>
> Boostrapping latest master didn't fix it here.

I manually reverted this part of 2349f1df1b:

-(define-minor-mode global-eldoc-mode
-  "Toggle Global Eldoc mode on or off.
-With a prefix argument ARG, enable Global Eldoc mode if ARG is
-positive, and disable it otherwise.  If called from Lisp, enable
-the mode if ARG is omitted or nil, and toggle it if ARG is ‘toggle’.
-
-If Global Eldoc mode is on, `eldoc-mode' will be enabled in all
-buffers where it's applicable.  These are buffers that have modes
-that have enabled eldoc support.  See `eldoc-documentation-function'."
+(define-globalized-minor-mode global-eldoc-mode eldoc-mode turn-on-eldoc-mode
   :group 'eldoc
-  :global t
   :initialize 'custom-initialize-delay
-  :init-value t
-  (setq eldoc-last-message nil)
-  (if global-eldoc-mode
-      (progn
-	(add-hook 'post-command-hook #'eldoc-schedule-timer)
-	(add-hook 'pre-command-hook #'eldoc-pre-command-refresh-echo-area))
-    (remove-hook 'post-command-hook #'eldoc-schedule-timer)
-    (remove-hook 'pre-command-hook #'eldoc-pre-command-refresh-echo-area)))
+  :init-value t)

then rebuilt Emacs (just make, not bootstrap), and now Eldoc in the
modeline works here again.

Steve Berman

Message #17 received at 27202 <at> debbugs.gnu.org (full text, mbox):

From: Dmitry Gutov <dgutov <at> yandex.ru>
To: Stephen Berman <stephen.berman <at> gmx.net>
Cc: 27202 <at> debbugs.gnu.org
Subject: Re: bug#27202: 26.0.50; Eldoc mode is broken
Date: Sat, 3 Jun 2017 02:05:49 +0300

On 6/3/17 1:47 AM, Stephen Berman wrote:

>> Boostrapping latest master didn't fix it here.
> 
> I manually reverted this part of 2349f1df1b:

So basically all of it.

> -(define-minor-mode global-eldoc-mode
> -  "Toggle Global Eldoc mode on or off.
> -With a prefix argument ARG, enable Global Eldoc mode if ARG is
> -positive, and disable it otherwise.  If called from Lisp, enable
> -the mode if ARG is omitted or nil, and toggle it if ARG is ‘toggle’.
> -
> -If Global Eldoc mode is on, `eldoc-mode' will be enabled in all
> -buffers where it's applicable.  These are buffers that have modes
> -that have enabled eldoc support.  See `eldoc-documentation-function'."
> +(define-globalized-minor-mode global-eldoc-mode eldoc-mode turn-on-eldoc-mode
>     :group 'eldoc
> -  :global t
>     :initialize 'custom-initialize-delay
> -  :init-value t
> -  (setq eldoc-last-message nil)
> -  (if global-eldoc-mode
> -      (progn
> -	(add-hook 'post-command-hook #'eldoc-schedule-timer)
> -	(add-hook 'pre-command-hook #'eldoc-pre-command-refresh-echo-area))
> -    (remove-hook 'post-command-hook #'eldoc-schedule-timer)
> -    (remove-hook 'pre-command-hook #'eldoc-pre-command-refresh-echo-area)))
> +  :init-value t)
> 
> then rebuilt Emacs (just make, not bootstrap), and now Eldoc in the
> modeline works here again.

Do you have an explanation why one version of the code works, and 
another doesn't?

Message #20 received at 27202 <at> debbugs.gnu.org (full text, mbox):

From: Dmitry Gutov <dgutov <at> yandex.ru>
To: Stephen Berman <stephen.berman <at> gmx.net>
Cc: 27202 <at> debbugs.gnu.org
Subject: Re: bug#27202: 26.0.50; Eldoc mode is broken
Date: Sat, 3 Jun 2017 02:08:15 +0300

>> On 6/2/17 10:53 PM, Stephen Berman wrote:
>>> 0. emacs -Q
>>> 1. M-: (car SPC
>>> => No function signature in the mode line, whereas before the breakage
>>>      the mode line would display this:
>>>      car: (LIST)

> Boostrapping latest master didn't fix it here.

All right, I see this. So it's specifically broken in the minibuffer? 
Not everywhere?

Message #23 received at 27202 <at> debbugs.gnu.org (full text, mbox):

From: Stephen Berman <stephen.berman <at> gmx.net>
To: Dmitry Gutov <dgutov <at> yandex.ru>
Cc: 27202 <at> debbugs.gnu.org
Subject: Re: bug#27202: 26.0.50; Eldoc mode is broken
Date: Sat, 03 Jun 2017 01:20:30 +0200

On Sat, 3 Jun 2017 02:08:15 +0300 Dmitry Gutov <dgutov <at> yandex.ru> wrote:

>>> On 6/2/17 10:53 PM, Stephen Berman wrote:
>>>> 0. emacs -Q
>>>> 1. M-: (car SPC
>>>> => No function signature in the mode line, whereas before the breakage
>>>>      the mode line would display this:
>>>>      car: (LIST)
>
>> Boostrapping latest master didn't fix it here.
>
> All right, I see this. So it's specifically broken in the minibuffer? Not
> everywhere?

Right, with M-: there's no Eldoc message in the modeline; in an .el file
or *scratch*, the Eldoc message does appear in the echo area.  Sorry for
not be clear about that in my OP.

Steve Berman

Message #26 received at 27202 <at> debbugs.gnu.org (full text, mbox):

From: Stephen Berman <stephen.berman <at> gmx.net>
To: Dmitry Gutov <dgutov <at> yandex.ru>
Cc: 27202 <at> debbugs.gnu.org
Subject: Re: bug#27202: 26.0.50; Eldoc mode is broken
Date: Sat, 03 Jun 2017 01:21:21 +0200

On Sat, 3 Jun 2017 02:05:49 +0300 Dmitry Gutov <dgutov <at> yandex.ru> wrote:

> On 6/3/17 1:47 AM, Stephen Berman wrote:
>
>>> Boostrapping latest master didn't fix it here.
>>
>> I manually reverted this part of 2349f1df1b:
>
> So basically all of it.
>
>> -(define-minor-mode global-eldoc-mode
>> -  "Toggle Global Eldoc mode on or off.
>> -With a prefix argument ARG, enable Global Eldoc mode if ARG is
>> -positive, and disable it otherwise.  If called from Lisp, enable
>> -the mode if ARG is omitted or nil, and toggle it if ARG is ‘toggle’.
>> -
>> -If Global Eldoc mode is on, `eldoc-mode' will be enabled in all
>> -buffers where it's applicable.  These are buffers that have modes
>> -that have enabled eldoc support.  See `eldoc-documentation-function'."
>> +(define-globalized-minor-mode global-eldoc-mode eldoc-mode turn-on-eldoc-mode
>>     :group 'eldoc
>> -  :global t
>>     :initialize 'custom-initialize-delay
>> -  :init-value t
>> -  (setq eldoc-last-message nil)
>> -  (if global-eldoc-mode
>> -      (progn
>> -	(add-hook 'post-command-hook #'eldoc-schedule-timer)
>> -	(add-hook 'pre-command-hook #'eldoc-pre-command-refresh-echo-area))
>> -    (remove-hook 'post-command-hook #'eldoc-schedule-timer)
>> -    (remove-hook 'pre-command-hook #'eldoc-pre-command-refresh-echo-area)))
>> +  :init-value t)
>>
>> then rebuilt Emacs (just make, not bootstrap), and now Eldoc in the
>> modeline works here again.
>
> Do you have an explanation why one version of the code works, and another
> doesn't?

No, I don't really know anything about how define-globalized-minor-mode
works, or Eldoc either, for that matter.

Steve Berman

Message #29 received at 27202 <at> debbugs.gnu.org (full text, mbox):

From: Dmitry Gutov <dgutov <at> yandex.ru>
To: Stephen Berman <stephen.berman <at> gmx.net>
Cc: 27202 <at> debbugs.gnu.org, Stefan Monnier <monnier <at> IRO.UMontreal.CA>
Subject: Re: bug#27202: 26.0.50; Eldoc mode is broken
Date: Sat, 3 Jun 2017 02:53:17 +0300

On 6/3/17 2:20 AM, Stephen Berman wrote:

>> All right, I see this. So it's specifically broken in the minibuffer? Not
>> everywhere?
> 
> Right, with M-: there's no Eldoc message in the modeline; in an .el file
> or *scratch*, the Eldoc message does appear in the echo area.  Sorry for
> not be clear about that in my OP.

Thanks.

The patch below seems to fix it.

Also Ccing Stefan: should we do it this way?

diff --git a/lisp/simple.el b/lisp/simple.el
index ea3a495..df664fc 100644
--- a/lisp/simple.el
+++ b/lisp/simple.el
@@ -1484,6 +1484,7 @@ read--expression
           ;; FIXME: call emacs-lisp-mode?
           (add-function :before-until (local 
'eldoc-documentation-function)
                         #'elisp-eldoc-documentation-function)
+          (eldoc-mode 1)
           (add-hook 'completion-at-point-functions
                     #'elisp-completion-at-point nil t)
           (run-hooks 'eval-expression-minibuffer-setup-hook))

Message #38 received at 27202 <at> debbugs.gnu.org (full text, mbox):

From: Stephen Berman <stephen.berman <at> gmx.net>
To: Dmitry Gutov <dgutov <at> yandex.ru>
Cc: 27202 <at> debbugs.gnu.org
Subject: Re: bug#27202: 26.0.50; Eldoc mode is broken
Date: Sat, 03 Jun 2017 10:59:15 +0200

On Sat, 3 Jun 2017 02:53:17 +0300 Dmitry Gutov <dgutov <at> yandex.ru> wrote:

> On 6/3/17 2:20 AM, Stephen Berman wrote:
>
>>> All right, I see this. So it's specifically broken in the minibuffer? Not
>>> everywhere?
>>
>> Right, with M-: there's no Eldoc message in the modeline; in an .el file
>> or *scratch*, the Eldoc message does appear in the echo area.  Sorry for
>> not be clear about that in my OP.
>
> Thanks.
>
> The patch below seems to fix it.

That works for me here, too; thanks.

Steve Berman

Message #43 received at 27202-done <at> debbugs.gnu.org (full text, mbox):

From: Dmitry Gutov <dgutov <at> yandex.ru>
To: Stephen Berman <stephen.berman <at> gmx.net>
Cc: 27202-done <at> debbugs.gnu.org
Subject: Re: bug#27202: 26.0.50; Eldoc mode is broken
Date: Tue, 6 Jun 2017 01:05:20 +0300

On 6/3/17 11:59 AM, Stephen Berman wrote:

> That works for me here, too; thanks.

Thanks for testing.

Installed, since there were no objections from anyone.

Previous Next

GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson.