GNU bug report logs - #28385
ert "should" macros to not be globally visible

Previous Next

To add a comment to this bug, you must first unarchive it, by sending
a message to control AT debbugs.gnu.org, with unarchive 28385 in the body.
You can then email your comments to 28385 AT debbugs.gnu.org in the normal way.

Toggle the display of automated, internal messages from the tracker.

Message #3 received at submit <at> debbugs.gnu.org (full text, mbox):

From: Glenn Morris <rgm <at> gnu.org>
To: submit <at> debbugs.gnu.org
Subject: ert "should" macros to not be globally visible
Date: Thu, 07 Sep 2017 14:24:02 -0400

Package: emacs
Version: 25.2
Severity: wishlist

emacs -Q -l ert

Now "should", "should-not", and "should-error" are globally defined as
macros (with no "ert-" prefix). They are only useful inside ert-deftests.
Perhaps they should steal a trick from the similar "skip-unless", which
is not globally visible. The global definition is "ert--skip-unless",
and the ert-deftest macro basically makes "skip-unless" an alias for
this inside the body of a test. This seems cleaner.

Message #6 received at 28385 <at> debbugs.gnu.org (full text, mbox):

From: Lars Ingebrigtsen <larsi <at> gnus.org>
To: Glenn Morris <rgm <at> gnu.org>
Cc: 28385 <at> debbugs.gnu.org
Subject: Re: bug#28385: ert "should" macros to not be globally visible
Date: Mon, 15 Jul 2019 13:01:10 +0200

Glenn Morris <rgm <at> gnu.org> writes:

> Now "should", "should-not", and "should-error" are globally defined as
> macros (with no "ert-" prefix). They are only useful inside ert-deftests.
> Perhaps they should steal a trick from the similar "skip-unless", which
> is not globally visible. The global definition is "ert--skip-unless",
> and the ert-deftest macro basically makes "skip-unless" an alias for
> this inside the body of a test. This seems cleaner.

When writing tests, I find it convenient that I can `C-x C-e'

  (should ...)

terms.  I mean, I could just `C-x C-e' the insides of the form instead,
but still...

-- 
(domestic pets only, the antidote for overdose, milk.)
   bloggy blog: http://lars.ingebrigtsen.no

Message #9 received at 28385 <at> debbugs.gnu.org (full text, mbox):

From: Stefan Kangas <stefan <at> marxist.se>
To: Lars Ingebrigtsen <larsi <at> gnus.org>
Cc: Glenn Morris <rgm <at> gnu.org>, 28385 <at> debbugs.gnu.org
Subject: Re: bug#28385: ert "should" macros to not be globally visible
Date: Sun, 29 Sep 2019 03:26:17 +0200

Lars Ingebrigtsen <larsi <at> gnus.org> writes:

> Glenn Morris <rgm <at> gnu.org> writes:
>
>> Now "should", "should-not", and "should-error" are globally defined as
>> macros (with no "ert-" prefix). They are only useful inside ert-deftests.
>> Perhaps they should steal a trick from the similar "skip-unless", which
>> is not globally visible. The global definition is "ert--skip-unless",
>> and the ert-deftest macro basically makes "skip-unless" an alias for
>> this inside the body of a test. This seems cleaner.
>
> When writing tests, I find it convenient that I can `C-x C-e'
>
>   (should ...)
>
> terms.  I mean, I could just `C-x C-e' the insides of the form instead,
> but still...

I agree; I do this all the time when developing tests.  C-x C-e inside
the form doesn't help much e.g. when you have a let form doing some
setup that contains multiple should statements.  (See
test/lisp/bookmark-tests.el for an example.)

With all due respect to Glenn, I would suggest to close this as wontfix.

Best regards,
Stefan Kangas

Message #12 received at 28385 <at> debbugs.gnu.org (full text, mbox):

From: Stefan Kangas <stefan <at> marxist.se>
To: Lars Ingebrigtsen <larsi <at> gnus.org>
Cc: Glenn Morris <rgm <at> gnu.org>, 28385 <at> debbugs.gnu.org
Subject: Re: bug#28385: ert "should" macros to not be globally visible
Date: Mon, 10 Aug 2020 09:58:50 -0700

tags 28385 + wontfix notabug
close 28385
thanks

Stefan Kangas <stefan <at> marxist.se> writes:

> Lars Ingebrigtsen <larsi <at> gnus.org> writes:
>
>> Glenn Morris <rgm <at> gnu.org> writes:
>>
>>> Now "should", "should-not", and "should-error" are globally defined as
>>> macros (with no "ert-" prefix). They are only useful inside ert-deftests.
>>> Perhaps they should steal a trick from the similar "skip-unless", which
>>> is not globally visible. The global definition is "ert--skip-unless",
>>> and the ert-deftest macro basically makes "skip-unless" an alias for
>>> this inside the body of a test. This seems cleaner.
>>
>> When writing tests, I find it convenient that I can `C-x C-e'
>>
>>   (should ...)
>>
>> terms.  I mean, I could just `C-x C-e' the insides of the form instead,
>> but still...
>
> I agree; I do this all the time when developing tests.  C-x C-e inside
> the form doesn't help much e.g. when you have a let form doing some
> setup that contains multiple should statements.  (See
> test/lisp/bookmark-tests.el for an example.)
>
> With all due respect to Glenn, I would suggest to close this as wontfix.

No further comments within 45 weeks, so I'm closing this now.

Feel free to reopen if you disagree and we can discuss it.

Best regards,
Stefan Kangas

Previous Next

GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson.