GNU bug report logs - #29192
26.0.90; flymake-warning's default color might be inappropriate

Previous Next

To add a comment to this bug, you must first unarchive it, by sending
a message to control AT debbugs.gnu.org, with unarchive 29192 in the body.
You can then email your comments to 29192 AT debbugs.gnu.org in the normal way.

Toggle the display of automated, internal messages from the tracker.

Message #5 received at submit <at> debbugs.gnu.org (full text, mbox):

From: Dmitry Gutov <dgutov <at> yandex.ru>
To: bug-gnu-emacs <at> gnu.org
Subject: 26.0.90; flymake-warning's default color might be inappropriate
Date: Tue, 7 Nov 2017 16:49:11 +0200

I've never seen this discussed, and this might be a subjective opinion.

But AFAICT, the flymake-warnline face, previously, used DarkOrange (now
it's an obsolete alias). Flycheck also uses this color for warnings.

Flymake's own fringe indicators (for warning) also use an orange color
by default, inheriting it from the `warning' face through
`compilation-warning'.

So I think that flymake-warning should use it as well.

The current blue is pretty and all, but it conveys an optimistic mood,
not something I would associate with a warning.

+++

In GNU Emacs 26.0.90 (build 5, x86_64-pc-linux-gnu, GTK+ Version 3.22.11)
 of 2017-11-07 built on zappa
Repository revision: ca2d94ba61dee678f85bfc7299d167e7219e6d8f
Windowing system distributor 'The X.Org Foundation', version 11.0.11903000
System Description:	Ubuntu 17.04

Message #8 received at 29192 <at> debbugs.gnu.org (full text, mbox):

From: Stefan Kangas <stefan <at> marxist.se>
To: Dmitry Gutov <dgutov <at> yandex.ru>
Cc: 29192 <at> debbugs.gnu.org
Subject: Re: bug#29192: 26.0.90;
 flymake-warning's default color might be inappropriate
Date: Mon, 10 Aug 2020 09:25:34 -0700

Dmitry Gutov <dgutov <at> yandex.ru> writes:

> I've never seen this discussed, and this might be a subjective opinion.
>
> But AFAICT, the flymake-warnline face, previously, used DarkOrange (now
> it's an obsolete alias). Flycheck also uses this color for warnings.
>
> Flymake's own fringe indicators (for warning) also use an orange color
> by default, inheriting it from the `warning' face through
> `compilation-warning'.
>
> So I think that flymake-warning should use it as well.
>
> The current blue is pretty and all, but it conveys an optimistic mood,
> not something I would associate with a warning.

Make sense.  Could you make that change?

Best regards,
Stefan Kangas

Message #11 received at 29192 <at> debbugs.gnu.org (full text, mbox):

From: Dmitry Gutov <dgutov <at> yandex.ru>
To: Stefan Kangas <stefan <at> marxist.se>
Cc: 29192 <at> debbugs.gnu.org
Subject: Re: bug#29192: 26.0.90; flymake-warning's default color might be
 inappropriate
Date: Tue, 11 Aug 2020 02:25:24 +0300

Hi Stefan,

On 10.08.2020 19:25, Stefan Kangas wrote:
>> But AFAICT, the flymake-warnline face, previously, used DarkOrange (now
>> it's an obsolete alias). Flycheck also uses this color for warnings.
>>
>> Flymake's own fringe indicators (for warning) also use an orange color
>> by default, inheriting it from the `warning' face through
>> `compilation-warning'.
>>
>> So I think that flymake-warning should use it as well.
>>
>> The current blue is pretty and all, but it conveys an optimistic mood,
>> not something I would associate with a warning.
> Make sense.  Could you make that change?

Thank you for the response, but I have warmed up to this new color in 
the years since the change was made. Maybe not very indicative of being 
a warning, it is nevertheless more noticeable than DarkOrange.

Which is a nice property to have.

If you really like the suggestion, I welcome you to play with the color 
change a little. Otherwise, we can just close this.

Message #16 received at 29192-done <at> debbugs.gnu.org (full text, mbox):

From: Stefan Kangas <stefan <at> marxist.se>
To: Dmitry Gutov <dgutov <at> yandex.ru>
Cc: 29192-done <at> debbugs.gnu.org
Subject: Re: bug#29192: 26.0.90;
 flymake-warning's default color might be inappropriate
Date: Mon, 10 Aug 2020 16:48:58 -0700

Dmitry Gutov <dgutov <at> yandex.ru> writes:

> Thank you for the response, but I have warmed up to this new color in the years
> since the change was made. Maybe not very indicative of being a warning, it is
> nevertheless more noticeable than DarkOrange.
>
> Which is a nice property to have.
>
> If you really like the suggestion, I welcome you to play with the
> color change a little. Otherwise, we can just close this.

That sounds good to me so I'll just close this.  Thanks!

Best regards,
Stefan Kangas

Previous Next

GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson.