GNU bug report logs - #40003
27.0.70; Windows build is without jansson support

Previous Next

To add a comment to this bug, you must first unarchive it, by sending
a message to control AT debbugs.gnu.org, with unarchive 40003 in the body.
You can then email your comments to 40003 AT debbugs.gnu.org in the normal way.

Toggle the display of automated, internal messages from the tracker.

Message #5 received at submit <at> debbugs.gnu.org (full text, mbox):

From: Ivan Yonchovski <yyoncho <at> gmail.com>
To: bug-gnu-emacs <at> gnu.org
Subject: 27.0.70; Windows build is without jansson support
Date: Mon, 09 Mar 2020 21:53:58 +0200

The native json/serialization seems to be one of the important features
in the new upcomming 27 release. It will be great if the default GNU
Emacs windows build has it.

Message #8 received at 40003 <at> debbugs.gnu.org (full text, mbox):

From: Eli Zaretskii <eliz <at> gnu.org>
To: Ivan Yonchovski <yyoncho <at> gmail.com>,
 phillip.lord <at> russet.org.uk (Phillip Lord)
Cc: 40003 <at> debbugs.gnu.org
Subject: Re: bug#40003: 27.0.70; Windows build is without jansson support
Date: Tue, 10 Mar 2020 05:23:15 +0200

> From: Ivan Yonchovski <yyoncho <at> gmail.com>
> Date: Mon, 09 Mar 2020 21:53:58 +0200
> 
> The native json/serialization seems to be one of the important features
> in the new upcomming 27 release. It will be great if the default GNU
> Emacs windows build has it.

Phillip, are you looking into this?  I think I reported this a few
weeks ago.

Message #11 received at 40003 <at> debbugs.gnu.org (full text, mbox):

From: Noam Postavsky <npostavs <at> gmail.com>
To: Eli Zaretskii <eliz <at> gnu.org>
Cc: 40003 <at> debbugs.gnu.org, Ivan Yonchovski <yyoncho <at> gmail.com>,
 Phillip Lord <phillip.lord <at> russet.org.uk>
Subject: Re: bug#40003: 27.0.70; Windows build is without jansson support
Date: Tue, 14 Apr 2020 10:47:33 -0400

Eli Zaretskii <eliz <at> gnu.org> writes:

>> From: Ivan Yonchovski <yyoncho <at> gmail.com>
>> Date: Mon, 09 Mar 2020 21:53:58 +0200
>> 
>> The native json/serialization seems to be one of the important features
>> in the new upcomming 27 release. It will be great if the default GNU
>> Emacs windows build has it.
>
> Phillip, are you looking into this?  I think I reported this a few
> weeks ago.

As far as I can tell, just the following would do the job:

--- i/admin/nt/dist-build/build-dep-zips.py
+++ w/admin/nt/dist-build/build-dep-zips.py
@@ -32,6 +32,7 @@
 PKG_REQ='''mingw-w64-x86_64-giflib
 mingw-w64-x86_64-gnutls
 mingw-w64-x86_64-harfbuzz
+mingw-w64-x86_64-jansson
 mingw-w64-x86_64-lcms2
 mingw-w64-x86_64-libjpeg-turbo
 mingw-w64-x86_64-libpng

Message #14 received at 40003 <at> debbugs.gnu.org (full text, mbox):

From: yyoncho <yyoncho <at> gmail.com>
To: Noam Postavsky <npostavs <at> gmail.com>
Cc: 40003 <at> debbugs.gnu.org, Eli Zaretskii <eliz <at> gnu.org>,
 Phillip Lord <phillip.lord <at> russet.org.uk>
Subject: Re: bug#40003: 27.0.70; Windows build is without jansson support
Date: Sat, 13 Jun 2020 19:58:02 +0300

[Message part 1 (text/plain, inline)]

Any update on this?

On Tue, Apr 14, 2020 at 5:47 PM Noam Postavsky <npostavs <at> gmail.com> wrote:

> Eli Zaretskii <eliz <at> gnu.org> writes:
>
> >> From: Ivan Yonchovski <yyoncho <at> gmail.com>
> >> Date: Mon, 09 Mar 2020 21:53:58 +0200
> >>
> >> The native json/serialization seems to be one of the important features
> >> in the new upcomming 27 release. It will be great if the default GNU
> >> Emacs windows build has it.
> >
> > Phillip, are you looking into this?  I think I reported this a few
> > weeks ago.
>
> As far as I can tell, just the following would do the job:
>
> --- i/admin/nt/dist-build/build-dep-zips.py
> +++ w/admin/nt/dist-build/build-dep-zips.py
> @@ -32,6 +32,7 @@
>  PKG_REQ='''mingw-w64-x86_64-giflib
>  mingw-w64-x86_64-gnutls
>  mingw-w64-x86_64-harfbuzz
> +mingw-w64-x86_64-jansson
>  mingw-w64-x86_64-lcms2
>  mingw-w64-x86_64-libjpeg-turbo
>  mingw-w64-x86_64-libpng
>
>

[Message part 2 (text/html, inline)]

Message #17 received at 40003 <at> debbugs.gnu.org (full text, mbox):

From: Phillip Lord <phillip.lord <at> russet.org.uk>
To: Noam Postavsky <npostavs <at> gmail.com>
Cc: 40003 <at> debbugs.gnu.org, Eli Zaretskii <eliz <at> gnu.org>,
 Ivan Yonchovski <yyoncho <at> gmail.com>
Subject: Re: bug#40003: 27.0.70; Windows build is without jansson support
Date: Mon, 22 Jun 2020 16:53:25 +0100

Noam Postavsky <npostavs <at> gmail.com> writes:

> Eli Zaretskii <eliz <at> gnu.org> writes:
>
>>> From: Ivan Yonchovski <yyoncho <at> gmail.com>
>>> Date: Mon, 09 Mar 2020 21:53:58 +0200
>>> 
>>> The native json/serialization seems to be one of the important features
>>> in the new upcomming 27 release. It will be great if the default GNU
>>> Emacs windows build has it.
>>
>> Phillip, are you looking into this?  I think I reported this a few
>> weeks ago.
>
> As far as I can tell, just the following would do the job:
>
> --- i/admin/nt/dist-build/build-dep-zips.py
> +++ w/admin/nt/dist-build/build-dep-zips.py
> @@ -32,6 +32,7 @@
>  PKG_REQ='''mingw-w64-x86_64-giflib
>  mingw-w64-x86_64-gnutls
>  mingw-w64-x86_64-harfbuzz
> +mingw-w64-x86_64-jansson
>  mingw-w64-x86_64-lcms2
>  mingw-w64-x86_64-libjpeg-turbo
>  mingw-w64-x86_64-libpng


Assuming that configure puts this in by default, yes, that should be it.

I am trying to build this against Emacs-28 at the moment. What test can
I run on Emacs-28 to let me know if it has worked?

After that, the decision is what to do for Emacs-27. I can add the
dependency, but it will require rebuilding the deps file which will
update *all* of the dependencies. Not a big problem in one sense, but we
are in the pre-release test phase, IIUC.

Phil

Message #20 received at 40003 <at> debbugs.gnu.org (full text, mbox):

From: Eli Zaretskii <eliz <at> gnu.org>
To: Phillip Lord <phillip.lord <at> russet.org.uk>
Cc: 40003 <at> debbugs.gnu.org, npostavs <at> gmail.com, yyoncho <at> gmail.com
Subject: Re: bug#40003: 27.0.70; Windows build is without jansson support
Date: Mon, 22 Jun 2020 19:13:50 +0300

> From: Phillip Lord <phillip.lord <at> russet.org.uk>
> Cc: Eli Zaretskii <eliz <at> gnu.org>,  Ivan Yonchovski <yyoncho <at> gmail.com>,
>   40003 <at> debbugs.gnu.org
> Date: Mon, 22 Jun 2020 16:53:25 +0100
> 
> I am trying to build this against Emacs-28 at the moment. What test can
> I run on Emacs-28 to let me know if it has worked?

  cd test && make src/json-tests

If this says tests were not skipped, you've succeeded, and your Emacs
uses the libjansson library.

> After that, the decision is what to do for Emacs-27. I can add the
> dependency, but it will require rebuilding the deps file which will
> update *all* of the dependencies. Not a big problem in one sense, but we
> are in the pre-release test phase, IIUC.

I'd say go for it.  I don't expect trivial changes in the dependencies
to affect Emacs.

Thanks.

Message #23 received at 40003 <at> debbugs.gnu.org (full text, mbox):

From: Phillip Lord <phillip.lord <at> russet.org.uk>
To: Eli Zaretskii <eliz <at> gnu.org>
Cc: 40003 <at> debbugs.gnu.org, npostavs <at> gmail.com, yyoncho <at> gmail.com
Subject: Re: bug#40003: 27.0.70; Windows build is without jansson support
Date: Mon, 22 Jun 2020 18:24:35 +0100

Eli Zaretskii <eliz <at> gnu.org> writes:

>> From: Phillip Lord <phillip.lord <at> russet.org.uk>
>> Cc: Eli Zaretskii <eliz <at> gnu.org>,  Ivan Yonchovski <yyoncho <at> gmail.com>,
>>   40003 <at> debbugs.gnu.org
>> Date: Mon, 22 Jun 2020 16:53:25 +0100
>> 
>> I am trying to build this against Emacs-28 at the moment. What test can
>> I run on Emacs-28 to let me know if it has worked?
>
>   cd test && make src/json-tests
>
> If this says tests were not skipped, you've succeeded, and your Emacs
> uses the libjansson library.

Ah!

(fboundp 'json-serialize)



>> After that, the decision is what to do for Emacs-27. I can add the
>> dependency, but it will require rebuilding the deps file which will
>> update *all* of the dependencies. Not a big problem in one sense, but we
>> are in the pre-release test phase, IIUC.
>
> I'd say go for it.  I don't expect trivial changes in the dependencies
> to affect Emacs.


Okay. I've updated by deps files. Will have to wait for emacs-27.0.92 to
come out till the next upload.

Phil

Message #26 received at 40003 <at> debbugs.gnu.org (full text, mbox):

From: Phillip Lord <phillip.lord <at> russet.org.uk>
To: Eli Zaretskii <eliz <at> gnu.org>
Cc: 40003 <at> debbugs.gnu.org, npostavs <at> gmail.com, yyoncho <at> gmail.com
Subject: Re: bug#40003: 27.0.70; Windows build is without jansson support
Date: Tue, 30 Jun 2020 12:13:05 +0100

Phillip Lord <phillip.lord <at> russet.org.uk> writes:
>
> Ah!
>
> (fboundp 'json-serialize)
>
>
>
>>> After that, the decision is what to do for Emacs-27. I can add the
>>> dependency, but it will require rebuilding the deps file which will
>>> update *all* of the dependencies. Not a big problem in one sense, but we
>>> are in the pre-release test phase, IIUC.
>>
>> I'd say go for it.  I don't expect trivial changes in the dependencies
>> to affect Emacs.
>
>
> Okay. I've updated by deps files. Will have to wait for emacs-27.0.92 to
> come out till the next upload.


I have pushed a snapshot release of emacs-28 to alpha which contains
this support as far as I can tell. "As far as I can tell" means

(fboundp 'json-serialize)

so any slightly more rigourous testing of this build against a real
world use case would be appreciated.

https://alpha.gnu.org/gnu/emacs/pretest/windows/emacs-28/


Phil

Message #29 received at 40003 <at> debbugs.gnu.org (full text, mbox):

From: Eli Zaretskii <eliz <at> gnu.org>
To: Phillip Lord <phillip.lord <at> russet.org.uk>
Cc: 40003 <at> debbugs.gnu.org, npostavs <at> gmail.com, yyoncho <at> gmail.com
Subject: Re: bug#40003: 27.0.70; Windows build is without jansson support
Date: Tue, 30 Jun 2020 17:26:24 +0300

> From: Phillip Lord <phillip.lord <at> russet.org.uk>
> Cc: 40003 <at> debbugs.gnu.org,  npostavs <at> gmail.com,  yyoncho <at> gmail.com
> Date: Tue, 30 Jun 2020 12:13:05 +0100
> 
> I have pushed a snapshot release of emacs-28 to alpha which contains
> this support as far as I can tell.

Thanks.

> "As far as I can tell" means
> 
> (fboundp 'json-serialize)
> 
> so any slightly more rigourous testing of this build against a real
> world use case would be appreciated.

There's a small test suite in test/src/json-tests.el.

Message #32 received at 40003 <at> debbugs.gnu.org (full text, mbox):

From: phillip.lord <at> russet.org.uk
To: Eli Zaretskii <eliz <at> gnu.org>
Cc: 40003 <at> debbugs.gnu.org, npostavs <at> gmail.com, yyoncho <at> gmail.com
Subject: Re: bug#40003: 27.0.70; Windows build is without jansson support
Date: Tue, 30 Jun 2020 21:56:04 +0100

On 2020-06-30 15:26, Eli Zaretskii wrote:
>> From: Phillip Lord <phillip.lord <at> russet.org.uk>
>> Cc: 40003 <at> debbugs.gnu.org,  npostavs <at> gmail.com,  yyoncho <at> gmail.com
>> Date: Tue, 30 Jun 2020 12:13:05 +0100
>> 
>> I have pushed a snapshot release of emacs-28 to alpha which contains
>> this support as far as I can tell.
> 
> Thanks.
> 
>> "As far as I can tell" means
>> 
>> (fboundp 'json-serialize)
>> 
>> so any slightly more rigourous testing of this build against a real
>> world use case would be appreciated.
> 
> There's a small test suite in test/src/json-tests.el.

Yes, I know, but the test suite tests the build and not the packaged 
version. We don't have any way to check that automatically.

Message #35 received at 40003 <at> debbugs.gnu.org (full text, mbox):

From: yyoncho <yyoncho <at> gmail.com>
To: Phillip Lord <phillip.lord <at> russet.org.uk>
Cc: 40003 <at> debbugs.gnu.org, Eli Zaretskii <eliz <at> gnu.org>,
 Noam Postavsky <npostavs <at> gmail.com>
Subject: Re: bug#40003: 27.0.70; Windows build is without jansson support
Date: Wed, 1 Jul 2020 00:04:37 +0300

[Message part 1 (text/plain, inline)]

FWIW a few lsp-mode users tested the build and it works as expected.

Thanks,
Ivan

On Tue, Jun 30, 2020 at 11:56 PM <phillip.lord <at> russet.org.uk> wrote:

> On 2020-06-30 15:26, Eli Zaretskii wrote:
> >> From: Phillip Lord <phillip.lord <at> russet.org.uk>
> >> Cc: 40003 <at> debbugs.gnu.org,  npostavs <at> gmail.com,  yyoncho <at> gmail.com
> >> Date: Tue, 30 Jun 2020 12:13:05 +0100
> >>
> >> I have pushed a snapshot release of emacs-28 to alpha which contains
> >> this support as far as I can tell.
> >
> > Thanks.
> >
> >> "As far as I can tell" means
> >>
> >> (fboundp 'json-serialize)
> >>
> >> so any slightly more rigourous testing of this build against a real
> >> world use case would be appreciated.
> >
> > There's a small test suite in test/src/json-tests.el.
>
> Yes, I know, but the test suite tests the build and not the packaged
> version. We don't have any way to check that automatically.
>

[Message part 2 (text/html, inline)]

Message #38 received at 40003 <at> debbugs.gnu.org (full text, mbox):

From: Phillip Lord <phillip.lord <at> russet.org.uk>
To: yyoncho <yyoncho <at> gmail.com>
Cc: 40003 <at> debbugs.gnu.org, Eli Zaretskii <eliz <at> gnu.org>,
 Noam Postavsky <npostavs <at> gmail.com>
Subject: Re: bug#40003: 27.0.70; Windows build is without jansson support
Date: Wed, 01 Jul 2020 15:13:02 +0100

It's worth a lot! Thanks for the info.

Phil

yyoncho <yyoncho <at> gmail.com> writes:

> FWIW a few lsp-mode users tested the build and it works as expected.
>
> Thanks,
> Ivan
>
> On Tue, Jun 30, 2020 at 11:56 PM <phillip.lord <at> russet.org.uk> wrote:
>
>> On 2020-06-30 15:26, Eli Zaretskii wrote:
>> >> From: Phillip Lord <phillip.lord <at> russet.org.uk>
>> >> Cc: 40003 <at> debbugs.gnu.org,  npostavs <at> gmail.com,  yyoncho <at> gmail.com
>> >> Date: Tue, 30 Jun 2020 12:13:05 +0100
>> >>
>> >> I have pushed a snapshot release of emacs-28 to alpha which contains
>> >> this support as far as I can tell.
>> >
>> > Thanks.
>> >
>> >> "As far as I can tell" means
>> >>
>> >> (fboundp 'json-serialize)
>> >>
>> >> so any slightly more rigourous testing of this build against a real
>> >> world use case would be appreciated.
>> >
>> > There's a small test suite in test/src/json-tests.el.
>>
>> Yes, I know, but the test suite tests the build and not the packaged
>> version. We don't have any way to check that automatically.
>>

Message #41 received at 40003 <at> debbugs.gnu.org (full text, mbox):

From: Stefan Kangas <stefan <at> marxist.se>
To: Phillip Lord <phillip.lord <at> russet.org.uk>
Cc: 40003 <at> debbugs.gnu.org, Eli Zaretskii <eliz <at> gnu.org>, npostavs <at> gmail.com,
 yyoncho <at> gmail.com
Subject: Re: bug#40003: 27.0.70; Windows build is without jansson support
Date: Sun, 23 Aug 2020 08:34:08 -0400

Phillip Lord <phillip.lord <at> russet.org.uk> writes:

> I have pushed a snapshot release of emacs-28 to alpha which contains
> this support as far as I can tell. "As far as I can tell" means
>
> (fboundp 'json-serialize)
>
> so any slightly more rigourous testing of this build against a real
> world use case would be appreciated.

It seems like the issue with missing jansson support has been resolved?
Is there anything more to do here or should this bug be closed?

Best regards,
Stefan Kangas

Message #44 received at 40003 <at> debbugs.gnu.org (full text, mbox):

From: phillip.lord <at> russet.org.uk
To: Stefan Kangas <stefan <at> marxist.se>
Cc: 40003 <at> debbugs.gnu.org, Eli Zaretskii <eliz <at> gnu.org>, npostavs <at> gmail.com,
 yyoncho <at> gmail.com
Subject: Re: bug#40003: 27.0.70; Windows build is without jansson support
Date: Sun, 23 Aug 2020 16:12:09 +0100

On 2020-08-23 13:34, Stefan Kangas wrote:
> Phillip Lord <phillip.lord <at> russet.org.uk> writes:
> 
>> I have pushed a snapshot release of emacs-28 to alpha which contains
>> this support as far as I can tell. "As far as I can tell" means
>> 
>> (fboundp 'json-serialize)
>> 
>> so any slightly more rigourous testing of this build against a real
>> world use case would be appreciated.
> 
> It seems like the issue with missing jansson support has been resolved?
> Is there anything more to do here or should this bug be closed?
> 
> Best regards,
> Stefan Kangas

I think it can be. Strictly the bug is "windows build for Emacs-27 not 
released yet".

My last comment is wrong, though. It should say "a release of emacs-27 
to alpha".

Phil

Message #49 received at 40003-done <at> debbugs.gnu.org (full text, mbox):

From: Stefan Kangas <stefan <at> marxist.se>
To: phillip.lord <at> russet.org.uk
Cc: 40003-done <at> debbugs.gnu.org, npostavs <at> gmail.com, yyoncho <at> gmail.com
Subject: Re: bug#40003: 27.0.70; Windows build is without jansson support
Date: Sun, 23 Aug 2020 12:12:01 -0400

phillip.lord <at> russet.org.uk writes:

>> Is there anything more to do here or should this bug be closed?
>
> I think it can be.

Thanks.  I'm therefore closing this bug report.

Best regards,
Stefan Kangas

Previous Next

GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson.