GNU bug report logs - #51240
27.2; Binding find-library commands

Previous Next

To add a comment to this bug, you must first unarchive it, by sending
a message to control AT debbugs.gnu.org, with unarchive 51240 in the body.
You can then email your comments to 51240 AT debbugs.gnu.org in the normal way.

Toggle the display of automated, internal messages from the tracker.

Message #5 received at submit <at> debbugs.gnu.org (full text, mbox):

From: Howard Melman <hmelman <at> gmail.com>
To: GNU Emacs <bug-gnu-emacs <at> gnu.org>
Subject: 27.2; Binding find-library commands
Date: Sat, 16 Oct 2021 12:49:28 -0400

I see that the other-window and other-frame versions of
find-library were added in Emacs 26 but none of them were
bound to keys as discussed in Emacs bug#26712.  And if I'm
looking at the correct source tree, still aren't bound in
Emacs 28.  It seemed like there was concensus on replacing
the bindings of the find-function commands with new
find-function-or-library versions but the included patches
were never applied and the bug archived.

There was also discussion in bug#2270 that also didn't seem
to come to resolution.

I (bind and) use find-library all the time, typically to
view the source of a 3rd party package I've installed via
elpa (since entering the package name is easier than a
function name).  Is there a better way to do this?  If not,
could these commands be bound (possibly in Emacs 28)?

-- 

Howard

Message #8 received at 51240 <at> debbugs.gnu.org (full text, mbox):

From: Drew Adams <drew.adams <at> oracle.com>
To: Howard Melman <hmelman <at> gmail.com>, "51240 <at> debbugs.gnu.org"
 <51240 <at> debbugs.gnu.org>
Subject: RE: [External] : bug#51240: 27.2; Binding find-library commands
Date: Sat, 16 Oct 2021 18:28:43 +0000

> I see that the other-window and other-frame versions of
> find-library were added in Emacs 26 but none of them were
> bound to keys as discussed in Emacs bug#26712.  And if I'm
> looking at the correct source tree, still aren't bound in
> Emacs 28.  It seemed like there was concensus on replacing
> the bindings of the find-function commands with new
> find-function-or-library versions but the included patches
> were never applied and the bug archived.
> 
> There was also discussion in bug#2270 that also didn't seem
> to come to resolution.
> 
> I (bind and) use find-library all the time, typically to
> view the source of a 3rd party package I've installed via
> elpa (since entering the package name is easier than a
> function name).  Is there a better way to do this?  If not,
> could these commands be bound (possibly in Emacs 28)?

+1.

[But isn't this essentially bug #26712? and 2270?
(which was closed as Done, but with no key binding)]

IMO, we should bind `find-library-other-window' to
`C-x 4 l' and `find-library-other-frame' to `C-x 5 l'.
___

[And this is from someone who doesn't Emacs to waste
key bindings.  These bindings just make sense.  I
almost never use `find-library'.  I use `C-x 4 l'
(which, because I use non-nil `pop-up-frames', opens
in another frame).]
___

Maybe this will happen in another decade or two?...
I proposed this in 2007 (as soon as `find-library'
was added, if I'm not mistaken).

Message #11 received at 51240 <at> debbugs.gnu.org (full text, mbox):

From: Juri Linkov <juri <at> linkov.net>
To: Drew Adams <drew.adams <at> oracle.com>
Cc: "51240 <at> debbugs.gnu.org" <51240 <at> debbugs.gnu.org>,
 Howard Melman <hmelman <at> gmail.com>
Subject: Re: bug#51240: [External] : bug#51240: 27.2; Binding find-library
 commands
Date: Sat, 16 Oct 2021 21:57:30 +0300

> IMO, we should bind `find-library-other-window' to
> `C-x 4 l' and `find-library-other-frame' to `C-x 5 l'.

Since other Emacs-Lisp specific keys are on the `C-h' key prefix
like `C-h f' and `C-h S', a key to find an Emacs-Lisp library
could find a place in the same `C-h' key prefix.

But I don't understand why it needs a new key - it already
works fine with 'C-x 4 f' and 'C-x 5 f' when point is on
the library name, then typing 'M-n' will get the library file.

Message #14 received at 51240 <at> debbugs.gnu.org (full text, mbox):

From: Drew Adams <drew.adams <at> oracle.com>
To: Juri Linkov <juri <at> linkov.net>
Cc: "51240 <at> debbugs.gnu.org" <51240 <at> debbugs.gnu.org>,
 Howard Melman <hmelman <at> gmail.com>
Subject: RE: bug#51240: [External] : bug#51240: 27.2; Binding find-library
 commands
Date: Sat, 16 Oct 2021 19:33:52 +0000

> > IMO, we should bind `find-library-other-window' to
> > `C-x 4 l' and `find-library-other-frame' to `C-x 5 l'.
> 
> Since other Emacs-Lisp specific keys are on the `C-h' key prefix
> like `C-h f' and `C-h S', a key to find an Emacs-Lisp library
> could find a place in the same `C-h' key prefix.

It's not about finding help information.
It's about finding a library - a file.  Do you
also propose to move the find-file commands to
the `C-h' prefix, because the command name is
"find"?  Moving `C-x 4 f' to `C-h <something>'?

> But I don't understand why it needs a new key - it already
> works fine with 'C-x 4 f' and 'C-x 5 f' when point is on
> the library name, then typing 'M-n' will get the library file.

It's not about the cursor being on the library
name.  It's about getting the library file
wherever you are, in whatever buffer, directory,
etc.

What's the big deal?  IIRC, in the last month
alone you've proposed (and grabbed) a _bunch_
of new default keys, no?

These find-library keys just make sense, IMO.

Message #17 received at 51240 <at> debbugs.gnu.org (full text, mbox):

From: Howard Melman <hmelman <at> gmail.com>
To: Juri Linkov <juri <at> linkov.net>
Cc: "51240 <at> debbugs.gnu.org" <51240 <at> debbugs.gnu.org>,
 Drew Adams <drew.adams <at> oracle.com>
Subject: Re: bug#51240: [External] : bug#51240: 27.2; Binding find-library
 commands
Date: Sat, 16 Oct 2021 21:16:32 -0400

On Oct 16, 2021, at 2:57 PM, Juri Linkov <juri <at> linkov.net> wrote:
> 
>> IMO, we should bind `find-library-other-window' to
>> `C-x 4 l' and `find-library-other-frame' to `C-x 5 l'.
> 
> Since other Emacs-Lisp specific keys are on the `C-h' key prefix
> like `C-h f' and `C-h S', a key to find an Emacs-Lisp library
> could find a place in the same `C-h' key prefix.

The other commands related to find-library are setup via
find-function-setup-keys.  The equivalents of find-library
are on C-x F, C-x K and C-x V and then on the C-x 4 and 
C-x 5 locations too.

> But I don't understand why it needs a new key - it already
> works fine with 'C-x 4 f' and 'C-x 5 f' when point is on
> the library name, then typing 'M-n' will get the library file.

I use this often if I want to visit a library regardless of what is
near point.  If I want to open embark (say because I just updated
it), I use C-x L and enter "embark" via completing-read.  
It's very convenient.

Howard

Message #20 received at 51240 <at> debbugs.gnu.org (full text, mbox):

From: Juri Linkov <juri <at> linkov.net>
To: Drew Adams <drew.adams <at> oracle.com>
Cc: "51240 <at> debbugs.gnu.org" <51240 <at> debbugs.gnu.org>,
 Howard Melman <hmelman <at> gmail.com>
Subject: Re: bug#51240: [External] : bug#51240: 27.2; Binding find-library
 commands
Date: Sun, 17 Oct 2021 19:59:16 +0300

> What's the big deal?  IIRC, in the last month
> alone you've proposed (and grabbed) a _bunch_
> of new default keys, no?

No, I didn't grab no keys from you.

Message #23 received at 51240 <at> debbugs.gnu.org (full text, mbox):

From: Juri Linkov <juri <at> linkov.net>
To: Howard Melman <hmelman <at> gmail.com>
Cc: "51240 <at> debbugs.gnu.org" <51240 <at> debbugs.gnu.org>,
 Drew Adams <drew.adams <at> oracle.com>
Subject: Re: bug#51240: [External] : bug#51240: 27.2; Binding find-library
 commands
Date: Sun, 17 Oct 2021 20:04:17 +0300

> The other commands related to find-library are setup via
> find-function-setup-keys.  The equivalents of find-library
> are on C-x F, C-x K and C-x V and then on the C-x 4 and
> C-x 5 locations too.

> I use this often if I want to visit a library regardless of what is
> near point.  If I want to open embark (say because I just updated
> it), I use C-x L and enter "embark" via completing-read.
> It's very convenient.

Thanks for the explanation, I think it makes sense to add
C-x L, C-x 4 L, C-x 5 L to find-function-setup-keys.

Message #26 received at 51240 <at> debbugs.gnu.org (full text, mbox):

From: Lars Ingebrigtsen <larsi <at> gnus.org>
To: Juri Linkov <juri <at> linkov.net>
Cc: "51240 <at> debbugs.gnu.org" <51240 <at> debbugs.gnu.org>,
 Howard Melman <hmelman <at> gmail.com>, Drew Adams <drew.adams <at> oracle.com>
Subject: Re: bug#51240: 27.2; Binding find-library commands
Date: Mon, 18 Oct 2021 09:32:48 +0200

Juri Linkov <juri <at> linkov.net> writes:

> Thanks for the explanation, I think it makes sense to add
> C-x L, C-x 4 L, C-x 5 L to find-function-setup-keys.

Makes sense to me.

-- 
(domestic pets only, the antidote for overdose, milk.)
   bloggy blog: http://lars.ingebrigtsen.no

Message #33 received at submit <at> debbugs.gnu.org (full text, mbox):

From: Howard Melman <hmelman <at> gmail.com>
To: bug-gnu-emacs <at> gnu.org
Subject: Re: bug#51240: 27.2; Binding find-library commands
Date: Mon, 03 Jan 2022 16:25:12 -0500

Lars Ingebrigtsen <larsi <at> gnus.org> writes:

> Juri Linkov <juri <at> linkov.net> writes:
>
>> Thanks for the explanation, I think it makes sense to add
>> C-x L, C-x 4 L, C-x 5 L to find-function-setup-keys.
>
> Makes sense to me.

I don't see this in the tree.  Could this make it into
master or even Emacs 28?

--

Howard

Message #36 received at 51240 <at> debbugs.gnu.org (full text, mbox):

From: Drew Adams <drew.adams <at> oracle.com>
To: Howard Melman <hmelman <at> gmail.com>, "51240 <at> debbugs.gnu.org"
 <51240 <at> debbugs.gnu.org>
Subject: RE: [External] : bug#51240: 27.2; Binding find-library commands
Date: Mon, 3 Jan 2022 22:40:58 +0000

>> Thanks for the explanation, I think it makes sense to add
>> C-x L, C-x 4 L, C-x 5 L to find-function-setup-keys.
> Makes sense to me.

Why is `L' needed, instead of `l', for `C-x [45]'?
(Why should you need to use the Shift key for this?)

Why is `C-x L' wasted on this?  That `L' would be a
perfectly good prefix key for something.

Is a same-window key binding even needed?  Do you
really think it will be used much?

Message #39 received at 51240 <at> debbugs.gnu.org (full text, mbox):

From: Howard Melman <hmelman <at> gmail.com>
To: Drew Adams <drew.adams <at> oracle.com>
Cc: "51240 <at> debbugs.gnu.org" <51240 <at> debbugs.gnu.org>
Subject: Re: [External] : bug#51240: 27.2; Binding find-library commands
Date: Mon, 3 Jan 2022 18:02:11 -0500

On Jan 3, 2022, at 5:40 PM, Drew Adams <drew.adams <at> oracle.com> wrote:
> 
>>> Thanks for the explanation, I think it makes sense to add
>>> C-x L, C-x 4 L, C-x 5 L to find-function-setup-keys.
>> Makes sense to me.
> 
> Why is `L' needed, instead of `l', for `C-x [45]'?
> (Why should you need to use the Shift key for this?)
> 
> Why is `C-x L' wasted on this?  That `L' would be a
> perfectly good prefix key for something.
> 
> Is a same-window key binding even needed?  Do you
> really think it will be used much?

I answered all of these previously in this bug several months ago.

Juri and Lars agreed at the time, and I'm just trying to follow through to see the changes make it in.

Howard

Message #42 received at 51240 <at> debbugs.gnu.org (full text, mbox):

From: Drew Adams <drew.adams <at> oracle.com>
To: Howard Melman <hmelman <at> gmail.com>
Cc: "51240 <at> debbugs.gnu.org" <51240 <at> debbugs.gnu.org>
Subject: RE: [External] : bug#51240: 27.2; Binding find-library commands
Date: Mon, 3 Jan 2022 23:32:22 +0000

> I answered all of these previously in this bug several months ago.

Yeah, it sounds familiar.  I wasn't sure whether I'd
registered my disagreement and asked for reasons.
Sorry for the noise.

I see now, checking.  Your reason is that this is
similar to what `find-function-setup-keys' gives,
for finding a function.  (I don't see much of a
connection between finding libraries and finding
functions, but so be it.)

But if the idea is to emulate the model of
`find-function-setup-keys', then such find-library
bindings should be _created only by command_, e.g.,
`find-library-setup-keys' - not by default.

I don't at all object to someone using a command
that creates such a set of key bindings.  I object
to such _default_ key bindings - for the reasons
I gave.

It's one thing for someone to explicitly request
some key bindings (interactively or init file),
and a command is a convenient way to do that.

It's quite another thing for Emacs to assign keys
by default.

> Juri and Lars agreed at the time, and I'm just
> trying to follow through to see the changes make it in.

On n'arrete pas le progres...

Message #45 received at submit <at> debbugs.gnu.org (full text, mbox):

From: Howard Melman <hmelman <at> gmail.com>
To: bug-gnu-emacs <at> gnu.org
Subject: Re: bug#51240: [External] : bug#51240: 27.2;
 Binding find-library commands
Date: Mon, 03 Jan 2022 19:04:35 -0500

Drew Adams <drew.adams <at> oracle.com> writes:

>> I answered all of these previously in this bug several months ago.
>
> Yeah, it sounds familiar.  I wasn't sure whether I'd
> registered my disagreement and asked for reasons.
> Sorry for the noise.
>
> I see now, checking.  Your reason is that this is
> similar to what `find-function-setup-keys' gives,
> for finding a function.  (I don't see much of a
> connection between finding libraries and finding
> functions, but so be it.)
>
> But if the idea is to emulate the model of
> `find-function-setup-keys', then such find-library
> bindings should be _created only by command_, e.g.,
> `find-library-setup-keys' - not by default.

The concensus from a couple of months ago is explicitly to
add these 3 bindings to find-library-setup-keys just like
the others.  I would think if you had checked we could have
avoided this noise too.  ;)

-- 

Howard

Message #48 received at 51240 <at> debbugs.gnu.org (full text, mbox):

From: Drew Adams <drew.adams <at> oracle.com>
To: Howard Melman <hmelman <at> gmail.com>, "51240 <at> debbugs.gnu.org"
 <51240 <at> debbugs.gnu.org>
Subject: RE: bug#51240: [External] : bug#51240: 27.2; Binding find-library
 commands
Date: Tue, 4 Jan 2022 15:36:50 +0000

> > But if the idea is to emulate the model of
> > `find-function-setup-keys', then such find-library
> > bindings should be _created only by command_, e.g.,
> > `find-library-setup-keys' - not by default.
> 
> The concensus from a couple of months ago is explicitly to
> add these 3 bindings to find-library-setup-keys just like
> the others.  I would think if you had checked we could have
> avoided this noise too.  ;)

Sorry.  Good to hear.  (I guess you meant
`find-function-setup-keys'.)

Message #51 received at 51240 <at> debbugs.gnu.org (full text, mbox):

From: Lars Ingebrigtsen <larsi <at> gnus.org>
To: Juri Linkov <juri <at> linkov.net>
Cc: "51240 <at> debbugs.gnu.org" <51240 <at> debbugs.gnu.org>,
 Howard Melman <hmelman <at> gmail.com>, 52074 <at> debbugs.gnu.org,
 Drew Adams <drew.adams <at> oracle.com>
Subject: Re: bug#52074: 29.0.50; Add key binding for find-library
Date: Thu, 30 Jun 2022 12:49:55 +0200

Lars Ingebrigtsen <larsi <at> gnus.org> writes:

>> Thanks for the explanation, I think it makes sense to add
>> C-x L, C-x 4 L, C-x 5 L to find-function-setup-keys.
>
> Makes sense to me.

So I've now done this in Emacs 29.

-- 
(domestic pets only, the antidote for overdose, milk.)
   bloggy blog: http://lars.ingebrigtsen.no

Message #56 received at 51240 <at> debbugs.gnu.org (full text, mbox):

From: Drew Adams <drew.adams <at> oracle.com>
To: Lars Ingebrigtsen <larsi <at> gnus.org>, Juri Linkov <juri <at> linkov.net>
Cc: "51240 <at> debbugs.gnu.org" <51240 <at> debbugs.gnu.org>,
 Howard Melman <hmelman <at> gmail.com>,
 "52074 <at> debbugs.gnu.org" <52074 <at> debbugs.gnu.org>
Subject: RE: [External] : Re: bug#52074: 29.0.50; Add key binding for
 find-library
Date: Thu, 30 Jun 2022 15:40:45 +0000

> >> Thanks for the explanation, I think it makes sense to add
> >> C-x L, C-x 4 L, C-x 5 L to find-function-setup-keys.
> >
> > Makes sense to me.
> 
> So I've now done this in Emacs 29.

Finally.

But as I said in bug #51240, which is a duplicate
of this one:

 [Isn't this essentially bug #26712? and 2270? (which
  was closed as Done, but with no key binding)]

At least 3 duplicate bugs, + discussion in emacs-devel.
15 years.

It's taken 15 years to get this done, from my initial
proposal to add the -other-window/frame versions, and
my suggestion of `C-x 4 l' and `C-x 5 l' bindings.

Yes, you should have used lowercase `l'.  From #26712:

  I almost _never_ use `count-lines-page', and I use
  `find-library-other-window' several times a day.
  And I'm probably one of the few people who actually
  does use page commands.  That's just not that useful
  a command, for me.)

And `find-function-setup-keys' shouldn't hardcode the
keys anyway - it should use a user option.

And this isn't even (at all) about finding a function.
There's no reason to put finding a _library_ on
`find-function-setup-keys'.  But I repeat myself...

https://debbugs.gnu.org/cgi/bugreport.cgi?bug=2270

https://debbugs.gnu.org/cgi/bugreport.cgi?bug=26712#8

https://debbugs.gnu.org/cgi/bugreport.cgi?bug=26712#44

https://lists.gnu.org/archive/html/emacs-devel/2007-03/msg01073.html

https://lists.gnu.org/archive/html/emacs-devel/2007-06/msg01306.html

Previous Next

GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson.