GNU bug report logs - #59047
29.0.50; [PATCH] dired-hide-subdir breaks dired-hide-details-mode

Previous Next

To add a comment to this bug, you must first unarchive it, by sending
a message to control AT debbugs.gnu.org, with unarchive 59047 in the body.
You can then email your comments to 59047 AT debbugs.gnu.org in the normal way.

Toggle the display of automated, internal messages from the tracker.

Message #5 received at submit <at> debbugs.gnu.org (full text, mbox):

From: Gabriel <gabriel376 <at> hotmail.com>
To: bug-gnu-emacs <at> gnu.org
Subject: 29.0.50; [PATCH] dired-hide-subdir breaks dired-hide-details-mode
Date: Sat, 05 Nov 2022 08:32:16 -0300

[Message part 1 (text/plain, inline)]

Description:
In Dired, the use of `dired-hide-subdir' breaks the subsequent
invocations of `dired-hide-details-mode'.

Steps to reproduce:
Emacs 29.0.50 (master 8721e87a6ec0874057f83f54498a0e3a64475a53)
1) emacs -Q
2) Open any Dired buffer, e.g.: C-x C-f ~/
3) Press key ( a couple of times to toggle `dired-hide-details-mode'
4) Press key $ twice to hide and unhide the current directory list
5) Press key ( a couple of times to toggle `dired-hide-details-mode'

On step 5), the `dired-hide-details-mode' ceases to work.

Patch:
The patch below adds a call to `dired-insert-set-properties` to restore
the text properties lost by `dired-hide-subdir'. More specifically, the
`dired--hide' removes the 'invisible text property that is used by Dired
to toggle the visibility of some information, such as
details-information, details-detail and details-link.

[0001-Make-dired-hide-details-mode-work-after-dired-hide-s.patch (text/x-diff, attachment)]

[Message part 3 (text/plain, inline)]

I did some tests and could not find any regression. I wrote a simple
test case. If there is a better way to fix the issue or to improve the
test case, let me know.

---
Gabriel

Message #10 received at 59047-done <at> debbugs.gnu.org (full text, mbox):

From: Eli Zaretskii <eliz <at> gnu.org>
To: Gabriel <gabriel376 <at> hotmail.com>
Cc: 59047-done <at> debbugs.gnu.org
Subject: Re: bug#59047: 29.0.50;
 [PATCH] dired-hide-subdir breaks dired-hide-details-mode
Date: Thu, 10 Nov 2022 12:09:25 +0200

> From: Gabriel <gabriel376 <at> hotmail.com>
> Date: Sat, 05 Nov 2022 08:32:16 -0300
> 
> Description:
> In Dired, the use of `dired-hide-subdir' breaks the subsequent
> invocations of `dired-hide-details-mode'.
> 
> Steps to reproduce:
> Emacs 29.0.50 (master 8721e87a6ec0874057f83f54498a0e3a64475a53)
> 1) emacs -Q
> 2) Open any Dired buffer, e.g.: C-x C-f ~/
> 3) Press key ( a couple of times to toggle `dired-hide-details-mode'
> 4) Press key $ twice to hide and unhide the current directory list
> 5) Press key ( a couple of times to toggle `dired-hide-details-mode'
> 
> On step 5), the `dired-hide-details-mode' ceases to work.
> 
> Patch:
> The patch below adds a call to `dired-insert-set-properties` to restore
> the text properties lost by `dired-hide-subdir'. More specifically, the
> `dired--hide' removes the 'invisible text property that is used by Dired
> to toggle the visibility of some information, such as
> details-information, details-detail and details-link.

Thanks, installed.

Message #13 received at 59047 <at> debbugs.gnu.org (full text, mbox):

From: Michael Heerdegen <michael_heerdegen <at> web.de>
To: Gabriel <gabriel376 <at> hotmail.com>
Cc: 59047 <at> debbugs.gnu.org
Subject: Re: bug#59047: 29.0.50; [PATCH] dired-hide-subdir breaks
 dired-hide-details-mode
Date: Fri, 11 Nov 2022 22:37:12 +0100

Gabriel <gabriel376 <at> hotmail.com> writes:

> I did some tests and could not find any regression. I wrote a simple
> test case. If there is a better way to fix the issue or to improve the
> test case, let me know.

Thanks for that.

Does your patch also fix Bug#48147: 27.2; "dired-hide-details-mode does
not work properly with dired-subdirs" (seems so...)?  Can you confirm
that your patch is the correct fix also for that very similar bug?

TIA,

Michael.

Message #16 received at submit <at> debbugs.gnu.org (full text, mbox):

From: Gabriel <gabriel376 <at> hotmail.com>
To: bug-gnu-emacs <at> gnu.org
Subject: Re: bug#59047: 29.0.50; [PATCH] dired-hide-subdir breaks
 dired-hide-details-mode
Date: Fri, 11 Nov 2022 18:48:59 -0300

Michael Heerdegen <michael_heerdegen <at> web.de> writes:
>
> Thanks for that.
>
> Does your patch also fix Bug#48147: 27.2; "dired-hide-details-mode does
> not work properly with dired-subdirs" (seems so...)?  Can you confirm
> that your patch is the correct fix also for that very similar bug?
>
> TIA,
>
> Michael.

Hi Michael,

Thank you for your message. This bug looks exactly the same I reported
in this thread. I did some tests and confirm that the patch fixes the
original issue. Perhaps we can remove the `FIXME` note in
`dired--unhide`?

---

Gabriel

Message #19 received at 59047 <at> debbugs.gnu.org (full text, mbox):

From: Eli Zaretskii <eliz <at> gnu.org>
To: Gabriel <gabriel376 <at> hotmail.com>
Cc: 48147-done <at> debbugs.gnu.org, 59047 <at> debbugs.gnu.org
Subject: Re: bug#59047: 29.0.50;
 [PATCH] dired-hide-subdir breaks dired-hide-details-mode
Date: Sat, 12 Nov 2022 09:04:22 +0200

> From: Gabriel <gabriel376 <at> hotmail.com>
> Date: Fri, 11 Nov 2022 18:48:59 -0300
> 
> Michael Heerdegen <michael_heerdegen <at> web.de> writes:
> >
> > Thanks for that.
> >
> > Does your patch also fix Bug#48147: 27.2; "dired-hide-details-mode does
> > not work properly with dired-subdirs" (seems so...)?  Can you confirm
> > that your patch is the correct fix also for that very similar bug?
> >
> > TIA,
> >
> > Michael.
> 
> Hi Michael,
> 
> Thank you for your message. This bug looks exactly the same I reported
> in this thread. I did some tests and confirm that the patch fixes the
> original issue. Perhaps we can remove the `FIXME` note in
> `dired--unhide`?

Done.

I'm also closing bug#48147.

Thanks.

Message #22 received at 59047 <at> debbugs.gnu.org (full text, mbox):

From: Michael Heerdegen <michael_heerdegen <at> web.de>
To: Eli Zaretskii <eliz <at> gnu.org>
Cc: Gabriel <gabriel376 <at> hotmail.com>, 48147-done <at> debbugs.gnu.org,
 59047 <at> debbugs.gnu.org
Subject: Re: bug#59047: 29.0.50; [PATCH] dired-hide-subdir breaks
 dired-hide-details-mode
Date: Sat, 12 Nov 2022 22:58:14 +0100

Eli Zaretskii <eliz <at> gnu.org> writes:

> Done. [I.e. removing this FIXME:
| -  ;; FIXME: This also removes other invisible properties!
> in `dired--unhide'.]

Although the FIXME hinted at the solution for this bug, that code could
still be causing other trouble (we now re-add only invisible props
coming from dired-hide-details-mode, right?), so I'm not sure if it's
good to remove the FIXME.

> I'm also closing bug#48147

Thanks.


Michael.

Previous Next

GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson.