GNU bug report logs - #59914
[GNU ELPA] Make use-package and bind-key into :core packages

Previous Next

To add a comment to this bug, you must first unarchive it, by sending
a message to control AT debbugs.gnu.org, with unarchive 59914 in the body.
You can then email your comments to 59914 AT debbugs.gnu.org in the normal way.

Toggle the display of automated, internal messages from the tracker.

Message #5 received at submit <at> debbugs.gnu.org (full text, mbox):

From: Stefan Kangas <stefankangas <at> gmail.com>
To: bug-gnu-emacs <at> gnu.org
Subject: [GNU ELPA] Make use-package and bind-key into :core packages
Date: Thu, 8 Dec 2022 16:11:22 -0800

[Message part 1 (text/plain, inline)]

Severity: wishlist

The first patch (for elpa.git) below makes `use-package' and `bind-key'
into :core packages.  This is the first step towards retiring the old
use-package GitHub repository.[1]

The second patch makes use-package-ensure-system package into its own
separate :core package, just as it has been on MELPA.[2]  This would
facilitate users' transition, and also by installing it they will get
the necessary `system-packages' package installed as a dependency.

Stefan, does this look okay and make sense to you?  Is pushing this all
that is needed, or do we need some manual intervention in addition?

[Message part 2 (text/plain, attachment)]

[0001-elpa-packages-bind-key-use-package-Make-into-core-pa.patch (text/x-diff, attachment)]

[0002-elpa-packages-use-package-ensure-system-package-New-.patch (text/x-diff, attachment)]

Message #8 received at 59914 <at> debbugs.gnu.org (full text, mbox):

From: Stefan Monnier <monnier <at> iro.umontreal.ca>
To: Stefan Kangas <stefankangas <at> gmail.com>
Cc: John Wiegley <johnw <at> newartisans.com>, 59914 <at> debbugs.gnu.org
Subject: Re: bug#59914: [GNU ELPA] Make use-package and bind-key into :core
 packages
Date: Fri, 09 Dec 2022 09:56:14 -0500

> Stefan, does this look okay and make sense to you?  Is pushing this all
> that is needed, or do we need some manual intervention in addition?

I think it will require manual intervention on `elpa.gnu.org` but I'll
take care of that.

> - ("bind-key"         :url "https://github.com/jwiegley/use-package"
> -  :ignored-files ("LICENSE" "doc" "Makefile*" "bind-chords.el" "use-package*"
> -                  "README.md" "NEWS.md") ;; These two are for use-package.
> -  :news "/dev/null"           ;l Don't use use-package' s `NEWS.md`.
> -  :auto-sync t)
> + ("bind-key"            :core "lisp/use-package/bind-key.el")

Looks fine.

> - ("use-package"		:url "https://github.com/jwiegley/use-package"
> -  :ignored-files ("LICENSE" "bind-*" "use-package-chords.el")
> -  :readme "README.md"
> -  :doc "use-package.texi"
> -  :news "NEWS.md"
> -  :auto-sync t)
> + ("use-package"
> +  :core ("lisp/use-package/use-package-core.el"
> +         "lisp/use-package/use-package-delight.el"
> +         "lisp/use-package/use-package-diminish.el"
> +         "lisp/use-package/use-package-ensure.el"
> +         "lisp/use-package/use-package-jump.el"
> +         "lisp/use-package/use-package-lint.el"
> +         "lisp/use-package/use-package.el")
> +  :doc "use-package.texi")

Can we use "lisp/use-package/" (and maybe the use `:ignored-files` to
strip out `bind-keys.el` or maybe even move `bind-keys.el` outside of
the `use-package` subdirectory)?

Also I suspect you need to add "doc/misc/use-package.texi" to `:core` in
order for the `:doc` to find the file.  Have you tried the above recipe?

> + ("use-package-ensure-system-package"
> +  :core ("lisp/use-package/use-package-ensure-system-package.el"))

Why do we need this as a separate package?

And while I'm here, I see in the doc:

    @lisp
    (use-package foo
      :ensure-system-package foo)
    @end lisp

    This will expect a global binary package to exist called @code{foo}.

Should we use another name than "binary package"?  In my part of the
world these things are usually called "executables" or "programs",
occasionally they're called "binaries" but I'd never heard them called
"binary packages".



        Stefan

Message #11 received at 59914 <at> debbugs.gnu.org (full text, mbox):

From: Stefan Kangas <stefankangas <at> gmail.com>
To: Stefan Monnier <monnier <at> iro.umontreal.ca>
Cc: John Wiegley <johnw <at> newartisans.com>, 59914 <at> debbugs.gnu.org
Subject: Re: bug#59914: [GNU ELPA] Make use-package and bind-key into :core
 packages
Date: Sun, 11 Dec 2022 18:37:04 -0800

[Message part 1 (text/plain, inline)]

Stefan Monnier <monnier <at> iro.umontreal.ca> writes:

> I think it will require manual intervention on `elpa.gnu.org` but I'll
> take care of that.

Great!

> Can we use "lisp/use-package/" (and maybe the use `:ignored-files` to
> strip out `bind-keys.el` or maybe even move `bind-keys.el` outside of
> the `use-package` subdirectory)?

I think we could move bind-keys to lisp/emacs-lisp, if everybody agrees.

> Also I suspect you need to add "doc/misc/use-package.texi" to `:core` in
> order for the `:doc` to find the file.  Have you tried the above recipe?

You're right, it did not work without that addition.  I've changed that
in the attached, now fully tested patch.

>> + ("use-package-ensure-system-package"
>> +  :core ("lisp/use-package/use-package-ensure-system-package.el"))
>
> Why do we need this as a separate package?

Because it was like that on MELPA.  I think we might as well not do
that.

The only nice thing I see is that it would stop `use-package' from
depending on `system-packages'.  But I don't think that's a big issue,
and on the contrary doing that will make things simpler.

>     This will expect a global binary package to exist called @code{foo}.
>
> Should we use another name than "binary package"?  In my part of the
> world these things are usually called "executables" or "programs",
> occasionally they're called "binaries" but I'd never heard them called
> "binary packages".

I hope I managed to improve that with commit a9037aa8e8, thanks.

[0001-elpa-packages-bind-key-use-package-Make-into-core-pa.patch (text/x-diff, attachment)]

Message #14 received at 59914 <at> debbugs.gnu.org (full text, mbox):

From: Stefan Monnier <monnier <at> iro.umontreal.ca>
To: Stefan Kangas <stefankangas <at> gmail.com>
Cc: John Wiegley <johnw <at> newartisans.com>, 59914 <at> debbugs.gnu.org
Subject: Re: bug#59914: [GNU ELPA] Make use-package and bind-key into :core
 packages
Date: Mon, 12 Dec 2022 09:56:49 -0500

>> Can we use "lisp/use-package/" (and maybe the use `:ignored-files` to
>> strip out `bind-keys.el` or maybe even move `bind-keys.el` outside of
>> the `use-package` subdirectory)?
> I think we could move bind-keys to lisp/emacs-lisp, if everybody agrees.

[ I don't have an opinion on this.  ]

>>> + ("use-package-ensure-system-package"
>>> +  :core ("lisp/use-package/use-package-ensure-system-package.el"))
>> Why do we need this as a separate package?
> Because it was like that on MELPA.

Doesn't sound like a strong enough reason.

> I think we might as well not do that.

I'm glad you agree.

> The only nice thing I see is that it would stop `use-package' from
> depending on `system-packages'.  But I don't think that's a big issue,
> and on the contrary doing that will make things simpler.

We can include `use-package-ensure-system-package.el` without adding
a dependency on `system-packages`.  Just like `use-package` did not
depend on `use-package-ensure-system-package` in MELPA.
[ Or just like Emacs itself now includes `use-package` and
  `use-package-ensure-system-package.el` but not `system-packages`.  ]

The patch looks good to me, feel free to push,


        Stefan

Message #19 received at 59914-done <at> debbugs.gnu.org (full text, mbox):

From: Stefan Kangas <stefankangas <at> gmail.com>
To: Stefan Monnier <monnier <at> iro.umontreal.ca>
Cc: John Wiegley <johnw <at> newartisans.com>, 59914-done <at> debbugs.gnu.org
Subject: Re: bug#59914: [GNU ELPA] Make use-package and bind-key into :core
 packages
Date: Mon, 12 Dec 2022 17:03:56 -0800

Stefan Monnier <monnier <at> iro.umontreal.ca> writes:

> The patch looks good to me, feel free to push,

Thanks, done.

Previous Next

GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson.