GNU bug report logs - #61128
[PATCH] Use complementation correctly in shell globs

Previous Next

To reply to this bug, email your comments to 61128 AT debbugs.gnu.org.

Toggle the display of automated, internal messages from the tracker.

Message #5 received at submit <at> debbugs.gnu.org (full text, mbox):

From: Kerin Millar <kfm <at> plushkava.net>
To: bug-parted <at> gnu.org
Subject: [PATCH] Use complementation correctly in shell globs
Date: Sat, 28 Jan 2023 23:42:05 +0000

[Message part 1 (text/plain, inline)]

Hello,

The attached patch rectifies a spurious test failure reported at https://bugs.gentoo.org/890869. As explained by the commit message, the exclamation mark character should be used to perform negations within bracket expressions, not the circumflex character.

-- 
Kerin Millar

[0001-Use-complementation-correctly-in-shell-globs.patch (application/octet-stream, attachment)]

Message #8 received at 61128 <at> debbugs.gnu.org (full text, mbox):

From: Håkon Løvdal <hlovdal <at> gmail.com>
To: Kerin Millar <kfm <at> plushkava.net>
Cc: 61128 <at> debbugs.gnu.org
Subject: Re: bug#61128: [PATCH] Use complementation correctly in shell globs
Date: Sun, 29 Jan 2023 11:24:53 +0100

This looks good to me. While shells often accept both ! and ^
(https://www.gnu.org/savannah-checkouts/gnu/bash/manual/bash.html#Pattern-Matching:
"3.5.8.1 Pattern Matching ... "[…]" Matches any one of the enclosed
characters. ...
If the first character following the ‘[’ is a ‘!’ or a ‘^’ then any
character not enclosed is matched.")
it is not portable.

https://www.linux.com/news/patterns-and-string-processing-shell-scripts/:
"Many users have the habit of using a caret (^) instead of ! in shell
character classes.
This is not portable, but it is a common extension some shells offer
because habitual
users of regular expressions may be more used to it. This can create
an occasional
surprise if you have never seen it used, and want to match a caret in a class."

On Sun, 29 Jan 2023 at 00:43, Kerin Millar <kfm <at> plushkava.net> wrote:
>
> Hello,
>
> The attached patch rectifies a spurious test failure reported at https://bugs.gentoo.org/890869. As explained by the commit message, the exclamation mark character should be used to perform negations within bracket expressions, not the circumflex character.
>
> --
> Kerin Millar

Previous Next

GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson.