GNU bug report logs - #61819
The CVE-2022-48337 fix seems to introduce a memory leak

Previous Next

To add a comment to this bug, you must first unarchive it, by sending
a message to control AT debbugs.gnu.org, with unarchive 61819 in the body.
You can then email your comments to 61819 AT debbugs.gnu.org in the normal way.

Toggle the display of automated, internal messages from the tracker.

Message #5 received at submit <at> debbugs.gnu.org (full text, mbox):

From: Adrian Bunk <bunk <at> debian.org>
To: bug-gnu-emacs <at> gnu.org
Subject: The CVE-2022-48337 fix seems to introduce a memory leak
Date: Sun, 26 Feb 2023 12:40:45 +0200

In the upstream bug for CVE-2022-48337 there was originally[1]
+          free (new_real_name);
+          free (new_tmp_name);
in the fix that later disappeared (by accident?).

This seems to introduce a memory leak, this memory allocated
by escape_shell_arg_string() is now never freed.

cu
Adrian

[1] https://debbugs.gnu.org/cgi/bugreport.cgi?bug=59817#23

Message #10 received at 61819-done <at> debbugs.gnu.org (full text, mbox):

From: Eli Zaretskii <eliz <at> gnu.org>
To: Adrian Bunk <bunk <at> debian.org>
Cc: 61819-done <at> debbugs.gnu.org
Subject: Re: bug#61819: The CVE-2022-48337 fix seems to introduce a memory leak
Date: Sun, 26 Feb 2023 20:04:11 +0200

> Date: Sun, 26 Feb 2023 12:40:45 +0200
> From: Adrian Bunk <bunk <at> debian.org>
> 
> In the upstream bug for CVE-2022-48337 there was originally[1]
> +          free (new_real_name);
> +          free (new_tmp_name);
> in the fix that later disappeared (by accident?).
> 
> This seems to introduce a memory leak, this memory allocated
> by escape_shell_arg_string() is now never freed.

Thanks, fixed.

Previous Next

GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson.