GNU bug report logs - #68612
typescript-ts-mode-test-indentation test fails if tsx grammar not installed

Previous Next

To add a comment to this bug, you must first unarchive it, by sending
a message to control AT debbugs.gnu.org, with unarchive 68612 in the body.
You can then email your comments to 68612 AT debbugs.gnu.org in the normal way.

Toggle the display of automated, internal messages from the tracker.

Message #5 received at submit <at> debbugs.gnu.org (full text, mbox):

From: Matthew Smith <matthew <at> gentoo.org>
To: bug-gnu-emacs <at> gnu.org
Subject: typescript-ts-mode-test-indentation test fails if tsx grammar not
 installed
Date: Sat, 20 Jan 2024 10:35:23 +0000

[Message part 1 (text/plain, inline)]

Severity: minor
Tags: patch

Hi,

typescript-ts-mode-test-indentation only checks if the typescript
language grammar is installed before running the test, but the test
also depends on the tsx language grammar.

A patch is attached that skips the test unless both typescript and tsx
grammars are installed.

Thanks,
Matthew

[typescript-ts-mode-test.patch (text/x-patch, attachment)]

Message #10 received at 68612-done <at> debbugs.gnu.org (full text, mbox):

From: Yuan Fu <casouri <at> gmail.com>
To: Matthew Smith <matthew <at> gentoo.org>
Cc: 68612-done <at> debbugs.gnu.org
Subject: Re: bug#68612: typescript-ts-mode-test-indentation test fails if tsx
 grammar not installed
Date: Sat, 20 Jan 2024 21:12:06 -0800

> On Jan 20, 2024, at 2:35 AM, Matthew Smith <matthew <at> gentoo.org> wrote:
> 
> Severity: minor
> Tags: patch
> 
> Hi,
> 
> typescript-ts-mode-test-indentation only checks if the typescript
> language grammar is installed before running the test, but the test
> also depends on the tsx language grammar.
> 
> A patch is attached that skips the test unless both typescript and tsx
> grammars are installed.
> 

Thank you Matthew! Pushed to emacs-29.

Yuan

Previous Next

GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson.