GNU bug report logs - #70484
Fix compatibility of build-aux/make-info-dir script

Previous Next

To add a comment to this bug, you must first unarchive it, by sending
a message to control AT debbugs.gnu.org, with unarchive 70484 in the body.
You can then email your comments to 70484 AT debbugs.gnu.org in the normal way.

Toggle the display of automated, internal messages from the tracker.

Message #5 received at submit <at> debbugs.gnu.org (full text, mbox):

From: Felix Janda <felix.janda <at> posteo.de>
To: bug-gnu-emacs <at> gnu.org
Subject: Fix compatibility of build-aux/make-info-dir script
Date: Sat, 20 Apr 2024 19:05:57 +0000

Hi,

I'm reporting the bug in the build scripts:

https://bugs.gentoo.org/930086

To summarize, the build-aux/make-info-dir script uses the substitution
${@?}, which is incompatible with mksh (and possibly other shells) and
undefined behavior in the proposed next POSIX standard.

A possible fix is to check $# at the beginning of the script, and then
simplify the rest of the script.

Felix

Message #8 received at 70484 <at> debbugs.gnu.org (full text, mbox):

From: Ulrich Mueller <ulm <at> gentoo.org>
To: 70484 <at> debbugs.gnu.org
Subject: Re: Fix compatibility of build-aux/make-info-dir script
Date: Tue, 23 Apr 2024 19:36:54 +0200

[Message part 1 (text/plain, inline)]

Attached patch fixes the problem for me. It applies cleanly to both
emacs-29 and master.

[0001-build-aux-make-info-dir-Avoid-bashism-bug-70484.patch (text/x-patch, inline)]

From cb490ee7a8365c6375dc6c7a5f6d8202ab381219 Mon Sep 17 00:00:00 2001
From: =?UTF-8?q?Ulrich=20M=C3=BCller?= <ulm <at> gentoo.org>
Date: Tue, 23 Apr 2024 07:37:17 +0200
Subject: [PATCH] * build-aux/make-info-dir: Avoid bashism (bug#70484).

---
 build-aux/make-info-dir | 5 +++--
 1 file changed, 3 insertions(+), 2 deletions(-)

diff --git a/build-aux/make-info-dir b/build-aux/make-info-dir
index e5f4972902f..631fe533e69 100755
--- a/build-aux/make-info-dir
+++ b/build-aux/make-info-dir
@@ -33,7 +33,8 @@
 
 ## Header contains non-printing characters, so this is more
 ## reliable than using awk.
-cat <"${1?}" || exit
+test $# -ge 2 || exit 1
+cat <"$1"
 shift
 
 exec "${AWK-awk}" '
@@ -101,4 +102,4 @@       detexinfo()
       if (data[dircat])
         printf "\n%s\n%s", topic[dircat], data[dircat]
   }
-' "${@?}"
+' "$@"
-- 
2.44.0

Message #11 received at 70484 <at> debbugs.gnu.org (full text, mbox):

From: Eli Zaretskii <eliz <at> gnu.org>
To: Ulrich Mueller <ulm <at> gentoo.org>
Cc: 70484 <at> debbugs.gnu.org
Subject: Re: bug#70484: Fix compatibility of build-aux/make-info-dir script
Date: Tue, 23 Apr 2024 20:57:01 +0300

> From: Ulrich Mueller <ulm <at> gentoo.org>
> Date: Tue, 23 Apr 2024 19:36:54 +0200
> 
> Attached patch fixes the problem for me. It applies cleanly to both
> emacs-29 and master.

Thanks, please install on the emacs-29 branch.

Previous Next

GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson.