GNU bug report logs - #73036
29.4; Test failure in erc-networks--id-sort-buffers

Previous Next

To add a comment to this bug, you must first unarchive it, by sending
a message to control AT debbugs.gnu.org, with unarchive 73036 in the body.
You can then email your comments to 73036 AT debbugs.gnu.org in the normal way.

Toggle the display of automated, internal messages from the tracker.

Message #5 received at submit <at> debbugs.gnu.org (full text, mbox):

From: Ulrich Mueller <ulm <at> gentoo.org>
To: bug-gnu-emacs <at> gnu.org
Subject: 29.4; Test failure in erc-networks--id-sort-buffers
Date: Thu, 05 Sep 2024 07:59:14 +0200

[Message part 1 (text/plain, inline)]

Forwarding Gentoo bug 920696 <https://bugs.gentoo.org/920696>.

We see the following test failure on an hppa2.0-unknown-linux-gnu
(Linux-6.9.8-gentoo-parisc64-parisc64-PA8900_-Shortfin-with-glibc2.39)
system:

Test erc-networks--id-sort-buffers condition:
    (ert-test-failed
     ((should
       (equal
        (erc-networks--id-sort-buffers ...)
        (list newest middle oldest)))
      :form
      (equal
       (#<killed buffer> #<killed buffer> #<killed buffer>)
       (#<killed buffer> #<killed buffer> #<killed buffer>))
      :value nil :explanation
      (list-elt 0
                (different-atoms #<killed buffer> #<killed buffer>))))
   FAILED   6/41  erc-networks--id-sort-buffers (0.000000 sec) at lisp/erc/erc-networks-tests.el:133

[...]

Ran 41 tests, 40 results as expected, 1 unexpected (2024-09-03 20:09:01+0000, 14
.712021 sec)

1 unexpected results:
   FAILED  erc-networks--id-sort-buffers  ((should (equal (erc-networks--id-sort
-buffers (list oldest newest middle)) (list newest middle oldest))) :form (equal
 (#<killed buffer> #<killed buffer> #<killed buffer>) (#<killed buffer> #<killed buffer> #<killed buffer>)) :value nil :explanation (list-elt 0 (different-atoms #<killed buffer> #<killed buffer>)))

[...]

SUMMARY OF TEST RESULTS
-----------------------
Files examined: 465
Ran 6939 tests, 6675 results as expected, 1 unexpected, 263 skipped
1 files contained unexpected results:
  lisp/erc/erc-networks-tests.log


Looking at the code, the test creates three buffers, then sorts them by
time. Clock resolution on HPPA appears to be 4 milliseconds, so it is
not unlikely that the buffers end up with exactly the same timestamp and
sorting fails.

Attached patch fixes the problem. Is it OK to install it on the emacs-30
branch?

[0001-Fix-test-failure-in-erc-networks-tests.patch (text/plain, inline)]

From bf42248be8e795d591ce97c1d161d73d98038db6 Mon Sep 17 00:00:00 2001
From: =?UTF-8?q?Ulrich=20M=C3=BCller?= <ulm <at> gentoo.org>
Date: Wed, 4 Sep 2024 13:35:51 +0200
Subject: [PATCH] Fix test failure in erc-networks-tests

* test/lisp/erc/erc-networks-tests.el
(erc-networks--id-sort-buffers): Make sure that buffers have
different timestamps.
---
 test/lisp/erc/erc-networks-tests.el | 2 ++
 1 file changed, 2 insertions(+)

diff --git a/test/lisp/erc/erc-networks-tests.el b/test/lisp/erc/erc-networks-tests.el
index f0a7c37ddf2..e84cca68cdd 100644
--- a/test/lisp/erc/erc-networks-tests.el
+++ b/test/lisp/erc/erc-networks-tests.el
@@ -133,10 +133,12 @@ erc-networks--id-sort-buffers
     (with-temp-buffer
       (setq erc-networks--id (erc-networks--id-fixed-create 'oldest)
             oldest (current-buffer))
+      (sleep-for 0.02)
 
       (with-temp-buffer
         (setq erc-networks--id (erc-networks--id-fixed-create 'middle)
               middle (current-buffer))
+        (sleep-for 0.02)
 
         (with-temp-buffer
           (setq erc-networks--id (erc-networks--id-fixed-create 'newest)
-- 
2.46.0

Message #8 received at 73036 <at> debbugs.gnu.org (full text, mbox):

From: "J.P." <jp <at> neverwas.me>
To: Ulrich Mueller <ulm <at> gentoo.org>
Cc: Eli Zaretskii <eliz <at> gnu.org>, emacs-erc <at> gnu.org, 73036 <at> debbugs.gnu.org
Subject: Re: bug#73036: 29.4; Test failure in erc-networks--id-sort-buffers
Date: Wed, 04 Sep 2024 23:44:02 -0700

Hi Ulrich,

Author of shoddy test here. Apologies for the annoyance.

Ulrich Mueller <ulm <at> gentoo.org> writes:

> Looking at the code, the test creates three buffers, then sorts them by
> time. Clock resolution on HPPA appears to be 4 milliseconds, so it is
> not unlikely that the buffers end up with exactly the same timestamp and
> sorting fails.

Makes sense to me.

> Attached patch fixes the problem. Is it OK to install it on the emacs-30
> branch?

I guess that's up to the Emacs maintainers (Eli Cc'd).

Thanks,
J.P.

Message #13 received at 73036 <at> debbugs.gnu.org (full text, mbox):

From: Eli Zaretskii <eliz <at> gnu.org>
To: "J.P." <jp <at> neverwas.me>
Cc: ulm <at> gentoo.org, emacs-erc <at> gnu.org, 73036 <at> debbugs.gnu.org
Subject: Re: bug#73036: 29.4; Test failure in erc-networks--id-sort-buffers
Date: Thu, 05 Sep 2024 11:05:05 +0300

> From: "J.P." <jp <at> neverwas.me>
> Cc: 73036 <at> debbugs.gnu.org, emacs-erc <at> gnu.org, Eli Zaretskii <eliz <at> gnu.org>
> Date: Wed, 04 Sep 2024 23:44:02 -0700
> 
> Hi Ulrich,
> 
> Author of shoddy test here. Apologies for the annoyance.
> 
> Ulrich Mueller <ulm <at> gentoo.org> writes:
> 
> > Looking at the code, the test creates three buffers, then sorts them by
> > time. Clock resolution on HPPA appears to be 4 milliseconds, so it is
> > not unlikely that the buffers end up with exactly the same timestamp and
> > sorting fails.
> 
> Makes sense to me.
> 
> > Attached patch fixes the problem. Is it OK to install it on the emacs-30
> > branch?
> 
> I guess that's up to the Emacs maintainers (Eli Cc'd).

It's okay to install these test fixes on the emacs-30 release branch.

Thanks.

Previous Next

GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson.