GNU bug report logs - #5181
[PATCH] vc-revert-file: fix setting of file time-stamp into the past.

Previous Next

Package: emacs;

Reported by: Sergei Organov <osv <at> javad.com>

Date: Fri, 11 Dec 2009 16:15:05 UTC

Severity: normal

Tags: patch

Merged with 3298

Fixed in version 24.1

Done: Glenn Morris <rgm <at> gnu.org>

Bug is archived. No further changes may be made.

To add a comment to this bug, you must first unarchive it, by sending
a message to control AT debbugs.gnu.org, with unarchive 5181 in the body.
You can then email your comments to 5181 AT debbugs.gnu.org in the normal way.

Toggle the display of automated, internal messages from the tracker.

View this report as an mbox folder, status mbox, maintainer mbox

Report forwarded to bug-submit-list <at> lists.donarmstrong.com, Emacs Bugs <bug-gnu-emacs <at> gnu.org>:
bug#5181; Package emacs. (Fri, 11 Dec 2009 16:15:05 GMT) Full text and rfc822 format available.
Acknowledgement sent to Sergei Organov <osv <at> javad.com>:
New bug report received and forwarded. Copy sent to Emacs Bugs <bug-gnu-emacs <at> gnu.org>. (Fri, 11 Dec 2009 16:15:05 GMT) Full text and rfc822 format available.

Message #5 received at submit <at> emacsbugs.donarmstrong.com (full text, mbox):

From: Sergei Organov <osv <at> javad.com>
To: bug-gnu-emacs <at> gnu.org
Subject: [PATCH] vc-revert-file: fix setting of file time-stamp into the past.
Date: Fri, 11 Dec 2009 19:12:39 +0300

The patch below fixes a long-standing bug in the VC, described here:

<http://lists.gnu.org/archive/html/bug-gnu-emacs/2009-05/msg00312.html>

2009-12-11  Sergei Organov  <osv <at> javad.com>

	* vc.el (vc-revert-file): Fix setting of file time-stamp into the
	past.

Index: lisp/vc.el
===================================================================
RCS file: /sources/emacs/emacs/lisp/vc.el,v
retrieving revision 1.746
diff -u -r1.746 vc.el
--- lisp/vc.el	7 Dec 2009 09:02:16 -0000	1.746
+++ lisp/vc.el	11 Dec 2009 16:03:12 -0000
@@ -2114,7 +2114,7 @@
    (list file)
    (let ((backup-file (vc-version-backup-file file)))
      (when backup-file
-       (copy-file backup-file file 'ok-if-already-exists 'keep-date)
+       (copy-file backup-file file 'ok-if-already-exists)
        (vc-delete-automatic-version-backups file))
      (vc-call revert file backup-file))
    `((vc-state . up-to-date)
Information forwarded to bug-submit-list <at> lists.donarmstrong.com, Emacs Bugs <bug-gnu-emacs <at> gnu.org>:
bug#5181; Package emacs. (Fri, 11 Dec 2009 17:55:05 GMT) Full text and rfc822 format available.
Acknowledgement sent to <osv <at> javad.com>:
Extra info received and forwarded to list. Copy sent to Emacs Bugs <bug-gnu-emacs <at> gnu.org>. (Fri, 11 Dec 2009 17:55:05 GMT) Full text and rfc822 format available.

Message #10 received at 5181 <at> emacsbugs.donarmstrong.com (full text, mbox):

From: <osv <at> javad.com>
To: 5181 <at> debbugs.gnu.org
Subject: Re: [PATCH] vc-revert-file: fix setting of file time-stamp into the past.
Date: Fri, 11 Dec 2009 20:21:38 +0300

This bug was supposed to be a patch to bug#3298 instead, -- sorry for
sending it to a wrong address.
Merged 3298 5181. Request was from Glenn Morris <rgm <at> gnu.org> to control <at> emacsbugs.donarmstrong.com. (Sat, 12 Dec 2009 19:55:07 GMT) Full text and rfc822 format available.
Added tag(s) patch. Request was from Glenn Morris <rgm <at> gnu.org> to control <at> emacsbugs.donarmstrong.com. (Sat, 12 Dec 2009 19:55:08 GMT) Full text and rfc822 format available.
Reply sent to Glenn Morris <rgm <at> gnu.org>:
You have taken responsibility. (Wed, 13 Jul 2011 07:58:02 GMT) Full text and rfc822 format available.
Notification sent to Sergei Organov <osv <at> javad.com>:
bug acknowledged by developer. (Wed, 13 Jul 2011 07:58:02 GMT) Full text and rfc822 format available.

Message #19 received at 5181-done <at> debbugs.gnu.org (full text, mbox):

From: Glenn Morris <rgm <at> gnu.org>
To: 5181-done <at> debbugs.gnu.org
Subject: Re: bug#5181: [PATCH] vc-revert-file: fix setting of file time-stamp
	into the past.
Date: Wed, 13 Jul 2011 03:57:01 -0400

Version: 24.1

Thank you; applied.
Reply sent to Glenn Morris <rgm <at> gnu.org>:
You have taken responsibility. (Wed, 13 Jul 2011 07:58:02 GMT) Full text and rfc822 format available.
Notification sent to Sergei Organov <osv <at> javad.com>:
bug acknowledged by developer. (Wed, 13 Jul 2011 07:58:02 GMT) Full text and rfc822 format available.
bug archived. Request was from Debbugs Internal Request <help-debbugs <at> gnu.org> to internal_control <at> debbugs.gnu.org. (Wed, 10 Aug 2011 11:24:06 GMT) Full text and rfc822 format available.
This bug report was last modified 12 years and 169 days ago.

Previous Next

GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson.