GNU bug report logs - #6387
24.0.50; ESC TAB should be bound to `isearch-complete'

Previous Next

To add a comment to this bug, you must first unarchive it, by sending
a message to control AT debbugs.gnu.org, with unarchive 6387 in the body.
You can then email your comments to 6387 AT debbugs.gnu.org in the normal way.

Toggle the display of automated, internal messages from the tracker.

Message #5 received at submit <at> debbugs.gnu.org (full text, mbox):

From: "Drew Adams" <drew.adams <at> oracle.com>
To: <bug-gnu-emacs <at> gnu.org>
Subject: 24.0.50; ESC TAB should be bound to `isearch-complete'
Date: Wed, 9 Jun 2010 17:20:32 -0700

In isearch.el, we have this:
(define-key map "\M-\t" 'isearch-complete)
 
We should also have this, so `ESC TAB' works too:
(define-key map [escape tab] 'isearch-complete)

In GNU Emacs 24.0.50.1 (i386-mingw-nt5.1.2600)
 of 2010-06-07 on 3249CTO
Windowing system distributor `Microsoft Corp.', version 5.1.2600
configured using `configure --with-gcc (4.4) --no-opt --cflags -Ic:/xpm/include'
 

Message #8 received at 6387 <at> debbugs.gnu.org (full text, mbox):

From: Juri Linkov <juri <at> jurta.org>
To: "Drew Adams" <drew.adams <at> oracle.com>
Cc: 6387 <at> debbugs.gnu.org
Subject: Re: bug#6387: 24.0.50; ESC TAB should be bound to `isearch-complete'
Date: Thu, 10 Jun 2010 19:23:31 +0300

> In isearch.el, we have this:
> (define-key map "\M-\t" 'isearch-complete)
>
> We should also have this, so `ESC TAB' works too:
> (define-key map [escape tab] 'isearch-complete)

I wonder why `ESC C-i' works in isearch, but `ESC TAB' doesn't work.
(There is no special key binding for `ESC C-i' in isearch.)

-- 
Juri Linkov
http://www.jurta.org/emacs/

Message #11 received at 6387 <at> debbugs.gnu.org (full text, mbox):

From: "Drew Adams" <drew.adams <at> oracle.com>
To: "'Juri Linkov'" <juri <at> jurta.org>
Cc: 6387 <at> debbugs.gnu.org
Subject: RE: bug#6387: 24.0.50; ESC TAB should be bound to `isearch-complete'
Date: Thu, 10 Jun 2010 09:34:10 -0700

> > In isearch.el, we have this:
> > (define-key map "\M-\t" 'isearch-complete)
> >
> > We should also have this, so `ESC TAB' works too:
> > (define-key map [escape tab] 'isearch-complete)
> 
> I wonder why `ESC C-i' works in isearch, but `ESC TAB' doesn't work.
> (There is no special key binding for `ESC C-i' in isearch.)

See this comment in the code:

    ;; To handle local bindings with meta char prefix keys, define
    ;; another full keymap.  This must be done for any other prefix
    ;; keys as well, one full keymap per char of the prefix key.  It
    ;; would be simpler to disable the global keymap, and/or have a
    ;; default local key binding for any key not otherwise bound.
    (let ((meta-map (make-sparse-keymap)))
      (define-key map (char-to-string meta-prefix-char) meta-map)
      (define-key map [escape] meta-map))
    (define-key map (vector meta-prefix-char t) 'isearch-other-meta-char)

Message #14 received at 6387 <at> debbugs.gnu.org (full text, mbox):

From: Stefan Monnier <monnier <at> IRO.UMontreal.CA>
To: Juri Linkov <juri <at> jurta.org>
Cc: 6387 <at> debbugs.gnu.org, Drew Adams <drew.adams <at> oracle.com>
Subject: Re: bug#6387: 24.0.50; ESC TAB should be bound to `isearch-complete'
Date: Thu, 10 Jun 2010 15:36:04 -0400

> I wonder why `ESC C-i' works in isearch, but `ESC TAB' doesn't work.
> (There is no special key binding for `ESC C-i' in isearch.)

It probably has to do with the fact that isearch uses default-bindings
(i.e. bindings to the event gt which stands for "any event").
Such bindings prevent function-key-map (and similar hardcoded key
translations such as A -> a, S-left -> left, double-mouse-1 -> mouse-1,
...) from doing its job (since function-key-map is only used if the
untranslated sequence has no bindings which never happens thanks to the
default binding which always applies).

I've tried to change read-key-sequence such that a default binding is
only applied *after* function-key-map (or at least that a default
binding does not prevent function-key-map translations), but so far this
has failed.


        Stefan

Message #17 received at 6387 <at> debbugs.gnu.org (full text, mbox):

From: Alex <agrambot <at> gmail.com>
To: "Drew Adams" <drew.adams <at> oracle.com>
Cc: 6387 <at> debbugs.gnu.org
Subject: Re: bug#6387: 24.0.50; ESC TAB should be bound to `isearch-complete'
Date: Sun, 21 Aug 2016 14:46:00 -0600

"Drew Adams" <drew.adams <at> oracle.com> writes:

> In isearch.el, we have this:
> (define-key map "\M-\t" 'isearch-complete)
>  
> We should also have this, so `ESC TAB' works too:
> (define-key map [escape tab] 'isearch-complete)
>
> In GNU Emacs 24.0.50.1 (i386-mingw-nt5.1.2600)
>  of 2010-06-07 on 3249CTO
> Windowing system distributor `Microsoft Corp.', version 5.1.2600
> configured using `configure --with-gcc (4.4) --no-opt --cflags -Ic:/xpm/include'
>  

ESC TAB works for me since at least 24.4. Does it work for you now?

Message #20 received at 6387 <at> debbugs.gnu.org (full text, mbox):

From: Drew Adams <drew.adams <at> oracle.com>
To: Alex <agrambot <at> gmail.com>
Cc: 6387 <at> debbugs.gnu.org
Subject: RE: bug#6387: 24.0.50; ESC TAB should be bound to `isearch-complete'
Date: Sun, 21 Aug 2016 14:52:58 -0700 (PDT)

> > In isearch.el, we have this:
> > (define-key map "\M-\t" 'isearch-complete)
> >
> > We should also have this, so `ESC TAB' works too:
> ESC TAB works for me since at least 24.4. Does it work for you now?

Yes.  The bug was fixed in 24.4.  Earlier versions had an explicit binding of <escape> TAB to `isearch-complete', but ESC TAB did not work.

Message #23 received at 6387 <at> debbugs.gnu.org (full text, mbox):

From: Nicolas Petton <nicolas <at> petton.fr>
To: Drew Adams <drew.adams <at> oracle.com>, Alex <agrambot <at> gmail.com>
Cc: 6387 <at> debbugs.gnu.org
Subject: Re: bug#6387: 24.0.50; ESC TAB should be bound to `isearch-complete'
Date: Mon, 22 Aug 2016 00:06:26 +0200

[Message part 1 (text/plain, inline)]

Drew Adams <drew.adams <at> oracle.com> writes:

close 6387
thanks

> Yes.  The bug was fixed in 24.4.

Great, I'm closing this bug report then.

Cheers,
Nico

[signature.asc (application/pgp-signature, inline)]

Previous Next

GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson.