GNU bug report logs - #10097
24.0.91; Lisp mode should use common-lisp-indent-function by default

Previous Next

To add a comment to this bug, you must first unarchive it, by sending
a message to control AT debbugs.gnu.org, with unarchive 10097 in the body.
You can then email your comments to 10097 AT debbugs.gnu.org in the normal way.

Toggle the display of automated, internal messages from the tracker.

Message #5 received at submit <at> debbugs.gnu.org (full text, mbox):

From: Helmut Eller <eller.helmut <at> gmail.com>
To: bug-gnu-emacs <at> gnu.org
Subject: 24.0.91; Lisp mode should use common-lisp-indent-function by default
Date: Mon, 21 Nov 2011 18:10:28 +0100

Lisp mode is supposedly a "Major mode for editing Lisp code for Lisps
other than GNU Emacs Lisp".  Yet the variable lisp-indent-function
remains set to the rather Elisp oriented #'lisp-indent-function.  As
Common Lisp is the most important non-Elisp Lisp
#'common-lisp-indent-function would be a friendlier default as it gets
at least if/flet/labels right more often:

=== modified file 'lisp/emacs-lisp/lisp-mode.el'
--- lisp/emacs-lisp/lisp-mode.el	2011-09-18 20:43:20 +0000
+++ lisp/emacs-lisp/lisp-mode.el	2011-11-21 17:06:50 +0000
@@ -474,6 +474,8 @@
 Entry to this mode calls the value of `lisp-mode-hook'
 if that value is non-nil."
   (lisp-mode-variables nil t)
+  (make-local-variable 'lisp-indent-function)
+  (setq lisp-indent-function 'common-lisp-indent-function)
   (set (make-local-variable 'find-tag-default-function) 'lisp-find-tag-default)
   (make-local-variable 'comment-start-skip)
   (setq comment-start-skip



In GNU Emacs 24.0.91.1 (i686-pc-linux-gnu, GTK+ Version 2.20.1)
 of 2011-11-06 on ix
Windowing system distributor `The X.Org Foundation', version 11.0.10707000
configured using `configure  '--enable-asserts' '--enable-checking' '--with-gif=no' '--with-gnutls=no' 'CFLAGS=-g3 -O0''

Important settings:
  value of $LC_ALL: nil
  value of $LC_COLLATE: nil
  value of $LC_CTYPE: nil
  value of $LC_MESSAGES: nil
  value of $LC_MONETARY: nil
  value of $LC_NUMERIC: nil
  value of $LC_TIME: nil
  value of $LANG: en_US
  value of $XMODIFIERS: nil
  locale-coding-system: iso-latin-1-unix
  default enable-multibyte-characters: nil

Message #10 received at 10097 <at> debbugs.gnu.org (full text, mbox):

From: Lars Ingebrigtsen <larsi <at> gnus.org>
To: Helmut Eller <eller.helmut <at> gmail.com>
Cc: 10097 <at> debbugs.gnu.org
Subject: Re: bug#10097: 24.0.91; Lisp mode should use
 common-lisp-indent-function by default
Date: Thu, 03 Oct 2019 18:31:30 +0200

Helmut Eller <eller.helmut <at> gmail.com> writes:

> Lisp mode is supposedly a "Major mode for editing Lisp code for Lisps
> other than GNU Emacs Lisp".  Yet the variable lisp-indent-function
> remains set to the rather Elisp oriented #'lisp-indent-function.  As
> Common Lisp is the most important non-Elisp Lisp
> #'common-lisp-indent-function would be a friendlier default as it gets
> at least if/flet/labels right more often:

[...]

> +  (make-local-variable 'lisp-indent-function)
> +  (setq lisp-indent-function 'common-lisp-indent-function)

(I'm going through old Emacs bug reports that unfortunately got no
response at the time.)

I think this makes sense -- Common Lisp is the biggest non-Elisp Lisp
dialect, so using this as a default seems good.

However, it's a behaviour change, and people who are used to wrongly
indenting Common Lisp code may be annoyed by the change.

Does anybody have an opinion on changing the default indentation in this
mode?

-- 
(domestic pets only, the antidote for overdose, milk.)
   bloggy blog: http://lars.ingebrigtsen.no

Message #13 received at 10097 <at> debbugs.gnu.org (full text, mbox):

From: Stefan Kangas <stefan <at> marxist.se>
To: Lars Ingebrigtsen <larsi <at> gnus.org>
Cc: Helmut Eller <eller.helmut <at> gmail.com>, 10097 <at> debbugs.gnu.org
Subject: Re: bug#10097: 24.0.91;
 Lisp mode should use common-lisp-indent-function by default
Date: Fri, 17 Jan 2020 00:11:02 +0100

Lars Ingebrigtsen <larsi <at> gnus.org> writes:

> Helmut Eller <eller.helmut <at> gmail.com> writes:
>
>> Lisp mode is supposedly a "Major mode for editing Lisp code for Lisps
>> other than GNU Emacs Lisp".  Yet the variable lisp-indent-function
>> remains set to the rather Elisp oriented #'lisp-indent-function.  As
>> Common Lisp is the most important non-Elisp Lisp
>> #'common-lisp-indent-function would be a friendlier default as it gets
>> at least if/flet/labels right more often:
>
> [...]
>
>> +  (make-local-variable 'lisp-indent-function)
>> +  (setq lisp-indent-function 'common-lisp-indent-function)
>
> (I'm going through old Emacs bug reports that unfortunately got no
> response at the time.)
>
> I think this makes sense -- Common Lisp is the biggest non-Elisp Lisp
> dialect, so using this as a default seems good.
>
> However, it's a behaviour change, and people who are used to wrongly
> indenting Common Lisp code may be annoyed by the change.
>
> Does anybody have an opinion on changing the default indentation in this
> mode?

I think we should change the default as suggested and announce in NEWS
why the change was made, and how to get back the old behaviour.

Best regards,
Stefan Kangas

Message #16 received at 10097 <at> debbugs.gnu.org (full text, mbox):

From: Lars Ingebrigtsen <larsi <at> gnus.org>
To: Stefan Kangas <stefan <at> marxist.se>
Cc: Helmut Eller <eller.helmut <at> gmail.com>, 10097 <at> debbugs.gnu.org
Subject: Re: bug#10097: 24.0.91; Lisp mode should use
 common-lisp-indent-function by default
Date: Wed, 22 Jan 2020 14:18:37 +0100

Stefan Kangas <stefan <at> marxist.se> writes:

> I think we should change the default as suggested and announce in NEWS
> why the change was made, and how to get back the old behaviour.

I agree.  And it's the start of the Emacs 28 cycle now, so there's
plenty of time to roll back if everybody hates the change.

So I've now done this and I'm closing this bug report.

-- 
(domestic pets only, the antidote for overdose, milk.)
   bloggy blog: http://lars.ingebrigtsen.no

Previous Next

GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson.