GNU bug report logs -
#10097
24.0.91; Lisp mode should use common-lisp-indent-function by default
Previous Next
Reported by: Helmut Eller <eller.helmut <at> gmail.com>
Date: Mon, 21 Nov 2011 17:49:01 UTC
Severity: wishlist
Tags: fixed
Found in version 24.0.91
Fixed in version 28.1
Done: Lars Ingebrigtsen <larsi <at> gnus.org>
Bug is archived. No further changes may be made.
To add a comment to this bug, you must first unarchive it, by sending
a message to control AT debbugs.gnu.org, with unarchive 10097 in the body.
You can then email your comments to 10097 AT debbugs.gnu.org in the normal way.
Toggle the display of automated, internal messages from the tracker.
Report forwarded
to
bug-gnu-emacs <at> gnu.org
:
bug#10097
; Package
emacs
.
(Mon, 21 Nov 2011 17:49:01 GMT)
Full text and
rfc822 format available.
Acknowledgement sent
to
Helmut Eller <eller.helmut <at> gmail.com>
:
New bug report received and forwarded. Copy sent to
bug-gnu-emacs <at> gnu.org
.
(Mon, 21 Nov 2011 17:49:01 GMT)
Full text and
rfc822 format available.
Message #5 received at submit <at> debbugs.gnu.org (full text, mbox):
Lisp mode is supposedly a "Major mode for editing Lisp code for Lisps
other than GNU Emacs Lisp". Yet the variable lisp-indent-function
remains set to the rather Elisp oriented #'lisp-indent-function. As
Common Lisp is the most important non-Elisp Lisp
#'common-lisp-indent-function would be a friendlier default as it gets
at least if/flet/labels right more often:
=== modified file 'lisp/emacs-lisp/lisp-mode.el'
--- lisp/emacs-lisp/lisp-mode.el 2011-09-18 20:43:20 +0000
+++ lisp/emacs-lisp/lisp-mode.el 2011-11-21 17:06:50 +0000
@@ -474,6 +474,8 @@
Entry to this mode calls the value of `lisp-mode-hook'
if that value is non-nil."
(lisp-mode-variables nil t)
+ (make-local-variable 'lisp-indent-function)
+ (setq lisp-indent-function 'common-lisp-indent-function)
(set (make-local-variable 'find-tag-default-function) 'lisp-find-tag-default)
(make-local-variable 'comment-start-skip)
(setq comment-start-skip
In GNU Emacs 24.0.91.1 (i686-pc-linux-gnu, GTK+ Version 2.20.1)
of 2011-11-06 on ix
Windowing system distributor `The X.Org Foundation', version 11.0.10707000
configured using `configure '--enable-asserts' '--enable-checking' '--with-gif=no' '--with-gnutls=no' 'CFLAGS=-g3 -O0''
Important settings:
value of $LC_ALL: nil
value of $LC_COLLATE: nil
value of $LC_CTYPE: nil
value of $LC_MESSAGES: nil
value of $LC_MONETARY: nil
value of $LC_NUMERIC: nil
value of $LC_TIME: nil
value of $LANG: en_US
value of $XMODIFIERS: nil
locale-coding-system: iso-latin-1-unix
default enable-multibyte-characters: nil
Severity set to 'wishlist' from 'normal'
Request was from
Glenn Morris <rgm <at> gnu.org>
to
control <at> debbugs.gnu.org
.
(Mon, 21 Nov 2011 18:19:01 GMT)
Full text and
rfc822 format available.
Information forwarded
to
bug-gnu-emacs <at> gnu.org
:
bug#10097
; Package
emacs
.
(Thu, 03 Oct 2019 16:32:02 GMT)
Full text and
rfc822 format available.
Message #10 received at 10097 <at> debbugs.gnu.org (full text, mbox):
Helmut Eller <eller.helmut <at> gmail.com> writes:
> Lisp mode is supposedly a "Major mode for editing Lisp code for Lisps
> other than GNU Emacs Lisp". Yet the variable lisp-indent-function
> remains set to the rather Elisp oriented #'lisp-indent-function. As
> Common Lisp is the most important non-Elisp Lisp
> #'common-lisp-indent-function would be a friendlier default as it gets
> at least if/flet/labels right more often:
[...]
> + (make-local-variable 'lisp-indent-function)
> + (setq lisp-indent-function 'common-lisp-indent-function)
(I'm going through old Emacs bug reports that unfortunately got no
response at the time.)
I think this makes sense -- Common Lisp is the biggest non-Elisp Lisp
dialect, so using this as a default seems good.
However, it's a behaviour change, and people who are used to wrongly
indenting Common Lisp code may be annoyed by the change.
Does anybody have an opinion on changing the default indentation in this
mode?
--
(domestic pets only, the antidote for overdose, milk.)
bloggy blog: http://lars.ingebrigtsen.no
Information forwarded
to
bug-gnu-emacs <at> gnu.org
:
bug#10097
; Package
emacs
.
(Thu, 16 Jan 2020 23:12:02 GMT)
Full text and
rfc822 format available.
Message #13 received at 10097 <at> debbugs.gnu.org (full text, mbox):
Lars Ingebrigtsen <larsi <at> gnus.org> writes:
> Helmut Eller <eller.helmut <at> gmail.com> writes:
>
>> Lisp mode is supposedly a "Major mode for editing Lisp code for Lisps
>> other than GNU Emacs Lisp". Yet the variable lisp-indent-function
>> remains set to the rather Elisp oriented #'lisp-indent-function. As
>> Common Lisp is the most important non-Elisp Lisp
>> #'common-lisp-indent-function would be a friendlier default as it gets
>> at least if/flet/labels right more often:
>
> [...]
>
>> + (make-local-variable 'lisp-indent-function)
>> + (setq lisp-indent-function 'common-lisp-indent-function)
>
> (I'm going through old Emacs bug reports that unfortunately got no
> response at the time.)
>
> I think this makes sense -- Common Lisp is the biggest non-Elisp Lisp
> dialect, so using this as a default seems good.
>
> However, it's a behaviour change, and people who are used to wrongly
> indenting Common Lisp code may be annoyed by the change.
>
> Does anybody have an opinion on changing the default indentation in this
> mode?
I think we should change the default as suggested and announce in NEWS
why the change was made, and how to get back the old behaviour.
Best regards,
Stefan Kangas
Information forwarded
to
bug-gnu-emacs <at> gnu.org
:
bug#10097
; Package
emacs
.
(Wed, 22 Jan 2020 13:19:01 GMT)
Full text and
rfc822 format available.
Message #16 received at 10097 <at> debbugs.gnu.org (full text, mbox):
Stefan Kangas <stefan <at> marxist.se> writes:
> I think we should change the default as suggested and announce in NEWS
> why the change was made, and how to get back the old behaviour.
I agree. And it's the start of the Emacs 28 cycle now, so there's
plenty of time to roll back if everybody hates the change.
So I've now done this and I'm closing this bug report.
--
(domestic pets only, the antidote for overdose, milk.)
bloggy blog: http://lars.ingebrigtsen.no
Added tag(s) fixed.
Request was from
Lars Ingebrigtsen <larsi <at> gnus.org>
to
control <at> debbugs.gnu.org
.
(Wed, 22 Jan 2020 13:19:02 GMT)
Full text and
rfc822 format available.
bug marked as fixed in version 28.1, send any further explanations to
10097 <at> debbugs.gnu.org and Helmut Eller <eller.helmut <at> gmail.com>
Request was from
Lars Ingebrigtsen <larsi <at> gnus.org>
to
control <at> debbugs.gnu.org
.
(Wed, 22 Jan 2020 13:19:02 GMT)
Full text and
rfc822 format available.
bug archived.
Request was from
Debbugs Internal Request <help-debbugs <at> gnu.org>
to
internal_control <at> debbugs.gnu.org
.
(Thu, 20 Feb 2020 12:24:07 GMT)
Full text and
rfc822 format available.
This bug report was last modified 4 years and 58 days ago.
Previous Next
GNU bug tracking system
Copyright (C) 1999 Darren O. Benham,
1997,2003 nCipher Corporation Ltd,
1994-97 Ian Jackson.