GNU logs - #10111, boring messages

Message sent to bug-automake@HIDDEN:

Subject: bug#10111: remake rules can fail in a weird corner case (VPATH into $distdir).
Resent-From: Stefano Lattarini <stefano.lattarini@HIDDEN>
Original-Sender: debbugs-submit-bounces <at> debbugs.gnu.org
Resent-CC: bug-automake@HIDDEN
Resent-Date: Tue, 22 Nov 2011 19:06:02 +0000
Resent-Message-ID: <handler.10111.B.13219887374896 <at> debbugs.gnu.org>
Resent-Sender: help-debbugs@HIDDEN
To: 10111 <at> debbugs.gnu.org
From: Stefano Lattarini <stefano.lattarini@HIDDEN>
Date: Tue, 22 Nov 2011 20:03:51 +0100
User-Agent: KMail/1.13.7 (Linux/2.6.30-2-686; KDE/4.6.5; i686; ; )
MIME-Version: 1.0
Content-Type: Multipart/Mixed;
  boundary="Boundary-00=_YI/yOgBDAnw5EVA"
Message-Id: <201111222003.52223.stefano.lattarini@HIDDEN>
Precedence: list
Sender: debbugs-submit-bounces <at> debbugs.gnu.org
Errors-To: debbugs-submit-bounces <at> debbugs.gnu.org

--Boundary-00=_YI/yOgBDAnw5EVA
Content-Type: Text/Plain;
  charset="utf-8"
Content-Transfer-Encoding: 7bit

Severity: minor
thanks

This report describes a failure of the automake-generated remake
rules in a particular, low-probability scenario.  I admit upfront
that the scenario I'm speaking about is pretty corner-case, and
very unlikely to be problemtic in practice.  Still, I think it's
still worth having a description and a testsuite exposure for the
problem.

Here is how to reporduce the bug, step by step.

  $ mkdir bug
  $ cd bug
  $ cat > configure.ac <<'END'
  AC_INIT([foo], [1.0])
  AM_INIT_AUTOMAKE([foreign])
  m4_include([foobar.m4])
  AC_CONFIG_FILES([Makefile])
  AC_OUTPUT
  END
  $ : > foobar.m4
  $ cat > Makefile.am <<'END'
  $(srcdir)/foobar.m4:
	echo ': foobar was here :' > $@
  END
  $ autoreconf -vi
  autoreconf: Entering directory `.'
  autoreconf: configure.ac: not using Gettext
  autoreconf: running: aclocal 
  autoreconf: configure.ac: tracing
  autoreconf: configure.ac: not using Libtool
  autoreconf: running: /usr/bin/autoconf
  autoreconf: configure.ac: not using Autoheader
  autoreconf: running: automake --add-missing --copy --no-force
  configure.ac:2: installing `./install-sh'
  configure.ac:2: installing `./missing'
  autoreconf: Leaving directory `.'
  $ ./configure
  checking for a BSD-compatible install... /usr/bin/install -c
  checking whether build environment is sane... yes
  ...
  config.status: creating Makefile
  # OK, so the developer wants to interactively try out how the
  # "distributed form" of his package behaves
  $ make distdir
  ...
  $ ls foo-1.0 
  Makefile.am  aclocal.m4  configure.ac  install-sh
  Makefile.in  configure   foobar.m4     missing
  $ cd f00-1.0
  # He's interested in trying out a VPATH build.
  $ mkdir build && cd build
  $ ../configure
  checking for a BSD-compatible install... /usr/bin/install -c
  ...
  config.status: creating Makefile
  # He wants to verify that the rules he's written to rebuild a file
  # included by configure.in works also in VPATH builds.
  $ rm -f ../foobar.m4
  # But things won't work as expected!
  $ make
  make: Nothing to be done for `all'.
  $ ls -l ../foobar.m4
  ls: cannot access ../foobar.m4: No such file or directory
  $ grep foobar ../configure || echo no match
  no match
  # And a spurious error will fail when trying to rebuild the
  # distribution tarball.
  $ make dist
  ...
  test -d "foo-1.0" || mkdir "foo-1.0"
  cp: cannot stat `../foobar.m4': No such file or directory
  make: *** [distdir] Error 1

Let's see the explanation of the bug.  The following dependency is
in the generated Makefile:

  $(top_srcdir)/configure:  $(am__configure_deps)

Once the macros are expanded, this becomes:

  ../configure: ../foobar.m4 ../configure.ac ../aclocal.m4

GNN make sees that `../foobar.m4' does not exists in the current
directory; but since a VPATH build is being performed, make does not
error out, but rather looks for that file in the $(srcdir) directory
too.  Now, in our case `$(srcdir)' is `..', so make looks for the
file `../../foobar.m4' -- which do exists!  In fact, the first `..'
brings us in the `foo-1.0' directory, the second one in the original
test directory -- where our original, empty `foobar.m4' resides.

If this is true, nesting the build directory one level more should
solve the problem -- and it does:

  $ cd ..
  $ mkdir -p build2/sub
  $ cd build2/sub
  $ ../../configure
  checking for a BSD-compatible install... /usr/bin/install -c
  checking whether build environment is sane... yes
  ...
  config.status: creating Makefile
  $ make
  echo ': foobar was here :' > ../../foobar.m4
  CDPATH="${ZSH_VERSION+.}:" && cd ../.. && /bin/sh /tmp/bug/foo-1.0/missing --run aclocal-1.11 
   cd ../.. && /bin/sh /tmp/bug/foo-1.0/missing --run automake-1.11 --foreign
  CDPATH="${ZSH_VERSION+.}:" && cd ../.. && /bin/sh /tmp/bug/foo-1.0/missing --run autoconf
  /bin/sh ./config.status --recheck
  running CONFIG_SHELL=/bin/sh /bin/sh ../../configure --no-create --no-recursion
  checking for a BSD-compatible install... /usr/bin/install -c
  ...
  configure: creating ./config.status
   /bin/sh ./config.status
  config.status: creating Makefile
  make: Nothing to be done for `all'.

Attached are two test scripts that expose the bug for the related but
slightly different cases of an `.m4' file included by `configure.ac'
and an `.am' file included by `Makefile.am'.  I will soonish add them
to the maint branch if there is no objection.

Regards,
  Stefano

--Boundary-00=_YI/yOgBDAnw5EVA
Content-Type: application/x-shellscript;
  name="foo1.test"
Content-Transfer-Encoding: 7bit
Content-Disposition: inline;
	filename="foo1.test"

#! /bin/sh
# Copyright (C) 2011 Free Software Foundation, Inc.
#
# This program is free software; you can redistribute it and/or modify
# it under the terms of the GNU General Public License as published by
# the Free Software Foundation; either version 2, or (at your option)
# any later version.
#
# This program is distributed in the hope that it will be useful,
# but WITHOUT ANY WARRANTY; without even the implied warranty of
# MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE.  See the
# GNU General Public License for more details.
#
# You should have received a copy of the GNU General Public License
# along with this program.  If not, see <http://www.gnu.org/licenses/>.

# Check that our remake rules doesn't give spurious successes in
# some corner case situations where they should actually fail.
# See automake bug#XXX.
# To be clear, we are speaking about *very* corner-case situations here,
# and the fact that the remake rules might get confused in them is not a
# big deal in practice (in fact, this test *currently fails*).  Still,
# keeping the limitation exposed is a good idea anyway.

. ./defs || Exit 1

set -e

cat >> configure.in <<'END'
m4_include([foobar.m4])
AC_OUTPUT
END

: > foobar.m4

cat > Makefile.am <<'END'
$(srcdir)/foobar.m4:
	echo ': foobar was here :' > $@
END

$ACLOCAL
$AUTOCONF
$AUTOMAKE

./configure

# OK, so the developer wants to interactively try out how the
# "distributed form" of his package behaves.
$MAKE distdir
cd $distdir
# He's interested in trying out a VPATH build.
mkdir build
cd build
../configure
# He wants to verify that the rules he's written to rebuild a file
# included by configure.in works also in VPATH builds.
rm -f ../foobar.m4
$MAKE
grep ': foobar was here :' ../configure
$MAKE distcheck

:

--Boundary-00=_YI/yOgBDAnw5EVA
Content-Type: application/x-shellscript;
  name="foo2.test"
Content-Transfer-Encoding: 7bit
Content-Disposition: inline;
	filename="foo2.test"

#! /bin/sh
# Copyright (C) 2011 Free Software Foundation, Inc.
#
# This program is free software; you can redistribute it and/or modify
# it under the terms of the GNU General Public License as published by
# the Free Software Foundation; either version 2, or (at your option)
# any later version.
#
# This program is distributed in the hope that it will be useful,
# but WITHOUT ANY WARRANTY; without even the implied warranty of
# MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE.  See the
# GNU General Public License for more details.
#
# You should have received a copy of the GNU General Public License
# along with this program.  If not, see <http://www.gnu.org/licenses/>.

# Check that our remake rules doesn't give spurious successes in
# some corner case situations where they should actually fail.
# See automake bug#XXX.
# To be clear, we are speaking about *very* corner-case situations here,
# and the fact that the remake rules might get confused in them is not a
# big deal in practice (in fact, this test *currently fails*).  Still,
# keeping the limitation exposed is a good idea anyway.

. ./defs || Exit 1

set -e

cat >> configure.in <<'END'
AC_OUTPUT
END

: > foobar.am

cat > Makefile.am <<'END'
include $(srcdir)/foobar.am
$(srcdir)/foobar.am:
## Creative quoring to avoid spurious matches in the grepping
## of Makefile.in, later.
	echo '#' 'foobar' 'was 'here' '#' > $@
END

$ACLOCAL
$AUTOCONF
$AUTOMAKE

./configure

# OK, so the developer wants to interactively try out how the
# "distributed form" of his package behaves.
$MAKE distdir
cd $distdir
# He's interested in trying out a VPATH build.
mkdir build
cd build
../configure
# He wants to verify that the rules he's written to rebuild a file
# included by configure.in works also in VPATH builds.
rm -f ../foobar.am
$MAKE
grep '# foobar was here #' ../Makefile.in
$MAKE distcheck

:

--Boundary-00=_YI/yOgBDAnw5EVA--

Message sent:

Content-Disposition: inline
Content-Transfer-Encoding: quoted-printable
MIME-Version: 1.0
X-Mailer: MIME-tools 5.427 (Entity 5.427)
Content-Type: text/plain; charset=utf-8
X-Loop: help-debbugs@HIDDEN
From: help-debbugs@HIDDEN (GNU bug Tracking System)
To: Stefano Lattarini <stefano.lattarini@HIDDEN>
Subject: bug#10111: Acknowledgement (remake rules can fail in a weird
 corner case (VPATH into $distdir).)
Message-ID: <handler.10111.B.13219887374896.ack <at> debbugs.gnu.org>
References: <201111222003.52223.stefano.lattarini@HIDDEN>
X-Gnu-PR-Message: ack 10111
X-Gnu-PR-Package: automake
Reply-To: 10111 <at> debbugs.gnu.org
Date: Tue, 22 Nov 2011 19:06:02 +0000

Thank you for filing a new bug report with debbugs.gnu.org.

This is an automatically generated reply to let you know your message
has been received.

Your message is being forwarded to the package maintainers and other
interested parties for their attention; they will reply in due course.

Your message has been sent to the package maintainer(s):
 bug-automake@HIDDEN

If you wish to submit further information on this problem, please
send it to 10111 <at> debbugs.gnu.org.

Please do not send mail to help-debbugs@HIDDEN unless you wish
to report a problem with the Bug-tracking system.

--=20
10111: http://debbugs.gnu.org/cgi/bugreport.cgi?bug=3D10111
GNU Bug Tracking System
Contact help-debbugs@HIDDEN with problems

Message sent to bug-automake@HIDDEN:

Subject: bug#10111: remake rules can fail in a weird corner case (VPATH into $distdir).
Resent-From: Stefano Lattarini <stefano.lattarini@HIDDEN>
Original-Sender: debbugs-submit-bounces <at> debbugs.gnu.org
Resent-CC: bug-automake@HIDDEN
Resent-Date: Tue, 22 Nov 2011 20:27:02 +0000
Resent-Message-ID: <handler.10111.B.132199360515170 <at> debbugs.gnu.org>
Resent-Sender: help-debbugs@HIDDEN
To: 10111 <at> debbugs.gnu.org
Cc: automake-patches@HIDDEN
From: Stefano Lattarini <stefano.lattarini@HIDDEN>
Date: Tue, 22 Nov 2011 21:24:58 +0100
User-Agent: KMail/1.13.7 (Linux/2.6.30-2-686; KDE/4.6.5; i686; ; )
References: <201111222003.52223.stefano.lattarini@HIDDEN>
In-Reply-To: <201111222003.52223.stefano.lattarini@HIDDEN>
MIME-Version: 1.0
Content-Type: Multipart/Mixed;
  boundary="Boundary-00=_bUAzOoEecrs2Pxr"
Message-Id: <201111222124.59460.stefano.lattarini@HIDDEN>
Precedence: list
Sender: debbugs-submit-bounces <at> debbugs.gnu.org
Errors-To: debbugs-submit-bounces <at> debbugs.gnu.org

--Boundary-00=_bUAzOoEecrs2Pxr
Content-Type: Text/Plain;
  charset="utf-8"
Content-Transfer-Encoding: 7bit

[adding automake-patches]

Reference:
 <http://debbugs.gnu.org/cgi/bugreport.cgi?bug=10111>

On Tuesday 22 November 2011, Stefano Lattarini wrote:
> Attached are two test scripts that expose the bug for the related but
> slightly different cases of an `.m4' file included by `configure.ac'
> and an `.am' file included by `Makefile.am'.  I will soonish add them
> to the maint branch if there is no objection.
>
Done with the attached patch.

Regards,
  Stefano


--Boundary-00=_bUAzOoEecrs2Pxr
Content-Type: text/x-patch;
  charset="utf-8";
  name="0001-remake-expose-automake-bug-10111-in-the-testsuite.patch"
Content-Transfer-Encoding: quoted-printable
Content-Disposition: inline;
	filename="0001-remake-expose-automake-bug-10111-in-the-testsuite.patch"

=46rom 96b93273f629c4844e19d429a1cec61ff6d406c4 Mon Sep 17 00:00:00 2001
Message-Id: <96b93273f629c4844e19d429a1cec61ff6d406c4.1321991878.git.stefan=
o.lattarini@HIDDEN>
=46rom: Stefano Lattarini <stefano.lattarini@HIDDEN>
Date: Tue, 22 Nov 2011 20:50:53 +0100
Subject: [PATCH] remake: expose automake bug#10111 in the testsuite

* tests/remake-am-pr10111.test: New test, xfailing.
* tests/remake-m4-pr10111.test: Likewise.
* tests/Makefile.am (TESTS, XFAIL_TESTS): Add them.
=2D--
 ChangeLog                    |    7 ++++
 tests/Makefile.am            |    4 ++
 tests/Makefile.in            |    4 ++
 tests/remake-am-pr10111.test |   64 ++++++++++++++++++++++++++++++++++++++=
++++
 tests/remake-m4-pr10111.test |   62 ++++++++++++++++++++++++++++++++++++++=
++
 5 files changed, 141 insertions(+), 0 deletions(-)
 create mode 100644 tests/remake-am-pr10111.test
 create mode 100644 tests/remake-m4-pr10111.test

diff --git a/ChangeLog b/ChangeLog
index a828c21..0151d96 100644
=2D-- a/ChangeLog
+++ b/ChangeLog
@@ -1,3 +1,10 @@
+2011-11-22  Stefano Lattarini  <stefano.lattarini@HIDDEN>
+
+	remake: expose automake bug#10111 in the testsuite
+	* tests/remake-am-pr10111.test: New test, xfailing.
+	* tests/remake-m4-pr10111.test: Likewise.
+	* tests/Makefile.am (TESTS, XFAIL_TESTS): Add them.
+
 2011-11-19  Stefano Lattarini  <stefano.lattarini@HIDDEN>
=20
 	texinfo: work around Solaris 10 xpg4 shell bug in install rules
diff --git a/tests/Makefile.am b/tests/Makefile.am
index dd3fb46..936b781 100644
=2D-- a/tests/Makefile.am
+++ b/tests/Makefile.am
@@ -26,6 +26,8 @@ gcj6.test \
 java-nobase.test \
 pr8365-remake-timing.test \
 lex-subobj-nodep.test \
+remake-am-pr10111.test \
+remake-m4-pr10111.test \
 vala-vpath.test \
 txinfo5.test
=20
@@ -722,6 +724,8 @@ remake-subdir-gnu.test \
 remake-subdir.test \
 remake-subdir2.test \
 remake-subdir-long-time.test \
+remake-am-pr10111.test \
+remake-m4-pr10111.test \
 pr8365-remake-timing.test \
 regex.test \
 req.test \
diff --git a/tests/Makefile.in b/tests/Makefile.in
index d2085c8..18983ae 100644
=2D-- a/tests/Makefile.in
+++ b/tests/Makefile.in
@@ -297,6 +297,8 @@ gcj6.test \
 java-nobase.test \
 pr8365-remake-timing.test \
 lex-subobj-nodep.test \
+remake-am-pr10111.test \
+remake-m4-pr10111.test \
 vala-vpath.test \
 txinfo5.test
=20
@@ -1006,6 +1008,8 @@ remake-subdir-gnu.test \
 remake-subdir.test \
 remake-subdir2.test \
 remake-subdir-long-time.test \
+remake-am-pr10111.test \
+remake-m4-pr10111.test \
 pr8365-remake-timing.test \
 regex.test \
 req.test \
diff --git a/tests/remake-am-pr10111.test b/tests/remake-am-pr10111.test
new file mode 100644
index 0000000..a8c2dc6
=2D-- /dev/null
+++ b/tests/remake-am-pr10111.test
@@ -0,0 +1,64 @@
+#! /bin/sh
+# Copyright (C) 2011 Free Software Foundation, Inc.
+#
+# This program is free software; you can redistribute it and/or modify
+# it under the terms of the GNU General Public License as published by
+# the Free Software Foundation; either version 2, or (at your option)
+# any later version.
+#
+# This program is distributed in the hope that it will be useful,
+# but WITHOUT ANY WARRANTY; without even the implied warranty of
+# MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE.  See the
+# GNU General Public License for more details.
+#
+# You should have received a copy of the GNU General Public License
+# along with this program.  If not, see <http://www.gnu.org/licenses/>.
+
+# Check that our remake rules doesn't give spurious successes in
+# some corner case situations where they should actually fail.
+# See automake bug#10111.
+# To be clear, we are speaking about *very* corner-case situations here,
+# and the fact that the remake rules might get confused in them is not a
+# big deal in practice (in fact, this test *currently fails*).  Still,
+# keeping the limitation exposed is a good idea anyway.
+
+. ./defs || Exit 1
+
+set -e
+
+cat >> configure.in <<'END'
+AC_OUTPUT
+END
+
+: > foobar.am
+
+cat > Makefile.am <<'END'
+include $(srcdir)/foobar.am
+$(srcdir)/foobar.am:
+## Creative quoring to avoid spurious matches in the grepping
+## of Makefile.in, later.
+	echo '#' 'foobar' 'was 'here' '#' > $@
+END
+
+$ACLOCAL
+$AUTOCONF
+$AUTOMAKE
+
+./configure
+
+# OK, so the developer wants to interactively try out how the
+# "distributed form" of his package behaves.
+$MAKE distdir
+cd $distdir
+# He's interested in trying out a VPATH build.
+mkdir build
+cd build
+../configure
+# He wants to verify that the rules he's written to rebuild a file
+# included by configure.in works also in VPATH builds.
+rm -f ../foobar.am
+$MAKE
+grep '# foobar was here #' ../Makefile.in
+$MAKE distcheck
+
+:
diff --git a/tests/remake-m4-pr10111.test b/tests/remake-m4-pr10111.test
new file mode 100644
index 0000000..2d89c25
=2D-- /dev/null
+++ b/tests/remake-m4-pr10111.test
@@ -0,0 +1,62 @@
+#! /bin/sh
+# Copyright (C) 2011 Free Software Foundation, Inc.
+#
+# This program is free software; you can redistribute it and/or modify
+# it under the terms of the GNU General Public License as published by
+# the Free Software Foundation; either version 2, or (at your option)
+# any later version.
+#
+# This program is distributed in the hope that it will be useful,
+# but WITHOUT ANY WARRANTY; without even the implied warranty of
+# MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE.  See the
+# GNU General Public License for more details.
+#
+# You should have received a copy of the GNU General Public License
+# along with this program.  If not, see <http://www.gnu.org/licenses/>.
+
+# Check that our remake rules doesn't give spurious successes in
+# some corner case situations where they should actually fail.
+# See automake bug#10111.
+# To be clear, we are speaking about *very* corner-case situations here,
+# and the fact that the remake rules might get confused in them is not a
+# big deal in practice (in fact, this test *currently fails*).  Still,
+# keeping the limitation exposed is a good idea anyway.
+
+. ./defs || Exit 1
+
+set -e
+
+cat >> configure.in <<'END'
+m4_include([foobar.m4])
+AC_OUTPUT
+END
+
+: > foobar.m4
+
+cat > Makefile.am <<'END'
+$(srcdir)/foobar.m4:
+	echo ': foobar was here :' > $@
+END
+
+$ACLOCAL
+$AUTOCONF
+$AUTOMAKE
+
+./configure
+
+# OK, so the developer wants to interactively try out how the
+# "distributed form" of his package behaves.
+$MAKE distdir
+cd $distdir
+# He's interested in trying out a VPATH build.
+mkdir build
+cd build
+../configure
+# He wants to verify that the rules he's written to rebuild a file
+# included by configure.in works also in VPATH builds.
+rm -f ../foobar.m4
+$MAKE
+grep ': foobar was here :' ../configure
+$MAKE distcheck
+
+:
=2D-=20
1.7.2.3


--Boundary-00=_bUAzOoEecrs2Pxr--

Message sent to bug-automake@HIDDEN:

Subject: bug#10111: remake rules can fail in a weird corner case (VPATH into $distdir).
Resent-From: Stefano Lattarini <stefano.lattarini@HIDDEN>
Original-Sender: debbugs-submit-bounces <at> debbugs.gnu.org
Resent-CC: bug-automake@HIDDEN
Resent-Date: Tue, 22 Nov 2011 20:27:02 +0000
Resent-Message-ID: <handler.10111.B10111.132199359715151 <at> debbugs.gnu.org>
Resent-Sender: help-debbugs@HIDDEN
To: 10111 <at> debbugs.gnu.org
Cc: automake-patches@HIDDEN
From: Stefano Lattarini <stefano.lattarini@HIDDEN>
Date: Tue, 22 Nov 2011 21:24:58 +0100
User-Agent: KMail/1.13.7 (Linux/2.6.30-2-686; KDE/4.6.5; i686; ; )
References: <201111222003.52223.stefano.lattarini@HIDDEN>
In-Reply-To: <201111222003.52223.stefano.lattarini@HIDDEN>
MIME-Version: 1.0
Content-Type: Multipart/Mixed;
  boundary="Boundary-00=_bUAzOoEecrs2Pxr"
Message-Id: <201111222124.59460.stefano.lattarini@HIDDEN>
Precedence: list
Sender: debbugs-submit-bounces <at> debbugs.gnu.org
Errors-To: debbugs-submit-bounces <at> debbugs.gnu.org

--Boundary-00=_bUAzOoEecrs2Pxr
Content-Type: Text/Plain;
  charset="utf-8"
Content-Transfer-Encoding: 7bit

[adding automake-patches]

Reference:
 <http://debbugs.gnu.org/cgi/bugreport.cgi?bug=10111>

On Tuesday 22 November 2011, Stefano Lattarini wrote:
> Attached are two test scripts that expose the bug for the related but
> slightly different cases of an `.m4' file included by `configure.ac'
> and an `.am' file included by `Makefile.am'.  I will soonish add them
> to the maint branch if there is no objection.
>
Done with the attached patch.

Regards,
  Stefano


--Boundary-00=_bUAzOoEecrs2Pxr
Content-Type: text/x-patch;
  charset="utf-8";
  name="0001-remake-expose-automake-bug-10111-in-the-testsuite.patch"
Content-Transfer-Encoding: quoted-printable
Content-Disposition: inline;
	filename="0001-remake-expose-automake-bug-10111-in-the-testsuite.patch"

=46rom 96b93273f629c4844e19d429a1cec61ff6d406c4 Mon Sep 17 00:00:00 2001
Message-Id: <96b93273f629c4844e19d429a1cec61ff6d406c4.1321991878.git.stefan=
o.lattarini@HIDDEN>
=46rom: Stefano Lattarini <stefano.lattarini@HIDDEN>
Date: Tue, 22 Nov 2011 20:50:53 +0100
Subject: [PATCH] remake: expose automake bug#10111 in the testsuite

* tests/remake-am-pr10111.test: New test, xfailing.
* tests/remake-m4-pr10111.test: Likewise.
* tests/Makefile.am (TESTS, XFAIL_TESTS): Add them.
=2D--
 ChangeLog                    |    7 ++++
 tests/Makefile.am            |    4 ++
 tests/Makefile.in            |    4 ++
 tests/remake-am-pr10111.test |   64 ++++++++++++++++++++++++++++++++++++++=
++++
 tests/remake-m4-pr10111.test |   62 ++++++++++++++++++++++++++++++++++++++=
++
 5 files changed, 141 insertions(+), 0 deletions(-)
 create mode 100644 tests/remake-am-pr10111.test
 create mode 100644 tests/remake-m4-pr10111.test

diff --git a/ChangeLog b/ChangeLog
index a828c21..0151d96 100644
=2D-- a/ChangeLog
+++ b/ChangeLog
@@ -1,3 +1,10 @@
+2011-11-22  Stefano Lattarini  <stefano.lattarini@HIDDEN>
+
+	remake: expose automake bug#10111 in the testsuite
+	* tests/remake-am-pr10111.test: New test, xfailing.
+	* tests/remake-m4-pr10111.test: Likewise.
+	* tests/Makefile.am (TESTS, XFAIL_TESTS): Add them.
+
 2011-11-19  Stefano Lattarini  <stefano.lattarini@HIDDEN>
=20
 	texinfo: work around Solaris 10 xpg4 shell bug in install rules
diff --git a/tests/Makefile.am b/tests/Makefile.am
index dd3fb46..936b781 100644
=2D-- a/tests/Makefile.am
+++ b/tests/Makefile.am
@@ -26,6 +26,8 @@ gcj6.test \
 java-nobase.test \
 pr8365-remake-timing.test \
 lex-subobj-nodep.test \
+remake-am-pr10111.test \
+remake-m4-pr10111.test \
 vala-vpath.test \
 txinfo5.test
=20
@@ -722,6 +724,8 @@ remake-subdir-gnu.test \
 remake-subdir.test \
 remake-subdir2.test \
 remake-subdir-long-time.test \
+remake-am-pr10111.test \
+remake-m4-pr10111.test \
 pr8365-remake-timing.test \
 regex.test \
 req.test \
diff --git a/tests/Makefile.in b/tests/Makefile.in
index d2085c8..18983ae 100644
=2D-- a/tests/Makefile.in
+++ b/tests/Makefile.in
@@ -297,6 +297,8 @@ gcj6.test \
 java-nobase.test \
 pr8365-remake-timing.test \
 lex-subobj-nodep.test \
+remake-am-pr10111.test \
+remake-m4-pr10111.test \
 vala-vpath.test \
 txinfo5.test
=20
@@ -1006,6 +1008,8 @@ remake-subdir-gnu.test \
 remake-subdir.test \
 remake-subdir2.test \
 remake-subdir-long-time.test \
+remake-am-pr10111.test \
+remake-m4-pr10111.test \
 pr8365-remake-timing.test \
 regex.test \
 req.test \
diff --git a/tests/remake-am-pr10111.test b/tests/remake-am-pr10111.test
new file mode 100644
index 0000000..a8c2dc6
=2D-- /dev/null
+++ b/tests/remake-am-pr10111.test
@@ -0,0 +1,64 @@
+#! /bin/sh
+# Copyright (C) 2011 Free Software Foundation, Inc.
+#
+# This program is free software; you can redistribute it and/or modify
+# it under the terms of the GNU General Public License as published by
+# the Free Software Foundation; either version 2, or (at your option)
+# any later version.
+#
+# This program is distributed in the hope that it will be useful,
+# but WITHOUT ANY WARRANTY; without even the implied warranty of
+# MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE.  See the
+# GNU General Public License for more details.
+#
+# You should have received a copy of the GNU General Public License
+# along with this program.  If not, see <http://www.gnu.org/licenses/>.
+
+# Check that our remake rules doesn't give spurious successes in
+# some corner case situations where they should actually fail.
+# See automake bug#10111.
+# To be clear, we are speaking about *very* corner-case situations here,
+# and the fact that the remake rules might get confused in them is not a
+# big deal in practice (in fact, this test *currently fails*).  Still,
+# keeping the limitation exposed is a good idea anyway.
+
+. ./defs || Exit 1
+
+set -e
+
+cat >> configure.in <<'END'
+AC_OUTPUT
+END
+
+: > foobar.am
+
+cat > Makefile.am <<'END'
+include $(srcdir)/foobar.am
+$(srcdir)/foobar.am:
+## Creative quoring to avoid spurious matches in the grepping
+## of Makefile.in, later.
+	echo '#' 'foobar' 'was 'here' '#' > $@
+END
+
+$ACLOCAL
+$AUTOCONF
+$AUTOMAKE
+
+./configure
+
+# OK, so the developer wants to interactively try out how the
+# "distributed form" of his package behaves.
+$MAKE distdir
+cd $distdir
+# He's interested in trying out a VPATH build.
+mkdir build
+cd build
+../configure
+# He wants to verify that the rules he's written to rebuild a file
+# included by configure.in works also in VPATH builds.
+rm -f ../foobar.am
+$MAKE
+grep '# foobar was here #' ../Makefile.in
+$MAKE distcheck
+
+:
diff --git a/tests/remake-m4-pr10111.test b/tests/remake-m4-pr10111.test
new file mode 100644
index 0000000..2d89c25
=2D-- /dev/null
+++ b/tests/remake-m4-pr10111.test
@@ -0,0 +1,62 @@
+#! /bin/sh
+# Copyright (C) 2011 Free Software Foundation, Inc.
+#
+# This program is free software; you can redistribute it and/or modify
+# it under the terms of the GNU General Public License as published by
+# the Free Software Foundation; either version 2, or (at your option)
+# any later version.
+#
+# This program is distributed in the hope that it will be useful,
+# but WITHOUT ANY WARRANTY; without even the implied warranty of
+# MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE.  See the
+# GNU General Public License for more details.
+#
+# You should have received a copy of the GNU General Public License
+# along with this program.  If not, see <http://www.gnu.org/licenses/>.
+
+# Check that our remake rules doesn't give spurious successes in
+# some corner case situations where they should actually fail.
+# See automake bug#10111.
+# To be clear, we are speaking about *very* corner-case situations here,
+# and the fact that the remake rules might get confused in them is not a
+# big deal in practice (in fact, this test *currently fails*).  Still,
+# keeping the limitation exposed is a good idea anyway.
+
+. ./defs || Exit 1
+
+set -e
+
+cat >> configure.in <<'END'
+m4_include([foobar.m4])
+AC_OUTPUT
+END
+
+: > foobar.m4
+
+cat > Makefile.am <<'END'
+$(srcdir)/foobar.m4:
+	echo ': foobar was here :' > $@
+END
+
+$ACLOCAL
+$AUTOCONF
+$AUTOMAKE
+
+./configure
+
+# OK, so the developer wants to interactively try out how the
+# "distributed form" of his package behaves.
+$MAKE distdir
+cd $distdir
+# He's interested in trying out a VPATH build.
+mkdir build
+cd build
+../configure
+# He wants to verify that the rules he's written to rebuild a file
+# included by configure.in works also in VPATH builds.
+rm -f ../foobar.m4
+$MAKE
+grep ': foobar was here :' ../configure
+$MAKE distcheck
+
+:
=2D-=20
1.7.2.3


--Boundary-00=_bUAzOoEecrs2Pxr--

Message sent to bug-automake@HIDDEN:

X-Loop: help-debbugs@HIDDEN
Subject: bug#10111: typo fix
References: <201111222003.52223.stefano.lattarini@HIDDEN>
In-Reply-To: <201111222003.52223.stefano.lattarini@HIDDEN>
Resent-From: Krzysztof =?UTF-8?Q?=C5=BBelechowski?= <giecrilj@HIDDEN>
Original-Sender: debbugs-submit-bounces <at> debbugs.gnu.org
Resent-CC: bug-automake@HIDDEN
Resent-Date: Wed, 23 Nov 2011 10:13:02 +0000
Resent-Message-ID: <handler.10111.B10111.132204316228225 <at> debbugs.gnu.org>
Resent-Sender: help-debbugs@HIDDEN
X-GNU-PR-Message: followup 10111
X-GNU-PR-Package: automake
X-GNU-PR-Keywords: 
To: 10111 <at> debbugs.gnu.org
Received: via spool by 10111-submit <at> debbugs.gnu.org id=B10111.132204316228225
          (code B ref 10111); Wed, 23 Nov 2011 10:13:02 +0000
Received: (at 10111) by debbugs.gnu.org; 23 Nov 2011 10:12:42 +0000
Received: from localhost ([127.0.0.1] helo=debbugs.gnu.org)
	by debbugs.gnu.org with esmtp (Exim 4.69)
	(envelope-from <debbugs-submit-bounces <at> debbugs.gnu.org>)
	id 1RT9on-0007LC-Gr
	for submit <at> debbugs.gnu.org; Wed, 23 Nov 2011 05:12:41 -0500
Received: from shark.2a.pl ([195.117.102.3])
	by debbugs.gnu.org with esmtp (Exim 4.69)
	(envelope-from <giecrilj@HIDDEN>) id 1RT9ol-0007L5-5B
	for 10111 <at> debbugs.gnu.org; Wed, 23 Nov 2011 05:12:39 -0500
Received: from av.2a.pl (av.2a.pl [195.117.102.9])
	by shark.2a.pl (Postfix) with ESMTP id 123442A6DBF
	for <10111 <at> debbugs.gnu.org>; Wed, 23 Nov 2011 11:11:14 +0100 (CET)
X-Virus-Scanned: amavisd-new at 2a.pl
Received: from shark.2a.pl ([195.117.102.3])
	by av.2a.pl (av.2a.pl [195.117.102.9]) (amavisd-new, port 10024)
	with ESMTP id KnEn0mYh+lDi for <10111 <at> debbugs.gnu.org>;
	Wed, 23 Nov 2011 11:11:03 +0100 (CET)
Received: from [10.8.1.26] (unknown [10.8.1.26])
	by shark.2a.pl (Postfix) with ESMTPA id 9F6ED2A6D80
	for <10111 <at> debbugs.gnu.org>; Wed, 23 Nov 2011 11:11:03 +0100 (CET)
Message-ID: <4ECCC6B2.4060507@HIDDEN>
Date: Wed, 23 Nov 2011 11:10:58 +0100
From: Krzysztof =?UTF-8?Q?=C5=BBelechowski?=
 <giecrilj@HIDDEN>
User-Agent: Mozilla/5.0 (X11; Linux i686;
	rv:7.0.1) Gecko/20110929 Firefox/7.0.1 SeaMonkey/2.4.1
MIME-Version: 1.0
Content-Type: text/plain; charset=UTF-8; format=flowed
Content-Transfer-Encoding: 7bit
X-Spam-Score: -3.6 (---)
X-BeenThere: debbugs-submit <at> debbugs.gnu.org
X-Mailman-Version: 2.1.11
Precedence: list
List-Id: <debbugs-submit.debbugs.gnu.org>
List-Unsubscribe: <http://debbugs.gnu.org/cgi-bin/mailman/options/debbugs-submit>,
	<mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=unsubscribe>
List-Archive: <http://debbugs.gnu.org/cgi-bin/mailman/private/debbugs-submit>
List-Post: <mailto:debbugs-submit <at> debbugs.gnu.org>
List-Help: <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=help>
List-Subscribe: <http://debbugs.gnu.org/cgi-bin/mailman/listinfo/debbugs-submit>,
	<mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=subscribe>
Sender: debbugs-submit-bounces <at> debbugs.gnu.org
Errors-To: debbugs-submit-bounces <at> debbugs.gnu.org
X-Spam-Score: -3.5 (---)

> +## Creative quoring to avoid spurious matches in the grepping
quoting

Message sent to bug-automake@HIDDEN:

X-Loop: help-debbugs@HIDDEN
Subject: bug#10111: typo fix
Resent-From: Stefano Lattarini <stefano.lattarini@HIDDEN>
Original-Sender: debbugs-submit-bounces <at> debbugs.gnu.org
Resent-CC: bug-automake@HIDDEN
Resent-Date: Thu, 24 Nov 2011 14:54:02 +0000
Resent-Message-ID: <handler.10111.B10111.132214643731734 <at> debbugs.gnu.org>
Resent-Sender: help-debbugs@HIDDEN
X-GNU-PR-Message: followup 10111
X-GNU-PR-Package: automake
X-GNU-PR-Keywords: 
To: Krzysztof =?UTF-8?Q?=C5=BBelechowski?= <giecrilj@HIDDEN>
Cc: 10111 <at> debbugs.gnu.org, automake-patches@HIDDEN
Received: via spool by 10111-submit <at> debbugs.gnu.org id=B10111.132214643731734
          (code B ref 10111); Thu, 24 Nov 2011 14:54:02 +0000
Received: (at 10111) by debbugs.gnu.org; 24 Nov 2011 14:53:57 +0000
Received: from localhost ([127.0.0.1] helo=debbugs.gnu.org)
	by debbugs.gnu.org with esmtp (Exim 4.69)
	(envelope-from <debbugs-submit-bounces <at> debbugs.gnu.org>)
	id 1RTagX-0008Fn-0i
	for submit <at> debbugs.gnu.org; Thu, 24 Nov 2011 09:53:57 -0500
Received: from mail-ww0-f46.google.com ([74.125.82.46])
	by debbugs.gnu.org with esmtp (Exim 4.69)
	(envelope-from <stefano.lattarini@HIDDEN>) id 1RTagS-0008Fd-1S
	for 10111 <at> debbugs.gnu.org; Thu, 24 Nov 2011 09:53:55 -0500
Received: by wwg9 with SMTP id 9so3086570wwg.15
	for <10111 <at> debbugs.gnu.org>; Thu, 24 Nov 2011 06:52:19 -0800 (PST)
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=gamma;
	h=from:to:subject:date:user-agent:cc:references:in-reply-to
	:mime-version:message-id:content-type;
	bh=1AbOcWmYw/3dJIXBpjahNepOptSb7SK98R03boVP1qU=;
	b=k3IBJwsSeWh+WmsHi74P9zZWkfMFunEEHjEnzR0kx1G7uzKSKgWDje+a98LJjP7uYF
	3/nqmDH5/ATR9OzlAdZ7Yn0sfOQn8IwRuJo4red7iCiRgH9OITrHZUjtc4xkgKudqsJE
	suQ0ryM8CU098wm7UMHC0qlGg6TV5pSWG5MuM=
Received: by 10.216.24.21 with SMTP id w21mr410653wew.57.1322146339823;
	Thu, 24 Nov 2011 06:52:19 -0800 (PST)
Received: from bigio.localnet
	(host129-94-dynamic.7-79-r.retail.telecomitalia.it. [79.7.94.129])
	by mx.google.com with ESMTPS id hq5sm9515914wib.7.2011.11.24.06.52.17
	(version=TLSv1/SSLv3 cipher=OTHER);
	Thu, 24 Nov 2011 06:52:18 -0800 (PST)
From: Stefano Lattarini <stefano.lattarini@HIDDEN>
Date: Thu, 24 Nov 2011 15:52:08 +0100
User-Agent: KMail/1.13.7 (Linux/2.6.30-2-686; KDE/4.6.5; i686; ; )
References: <201111222003.52223.stefano.lattarini@HIDDEN>
	<4ECCC6B2.4060507@HIDDEN>
In-Reply-To: <4ECCC6B2.4060507@HIDDEN>
MIME-Version: 1.0
Message-Id: <201111241552.09547.stefano.lattarini@HIDDEN>
Content-Type: Multipart/Mixed;
  boundary="Boundary-00=_ZolzOc6XtFDZ5/N"
X-Spam-Score: -3.9 (---)
X-BeenThere: debbugs-submit <at> debbugs.gnu.org
X-Mailman-Version: 2.1.11
Precedence: list
List-Id: <debbugs-submit.debbugs.gnu.org>
List-Unsubscribe: <http://debbugs.gnu.org/cgi-bin/mailman/options/debbugs-submit>,
	<mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=unsubscribe>
List-Archive: <http://debbugs.gnu.org/cgi-bin/mailman/private/debbugs-submit>
List-Post: <mailto:debbugs-submit <at> debbugs.gnu.org>
List-Help: <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=help>
List-Subscribe: <http://debbugs.gnu.org/cgi-bin/mailman/listinfo/debbugs-submit>,
	<mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=subscribe>
Sender: debbugs-submit-bounces <at> debbugs.gnu.org
Errors-To: debbugs-submit-bounces <at> debbugs.gnu.org
X-Spam-Score: -3.9 (---)

--Boundary-00=_ZolzOc6XtFDZ5/N
Content-Type: text/plain;
  charset="utf-8"
Content-Transfer-Encoding: quoted-printable

On Wednesday 23 November 2011, Krzysztof =C5=BBelechowski wrote:
> > +## Creative quoring to avoid spurious matches in the grepping
> quoting
>=20
Thanks for spotting it.  Fixed by the attached patch.

Regards,
  Stefano

--Boundary-00=_ZolzOc6XtFDZ5/N
Content-Type: text/x-patch;
  charset="utf-8";
  name="0001-cosmetics-typofix-in-comments.patch"
Content-Transfer-Encoding: quoted-printable
Content-Disposition: inline;
	filename="0001-cosmetics-typofix-in-comments.patch"

=46rom 39a0fd0267ca5aab3d7c4677586181c355233eef Mon Sep 17 00:00:00 2001
Message-Id: <39a0fd0267ca5aab3d7c4677586181c355233eef.1322133328.git.stefan=
o.lattarini@HIDDEN>
=46rom: Stefano Lattarini <stefano.lattarini@HIDDEN>
Date: Thu, 24 Nov 2011 12:14:49 +0100
Subject: [PATCH] cosmetics: typofix in comments
MIME-Version: 1.0
Content-Type: text/plain; charset=3DUTF-8
Content-Transfer-Encoding: 8bit

* tests/remake-am-pr10111.test (Makefile.am): Fix typo in comments.
* THANKS: Update.

Reported by Krzysztof =C5=BBelechowski.
=2D--
 ChangeLog                    |    7 +++++++
 THANKS                       |    1 +
 tests/remake-am-pr10111.test |    2 +-
 3 files changed, 9 insertions(+), 1 deletions(-)

diff --git a/ChangeLog b/ChangeLog
index 51d2dd8..a8e6587 100644
=2D-- a/ChangeLog
+++ b/ChangeLog
@@ -1,3 +1,10 @@
+2011-11-24  Stefano Lattarini  <stefano.lattarini@HIDDEN>
+
+	cosmetics: typofix in comments
+	* tests/remake-am-pr10111.test (Makefile.am): Fix typo in comments.
+	* THANKS: Update.
+	Reported by Krzysztof =C5=BBelechowski.
+
 2011-11-22  Stefano Lattarini  <stefano.lattarini@HIDDEN>
=20
 	coverage: undistributed '.am' and '.m4' files are diagnosed
diff --git a/THANKS b/THANKS
index 7e6de25..e9da06c 100644
=2D-- a/THANKS
+++ b/THANKS
@@ -189,6 +189,7 @@ Kevin P. Fleming.	kpfleming@HIDDEN
 Kevin Ryde		user42@HIDDEN
 Kevin Street		street@HIDDEN
 Klaus Reichl		Klaus.Reichl@HIDDEN
+Krzysztof =C5=BBelechowski	giecrilj@HIDDEN
 L. Peter Deutsch	ghost@HIDDEN
 Ladislav Strojil	Ladislav.Strojil@HIDDEN
 Larry Jones		larry.jones@HIDDEN
diff --git a/tests/remake-am-pr10111.test b/tests/remake-am-pr10111.test
index a8c2dc6..6f622f8 100644
=2D-- a/tests/remake-am-pr10111.test
+++ b/tests/remake-am-pr10111.test
@@ -35,7 +35,7 @@ END
 cat > Makefile.am <<'END'
 include $(srcdir)/foobar.am
 $(srcdir)/foobar.am:
=2D## Creative quoring to avoid spurious matches in the grepping
+## Creative quoting to avoid spurious matches in the grepping
 ## of Makefile.in, later.
 	echo '#' 'foobar' 'was 'here' '#' > $@
 END
=2D-=20
1.7.2.3


--Boundary-00=_ZolzOc6XtFDZ5/N--

Last modified: Mon, 25 Nov 2019 12:00:02 UTC

GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997 nCipher Corporation Ltd, 1994-97 Ian Jackson.