GNU bug report logs - #10758
thumbs and image-dired to use built-in ImageMagick

Please note: This is a static page, with minimal formatting, updated once a day.
Click here to see this page with the latest information and nicer formatting.

Package: emacs; Severity: wishlist; Reported by: Glenn Morris <rgm@HIDDEN>; dated Wed, 8 Feb 2012 04:54:02 UTC; Maintainer for emacs is bug-gnu-emacs@HIDDEN.
Removed tag(s) moreinfo. Request was from Stefan Kangas <stefan@HIDDEN> to control <at> debbugs.gnu.org. Full text available.

Message received at 10758 <at> debbugs.gnu.org:


Received: (at 10758) by debbugs.gnu.org; 27 Oct 2021 22:14:32 +0000
From debbugs-submit-bounces <at> debbugs.gnu.org Wed Oct 27 18:14:32 2021
Received: from localhost ([127.0.0.1]:50765 helo=debbugs.gnu.org)
	by debbugs.gnu.org with esmtp (Exim 4.84_2)
	(envelope-from <debbugs-submit-bounces <at> debbugs.gnu.org>)
	id 1mfrBn-0002NJ-Iu
	for submit <at> debbugs.gnu.org; Wed, 27 Oct 2021 18:14:32 -0400
Received: from mail-pl1-f171.google.com ([209.85.214.171]:34688)
 by debbugs.gnu.org with esmtp (Exim 4.84_2)
 (envelope-from <stefankangas@HIDDEN>) id 1mfrBX-0002Mi-KL
 for 10758 <at> debbugs.gnu.org; Wed, 27 Oct 2021 18:14:30 -0400
Received: by mail-pl1-f171.google.com with SMTP id r5so3030810pls.1
 for <10758 <at> debbugs.gnu.org>; Wed, 27 Oct 2021 15:14:15 -0700 (PDT)
X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed;
 d=1e100.net; s=20210112;
 h=x-gm-message-state:from:in-reply-to:references:user-agent
 :mime-version:date:message-id:subject:to:cc;
 bh=c1rQiRs9JUjqahD2ozKUMaOC0fF3zm/FkJ8KeJDv+f8=;
 b=G/aSNgbLqiTEXfhNfFpXnewgk3IXDWA4hJ/C9jsusL/LOKeFiA7e495BCR+AemaZpi
 jG5mEJZL7vueXvPuSjB5ybgoiX0Qhgv9Vf0YeBqeI+KeX/19hr5b62hVb8KO1nsimUao
 8yBf7eL1r92mhYE63HpqVG3roIxZS64uHcxzAWaqgpCB7equSNou/X9GEF4PP+rrok2T
 NDD1UjVLqbVwV16NzjFky/FT4SRICDWB43BSMMrkh9mFUl4rxCe/9cwbLEDF+ga/tWC/
 7YnBosWUjjG+PkG6BMyupvnaAi66lD37jCKYgS976wP0XfhzABvj50A+3HnJUlmYvima
 ecPA==
X-Gm-Message-State: AOAM533LK6Lu9BE02uO7Imqd4y0q+lugGa2OJdBDnwGAsaY1mPKjk1r5
 5xaOksKlJfNZlmME6Lef7GHragsEW/RY05ZYmDE=
X-Google-Smtp-Source: ABdhPJypO5/t3TMy3F0YpvagAC12IBFtoWItA858vjofaFzljR4xuN6P4f3l/8daY+Z3NyJkpj0h92q8YcIliyq701E=
X-Received: by 2002:a17:90b:11c2:: with SMTP id
 gv2mr362819pjb.133.1635372849855; 
 Wed, 27 Oct 2021 15:14:09 -0700 (PDT)
Received: from 753933720722 named unknown by gmailapi.google.com with
 HTTPREST; Wed, 27 Oct 2021 15:14:09 -0700
From: Stefan Kangas <stefan@HIDDEN>
In-Reply-To: <CADwFkmm1X1MSHfcMai47OZp7ZH=TEFFarEGOMNZv4dvN0Z9b-w@HIDDEN>
 (Stefan Kangas's message of "Mon, 25 Oct 2021 12:37:51 -0700")
References: <8xfwemx6yr.fsf@HIDDEN> <87k18jw6w0.fsf@HIDDEN>
 <CADwFkmkDn8jKJM2tp36AoVms8MjCX=UEVk=L0NS0mUq=0CXVmw@HIDDEN>
 <CADwFkmm5vJOHs+QNacUuqH7vh4jkykdJ_790obJwikVZ7CPznA@HIDDEN>
 <CADwFkmkcv6PTzAdvL2e8Nyt1sQ0kf-p-S2esDV1L39SrGMbABA@HIDDEN>
 <CABrcCQ5J7QJ=jfGPftv4MwhaNLjFx=9nVJe9HQLyis-VD8NGrw@HIDDEN>
 <CADwFkmm1X1MSHfcMai47OZp7ZH=TEFFarEGOMNZv4dvN0Z9b-w@HIDDEN>
User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/29.0.50 (gnu/linux)
MIME-Version: 1.0
Date: Wed, 27 Oct 2021 15:14:09 -0700
Message-ID: <CADwFkmm95LSf8WSoHVymM3pO5_yTmORpeMDoMwkyRgj=Fd1sLA@HIDDEN>
Subject: Re: bug#10758: thumbs and image-dired to use built-in ImageMagick
To: Mathias Dahl <mathias.dahl@HIDDEN>
Content-Type: multipart/mixed; boundary="000000000000ca9c8705cf5ce9f4"
X-Spam-Score: 0.5 (/)
X-Debbugs-Envelope-To: 10758
Cc: Glenn Morris <rgm@HIDDEN>, 10758 <at> debbugs.gnu.org
X-BeenThere: debbugs-submit <at> debbugs.gnu.org
X-Mailman-Version: 2.1.18
Precedence: list
List-Id: <debbugs-submit.debbugs.gnu.org>
List-Unsubscribe: <https://debbugs.gnu.org/cgi-bin/mailman/options/debbugs-submit>, 
 <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=unsubscribe>
List-Archive: <https://debbugs.gnu.org/cgi-bin/mailman/private/debbugs-submit/>
List-Post: <mailto:debbugs-submit <at> debbugs.gnu.org>
List-Help: <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=help>
List-Subscribe: <https://debbugs.gnu.org/cgi-bin/mailman/listinfo/debbugs-submit>, 
 <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=subscribe>
Errors-To: debbugs-submit-bounces <at> debbugs.gnu.org
Sender: "Debbugs-submit" <debbugs-submit-bounces <at> debbugs.gnu.org>
X-Spam-Score: -0.5 (/)

--000000000000ca9c8705cf5ce9f4
Content-Type: text/plain; charset="UTF-8"

Stefan Kangas <stefan@HIDDEN> writes:

> Mathias Dahl <mathias.dahl@HIDDEN> writes:
>
>> It seems I knew about `image-mode' but perhaps it never crossed my mind
>> to inherit from it. 16 years later, my memory fails me...
>>
>> At any rate I have nothing against it, if someone wants to give it a try.

See the attached patch.  Unsurprisingly, this makes `image-dired' feel
quite a bit snappier, as we avoid a lot of unnecessary work.

--000000000000ca9c8705cf5ce9f4
Content-Type: text/x-diff; charset="US-ASCII"; 
	name="0001-Make-image-dired-display-image-mode-inherit-from-ima.patch"
Content-Disposition: attachment; 
	filename="0001-Make-image-dired-display-image-mode-inherit-from-ima.patch"
Content-Transfer-Encoding: base64
X-Attachment-Id: 76b70ba84bafb99e_0.1

RnJvbSAwZGJjYjg4NjYwYjZjNGMwZDA4NDQ0NmU5ZjM2NzkzODMxOWRhMjU0IE1vbiBTZXAgMTcg
MDA6MDA6MDAgMjAwMQpGcm9tOiBTdGVmYW4gS2FuZ2FzIDxzdGVmYW5AbWFyeGlzdC5zZT4KRGF0
ZTogU2F0LCAyMyBPY3QgMjAyMSAxNjowNjowNSArMDIwMApTdWJqZWN0OiBbUEFUQ0hdIE1ha2Ug
aW1hZ2UtZGlyZWQtZGlzcGxheS1pbWFnZS1tb2RlIGluaGVyaXQgZnJvbSBpbWFnZS1tb2RlCgoq
IGxpc3AvaW1hZ2UtZGlyZWQuZWwgKGltYWdlLWRpcmVkLWRpc3BsYXktaW1hZ2UtbW9kZSk6Cklu
aGVyaXQgZnJvbSAnaW1hZ2UtbW9kZScuICAoQnVnIzEwNzU4KQooaW1hZ2UtZGlyZWQtZGlzcGxh
eS1pbWFnZSk6IFNpbXBsaWZ5OiBubyBsb25nZXIgZ2VuZXJhdGUKdGVtcG9yYXJ5IGltYWdlLCB3
aGljaCBpcyB1bm5lY2Vzc2FyeSB3aXRoIHRoZSBhYm92ZSBjaGFuZ2UuCihpbWFnZS1kaXJlZC1k
aXNwbGF5LXRodW1ibmFpbC1vcmlnaW5hbC1pbWFnZSkKKGltYWdlLWRpcmVkLWRpcmVkLWRpc3Bs
YXktaW1hZ2UpCihpbWFnZS1kaXJlZC1tb3VzZS1kaXNwbGF5LWltYWdlKTogU2ltcGxpZnkuCgoo
aW1hZ2UtZGlyZWQtY21kLWNyZWF0ZS10ZW1wLWltYWdlLXByb2dyYW0pCihpbWFnZS1kaXJlZC1j
bWQtY3JlYXRlLXRlbXAtaW1hZ2Utb3B0aW9ucykKKGltYWdlLWRpcmVkLWRpc3BsYXktd2luZG93
LXdpZHRoLWNvcnJlY3Rpb24pCihpbWFnZS1kaXJlZC1kaXNwbGF5LXdpbmRvdy1oZWlnaHQtY29y
cmVjdGlvbikKKGltYWdlLWRpcmVkLWRpc3BsYXktd2luZG93LXdpZHRoKQooaW1hZ2UtZGlyZWQt
ZGlzcGxheS13aW5kb3ctaGVpZ2h0KQooaW1hZ2UtZGlyZWQtd2luZG93LWhlaWdodC1waXhlbHMp
OiBNYWtlIG9ic29sZXRlLgooaW1hZ2UtZGlyZWQtY3JlYXRlLWRpc3BsYXktaW1hZ2UtYnVmZmVy
KTogTWFrZSBpbnRvIG9ic29sZXRlCmZ1bmN0aW9uIGFsaWFzIGZvciAnaWdub3JlJy4KKGltYWdl
LWRpcmVkLW1pbm9yLW1vZGUpOiBEb2MgZml4LgotLS0KIGxpc3AvaW1hZ2UtZGlyZWQuZWwgfCAx
OTQgKysrKysrKysrKysrKysrKysrKy0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0KIDEgZmlsZSBj
aGFuZ2VkLCA4MiBpbnNlcnRpb25zKCspLCAxMTIgZGVsZXRpb25zKC0pCgpkaWZmIC0tZ2l0IGEv
bGlzcC9pbWFnZS1kaXJlZC5lbCBiL2xpc3AvaW1hZ2UtZGlyZWQuZWwKaW5kZXggMTIyZDhhNWQ5
YS4uZmZiZTg5YTQyOSAxMDA2NDQKLS0tIGEvbGlzcC9pbWFnZS1kaXJlZC5lbAorKysgYi9saXNw
L2ltYWdlLWRpcmVkLmVsCkBAIC0yNzgsMjcgKzI3OCw2IEBAIGltYWdlLWRpcmVkLWNtZC1jcmVh
dGUtdGh1bWJuYWlsLW9wdGlvbnMKICAgOnZlcnNpb24gIjI5LjEiCiAgIDp0eXBlICcocmVwZWF0
IChzdHJpbmcgOnRhZyAiQXJndW1lbnQiKSkpCiAKLShkZWZjdXN0b20gaW1hZ2UtZGlyZWQtY21k
LWNyZWF0ZS10ZW1wLWltYWdlLXByb2dyYW0KLSAgKGlmIChleGVjdXRhYmxlLWZpbmQgImdtIikg
ImdtIiAiY29udmVydCIpCi0gICJFeGVjdXRhYmxlIHVzZWQgdG8gY3JlYXRlIHRlbXBvcmFyeSBp
bWFnZS4KLVVzZWQgdG9nZXRoZXIgd2l0aCBgaW1hZ2UtZGlyZWQtY21kLWNyZWF0ZS10ZW1wLWlt
YWdlLW9wdGlvbnMnLiIKLSAgOnR5cGUgJ2ZpbGUKLSAgOnZlcnNpb24gIjI5LjEiKQotCi0oZGVm
Y3VzdG9tIGltYWdlLWRpcmVkLWNtZC1jcmVhdGUtdGVtcC1pbWFnZS1vcHRpb25zCi0gIChsZXQg
KChvcHRzICcoIi1zaXplIiAiJXd4JWgiICIlZlswXSIKLSAgICAgICAgICAgICAgICAiLXJlc2l6
ZSIgIiV3eCVoPiIKLSAgICAgICAgICAgICAgICAiLXN0cmlwIiAianBlZzoldCIpKSkKLSAgICAo
aWYgKGV4ZWN1dGFibGUtZmluZCAiZ20iKSAoY29ucyAiY29udmVydCIgb3B0cykgb3B0cykpCi0g
ICJPcHRpb25zIG9mIGNvbW1hbmQgdXNlZCB0byBjcmVhdGUgdGVtcG9yYXJ5IGltYWdlIGZvciBk
aXNwbGF5IHdpbmRvdy4KLVVzZWQgdG9nZXRoZXIgd2l0aCBgaW1hZ2UtZGlyZWQtY21kLWNyZWF0
ZS10ZW1wLWltYWdlLXByb2dyYW0nLAotQXZhaWxhYmxlIGZvcm1hdCBzcGVjaWZpZXJzIGFyZTog
JXcgYW5kICVoIHdoaWNoIGFyZSByZXBsYWNlZCBieQotdGhlIGNhbGN1bGF0ZWQgbWF4IHNpemUg
Zm9yIHdpZHRoIGFuZCBoZWlnaHQgaW4gdGhlIGltYWdlIGRpc3BsYXkgd2luZG93LAotJWYgd2hp
Y2ggaXMgcmVwbGFjZWQgYnkgdGhlIGZpbGUgbmFtZSBvZiB0aGUgb3JpZ2luYWwgaW1hZ2UgYW5k
ICV0IHdoaWNoCi1pcyByZXBsYWNlZCBieSB0aGUgZmlsZSBuYW1lIG9mIHRoZSB0ZW1wb3Jhcnkg
ZmlsZS4iCi0gIDp2ZXJzaW9uICIyOS4xIgotICA6dHlwZSAnKHJlcGVhdCAoc3RyaW5nIDp0YWcg
IkFyZ3VtZW50IikpKQotCiAoZGVmY3VzdG9tIGltYWdlLWRpcmVkLWNtZC1wbmducS1wcm9ncmFt
CiAgIDs7IFByZWZlciBwbmdxdWFudCB0byBwbmducS1zOSBhcyBpdCBpcyBmYXN0ZXIgb24gbXkg
bWFjaGluZS4KICAgOzsgICBUaGUgcHJvamVjdCBhbHNvIHNlZW1zIG1vcmUgYWN0aXZlIHRoYW4g
dGhlIGFsdGVybmF0aXZlcy4KQEAgLTUwOSwxOCArNDg4LDYgQEAgaW1hZ2UtZGlyZWQtdGh1bWJz
LXBlci1yb3cKICAgIk51bWJlciBvZiB0aHVtYm5haWxzIHRvIGRpc3BsYXkgcGVyIHJvdyBpbiB0
aHVtYiBidWZmZXIuIgogICA6dHlwZSAnaW50ZWdlcikKIAotKGRlZmN1c3RvbSBpbWFnZS1kaXJl
ZC1kaXNwbGF5LXdpbmRvdy13aWR0aC1jb3JyZWN0aW9uIDEKLSAgIk51bWJlciB0byBiZSB1c2Vk
IHRvIGNvcnJlY3QgaW1hZ2UgZGlzcGxheSB3aW5kb3cgd2lkdGguCi1DaGFuZ2UgaWYgdGhlIGRl
ZmF1bHQgKDEpIGRvZXMgbm90IHdvcmsgKGkuZS4gaWYgdGhlIGltYWdlIGRvZXMgbm90Ci1jb21w
bGV0ZWx5IGZpdCkuIgotICA6dHlwZSAnaW50ZWdlcikKLQotKGRlZmN1c3RvbSBpbWFnZS1kaXJl
ZC1kaXNwbGF5LXdpbmRvdy1oZWlnaHQtY29ycmVjdGlvbiAwCi0gICJOdW1iZXIgdG8gYmUgdXNl
ZCB0byBjb3JyZWN0IGltYWdlIGRpc3BsYXkgd2luZG93IGhlaWdodC4KLUNoYW5nZSBpZiB0aGUg
ZGVmYXVsdCAoMCkgZG9lcyBub3Qgd29yayAoaS5lLiBpZiB0aGUgaW1hZ2UgZG9lcyBub3QKLWNv
bXBsZXRlbHkgZml0KS4iCi0gIDp0eXBlICdpbnRlZ2VyKQotCiAoZGVmY3VzdG9tIGltYWdlLWRp
cmVkLXRyYWNrLW1vdmVtZW50IHQKICAgIlRoZSBjdXJyZW50IHN0YXRlIG9mIHRoZSB0cmFja2lu
ZyBhbmQgbWlycm9yaW5nLgogRm9yIG1vcmUgaW5mb3JtYXRpb24sIHNlZSB0aGUgZG9jdW1lbnRh
dGlvbiBmb3IKQEAgLTEwMTQsMTUgKzk4MSw2IEBAIGltYWdlLWRpcmVkLWNyZWF0ZS10aHVtYm5h
aWwtYnVmZmVyCiAoZGVmdmFyIGltYWdlLWRpcmVkLWRpc3BsYXktaW1hZ2UtYnVmZmVyICIqaW1h
Z2UtZGlyZWQtZGlzcGxheS1pbWFnZSoiCiAgICJXaGVyZSBsYXJnZXIgdmVyc2lvbnMgb2YgdGhl
IGltYWdlcyBhcmUgZGlzcGxheS4iKQogCi0oZGVmdW4gaW1hZ2UtZGlyZWQtY3JlYXRlLWRpc3Bs
YXktaW1hZ2UtYnVmZmVyICgpCi0gICJDcmVhdGUgaW1hZ2UgZGlzcGxheSBidWZmZXIgYW5kIHNl
dCBgaW1hZ2UtZGlyZWQtZGlzcGxheS1pbWFnZS1tb2RlJy4iCi0gIChsZXQgKChidWYgKGdldC1i
dWZmZXItY3JlYXRlIGltYWdlLWRpcmVkLWRpc3BsYXktaW1hZ2UtYnVmZmVyKSkpCi0gICAgKHdp
dGgtY3VycmVudC1idWZmZXIgYnVmCi0gICAgICAoc2V0cSBidWZmZXItcmVhZC1vbmx5IHQpCi0g
ICAgICAoaWYgKG5vdCAoZXEgbWFqb3ItbW9kZSAnaW1hZ2UtZGlyZWQtZGlzcGxheS1pbWFnZS1t
b2RlKSkKLSAgICAgICAgICAoaW1hZ2UtZGlyZWQtZGlzcGxheS1pbWFnZS1tb2RlKSkpCi0gICAg
YnVmKSkKLQogKGRlZnZhciBpbWFnZS1kaXJlZC1zYXZlZC13aW5kb3ctY29uZmlndXJhdGlvbiBu
aWwKICAgIlNhdmVkIHdpbmRvdyBjb25maWd1cmF0aW9uLiIpCiAKQEAgLTEwNDYsNyArMTAwNCw3
IEBAIGltYWdlLWRpcmVkLWRpcmVkLXdpdGgtd2luZG93LWNvbmZpZ3VyYXRpb24KIGNhbGxpbmcg
YGltYWdlLWRpcmVkLXJlc3RvcmUtd2luZG93LWNvbmZpZ3VyYXRpb24nLiIKICAgKGludGVyYWN0
aXZlICJERGlyZWN0b3J5OiBcblAiKQogICAobGV0ICgoYnVmIChpbWFnZS1kaXJlZC1jcmVhdGUt
dGh1bWJuYWlsLWJ1ZmZlcikpCi0gICAgICAgIChidWYyIChpbWFnZS1kaXJlZC1jcmVhdGUtZGlz
cGxheS1pbWFnZS1idWZmZXIpKSkKKyAgICAgICAgKGJ1ZjIgKGdldC1idWZmZXItY3JlYXRlIGlt
YWdlLWRpcmVkLWRpc3BsYXktaW1hZ2UtYnVmZmVyKSkpCiAgICAgKHNldHEgaW1hZ2UtZGlyZWQt
c2F2ZWQtd2luZG93LWNvbmZpZ3VyYXRpb24KICAgICAgICAgICAoY3VycmVudC13aW5kb3ctY29u
ZmlndXJhdGlvbikpCiAgICAgKGRpcmVkIGRpcikKQEAgLTE3ODMsMTMgKzE3NDEsMTEgQEAgaW1h
Z2UtZGlyZWQtdGh1bWJuYWlsLW1vZGUKICAgKHNldHEtbG9jYWwgbGluZS1zcGFjaW5nIChmcmFt
ZS1jaGFyLXdpZHRoKSkpCiAKIChkZWZpbmUtZGVyaXZlZC1tb2RlIGltYWdlLWRpcmVkLWRpc3Bs
YXktaW1hZ2UtbW9kZQotICBzcGVjaWFsLW1vZGUgImltYWdlLWRpcmVkLWltYWdlLWRpc3BsYXki
CisgIGltYWdlLW1vZGUgImltYWdlLWRpcmVkLWltYWdlLWRpc3BsYXkiCiAgICJNb2RlIGZvciBk
aXNwbGF5aW5nIGFuZCBtYW5pcHVsYXRpbmcgb3JpZ2luYWwgaW1hZ2UuCiBSZXNpemVkIG9yIGlu
IGZ1bGwtc2l6ZS4iCi0gIChidWZmZXItZGlzYWJsZS11bmRvKQotICAoaW1hZ2UtbW9kZS1zZXR1
cC13aW5wcm9wcykKLSAgKHNldHEgY3Vyc29yLXR5cGUgbmlsKQotICAoYWRkLWhvb2sgJ2ZpbGUt
bmFtZS1hdC1wb2ludC1mdW5jdGlvbnMgJ2ltYWdlLWRpcmVkLWZpbGUtbmFtZS1hdC1wb2ludCBu
aWwgdCkpCisgIDppbnRlcmFjdGl2ZSBuaWwKKyAgKGFkZC1ob29rICdmaWxlLW5hbWUtYXQtcG9p
bnQtZnVuY3Rpb25zICMnaW1hZ2UtZGlyZWQtZmlsZS1uYW1lLWF0LXBvaW50IG5pbCB0KSkKIAog
KGRlZnZhciBpbWFnZS1kaXJlZC1taW5vci1tb2RlLW1hcAogICAobGV0ICgobWFwIChtYWtlLXNw
YXJzZS1rZXltYXApKSkKQEAgLTE4NDQsNyArMTgwMCw3IEBAIGltYWdlLWRpcmVkLW1pbm9yLW1v
ZGUtbWFwCiAoZGVmaW5lLW1pbm9yLW1vZGUgaW1hZ2UtZGlyZWQtbWlub3ItbW9kZQogICAiU2V0
dXAgZWFzeS10by11c2Uga2V5YmluZGluZ3MgZm9yIHRoZSBjb21tYW5kcyB0byBiZSB1c2VkIGlu
IERpcmVkIG1vZGUuCiBOb3RlIHRoYXQgbiwgcCBhbmQgPGRvd24+IGFuZCA8dXA+IHdpbGwgYmUg
aGlqYWNrZWQgYW5kIGJvdW5kIHRvCi1gaW1hZ2UtZGlyZWQtZGlyZWQteC1saW5lJy4iCitgaW1h
Z2UtZGlyZWQtZGlyZWQtbmV4dC1saW5lJyBhbmQgYGltYWdlLWRpcmVkLWRpcmVkLXByZXZpb3Vz
LWxpbmUnLiIKICAgOmtleW1hcCBpbWFnZS1kaXJlZC1taW5vci1tb2RlLW1hcCkKIAogKGRlY2xh
cmUtZnVuY3Rpb24gY2xlYXItaW1hZ2UtY2FjaGUgImltYWdlLmMiICgmb3B0aW9uYWwgZmlsdGVy
KSkKQEAgLTIwMDcsMTEgKzE5NjMsNiBAQCBpbWFnZS1kaXJlZC13aW5kb3ctd2lkdGgtcGl4ZWxz
CiAgICJDYWxjdWxhdGUgV0lORE9XIHdpZHRoIGluIHBpeGVscy4iCiAgICAgKCogKHdpbmRvdy13
aWR0aCB3aW5kb3cpIChmcmFtZS1jaGFyLXdpZHRoKSkpCiAKLShkZWZ1biBpbWFnZS1kaXJlZC13
aW5kb3ctaGVpZ2h0LXBpeGVscyAod2luZG93KQotICAiQ2FsY3VsYXRlIFdJTkRPVyBoZWlnaHQg
aW4gcGl4ZWxzLiIKLSAgOzsgTm90ZTogVGhlIG1vZGUtbGluZSBjb25zdW1lcyBvbmUgbGluZQot
ICAgICgqICgtICh3aW5kb3ctaGVpZ2h0IHdpbmRvdykgMSkgKGZyYW1lLWNoYXItaGVpZ2h0KSkp
Ci0KIChkZWZ1biBpbWFnZS1kaXJlZC1kaXNwbGF5LXdpbmRvdyAoKQogICAiUmV0dXJuIHdpbmRv
dyB3aGVyZSBgaW1hZ2UtZGlyZWQtZGlzcGxheS1pbWFnZS1idWZmZXInIGlzIHZpc2libGUuIgog
ICAoZ2V0LXdpbmRvdy13aXRoLXByZWRpY2F0ZQpAQCAtMjAzNyw1OSArMTk4OCwyMiBAQCBpbWFn
ZS1kaXJlZC1hc3NvY2lhdGVkLWRpcmVkLWJ1ZmZlci13aW5kb3cKICAgICAgICAgICAgICAoZXF1
YWwgKHdpbmRvdy1idWZmZXIgd2luZG93KSBidWYpKSkpCiAgICAgICAoZXJyb3IgIk5vIHRodW1i
bmFpbCBpbWFnZSBhdCBwb2ludCIpKSkpCiAKLShkZWZ1biBpbWFnZS1kaXJlZC1kaXNwbGF5LXdp
bmRvdy13aWR0aCAod2luZG93KQotICAiUmV0dXJuIHdpZHRoLCBpbiBwaXhlbHMsIG9mIFdJTkRP
Vy4iCi0gICgtIChpbWFnZS1kaXJlZC13aW5kb3ctd2lkdGgtcGl4ZWxzIHdpbmRvdykKLSAgICAg
aW1hZ2UtZGlyZWQtZGlzcGxheS13aW5kb3ctd2lkdGgtY29ycmVjdGlvbikpCi0KLShkZWZ1biBp
bWFnZS1kaXJlZC1kaXNwbGF5LXdpbmRvdy1oZWlnaHQgKHdpbmRvdykKLSAgIlJldHVybiBoZWln
aHQsIGluIHBpeGVscywgb2YgV0lORE9XLiIKLSAgKC0gKGltYWdlLWRpcmVkLXdpbmRvdy1oZWln
aHQtcGl4ZWxzIHdpbmRvdykKLSAgICAgaW1hZ2UtZGlyZWQtZGlzcGxheS13aW5kb3ctaGVpZ2h0
LWNvcnJlY3Rpb24pKQotCi0oZGVmdW4gaW1hZ2UtZGlyZWQtZGlzcGxheS1pbWFnZSAoZmlsZSAm
b3B0aW9uYWwgb3JpZ2luYWwtc2l6ZSkKKyhkZWZ1biBpbWFnZS1kaXJlZC1kaXNwbGF5LWltYWdl
IChmaWxlICZvcHRpb25hbCBfaWdub3JlZCkKICAgIkRpc3BsYXkgaW1hZ2UgRklMRSBpbiBpbWFn
ZSBidWZmZXIuCi1Vc2UgdGhpcyB3aGVuIHlvdSB3YW50IHRvIGRpc3BsYXkgdGhlIGltYWdlLCBz
ZW1pIHNpemVkLCBpbiBhIG5ldwotd2luZG93LiAgVGhlIGltYWdlIGlzIHNpemVkIHRvIGZpdCB0
aGUgZGlzcGxheSB3aW5kb3cgKHVzaW5nIGEKLXRlbXBvcmFyeSBmaWxlLCBkb24ndCB3b3JyeSku
ICBCZWNhdXNlIG9mIHRoaXMsIGl0IHdpbGwgbm90IGJlIGFzCi1xdWljayBhcyBvcGVuaW5nIGl0
IGRpcmVjdGx5LCBidXQgb24gbW9zdCBtb2Rlcm4gc3lzdGVtcyBpdAotc2hvdWxkIGZlZWwgc25h
cHB5IGVub3VnaC4KLQotSWYgb3B0aW9uYWwgYXJndW1lbnQgT1JJR0lOQUwtU0laRSBpcyBub24t
bmlsLCBkaXNwbGF5IGltYWdlIGluIGl0cwotb3JpZ2luYWwgc2l6ZS4iCi0gIChpbWFnZS1kaXJl
ZC0tY2hlY2stZXhlY3V0YWJsZS1leGlzdHMKLSAgICdpbWFnZS1kaXJlZC1jbWQtY3JlYXRlLXRl
bXAtaW1hZ2UtcHJvZ3JhbSkKLSAgKGxldCAoKG5ldy1maWxlIChleHBhbmQtZmlsZS1uYW1lIGlt
YWdlLWRpcmVkLXRlbXAtaW1hZ2UtZmlsZSkpCi0gICAgICAgICh3aW5kb3cgKGltYWdlLWRpcmVk
LWRpc3BsYXktd2luZG93KSkKLSAgICAgICAgKGltYWdlLXR5cGUgJ2pwZWcpKQotICAgIChzZXRx
IGZpbGUgKGV4cGFuZC1maWxlLW5hbWUgZmlsZSkpCi0gICAgKGlmIChub3Qgb3JpZ2luYWwtc2l6
ZSkKLSAgICAgICAgKGxldCogKChzcGVjCi0gICAgICAgICAgICAgICAgKGxpc3QKLSAgICAgICAg
ICAgICAgICAgKGNvbnMgP3AgaW1hZ2UtZGlyZWQtY21kLWNyZWF0ZS10ZW1wLWltYWdlLXByb2dy
YW0pCi0gICAgICAgICAgICAgICAgIChjb25zID93IChpbWFnZS1kaXJlZC1kaXNwbGF5LXdpbmRv
dy13aWR0aCB3aW5kb3cpKQotICAgICAgICAgICAgICAgICAoY29ucyA/aCAoaW1hZ2UtZGlyZWQt
ZGlzcGxheS13aW5kb3ctaGVpZ2h0IHdpbmRvdykpCi0gICAgICAgICAgICAgICAgIChjb25zID9m
IGZpbGUpCi0gICAgICAgICAgICAgICAgIChjb25zID90IG5ldy1maWxlKSkpCi0gICAgICAgICAg
ICAgICAocmV0Ci0gICAgICAgICAgICAgICAgKGFwcGx5ICMnY2FsbC1wcm9jZXNzCi0gICAgICAg
ICAgICAgICAgICAgICAgIGltYWdlLWRpcmVkLWNtZC1jcmVhdGUtdGVtcC1pbWFnZS1wcm9ncmFt
IG5pbCBuaWwgbmlsCi0gICAgICAgICAgICAgICAgICAgICAgIChtYXBjYXIKLSAgICAgICAgICAg
ICAgICAgICAgICAgIChsYW1iZGEgKGFyZykgKGZvcm1hdC1zcGVjIGFyZyBzcGVjKSkKLSAgICAg
ICAgICAgICAgICAgICAgICAgIGltYWdlLWRpcmVkLWNtZC1jcmVhdGUtdGVtcC1pbWFnZS1vcHRp
b25zKSkpKQotICAgICAgICAgICh3aGVuIChub3QgKHplcm9wIHJldCkpCi0gICAgICAgICAgICAo
ZXJyb3IgIkNvdWxkIG5vdCByZXNpemUgaW1hZ2UiKSkpCi0gICAgICAoc2V0cSBpbWFnZS10eXBl
IChpbWFnZS10eXBlLWZyb20tZmlsZS1uYW1lIGZpbGUpKQotICAgICAgKGNvcHktZmlsZSBmaWxl
IG5ldy1maWxlIHQpKQotICAgICh3aXRoLWN1cnJlbnQtYnVmZmVyIChpbWFnZS1kaXJlZC1jcmVh
dGUtZGlzcGxheS1pbWFnZS1idWZmZXIpCi0gICAgICAobGV0ICgoaW5oaWJpdC1yZWFkLW9ubHkg
dCkpCi0gICAgICAgIChlcmFzZS1idWZmZXIpCi0gICAgICAgIChjbGVhci1pbWFnZS1jYWNoZSkK
LSAgICAgICAgKGltYWdlLWRpcmVkLWluc2VydC1pbWFnZSBpbWFnZS1kaXJlZC10ZW1wLWltYWdl
LWZpbGUgaW1hZ2UtdHlwZSAwIDApCi0gICAgICAgIChnb3RvLWNoYXIgKHBvaW50LW1pbikpCi0g
ICAgICAgIChzZXQtd2luZG93LXZzY3JvbGwgd2luZG93IDApCi0gICAgICAgIChzZXQtd2luZG93
LWhzY3JvbGwgd2luZG93IDApCi0gICAgICAgIChpbWFnZS1kaXJlZC11cGRhdGUtcHJvcGVydHkg
J29yaWdpbmFsLWZpbGUtbmFtZSBmaWxlKSkpKSkKK1VzZSB0aGlzIHdoZW4geW91IHdhbnQgdG8g
ZGlzcGxheSB0aGUgaW1hZ2UsIGluIGEgbmV3IHdpbmRvdy4KK1RoZSB3aW5kb3cgd2lsbCB1c2Ug
YGltYWdlLWRpcmVkLWRpc3BsYXktaW1hZ2UtbW9kZScgd2hpY2ggaXMKK2Jhc2VkIG9uIGBpbWFn
ZS1tb2RlJy4iCisgIChkZWNsYXJlIChhZHZlcnRpc2VkLWNhbGxpbmctY29udmVudGlvbiAoZmls
ZSkgIjI5LjEiKSkKKyAgKHNldHEgZmlsZSAoZXhwYW5kLWZpbGUtbmFtZSBmaWxlKSkKKyAgKGxl
dCAoKGJ1ZiAoZ2V0LWJ1ZmZlciBpbWFnZS1kaXJlZC1kaXNwbGF5LWltYWdlLWJ1ZmZlcikpCisg
ICAgICAgIChjdXItd2luIChzZWxlY3RlZC13aW5kb3cpKSkKKyAgICAod2hlbiBidWYKKyAgICAg
IChraWxsLWJ1ZmZlciBidWYpKQorICAgICh3aGVuLWxldCAoKGJ1ZiAoZmluZC1maWxlLW90aGVy
LXdpbmRvdyBmaWxlKSkpCisgICAgICAoZGlzcGxheS1idWZmZXIgYnVmKQorICAgICAgKHJlbmFt
ZS1idWZmZXIgaW1hZ2UtZGlyZWQtZGlzcGxheS1pbWFnZS1idWZmZXIpCisgICAgICAoaW1hZ2Ut
ZGlyZWQtZGlzcGxheS1pbWFnZS1tb2RlKQorICAgICAgKHNlbGVjdC13aW5kb3cgY3VyLXdpbikp
KSkKIAogKGRlZnVuIGltYWdlLWRpcmVkLWRpc3BsYXktdGh1bWJuYWlsLW9yaWdpbmFsLWltYWdl
ICgmb3B0aW9uYWwgYXJnKQogICAiRGlzcGxheSBjdXJyZW50IHRodW1ibmFpbCdzIG9yaWdpbmFs
IGltYWdlIGluIGRpc3BsYXkgYnVmZmVyLgpAQCAtMjEwMyw4ICsyMDE3LDYgQEAgaW1hZ2UtZGly
ZWQtZGlzcGxheS10aHVtYm5haWwtb3JpZ2luYWwtaW1hZ2UKICAgICAgICAgICAobWVzc2FnZSAi
Tm8gdGh1bWJuYWlsIGF0IHBvaW50IikKICAgICAgICAgKGlmIChub3QgZmlsZSkKICAgICAgICAg
ICAgIChtZXNzYWdlICJObyBvcmlnaW5hbCBmaWxlIG5hbWUgZm91bmQiKQotCSAgKGltYWdlLWRp
cmVkLWNyZWF0ZS1kaXNwbGF5LWltYWdlLWJ1ZmZlcikKLSAgICAgICAgICAoZGlzcGxheS1idWZm
ZXIgaW1hZ2UtZGlyZWQtZGlzcGxheS1pbWFnZS1idWZmZXIpCiAgICAgICAgICAgKGltYWdlLWRp
cmVkLWRpc3BsYXktaW1hZ2UgZmlsZSBhcmcpKSkpKSkKIAogCkBAIC0yMTE0LDggKzIwMjYsNiBA
QCBpbWFnZS1kaXJlZC1kaXJlZC1kaXNwbGF5LWltYWdlCiBTZWUgZG9jdW1lbnRhdGlvbiBmb3Ig
YGltYWdlLWRpcmVkLWRpc3BsYXktaW1hZ2UnIGZvciBtb3JlIGluZm9ybWF0aW9uLgogV2l0aCBw
cmVmaXggYXJndW1lbnQgQVJHLCBkaXNwbGF5IGltYWdlIGluIGl0cyBvcmlnaW5hbCBzaXplLiIK
ICAgKGludGVyYWN0aXZlICJQIikKLSAgKGltYWdlLWRpcmVkLWNyZWF0ZS1kaXNwbGF5LWltYWdl
LWJ1ZmZlcikKLSAgKGRpc3BsYXktYnVmZmVyIGltYWdlLWRpcmVkLWRpc3BsYXktaW1hZ2UtYnVm
ZmVyKQogICAoaW1hZ2UtZGlyZWQtZGlzcGxheS1pbWFnZSAoZGlyZWQtZ2V0LWZpbGVuYW1lKSBh
cmcpKQogCiAoZGVmdW4gaW1hZ2UtZGlyZWQtaW1hZ2UtYXQtcG9pbnQtcCAoKQpAQCAtMjQzMiw4
ICsyMzQyLDYgQEAgaW1hZ2UtZGlyZWQtbW91c2UtZGlzcGxheS1pbWFnZQogICAgICh3aGVuIGZp
bGUKICAgICAgIChpZiBpbWFnZS1kaXJlZC10cmFjay1tb3ZlbWVudAogCSAgKGltYWdlLWRpcmVk
LXRyYWNrLW9yaWdpbmFsLWZpbGUpKQotICAgICAgKGltYWdlLWRpcmVkLWNyZWF0ZS1kaXNwbGF5
LWltYWdlLWJ1ZmZlcikKLSAgICAgIChkaXNwbGF5LWJ1ZmZlciBpbWFnZS1kaXJlZC1kaXNwbGF5
LWltYWdlLWJ1ZmZlcikKICAgICAgIChpbWFnZS1kaXJlZC1kaXNwbGF5LWltYWdlIGZpbGUpKSkp
CiAKIChkZWZ1biBpbWFnZS1kaXJlZC1tb3VzZS1zZWxlY3QtdGh1bWJuYWlsIChldmVudCkKQEAg
LTI4NzAsNiArMjc3OCw2NSBAQCAndHVtbWUKIChkZWZpbmUtb2Jzb2xldGUtZnVuY3Rpb24tYWxp
YXMgJ2ltYWdlLWRpcmVkLXNldHVwLWRpcmVkLWtleWJpbmRpbmdzCiAgICMnaW1hZ2UtZGlyZWQt
bWlub3ItbW9kZSAiMjYuMSIpCiAKKyhkZWZjdXN0b20gaW1hZ2UtZGlyZWQtY21kLWNyZWF0ZS10
ZW1wLWltYWdlLXByb2dyYW0KKyAgKGlmIChleGVjdXRhYmxlLWZpbmQgImdtIikgImdtIiAiY29u
dmVydCIpCisgICJFeGVjdXRhYmxlIHVzZWQgdG8gY3JlYXRlIHRlbXBvcmFyeSBpbWFnZS4KK1Vz
ZWQgdG9nZXRoZXIgd2l0aCBgaW1hZ2UtZGlyZWQtY21kLWNyZWF0ZS10ZW1wLWltYWdlLW9wdGlv
bnMnLiIKKyAgOnR5cGUgJ2ZpbGUKKyAgOnZlcnNpb24gIjI5LjEiKQorKG1ha2Utb2Jzb2xldGUt
dmFyaWFibGUgJ2ltYWdlLWRpcmVkLWNtZC1jcmVhdGUtdGVtcC1pbWFnZS1wcm9ncmFtCisgICAg
ICAgICAgICAgICAgICAgICAgICAibm8gbG9uZ2VyIHVzZWQuIiAiMjkuMSIpCisKKyhkZWZjdXN0
b20gaW1hZ2UtZGlyZWQtY21kLWNyZWF0ZS10ZW1wLWltYWdlLW9wdGlvbnMKKyAgKGxldCAoKG9w
dHMgJygiLXNpemUiICIld3glaCIgIiVmWzBdIgorICAgICAgICAgICAgICAgICItcmVzaXplIiAi
JXd4JWg+IgorICAgICAgICAgICAgICAgICItc3RyaXAiICJqcGVnOiV0IikpKQorICAgIChpZiAo
ZXhlY3V0YWJsZS1maW5kICJnbSIpIChjb25zICJjb252ZXJ0IiBvcHRzKSBvcHRzKSkKKyAgIk9w
dGlvbnMgb2YgY29tbWFuZCB1c2VkIHRvIGNyZWF0ZSB0ZW1wb3JhcnkgaW1hZ2UgZm9yIGRpc3Bs
YXkgd2luZG93LgorVXNlZCB0b2dldGhlciB3aXRoIGBpbWFnZS1kaXJlZC1jbWQtY3JlYXRlLXRl
bXAtaW1hZ2UtcHJvZ3JhbScsCitBdmFpbGFibGUgZm9ybWF0IHNwZWNpZmllcnMgYXJlOiAldyBh
bmQgJWggd2hpY2ggYXJlIHJlcGxhY2VkIGJ5Cit0aGUgY2FsY3VsYXRlZCBtYXggc2l6ZSBmb3Ig
d2lkdGggYW5kIGhlaWdodCBpbiB0aGUgaW1hZ2UgZGlzcGxheSB3aW5kb3csCislZiB3aGljaCBp
cyByZXBsYWNlZCBieSB0aGUgZmlsZSBuYW1lIG9mIHRoZSBvcmlnaW5hbCBpbWFnZSBhbmQgJXQg
d2hpY2gKK2lzIHJlcGxhY2VkIGJ5IHRoZSBmaWxlIG5hbWUgb2YgdGhlIHRlbXBvcmFyeSBmaWxl
LiIKKyAgOnZlcnNpb24gIjI5LjEiCisgIDp0eXBlICcocmVwZWF0IChzdHJpbmcgOnRhZyAiQXJn
dW1lbnQiKSkpCisobWFrZS1vYnNvbGV0ZS12YXJpYWJsZSAnaW1hZ2UtZGlyZWQtY21kLWNyZWF0
ZS10ZW1wLWltYWdlLW9wdGlvbnMKKyAgICAgICAgICAgICAgICAgICAgICAgICJubyBsb25nZXIg
dXNlZC4iICIyOS4xIikKKworKGRlZmN1c3RvbSBpbWFnZS1kaXJlZC1kaXNwbGF5LXdpbmRvdy13
aWR0aC1jb3JyZWN0aW9uIDEKKyAgIk51bWJlciB0byBiZSB1c2VkIHRvIGNvcnJlY3QgaW1hZ2Ug
ZGlzcGxheSB3aW5kb3cgd2lkdGguCitDaGFuZ2UgaWYgdGhlIGRlZmF1bHQgKDEpIGRvZXMgbm90
IHdvcmsgKGkuZS4gaWYgdGhlIGltYWdlIGRvZXMgbm90Citjb21wbGV0ZWx5IGZpdCkuIgorICA6
dHlwZSAnaW50ZWdlcikKKyhtYWtlLW9ic29sZXRlLXZhcmlhYmxlICdpbWFnZS1kaXJlZC1kaXNw
bGF5LXdpbmRvdy13aWR0aC1jb3JyZWN0aW9uCisgICAgICAgICAgICAgICAgICAgICAgICAibm8g
bG9uZ2VyIHVzZWQuIiAiMjkuMSIpCisKKyhkZWZjdXN0b20gaW1hZ2UtZGlyZWQtZGlzcGxheS13
aW5kb3ctaGVpZ2h0LWNvcnJlY3Rpb24gMAorICAiTnVtYmVyIHRvIGJlIHVzZWQgdG8gY29ycmVj
dCBpbWFnZSBkaXNwbGF5IHdpbmRvdyBoZWlnaHQuCitDaGFuZ2UgaWYgdGhlIGRlZmF1bHQgKDAp
IGRvZXMgbm90IHdvcmsgKGkuZS4gaWYgdGhlIGltYWdlIGRvZXMgbm90Citjb21wbGV0ZWx5IGZp
dCkuIgorICA6dHlwZSAnaW50ZWdlcikKKyhtYWtlLW9ic29sZXRlLXZhcmlhYmxlICdpbWFnZS1k
aXJlZC1kaXNwbGF5LXdpbmRvdy1oZWlnaHQtY29ycmVjdGlvbgorICAgICAgICAgICAgICAgICAg
ICAgICAgIm5vIGxvbmdlciB1c2VkLiIgIjI5LjEiKQorCisoZGVmdW4gaW1hZ2UtZGlyZWQtZGlz
cGxheS13aW5kb3ctd2lkdGggKHdpbmRvdykKKyAgIlJldHVybiB3aWR0aCwgaW4gcGl4ZWxzLCBv
ZiBXSU5ET1cuIgorICAoZGVjbGFyZSAob2Jzb2xldGUgbmlsICIyOS4xIikpCisgICgtIChpbWFn
ZS1kaXJlZC13aW5kb3ctd2lkdGgtcGl4ZWxzIHdpbmRvdykKKyAgICAgaW1hZ2UtZGlyZWQtZGlz
cGxheS13aW5kb3ctd2lkdGgtY29ycmVjdGlvbikpCisKKyhkZWZ1biBpbWFnZS1kaXJlZC1kaXNw
bGF5LXdpbmRvdy1oZWlnaHQgKHdpbmRvdykKKyAgIlJldHVybiBoZWlnaHQsIGluIHBpeGVscywg
b2YgV0lORE9XLiIKKyAgKGRlY2xhcmUgKG9ic29sZXRlIG5pbCAiMjkuMSIpKQorICAoLSAoaW1h
Z2UtZGlyZWQtd2luZG93LWhlaWdodC1waXhlbHMgd2luZG93KQorICAgICBpbWFnZS1kaXJlZC1k
aXNwbGF5LXdpbmRvdy1oZWlnaHQtY29ycmVjdGlvbikpCisKKyhkZWZ1biBpbWFnZS1kaXJlZC13
aW5kb3ctaGVpZ2h0LXBpeGVscyAod2luZG93KQorICAiQ2FsY3VsYXRlIFdJTkRPVyBoZWlnaHQg
aW4gcGl4ZWxzLiIKKyAgKGRlY2xhcmUgKG9ic29sZXRlIG5pbCAiMjkuMSIpKQorICA7OyBOb3Rl
OiBUaGUgbW9kZS1saW5lIGNvbnN1bWVzIG9uZSBsaW5lCisgICAgKCogKC0gKHdpbmRvdy1oZWln
aHQgd2luZG93KSAxKSAoZnJhbWUtY2hhci1oZWlnaHQpKSkKKwogKGRlZmN1c3RvbSBpbWFnZS1k
aXJlZC1jbWQtcmVhZC1leGlmLWRhdGEtcHJvZ3JhbSAiZXhpZnRvb2wiCiAgICJQcm9ncmFtIHVz
ZWQgdG8gcmVhZCBFWElGIGRhdGEgdG8gaW1hZ2UuCiBVc2VkIHRvZ2V0aGVyIHdpdGggYGltYWdl
LWRpcmVkLWNtZC1yZWFkLWV4aWYtZGF0YS1vcHRpb25zJy4iCkBAIC0yOTEyLDYgKzI4NzksOSBA
QCBpbWFnZS1kaXJlZC1nZXQtZXhpZi1kYXRhCiAgICAgICAgIChzZXRxIHRhZy12YWx1ZSAoYnVm
ZmVyLXN1YnN0cmluZyAocG9pbnQtbWluKSAocG9pbnQtbWF4KSkpKSkKICAgICB0YWctdmFsdWUp
KQogCisoZGVmaW5lLW9ic29sZXRlLWZ1bmN0aW9uLWFsaWFzICdpbWFnZS1kaXJlZC1jcmVhdGUt
ZGlzcGxheS1pbWFnZS1idWZmZXIKKyAgIydpZ25vcmUgIjI5LjEiKQorCiA7Ozs7Ozs7Ozs7Ozs7
Ozs7Ozs7Ozs7Ozs7Ozs7Ozs7Ozs7CiA7Ozs7Ozs7OzsgVEVTVC1TRUNUSU9OIDs7Ozs7Ozs7Ozs7
CiA7Ozs7Ozs7Ozs7Ozs7Ozs7Ozs7Ozs7Ozs7Ozs7Ozs7Ozs7Ci0tIAoyLjMwLjIKCg==
--000000000000ca9c8705cf5ce9f4--




Information forwarded to bug-gnu-emacs@HIDDEN:
bug#10758; Package emacs. Full text available.

Message received at 10758 <at> debbugs.gnu.org:


Received: (at 10758) by debbugs.gnu.org; 27 Oct 2021 22:14:06 +0000
From debbugs-submit-bounces <at> debbugs.gnu.org Wed Oct 27 18:14:06 2021
Received: from localhost ([127.0.0.1]:50762 helo=debbugs.gnu.org)
	by debbugs.gnu.org with esmtp (Exim 4.84_2)
	(envelope-from <debbugs-submit-bounces <at> debbugs.gnu.org>)
	id 1mfrBO-0002MY-8l
	for submit <at> debbugs.gnu.org; Wed, 27 Oct 2021 18:14:06 -0400
Received: from mail-pj1-f45.google.com ([209.85.216.45]:41789)
 by debbugs.gnu.org with esmtp (Exim 4.84_2)
 (envelope-from <stefankangas@HIDDEN>) id 1mfrBM-0002Lu-D7
 for 10758 <at> debbugs.gnu.org; Wed, 27 Oct 2021 18:14:04 -0400
Received: by mail-pj1-f45.google.com with SMTP id
 na16-20020a17090b4c1000b0019f5bb661f9so3184390pjb.0
 for <10758 <at> debbugs.gnu.org>; Wed, 27 Oct 2021 15:14:04 -0700 (PDT)
X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed;
 d=1e100.net; s=20210112;
 h=x-gm-message-state:from:in-reply-to:references:user-agent
 :mime-version:date:message-id:subject:to:cc;
 bh=djKJS3FxuUZs3bGpmi45aj/HmucK07E+g8O74+yiEMw=;
 b=KbDz+iRTALWo73+ImBT3K7TpLmP/1f1MOAXcLfRoBofDmiG/85Sx+TPA1NBRWOvESO
 /4y7C36+VCTk9DewmWo0kCON61R6khQwDp13gWVfrwv3dWkErTteaV6zoxQO1MpnUdZq
 0mPhyvZKSQ93TZ9fLzyy3ttvPG2te0aZRKhIVfDexgC36+2g76ktUqryocn2E3qYWacw
 w59nxdCMnniPI3ps92pyARmwmk2B6I+b/yOykqtYNDMkLJ2Kpss9v/VXtzJmT6oNSFNn
 dqoZ2bbPcCwavaH5CJsp+stPCVbn4OAy4aShp9g8veSFk3R86KMB2kLl0O9gT1qD03j8
 SnQg==
X-Gm-Message-State: AOAM531yi3+1mM9VjVk0mFnO5Sp57SAOvHQoeZM5HV2kEt4Mu0yV8U3K
 dtFYFRIJXHimXymQfSgVnK4AnV3F8x+MwK5GxAM=
X-Google-Smtp-Source: ABdhPJzIe+FjliqaHBcatzHzdvOgNARga4gn+1CwnU32Zu/a7ZU/DvJqaSOTFu2Xly3KAnX3cBWQVHN1J2pULyj2JMo=
X-Received: by 2002:a17:90b:17d2:: with SMTP id
 me18mr8652358pjb.132.1635372838677; 
 Wed, 27 Oct 2021 15:13:58 -0700 (PDT)
Received: from 753933720722 named unknown by gmailapi.google.com with
 HTTPREST; Wed, 27 Oct 2021 15:13:58 -0700
From: Stefan Kangas <stefan@HIDDEN>
In-Reply-To: <CADwFkmkDn8jKJM2tp36AoVms8MjCX=UEVk=L0NS0mUq=0CXVmw@HIDDEN>
 (Stefan Kangas's message of "Fri, 22 Oct 2021 23:57:42 -0700")
References: <8xfwemx6yr.fsf@HIDDEN> <87k18jw6w0.fsf@HIDDEN>
 <CADwFkmkDn8jKJM2tp36AoVms8MjCX=UEVk=L0NS0mUq=0CXVmw@HIDDEN>
User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/29.0.50 (gnu/linux)
MIME-Version: 1.0
Date: Wed, 27 Oct 2021 15:13:58 -0700
Message-ID: <CADwFkmm1TDPdcWHB4DgYpeq5mksWBZBMeJUEUQsOOxt=1LWShQ@HIDDEN>
Subject: Re: bug#10758: thumbs and image-dired to use built-in ImageMagick
To: Glenn Morris <rgm@HIDDEN>
Content-Type: text/plain; charset="UTF-8"
X-Spam-Score: 0.5 (/)
X-Debbugs-Envelope-To: 10758
Cc: 10758 <at> debbugs.gnu.org
X-BeenThere: debbugs-submit <at> debbugs.gnu.org
X-Mailman-Version: 2.1.18
Precedence: list
List-Id: <debbugs-submit.debbugs.gnu.org>
List-Unsubscribe: <https://debbugs.gnu.org/cgi-bin/mailman/options/debbugs-submit>, 
 <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=unsubscribe>
List-Archive: <https://debbugs.gnu.org/cgi-bin/mailman/private/debbugs-submit/>
List-Post: <mailto:debbugs-submit <at> debbugs.gnu.org>
List-Help: <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=help>
List-Subscribe: <https://debbugs.gnu.org/cgi-bin/mailman/listinfo/debbugs-submit>, 
 <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=subscribe>
Errors-To: debbugs-submit-bounces <at> debbugs.gnu.org
Sender: "Debbugs-submit" <debbugs-submit-bounces <at> debbugs.gnu.org>
X-Spam-Score: -0.5 (/)

Stefan Kangas <stefan@HIDDEN> writes:

>> Glenn Morris <rgm@HIDDEN> writes:
>>
>>> thumbs.el and image-dired.el both rely on using external ImageMagick
>>> utilities to resize/rotate images.
>>>
>>> If Emacs was compiled with ImageMagick support, then images of
>>> type imagemagick can be resized and rotated internally (see
>>> image-transform-*). These modes should use the internal support if
>>> it exists.
>>
>> So now that we have native image rotation and ImageMagick is on its
>> way to become deprecated, I assume that this bug should be taken to
>> mean that we want to use the built-in support here instead.

I fixed this in `image-dired' (see separate patch).

I guess we could rebase thumbs.el to also use the built-in image viewing
support, but I took a look and this external conversion seems built into
the foundation of how that library works.  So this looks to me like it
would amount to a rewrite of thumbs.el.  I could be wrong of course, but
that was my conclusion after poking at it for an hour or so.

Furthermore, at this point, image-dired.el is by far the more powerful
package, and it seems better implemented overall.  Although it borrows
heavily from thumbs.el (or at least it used to), thumbs.el seems fully
redundant these days.  However, it has some features that image-dired.el
does not, especially when it comes to modifying images.

So rather than attempting a rewrite of thumbs.el, the better solution
seems to me to add any important missing features from thumbs.el to
image-dired.el, and then obsoleting the former (not necessarily in that
order, but either way is fine to me).




Information forwarded to bug-gnu-emacs@HIDDEN:
bug#10758; Package emacs. Full text available.

Message received at 10758 <at> debbugs.gnu.org:


Received: (at 10758) by debbugs.gnu.org; 25 Oct 2021 19:37:58 +0000
From debbugs-submit-bounces <at> debbugs.gnu.org Mon Oct 25 15:37:58 2021
Received: from localhost ([127.0.0.1]:44341 helo=debbugs.gnu.org)
	by debbugs.gnu.org with esmtp (Exim 4.84_2)
	(envelope-from <debbugs-submit-bounces <at> debbugs.gnu.org>)
	id 1mf5nC-0000J4-Ew
	for submit <at> debbugs.gnu.org; Mon, 25 Oct 2021 15:37:58 -0400
Received: from mail-pj1-f52.google.com ([209.85.216.52]:52895)
 by debbugs.gnu.org with esmtp (Exim 4.84_2)
 (envelope-from <stefankangas@HIDDEN>) id 1mf5nB-0000Ir-53
 for 10758 <at> debbugs.gnu.org; Mon, 25 Oct 2021 15:37:57 -0400
Received: by mail-pj1-f52.google.com with SMTP id oa4so9094789pjb.2
 for <10758 <at> debbugs.gnu.org>; Mon, 25 Oct 2021 12:37:57 -0700 (PDT)
X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed;
 d=1e100.net; s=20210112;
 h=x-gm-message-state:from:in-reply-to:references:mime-version:date
 :message-id:subject:to:cc;
 bh=s52Qt4odh1CNYQx+8GijL0BV+Xtg/vm0mZJYstBC8cg=;
 b=HhNuLxVsM7T+GwjDOOH/6eL3gQNLmx4DEBsOUW21t1ovYkhDj5dLVhNnqWgdHYv+UP
 MocgjiHiAalLz5m3xqwv64Co/bO95QSH3LmeUrAOs5uKWYIhvb3/a0j2w49PpJq2b9Z3
 H9J33l0SuE944F6nq8pojmnVBFg4mhXWBEklZlhAzCX89yx+UZTwYt+3+fi+JRhE0ViH
 llKK2gAYaW1w4/L3e5M3DqU3cOLhnJRf3fd/EaSfyDjHZ2YkCgkNsZUsB5f+4suYtkf6
 YToD/RC20bMgyJobElLOQT3gPdGYYQIYD9YZUlozxL2mc5+lM28XXc/Rncm3wps2VVOQ
 0Msw==
X-Gm-Message-State: AOAM5321pyvQbDcDeEetIQ8ELy1xPAoCwDVw01D9/o4sSrkvttOecIRn
 zNEYJHp042+buXlz9NtZyJDTNIlI0AUxkDtQxaWUy597
X-Google-Smtp-Source: ABdhPJwgzs/UTSybgzCs1YsJhRbKt/6Gv/Tnxv8mQKYbelyl594wxGSrdC2XseYnOrDZ3J+8StAb7OgUnXuGVTLDYt8=
X-Received: by 2002:a17:90b:3b86:: with SMTP id
 pc6mr20531479pjb.143.1635190671525; 
 Mon, 25 Oct 2021 12:37:51 -0700 (PDT)
Received: from 753933720722 named unknown by gmailapi.google.com with
 HTTPREST; Mon, 25 Oct 2021 12:37:51 -0700
From: Stefan Kangas <stefan@HIDDEN>
In-Reply-To: <CABrcCQ5J7QJ=jfGPftv4MwhaNLjFx=9nVJe9HQLyis-VD8NGrw@HIDDEN>
References: <8xfwemx6yr.fsf@HIDDEN> <87k18jw6w0.fsf@HIDDEN>
 <CADwFkmkDn8jKJM2tp36AoVms8MjCX=UEVk=L0NS0mUq=0CXVmw@HIDDEN>
 <CADwFkmm5vJOHs+QNacUuqH7vh4jkykdJ_790obJwikVZ7CPznA@HIDDEN>
 <CADwFkmkcv6PTzAdvL2e8Nyt1sQ0kf-p-S2esDV1L39SrGMbABA@HIDDEN>
 <CABrcCQ5J7QJ=jfGPftv4MwhaNLjFx=9nVJe9HQLyis-VD8NGrw@HIDDEN>
MIME-Version: 1.0
Date: Mon, 25 Oct 2021 12:37:51 -0700
Message-ID: <CADwFkmm1X1MSHfcMai47OZp7ZH=TEFFarEGOMNZv4dvN0Z9b-w@HIDDEN>
Subject: Re: bug#10758: thumbs and image-dired to use built-in ImageMagick
To: Mathias Dahl <mathias.dahl@HIDDEN>
Content-Type: text/plain; charset="UTF-8"
X-Spam-Score: 0.5 (/)
X-Debbugs-Envelope-To: 10758
Cc: Glenn Morris <rgm@HIDDEN>, 10758 <at> debbugs.gnu.org
X-BeenThere: debbugs-submit <at> debbugs.gnu.org
X-Mailman-Version: 2.1.18
Precedence: list
List-Id: <debbugs-submit.debbugs.gnu.org>
List-Unsubscribe: <https://debbugs.gnu.org/cgi-bin/mailman/options/debbugs-submit>, 
 <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=unsubscribe>
List-Archive: <https://debbugs.gnu.org/cgi-bin/mailman/private/debbugs-submit/>
List-Post: <mailto:debbugs-submit <at> debbugs.gnu.org>
List-Help: <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=help>
List-Subscribe: <https://debbugs.gnu.org/cgi-bin/mailman/listinfo/debbugs-submit>, 
 <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=subscribe>
Errors-To: debbugs-submit-bounces <at> debbugs.gnu.org
Sender: "Debbugs-submit" <debbugs-submit-bounces <at> debbugs.gnu.org>
X-Spam-Score: -0.5 (/)

Mathias Dahl <mathias.dahl@HIDDEN> writes:

> It seems I knew about `image-mode' but perhaps it never crossed my mind
> to inherit from it. 16 years later, my memory fails me...
>
> At any rate I have nothing against it, if someone wants to give it a try.

Thank you, that is useful information.  I intend to look into this.




Information forwarded to bug-gnu-emacs@HIDDEN:
bug#10758; Package emacs. Full text available.

Message received at 10758 <at> debbugs.gnu.org:


Received: (at 10758) by debbugs.gnu.org; 25 Oct 2021 19:03:01 +0000
From debbugs-submit-bounces <at> debbugs.gnu.org Mon Oct 25 15:03:01 2021
Received: from localhost ([127.0.0.1]:44299 helo=debbugs.gnu.org)
	by debbugs.gnu.org with esmtp (Exim 4.84_2)
	(envelope-from <debbugs-submit-bounces <at> debbugs.gnu.org>)
	id 1mf5FN-0007rW-Da
	for submit <at> debbugs.gnu.org; Mon, 25 Oct 2021 15:03:01 -0400
Received: from mail-yb1-f171.google.com ([209.85.219.171]:40655)
 by debbugs.gnu.org with esmtp (Exim 4.84_2)
 (envelope-from <mathias.dahl@HIDDEN>) id 1mf5FL-0007rK-Ce
 for 10758 <at> debbugs.gnu.org; Mon, 25 Oct 2021 15:02:59 -0400
Received: by mail-yb1-f171.google.com with SMTP id m63so28494228ybf.7
 for <10758 <at> debbugs.gnu.org>; Mon, 25 Oct 2021 12:02:59 -0700 (PDT)
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112;
 h=mime-version:references:in-reply-to:from:date:message-id:subject:to
 :cc; bh=2tq1RYvhpNnL2I13mM8Tc91NLwIVdMRHhvr4AGbI+xo=;
 b=BxxkT0a871Ng/om1M2QWdrGCgQepfnkIUX6cDSlc1JtWkzUIIlfqsUs4jicT6fxgHC
 TOQWCkacbSDJWtdUFNlJ50iHuRZI0cY50xOZ7Cf9XnK0zZ/pMOtrCBl5a+cZY38RICaq
 6IXJbEmBngmpiVh6SPwW6W+g0yPROzgox6CpU7FFfKnUxakOI1Kf5657nF0dabt9FmdI
 dY0BdqiQU8+Kno4Ft6FovMNMapdcz7ryqip8zstwcscvzmLhHW5AVRF3n+NmaTvLFoTv
 XnKnFIkqtfBIYJSMPi1/GdG8CJgM+wXWsyIW5Rpy6WVdFd6ZZTYhv1HRnuwbMvFJNkD9
 sp6g==
X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed;
 d=1e100.net; s=20210112;
 h=x-gm-message-state:mime-version:references:in-reply-to:from:date
 :message-id:subject:to:cc;
 bh=2tq1RYvhpNnL2I13mM8Tc91NLwIVdMRHhvr4AGbI+xo=;
 b=y9A9GLgZU3hCL3jhHMSIyJghd5IdmH5x2xIAnmUwcV0gE8KUgTxjOMNWhnZBuK760N
 MN+dxXSfkEFK5odq3eKNuzh+tQuG5acChFU+PtKdJZQlAPU4wAi4S0kAu7NHb77aIyiv
 B93nUb02MWFNB7xgUZ8pFyRb7bNxjHm+TLdVR+uODLJnnT6mlm0q6y6HjrFUQg8OIieA
 E0hPKUmc+N3bcvTtLQzI54ik7zAMHR9G0dZmAElu0ocBnhrU1M9fdUQxdIYw9grAERtL
 nxfEVGVmsScZCA5ePqFjtxcoHA2L5B5Mqb4V+mOTQwVjti83Bey+QZnnpktAZfLrXqJQ
 /BjA==
X-Gm-Message-State: AOAM533LsP7q8BGlwTQ0dpXARxhJ9ipgFkdDh/fjv5hZg1kWLOmf4YyJ
 3PBA9Naq3V/Sw8Mu8TA475G5T/E1UbwZTZ8TjuU=
X-Google-Smtp-Source: ABdhPJwact+DYgS9RzlN6wK+OZmQY/Bs9MLmhUrkDptD//H9Cmz7JHJziUYhraOTYEoACjFzGHoFoGdbq60IAqDr/A4=
X-Received: by 2002:a25:9d01:: with SMTP id i1mr19534538ybp.88.1635188573721; 
 Mon, 25 Oct 2021 12:02:53 -0700 (PDT)
MIME-Version: 1.0
References: <8xfwemx6yr.fsf@HIDDEN> <87k18jw6w0.fsf@HIDDEN>
 <CADwFkmkDn8jKJM2tp36AoVms8MjCX=UEVk=L0NS0mUq=0CXVmw@HIDDEN>
 <CADwFkmm5vJOHs+QNacUuqH7vh4jkykdJ_790obJwikVZ7CPznA@HIDDEN>
 <CADwFkmkcv6PTzAdvL2e8Nyt1sQ0kf-p-S2esDV1L39SrGMbABA@HIDDEN>
In-Reply-To: <CADwFkmkcv6PTzAdvL2e8Nyt1sQ0kf-p-S2esDV1L39SrGMbABA@HIDDEN>
From: Mathias Dahl <mathias.dahl@HIDDEN>
Date: Mon, 25 Oct 2021 21:02:42 +0200
Message-ID: <CABrcCQ5J7QJ=jfGPftv4MwhaNLjFx=9nVJe9HQLyis-VD8NGrw@HIDDEN>
Subject: Re: bug#10758: thumbs and image-dired to use built-in ImageMagick
To: Stefan Kangas <stefan@HIDDEN>
Content-Type: multipart/alternative; boundary="00000000000013d84905cf3202a4"
X-Spam-Score: 0.0 (/)
X-Debbugs-Envelope-To: 10758
Cc: Glenn Morris <rgm@HIDDEN>, 10758 <at> debbugs.gnu.org
X-BeenThere: debbugs-submit <at> debbugs.gnu.org
X-Mailman-Version: 2.1.18
Precedence: list
List-Id: <debbugs-submit.debbugs.gnu.org>
List-Unsubscribe: <https://debbugs.gnu.org/cgi-bin/mailman/options/debbugs-submit>, 
 <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=unsubscribe>
List-Archive: <https://debbugs.gnu.org/cgi-bin/mailman/private/debbugs-submit/>
List-Post: <mailto:debbugs-submit <at> debbugs.gnu.org>
List-Help: <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=help>
List-Subscribe: <https://debbugs.gnu.org/cgi-bin/mailman/listinfo/debbugs-submit>, 
 <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=subscribe>
Errors-To: debbugs-submit-bounces <at> debbugs.gnu.org
Sender: "Debbugs-submit" <debbugs-submit-bounces <at> debbugs.gnu.org>
X-Spam-Score: -1.0 (-)

--00000000000013d84905cf3202a4
Content-Type: text/plain; charset="UTF-8"

On Sun, Oct 24, 2021 at 11:45 AM Stefan Kangas <stefan@HIDDEN> wrote:

> Stefan Kangas <stefan@HIDDEN> writes:
>
> > Stefan Kangas <stefan@HIDDEN> writes:
> >
> >> So perhaps this feature request is relevant anymore.  WDYT?
> >
> > I now see that Glenn mentioned resizing as well, where using the
> > built-in image scaling seems very relevant.  We currently jump through
> > some unnecessary hoops in `image-dired-display-image' when we could just
> > resize the image in memory.
> >
> > Is there any reason why `image-dired-display-image-mode' doesn't just
> > inherit `image-mode'?  That would avoid code duplication and also allow
> > us to immediately benefit from any improvements to `image-mode'.


Hi, sorry for coming late to the party.

I cannot remember any good reason for not inheriting from `image-mode', but
I opened image-dired.el now and found this:

(defvar image-dired-display-image-mode-map
  (let ((map (make-sparse-keymap)))
    ;; `image-mode-map' has bindings that do not make sense in image-dired
    ;; (set-keymap-parent map image-mode-map)
    (define-key map "f" 'image-dired-display-current-image-full)
    (define-key map "s" 'image-dired-display-current-image-sized)
    (define-key map "g" nil)

    ;; Useful bindings from `image-mode-map'
    (define-key map [remap forward-char] 'image-forward-hscroll)
    (define-key map [remap backward-char] 'image-backward-hscroll)
...

It seems I knew about `image-mode' but perhaps it never crossed my mind
to inherit from it. 16 years later, my memory fails me...

At any rate I have nothing against it, if someone wants to give it a try.

/Mathias

--00000000000013d84905cf3202a4
Content-Type: text/html; charset="UTF-8"
Content-Transfer-Encoding: quoted-printable

<div dir=3D"ltr"><div dir=3D"ltr"><br></div><div class=3D"gmail_quote"><div=
 dir=3D"ltr" class=3D"gmail_attr">On Sun, Oct 24, 2021 at 11:45 AM Stefan K=
angas &lt;<a href=3D"mailto:stefan@HIDDEN">stefan@HIDDEN</a>&gt; wr=
ote:<br></div><blockquote class=3D"gmail_quote" style=3D"margin:0px 0px 0px=
 0.8ex;border-left:1px solid rgb(204,204,204);padding-left:1ex">Stefan Kang=
as &lt;<a href=3D"mailto:stefan@HIDDEN" target=3D"_blank">stefan@marxis=
t.se</a>&gt; writes:<br>
<br>
&gt; Stefan Kangas &lt;<a href=3D"mailto:stefan@HIDDEN" target=3D"_blan=
k">stefan@HIDDEN</a>&gt; writes:<br>
&gt;<br>
&gt;&gt; So perhaps this feature request is relevant anymore.=C2=A0 WDYT?<b=
r>
&gt;<br>
&gt; I now see that Glenn mentioned resizing as well, where using the<br>
&gt; built-in image scaling seems very relevant.=C2=A0 We currently jump th=
rough<br>
&gt; some unnecessary hoops in `image-dired-display-image&#39; when we coul=
d just<br>
&gt; resize the image in memory.<br>
&gt;<br>
&gt; Is there any reason why `image-dired-display-image-mode&#39; doesn&#39=
;t just<br>
&gt; inherit `image-mode&#39;?=C2=A0 That would avoid code duplication and =
also allow<br>
&gt; us to immediately benefit from any improvements to `image-mode&#39;.</=
blockquote><div><br></div><div>Hi, sorry for coming late to the party.</div=
><div><br></div><div>I cannot remember any good reason for not inheriting f=
rom `image-mode&#39;, but</div><div>I opened image-dired.el now and found t=
his:</div><div><br></div>(defvar image-dired-display-image-mode-map<br>=C2=
=A0 (let ((map (make-sparse-keymap)))<br>=C2=A0 =C2=A0 ;; `image-mode-map&#=
39; has bindings that do not make sense in image-dired<br>=C2=A0 =C2=A0 ;; =
(set-keymap-parent map image-mode-map)<br>=C2=A0 =C2=A0 (define-key map &qu=
ot;f&quot; &#39;image-dired-display-current-image-full)<br>=C2=A0 =C2=A0 (d=
efine-key map &quot;s&quot; &#39;image-dired-display-current-image-sized)<b=
r>=C2=A0 =C2=A0 (define-key map &quot;g&quot; nil)<br><br>=C2=A0 =C2=A0 ;; =
Useful bindings from `image-mode-map&#39;<br>=C2=A0 =C2=A0 (define-key map =
[remap forward-char] &#39;image-forward-hscroll)<br>=C2=A0 =C2=A0 (define-k=
ey map [remap backward-char] &#39;image-backward-hscroll)<br><div>...</div>=
<div><br></div><div>It seems I knew about `image-mode&#39; but perhaps it n=
ever crossed my mind</div><div>to inherit from it. 16 years later, my memor=
y fails me...=C2=A0</div><div><br></div><div>At any rate I have nothing aga=
inst it, if someone wants to give it a try.</div><div><br></div><div>/Mathi=
as</div><div><br></div></div></div>

--00000000000013d84905cf3202a4--




Information forwarded to bug-gnu-emacs@HIDDEN:
bug#10758; Package emacs. Full text available.

Message received at 10758 <at> debbugs.gnu.org:


Received: (at 10758) by debbugs.gnu.org; 24 Oct 2021 09:45:37 +0000
From debbugs-submit-bounces <at> debbugs.gnu.org Sun Oct 24 05:45:37 2021
Received: from localhost ([127.0.0.1]:37951 helo=debbugs.gnu.org)
	by debbugs.gnu.org with esmtp (Exim 4.84_2)
	(envelope-from <debbugs-submit-bounces <at> debbugs.gnu.org>)
	id 1mea4P-0006po-7H
	for submit <at> debbugs.gnu.org; Sun, 24 Oct 2021 05:45:37 -0400
Received: from mail-pg1-f180.google.com ([209.85.215.180]:46059)
 by debbugs.gnu.org with esmtp (Exim 4.84_2)
 (envelope-from <stefankangas@HIDDEN>) id 1mea4K-0006pY-Tb
 for 10758 <at> debbugs.gnu.org; Sun, 24 Oct 2021 05:45:36 -0400
Received: by mail-pg1-f180.google.com with SMTP id f5so7845749pgc.12
 for <10758 <at> debbugs.gnu.org>; Sun, 24 Oct 2021 02:45:32 -0700 (PDT)
X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed;
 d=1e100.net; s=20210112;
 h=x-gm-message-state:from:in-reply-to:references:mime-version:date
 :message-id:subject:to:cc;
 bh=+75Mz3zlx2Z9PVfSrM0p4sEDnHZrz4r8jW4GeOvVZ5g=;
 b=DcXadbwyfjbE1TV6F9eKfpBU3XTvDZ2sKSaX2uG0/U8TEZUeUlPxo3Up/8a82CVDf0
 f2DPyisNUwfT0+TERwqbH/lNjCvhofxA1sopMBrgtJXsuOzeFIR3IEXwfZB0stiGK5rI
 EYtLVNycs97RJnH4mdE8sndiOXgcQcIZJ3C/vUORL9mmoae8K3J5myQHaM68fKLLgWul
 OQx2YtXpjmEFNUekzno2iNx/1bOJwJ7WzSM0ViCvGzHr0/8z3u3cVwDwVj2+7LMMKrIV
 FUeQIwqPlK5podkLETfpBkpRkyhb9wKJuR3ax1yh7c1jRHn4F6yf38FLF/ITtijaskBc
 Q2hQ==
X-Gm-Message-State: AOAM533efRdH9coQYQkZ0iGo2YKCutRzRmNCrWIvZCj/dWwcfetWEH9C
 X4iRq0qp7/n6qD/atNZuqOxxSEKBj5sSMT+xV30=
X-Google-Smtp-Source: ABdhPJzk0kNG0ZENrzVNMuARqPE8a+nwnvbYYBFjW11wfOH4G3EI5hsB6P3htg2FdzDcZ1CWBugfz7i6FV/0rV1Thak=
X-Received: by 2002:a63:370c:: with SMTP id e12mr8321608pga.359.1635068727079; 
 Sun, 24 Oct 2021 02:45:27 -0700 (PDT)
Received: from 753933720722 named unknown by gmailapi.google.com with
 HTTPREST; Sun, 24 Oct 2021 02:45:26 -0700
From: Stefan Kangas <stefan@HIDDEN>
In-Reply-To: <CADwFkmm5vJOHs+QNacUuqH7vh4jkykdJ_790obJwikVZ7CPznA@HIDDEN>
References: <8xfwemx6yr.fsf@HIDDEN> <87k18jw6w0.fsf@HIDDEN>
 <CADwFkmkDn8jKJM2tp36AoVms8MjCX=UEVk=L0NS0mUq=0CXVmw@HIDDEN>
 <CADwFkmm5vJOHs+QNacUuqH7vh4jkykdJ_790obJwikVZ7CPznA@HIDDEN>
MIME-Version: 1.0
Date: Sun, 24 Oct 2021 02:45:26 -0700
Message-ID: <CADwFkmkcv6PTzAdvL2e8Nyt1sQ0kf-p-S2esDV1L39SrGMbABA@HIDDEN>
Subject: Re: bug#10758: thumbs and image-dired to use built-in ImageMagick
To: Glenn Morris <rgm@HIDDEN>
Content-Type: text/plain; charset="UTF-8"
X-Spam-Score: 0.5 (/)
X-Debbugs-Envelope-To: 10758
Cc: 10758 <at> debbugs.gnu.org, Mathias Dahl <mathias.dahl@HIDDEN>
X-BeenThere: debbugs-submit <at> debbugs.gnu.org
X-Mailman-Version: 2.1.18
Precedence: list
List-Id: <debbugs-submit.debbugs.gnu.org>
List-Unsubscribe: <https://debbugs.gnu.org/cgi-bin/mailman/options/debbugs-submit>, 
 <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=unsubscribe>
List-Archive: <https://debbugs.gnu.org/cgi-bin/mailman/private/debbugs-submit/>
List-Post: <mailto:debbugs-submit <at> debbugs.gnu.org>
List-Help: <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=help>
List-Subscribe: <https://debbugs.gnu.org/cgi-bin/mailman/listinfo/debbugs-submit>, 
 <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=subscribe>
Errors-To: debbugs-submit-bounces <at> debbugs.gnu.org
Sender: "Debbugs-submit" <debbugs-submit-bounces <at> debbugs.gnu.org>
X-Spam-Score: -0.5 (/)

Stefan Kangas <stefan@HIDDEN> writes:

> Stefan Kangas <stefan@HIDDEN> writes:
>
>> So perhaps this feature request is relevant anymore.  WDYT?
>
> I now see that Glenn mentioned resizing as well, where using the
> built-in image scaling seems very relevant.  We currently jump through
> some unnecessary hoops in `image-dired-display-image' when we could just
> resize the image in memory.
>
> Is there any reason why `image-dired-display-image-mode' doesn't just
> inherit `image-mode'?  That would avoid code duplication and also allow
> us to immediately benefit from any improvements to `image-mode'.

Resending to include Mathias Dahl in the conversation.

(I missed removing ".rem0veth1s" from his listed email address.)




Information forwarded to bug-gnu-emacs@HIDDEN:
bug#10758; Package emacs. Full text available.

Message received at 10758 <at> debbugs.gnu.org:


Received: (at 10758) by debbugs.gnu.org; 24 Oct 2021 09:14:42 +0000
From debbugs-submit-bounces <at> debbugs.gnu.org Sun Oct 24 05:14:41 2021
Received: from localhost ([127.0.0.1]:37933 helo=debbugs.gnu.org)
	by debbugs.gnu.org with esmtp (Exim 4.84_2)
	(envelope-from <debbugs-submit-bounces <at> debbugs.gnu.org>)
	id 1meZaT-00064F-OQ
	for submit <at> debbugs.gnu.org; Sun, 24 Oct 2021 05:14:41 -0400
Received: from mail-pj1-f50.google.com ([209.85.216.50]:41640)
 by debbugs.gnu.org with esmtp (Exim 4.84_2)
 (envelope-from <stefankangas@HIDDEN>) id 1meZaQ-00063z-8S
 for 10758 <at> debbugs.gnu.org; Sun, 24 Oct 2021 05:14:40 -0400
Received: by mail-pj1-f50.google.com with SMTP id
 na16-20020a17090b4c1000b0019f5bb661f9so6165889pjb.0
 for <10758 <at> debbugs.gnu.org>; Sun, 24 Oct 2021 02:14:38 -0700 (PDT)
X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed;
 d=1e100.net; s=20210112;
 h=x-gm-message-state:from:in-reply-to:references:user-agent
 :mime-version:date:message-id:subject:to:cc;
 bh=4Jxb9OWgA2bBKV30KYXZe44OOXOQ1Ub7vIgBVPEx6iU=;
 b=VafJ1VG5KPimopYYc5E1z+k/Z5kwBhF7BSiY0pXORo7/ZY5y2Tk0g4TeSPWNCP4+8A
 bVaSjcfDt06fRnF4MhDAo54f88MvEljE+jfD8g6XB6HVXRW/7b1zMC5nns5Wu2ANXefk
 80T2Tuy1xIxYKdCJdm/XUQTyMBg92mfXUjsCFvvXBvS008KBMbbqZbmUoDwBi2PCEt89
 1JYOm54/MzGWAhfJTsknkGM9Ud9nE++gkAIAvxp7p/ZVidvCKpTVRLhZlt78oLXAGg8Z
 CKBkwkyfV0vhzOoOXBJiq23LTI1RcXviJR8DBJGeSYFHNQ90L63KSDcprXxmOKKpoPPp
 yhdg==
X-Gm-Message-State: AOAM531qu71yMn8YFGuXWb111NPOHSZmA5N171uMY5ICz7Y0dTQBRC8p
 iN3yJOxquyUbouopCAVhzQI1tymOxPWnaZodQ5k=
X-Google-Smtp-Source: ABdhPJw8qE1I1FKs5cx265TQM854X2jmBJJX9F/EtzgIVEo2QXZ+3A5Dvhl5s1DtkOPswZojUu3gMgk2H12gNOlR6+0=
X-Received: by 2002:a17:90a:d917:: with SMTP id
 c23mr5349179pjv.133.1635066872611; 
 Sun, 24 Oct 2021 02:14:32 -0700 (PDT)
Received: from 753933720722 named unknown by gmailapi.google.com with
 HTTPREST; Sun, 24 Oct 2021 02:14:32 -0700
From: Stefan Kangas <stefan@HIDDEN>
In-Reply-To: <CADwFkmkDn8jKJM2tp36AoVms8MjCX=UEVk=L0NS0mUq=0CXVmw@HIDDEN>
 (Stefan Kangas's message of "Fri, 22 Oct 2021 23:57:42 -0700")
References: <8xfwemx6yr.fsf@HIDDEN> <87k18jw6w0.fsf@HIDDEN>
 <CADwFkmkDn8jKJM2tp36AoVms8MjCX=UEVk=L0NS0mUq=0CXVmw@HIDDEN>
User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/29.0.50 (gnu/linux)
MIME-Version: 1.0
Date: Sun, 24 Oct 2021 02:14:32 -0700
Message-ID: <CADwFkmm5vJOHs+QNacUuqH7vh4jkykdJ_790obJwikVZ7CPznA@HIDDEN>
Subject: Re: bug#10758: thumbs and image-dired to use built-in ImageMagick
To: Glenn Morris <rgm@HIDDEN>
Content-Type: text/plain; charset="UTF-8"
X-Spam-Score: 0.5 (/)
X-Debbugs-Envelope-To: 10758
Cc: 10758 <at> debbugs.gnu.org, Mathias Dahl <mathias.rem0veth1s.dahl@HIDDEN>
X-BeenThere: debbugs-submit <at> debbugs.gnu.org
X-Mailman-Version: 2.1.18
Precedence: list
List-Id: <debbugs-submit.debbugs.gnu.org>
List-Unsubscribe: <https://debbugs.gnu.org/cgi-bin/mailman/options/debbugs-submit>, 
 <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=unsubscribe>
List-Archive: <https://debbugs.gnu.org/cgi-bin/mailman/private/debbugs-submit/>
List-Post: <mailto:debbugs-submit <at> debbugs.gnu.org>
List-Help: <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=help>
List-Subscribe: <https://debbugs.gnu.org/cgi-bin/mailman/listinfo/debbugs-submit>, 
 <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=subscribe>
Errors-To: debbugs-submit-bounces <at> debbugs.gnu.org
Sender: "Debbugs-submit" <debbugs-submit-bounces <at> debbugs.gnu.org>
X-Spam-Score: -0.5 (/)

Stefan Kangas <stefan@HIDDEN> writes:

> So perhaps this feature request is relevant anymore.  WDYT?

I now see that Glenn mentioned resizing as well, where using the
built-in image scaling seems very relevant.  We currently jump through
some unnecessary hoops in `image-dired-display-image' when we could just
resize the image in memory.

Is there any reason why `image-dired-display-image-mode' doesn't just
inherit `image-mode'?  That would avoid code duplication and also allow
us to immediately benefit from any improvements to `image-mode'.




Information forwarded to bug-gnu-emacs@HIDDEN:
bug#10758; Package emacs. Full text available.
Added tag(s) moreinfo. Request was from Stefan Kangas <stefan@HIDDEN> to control <at> debbugs.gnu.org. Full text available.

Message received at 10758 <at> debbugs.gnu.org:


Received: (at 10758) by debbugs.gnu.org; 23 Oct 2021 06:57:52 +0000
From debbugs-submit-bounces <at> debbugs.gnu.org Sat Oct 23 02:57:52 2021
Received: from localhost ([127.0.0.1]:34227 helo=debbugs.gnu.org)
	by debbugs.gnu.org with esmtp (Exim 4.84_2)
	(envelope-from <debbugs-submit-bounces <at> debbugs.gnu.org>)
	id 1meAyW-0001ca-69
	for submit <at> debbugs.gnu.org; Sat, 23 Oct 2021 02:57:52 -0400
Received: from mail-pf1-f176.google.com ([209.85.210.176]:33785)
 by debbugs.gnu.org with esmtp (Exim 4.84_2)
 (envelope-from <stefankangas@HIDDEN>) id 1meAyT-0001cL-HW
 for 10758 <at> debbugs.gnu.org; Sat, 23 Oct 2021 02:57:50 -0400
Received: by mail-pf1-f176.google.com with SMTP id t184so5669205pfd.0
 for <10758 <at> debbugs.gnu.org>; Fri, 22 Oct 2021 23:57:49 -0700 (PDT)
X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed;
 d=1e100.net; s=20210112;
 h=x-gm-message-state:from:in-reply-to:references:user-agent
 :mime-version:date:message-id:subject:to:cc;
 bh=GdhXJo5Np3SvB2iD6QeaYrOo1P1ALNSN/IbVgRsDXZI=;
 b=r3lNPDj08c7z7LXbsQfgkvQZDJvbuQhk3E3zB9K108RXlecLf5aTZps1SnDLvqy7bk
 0/wzr7e4C69/3DTBPamhajhuKAaQIAQOJlYjkGEbIfbl8CCVdWAWpcp7XUCUuOFedLGc
 JLFVGKqc6B9FyUrdOiBRG5PuNqNT6unZqzd/Jm18/ejD2YTRW7oIWT0H5hLSFlcC9D7g
 qn3GQ3WDNyghyuYMBQJM0AlSvrqyT036A55/vVSH6j0egjzk/UJYKljpJvIH6HgtVOGf
 XW46P72+6zKv3UfCntagCvz+YImrA2LVa58KvdvqPOXs20gmRkxelxnCsj0UmsYdmT5A
 AZnA==
X-Gm-Message-State: AOAM531yYbJ2QHUvTs9d3f/bVgxPgn5HfL4q6OAXdxEXwBEXuSicl1yL
 x1tV01z4xkFvHSoUN67PeRWnwlrjmk6v2oBMKyo=
X-Google-Smtp-Source: ABdhPJxMV51ssF4WNJaurFneyxeUIa/1bJ9I6iUVO4gkID7bChWjG9oAEmekBFvNlQoOdXLsrGK9fMd5AW2CuqZkMnI=
X-Received: by 2002:a05:6a00:244d:b0:44d:c279:5155 with SMTP id
 d13-20020a056a00244d00b0044dc2795155mr4784287pfj.0.1634972263676; Fri, 22 Oct
 2021 23:57:43 -0700 (PDT)
Received: from 753933720722 named unknown by gmailapi.google.com with
 HTTPREST; Fri, 22 Oct 2021 23:57:42 -0700
From: Stefan Kangas <stefan@HIDDEN>
In-Reply-To: <87k18jw6w0.fsf@HIDDEN> (Stefan Kangas's message of "Fri, 01
 Nov 2019 23:47:59 +0100")
References: <8xfwemx6yr.fsf@HIDDEN> <87k18jw6w0.fsf@HIDDEN>
User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/29.0.50 (gnu/linux)
MIME-Version: 1.0
Date: Fri, 22 Oct 2021 23:57:42 -0700
Message-ID: <CADwFkmkDn8jKJM2tp36AoVms8MjCX=UEVk=L0NS0mUq=0CXVmw@HIDDEN>
Subject: Re: bug#10758: thumbs and image-dired to use built-in ImageMagick
To: Glenn Morris <rgm@HIDDEN>
Content-Type: text/plain; charset="UTF-8"
X-Spam-Score: 0.5 (/)
X-Debbugs-Envelope-To: 10758
Cc: 10758 <at> debbugs.gnu.org
X-BeenThere: debbugs-submit <at> debbugs.gnu.org
X-Mailman-Version: 2.1.18
Precedence: list
List-Id: <debbugs-submit.debbugs.gnu.org>
List-Unsubscribe: <https://debbugs.gnu.org/cgi-bin/mailman/options/debbugs-submit>, 
 <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=unsubscribe>
List-Archive: <https://debbugs.gnu.org/cgi-bin/mailman/private/debbugs-submit/>
List-Post: <mailto:debbugs-submit <at> debbugs.gnu.org>
List-Help: <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=help>
List-Subscribe: <https://debbugs.gnu.org/cgi-bin/mailman/listinfo/debbugs-submit>, 
 <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=subscribe>
Errors-To: debbugs-submit-bounces <at> debbugs.gnu.org
Sender: "Debbugs-submit" <debbugs-submit-bounces <at> debbugs.gnu.org>
X-Spam-Score: -0.5 (/)

Stefan Kangas <stefan@HIDDEN> writes:

> Glenn Morris <rgm@HIDDEN> writes:
>
>> Package: emacs
>> Version: 24.0.93
>> Severity: wishlist
>>
>> thumbs.el and image-dired.el both rely on using external ImageMagick
>> utilities to resize/rotate images.
>>
>> If Emacs was compiled with ImageMagick support, then images of
>> type imagemagick can be resized and rotated internally (see
>> image-transform-*). These modes should use the internal support if
>> it exists.
>
> So now that we have native image rotation and ImageMagick is on its
> way to become deprecated, I assume that this bug should be taken to
> mean that we want to use the built-in support here instead.

Hmm, looking closer at this, both thumbs.el and image-dired.el modifies
the actual image file.  This is something that our built-in support
can't do, as we only have support for reading images.

However, the ImageMagick library has these capabilities.  Given that we
no longer compile with ImageMagick by default, I don't think this
request makes any sense as it stands.  Perhaps we could implement the
in-memory rotation in addition to the modifying one that we have now,
but this is unlikely to be very useful.  If I rotate an image in an
image viewer, it is almost certainly because I want to update the file;
at least this is always the case in my use.

Jpeg images can of course be losslessly rotated by just modifying the
exif data, so implementing built-in support for rotating jpeg images
seems quite doable.  However, we would still not be able to drop the
external imagemagick dependency, because we would then also lose the
capability to rotate other image formats.

So perhaps this feature request is relevant anymore.  WDYT?




Information forwarded to bug-gnu-emacs@HIDDEN:
bug#10758; Package emacs. Full text available.

Message received at 10758 <at> debbugs.gnu.org:


Received: (at 10758) by debbugs.gnu.org; 1 Nov 2019 22:48:10 +0000
From debbugs-submit-bounces <at> debbugs.gnu.org Fri Nov 01 18:48:10 2019
Received: from localhost ([127.0.0.1]:57448 helo=debbugs.gnu.org)
	by debbugs.gnu.org with esmtp (Exim 4.84_2)
	(envelope-from <debbugs-submit-bounces <at> debbugs.gnu.org>)
	id 1iQfiE-0005FN-78
	for submit <at> debbugs.gnu.org; Fri, 01 Nov 2019 18:48:10 -0400
Received: from host.gofardesign.uk ([208.79.239.190]:46987)
 by debbugs.gnu.org with esmtp (Exim 4.84_2)
 (envelope-from <stefan@HIDDEN>) id 1iQfiC-0005F4-IN
 for 10758 <at> debbugs.gnu.org; Fri, 01 Nov 2019 18:48:08 -0400
DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=marxist.se; 
 s=default;
 h=Content-Type:MIME-Version:Message-ID:Date:References:
 In-Reply-To:Subject:Cc:To:From:Sender:Reply-To:Content-Transfer-Encoding:
 Content-ID:Content-Description:Resent-Date:Resent-From:Resent-Sender:
 Resent-To:Resent-Cc:Resent-Message-ID:List-Id:List-Help:List-Unsubscribe:
 List-Subscribe:List-Post:List-Owner:List-Archive;
 bh=mb4phhSzH6ILLj/cHBylMz8PD5J8uf/GR8VxYGS/qj8=; b=lJoWJ//ZDUlua6b+NuoPEpuCeI
 KCAmYNkrB2XIoAHIGXZbnoIIp3i4w/AorfEnpxiNyOjEBlKpBCNhwLQ4bb6qY7dl1BZtrIzlUDcx2
 FjosG4zNy9vgzMest9TytBO2/N6w9agYzP2ENzhuKMTJgyTJdeFNo6JgMXn9wxJiEdn4=;
Received: from h-70-69.a785.priv.bahnhof.se ([155.4.70.69]:53340
 helo=localhost)
 by host.gofardesign.uk with esmtpsa (TLSv1.2:ECDHE-RSA-AES256-GCM-SHA384:256)
 (Exim 4.92) (envelope-from <stefan@HIDDEN>)
 id 1iQfi6-0006ll-K9; Fri, 01 Nov 2019 17:48:03 -0500
From: Stefan Kangas <stefan@HIDDEN>
To: Glenn Morris <rgm@HIDDEN>
Subject: Re: thumbs and image-dired to use built-in ImageMagick
In-Reply-To: <8xfwemx6yr.fsf@HIDDEN> (Glenn Morris's message of
 "Tue, 07 Feb 2012 23:52:12 -0500")
References: <8xfwemx6yr.fsf@HIDDEN>
User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/27.0.50 (gnu/linux)
Date: Fri, 01 Nov 2019 23:47:59 +0100
Message-ID: <87k18jw6w0.fsf@HIDDEN>
MIME-Version: 1.0
Content-Type: text/plain
X-OutGoing-Spam-Status: No, score=-1.0
X-AntiAbuse: This header was added to track abuse,
 please include it with any abuse report
X-AntiAbuse: Primary Hostname - host.gofardesign.uk
X-AntiAbuse: Original Domain - debbugs.gnu.org
X-AntiAbuse: Originator/Caller UID/GID - [47 12] / [47 12]
X-AntiAbuse: Sender Address Domain - marxist.se
X-Get-Message-Sender-Via: host.gofardesign.uk: authenticated_id:
 stefan@HIDDEN
X-Authenticated-Sender: host.gofardesign.uk: stefan@HIDDEN
X-Source: 
X-Source-Args: 
X-Source-Dir: 
X-Spam-Score: -0.0 (/)
X-Debbugs-Envelope-To: 10758
Cc: 10758 <at> debbugs.gnu.org
X-BeenThere: debbugs-submit <at> debbugs.gnu.org
X-Mailman-Version: 2.1.18
Precedence: list
List-Id: <debbugs-submit.debbugs.gnu.org>
List-Unsubscribe: <https://debbugs.gnu.org/cgi-bin/mailman/options/debbugs-submit>, 
 <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=unsubscribe>
List-Archive: <https://debbugs.gnu.org/cgi-bin/mailman/private/debbugs-submit/>
List-Post: <mailto:debbugs-submit <at> debbugs.gnu.org>
List-Help: <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=help>
List-Subscribe: <https://debbugs.gnu.org/cgi-bin/mailman/listinfo/debbugs-submit>, 
 <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=subscribe>
Errors-To: debbugs-submit-bounces <at> debbugs.gnu.org
Sender: "Debbugs-submit" <debbugs-submit-bounces <at> debbugs.gnu.org>
X-Spam-Score: -1.0 (-)

Glenn Morris <rgm@HIDDEN> writes:

> Package: emacs
> Version: 24.0.93
> Severity: wishlist
>
> thumbs.el and image-dired.el both rely on using external ImageMagick
> utilities to resize/rotate images.
>
> If Emacs was compiled with ImageMagick support, then images of
> type imagemagick can be resized and rotated internally (see
> image-transform-*). These modes should use the internal support if
> it exists.

So now that we have native image rotation and ImageMagick is on its
way to become deprecated, I assume that this bug should be taken to
mean that we want to use the built-in support here instead.

Best regards,
Stefan Kangas




Information forwarded to bug-gnu-emacs@HIDDEN:
bug#10758; Package emacs. Full text available.

Message received at submit <at> debbugs.gnu.org:


Received: (at submit) by debbugs.gnu.org; 8 Feb 2012 04:53:14 +0000
From debbugs-submit-bounces <at> debbugs.gnu.org Tue Feb 07 23:53:14 2012
Received: from localhost ([127.0.0.1]:59767 helo=debbugs.gnu.org)
	by debbugs.gnu.org with esmtp (Exim 4.72)
	(envelope-from <debbugs-submit-bounces <at> debbugs.gnu.org>)
	id 1RuzWs-0004NT-Ly
	for submit <at> debbugs.gnu.org; Tue, 07 Feb 2012 23:53:14 -0500
Received: from fencepost.gnu.org ([140.186.70.10]:57659 ident=Debian-exim)
	by debbugs.gnu.org with esmtp (Exim 4.72)
	(envelope-from <rgm@HIDDEN>) id 1RuzWq-0004NL-Gu
	for submit <at> debbugs.gnu.org; Tue, 07 Feb 2012 23:53:13 -0500
Received: from rgm by fencepost.gnu.org with local (Exim 4.71)
	(envelope-from <rgm@HIDDEN>)
	id 1RuzVs-0001gf-Ep; Tue, 07 Feb 2012 23:52:12 -0500
From: Glenn Morris <rgm@HIDDEN>
To: submit <at> debbugs.gnu.org
Subject: thumbs and image-dired to use built-in ImageMagick
X-Spook: SP4 gamma cracking mania Comirex AMW George W. Bush
X-Ran: ARxeBbR,fE<T<-C/BcngB"'M{hF;)!f1oD?qVW!Kv6P}w&.g,^8-DMhA,|(6z_R(T)6\x}
X-Hue: red
X-Debbugs-No-Ack: yes
X-Attribution: GM
Date: Tue, 07 Feb 2012 23:52:12 -0500
Message-ID: <8xfwemx6yr.fsf@HIDDEN>
User-Agent: Gnus (www.gnus.org), GNU Emacs (www.gnu.org/software/emacs/)
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
X-Spam-Score: -4.2 (----)
X-Debbugs-Envelope-To: submit
X-BeenThere: debbugs-submit <at> debbugs.gnu.org
X-Mailman-Version: 2.1.13
Precedence: list
List-Id: <debbugs-submit.debbugs.gnu.org>
List-Unsubscribe: <http://debbugs.gnu.org/cgi-bin/mailman/options/debbugs-submit>,
	<mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=unsubscribe>
List-Archive: <http://debbugs.gnu.org/cgi-bin/mailman/private/debbugs-submit>
List-Post: <mailto:debbugs-submit <at> debbugs.gnu.org>
List-Help: <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=help>
List-Subscribe: <http://debbugs.gnu.org/cgi-bin/mailman/listinfo/debbugs-submit>,
	<mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=subscribe>
Sender: debbugs-submit-bounces <at> debbugs.gnu.org
Errors-To: debbugs-submit-bounces <at> debbugs.gnu.org
X-Spam-Score: -4.2 (----)

Package: emacs
Version: 24.0.93
Severity: wishlist

thumbs.el and image-dired.el both rely on using external ImageMagick
utilities to resize/rotate images.

If Emacs was compiled with ImageMagick support, then images of
type imagemagick can be resized and rotated internally (see
image-transform-*). These modes should use the internal support if
it exists.




Report forwarded to bug-gnu-emacs@HIDDEN:
bug#10758; Package emacs. Full text available.
Please note: This is a static page, with minimal formatting, updated once a day.
Click here to see this page with the latest information and nicer formatting.
Last modified: Thu, 4 Nov 2021 00:15:02 UTC

GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997 nCipher Corporation Ltd, 1994-97 Ian Jackson.