GNU bug report logs - #10806
24.0.93; `cancel-edebug-on-entry': many tiny problems

Previous Next

To add a comment to this bug, you must first unarchive it, by sending
a message to control AT debbugs.gnu.org, with unarchive 10806 in the body.
You can then email your comments to 10806 AT debbugs.gnu.org in the normal way.

Toggle the display of automated, internal messages from the tracker.

Message #5 received at submit <at> debbugs.gnu.org (full text, mbox):

From: Michael Heerdegen <michael_heerdegen <at> web.de>
To: bug-gnu-emacs <at> gnu.org
Subject: 24.0.93; `cancel-edebug-on-entry': many tiny problems
Date: Mon, 13 Feb 2012 23:55:59 +0100

1. It is a user command, but is has no docstring.

2. The user can't find it easily: it doesn't start with "edebug".  I
needed to consult the source to find it.  Can we at least add
something like

  (defalias 'edebug-cancel-edebug-on-entry #'cancel-edebug-on-entry)

3. The prompt string "Edebug on entry to: " should include the word
"cancel".

4. Wouldn't it be better to limit the input to functions that are
instrumented?


Thanks,

Michael.


In GNU Emacs 24.0.93.1 (i486-pc-linux-gnu, GTK+ Version 3.2.3)
 of 2012-02-08 on zelenka, modified by Debian
 (emacs-snapshot package, version 2:20120208-1)
Windowing system distributor `The X.Org Foundation', version 11.0.11103901
Configured using:
 `configure '--build' 'i486-linux-gnu' '--host' 'i486-linux-gnu'
 '--prefix=/usr' '--sharedstatedir=/var/lib' '--libexecdir=/usr/lib'
 '--localstatedir=/var' '--infodir=/usr/share/info'
 '--mandir=/usr/share/man' '--with-pop=yes'
 '--enable-locallisppath=/etc/emacs-snapshot:/etc/emacs:/usr/local/share/emacs/24.0.93/site-lisp:/usr/local/share/emacs/site-lisp:/usr/share/emacs/24.0.93/site-lisp:/usr/share/emacs/site-lisp'
 '--without-compress-info' '--with-crt-dir=/usr/lib/i386-linux-gnu/'
 '--with-x=yes' '--with-x-toolkit=gtk3' '--with-imagemagick=yes'
 'build_alias=i486-linux-gnu' 'host_alias=i486-linux-gnu'
 'CFLAGS=-DDEBIAN -DSITELOAD_PURESIZE_EXTRA=5000 -g -O2''

Message #8 received at 10806 <at> debbugs.gnu.org (full text, mbox):

From: Stefan Monnier <monnier <at> iro.umontreal.ca>
To: michael_heerdegen <at> web.de
Cc: 10806 <at> debbugs.gnu.org
Subject: Re: bug#10806: 24.0.93; `cancel-edebug-on-entry': many tiny problems
Date: Wed, 21 Mar 2012 14:17:56 -0400

> 1. It is a user command, but is has no docstring.
> 2. The user can't find it easily: it doesn't start with "edebug".  I
> needed to consult the source to find it.  Can we at least add
> something like

>   (defalias 'edebug-cancel-edebug-on-entry #'cancel-edebug-on-entry)

Yes.

> 3. The prompt string "Edebug on entry to: " should include the word
> "cancel".

Yes.

> 4. Wouldn't it be better to limit the input to functions that are
> instrumented?

Yes (or we could also consider making edebug-on-entry into a toggle).

Patch welcome for 24.2,


        Stefan

Message #11 received at 10806 <at> debbugs.gnu.org (full text, mbox):

From: Lars Ingebrigtsen <larsi <at> gnus.org>
To: Michael Heerdegen <michael_heerdegen <at> web.de>
Cc: 10806 <at> debbugs.gnu.org
Subject: Re: bug#10806: 24.0.93; `cancel-edebug-on-entry': many tiny problems
Date: Sun, 20 Oct 2019 09:48:51 +0200

Michael Heerdegen <michael_heerdegen <at> web.de> writes:

> 1. It is a user command, but is has no docstring.
>
> 2. The user can't find it easily: it doesn't start with "edebug".  I
> needed to consult the source to find it.  Can we at least add
> something like
>
>   (defalias 'edebug-cancel-edebug-on-entry #'cancel-edebug-on-entry)
>
> 3. The prompt string "Edebug on entry to: " should include the word
> "cancel".
>
> 4. Wouldn't it be better to limit the input to functions that are
> instrumented?

It looks like these things have been fixed in the years since -- except
that it looks like it's had a doc string since at least 2005, and the
prompt has mentioned "cancel" since that time, too?

But the alias hasn't been added -- Stefan OK'd it, though, so I've now
added it in Emacs 27, and I'm closing this bug report.

-- 
(domestic pets only, the antidote for overdose, milk.)
   bloggy blog: http://lars.ingebrigtsen.no

Message #18 received at 10806 <at> debbugs.gnu.org (full text, mbox):

From: Lars Ingebrigtsen <larsi <at> gnus.org>
To: Michael Heerdegen <michael_heerdegen <at> web.de>
Cc: 10806 <at> debbugs.gnu.org
Subject: Re: bug#10806: 24.0.93; `cancel-edebug-on-entry': many tiny problems
Date: Sun, 20 Oct 2019 10:30:09 +0200

Lars Ingebrigtsen <larsi <at> gnus.org> writes:

> It looks like these things have been fixed in the years since -- except
> that it looks like it's had a doc string since at least 2005, and the
> prompt has mentioned "cancel" since that time, too?
>
> But the alias hasn't been added -- Stefan OK'd it, though, so I've now
> added it in Emacs 27, and I'm closing this bug report.

I was confused -- I was looking at cancel-debug-on-entry, not
cancel-edebug-on-entry.

-- 
(domestic pets only, the antidote for overdose, milk.)
   bloggy blog: http://lars.ingebrigtsen.no

Message #21 received at 10806 <at> debbugs.gnu.org (full text, mbox):

From: Lars Ingebrigtsen <larsi <at> gnus.org>
To: Michael Heerdegen <michael_heerdegen <at> web.de>
Cc: 10806 <at> debbugs.gnu.org
Subject: Re: bug#10806: 24.0.93; `cancel-edebug-on-entry': many tiny problems
Date: Sun, 20 Oct 2019 10:51:46 +0200

Lars Ingebrigtsen <larsi <at> gnus.org> writes:

> Lars Ingebrigtsen <larsi <at> gnus.org> writes:
>
>> It looks like these things have been fixed in the years since -- except
>> that it looks like it's had a doc string since at least 2005, and the
>> prompt has mentioned "cancel" since that time, too?
>>
>> But the alias hasn't been added -- Stefan OK'd it, though, so I've now
>> added it in Emacs 27, and I'm closing this bug report.
>
> I was confused -- I was looking at cancel-debug-on-entry, not
> cancel-edebug-on-entry.

I've now fixed the things the bug report mentioned in Emacs 27.

-- 
(domestic pets only, the antidote for overdose, milk.)
   bloggy blog: http://lars.ingebrigtsen.no

Message #24 received at 10806 <at> debbugs.gnu.org (full text, mbox):

From: Michael Heerdegen <michael_heerdegen <at> web.de>
To: Lars Ingebrigtsen <larsi <at> gnus.org>
Cc: 10806 <at> debbugs.gnu.org
Subject: Re: bug#10806: 24.0.93; `cancel-edebug-on-entry': many tiny problems
Date: Sun, 20 Oct 2019 12:20:56 +0200

Lars Ingebrigtsen <larsi <at> gnus.org> writes:

> I've now fixed the things the bug report mentioned in Emacs 27.

Thanks!

Two comments:

(1)

> +  (unless functions
> +    (error "No functions have `edebug-on-entry'."))

Should this better be a `user-error' (and I guess the error message
should not end with a period)?

(2) Would it make sense to make the default behavior analog to that of
`cancel-debug-on-entry': remove edebug-on-entry property of all
functions?


Regards,

Michael.

Message #27 received at 10806 <at> debbugs.gnu.org (full text, mbox):

From: Lars Ingebrigtsen <larsi <at> gnus.org>
To: Michael Heerdegen <michael_heerdegen <at> web.de>
Cc: 10806 <at> debbugs.gnu.org
Subject: Re: bug#10806: 24.0.93; `cancel-edebug-on-entry': many tiny problems
Date: Sun, 20 Oct 2019 12:37:51 +0200

Michael Heerdegen <michael_heerdegen <at> web.de> writes:

>> +  (unless functions
>> +    (error "No functions have `edebug-on-entry'."))
>
> Should this better be a `user-error' (and I guess the error message
> should not end with a period)?

Yup; fixed now.

> (2) Would it make sense to make the default behavior analog to that of
> `cancel-debug-on-entry': remove edebug-on-entry property of all
> functions?

Hm...  Good idea.  I've now made this change.

-- 
(domestic pets only, the antidote for overdose, milk.)
   bloggy blog: http://lars.ingebrigtsen.no

Previous Next

GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson.