Stefan Kangas <stefankangas@HIDDEN>
to control <at> debbugs.gnu.org.
Full text available.
Received: (at 11301) by debbugs.gnu.org; 6 Jun 2021 17:58:07 +0000
From debbugs-submit-bounces <at> debbugs.gnu.org Sun Jun 06 13:58:07 2021
Received: from localhost ([127.0.0.1]:53842 helo=debbugs.gnu.org)
by debbugs.gnu.org with esmtp (Exim 4.84_2)
(envelope-from <debbugs-submit-bounces <at> debbugs.gnu.org>)
id 1lpx2E-0001S6-Rx
for submit <at> debbugs.gnu.org; Sun, 06 Jun 2021 13:58:07 -0400
Received: from mailscanner.iro.umontreal.ca ([132.204.25.50]:4266)
by debbugs.gnu.org with esmtp (Exim 4.84_2)
(envelope-from <monnier@HIDDEN>) id 1lpx2B-0001Ra-9m
for 11301 <at> debbugs.gnu.org; Sun, 06 Jun 2021 13:58:05 -0400
Received: from pmg2.iro.umontreal.ca (localhost.localdomain [127.0.0.1])
by pmg2.iro.umontreal.ca (Proxmox) with ESMTP id C30A1806A5;
Sun, 6 Jun 2021 13:57:57 -0400 (EDT)
Received: from mail01.iro.umontreal.ca (unknown [172.31.2.1])
by pmg2.iro.umontreal.ca (Proxmox) with ESMTP id 6FA0E80240;
Sun, 6 Jun 2021 13:57:56 -0400 (EDT)
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=iro.umontreal.ca;
s=mail; t=1623002276;
bh=vkKJXQ7fDx3lUadSUUvp9FcsW+uG3KZvEdCLLRWiznk=;
h=From:To:Cc:Subject:References:Date:In-Reply-To:From;
b=JgqLv23yvufCX3sI2ioTcR1RSID9oot+bFy/9chG/XJxtdVMcOEKQ/jozUyf/08vV
CLedMCS74Q5IKvwYnWCUkdxPM2qF9RkscHkUeyflpaEspcqkvPaElSONBXGcfrv7yE
NhEYy/vMFeokMMojsIfLqjnU/OOIVXcgza+wFnSBWOe0Av+PU0BcTle70M4P3GnzJy
reBDcP7Hm0z2fgZIBFtSKDeHgbn2Ov1KZFlMfkIHFtW+LW1geotPm3igTinU3QvoUa
APRt02RLjw7FeGyzt0STABLPj554UfLptnSWO759G5km1CDsUxqvKIxSeq57PfDHLZ
DasGsdjdUwXcw==
Received: from alfajor (69-196-163-239.dsl.teksavvy.com [69.196.163.239])
by mail01.iro.umontreal.ca (Postfix) with ESMTPSA id 2D34D1202D5;
Sun, 6 Jun 2021 13:57:56 -0400 (EDT)
From: Stefan Monnier <monnier@HIDDEN>
To: Lars Ingebrigtsen <larsi@HIDDEN>
Subject: Re: bug#11301: 24.1.50; `define-minor-mode' should set
`custom-mode-group' according to :group
Message-ID: <jwv35tuubb9.fsf-monnier+emacs@HIDDEN>
References: <3208B35C4FFE47FFBD0A7029AB2DBB8C@HIDDEN>
<87wnrc7o3p.fsf@HIDDEN> <jwv5yywflpv.fsf-monnier+emacs@HIDDEN>
<874kefbdcx.fsf@HIDDEN> <jwvfsxz84q7.fsf-monnier+emacs@HIDDEN>
<87wnra10i1.fsf@HIDDEN> <jwv4ked366a.fsf-monnier+emacs@HIDDEN>
<874kebuysj.fsf@HIDDEN>
Date: Sun, 06 Jun 2021 13:57:55 -0400
In-Reply-To: <874kebuysj.fsf@HIDDEN> (Lars Ingebrigtsen's message of "Sun,
06 Jun 2021 11:29:00 +0200")
User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/28.0.50 (gnu/linux)
MIME-Version: 1.0
Content-Type: text/plain
X-SPAM-INFO: Spam detection results: 0
ALL_TRUSTED -1 Passed through trusted hosts only via SMTP
AWL -0.020 Adjusted score from AWL reputation of From: address
BAYES_00 -1.9 Bayes spam probability is 0 to 1%
DKIM_SIGNED 0.1 Message has a DKIM or DK signature,
not necessarily valid
DKIM_VALID -0.1 Message has at least one valid DKIM or DK signature
DKIM_VALID_AU -0.1 Message has a valid DKIM or DK signature from author's
domain
X-SPAM-LEVEL:
X-Spam-Score: -2.3 (--)
X-Debbugs-Envelope-To: 11301
Cc: 11301 <at> debbugs.gnu.org, Drew Adams <drew.adams@HIDDEN>
X-BeenThere: debbugs-submit <at> debbugs.gnu.org
X-Mailman-Version: 2.1.18
Precedence: list
List-Id: <debbugs-submit.debbugs.gnu.org>
List-Unsubscribe: <https://debbugs.gnu.org/cgi-bin/mailman/options/debbugs-submit>,
<mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=unsubscribe>
List-Archive: <https://debbugs.gnu.org/cgi-bin/mailman/private/debbugs-submit/>
List-Post: <mailto:debbugs-submit <at> debbugs.gnu.org>
List-Help: <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=help>
List-Subscribe: <https://debbugs.gnu.org/cgi-bin/mailman/listinfo/debbugs-submit>,
<mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=subscribe>
Errors-To: debbugs-submit-bounces <at> debbugs.gnu.org
Sender: "Debbugs-submit" <debbugs-submit-bounces <at> debbugs.gnu.org>
X-Spam-Score: -3.3 (---)
Lars Ingebrigtsen [2021-06-06 11:29:00] wrote:
> Stefan Monnier <monnier@HIDDEN> writes:
>> Because we haven't been able to provide Custom support for buffer-local
>> variables in the many years since `defcustom` was introduced. ;-)
> Hm... defcustom does have a :local keyword now (since 2019), and...
> er... It probably works? But I'm not sure what `M-x customize' does
> with that. Probably nothing?
That sounds about right.
Stefan
bug-gnu-emacs@HIDDEN:bug#11301; Package emacs.
Full text available.Received: (at 11301) by debbugs.gnu.org; 6 Jun 2021 09:29:13 +0000 From debbugs-submit-bounces <at> debbugs.gnu.org Sun Jun 06 05:29:13 2021 Received: from localhost ([127.0.0.1]:50672 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from <debbugs-submit-bounces <at> debbugs.gnu.org>) id 1lpp5l-0005ns-BJ for submit <at> debbugs.gnu.org; Sun, 06 Jun 2021 05:29:13 -0400 Received: from quimby.gnus.org ([95.216.78.240]:57442) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from <larsi@HIDDEN>) id 1lpp5i-0005nf-Tn for 11301 <at> debbugs.gnu.org; Sun, 06 Jun 2021 05:29:11 -0400 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=gnus.org; s=20200322; h=Content-Type:MIME-Version:Message-ID:In-Reply-To:Date: References:Subject:Cc:To:From:Sender:Reply-To:Content-Transfer-Encoding: Content-ID:Content-Description:Resent-Date:Resent-From:Resent-Sender: Resent-To:Resent-Cc:Resent-Message-ID:List-Id:List-Help:List-Unsubscribe: List-Subscribe:List-Post:List-Owner:List-Archive; bh=WUZtgD7M+0otxJkto7UxHhg9xrHSmEsNjwOw5p5lDKU=; b=ZDlp2miij+ArRj8AuxAqhMSqXn CzoqsBRl5HvvIIMkujEU6J1amqEo9H9x+xEW41haB1cF1ueXJ+SkEGPmjsPELo26s1DLazeU9QHbQ 65zVJFnLVQ9a77nHWinNZDZAhde7bmhpk+0c3w2Vdd6PjdzTs+VOV65CjGOHOgh214T8=; Received: from cm-84.212.220.105.getinternet.no ([84.212.220.105] helo=xo) by quimby.gnus.org with esmtpsa (TLS1.3:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from <larsi@HIDDEN>) id 1lpp5Z-0004w6-AT; Sun, 06 Jun 2021 11:29:03 +0200 From: Lars Ingebrigtsen <larsi@HIDDEN> To: Stefan Monnier <monnier@HIDDEN> Subject: Re: bug#11301: 24.1.50; `define-minor-mode' should set `custom-mode-group' according to :group References: <3208B35C4FFE47FFBD0A7029AB2DBB8C@HIDDEN> <87wnrc7o3p.fsf@HIDDEN> <jwv5yywflpv.fsf-monnier+emacs@HIDDEN> <874kefbdcx.fsf@HIDDEN> <jwvfsxz84q7.fsf-monnier+emacs@HIDDEN> <87wnra10i1.fsf@HIDDEN> <jwv4ked366a.fsf-monnier+emacs@HIDDEN> X-Now-Playing: Microtub's _Sonic Drift_: "Sonic Drift" Date: Sun, 06 Jun 2021 11:29:00 +0200 In-Reply-To: <jwv4ked366a.fsf-monnier+emacs@HIDDEN> (Stefan Monnier's message of "Fri, 04 Jun 2021 13:13:21 -0400") Message-ID: <874kebuysj.fsf@HIDDEN> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/28.0.50 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain X-Spam-Report: Spam detection software, running on the system "quimby.gnus.org", has NOT identified this incoming email as spam. The original message has been attached to this so you can view it or label similar future email. If you have any questions, see @@CONTACT_ADDRESS@@ for details. Content preview: Stefan Monnier <monnier@HIDDEN> writes: > Because we haven't been able to provide Custom support for buffer-local > variables in the many years since `defcustom` was introduced. ;-) Hm... defcustom does have a :local keyword now (since 2019), and... er... It probably works? But I'm not sure what `M-x customize' does with that. Probably nothing? Content analysis details: (-2.9 points, 5.0 required) pts rule name description ---- ---------------------- -------------------------------------------------- -1.0 ALL_TRUSTED Passed through trusted hosts only via SMTP -1.9 BAYES_00 BODY: Bayes spam probability is 0 to 1% [score: 0.0000] X-Spam-Score: -0.7 (/) X-Debbugs-Envelope-To: 11301 Cc: 11301 <at> debbugs.gnu.org, Drew Adams <drew.adams@HIDDEN> X-BeenThere: debbugs-submit <at> debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: <debbugs-submit.debbugs.gnu.org> List-Unsubscribe: <https://debbugs.gnu.org/cgi-bin/mailman/options/debbugs-submit>, <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=unsubscribe> List-Archive: <https://debbugs.gnu.org/cgi-bin/mailman/private/debbugs-submit/> List-Post: <mailto:debbugs-submit <at> debbugs.gnu.org> List-Help: <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=help> List-Subscribe: <https://debbugs.gnu.org/cgi-bin/mailman/listinfo/debbugs-submit>, <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=subscribe> Errors-To: debbugs-submit-bounces <at> debbugs.gnu.org Sender: "Debbugs-submit" <debbugs-submit-bounces <at> debbugs.gnu.org> X-Spam-Score: -1.7 (-) Stefan Monnier <monnier@HIDDEN> writes: > Because we haven't been able to provide Custom support for buffer-local > variables in the many years since `defcustom` was introduced. ;-) Hm... defcustom does have a :local keyword now (since 2019), and... er... It probably works? But I'm not sure what `M-x customize' does with that. Probably nothing? -- (domestic pets only, the antidote for overdose, milk.) bloggy blog: http://lars.ingebrigtsen.no
bug-gnu-emacs@HIDDEN:bug#11301; Package emacs.
Full text available.
Received: (at 11301) by debbugs.gnu.org; 4 Jun 2021 17:13:46 +0000
From debbugs-submit-bounces <at> debbugs.gnu.org Fri Jun 04 13:13:46 2021
Received: from localhost ([127.0.0.1]:47845 helo=debbugs.gnu.org)
by debbugs.gnu.org with esmtp (Exim 4.84_2)
(envelope-from <debbugs-submit-bounces <at> debbugs.gnu.org>)
id 1lpDOA-0004Jb-Td
for submit <at> debbugs.gnu.org; Fri, 04 Jun 2021 13:13:46 -0400
Received: from mailscanner.iro.umontreal.ca ([132.204.25.50]:41603)
by debbugs.gnu.org with esmtp (Exim 4.84_2)
(envelope-from <monnier@HIDDEN>) id 1lpDO5-0004JK-G8
for 11301 <at> debbugs.gnu.org; Fri, 04 Jun 2021 13:13:41 -0400
Received: from pmg2.iro.umontreal.ca (localhost.localdomain [127.0.0.1])
by pmg2.iro.umontreal.ca (Proxmox) with ESMTP id 35A05806F0;
Fri, 4 Jun 2021 13:13:31 -0400 (EDT)
Received: from mail01.iro.umontreal.ca (unknown [172.31.2.1])
by pmg2.iro.umontreal.ca (Proxmox) with ESMTP id 83DBD80531;
Fri, 4 Jun 2021 13:13:22 -0400 (EDT)
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=iro.umontreal.ca;
s=mail; t=1622826802;
bh=OiETEqdpMXbPL4ZcxLQNKoMzZN3nUSX3jXjB+6xXzg4=;
h=From:To:Cc:Subject:References:Date:In-Reply-To:From;
b=CnAm0gHTkciTeMuxsOk2evBTu2kxsU7s3OzkuIYWbqWtr4n4VMVKUOvRBPDBzAlpq
SB3AsHrLkiL+k6A0jTI6dLeljl1ZIhmfTtW1qLhyDeXw42pZks+S1xARM+gfcvBxgL
HzNK2De6d5j52hV4GkQ59qazzimGxbBeeR3aDnevmt+Vi74wnUccvba6kEb1Hqu4O1
AlLXCHiGchksMCIQJuUtDPjL9oXEiB2LGAtzH4yNPu5N6YuMfX+bjw76knkvQ6jwvy
atR7Rar/HljkCSjZTH7dSUD/X21hbJyS/q5tcV03qYvZARI3cqgV60EXCo6N6V02DE
QXhbzBVRhdnsA==
Received: from alfajor (69-196-163-239.dsl.teksavvy.com [69.196.163.239])
by mail01.iro.umontreal.ca (Postfix) with ESMTPSA id 4DDBF12027F;
Fri, 4 Jun 2021 13:13:22 -0400 (EDT)
From: Stefan Monnier <monnier@HIDDEN>
To: Lars Ingebrigtsen <larsi@HIDDEN>
Subject: Re: bug#11301: 24.1.50; `define-minor-mode' should set
`custom-mode-group' according to :group
Message-ID: <jwv4ked366a.fsf-monnier+emacs@HIDDEN>
References: <3208B35C4FFE47FFBD0A7029AB2DBB8C@HIDDEN>
<87wnrc7o3p.fsf@HIDDEN> <jwv5yywflpv.fsf-monnier+emacs@HIDDEN>
<874kefbdcx.fsf@HIDDEN> <jwvfsxz84q7.fsf-monnier+emacs@HIDDEN>
<87wnra10i1.fsf@HIDDEN>
Date: Fri, 04 Jun 2021 13:13:21 -0400
In-Reply-To: <87wnra10i1.fsf@HIDDEN> (Lars Ingebrigtsen's message of "Fri,
04 Jun 2021 10:45:42 +0200")
User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/28.0.50 (gnu/linux)
MIME-Version: 1.0
Content-Type: text/plain
X-SPAM-INFO: Spam detection results: 0
ALL_TRUSTED -1 Passed through trusted hosts only via SMTP
AWL -0.013 Adjusted score from AWL reputation of From: address
BAYES_00 -1.9 Bayes spam probability is 0 to 1%
DKIM_SIGNED 0.1 Message has a DKIM or DK signature,
not necessarily valid
DKIM_VALID -0.1 Message has at least one valid DKIM or DK signature
DKIM_VALID_AU -0.1 Message has a valid DKIM or DK signature from author's
domain
X-SPAM-LEVEL:
X-Spam-Score: -2.3 (--)
X-Debbugs-Envelope-To: 11301
Cc: 11301 <at> debbugs.gnu.org, Drew Adams <drew.adams@HIDDEN>
X-BeenThere: debbugs-submit <at> debbugs.gnu.org
X-Mailman-Version: 2.1.18
Precedence: list
List-Id: <debbugs-submit.debbugs.gnu.org>
List-Unsubscribe: <https://debbugs.gnu.org/cgi-bin/mailman/options/debbugs-submit>,
<mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=unsubscribe>
List-Archive: <https://debbugs.gnu.org/cgi-bin/mailman/private/debbugs-submit/>
List-Post: <mailto:debbugs-submit <at> debbugs.gnu.org>
List-Help: <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=help>
List-Subscribe: <https://debbugs.gnu.org/cgi-bin/mailman/listinfo/debbugs-submit>,
<mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=subscribe>
Errors-To: debbugs-submit-bounces <at> debbugs.gnu.org
Sender: "Debbugs-submit" <debbugs-submit-bounces <at> debbugs.gnu.org>
X-Spam-Score: -3.3 (---)
Lars Ingebrigtsen [2021-06-04 10:45:42] wrote:
> Stefan Monnier <monnier@HIDDEN> writes:
>> The "extra args for decustom" are only used when define-minor-mode uses
>> a defcustom, i.e. only for global minor modes.
> Yes. But why? :-)
Because we haven't been able to provide Custom support for buffer-local
variables in the many years since `defcustom` was introduced. ;-)
Stefan
bug-gnu-emacs@HIDDEN:bug#11301; Package emacs.
Full text available.Received: (at 11301) by debbugs.gnu.org; 4 Jun 2021 08:45:56 +0000 From debbugs-submit-bounces <at> debbugs.gnu.org Fri Jun 04 04:45:56 2021 Received: from localhost ([127.0.0.1]:45278 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from <debbugs-submit-bounces <at> debbugs.gnu.org>) id 1lp5Sl-0002hh-WB for submit <at> debbugs.gnu.org; Fri, 04 Jun 2021 04:45:56 -0400 Received: from quimby.gnus.org ([95.216.78.240]:58192) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from <larsi@HIDDEN>) id 1lp5Sk-0002bX-0R for 11301 <at> debbugs.gnu.org; Fri, 04 Jun 2021 04:45:54 -0400 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=gnus.org; s=20200322; h=Content-Type:MIME-Version:Message-ID:In-Reply-To:Date: References:Subject:Cc:To:From:Sender:Reply-To:Content-Transfer-Encoding: Content-ID:Content-Description:Resent-Date:Resent-From:Resent-Sender: Resent-To:Resent-Cc:Resent-Message-ID:List-Id:List-Help:List-Unsubscribe: List-Subscribe:List-Post:List-Owner:List-Archive; bh=pyJ7BRCn2uOUzvt2psg2t2zwXchrBuOnG9ZXhiMaNbE=; b=oQAPsgcmORENFz2pP4vTsknJ1u A4O3zsJWlw8MXqY9xSJiHv31OMGmaLLpwqNOWe3QWm3PoEJuvIuvqXtMfzY5Sl/D7AplY6Cz/8zXq 2NuqtDt5GM/J99fAIJa2EKQVLNyTOKtOpC7BACCXcwrKLoFsVBlxLaXOnGkE3A4wrwy4=; Received: from cm-84.212.220.105.getinternet.no ([84.212.220.105] helo=xo) by quimby.gnus.org with esmtpsa (TLS1.3:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from <larsi@HIDDEN>) id 1lp5SZ-0003Qn-0X; Fri, 04 Jun 2021 10:45:47 +0200 From: Lars Ingebrigtsen <larsi@HIDDEN> To: Stefan Monnier <monnier@HIDDEN> Subject: Re: bug#11301: 24.1.50; `define-minor-mode' should set `custom-mode-group' according to :group References: <3208B35C4FFE47FFBD0A7029AB2DBB8C@HIDDEN> <87wnrc7o3p.fsf@HIDDEN> <jwv5yywflpv.fsf-monnier+emacs@HIDDEN> <874kefbdcx.fsf@HIDDEN> <jwvfsxz84q7.fsf-monnier+emacs@HIDDEN> X-Now-Playing: Mia Doi Todd's _Music Life_: "Little Bird (feat. Fabiano do Nascimento & Miguel Atwood-Ferguson)" Date: Fri, 04 Jun 2021 10:45:42 +0200 In-Reply-To: <jwvfsxz84q7.fsf-monnier+emacs@HIDDEN> (Stefan Monnier's message of "Thu, 03 Jun 2021 09:20:44 -0400") Message-ID: <87wnra10i1.fsf@HIDDEN> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/28.0.50 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain X-Spam-Report: Spam detection software, running on the system "quimby.gnus.org", has NOT identified this incoming email as spam. The original message has been attached to this so you can view it or label similar future email. If you have any questions, see @@CONTACT_ADDRESS@@ for details. Content preview: Stefan Monnier <monnier@HIDDEN> writes: > The "extra args for decustom" are only used when define-minor-mode uses > a defcustom, i.e. only for global minor modes. Yes. But why? :-) Content analysis details: (-2.9 points, 5.0 required) pts rule name description ---- ---------------------- -------------------------------------------------- -1.0 ALL_TRUSTED Passed through trusted hosts only via SMTP -1.9 BAYES_00 BODY: Bayes spam probability is 0 to 1% [score: 0.0000] X-Spam-Score: -0.7 (/) X-Debbugs-Envelope-To: 11301 Cc: 11301 <at> debbugs.gnu.org, Drew Adams <drew.adams@HIDDEN> X-BeenThere: debbugs-submit <at> debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: <debbugs-submit.debbugs.gnu.org> List-Unsubscribe: <https://debbugs.gnu.org/cgi-bin/mailman/options/debbugs-submit>, <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=unsubscribe> List-Archive: <https://debbugs.gnu.org/cgi-bin/mailman/private/debbugs-submit/> List-Post: <mailto:debbugs-submit <at> debbugs.gnu.org> List-Help: <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=help> List-Subscribe: <https://debbugs.gnu.org/cgi-bin/mailman/listinfo/debbugs-submit>, <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=subscribe> Errors-To: debbugs-submit-bounces <at> debbugs.gnu.org Sender: "Debbugs-submit" <debbugs-submit-bounces <at> debbugs.gnu.org> X-Spam-Score: -1.7 (-) Stefan Monnier <monnier@HIDDEN> writes: > The "extra args for decustom" are only used when define-minor-mode uses > a defcustom, i.e. only for global minor modes. Yes. But why? :-) -- (domestic pets only, the antidote for overdose, milk.) bloggy blog: http://lars.ingebrigtsen.no
bug-gnu-emacs@HIDDEN:bug#11301; Package emacs.
Full text available.
Received: (at 11301) by debbugs.gnu.org; 3 Jun 2021 13:21:01 +0000
From debbugs-submit-bounces <at> debbugs.gnu.org Thu Jun 03 09:21:01 2021
Received: from localhost ([127.0.0.1]:42886 helo=debbugs.gnu.org)
by debbugs.gnu.org with esmtp (Exim 4.84_2)
(envelope-from <debbugs-submit-bounces <at> debbugs.gnu.org>)
id 1lonHN-0003pW-Gw
for submit <at> debbugs.gnu.org; Thu, 03 Jun 2021 09:21:01 -0400
Received: from mailscanner.iro.umontreal.ca ([132.204.25.50]:61645)
by debbugs.gnu.org with esmtp (Exim 4.84_2)
(envelope-from <monnier@HIDDEN>) id 1lonHI-0003pF-Ay
for 11301 <at> debbugs.gnu.org; Thu, 03 Jun 2021 09:20:56 -0400
Received: from pmg3.iro.umontreal.ca (localhost [127.0.0.1])
by pmg3.iro.umontreal.ca (Proxmox) with ESMTP id 6D12A4407E7;
Thu, 3 Jun 2021 09:20:46 -0400 (EDT)
Received: from mail01.iro.umontreal.ca (unknown [172.31.2.1])
by pmg3.iro.umontreal.ca (Proxmox) with ESMTP id 38F85440803;
Thu, 3 Jun 2021 09:20:45 -0400 (EDT)
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=iro.umontreal.ca;
s=mail; t=1622726445;
bh=MxNXNl3EmaPeAtWF0+84vDSZt9bi8Vq4KKku7e2FBtI=;
h=From:To:Cc:Subject:References:Date:In-Reply-To:From;
b=gejoYWiZ5xGgbDqp29aYBIHs3WZvUlswu5XfHNIsA1LUXWQ2S50vCvtnKlBwY+Y0r
gbJN2nqe9Bjg5T6RxnDjfT32KhxHdZ6jQueYyims5oZHdTHHBSwjWcEEFPiF1aoNrT
OajHMUKVLfeDl0zvf1JyVRsqnxT572wPvsURz63Ch94/6OsYyHjwEAR8gr3Hjm8zaq
HsuusIG1J71zhpV1PnZhCGjwQ4RdP5o++EY+/x1/A42V3ojE3IC0lP5MKEBrLexVIK
1ZoY/mupNVmR7YfLiJW3X32sS3I2Qrm+hdVg7VWmpEOnDi/Bk9CmqSvoPFhlRyDlWX
TIji+pEeDtekQ==
Received: from alfajor (69-196-163-239.dsl.teksavvy.com [69.196.163.239])
by mail01.iro.umontreal.ca (Postfix) with ESMTPSA id 0853B120151;
Thu, 3 Jun 2021 09:20:45 -0400 (EDT)
From: Stefan Monnier <monnier@HIDDEN>
To: Lars Ingebrigtsen <larsi@HIDDEN>
Subject: Re: bug#11301: 24.1.50; `define-minor-mode' should set
`custom-mode-group' according to :group
Message-ID: <jwvfsxz84q7.fsf-monnier+emacs@HIDDEN>
References: <3208B35C4FFE47FFBD0A7029AB2DBB8C@HIDDEN>
<87wnrc7o3p.fsf@HIDDEN> <jwv5yywflpv.fsf-monnier+emacs@HIDDEN>
<874kefbdcx.fsf@HIDDEN>
Date: Thu, 03 Jun 2021 09:20:44 -0400
In-Reply-To: <874kefbdcx.fsf@HIDDEN> (Lars Ingebrigtsen's message of "Thu,
03 Jun 2021 09:45:34 +0200")
User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/28.0.50 (gnu/linux)
MIME-Version: 1.0
Content-Type: text/plain
X-SPAM-INFO: Spam detection results: 0
ALL_TRUSTED -1 Passed through trusted hosts only via SMTP
AWL -0.065 Adjusted score from AWL reputation of From: address
BAYES_00 -1.9 Bayes spam probability is 0 to 1%
DKIM_SIGNED 0.1 Message has a DKIM or DK signature,
not necessarily valid
DKIM_VALID -0.1 Message has at least one valid DKIM or DK signature
DKIM_VALID_AU -0.1 Message has a valid DKIM or DK signature from author's
domain
X-SPAM-LEVEL:
X-Spam-Score: -2.3 (--)
X-Debbugs-Envelope-To: 11301
Cc: 11301 <at> debbugs.gnu.org, Drew Adams <drew.adams@HIDDEN>
X-BeenThere: debbugs-submit <at> debbugs.gnu.org
X-Mailman-Version: 2.1.18
Precedence: list
List-Id: <debbugs-submit.debbugs.gnu.org>
List-Unsubscribe: <https://debbugs.gnu.org/cgi-bin/mailman/options/debbugs-submit>,
<mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=unsubscribe>
List-Archive: <https://debbugs.gnu.org/cgi-bin/mailman/private/debbugs-submit/>
List-Post: <mailto:debbugs-submit <at> debbugs.gnu.org>
List-Help: <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=help>
List-Subscribe: <https://debbugs.gnu.org/cgi-bin/mailman/listinfo/debbugs-submit>,
<mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=subscribe>
Errors-To: debbugs-submit-bounces <at> debbugs.gnu.org
Sender: "Debbugs-submit" <debbugs-submit-bounces <at> debbugs.gnu.org>
X-Spam-Score: -3.3 (---)
Lars Ingebrigtsen [2021-06-03 09:45:34] wrote:
> Stefan Monnier <monnier@HIDDEN> writes:
>> Since the `:group` was only used for the `defcustom`, I just removed
>> this special handling. It doesn't mean it doesn't work any more, but
>> now it's just another one of the keyword args that are simply passed
>> as-is to `defcustom`.
>
> Ah, I see. But it seems like `define-minor-mode' just discards :group
> now. Here's a test case:
The "extra args for decustom" are only used when define-minor-mode uses
a defcustom, i.e. only for global minor modes.
Stefan
bug-gnu-emacs@HIDDEN:bug#11301; Package emacs.
Full text available.
Received: (at 11301) by debbugs.gnu.org; 3 Jun 2021 07:45:48 +0000
From debbugs-submit-bounces <at> debbugs.gnu.org Thu Jun 03 03:45:48 2021
Received: from localhost ([127.0.0.1]:42033 helo=debbugs.gnu.org)
by debbugs.gnu.org with esmtp (Exim 4.84_2)
(envelope-from <debbugs-submit-bounces <at> debbugs.gnu.org>)
id 1loi31-0002UB-Rr
for submit <at> debbugs.gnu.org; Thu, 03 Jun 2021 03:45:48 -0400
Received: from quimby.gnus.org ([95.216.78.240]:39462)
by debbugs.gnu.org with esmtp (Exim 4.84_2)
(envelope-from <larsi@HIDDEN>) id 1loi2z-0002N8-NS
for 11301 <at> debbugs.gnu.org; Thu, 03 Jun 2021 03:45:46 -0400
DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=gnus.org;
s=20200322; h=Content-Type:MIME-Version:Message-ID:In-Reply-To:Date:
References:Subject:Cc:To:From:Sender:Reply-To:Content-Transfer-Encoding:
Content-ID:Content-Description:Resent-Date:Resent-From:Resent-Sender:
Resent-To:Resent-Cc:Resent-Message-ID:List-Id:List-Help:List-Unsubscribe:
List-Subscribe:List-Post:List-Owner:List-Archive;
bh=Gj6stauylHZb4r10PyoJXAr7Tl3mVAVShdWNM31+KLM=; b=fLGUhKcNnu5tIZzcGB/g6kRYTj
o/W6mSpcxl1G5a332JoJs5i+/jeKheW/p/d3mHiias68D6KAVcmEM31u9GRBmhF1RpKhigjQXHg5G
lDaDThC2e0u+ifW67zWT/oLow8JUasffor5GY+ZVg35CBEePeTI8dMEfB7mjK9Q1B7BU=;
Received: from cm-84.212.220.105.getinternet.no ([84.212.220.105] helo=xo)
by quimby.gnus.org with esmtpsa (TLS1.3:ECDHE_RSA_AES_256_GCM_SHA384:256)
(Exim 4.92) (envelope-from <larsi@HIDDEN>)
id 1loi2p-0007vd-FL; Thu, 03 Jun 2021 09:45:38 +0200
From: Lars Ingebrigtsen <larsi@HIDDEN>
To: Stefan Monnier <monnier@HIDDEN>
Subject: Re: bug#11301: 24.1.50; `define-minor-mode' should set
`custom-mode-group' according to :group
References: <3208B35C4FFE47FFBD0A7029AB2DBB8C@HIDDEN>
<87wnrc7o3p.fsf@HIDDEN> <jwv5yywflpv.fsf-monnier+emacs@HIDDEN>
X-Now-Playing: Little Simz's _Grey Area_: "Offence"
Date: Thu, 03 Jun 2021 09:45:34 +0200
In-Reply-To: <jwv5yywflpv.fsf-monnier+emacs@HIDDEN> (Stefan Monnier's message
of "Wed, 02 Jun 2021 09:25:18 -0400")
Message-ID: <874kefbdcx.fsf@HIDDEN>
User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/28.0.50 (gnu/linux)
MIME-Version: 1.0
Content-Type: text/plain
X-Spam-Report: Spam detection software, running on the system "quimby.gnus.org",
has NOT identified this incoming email as spam. The original
message has been attached to this so you can view it or label
similar future email. If you have any questions, see
@@CONTACT_ADDRESS@@ for details.
Content preview: Stefan Monnier <monnier@HIDDEN> writes: > Since
the `:group` was only used for the `defcustom`, I just removed > this special
handling. It doesn't mean it doesn't work any more, but > now it's just another
one of the keyword args that are s [...]
Content analysis details: (-2.9 points, 5.0 required)
pts rule name description
---- ---------------------- --------------------------------------------------
-1.0 ALL_TRUSTED Passed through trusted hosts only via SMTP
-1.9 BAYES_00 BODY: Bayes spam probability is 0 to 1%
[score: 0.0000]
X-Spam-Score: -0.7 (/)
X-Debbugs-Envelope-To: 11301
Cc: 11301 <at> debbugs.gnu.org, Drew Adams <drew.adams@HIDDEN>
X-BeenThere: debbugs-submit <at> debbugs.gnu.org
X-Mailman-Version: 2.1.18
Precedence: list
List-Id: <debbugs-submit.debbugs.gnu.org>
List-Unsubscribe: <https://debbugs.gnu.org/cgi-bin/mailman/options/debbugs-submit>,
<mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=unsubscribe>
List-Archive: <https://debbugs.gnu.org/cgi-bin/mailman/private/debbugs-submit/>
List-Post: <mailto:debbugs-submit <at> debbugs.gnu.org>
List-Help: <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=help>
List-Subscribe: <https://debbugs.gnu.org/cgi-bin/mailman/listinfo/debbugs-submit>,
<mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=subscribe>
Errors-To: debbugs-submit-bounces <at> debbugs.gnu.org
Sender: "Debbugs-submit" <debbugs-submit-bounces <at> debbugs.gnu.org>
X-Spam-Score: -1.7 (-)
Stefan Monnier <monnier@HIDDEN> writes:
> Since the `:group` was only used for the `defcustom`, I just removed
> this special handling. It doesn't mean it doesn't work any more, but
> now it's just another one of the keyword args that are simply passed
> as-is to `defcustom`.
Ah, I see. But it seems like `define-minor-mode' just discards :group
now. Here's a test case:
(define-minor-mode foo-mode "doc" :group 'mouse)
Since this isn't a global minor mode, we end up in this branch:
((not globalp)
`(progn
:autoload-end
(defvar-local ,mode ,init-value
,(concat (format "Non-nil if %s is enabled.\n" pretty-name)
(internal--format-docstring-line
"Use the command `%s' to change this variable." mode)))))
and :group (which ends up in `extra-keywords') isn't used. Should this
instead use `defcustom' with :local t? I.e., basically merge with the
global case in that cond?
--
(domestic pets only, the antidote for overdose, milk.)
bloggy blog: http://lars.ingebrigtsen.no
bug-gnu-emacs@HIDDEN:bug#11301; Package emacs.
Full text available.
Received: (at 11301) by debbugs.gnu.org; 2 Jun 2021 13:25:28 +0000
From debbugs-submit-bounces <at> debbugs.gnu.org Wed Jun 02 09:25:28 2021
Received: from localhost ([127.0.0.1]:39250 helo=debbugs.gnu.org)
by debbugs.gnu.org with esmtp (Exim 4.84_2)
(envelope-from <debbugs-submit-bounces <at> debbugs.gnu.org>)
id 1loQsC-0000s7-9p
for submit <at> debbugs.gnu.org; Wed, 02 Jun 2021 09:25:28 -0400
Received: from mailscanner.iro.umontreal.ca ([132.204.25.50]:32424)
by debbugs.gnu.org with esmtp (Exim 4.84_2)
(envelope-from <monnier@HIDDEN>) id 1loQsA-0000rt-BD
for 11301 <at> debbugs.gnu.org; Wed, 02 Jun 2021 09:25:26 -0400
Received: from pmg2.iro.umontreal.ca (localhost.localdomain [127.0.0.1])
by pmg2.iro.umontreal.ca (Proxmox) with ESMTP id EF924806A5;
Wed, 2 Jun 2021 09:25:20 -0400 (EDT)
Received: from mail01.iro.umontreal.ca (unknown [172.31.2.1])
by pmg2.iro.umontreal.ca (Proxmox) with ESMTP id 7E55A80497;
Wed, 2 Jun 2021 09:25:19 -0400 (EDT)
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=iro.umontreal.ca;
s=mail; t=1622640319;
bh=/y37IhGWeMALsDhVfS08rOFMmar9IIxv06ZnfrVuHw0=;
h=From:To:Cc:Subject:References:Date:In-Reply-To:From;
b=D23SfQ6G8idpItBUy4LaVbH+X6la45H8nefKnr1xTD5cLIQIwT61tBkwXr0FWv/YN
lOfqZ3oDRRpVcxSlaFyHB8rtzcnCvULeZ4nRHM6iMcL9EQ8yW3q1ZLvgwANWxyHzN2
zY83Cn6Fxqb7oUSMoaIxat0N22ofbJw4A+k+jNGOhs6VINE855R7TbK3sLrcVSjTeY
bLuh2X7lGS6U5Je/Xky+8EGX3NXmQWna5XLU7QO97gIzHkM/V5Yn2mqdmcbEBAXEI1
Mx/SHRnMXLW/yvls50SwqcDIs1KsI7LV4wpI89a1lnO7G4XNz36rIrxqLaYp+C2tF4
ejqTklP12ocLA==
Received: from alfajor (69-196-163-239.dsl.teksavvy.com [69.196.163.239])
by mail01.iro.umontreal.ca (Postfix) with ESMTPSA id 33A1812023C;
Wed, 2 Jun 2021 09:25:19 -0400 (EDT)
From: Stefan Monnier <monnier@HIDDEN>
To: Lars Ingebrigtsen <larsi@HIDDEN>
Subject: Re: bug#11301: 24.1.50; `define-minor-mode' should set
`custom-mode-group' according to :group
Message-ID: <jwv5yywflpv.fsf-monnier+emacs@HIDDEN>
References: <3208B35C4FFE47FFBD0A7029AB2DBB8C@HIDDEN>
<87wnrc7o3p.fsf@HIDDEN>
Date: Wed, 02 Jun 2021 09:25:18 -0400
In-Reply-To: <87wnrc7o3p.fsf@HIDDEN> (Lars Ingebrigtsen's message of "Wed,
02 Jun 2021 08:54:50 +0200")
User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/28.0.50 (gnu/linux)
MIME-Version: 1.0
Content-Type: text/plain
X-SPAM-INFO: Spam detection results: 0
ALL_TRUSTED -1 Passed through trusted hosts only via SMTP
AWL -0.052 Adjusted score from AWL reputation of From: address
BAYES_00 -1.9 Bayes spam probability is 0 to 1%
DKIM_SIGNED 0.1 Message has a DKIM or DK signature,
not necessarily valid
DKIM_VALID -0.1 Message has at least one valid DKIM or DK signature
DKIM_VALID_AU -0.1 Message has a valid DKIM or DK signature from author's
domain
X-SPAM-LEVEL:
X-Spam-Score: -2.3 (--)
X-Debbugs-Envelope-To: 11301
Cc: 11301 <at> debbugs.gnu.org, Drew Adams <drew.adams@HIDDEN>
X-BeenThere: debbugs-submit <at> debbugs.gnu.org
X-Mailman-Version: 2.1.18
Precedence: list
List-Id: <debbugs-submit.debbugs.gnu.org>
List-Unsubscribe: <https://debbugs.gnu.org/cgi-bin/mailman/options/debbugs-submit>,
<mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=unsubscribe>
List-Archive: <https://debbugs.gnu.org/cgi-bin/mailman/private/debbugs-submit/>
List-Post: <mailto:debbugs-submit <at> debbugs.gnu.org>
List-Help: <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=help>
List-Subscribe: <https://debbugs.gnu.org/cgi-bin/mailman/listinfo/debbugs-submit>,
<mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=subscribe>
Errors-To: debbugs-submit-bounces <at> debbugs.gnu.org
Sender: "Debbugs-submit" <debbugs-submit-bounces <at> debbugs.gnu.org>
X-Spam-Score: -3.3 (---)
> I've tried following the logic and history of the :group keyword in
> easy-mmode.el, and I'm not sure how that's supposed to work any more.
>
> `define-minor-mode' used to document taking a :group keyword, but that's
> been removed in:
Yes, it tried to be clever and guess the `:group` arg when none was
provided, but that guess was worse than the defaulting used by
`defcustom`.
Since the `:group` was only used for the `defcustom`, I just removed
this special handling. It doesn't mean it doesn't work any more, but
now it's just another one of the keyword args that are simply passed
as-is to `defcustom`.
So this has no direct impact on whether or not `define-minor-mode`
should register the mode for use in `customize-mode` (which sounds like
a good idea).
Stefan
bug-gnu-emacs@HIDDEN:bug#11301; Package emacs.
Full text available.
Received: (at 11301) by debbugs.gnu.org; 2 Jun 2021 06:55:05 +0000
From debbugs-submit-bounces <at> debbugs.gnu.org Wed Jun 02 02:55:05 2021
Received: from localhost ([127.0.0.1]:38526 helo=debbugs.gnu.org)
by debbugs.gnu.org with esmtp (Exim 4.84_2)
(envelope-from <debbugs-submit-bounces <at> debbugs.gnu.org>)
id 1loKmP-0004Ds-6m
for submit <at> debbugs.gnu.org; Wed, 02 Jun 2021 02:55:05 -0400
Received: from quimby.gnus.org ([95.216.78.240]:54264)
by debbugs.gnu.org with esmtp (Exim 4.84_2)
(envelope-from <larsi@HIDDEN>) id 1loKmN-0004DJ-0a
for 11301 <at> debbugs.gnu.org; Wed, 02 Jun 2021 02:55:03 -0400
DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=gnus.org;
s=20200322; h=Content-Type:MIME-Version:Message-ID:In-Reply-To:Date:
References:Subject:Cc:To:From:Sender:Reply-To:Content-Transfer-Encoding:
Content-ID:Content-Description:Resent-Date:Resent-From:Resent-Sender:
Resent-To:Resent-Cc:Resent-Message-ID:List-Id:List-Help:List-Unsubscribe:
List-Subscribe:List-Post:List-Owner:List-Archive;
bh=KUwWSBkYzHPvHuNrFdZ+Rlw44NGn6Q2i7LV2BtDiIGY=; b=jUo9HPxhh8z2XNsPSl4bcR58f6
IF5pBbTO0uHIXdVlOTcOffx02NRmTxFIoUHxGdusd4+HiQgVpjDksL1UDh2WRadPkUfQ61plTvDFS
fuZBbpkwlVYcLh+Gw9B2WD1lVIXCek5ySTODuNf/hzlhQD9M3OcePegQyPk3Z435ex28=;
Received: from cm-84.212.220.105.getinternet.no ([84.212.220.105] helo=xo)
by quimby.gnus.org with esmtpsa (TLS1.3:ECDHE_RSA_AES_256_GCM_SHA384:256)
(Exim 4.92) (envelope-from <larsi@HIDDEN>)
id 1loKmD-0002uo-96; Wed, 02 Jun 2021 08:54:55 +0200
From: Lars Ingebrigtsen <larsi@HIDDEN>
To: "Drew Adams" <drew.adams@HIDDEN>
Subject: Re: bug#11301: 24.1.50; `define-minor-mode' should set
`custom-mode-group' according to :group
References: <3208B35C4FFE47FFBD0A7029AB2DBB8C@HIDDEN>
X-Now-Playing: Ana Roxanne's _Ana Roxanne_: "Slowness"
Date: Wed, 02 Jun 2021 08:54:50 +0200
In-Reply-To: <3208B35C4FFE47FFBD0A7029AB2DBB8C@HIDDEN> (Drew Adams's
message of "Sat, 21 Apr 2012 10:18:34 -0700")
Message-ID: <87wnrc7o3p.fsf@HIDDEN>
User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/28.0.50 (gnu/linux)
MIME-Version: 1.0
Content-Type: text/plain
X-Spam-Report: Spam detection software, running on the system "quimby.gnus.org",
has NOT identified this incoming email as spam. The original
message has been attached to this so you can view it or label
similar future email. If you have any questions, see
@@CONTACT_ADDRESS@@ for details.
Content preview: "Drew Adams" <drew.adams@HIDDEN> writes: > My suggestion
is for `define-minor-mode' - and perhaps other > mode-defining macros - to
do likewise. `define-minor-mode' apparently > uses the :group keyword only
for defining the user options it d [...]
Content analysis details: (-2.9 points, 5.0 required)
pts rule name description
---- ---------------------- --------------------------------------------------
-1.0 ALL_TRUSTED Passed through trusted hosts only via SMTP
-1.9 BAYES_00 BODY: Bayes spam probability is 0 to 1%
[score: 0.0000]
X-Spam-Score: -0.7 (/)
X-Debbugs-Envelope-To: 11301
Cc: 11301 <at> debbugs.gnu.org, monnier@HIDDEN
X-BeenThere: debbugs-submit <at> debbugs.gnu.org
X-Mailman-Version: 2.1.18
Precedence: list
List-Id: <debbugs-submit.debbugs.gnu.org>
List-Unsubscribe: <https://debbugs.gnu.org/cgi-bin/mailman/options/debbugs-submit>,
<mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=unsubscribe>
List-Archive: <https://debbugs.gnu.org/cgi-bin/mailman/private/debbugs-submit/>
List-Post: <mailto:debbugs-submit <at> debbugs.gnu.org>
List-Help: <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=help>
List-Subscribe: <https://debbugs.gnu.org/cgi-bin/mailman/listinfo/debbugs-submit>,
<mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=subscribe>
Errors-To: debbugs-submit-bounces <at> debbugs.gnu.org
Sender: "Debbugs-submit" <debbugs-submit-bounces <at> debbugs.gnu.org>
X-Spam-Score: -1.7 (-)
"Drew Adams" <drew.adams@HIDDEN> writes:
> My suggestion is for `define-minor-mode' - and perhaps other
> mode-defining macros - to do likewise. `define-minor-mode' apparently
> uses the :group keyword only for defining the user options it defines.
I've tried following the logic and history of the :group keyword in
easy-mmode.el, and I'm not sure how that's supposed to work any more.
`define-minor-mode' used to document taking a :group keyword, but that's
been removed in:
commit 6e7736ac5f42e2f1b17aacdfb2a60d8bb951d038
Author: Stefan Monnier <monnier@HIDDEN>
AuthorDate: Wed Sep 9 13:29:59 2020 -0400
The only remaining mention is in this example:
For example, you could write
(define-minor-mode foo-mode \"If enabled, foo on you!\"
:lighter \" Foo\" :require \\='foo :global t :group \\='hassle :version \"27.5\"
...BODY CODE...)
`define-globalized-minor-mode' does mention it, though, and passes it on
to `define-minor-mode'... which doesn't use it?
I've added Stefan to the CCs; I'm sure he knows what's going on.
--
(domestic pets only, the antidote for overdose, milk.)
bloggy blog: http://lars.ingebrigtsen.no
bug-gnu-emacs@HIDDEN:bug#11301; Package emacs.
Full text available.Received: (at 11301) by debbugs.gnu.org; 21 Apr 2012 17:49:51 +0000 From debbugs-submit-bounces <at> debbugs.gnu.org Sat Apr 21 13:49:51 2012 Received: from localhost ([127.0.0.1]:45937 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.72) (envelope-from <debbugs-submit-bounces <at> debbugs.gnu.org>) id 1SLeRS-0006Hz-Ln for submit <at> debbugs.gnu.org; Sat, 21 Apr 2012 13:49:51 -0400 Received: from rcsinet15.oracle.com ([148.87.113.117]:36874) by debbugs.gnu.org with esmtp (Exim 4.72) (envelope-from <drew.adams@HIDDEN>) id 1SLeRN-0006HW-GB for 11301 <at> debbugs.gnu.org; Sat, 21 Apr 2012 13:49:46 -0400 Received: from acsinet22.oracle.com (acsinet22.oracle.com [141.146.126.238]) by rcsinet15.oracle.com (Sentrion-MTA-4.2.2/Sentrion-MTA-4.2.2) with ESMTP id q3LHn7ws021231 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-SHA bits=256 verify=OK) for <11301 <at> debbugs.gnu.org>; Sat, 21 Apr 2012 17:49:08 GMT Received: from acsmt356.oracle.com (acsmt356.oracle.com [141.146.40.156]) by acsinet22.oracle.com (8.14.4+Sun/8.14.4) with ESMTP id q3LHn7De002075 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-SHA bits=256 verify=NO) for <11301 <at> debbugs.gnu.org>; Sat, 21 Apr 2012 17:49:07 GMT Received: from abhmt107.oracle.com (abhmt107.oracle.com [141.146.116.59]) by acsmt356.oracle.com (8.12.11.20060308/8.12.11) with ESMTP id q3LHn6Bu012387 for <11301 <at> debbugs.gnu.org>; Sat, 21 Apr 2012 12:49:06 -0500 Received: from dradamslap1 (/10.159.63.181) by default (Oracle Beehive Gateway v4.0) with ESMTP ; Sat, 21 Apr 2012 10:49:06 -0700 From: "Drew Adams" <drew.adams@HIDDEN> To: <11301 <at> debbugs.gnu.org> References: <3208B35C4FFE47FFBD0A7029AB2DBB8C@HIDDEN> Subject: RE: bug#11301: 24.1.50; `define-minor-mode' should set `custom-mode-group' according to :group Date: Sat, 21 Apr 2012 10:48:59 -0700 Message-ID: <EFD781E4B0784FB28C5D3D6B855D743A@HIDDEN> MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit X-Mailer: Microsoft Office Outlook 11 In-Reply-To: <3208B35C4FFE47FFBD0A7029AB2DBB8C@HIDDEN> Thread-Index: Ac0f4shWQLNdAJ0/SxWaZVdeS5iMoQAAYosQ X-MimeOLE: Produced By Microsoft MimeOLE V6.00.2900.6157 X-Source-IP: acsinet22.oracle.com [141.146.126.238] X-Auth-Type: Internal IP X-CT-RefId: str=0001.0A090208.4F92F314.0062,ss=1,re=0.000,fgs=0 X-Spam-Score: -6.9 (------) X-Debbugs-Envelope-To: 11301 X-BeenThere: debbugs-submit <at> debbugs.gnu.org X-Mailman-Version: 2.1.13 Precedence: list List-Id: <debbugs-submit.debbugs.gnu.org> List-Unsubscribe: <http://debbugs.gnu.org/cgi-bin/mailman/options/debbugs-submit>, <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=unsubscribe> List-Archive: <http://debbugs.gnu.org/cgi-bin/mailman/private/debbugs-submit> List-Post: <mailto:debbugs-submit <at> debbugs.gnu.org> List-Help: <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=help> List-Subscribe: <http://debbugs.gnu.org/cgi-bin/mailman/listinfo/debbugs-submit>, <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=subscribe> Sender: debbugs-submit-bounces <at> debbugs.gnu.org Errors-To: debbugs-submit-bounces <at> debbugs.gnu.org X-Spam-Score: -6.9 (------) OK, so I looked a bit further. For major or minor mode `foo-mode': `custom-group-of-mode' checks for property `custom-mode-group' on the symbol `foo-mode'. Lacking that, it checks for property `custom-group' on the same symbol. Lacking that, it checks for `custom-group' on symbol `foo'. So if we look at `icomplete-mode', which is defined using `define-minor-mode' specifying :group as `icomplete': (custom-group-of-mode 'icomplete-mode) returns non-nil, because symbol `icomplete' gets property `custom-group'. Where does that come from? It seems to come from the :group. But the :group value is not applied as property `custom-group' to the _mode_ symbol. It is applied only to the :group value itself. E.g., with :group 'Foo, property `custom-group' is applied to the symbol `Foo' but not (also) to the mode name `foo-mode' or even `foo'. So if you use as the :group value something that is not _identical_ to the mode-function symbol (or that minus `-mode'), then `custom-group-of-mode' does not work. Its attempt to find the mode's group is too limited. If you use :group 'Foo or :group 'Foos, you are out of luck. You must use :group 'foo for `foo-mode' to be recognized by `custom-group-of-mode'. (And no such limitations are documented.) Please DTRT: pick up whatever :group specifies as the group and include it in the value of property `custom-group' for the mode name.
bug-gnu-emacs@HIDDEN:bug#11301; Package emacs.
Full text available.Received: (at submit) by debbugs.gnu.org; 21 Apr 2012 17:19:31 +0000 From debbugs-submit-bounces <at> debbugs.gnu.org Sat Apr 21 13:19:31 2012 Received: from localhost ([127.0.0.1]:45914 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.72) (envelope-from <debbugs-submit-bounces <at> debbugs.gnu.org>) id 1SLdy7-0005Zq-Ch for submit <at> debbugs.gnu.org; Sat, 21 Apr 2012 13:19:31 -0400 Received: from eggs.gnu.org ([208.118.235.92]:44131) by debbugs.gnu.org with esmtp (Exim 4.72) (envelope-from <drew.adams@HIDDEN>) id 1SLdy4-0005Zc-A8 for submit <at> debbugs.gnu.org; Sat, 21 Apr 2012 13:19:29 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from <drew.adams@HIDDEN>) id 1SLdxR-0004qI-Qi for submit <at> debbugs.gnu.org; Sat, 21 Apr 2012 13:18:51 -0400 X-Spam-Checker-Version: SpamAssassin 3.3.2 (2011-06-06) on eggs.gnu.org X-Spam-Level: X-Spam-Status: No, score=-6.9 required=5.0 tests=BAYES_00,RCVD_IN_DNSWL_HI, UNPARSEABLE_RELAY autolearn=unavailable version=3.3.2 Received: from lists.gnu.org ([208.118.235.17]:55650) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from <drew.adams@HIDDEN>) id 1SLdxR-0004qE-N4 for submit <at> debbugs.gnu.org; Sat, 21 Apr 2012 13:18:49 -0400 Received: from eggs.gnu.org ([208.118.235.92]:50844) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from <drew.adams@HIDDEN>) id 1SLdxP-0001R6-SA for bug-gnu-emacs@HIDDEN; Sat, 21 Apr 2012 13:18:49 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from <drew.adams@HIDDEN>) id 1SLdxN-0004pb-UC for bug-gnu-emacs@HIDDEN; Sat, 21 Apr 2012 13:18:47 -0400 Received: from rcsinet15.oracle.com ([148.87.113.117]:44594) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from <drew.adams@HIDDEN>) id 1SLdxN-0004pK-Nb for bug-gnu-emacs@HIDDEN; Sat, 21 Apr 2012 13:18:45 -0400 Received: from ucsinet22.oracle.com (ucsinet22.oracle.com [156.151.31.94]) by rcsinet15.oracle.com (Sentrion-MTA-4.2.2/Sentrion-MTA-4.2.2) with ESMTP id q3LHIgw3004617 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-SHA bits=256 verify=OK) for <bug-gnu-emacs@HIDDEN>; Sat, 21 Apr 2012 17:18:43 GMT Received: from acsmt357.oracle.com (acsmt357.oracle.com [141.146.40.157]) by ucsinet22.oracle.com (8.14.4+Sun/8.14.4) with ESMTP id q3LHIfTA017228 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-SHA bits=256 verify=NO) for <bug-gnu-emacs@HIDDEN>; Sat, 21 Apr 2012 17:18:42 GMT Received: from abhmt103.oracle.com (abhmt103.oracle.com [141.146.116.55]) by acsmt357.oracle.com (8.12.11.20060308/8.12.11) with ESMTP id q3LHIfwK005526 for <bug-gnu-emacs@HIDDEN>; Sat, 21 Apr 2012 12:18:41 -0500 Received: from dradamslap1 (/10.159.63.181) by default (Oracle Beehive Gateway v4.0) with ESMTP ; Sat, 21 Apr 2012 10:18:41 -0700 From: "Drew Adams" <drew.adams@HIDDEN> To: <bug-gnu-emacs@HIDDEN> Subject: 24.1.50; `define-minor-mode' should set `custom-mode-group' according to :group Date: Sat, 21 Apr 2012 10:18:34 -0700 Message-ID: <3208B35C4FFE47FFBD0A7029AB2DBB8C@HIDDEN> MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit X-Mailer: Microsoft Office Outlook 11 Thread-Index: Ac0f4shWQLNdAJ0/SxWaZVdeS5iMoQ== X-MimeOLE: Produced By Microsoft MimeOLE V6.00.2900.6157 X-Source-IP: ucsinet22.oracle.com [156.151.31.94] X-CT-RefId: str=0001.0A090202.4F92EBF3.0049,ss=1,re=0.000,fgs=0 X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.6 (newer, 1) X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.6 (newer, 3) X-Received-From: 208.118.235.17 X-Spam-Score: -6.1 (------) X-Debbugs-Envelope-To: submit X-BeenThere: debbugs-submit <at> debbugs.gnu.org X-Mailman-Version: 2.1.13 Precedence: list List-Id: <debbugs-submit.debbugs.gnu.org> List-Unsubscribe: <http://debbugs.gnu.org/cgi-bin/mailman/options/debbugs-submit>, <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=unsubscribe> List-Archive: <http://debbugs.gnu.org/cgi-bin/mailman/private/debbugs-submit> List-Post: <mailto:debbugs-submit <at> debbugs.gnu.org> List-Help: <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=help> List-Subscribe: <http://debbugs.gnu.org/cgi-bin/mailman/listinfo/debbugs-submit>, <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=subscribe> Sender: debbugs-submit-bounces <at> debbugs.gnu.org Errors-To: debbugs-submit-bounces <at> debbugs.gnu.org X-Spam-Score: -6.1 (------) I just started to look at this, so forgive me if I am missing something. `define-derived-mode' picks up the :group keyword and uses it, among other things, to do this: (put ',child 'custom-mode-group ,group), that is, to declare the group as the custom-mode-group for the new mode. My suggestion is for `define-minor-mode' - and perhaps other mode-defining macros - to do likewise. `define-minor-mode' apparently uses the :group keyword only for defining the user options it defines. As it stands today, you can define a minor mode `foo' using `define-minor-mode', and then try `C-u customize-mode, but `foo' will not appear as a possible completion, because neither property `custom-mode-group' nor property `custom-group' has been applied to the symbol `foo'. This is too bad. Grepping for `custom-mode-group' shows that it is applied _only_ in `define-derived-mode', and it is used _only_ in `custom-group-of-mode', which in turn is used _only_ in `customize-mode'. Grepping for `custom-group' and filtering a bit, my impression is that that property is put on symbols only by `custom-add-to-group'. And grepping for `custom-add-to-group', it is not too clear where `custom-group' is put on symbols. Things like `custom-declare-variable' do so, but is that used by `defcustom' or does `defcustom' do likewise? In any case, I do not see a `custom-group' property on any of the user options or faces I have defined using `defcustom' and `defface'. Likewise, for the options defined by `define-minor-mode'. So what's the story here? Does `customize-mode' work only for derived modes? If so, why? Can we please DTRT so that it works (e.g. with a prefix arg) for any major or minor mode with a clearly identified :group? See related bug #11299. Please do what it takes to have major and minor modes - at least those clearly recognizable as such via `define-minor-mode' etc. and that clearly have a defined :group - be assigned the property `custom-mode-group' (or `custom-group'), so that `custom-group-of-mode' recognizes them. In GNU Emacs 24.1.50.1 (i386-mingw-nt5.1.2600) of 2012-04-19 on MARVIN Bzr revision: 107968 monnier@HIDDEN Windowing system distributor `Microsoft Corp.', version 5.1.2600 Configured using: `configure --with-gcc (4.6) --no-opt --enable-checking --cflags -ID:/devel/emacs/libs/libXpm-3.5.8/include -ID:/devel/emacs/libs/libXpm-3.5.8/src -ID:/devel/emacs/libs/libpng-dev_1.4.3-1/include -ID:/devel/emacs/libs/zlib-dev_1.2.5-2/include -ID:/devel/emacs/libs/giflib-4.1.4-1/include -ID:/devel/emacs/libs/jpeg-6b-4/include -ID:/devel/emacs/libs/tiff-3.8.2-1/include -ID:/devel/emacs/libs/gnutls-3.0.9/include -ID:/devel/emacs/libs/libiconv-1.13.1-1-dev/include -ID:/devel/emacs/libs/libxml2-2.7.8/include/libxml2'
"Drew Adams" <drew.adams@HIDDEN>:bug-gnu-emacs@HIDDEN.
Full text available.bug-gnu-emacs@HIDDEN:bug#11301; Package emacs.
Full text available.
GNU bug tracking system
Copyright (C) 1999 Darren O. Benham,
1997 nCipher Corporation Ltd,
1994-97 Ian Jackson.