GNU bug report logs - #11549
auto-revert doesn't revert file permissions as revert-buffer does

Previous Next

Package: emacs;

Reported by: Barry OReilly <gundaetiapo <at> gmail.com>

Date: Wed, 23 May 2012 23:58:02 UTC

Severity: wishlist

Tags: moreinfo

Merged with 11412

Found in version 24.0.95

Done: Lars Ingebrigtsen <larsi <at> gnus.org>

Bug is archived. No further changes may be made.

To add a comment to this bug, you must first unarchive it, by sending
a message to control AT debbugs.gnu.org, with unarchive 11549 in the body.
You can then email your comments to 11549 AT debbugs.gnu.org in the normal way.

Toggle the display of automated, internal messages from the tracker.

View this report as an mbox folder, status mbox, maintainer mbox


Report forwarded to bug-gnu-emacs <at> gnu.org:
bug#11549; Package emacs. (Wed, 23 May 2012 23:58:02 GMT) Full text and rfc822 format available.

Acknowledgement sent to Barry OReilly <gundaetiapo <at> gmail.com>:
New bug report received and forwarded. Copy sent to bug-gnu-emacs <at> gnu.org. (Wed, 23 May 2012 23:58:02 GMT) Full text and rfc822 format available.

Message #5 received at submit <at> debbugs.gnu.org (full text, mbox):

From: Barry OReilly <gundaetiapo <at> gmail.com>
To: bug-gnu-emacs <at> gnu.org
Subject: auto-revert doesn't revert file permissions as revert-buffer does
Date: Wed, 23 May 2012 19:40:08 -0400
To reproduce this bug minimally:

Use a .emacs with only:
(global-auto-revert-mode 1)
(setq revert-without-query (quote (".*")))

Create foo.py:
# aaa
# bbb

Set permissions on foo.py:
-r-xr-xr--  1 boreilly ccgoesr        13 May 22 09:12 foo.py

Open foo.py in Emacs.

In a terminal:
chmod u+w foo.py

Wait several seconds, inserting text yields error:
Buffer is read-only: #<buffer foo.py>

Open foo.py with vim and add text:
# aaa blah
# bbb

The blah string appears in Emacs.  Insertion still fails with error:
Buffer is read-only: #<buffer foo.py>

Do: M-x revert-buffer

Insertion now works.

I would think if revert-buffer updates permissions that auto-revert would too.

An information dump from report-emacs-bug follows.

In GNU Emacs 23.4.1 (x86_64-unknown-linux-gnu, GTK+ Version 2.10.4)
 of 2012-03-19 on [cut]
Windowing system distributor `The X.Org Foundation', version 11.0.70101000
configured using `configure  '--prefix=[cut]/sw/emacs-install' '--with-gif=no''

Important settings:
  value of $LC_ALL: nil
  value of $LC_COLLATE: nil
  value of $LC_CTYPE: nil
  value of $LC_MESSAGES: nil
  value of $LC_MONETARY: nil
  value of $LC_NUMERIC: nil
  value of $LC_TIME: nil
  value of $LANG: en_US.UTF-8
  value of $XMODIFIERS: @im=none
  locale-coding-system: utf-8-unix
  default enable-multibyte-characters: t

Major mode: Python

Minor modes in effect:
  global-auto-revert-mode: t
  tooltip-mode: t
  mouse-wheel-mode: t
  tool-bar-mode: t
  menu-bar-mode: t
  file-name-shadow-mode: t
  global-font-lock-mode: t
  font-lock-mode: t
  blink-cursor-mode: t
  auto-encryption-mode: t
  auto-compression-mode: t
  line-number-mode: t
  transient-mark-mode: t

Recent input:
<help-echo> <help-echo> <down> <down> <down> i <help-echo>
<help-echo> <down-mouse-1> <drag-mouse-1> <down-mouse-1>
<mouse-movement> <mouse-movement> <drag-mouse-1> <help-echo>
<down-mouse-1> <mouse-1> M-x r e p o r t - e m a c
s - b u g <return>

Recent messages:
For information about GNU Emacs and the GNU system, type C-h C-a.
Note: file is write protected
Buffer is read-only: #<buffer foo.py>

Load-path shadows:
None found.

Features:
(shadow sort mail-extr message sendmail regexp-opt ecomplete rfc822 mml
mml-sec password-cache mm-decode mm-bodies mm-encode mailcap mail-parse
rfc2231 rfc2047 rfc2045 qp ietf-drums mailabbrev nnheader gnus-util
netrc time-date mm-util mail-prsvr gmm-utils wid-edit mailheader canlock
sha1 hex-util hashcash mail-utils emacsbug python-21 python easymenu
comint ring autorevert tooltip ediff-hook vc-hooks lisp-float-type
mwheel x-win x-dnd font-setting tool-bar dnd fontset image fringe
lisp-mode register page menu-bar rfn-eshadow timer select scroll-bar
mldrag mouse jit-lock font-lock syntax facemenu font-core frame cham
georgian utf-8-lang misc-lang vietnamese tibetan thai tai-viet lao
korean japanese hebrew greek romanian slovak czech european ethiopic
indian cyrillic chinese case-table epa-hook jka-cmpr-hook help simple
abbrev loaddefs button minibuffer faces cus-face files text-properties
overlay md5 base64 format env code-pages mule custom widget
hashtable-print-readable backquote make-network-process dbusbind
system-font-setting font-render-setting gtk x-toolkit x multi-tty emacs)




Forcibly Merged 11412 11549. Request was from Glenn Morris <rgm <at> gnu.org> to control <at> debbugs.gnu.org. (Thu, 24 May 2012 00:19:01 GMT) Full text and rfc822 format available.

Information forwarded to bug-gnu-emacs <at> gnu.org:
bug#11549; Package emacs. (Wed, 02 Jun 2021 06:25:02 GMT) Full text and rfc822 format available.

Message #10 received at 11549 <at> debbugs.gnu.org (full text, mbox):

From: Lars Ingebrigtsen <larsi <at> gnus.org>
To: Barry OReilly <gundaetiapo <at> gmail.com>
Cc: 11412 <at> debbugs.gnu.org, 11549 <at> debbugs.gnu.org
Subject: Re: bug#11412: 24.0.95; auto-revert-mode doesn't revert buffer when
 file becomes writeable
Date: Wed, 02 Jun 2021 08:24:02 +0200
Barry OReilly <gundaetiapo <at> gmail.com> writes:

> Open foo.py in Emacs.
>
> In a terminal:
> chmod u+w foo.py
>
> Wait several seconds, inserting text yields error:
> Buffer is read-only: #<buffer foo.py>

(I'm going through old bug reports that unfortunately got no response at
the time.)

This has been fixed in the years since this was reported.

> Open foo.py with vim and add text:
> # aaa blah
> # bbb
>
> The blah string appears in Emacs.  Insertion still fails with error:
> Buffer is read-only: #<buffer foo.py>
>
> Do: M-x revert-buffer
>
> Insertion now works.

This is apparently a feature added in 2004:

commit 90e118abf2dcc4aca4d7a7642247fa488554351e
Author:     Luc Teirlinck <teirllm <at> auburn.edu>
AuthorDate: Fri Sep 3 22:28:10 2004 +0000

        ;; Bind buffer-read-only in case user has done C-x C-q, so as
        ;; not to forget that.  This gives undesirable results when
        ;; the file's mode changes, but that is less common.
        (let ((buffer-read-only buffer-read-only))
           ...
            (revert-buffer 'ignore-auto 'dont-ask 'preserve-modes))))

So auto-reversion doesn't touch the buffer-readedness in case the user
has set it manually.  So I'm not sure whether we should change this
behaviour here.  Anybody got an opinion?

-- 
(domestic pets only, the antidote for overdose, milk.)
   bloggy blog: http://lars.ingebrigtsen.no




Added tag(s) moreinfo. Request was from Lars Ingebrigtsen <larsi <at> gnus.org> to control <at> debbugs.gnu.org. (Wed, 02 Jun 2021 06:25:02 GMT) Full text and rfc822 format available.

Information forwarded to bug-gnu-emacs <at> gnu.org:
bug#11549; Package emacs. (Fri, 02 Jul 2021 11:19:02 GMT) Full text and rfc822 format available.

Message #15 received at 11549 <at> debbugs.gnu.org (full text, mbox):

From: Lars Ingebrigtsen <larsi <at> gnus.org>
To: Barry OReilly <gundaetiapo <at> gmail.com>
Cc: 11412 <at> debbugs.gnu.org, 11549 <at> debbugs.gnu.org
Subject: Re: bug#11412: 24.0.95; auto-revert-mode doesn't revert buffer when
 file becomes writeable
Date: Fri, 02 Jul 2021 13:17:54 +0200
Lars Ingebrigtsen <larsi <at> gnus.org> writes:

> This is apparently a feature added in 2004:
>
> commit 90e118abf2dcc4aca4d7a7642247fa488554351e
> Author:     Luc Teirlinck <teirllm <at> auburn.edu>
> AuthorDate: Fri Sep 3 22:28:10 2004 +0000
>
>         ;; Bind buffer-read-only in case user has done C-x C-q, so as
>         ;; not to forget that.  This gives undesirable results when
>         ;; the file's mode changes, but that is less common.
>         (let ((buffer-read-only buffer-read-only))
>            ...
>             (revert-buffer 'ignore-auto 'dont-ask 'preserve-modes))))
>
> So auto-reversion doesn't touch the buffer-readedness in case the user
> has set it manually.  So I'm not sure whether we should change this
> behaviour here.  Anybody got an opinion?

Nobody had an opinion, and I think this is working as designed, and I'm
closing this bug report.  If I misunderstood the issue, please respond
to the debbugs address and we'll reopen.

-- 
(domestic pets only, the antidote for overdose, milk.)
   bloggy blog: http://lars.ingebrigtsen.no




bug closed, send any further explanations to 11412 <at> debbugs.gnu.org and Eric Hanchrow <eric.hanchrow <at> gmail.com> Request was from Lars Ingebrigtsen <larsi <at> gnus.org> to control <at> debbugs.gnu.org. (Fri, 02 Jul 2021 11:19:03 GMT) Full text and rfc822 format available.

bug archived. Request was from Debbugs Internal Request <help-debbugs <at> gnu.org> to internal_control <at> debbugs.gnu.org. (Fri, 30 Jul 2021 11:24:05 GMT) Full text and rfc822 format available.

This bug report was last modified 2 years and 242 days ago.

Previous Next


GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson.