GNU bug report logs - #11728
24.1.50; vc-pull inconsistent behavior

Message received at submit <at> debbugs.gnu.org:

Received: (at submit) by debbugs.gnu.org; 17 Jun 2012 17:59:22 +0000
From debbugs-submit-bounces <at> debbugs.gnu.org Sun Jun 17 13:59:22 2012
Received: from localhost ([127.0.0.1]:46044 helo=debbugs.gnu.org)
	by debbugs.gnu.org with esmtp (Exim 4.72)
	(envelope-from <debbugs-submit-bounces <at> debbugs.gnu.org>)
	id 1SgJkv-0006wv-DS
	for submit <at> debbugs.gnu.org; Sun, 17 Jun 2012 13:59:22 -0400
Received: from eggs.gnu.org ([208.118.235.92]:35900)
	by debbugs.gnu.org with esmtp (Exim 4.72)
	(envelope-from <sam.steingold@HIDDEN>) id 1SgJkt-0006wo-LT
	for submit <at> debbugs.gnu.org; Sun, 17 Jun 2012 13:59:20 -0400
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <sam.steingold@HIDDEN>) id 1SgJhm-0006hL-QY
	for submit <at> debbugs.gnu.org; Sun, 17 Jun 2012 13:56:08 -0400
X-Spam-Checker-Version: SpamAssassin 3.3.2 (2011-06-06) on eggs.gnu.org
X-Spam-Level: 
X-Spam-Status: No, score=-4.8 required=5.0 tests=BAYES_00,FREEMAIL_FROM,
	RCVD_IN_DNSWL_HI,RCVD_IN_XBL,T_DKIM_INVALID,URIBL_BLACK autolearn=ham
	version=3.3.2
Received: from lists.gnu.org ([208.118.235.17]:55999)
	by eggs.gnu.org with esmtp (Exim 4.71)
	(envelope-from <sam.steingold@HIDDEN>) id 1SgJhm-0006hC-Kb
	for submit <at> debbugs.gnu.org; Sun, 17 Jun 2012 13:56:06 -0400
Received: from eggs.gnu.org ([208.118.235.92]:48102)
	by lists.gnu.org with esmtp (Exim 4.71)
	(envelope-from <sam.steingold@HIDDEN>) id 1SgJhk-00074e-KW
	for bug-gnu-emacs@HIDDEN; Sun, 17 Jun 2012 13:56:06 -0400
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <sam.steingold@HIDDEN>) id 1SgJhi-0006gW-Qh
	for bug-gnu-emacs@HIDDEN; Sun, 17 Jun 2012 13:56:04 -0400
Received: from mail-qc0-f169.google.com ([209.85.216.169]:35883)
	by eggs.gnu.org with esmtp (Exim 4.71)
	(envelope-from <sam.steingold@HIDDEN>)
	id 1SgJhe-0006fE-LB; Sun, 17 Jun 2012 13:55:58 -0400
Received: by qcsd16 with SMTP id d16so2933377qcs.0
	for <multiple recipients>; Sun, 17 Jun 2012 10:55:56 -0700 (PDT)
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20120113;
	h=sender:from:to:subject:return-receipt-to:reply-to:x-attribution
	:x-disclaimer:date:message-id:mime-version:content-type;
	bh=a8/eBEsRel/qEifeGoQqac+DHjF9RH72b4lmjCnwI4o=;
	b=ken6OWI8AixioGb72DAaqONfakg4L1EXPeLRdrtqG5xhDqUcela+pHYQXEH2kG/qKH
	j2AgC90tWP51Zm4U40+5MSpFPPBA1IOiU+nIafZu2J3Uy4GnO2XTUTTYNf9sKfg8J9YF
	kImkcp9w0oBOOlJBXwPmXN3IfPKMJqYRILGEg++FWJDZhefGRsOgo1qEqrX4/pfVG6e+
	yDWNtwI04l5vue+Hvbf9vDG3TEhnfUXiTZ0jw0xhULbtMiF6GZEPTtitdIAUOlBfel11
	CJjNqSflFKfmsULpyYYR2XCJIRVauwhVBw26GVb6Sf6hKlQ0hWJYdWH3hy606pkYLVcY
	z1xg==
Received: by 10.229.134.199 with SMTP id k7mr6642738qct.4.1339955755673;
	Sun, 17 Jun 2012 10:55:55 -0700 (PDT)
Received: from t520sds (cl-pat-tr.clearspring.com. [8.18.54.254])
	by mx.google.com with ESMTPS id gy5sm36121673qab.3.2012.06.17.10.55.54
	(version=TLSv1/SSLv3 cipher=OTHER);
	Sun, 17 Jun 2012 10:55:55 -0700 (PDT)
From: Sam Steingold <sds@HIDDEN>
To: bug-gnu-emacs@HIDDEN
Subject: 24.1.50; vc-pull inconsistent behavior
X-Attribution: Sam
X-Disclaimer: You should not expect anyone to agree with me.
Date: Sun, 17 Jun 2012 13:55:53 -0400
Message-ID: <87lijlddqu.fsf@HIDDEN>
MIME-Version: 1.0
Content-Type: text/plain
X-detected-operating-system: by eggs.gnu.org: Genre and OS details not
	recognized.
X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.6 (newer, 3)
X-Received-From: 208.118.235.17
X-Spam-Score: -4.4 (----)
X-Debbugs-Envelope-To: submit
X-BeenThere: debbugs-submit <at> debbugs.gnu.org
X-Mailman-Version: 2.1.13
Precedence: list
Reply-To: sds@HIDDEN
List-Id: <debbugs-submit.debbugs.gnu.org>
List-Unsubscribe: <http://debbugs.gnu.org/cgi-bin/mailman/options/debbugs-submit>,
	<mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=unsubscribe>
List-Archive: <http://debbugs.gnu.org/cgi-bin/mailman/private/debbugs-submit>
List-Post: <mailto:debbugs-submit <at> debbugs.gnu.org>
List-Help: <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=help>
List-Subscribe: <http://debbugs.gnu.org/cgi-bin/mailman/listinfo/debbugs-submit>,
	<mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=subscribe>
Sender: debbugs-submit-bounces <at> debbugs.gnu.org
Errors-To: debbugs-submit-bounces <at> debbugs.gnu.org
X-Spam-Score: -4.4 (----)

In GNU Emacs 24.1.50.1 (x86_64-unknown-linux-gnu, X toolkit, Xaw3d scroll bars)
 of 2012-06-14 on t520sds
Bzr revision: 108611 sds@HIDDEN
Windowing system distributor `The X.Org Foundation', version 11.0.11103000
Configured using:
 `configure '--with-wide-int''

when I do '+' in a vc-dir buffer, the behavior is inconsistent across
different backends;
1. svn: a bunch of messages in the *Messages* buffer/echo area, then the
changed files (if any) are present in the vc-dir buffer
2. bzr: a separate *vc-bzr: ...* buffer in compilation mode; changed
files are clickable there (but they do not appear in the vc-dir buffer)
3. hg, git: like bzr, but the new buffer is in fundamental mode and the
modified files are not clickable.

it would be nice if the interface were consistent, preferably in the svn
version to avoid creating a new buffer.

however, even the bzr version is much better than the hg/git one.
one simple was to unification is rename vc-bzr-error-regex-alist to
vc-bzr-error-regexp-alist for consistency with
compilation-error-regexp-alist and make it a vc backend symbol.
then call something based on

(with-current-buffer buf
	(vc-exec-after
	 `(progn
	    (let ((compilation-error-regexp-alist
		   vc-bzr-error-regexp-alist))
	      (compilation-mode))
	    (set (make-local-variable 'compilation-error-regexp-alist)
		 vc-bzr-error-regexp-alist))))

in vc.el, not each individual backend file.

-- 
Sam Steingold (http://sds.podval.org/) on Ubuntu 12.04 (precise) X 11.0.11103000
http://www.childpsy.net/ http://honestreporting.com http://memri.org
http://openvotingconsortium.org http://truepeace.org http://dhimmi.com
Sex is like air.  It's only a big deal if you can't get any.